From: Russell King - ARM Linux admin <li...@armlinux.org.uk> Date: Jun/05/2020, 18:10:34 (UTC+00:00)
> This is incorrect - you should not mask the link partner's advertisement > with our advertisement like this; consider the table in 802.3 for > resolving the pause modes, where simply doing a bitwise-and operation > between the two advertisements would severely restrict the resulting > resolution to either symmetric pause or nothing at all. > > You want to do this when you resolve the speed, but only _temporarily_ > in order to resolve the speed - you do not want to write back the > result to state->lp_advertising. Thanks for bringing this up. Indeed I believe I did this in order to resolve the speed, as you said. > You may wish to fix that. Added to the list of my pending fixes. Thanks! --- Thanks, Jose Miguel Abreu
