Re: [PATCH net] net: flow_offload: Fix UBSAN invalid-load warning in tcf_block_unbind

2021-04-20 Thread Jianbo Liu
The 04/09/2021 09:01, Jakub Kicinski wrote: > On Fri, 9 Apr 2021 06:25:56 +0000 Jianbo Liu wrote: > > The 04/08/2021 14:16, Jakub Kicinski wrote: > > > On Thu, 8 Apr 2021 07:47:18 + Jianbo Liu wrote: > > > > When device is removed, indirect block

Re: [PATCH net] net: flow_offload: Fix UBSAN invalid-load warning in tcf_block_unbind

2021-04-11 Thread Jianbo Liu
The 04/09/2021 09:01, Jakub Kicinski wrote: > On Fri, 9 Apr 2021 06:25:56 +0000 Jianbo Liu wrote: > > The 04/08/2021 14:16, Jakub Kicinski wrote: > > > On Thu, 8 Apr 2021 07:47:18 + Jianbo Liu wrote: > > > > When device is removed, indirect block

Re: [PATCH net] net: flow_offload: Fix UBSAN invalid-load warning in tcf_block_unbind

2021-04-08 Thread Jianbo Liu
The 04/08/2021 14:16, Jakub Kicinski wrote: > On Thu, 8 Apr 2021 07:47:18 +0000 Jianbo Liu wrote: > > When device is removed, indirect block is unregisterd. As > > bo->unlocked_driver_cb is not initialized, the following UBSAN is > > triggered. > > > > UBSAN:

[PATCH net] net: flow_offload: Fix UBSAN invalid-load warning in tcf_block_unbind

2021-04-08 Thread Jianbo Liu
device's indr block bind callback, and unlocked_driver_cb is assigned with correct value. Fixes: 0fdcf78d5973 ("net: use flow_indr_dev_setup_offload()") Signed-off-by: Jianbo Liu Reviewed-by: Roi Dayan --- include/net/flow_offload.h | 11 ++- net/core/flow_offload.c|

Re: [PATCH mlx5-next 05/15] net/mlx5: E-Switch, Tag packet with vport number in VF vports and uplink ingress ACLs

2019-06-19 Thread Jianbo Liu
tdev@vger.kernel.org; linux-r...@vger.kernel.org; Jianbo Liu > > ; Eli Britstein ; Roi Dayan > > ; Mark Bloch > > Subject: [PATCH mlx5-next 05/15] net/mlx5: E-Switch, Tag packet with vport > > number in VF vports and uplink ingress ACLs > > > > From: Jianbo Liu

Re: [PATCH mlx5-next 05/15] net/mlx5: E-Switch, Tag packet with vport number in VF vports and uplink ingress ACLs

2019-06-18 Thread Jianbo Liu
The 06/19/2019 13:42, Parav Pandit wrote: > > > > -Original Message- > > From: Jianbo Liu > > Sent: Wednesday, June 19, 2019 10:42 AM > > To: Parav Pandit > > Cc: Saeed Mahameed ; Leon Romanovsky > > ; netdev@vger.kernel.org; linux- > >

Re: [PATCH mlx5-next 11/15] RDMA/mlx5: Add vport metadata matching for IB representors

2019-06-18 Thread Jianbo Liu
The 06/19/2019 13:04, Leon Romanovsky wrote: > On Wed, Jun 19, 2019 at 04:44:26AM +0000, Jianbo Liu wrote: > > The 06/18/2019 18:19, Leon Romanovsky wrote: > > > On Mon, Jun 17, 2019 at 07:23:30PM +, Saeed Mahameed wrote: > > > > From: Jianbo Liu > > >

Re: [PATCH mlx5-next 05/15] net/mlx5: E-Switch, Tag packet with vport number in VF vports and uplink ingress ACLs

2019-06-18 Thread Jianbo Liu
tdev@vger.kernel.org; linux-r...@vger.kernel.org; Jianbo Liu > > ; Eli Britstein ; Roi Dayan > > ; Mark Bloch > > Subject: [PATCH mlx5-next 05/15] net/mlx5: E-Switch, Tag packet with vport > > number in VF vports and uplink ingress ACLs > > > > From: Jianbo Liu

Re: [PATCH mlx5-next 11/15] RDMA/mlx5: Add vport metadata matching for IB representors

2019-06-18 Thread Jianbo Liu
The 06/18/2019 18:19, Leon Romanovsky wrote: > On Mon, Jun 17, 2019 at 07:23:30PM +, Saeed Mahameed wrote: > > From: Jianbo Liu > > > > If vport metadata matching is enabled in eswitch, the rule created > > must be changed to match on the metadata, instead of sour

[PATCH] net/mlx5e: Fix calling wrong function to get inner vlan key and mask

2019-05-14 Thread Jianbo Liu
commit fixes this by changing to call flow_rule_match_cvlan() after it's added. Fixes: 8f2566225ae2 ("flow_offload: add flow_rule and flow_match structures and use them") Signed-off-by: Jianbo Liu --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +- 1 file changed, 1 insertion

Re: [RFC PATCH net-next 3/3] flow_offload: support CVLAN match

2019-05-14 Thread Jianbo Liu
The 05/13/2019 14:28, Edward Cree wrote: > On 13/05/2019 13:54, Jianbo Liu wrote: > > Could you please push to 5.1 and 5.0-stable? The original patch brought a > > bug > > in mlx5_core driver. Need your patch to fix. > > > > --- a/drivers/net/ethernet/mellanox/ml

Re: [RFC PATCH net-next 3/3] flow_offload: support CVLAN match

2019-05-13 Thread Jianbo Liu
The 05/03/2019 16:08, Edward Cree wrote: > Plumb it through from the flow_dissector. > > Signed-off-by: Edward Cree > --- > include/net/flow_offload.h | 2 ++ > net/core/flow_offload.c| 7 +++ > 2 files changed, 9 insertions(+) > > diff --git a/include/net/flow_offload.h b/include/net/f

[PATCH net-next] net/sched: cls_flower: Use correct inline function for assignment of vlan tpid

2018-07-24 Thread Jianbo Liu
Signed-off-by: Jianbo Liu Reported-by: Or Gerlitz Reviewed-by: Or Gerlitz --- net/sched/cls_flower.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index c53fdd4..1d8559d 100644 --- a/net/sched/cls_flower.c +++ b/net/sched

[PATCH net-next] net/sched: flower: Fix null pointer dereference when run tc vlan command

2018-07-08 Thread Jianbo Liu
Add supprt for matching on QinQ vlan headers') Signed-off-by: Jianbo Liu Reported-by: Zahari Doychev --- net/sched/cls_flower.c | 48 ++-- 1 file changed, 26 insertions(+), 22 deletions(-) diff --git a/net/sched/cls_flower.c b/net/sched/cls

Re: [PATCH v2 net-next 5/5] net/sched: flower: Add supprt for matching on QinQ vlan headers

2018-07-08 Thread Jianbo Liu
The 07/08/2018 12:27, Zahari, Doychev wrote: > On Fri, Jul 06, 2018 at 05:38:16AM +0000, Jianbo Liu wrote: > > As support dissecting of QinQ inner and outer vlan headers, user can > > add rules to match on QinQ vlan headers. > > > > Signed-off-by: Jianbo Li

[PATCH v2 net-next 1/5] net/flow_dissector: Save vlan ethertype from headers

2018-07-05 Thread Jianbo Liu
Change vlan dissector key to save vlan tpid to support both 802.1Q and 802.1AD ethertype. Signed-off-by: Jianbo Liu Acked-by: Jiri Pirko --- include/net/flow_dissector.h | 2 +- net/core/flow_dissector.c| 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/net

[PATCH v2 net-next 2/5] net/sched: flower: Add support for matching on vlan ethertype

2018-07-05 Thread Jianbo Liu
As flow dissector stores vlan ethertype, tc flower now can match on that. It is to make preparation for supporting QinQ. Signed-off-by: Jianbo Liu Acked-by: Jiri Pirko --- net/sched/cls_flower.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/sched/cls_flower.c b

[PATCH v2 net-next 5/5] net/sched: flower: Add supprt for matching on QinQ vlan headers

2018-07-05 Thread Jianbo Liu
As support dissecting of QinQ inner and outer vlan headers, user can add rules to match on QinQ vlan headers. Signed-off-by: Jianbo Liu Acked-by: Jiri Pirko --- include/uapi/linux/pkt_cls.h | 4 +++ net/sched/cls_flower.c | 65 ++-- 2 files

[PATCH v2 net-next 4/5] net/sched: flower: Dump the ethertype encapsulated in vlan

2018-07-05 Thread Jianbo Liu
Currently the encapsulated ethertype is not dumped as it's the same as TCA_FLOWER_KEY_ETH_TYPE keyvalue. But the dumping result is inconsistent with input, we add dumping it with TCA_FLOWER_KEY_VLAN_ETH_TYPE. Signed-off-by: Jianbo Liu Acked-by: Jiri Pirko --- net/sched/cls_flower.c | 4 ++

[PATCH v2 net-next 3/5] net/flow_dissector: Add support for QinQ dissection

2018-07-05 Thread Jianbo Liu
Dissect the QinQ packets to get both outer and inner vlan information, then store to the extended flow keys. Signed-off-by: Jianbo Liu Acked-by: Jiri Pirko --- include/net/flow_dissector.h | 2 ++ net/core/flow_dissector.c| 32 +--- 2 files changed, 19

[PATCH v2 net-next 0/5] Introduce matching on double vlan/QinQ headers for TC flower

2018-07-05 Thread Jianbo Liu
ef 33 flower chain 0 filter protocol 802.1ad pref 33 flower chain 0 handle 0x1 vlan_id 1000 vlan_ethtype 802.1Q cvlan_id 100 cvlan_ethtype ip eth_type ipv4 in_hw ... v2: fix sparse warning. Jianbo Liu (5): net/flow_dissector: Save vlan ethertype from headers net/sched: flower

[PATCH iproute2/net-next] tc: flower: Add support for QinQ

2018-06-30 Thread Jianbo Liu
  in_hw Signed-off-by: Jianbo Liu Acked-by: Jiri Pirko --- include/uapi/linux/pkt_cls.h | 4 ++ man/man8/tc-flower.8 | 23 ++ tc/f_flower.c| 103 ++- 3 files changed, 118 insertions(+), 12 deletions(-) diff --git a/include

[PATCH net-next 4/5] net/sched: flower: Dump the ethertype encapsulated in vlan

2018-06-30 Thread Jianbo Liu
Currently the encapsulated ethertype is not dumped as it's the same as TCA_FLOWER_KEY_ETH_TYPE keyvalue. But the dumping result is inconsistent with input, we add dumping it with TCA_FLOWER_KEY_VLAN_ETH_TYPE. Signed-off-by: Jianbo Liu Acked-by: Jiri Pirko --- net/sched/cls_flower.c | 4 ++

[PATCH net-next 2/5] net/sched: flower: Add support for matching on vlan ethertype

2018-06-30 Thread Jianbo Liu
As flow dissector stores vlan ethertype, tc flower now can match on that. It is to make preparation for supporting QinQ. Signed-off-by: Jianbo Liu Acked-by: Jiri Pirko --- net/sched/cls_flower.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/sched/cls_flower.c b

[PATCH net-next 5/5] net/sched: flower: Add supprt for matching on QinQ vlan headers

2018-06-30 Thread Jianbo Liu
As support dissecting of QinQ inner and outer vlan headers, user can add rules to match on QinQ vlan headers. Signed-off-by: Jianbo Liu Acked-by: Jiri Pirko --- include/uapi/linux/pkt_cls.h | 4 +++ net/sched/cls_flower.c | 65 ++-- 2 files

[PATCH net-next 3/5] net/flow_dissector: Add support for QinQ dissection

2018-06-30 Thread Jianbo Liu
Dissect the QinQ packets to get both outer and inner vlan information, then store to the extended flow keys. Signed-off-by: Jianbo Liu Acked-by: Jiri Pirko --- include/net/flow_dissector.h | 2 ++ net/core/flow_dissector.c| 32 +--- 2 files changed, 19

[PATCH net-next 0/5] Introduce matching on double vlan/QinQ headers for TC flower

2018-06-30 Thread Jianbo Liu
ef 33 flower chain 0 filter protocol 802.1ad pref 33 flower chain 0 handle 0x1 vlan_id 1000 vlan_ethtype 802.1Q cvlan_id 100 cvlan_ethtype ip eth_type ipv4 in_hw ... Jianbo Liu (5): net/flow_dissector: Save vlan ethertype from headers net/sched: flower: Add support for matching on

[PATCH net-next 1/5] net/flow_dissector: Save vlan ethertype from headers

2018-06-30 Thread Jianbo Liu
Change vlan dissector key to save vlan tpid to support both 802.1Q and 802.1AD ethertype. Signed-off-by: Jianbo Liu Acked-by: Jiri Pirko --- include/net/flow_dissector.h | 2 +- net/core/flow_dissector.c| 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/net