The 06/18/2019 18:19, Leon Romanovsky wrote:
> On Mon, Jun 17, 2019 at 07:23:30PM +0000, Saeed Mahameed wrote:
> > From: Jianbo Liu <jian...@mellanox.com>
> >
> > If vport metadata matching is enabled in eswitch, the rule created
> > must be changed to match on the metadata, instead of source port.
> >
> > Signed-off-by: Jianbo Liu <jian...@mellanox.com>
> > Reviewed-by: Roi Dayan <r...@mellanox.com>
> > Reviewed-by: Mark Bloch <ma...@mellanox.com>
> > Signed-off-by: Saeed Mahameed <sae...@mellanox.com>
> > ---
> > drivers/infiniband/hw/mlx5/ib_rep.c | 11 +++++++
> > drivers/infiniband/hw/mlx5/ib_rep.h | 16 ++++++++++
> > drivers/infiniband/hw/mlx5/main.c | 45 +++++++++++++++++++++++------
> > 3 files changed, 63 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/mlx5/ib_rep.c
> > b/drivers/infiniband/hw/mlx5/ib_rep.c
> > index 22e651cb5534..d4ed611de35d 100644
> > --- a/drivers/infiniband/hw/mlx5/ib_rep.c
> > +++ b/drivers/infiniband/hw/mlx5/ib_rep.c
> > @@ -131,6 +131,17 @@ struct mlx5_eswitch_rep *mlx5_ib_vport_rep(struct
> > mlx5_eswitch *esw, int vport)
> > return mlx5_eswitch_vport_rep(esw, vport);
> > }
> >
> > +u32 mlx5_ib_eswitch_vport_match_metadata_enabled(struct mlx5_eswitch *esw)
> > +{
> > + return mlx5_eswitch_vport_match_metadata_enabled(esw);
> > +}
> > +
> > +u32 mlx5_ib_eswitch_get_vport_metadata_for_match(struct mlx5_eswitch *esw,
> > + u16 vport)
> > +{
> > + return mlx5_eswitch_get_vport_metadata_for_match(esw, vport);
> > +}
>
> 1. There is no need to introduce one line functions, call to that code
> directly.
No. They are in IB, and we don't want them be mixed up by the original
functions in eswitch. Please ask Mark more about it.
> 2. It should be bool and not u32.
>
> Thanks
--
