> -Original Message-
> From: Andrew Lunn
> Sent: Wednesday, August 28, 2019 2:53 PM
> To: Ioana Ciocoi Radulescu
> Cc: netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei
>
> Subject: Re: [PATCH net-next v2 3/3] dpaa2-eth: Add pause frame support
>
>
> -Original Message-
> From: Andrew Lunn
> Sent: Wednesday, August 28, 2019 2:22 AM
> To: Ioana Ciocoi Radulescu
> Cc: netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei
>
> Subject: Re: [PATCH net-next v2 3/3] dpaa2-eth: Add pause frame support
>
>
> -Original Message-
> From: Andrew Lunn
> Sent: Friday, August 23, 2019 7:31 PM
> To: Ioana Ciocoi Radulescu
> Cc: netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei
>
> Subject: Re: [PATCH net-next] dpaa2-eth: Add pause frame support
>
> > --- a/
> -Original Message-
> From: Edward Cree
> Sent: Friday, August 9, 2019 8:32 PM
> To: Ioana Ciocoi Radulescu
> Cc: David Miller ; netdev ;
> Eric Dumazet ; linux-net-driv...@solarflare.com
> Subject: Re: [PATCH v3 net-next 0/3] net: batched receive in GRO path
>
> -Original Message-
> From: netdev-ow...@vger.kernel.org On
> Behalf Of Edward Cree
> Sent: Tuesday, August 6, 2019 4:52 PM
> To: David Miller
> Cc: netdev ; Eric Dumazet
> ; linux-net-driv...@solarflare.com
> Subject: [PATCH v3 net-next 0/3] net: batched receive in GRO path
>
> This se
> -Original Message-
> From: David Miller
> Sent: Wednesday, July 24, 2019 12:03 AM
> To: Ioana Ciocoi Radulescu
> Cc: netdev@vger.kernel.org; Ioana Ciornei ; Vladimir
> Oltean
> Subject: Re: [PATCH net-next] dpaa2-eth: Don't use netif_receive_skb_list for
>
> -Original Message-
> From: David Miller
> Sent: Thursday, June 6, 2019 9:03 PM
> To: Ioana Ciocoi Radulescu
> Cc: netdev@vger.kernel.org; Ioana Ciornei
> Subject: Re: [PATCH net-next v2 2/3] dpaa2-eth: Support multiple traffic
> classes on Tx
>
> From: I
> -Original Message-
> From: David Miller
> Sent: Thursday, June 6, 2019 4:46 AM
> To: Ioana Ciocoi Radulescu
> Cc: netdev@vger.kernel.org; Ioana Ciornei
> Subject: Re: [PATCH net-next 2/3] dpaa2-eth: Support multiple traffic classes
> on Tx
>
> From: Ioana
> -Original Message-
> From: Sebastian Andrzej Siewior
> Sent: Thursday, May 30, 2019 1:15 AM
> To: netdev@vger.kernel.org
> Cc: t...@linutronix.de; David S. Miller ; Sebastian
> Andrzej Siewior ; Ioana Ciocoi Radulescu
>
> Subject: [PATCH net-next 4/7] dpaa2-
> -Original Message-
> From: Sebastian Andrzej Siewior
> Sent: Thursday, May 30, 2019 1:15 AM
> To: netdev@vger.kernel.org
> Cc: t...@linutronix.de; David S. Miller ; Sebastian
> Andrzej Siewior ; Ioana Ciocoi Radulescu
>
> Subject: [PATCH net-next 3/7] dpaa2-eth
Add two macros to simplify reading DPNI options.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 3 +--
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 6 ++
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale
On DPAA2 platforms that lack a TCAM (like LS1088A), masking of
flow steering keys is not supported. Until now we didn't offer
flow steering capabilities at all on these platforms.
Introduce a limited support for flow steering, where we only
allow ethtool rules that share a common key (i.e. have th
On platforms that lack a TCAM (like LS1088A), masking of
flow steering keys is not supported. Until now we didn't
offer flow steering capabilities at all on these platforms,
since our driver implementation configured a "comprehensive"
FS key (containing all supported header fields), with masks
used
Set the Rx flow classification enable flag only if key config
operation is successful.
Fixes 3f9b5c9 ("dpaa2-eth: Configure Rx flow classification key")
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-
Introduce an internal id bitfield to uniquely identify header fields
supported by the Rx distribution keys. For the hash key, add a
conversion from the RXH_* bitmask provided by ethtool to the internal
ids.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 19
> -Original Message-
> From: Jesper Dangaard Brouer
> Sent: Sunday, March 24, 2019 8:29 PM
> To: Ioana Ciocoi Radulescu
> Cc: netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei
> ; bro...@redhat.com
> Subject: Re: [PATCH net] dpaa2-eth: Fix possible acces
> -Original Message-
> From: David Miller
> Sent: Thursday, March 21, 2019 1:29 AM
> To: Ioana Ciocoi Radulescu
> Cc: netdev@vger.kernel.org; Ioana Ciornei ;
> bro...@redhat.com
> Subject: Re: [PATCH net] dpaa2-eth: Fix possible access beyond end of array
&g
Make sure we don't try to enqueue XDP_REDIRECT frames to an
inexistent FQ.
While it is guaranteed not to have more than one queue per core,
having fewer queues than CPUs on an interface is a valid
configuration.
Fixes: d678be1dc1ec ("dpaa2-eth: add XDP_REDIRECT support")
Reported-by: Jesper Danga
> -Original Message-
> From: Jesper Dangaard Brouer
> Sent: Monday, March 4, 2019 2:30 PM
> To: Ioana Ciornei
> Cc: netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciocoi Radulescu
> ; ilias.apalodi...@linaro.org;
> t...@redhat.com; bro...@redhat.com
> Su
> -Original Message-
> From: Ilias Apalodimas
> Sent: Tuesday, February 5, 2019 11:35 AM
> To: Ioana Ciocoi Radulescu
> Cc: netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei
> ; bro...@redhat.com
> Subject: Re: [PATCH net-next 1/4] dpaa2-eth: Use a sing
Add more buffers to the Rx buffer pool as soon as 7 of them
get consumed, instead of waiting for their number to drop
below a fixed threshold.
7 is the number of buffers that can be released in the pool
via a single DPIO command.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/
Starting with MC10.14.0, dpaa2_io_service_enqueue_fq() API is
functional. Since there are a number of cases where it offers
better performance compared to the currently used enqueue
function, switch to it for firmware versions that support it.
Signed-off-by: Ioana Radulescu
---
drivers/net/ether
First patch moves the driver to a page-per-frame memory model.
The others are minor tweaks and optimizations.
Ioana Radulescu (4):
dpaa2-eth: Use a single page per Rx buffer
dpaa2-eth: Use napi_consume_skb()
dpaa2-eth: Use FQ-based DPIO enqueue API
dpaa2-eth: Update buffer pool refill thre
While in NAPI context, free skbs by calling napi_consume_skb()
instead of dev_kfree_skb(), to take advantage of the bulk freeing
mechanism.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --gi
Instead of allocating page fragments via the network stack,
use the page allocator directly. For now, we consume one page
for each Rx buffer.
With the new memory model we are free to consider adding more
XDP support.
Performance decreases slightly in some IP forwarding cases.
No visible effect on
In the current implementation, on interface down we disabled NAPI and
then manually drained any remaining ingress frames. This could lead
to a situation when, under heavy traffic, the data availability
notification for some of the channels would not get rearmed correctly.
Change the implementation
> -Original Message-
> From: Ilias Apalodimas
> Sent: Monday, January 7, 2019 12:45 PM
> To: Ioana Ciocoi Radulescu
> Cc: Jesper Dangaard Brouer ;
> netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei
> ; dsah...@gmail.com; Camelia Alexandra Groza
>
>
> -Original Message-
> From: Jesper Dangaard Brouer
> Sent: Friday, December 21, 2018 5:31 PM
> To: Ioana Ciocoi Radulescu
> Cc: Ilias Apalodimas ; netdev@vger.kernel.org;
> da...@davemloft.net; Ioana Ciornei ;
> dsah...@gmail.com; Camelia Alexandra Groza ;
> bro
> -Original Message-
> From: Horia Geanta
> Sent: Friday, December 14, 2018 4:45 PM
> To: Ioana Ciornei ; Leo Li ;
> linux-ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> netdev@vger.kernel.org
> Cc: Laurentiu Tudor ; Ioana Ciocoi Radulescu
> ; R
> -Original Message-
> From: Ioana Ciocoi Radulescu
> Sent: Friday, December 7, 2018 8:08 PM
> To: 'Ilias Apalodimas'
> Cc: Jesper Dangaard Brouer ;
> netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei
> ; dsah...@gmail.com; Camelia Alexandra Groza
> -Original Message-
> From: Ilias Apalodimas
> Sent: Friday, December 7, 2018 7:52 PM
> To: Ioana Ciocoi Radulescu
> Cc: Jesper Dangaard Brouer ;
> netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei
> ; dsah...@gmail.com; Camelia Alexandra Groza
>
>
> -Original Message-
> From: Ilias Apalodimas
> Sent: Friday, December 7, 2018 7:20 PM
> To: Ioana Ciocoi Radulescu
> Cc: Jesper Dangaard Brouer ;
> netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei
> ; dsah...@gmail.com; Camelia Alexandra Groza
>
> -Original Message-
> From: Jesper Dangaard Brouer
> Sent: Wednesday, December 5, 2018 5:45 PM
> To: Ioana Ciocoi Radulescu
> Cc: bro...@redhat.com; netdev@vger.kernel.org; da...@davemloft.net;
> Ioana Ciornei ; dsah...@gmail.com; Camelia
> Alexandra Gro
Add comments in the switch statement for XDP action to indicate
fallthrough is intended.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
b/drivers/net/ether
> -Original Message-
> From: David Miller
> Sent: Wednesday, November 28, 2018 2:25 AM
> To: Ioana Ciocoi Radulescu
> Cc: netdev@vger.kernel.org; Ioana Ciornei ;
> dsah...@gmail.com; Camelia Alexandra Groza
> Subject: Re: [PATCH v2 net-next 0/8] dpaa2-eth:
Send frames back on the same port for XDP_TX action.
Since the frame buffers have been allocated by us, we can recycle
them directly into the Rx buffer pool instead of requesting a
confirmation frame upon transmission complete.
Signed-off-by: Ioana Radulescu
---
v2: XDP_TX packets count towards t
Reserve XDP_PACKET_HEADROOM bytes in Rx buffers to allow XDP
programs to increase frame header size.
Signed-off-by: Ioana Radulescu
---
v2: no changes
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 43 ++--
1 file changed, 40 insertions(+), 3 deletions(-)
diff --git a/d
Remove unused counter. Reorder fields in channel stats structure
to match the ethtool strings order and make it easier to print them
with ethtool -S.
Signed-off-by: Ioana Radulescu
---
v2: no changes
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 1 -
drivers/net/ethernet/freescale/dpa
We'll use function free_bufs() on the XDP path as well, so move
it higher in order to avoid a forward declaration.
Signed-off-by: Ioana Radulescu
---
v2: no changes
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 34
1 file changed, 17 insertions(+), 17 deletions(-)
In order to support enqueueing Rx FDs back to hardware, we need to
DMA map Rx buffers as bidirectional.
Signed-off-by: Ioana Radulescu
---
v2: no changes
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/n
Add counters for xdp processed frames to the channel statistics.
Signed-off-by: Ioana Radulescu
---
v2: no changes
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 3 +++
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 4
drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c |
Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX
actions are supported for now. Frame header changes are also
allowed.
v2: - count the XDP packets in the rx/tx inteface stats
- add message with the maximum supported MTU value for XDP
Ioana Radulescu (8):
dpaa2-eth: Add basic
Instead of freeing the RX buffers, release them back into the pool.
We wait for the maximum number of buffers supported by a single
release command to accumulate before issuing the command.
Also, don't unmap the Rx buffers at the beginning of the Rx routine
anymore, since that would require remapp
We keep one XDP program reference per channel. The only actions
supported for now are XDP_DROP and XDP_PASS.
Until now we didn't enforce a maximum size for Rx frames based
on MTU value. Change that, since for XDP mode we must ensure no
scatter-gather frames can be received.
Signed-off-by: Ioana R
> -Original Message-
> From: David Ahern
> Sent: Saturday, November 24, 2018 11:49 PM
> To: Ioana Ciocoi Radulescu ;
> netdev@vger.kernel.org; da...@davemloft.net
> Cc: Ioana Ciornei
> Subject: Re: [PATCH net-next 1/8] dpaa2-eth: Add basic XDP support
>
>
Send frames back on the same port for XDP_TX action.
Since the frame buffers have been allocated by us, we can recycle
them directly into the Rx buffer pool instead of requesting a
confirmation frame upon transmission complete.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dp
Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX
actions are supported for now. Frame header changes are also
allowed.
Ioana Radulescu (8):
dpaa2-eth: Add basic XDP support
dpaa2-eth: Allow XDP header adjustments
dpaa2-eth: Move function
dpaa2-eth: Release buffers back to p
We keep one XDP program reference per channel. The only actions
supported for now are XDP_DROP and XDP_PASS.
Until now we didn't enforce a maximum size for Rx frames based
on MTU value. Change that, since for XDP mode we must ensure no
scatter-gather frames can be received.
Signed-off-by: Ioana R
Remove one unused counter. Move the Tx portal busy counter to
the channel stats, since it logically belongs here.
Reorder fields in channel stats structure to match the ethtool
strings order and make it easier to print them with ethtool -S.
Signed-off-by: Ioana Radulescu
---
drivers/net/etherne
In order to support enqueueing Rx FDs back to hardware, we need to
DMA map Rx buffers as bidirectional.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/free
Instead of freeing the RX buffers, release them back into the pool.
We wait for the maximum number of buffers supported by a single
release command to accumulate before issuing the command.
Also, don't unmap the Rx buffers at the beginning of the Rx routine
anymore, since that would require remapp
Add counters for xdp processed frames to the channel statistics.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 7 ++-
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 4
drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c | 3 +++
3 fil
We'll use function free_bufs() on the XDP path as well, so move
it higher in order to avoid a forward declaration.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 34
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/dr
Reserve XDP_PACKET_HEADROOM bytes in Rx buffers to allow XDP
programs to increase frame header size.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 43 ++--
1 file changed, 40 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ether
Add support for byte queue limit.
On NAPI poll, we save the total number of Tx confirmed frames/bytes
and register them with bql at the end of the poll function.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 59 ++--
drivers/net/ethern
The DPNI object on which we build a network interface has a
certain number of {Rx, Tx, Tx confirmation} frame queues as
resources. The default hardware setup offers one queue of each
type, as well as one DPCON channel, for each core available
in the system.
There are however cases where the number
Change the frame consume callback signature:
* the entire FQ structure is passed to the callback instead
of just the queue index
* the NAPI structure can be easily obtained from the channel
it is associated to, so we don't need to pass it explicitly
Signed-off-by: Ioana Radulescu
---
drivers/net
The first two patches make minor tweaks to the driver to
simplify bql implementation. The third patch adds the actual
bql support.
Ioana Radulescu (3):
dpaa2-eth: Update callback signature
dpaa2-eth: Don't use multiple queues per channel
dpaa2-eth: bql support
drivers/net/ethernet/freescal
> -Original Message-
> From: David Miller
> Sent: Thursday, November 8, 2018 8:08 AM
> To: Ioana Ciocoi Radulescu
> Cc: netdev@vger.kernel.org; Ioana Ciornei
> Subject: Re: [PATCH net-next] dpaa2-eth: Introduce TX congestion
> management
>
> From: Ioana Cioco
DPAA2 hardware can be configured to signal when a set of queues
become congested (i.e., they accumulate a number of frames/bytes
larger than a configurable threshold).
Add the firmware API to control the congestion settings and use it
to enable congestion management on the TX path.
DPAA2 ethernet
Until now, both Rx and Tx confirmation frames handled during
NAPI poll were counted toward the NAPI budget. However, Tx
confirmations are lighter to process than Rx frames, which can
skew the amount of work actually done inside one NAPI cycle.
Update the code to only count Rx frames toward the NAP
Until now, the Rx flow hash key was a 5-tuple (IP src, IP dst,
IP nextproto, L4 src port, L4 dst port) fixed value that we
configured at probe.
Add support for configuring this hash key at runtime.
We support all standard header fields configurable through ethtool,
but cannot differentiate between
> -Original Message-
> From: Andrew Lunn [mailto:and...@lunn.ch]
> Sent: Thursday, April 5, 2018 6:24 PM
> To: Laurentiu Tudor
> Cc: Stuart Yoder ; Arnd Bergmann ;
> Ioana Ciornei ; gregkh
> ; Linux Kernel Mailing List ker...@vger.kernel.org>; Ruxandra Ioana Cio
63 matches
Mail list logo
