> -----Original Message----- > From: Andrew Lunn <and...@lunn.ch> > Sent: Wednesday, August 28, 2019 2:53 PM > To: Ioana Ciocoi Radulescu <ruxandra.radule...@nxp.com> > Cc: netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei > <ioana.cior...@nxp.com> > Subject: Re: [PATCH net-next v2 3/3] dpaa2-eth: Add pause frame support > > > Clearing the ASYM_PAUSE flag only means we tell the firmware we want > > both Rx and Tx pause to be enabled in the beginning. User can still set > > an asymmetric config (i.e. only Rx pause or only Tx pause to be enabled) > > if needed. > > > > The truth table is like this: > > > > PAUSE | ASYM_PAUSE | Rx pause | Tx pause > > ---------------------------------------- > > 0 | 0 | disabled | disabled > > 0 | 1 | disabled | enabled > > 1 | 0 | enabled | enabled > > 1 | 1 | enabled | disabled > > Hi Ioana > > Ah, that is not intuitive. Please add a comment, and maybe this table > to the commit message.
I think firmware tried to mirror the ASM_DIR bit (see http://www.ieee802.org/3/z/public/presentations/nov1996/asym.pdf), but I agree it's not really user friendly. Will add comment in v3. Thanks, Ioana
