> -----Original Message-----
> From: David Miller <da...@davemloft.net>
> Sent: Thursday, March 21, 2019 1:29 AM
> To: Ioana Ciocoi Radulescu <ruxandra.radule...@nxp.com>
> Cc: netdev@vger.kernel.org; Ioana Ciornei <ioana.cior...@nxp.com>;
> bro...@redhat.com
> Subject: Re: [PATCH net] dpaa2-eth: Fix possible access beyond end of array
> 
> From: Ioana Ciocoi Radulescu <ruxandra.radule...@nxp.com>
> Date: Wed, 20 Mar 2019 14:11:04 +0000
> 
> > Make sure we don't try to enqueue XDP_REDIRECT frames to an
> > inexistent FQ.
> >
> > While it is guaranteed not to have more than one queue per core,
> > having fewer queues than CPUs on an interface is a valid
> > configuration.
> >
> > Fixes: d678be1dc1ec ("dpaa2-eth: add XDP_REDIRECT support")
> > Reported-by: Jesper Dangaard Brouer <bro...@redhat.com>
> > Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
> 
> Applied, thanks.
> 
> I hope the modulus operation doesn't start showing up on profiles.

I haven't seen any performance impact on XDP_REDIRECT numbers.

Also, I think this patch should be added to stable as well, the bug it
fixes is quite ugly.

Thanks,
Ioana

Reply via email to