choose
> to make me do it and explain it to you instead.
Sorry, just matched the wrong pattern here :-)
Best Regards
Ingo Oeser
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
ces and modify
inet_twsk_put() to sth. like this:
static inline inet_twsk_put(struct inet_timewait_sock *tw)
{
kref_put(&tw->kref, inet_twsk_release);
}
David, can you see any reason (e.g. some crazy lock stuff) NOT to do this?
Best Regards
Ingo Oeser
--
To unsubscribe from this list: send th
!PRIVATE_10(a) &&
> !LINKLOCAL(a) &&
> !PRIVATE_172(a) &&
> !PRIVATE_192(a) &&
> !NETICDEVBENCH(a) &&
> !MULTICAST(a)) ? 2 : 0;
Oh, yes that's great! Now even *I* can read what this is all about
without reading any RFC :-)
Please Fred, try to do it that way.
Best Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
* @n: napi context
> + *
> + * Mnemonic: _p stands for "predicate", returning a yes/no
> + * answer to the question.
Call it "is_napi_enabled()" an nobody will ask :-)
> + */
> +static inline int napi_enabled_p(struct napi_struct *n)
And please make it return &q
y (eui+4, addr, 4);
> + return (0);
> +}
Nitpick:
"return" is not a function. Please write "return 0;" instead.
> +
> +static inline int ipv6_addr_is_isatap(const struct in6_addr *addr)
> +{
> + return (addr->s6_addr32[2] == __constant_
of the seconds outside the spinlock?
e.g.
tmp = get_seconds();
spin_lock_bh(&x->lock);
x->lastused = tmp;
spin_unlock_bh(&x->lock);
or is it not really worth it?
Best Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body o
invalid resource size (%lx != %x), check
> mpc52xx_devices.c\n",
> + " - invalid resource size (%lx < %x), check
> mpc52xx_devices.c\n",
> (unsigned long)(mem.end - mem.start + 1), sizeof(struct
> mpc52xx_fec));
>
y ok,
since mutexes can sleep, it is not desireable, since other users of that mutex
are blocked until the allocation is done.
If you are able to implement the "2 bytes of usbnet data buffer" version,
please ignore that mail :-)
Best Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Ingo Oeser schrieb:
> > +static void niu_init_xif(struct niu *);
> > +
> > +static int link_status_10g(struct niu *np, int *link_up_p)
> > +{
> > + unsigned long flags;
> > + int err, link_up;
> > +
> > + if (np->link_config.loopback_mode !
ink_up_p = link_up;
> + return 0;
> +}
[...]
> +static void niu_set_primary_mac(struct niu *np, unsigned char *addr)
> +{
> + u16 reg0 = addr[4] << 8 | addr[5];
> + u16 reg1 = addr[2] << 8 | addr[3];
> + u16 reg2 = addr[0] << 8 | addr[1];
> +
> + if (np->flags & NIU_FLAGS_XMAC) {
> + nw64_mac(XMAC_ADDR0, reg0);
> + nw64_mac(XMAC_ADDR1, reg1);
> + nw64_mac(XMAC_ADDR2, reg2);
> + } else {
> + nw64_mac(BMAC_ADDR0, reg0);
> + nw64_mac(BMAC_ADDR1, reg1);
> + nw64_mac(BMAC_ADDR2, reg2);
> + }
> +}
> +
> +static int niu_num_alt_addr(struct niu *np)
static int niu_num_alt_addr(const struct niu *np)
> +{
> + if (np->flags & NIU_FLAGS_XMAC)
> + return XMAC_NUM_ALT_ADDR;
> + else
> + return BMAC_NUM_ALT_ADDR;
> +}
> +
[...]
> +static void niu_set_max_burst(struct niu *np, struct tx_ring_info *rp)
> +{
> + int mtu = np->dev->mtu;
> +
> + rp->max_burst = mtu + 32;
> + if (rp->max_burst > 4096)
> + rp->max_burst = 4096;
Why 32 and 4096? (Magic values)
> +}
> +
... ok, I stop here, since this drivers is damn big :-)
Best Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Michael Chan schrieb:
> On Fri, 2007-09-14 at 10:14 +0200, Ingo Oeser wrote:
> > Is it enough to parse the first number in the firmware via simple_strtoul()?
>
> No, it's not. We need to check the number after the '.' and possibly an
> alphabet at the end as wel
version %s (latest supported: %d). You might consider
a firmware upgrade.\n",
version_string, oldest_supported);
}
Maybe that mechanism should be global somewhere? Having this kind of
information available
would help system maintenance in heterogenous hardware environm
elds.
All points raised be the people here are actually valid and I consider
bitfields nice and clear for specification and example code,
but avoid them while doing real coding.
Best Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of
Dear Nakamura-san,
[EMAIL PROTECTED] schrieb:
> This is the third one of MIPv6 module patch. It can be applied
> after two patches which are already sent to the list.
> Could you review it?
They look good. Thanks for taking the time to clean this up!
Acked-by: Ingo Oeser <[EMA
Masahide NAKAMURA schrieb:
> Ingo Oeser wrote:
> > What about MODULE_ALIAS("xfrm-type-10-60")
> > and MODULE_ALIAS("xfrm-type-10-43") in mip6.c ?
Just replace your second patch ("Loadable module support")
with one, which additionally adds thes
ere
and the code looks bigger than a function call with a single argument.
Maybe even make the callers out of line?
Best regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vge
catch declaration mismatch
> and other similar issues.
I would LOVE to see a config option or build target for that. At the moment
I haven't figured out, how to do this correctly with Kbuild.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev"
ODULE_ALIAS_XFRM_TYPE macro in include/net/xfrm.h
simliar to to MODULE_ALIAS_XFRM_MODE.
Please be sure to discuss CC Herbert Xu then.
Best regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jon,
Jon Paul Maloy schrieb:
> Ingo Oeser wrote:
> > static inlinevoid msg_set_bits(struct tipc_msg *m, u32 w,
> > u32 pos, __be32 mask, __be32 val)
> >
> >
> > Care to resubmit?
> I don't mind at all, but I would first li
w, u32 val) static inline void msg_set_bits(struct tipc_msg *m, u32 w,
> u32 pos, u32 mask, u32 val)
static inlinevoid msg_set_bits(struct tipc_msg *m, u32 w,
u32 pos, __be32 mask, __be32 val)
Care to resubmit?
Best Regards
Ingo
ex);
drv->idx = wiphy_counter;
/* increase counter for the next time, if id didn't wrap */
if (drv->idx >= 0)
wiphy_counter++;
mutex_unlock(&cfg80211_drv_mutex);
if (drv->idx < 0) {
kfree(drv);
return NULL;
}
/* give it a proper name */
snprintf(drv->wiphy.dev.bus_id, BUS_ID_SIZE,
PHY_NAME "%d", drv->idx);
[enqueue to all lists here]
Rest looks good so far.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
W_EV_LCP_LEN);
> + memcpy(stream, (char *) iwe, IW_EV_LCP_PK_LEN);
useless cast.
> memcpy(stream + IW_EV_LCP_LEN,
> ((char *) iwe) + IW_EV_LCP_LEN + IW_EV_POINT_OFF,
> -IW_EV_POINT_LEN - IW_EV_LCP_LEN);
> +IW_EV_POINT_PK_LEN - I
buffer space.
seq_puts() behaves the same. So you simply do this:
if (seq_puts(m, "text\n"))
goto no_space;
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http:/
s
according to Documentation/SubmittingPatches
I'm looking forward to review it!
Best Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
+ if (self->raw_mode)
> + return;
> +#endif
> +
I would suggest a small helper function here, which compiles into a constant,
if raw_mode is not compiled in.
like
#ifdef CONFIG_IRDA_RAW
static inline int irlap_raw_mod(struct irlap_cb *self)
{
return self-&g
Hi Patrick,
Patrick McHardy schrieb:
> Ingo Oeser wrote:
> > Patrick McHardy schrieb:
> >
> >>My guess is that you're using MASQUERADE on ppp0, which since 2.6.14
> >>doesn't exclude locally generated packets anymore, so it translates
> >>th
ress for several third party vendor tunnels.
So changing that is quite an effort.
Many thanks for your quick answer.
Best regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
IP_ID_YUKON && hw->chip_rev != 0)
> + return WAKE_MAGIC | WAKE_PHY;
> + else
> + return 0;
> +}
You can delete that comment, if you write exactly, what the comment says:
if (hw->chip_id == CHIP_ID_YUKON && hw->chip_rev >= 1)
s config. The algorithm should stay the same.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
a chance to run,
while you wait for your hardware state to change
(if your hardware can tolerate these latencies).
- can somehow handle hardware failure and at least give the user a clue
what is happening.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
g nr_segs;
unsigned long seg_limit;
size_t nr_bytes;
};
That will enable resizeable iodescs with partial completion state and
will enable successive filling of an iodesc with iovs.
This will be needed anyway. I built an complete short userspace
module for that already. I can po
t; + .data = NULL,
> + .maxlen = 0,
> + .mode = 0600,
> + .proc_handler = &pm_do_freq
> + },
> + {}
> };
dito
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
+ 1,
> + .procname = "autoprobe0",
> + .data = NULL,
> + .maxlen = 0,
> + .maxlen = 0444,
> + .proc_handler = &do_autoprobe
> + }
o this statement is not quite true, although I believe you are probably right
for this case.
BTW: This rp_filter=0 requirement isn't even officially documented
(e.g. in the LARTC).
Regards
Ingo Oeser
[1] But does take TOS into account for historic (???) reasons.
-
To unsubscribe
Divy Le Ray schrieb:
> Stephen Hemminger wrote:
> > On Tue, 9 Jan 2007 09:42:03 +0100
> > Ingo Oeser <[EMAIL PROTECTED]> wrote:
> >> Stephen Hemminger schrieb:
> >>> - if (fl->credits < drop_thres) {
> >>> +use_orig_buf:
> >>>
Stephen Hemminger schrieb:
> On Tue, 9 Jan 2007 09:42:03 +0100
> Ingo Oeser <[EMAIL PROTECTED]> wrote:
> > Stephen Hemminger schrieb:
> > > --- netdev-2.6.orig/drivers/net/chelsio/sge.c
> > > +++ netdev-2.6/drivers/net/chelsio/sge.c
> > Please use NET_
pci_unmap_len(ce, dma_len),
> +PCI_DMA_FROMDEVICE);
> recycle_fl_buf(fl, fl->cidx);
> return skb;
> }
>
> - if (fl->credits < drop_thres) {
> +use_orig_buf:
> + if (fl-&
iting infrastructure.
Many device types come with eeproms today and they implement
it per driver or subsystem. On embedded platforms these EEPROMs
might even be shared among different devices.
So it might be time to generalize this like we did with LEDs.
Any comments?
Regards
Ingo Oeser
-
To uns
= PHY_INTERFACE_MODE_RTBI;
> +
> + return interface;
> +}
If you change the modes into an enum (as suggested by Kumar),
you can make a nice static lookup table indexed by mode with a for loop here.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
41,7 @@ static int netxen_nic_poll(struct net_de
> netxen_nic_enable_int(adapter);
> }
>
> - return (done ? 0 : 1);
> + return (!done);
return !done;
Please lose the braces here (CodingStyle).
Just respin or send this change along with later pat
first 4-6 octets
of the hexdump and decode+check+warn using this info first
to avoid mixing up files?
Maybe only the first 4 octets to enhance privacy and still being able
to detect known "bad" series.
This might prevent user errors when sending such files
to developers.
Regar
.
And some distribution vendors are still at 2.6.8-$WHACKY_PATCHES
or similiar, which is not usable for many things
(e.g. IPsec, SIP behind NAT etc.).
But I agree that workings towards smaller size in "make allyesconfig"
is much better :-)
Regards
Ingo Oeser
-
To unsubscribe from thi
dule_delayed_work_on(cpu, reap_work,
__round_jiffies_relative(HZ, 3 * cpu));
}
}
In case you apply it:
Signed-off-by: Ingo Oese <[EMAIL PROTECTED]>
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
t members an issue again. These
> things are never easy are they? :-/
Would be, if floating point values would be allowed. Single precision would
be enough in this case and its just 32 bits IIRC.
I mean floating point values just for the user->kernel ABI and
NOT for the internal timer represe
Hi Tim,
Hi Jeff,
[EMAIL PROTECTED] wrote:
> On Thu, Sep 14, 2006 at 05:39:08PM +0200, Ingo Oeser wrote:
> > Ingo Oeser wrote:
> > > I get the following message when trying to transfer big files
> > > (via FTP or SCP) since Linux 2.6.16.27. It didn't h
Hi there,
Ingo Oeser wrote:
> I get the following message when trying to transfer big files
> (via FTP or SCP) since Linux 2.6.16.27. It didn't happen with Linux 2.6.13.4.
>
> [702238.242237] eth1: increased tx threshold, txcfg 0xd0f01008.
> [702238.242649] eth1: increased
about putting this message at the message level "DEBUG"
or even under pr_debug()?
This NIC is just used for PPPoE in our setups.
The other message "tx underrun with maximum tx threshold"
is much more useful, since it indicates a real problem.
So I would suggest the following pa
Lots of users use their own kernels instead
of distribution kernels. Much less users divert core software from
their distribution.
The big binary called bzImage/vmlinux whatever is a huge usability
advantage here :-)
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "uns
vlan target.
> +
> + To compile it as a module, choose M here. If unsure, say N.
> +
> +
Please put your nice explanations "to change vlan ids in fly" from your email
here.
And short ebtables example for the common use case might help, too. But only,
if it is not more t
ng ioc3_map(void *ptr, unsigned long vdev)
> {
> #ifdef CONFIG_SGI_IP27
> - vdev <<= 58; /* Shift to PCI64_ATTR_VIRTUAL */
> + vdev <<= 57; /* Shift to PCI64_ATTR_VIRTUAL */
So please use a symbolic value here.
Regards
Ingo Oeser
-
To unsubscribe from this lis
first, rather than the global/site one.
This can be worked around by defining an "alias interface" this way
"ip address add 169.254.182.108/16 brd 169.254.255.255 scope link dev eth0
label eth0:0"
(see: "label eth0:0" is appended)
So in reality this is no problem for us
your nvidia NIC, since we only have it at one customers
mail server behind a SonicWall, so we cannot really try a lot.
For all other customers it works. I'm a bit lost on the cause.
I've seen 4% collisions, which might reduce performance,
but should not stop the transmitter forever.
PS:
Hi Andi,
Andi Kleen wrote:
> > 4. Put "sysctl -w kernel.panic_on_oops=1" as early as possible
> > in your boot scripts[1].
>
> You can as well boot with oops=panic
Only on x86_64 as of Linux 2.6.16.
But maybe this could be put into kernel/panic.c instead :
.
And now reboot into the new kernel, try to login and delete the reboot
cronjob. If this doesn't work, just wait 15min and have the last stable kernel
booted automatically.
This method saved me and our customers a lot of time already :-)
Regards
Ingo Oeser
[1] This should be the defa
or
> such and use __ioremap with explicit page attributes. I have a hack to
> do that automatically for memory covered by prefetchable PCI BARs when
> mmap'ing from userland but not for kernel ioremap.
Stupid question: pci_iomap() is NOT what you are looking for, right?
Impleme
and your .config would be the minimum
some ethtool outputs (ethtool -k ethX) would help here.
4. If you like to have it resolved very fast, please try git-bisect.
This can take a lot of time (several recompiles and reboots needed!).
Happy Bug hunting!
Regards
Ingo Oeser
-
To
Hi Stephen,
Stephen Hemminger wrote:
> Many users of skb_checksum_help() are just using it to recalculate
> outbound checksum, so why not expose the interface in a more useful
> way. Suggested by Ingo Oeser.
You are damn fast Stephen :-)
That's even better and improves a lot on
not mix clean-ups with substantive changes so
> if you have the time please post a separate patch for this. Otherwise
> I'll do a patch when I resubmit this.
Would be nice to include such a patch in this patchset, since you seem
to be able to decipher that magic value :-)
Thanks &
essage.
Already there: /proc/sys/net/core/{message_cost,message_burst}
Just set burst to 0 and cost to a very big value to basically supppress
all net_ratelimit()ed messages.
Or did you think of sth. else?
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netde
from bugzilla and
"agreed to help out with net driver maintenance"
so I CC'ed you here manually.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at ht
t works good, reduces maintainence burden and keeps
your driver current to latest APIs automatically.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
_get_drvdata(rt2x00pci->pci_dev);
> - struct sk_buff *skb;
> + struct data_ring*ring = (struct data_ring*)data;
No need for casting.
Many more of them.
I guess you could just do a fgrep for "*ring = (struct data_ring*)data;"
Regards
Ingo Oeser
Sie schrieben:
> From: Ivo van Doorn <[EMAIL PROTECTED]>
>
> The vals[] arrays in *_init_hw_channels can be made
> static to optimize memory and reduce stack size.
What about static const? They are also constants, right?
But please try first, if this helps in terms of code si
s, you are right. But even then I can still implement the
reserve/commit once you provide the helpers for
producer_space and consumer_space.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majo
s is quite similiar to now we do page_vec stuff in mm/ already.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
ot exactly a queue, but a dynamic double buffer :-)
So maybe doing queueing with the classic head/tail variant is better here,
but the other variant might replace it without problems and allows
for some nice improvements.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "uns
5:45 -0700
> From: [EMAIL PROTECTED]
> To: [EMAIL PROTECTED]
> Subject: [Bug 6421] New: kernel 2.6.10-2.6.16 on alpha:
> arch/alpha/kernel/io.c, iowrite16_rep() BUG_ON((unsigned long)src & 0x1)
> triggered
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line &
plication is sth. like a MPEG demultiplexer?
There you don't like to look at everything and excplicitly
ignore received data[1].
Yes, I know this is usually done with hardware demuxers and filters,
but the principle might apply to other applications as well, for which
no hardware solutions e
cheaper with local_t instead of atomic_t later on.
But I guess the cacheline bouncing will be a non-issue, since the whole
point of netchannels was to keep traffic as local to a cpu as possible, right?
Would you like to see a sample patch relative to your tree,
to show you what I mean?
Rega
river writers were already confused by all that size, len and truesize stuff,
as this bug showed.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
dulo arithmetics.
The non-atomic wrapround doesn't change the atomic nature of
read, add, sub. Only problem is atomic_dec_and_test() or similiar ops.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
vlan/drivers/net/typhoon.o
with allyesconfig (minus CONFIG_INFO) and my patches applied.
So maybe the uninlining is enough. Gain after this is just 575 bytes here.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMA
eatures. So I really appreciate your work here Denis.
Regards
Ingo Oeser
diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c
index c1ce87a..aab24b8 100644
--- a/drivers/net/typhoon.c
+++ b/drivers/net/typhoon.c
@@ -285,7 +285,9 @@ struct typhoon {
struct pci_dev *pdev;
Hi Denis,
Denis Vlasenko wrote:
> On Tuesday 11 April 2006 12:49, Ingo Oeser wrote:
> > #if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
> > static inline has_vlan_group(...) {
> > /* get VLAN group */
> > }
> > #else
> > stati
code elemination. The result will be even cleaner code, I think.
What do you think?
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
hat: looks good.
Many thanks for your review.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Ingo Oeser <[EMAIL PROTECTED]>
general:
- endian annotation of the ring descriptors
nv_getlen():
- use htons() instead of __constant_htons()
to improvde readability and let the compiler constant fold it.
nv_rx_process():
- use a real for() l
return 0;
>
Please use "htons(ETH_P_SLOW)", since the compiler will constant fold this
and it is more readable this way.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
ss two files?
I would suggest folding it simply into its sole caller:
ieee80211softmac_wx_get_scan_results() in
net/ieee80211/softmac/ieee80211softmac_wx.c
That should reduce kernel text size a bit.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev&
nk that only happens on PCI Express and I don't think
> Ingo is using PCI Express.
Right. PCI-Express is not available in this machine.
Maybe the traffic is not enough to trigger it. External connect is just a 6MBit
DSL.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line &
but cannot test patches.
Regards
Ingo Oeser
#
# Automatically generated make config: don't edit
# Linux kernel version: 2.6.16
# Thu Mar 23 15:29:59 2006
#
CONFIG_X86_32=y
CONFIG_SEMAPHORE_SLEEPERS=y
CONFIG_X86=y
CONFIG_MMU=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_IOMAP=y
CONFIG_ARCH_MA
nt debugfs.
If it becomes really important, we can revisit this later.
Thats the advantage of files under debugfs
not being stable API in any way.
BTW: What is the actual frequency, at which such counters
will be incremented?
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line &
Hi Chris,
Andrew Morton wrote:
> Ingo Oeser <[EMAIL PROTECTED]> wrote:
> >
> > -int scm_send(struct socket *sock, struct msghdr *msg, struct scm_cookie
> > *scm)
> > -{
> > - struct task_struct *p = current;
> > - scm->creds
From: Ingo Oeser <[EMAIL PROTECTED]>
Fold __scm_send() into scm_send() and remove that interface completly
from the kernel.
Signed-off-by: Ingo Oeser <[EMAIL PROTECTED]>
---
Inspired by the patch to inline scm_send()
I did the next logical step :-)
Regards
Ingo Oeser
diff --git a
Hi,
On Sunday, 12. March 2006 00:49, Ingo Oeser wrote:
> From: Ingo Oeser <[EMAIL PROTECTED]>
>
> Two minor cleanups:
>
> 1. Using kzalloc() in fraq_alloc_queue()
>saves the memset() in ipv6_frag_create().
>
> 2. Invert sense of if-statements to streamline
From: Ingo Oeser <[EMAIL PROTECTED]>
Two minor cleanups:
1. Using kzalloc() in fraq_alloc_queue()
saves the memset() in ipv6_frag_create().
2. Invert sense of if-statements to streamline code.
Inverts the comment, too.
Signed-off-by: Ingo Oeser <[EMAIL PROTECTED]>
---
Hi,
From: Ingo Oeser <[EMAIL PROTECTED]>
Stupidly use kzalloc() instead of kmalloc()/memset()
everywhere where this is possible in net/ipv6/*.c .
Signed-off-by: Ingo Oeser <[EMAIL PROTECTED]>
---
Hi,
I'm going to refactor some of the simple cases to reduce code
duplication whi
From: Ingo Oeser <[EMAIL PROTECTED]>
Here are some possible (and trivial) cleanups.
- use kzalloc() where possible
- invert allocation failure test like
if (object) {
/* Rest of function here */
}
to
if (object == NULL)
return NULL;
/* Rest of function here */
as Van Jacobson calls this.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
YOSHIFUJI Hideaki wrote:
> In article <[EMAIL PROTECTED]> (at Tue, 7 Mar 2006 11:26:13 +0100), Ingo
> Oeser <[EMAIL PROTECTED]> says:
>
> > What about sth. like this simple defensive patch instead
> > (against Linux 2.6.16-rc4)?
>
> I disagree again. Sorr
miliar, I would not trust this very
much.
What about sth. like this simple defensive patch instead
(against Linux 2.6.16-rc4)?
Regards
Ingo Oeser
--- net/ipv6/addrconf.c~2006-02-17 23:23:45.0 +0100
+++ net/ipv6/addrconf.c 2006-03-07 11:19:50.0 +0100
@@ -713,7 +713,8 @@
Evgeniy Polyakov wrote:
> On Mon, Mar 06, 2006 at 06:44:07PM +0100, Ingo Oeser ([EMAIL PROTECTED])
> wrote:
> > Hmm, so I should resurrect my user page table walker abstraction?
> >
> > There I would hand each page to a "recording" function, which
> >
my user page table walker abstraction?
There I would hand each page to a "recording" function, which
can drop the page from the collection or coalesce it in the collector
if your scatter gather implementation allows it.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the lin
t:
> + printk(KERN_DEBUG "X.25: unknown facility %02X,"
> + "length %d, values %02X, %02X, %02X, %02X\n",
> + p[0], p[1], p[2], p[3], p[4], p[5]);
> + brea
From: Ingo Oeser <[EMAIL PROTECTED]>
Here are some possible (and trivial) cleanups.
- use kzalloc() where possible
- remove unused label
- invert allocation failure test like
if (object) {
/* Rest of function here */
}
to
if (object == NULL)
return NULL;
/* R
change, which I will run through
make allyesconfig
make
which may take a while.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Ingo Oeser <[EMAIL PROTECTED]>
Here are some possible (and trivial) cleanups.
- use kzalloc() where possible
- remove unused label
- invert allocation failure test like
if (object) {
/* Rest of function here */
}
to
if (object == NULL)
return NULL;
/* R
ny
connection
after EFAULT (which is usally followed by a SEGV)?
So I wouldn't worry that much.
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jesse Brandeburg wrote:
> On Mon, 23 Jan 2006, Ingo Oeser wrote:
> > Jeff Kirsher wrote:
> > > These functions help restore the driver to active configuration when
> > > coming out of resume for
> > power management.
> >
> > Shouldn't this probl
; #include "e1000.h"
>
> /* Change Log
Wasn't it consensus, that changelogs are better kept in version control systems
or at least
seperate from code?
Regards
Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
1 - 100 of 123 matches
Mail list logo
