Hi Herbert, Herbert Xu schrieb: > diff --git a/net/ipv6/xfrm6_mode_ro.c b/net/ipv6/xfrm6_mode_ro.c > index a7bc8c6..4a01cb3 100644 > --- a/net/ipv6/xfrm6_mode_ro.c > +++ b/net/ipv6/xfrm6_mode_ro.c > @@ -53,7 +54,9 @@ static int xfrm6_ro_output(struct xfrm_state *x, struct > sk_buff *skb) > __skb_pull(skb, hdr_len); > memmove(ipv6_hdr(skb), iph, hdr_len); > > + spin_lock_bh(&x->lock); > x->lastused = get_seconds(); > + spin_unlock_bh(&x->lock); > > return 0; > }
Can you move the retrieval of the seconds outside the spinlock? e.g. tmp = get_seconds(); spin_lock_bh(&x->lock); x->lastused = tmp; spin_unlock_bh(&x->lock); or is it not really worth it? Best Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html