RE: [PATCH v7 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-16 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Friday, April 16, 2021 12:40 PM > To: Dexuan Cui > Cc: da...@davemloft.net; k...@kernel.org; KY Srinivasan > ; Haiyang Zhang ; Stephen > Hemminger ; wei@kernel.org; Wei Liu > ; netdev@vger.kernel.org

RE: [PATCH v6 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-15 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, April 15, 2021 5:08 PM > To: Dexuan Cui > Cc: da...@davemloft.net; k...@kernel.org; KY Srinivasan > ; Haiyang Zhang ; Stephen > Hemminger ; wei@kernel.org; Wei Liu > ; netdev@vger.kernel.org

RE: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Haiyang Zhang
> -Original Message- > From: Andrew Lunn > Sent: Monday, April 12, 2021 8:32 AM > To: Dexuan Cui > Cc: da...@davemloft.net; k...@kernel.org; KY Srinivasan > ; Haiyang Zhang ; Stephen > Hemminger ; wei@kernel.org; Wei Liu > ; netdev@vger.kernel.or

RE: [PATCH v4 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-12 Thread Haiyang Zhang
> -Original Message- > From: Andrew Lunn > Sent: Monday, April 12, 2021 8:16 AM > To: Dexuan Cui > Cc: da...@davemloft.net; k...@kernel.org; KY Srinivasan > ; Haiyang Zhang ; Stephen > Hemminger ; wei@kernel.org; Wei Liu > ; netdev@vger.kernel.or

RE: [PATCH v3 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-08 Thread Haiyang Zhang
> -Original Message- > From: David Miller > Sent: Thursday, April 8, 2021 8:41 PM > To: Dexuan Cui > Cc: k...@kernel.org; KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; wei@kernel.org; Wei Liu > ; netdev@vger.kernel.org; l...@kernel.o

RE: [PATCH v2 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-08 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, April 8, 2021 12:52 PM > To: Randy Dunlap > Cc: Dexuan Cui ; da...@davemloft.net; > k...@kernel.org; KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; wei@kernel.org; Wei Liu >

RE: [PATCH v2 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-08 Thread Haiyang Zhang
> -Original Message- > From: Andrew Lunn > Sent: Thursday, April 8, 2021 12:45 PM > To: Haiyang Zhang > Cc: Randy Dunlap ; Dexuan Cui > ; da...@davemloft.net; k...@kernel.org; KY > Srinivasan ; Stephen Hemminger > ; wei@kernel.org; Wei Liu >

RE: [PATCH v2 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-08 Thread Haiyang Zhang
> -Original Message- > From: Randy Dunlap > Sent: Thursday, April 8, 2021 12:23 PM > To: Dexuan Cui ; da...@davemloft.net; > k...@kernel.org; KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; wei@kernel.org; Wei Liu > ; netdev@vger.kernel.org; l...@kern

RE: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Haiyang Zhang
> -Original Message- > From: Wei Liu > Sent: Wednesday, April 7, 2021 11:01 AM > To: Haiyang Zhang > Cc: Wei Liu ; Dexuan Cui ; > da...@davemloft.net; k...@kernel.org; KY Srinivasan > ; Stephen Hemminger ; > Wei Liu ; netdev@vger.kernel.org; linux- > ker...

RE: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Haiyang Zhang
> -Original Message- > From: Leon Romanovsky > Sent: Wednesday, April 7, 2021 10:55 AM > To: Haiyang Zhang > Cc: Dexuan Cui ; da...@davemloft.net; > k...@kernel.org; KY Srinivasan ; Stephen Hemminger > ; wei@kernel.org; Wei Liu > ; netdev@vger.

RE: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Haiyang Zhang
> -Original Message- > From: Leon Romanovsky > Sent: Wednesday, April 7, 2021 8:51 AM > To: Dexuan Cui > Cc: da...@davemloft.net; k...@kernel.org; KY Srinivasan > ; Haiyang Zhang ; Stephen > Hemminger ; wei@kernel.org; Wei Liu > ; netdev@vger.

RE: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Haiyang Zhang
> -Original Message- > From: Wei Liu > Sent: Wednesday, April 7, 2021 9:17 AM > To: Dexuan Cui > Cc: da...@davemloft.net; k...@kernel.org; KY Srinivasan > ; Haiyang Zhang ; Stephen > Hemminger ; wei@kernel.org; Wei Liu > ; netdev@vger.kernel.org; linux-

RE: [PATCH net-next] hv_netvsc: Add error handling while switching data path

2021-03-30 Thread Haiyang Zhang
> -Original Message- > From: Vitaly Kuznetsov > Sent: Tuesday, March 30, 2021 7:43 AM > To: Haiyang Zhang ; linux- > hyp...@vger.kernel.org; netdev@vger.kernel.org > Cc: Haiyang Zhang ; KY Srinivasan > ; Stephen Hemminger ; > o...@aepfle.de; da...@

[PATCH net-next] hv_netvsc: Add error handling while switching data path

2021-03-29 Thread Haiyang Zhang
Add error handling in case of failure to send switching data path message to the host. Reported-by: Shachar Raindel Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 6 +- drivers/net/hyperv/netvsc.c | 35 + drivers/net/hyperv

[PATCH net-next] hv_netvsc: Add a comment clarifying batching logic

2021-03-12 Thread Haiyang Zhang
From: Shachar Raindel The batching logic in netvsc_send is non-trivial, due to a combination of the Linux API and the underlying hypervisor interface. Add a comment explaining why the code is written this way. Signed-off-by: Shachar Raindel Signed-off-by: Haiyang Zhang --- .../ethernet

RE: [PATCH v2 4/4] hv_netvsc: Restrict configurations on isolated guests

2021-01-26 Thread Haiyang Zhang
> -Original Message- > From: Andrea Parri (Microsoft) > Sent: Tuesday, January 26, 2021 6:57 AM > To: linux-ker...@vger.kernel.org > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; Wei Liu ; Michael Kelley > ; linux-hyp...@vger.kernel.org; Tianyu L

RE: [PATCH 4/4] hv_netvsc: Restrict configurations on isolated guests

2021-01-21 Thread Haiyang Zhang
> -Original Message- > From: Andrea Parri > Sent: Wednesday, January 20, 2021 11:05 PM > To: Haiyang Zhang > Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; > Stephen Hemminger ; Wei Liu > ; Michael Kelley ; Tianyu Lan > ; Saruhan Karademir > ;

RE: [PATCH 4/4] hv_netvsc: Restrict configurations on isolated guests

2021-01-20 Thread Haiyang Zhang
> -Original Message- > From: Andrea Parri (Microsoft) > Sent: Tuesday, January 19, 2021 12:59 PM > To: linux-ker...@vger.kernel.org > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; Wei Liu ; Michael Kelley > ; Tianyu Lan ; > Saruhan Karademir ;

RE: [PATCH 3/3] hv_netvsc: Process NETDEV_GOING_DOWN on VF hot remove

2021-01-06 Thread Haiyang Zhang
> -Original Message- > From: Long Li > Sent: Tuesday, January 5, 2021 8:16 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; Wei Liu ; David S. Miller > ; Jakub Kicinski ; linux- > hyp...@vger.kernel.org; netdev@vger.kernel.org; linux- > ker...

RE: [PATCH 2/3] hv_netvsc: Wait for completion on request NVSP_MSG4_TYPE_SWITCH_DATA_PATH

2021-01-06 Thread Haiyang Zhang
> -Original Message- > From: Long Li > Sent: Tuesday, January 5, 2021 8:16 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; Wei Liu ; David S. Miller > ; Jakub Kicinski ; linux- > hyp...@vger.kernel.org; netdev@vger.kernel.org; linux- > ker...

RE: [PATCH 1/3] hv_netvsc: Check VF datapath when sending traffic to VF

2021-01-06 Thread Haiyang Zhang
> -Original Message- > From: Long Li > Sent: Tuesday, January 5, 2021 8:16 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; Wei Liu ; David S. Miller > ; Jakub Kicinski ; linux- > hyp...@vger.kernel.org; netdev@vger.kernel.org; linux- > ker...

RE: [PATCH] hv_netvsc: Validate number of allocated sub-channels

2020-11-18 Thread Haiyang Zhang
> -Original Message- > From: Andrea Parri (Microsoft) > Sent: Wednesday, November 18, 2020 10:33 AM > To: linux-ker...@vger.kernel.org > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; Wei Liu ; linux- > hyp...@vger.kernel.org; Michael Kelley ;

RE: [PATCH v3] hv_netvsc: Add validation for untrusted Hyper-V values

2020-09-16 Thread Haiyang Zhang
> -Original Message- > From: Andrea Parri (Microsoft) > Sent: Wednesday, September 16, 2020 5:47 AM > To: linux-ker...@vger.kernel.org > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; Wei Liu ; linux- > hyp...@vger.kernel.org; Andres Beltran ; Mi

RE: [PATCH v2] hv_netvsc: Add validation for untrusted Hyper-V values

2020-09-10 Thread Haiyang Zhang
> -Original Message- > From: Andrea Parri (Microsoft) > Sent: Thursday, September 10, 2020 8:48 AM > To: linux-ker...@vger.kernel.org > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; Wei Liu ; linux- > hyp...@vger.kernel.org; Andres Beltran ; Mi

[PATCH net, 2/2] hv_netvsc: Fix the queue_mapping in netvsc_vf_xmit()

2020-08-20 Thread Haiyang Zhang
the skb_get_rx_queue() called later will get the correct queue number, and VF will be able to use all queues. Fixes: b3bf5666a510 ("hv_netvsc: defer queue selection to VF") Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH net, 1/2] hv_netvsc: Remove "unlikely" from netvsc_select_queue

2020-08-20 Thread Haiyang Zhang
When using vf_ops->ndo_select_queue, the number of queues of VF is usually bigger than the synthetic NIC. This condition may happen often. Remove "unlikely" from the comparison of ndev->real_num_tx_queues. Fixes: b3bf5666a510 ("hv_netvsc: defer queue selection to VF") Si

[PATCH net, 0/2] hv_netvsc: Some fixes for the select_queue

2020-08-20 Thread Haiyang Zhang
This patch set includes two fixes for the select_queue process. Haiyang Zhang (2): hv_netvsc: Remove "unlikely" from netvsc_select_queue hv_netvsc: Fix the queue_mapping in netvsc_vf_xmit() drivers/net/hyperv/netvsc_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1

RE: [PATCH] hv_netvsc: do not use VF device if link is down

2020-08-04 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, August 4, 2020 12:54 PM > To: Haiyang Zhang ; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; wei@kernel.org; Stephen Hemminger > ; Shah, Ashish N > Subject: [PATCH]

RE: [PATCH] hv_netvsc: Add validation for untrusted Hyper-V values

2020-08-02 Thread Haiyang Zhang
> -Original Message- > From: Andres Beltran > Sent: Tuesday, July 28, 2020 6:53 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > wei@kernel.org > Cc: linux-hyp...@vger.kernel.org; linux-ker...@vger.kernel.org; Michael > Kelley ; parri.a

RE: [PATCH v8 net-next] net: hyperv: dump TX indirection table to ethtool regs

2020-07-24 Thread Haiyang Zhang
> -Original Message- > From: Chi Song > Sent: Friday, July 24, 2020 12:14 AM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > Wei Liu ; David S. Miller ; Jakub > Kicinski > Cc: linux-hyp...@vger.kernel.org; netdev@vger.kernel.org; linux- > ker..

RE: [PATCH v7 net-next] net: hyperv: dump TX indirection table to ethtool regs

2020-07-23 Thread Haiyang Zhang
> -Original Message- > From: Michal Kubecek > Sent: Thursday, July 23, 2020 3:36 PM > To: Chi Song > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > Wei Liu ; David S. Miller ; Jakub > Kicinski ; linux-hyp...@vger.kernel.org; > netdev

RE: [PATCH v6] hv_netvsc: add support for vlans in AF_PACKET mode

2020-07-22 Thread Haiyang Zhang
> -Original Message- > From: Sriram Krishnan > Sent: Wednesday, July 22, 2020 11:39 AM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > Wei Liu > Cc: mbumg...@cisco.com; u...@cisco.com; n...@cisco.com; xe-linux- > exter...@cisco.com; David S.

RE: [PATCH v3] net: hyperv: add support for vlans in netvsc driver

2020-07-21 Thread Haiyang Zhang
> -Original Message- > From: Sriram Krishnan (srirakr2) > Sent: Tuesday, July 21, 2020 3:10 AM > To: David Miller > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > wei@kernel.org; Malcolm Bumgardner (mbumgard) > ; Umesha G M (ugm) ; Niranjan

RE: [PATCH v6 net-next] net: hyperv: Add attributes to show TX indirection table

2020-07-21 Thread Haiyang Zhang
> -Original Message- > From: Chi Song > Sent: Tuesday, July 21, 2020 12:59 AM > To: Stephen Hemminger ; David Miller > ; Haiyang Zhang ; KY > Srinivasan ; Stephen Hemminger > ; wei@kernel.org; k...@kernel.org; linux- > hyp...@vger.kernel.org > Cc: netdev

RE: [PATCH v3] net: hyperv: add support for vlans in netvsc driver

2020-07-20 Thread Haiyang Zhang
> -Original Message- > From: Sriram Krishnan > Sent: Monday, July 20, 2020 12:46 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > Wei Liu > Cc: mbumg...@cisco.com; u...@cisco.com; n...@cisco.com; xe-linux- > exter...@cisco.com; David S.

RE: [PATCH v3] net: hyperv: add support for vlans in netvsc driver

2020-07-20 Thread Haiyang Zhang
> -Original Message- > From: Sriram Krishnan > Sent: Monday, July 20, 2020 12:46 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > Wei Liu > Cc: mbumg...@cisco.com; u...@cisco.com; n...@cisco.com; xe-linux- > exter...@cisco.com; David S.

RE: [PATCH v3 net-next] net: hyperv: Add attributes to show TX indirection table

2020-07-20 Thread Haiyang Zhang
> -Original Message- > From: Chi Song > Sent: Monday, July 20, 2020 3:17 AM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > Wei Liu ; David S. Miller ; Jakub > Kicinski > Cc: linux-hyp...@vger.kernel.org; netdev@vger.kernel.org; linux- > ker..

RE: [PATCH net-next] net: hyperv: Add attributes to show RX/TX indirection table

2020-07-17 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Friday, July 17, 2020 1:15 PM > To: David Miller > Cc: Haiyang Zhang ; Chi Song > ; KY Srinivasan ; Stephen > Hemminger ; wei@kernel.org; > k...@kernel.org; a...@kernel.org; dan...@iogearbox.net; ka.

RE: [PATCH net-next] net: hyperv: Add attributes to show RX/TX indirection table

2020-07-17 Thread Haiyang Zhang
> -Original Message- > From: David Miller > Sent: Friday, July 17, 2020 12:56 PM > To: Haiyang Zhang > Cc: step...@networkplumber.org; Chi Song ; KY > Srinivasan ; Stephen Hemminger > ; wei@kernel.org; k...@kernel.org; > a...@kernel.org; dan...@iog

RE: [PATCH net-next] net: hyperv: Add attributes to show RX/TX indirection table

2020-07-17 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Friday, July 17, 2020 11:25 AM > To: Chi Song > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > Wei Liu ; David S. Miller ; Jakub > Kicinski ; Alexei Starovoitov ; Daniel > Borkmann ; Ma

RE: [PATCH v2 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

2020-06-29 Thread Haiyang Zhang
> -Original Message- > From: Andres Beltran > Sent: Monday, June 29, 2020 4:02 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > wei@kernel.org > Cc: linux-hyp...@vger.kernel.org; linux-ker...@vger.kernel.org; Michael > Kelley ; parri.and...@g

RE: [PATCH 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

2020-06-25 Thread Haiyang Zhang
> -Original Message- > From: Andres Beltran > Sent: Thursday, June 25, 2020 11:37 AM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > wei@kernel.org > Cc: linux-hyp...@vger.kernel.org; linux-ker...@vger.kernel.org; Michael > Kelley ; parri.

RE: [PATCH v2] hv_netvsc: Fix netvsc_start_xmit's return type

2020-04-30 Thread Haiyang Zhang
> -Original Message- > From: Nathan Chancellor > Sent: Thursday, April 30, 2020 2:02 AM > To: Michael Kelley > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; Wei Liu ; linux- > hyp...@vger.kernel.org; netdev@vger.kernel.org; linux- > ker...@vger

RE: [PATCH net-next v2 12/33] hv_netvsc: add XDP frame size to driver

2020-04-30 Thread Haiyang Zhang
> -Original Message- > From: Jesper Dangaard Brouer > Sent: Thursday, April 30, 2020 7:21 AM > To: same...@amazon.com > Cc: Wei Liu ; KY Srinivasan ; > Haiyang Zhang ; Stephen Hemminger > ; Jesper Dangaard Brouer > ; netdev@vger.kernel.org; b...@vger.kernel.org;

[PATCH net-next,v3, 6/6] net/mlx5e: Add mlx5e HV VHCA stats agent

2019-08-20 Thread Haiyang Zhang
From: Eran Ben Elisha HV VHCA stats agent is responsible on running a preiodic rx/tx packets/bytes stats update. Currently the supported format is version MLX5_HV_VHCA_STATS_VERSION. Block ID 1 is dedicated for statistics data transfer from the VF to the PF. The reporter fetch the statistics dat

[PATCH net-next,v3, 2/6] PCI: hv: Add a Hyper-V PCI interface driver for software backchannel interface

2019-08-20 Thread Haiyang Zhang
This interface driver is a helper driver allows other drivers to have a common interface with the Hyper-V PCI frontend driver. Signed-off-by: Haiyang Zhang Signed-off-by: Saeed Mahameed --- MAINTAINERS | 1 + drivers/pci/Kconfig | 1

RE: [PATCH] revert async probing of VMBus network devices.

2019-06-05 Thread Haiyang Zhang
xes: af0a5646cb8d ("use the new async probing feature for the hyperv > drivers") > Signed-off-by: Stephen Hemminger > --- Reviewed-by: Haiyang Zhang

RE: [RFC 1/2] netvsc: invoke xdp_generic from VF frame handler

2019-05-15 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, May 15, 2019 1:54 PM > To: Haiyang Zhang > Cc: KY Srinivasan ; da...@davemloft.net; > netdev@vger.kernel.org; Stephen Hemminger > Subject: Re: [RFC 1/2] netvsc: invoke xdp_generic from VF frame ha

RE: [RFC 1/2] netvsc: invoke xdp_generic from VF frame handler

2019-05-15 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, May 15, 2019 4:03 AM > To: KY Srinivasan ; Haiyang Zhang > ; da...@davemloft.net > Cc: netdev@vger.kernel.org; Stephen Hemminger > Subject: [RFC 1/2] netvsc: invoke xdp_generic from VF frame han

RE: [PATCH hyperv-fixes] hv_netvsc: Fix IP header checksum for coalesced packets

2019-02-23 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Saturday, February 23, 2019 11:46 AM > To: Haiyang Zhang > Cc: Haiyang Zhang ; sas...@kernel.org; linux- > hyp...@vger.kernel.org; KY Srinivasan ; Stephen > Hemminger ; o...@aepfle.de; vkuznets > ; da.

[PATCH hyperv-fixes] hv_netvsc: Fix IP header checksum for coalesced packets

2019-02-22 Thread Haiyang Zhang
From: Haiyang Zhang Incoming packets may have IP header checksum verified by the host. They may not have IP header checksum computed after coalescing. This patch re-compute the checksum when necessary, otherwise the packets may be dropped, because Linux network stack always checks it. Signed

[PATCH hyperv-fixes,3/3] Fix hash key value reset after other ops

2019-01-14 Thread Haiyang Zhang
From: Haiyang Zhang Changing mtu, channels, or buffer sizes ops call to netvsc_attach(), rndis_set_subchannel(), which always reset the hash key to default value. That will override hash key changed previously. This patch fixes the problem by save the hash key, then restore it when we re- add

[PATCH hyperv-fixes,0/3] fixes for hash key setting issues

2019-01-14 Thread Haiyang Zhang
From: Haiyang Zhang Using ethtool to change Hash key failed on Linux VM runnig on Hyper-V. This patch set fix them. It targets Hyper-V tree, hyperv-fixes branch managed by Sasha Levin . Haiyang Zhang (3): Fix ethtool change hash key error Refactor assignments of struct netvsc_device_info

[PATCH hyperv-fixes,1/3] Fix ethtool change hash key error

2019-01-14 Thread Haiyang Zhang
From: Haiyang Zhang Hyper-V hosts require us to disable RSS before changing RSS key, otherwise the changing request will fail. This patch fixes the coding error. Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table") Reported-by: Wei Hu Signed-off-by: Hai

[PATCH hyperv-fixes,2/3] Refactor assignments of struct netvsc_device_info

2019-01-14 Thread Haiyang Zhang
From: Haiyang Zhang These assignments occur in multiple places. The patch refactor them to a function for simplicity. It also puts the struct to heap area for future expension. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c | 134 1 file

RE: [PATCH net-next 2/4] net/hyperv: use skb_vlan_tag_*() helpers

2018-11-20 Thread Haiyang Zhang
> -Original Message- > From: Michał Mirosław > Sent: Tuesday, November 20, 2018 7:21 AM > To: netdev@vger.kernel.org > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; de...@linuxdriverproject.org; Ajit Khaparde > ; Leon Romanovsky ; > linux-

RE: [PATCH] hv_netvsc: remove ndo_poll_controller

2018-09-29 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Saturday, September 29, 2018 8:53 AM > To: netdev@vger.kernel.org > Cc: Stephen Hemminger ; Haiyang Zhang > ; Eric Dumazet > Subject: [PATCH] hv_netvsc: remove ndo_poll_controller > > Similar to other

RE: [PATCH] hv_netvsc: fix schedule in RCU context

2018-09-13 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, September 13, 2018 11:04 AM > To: KY Srinivasan ; Haiyang Zhang > > Cc: netdev@vger.kernel.org; Stephen Hemminger > Subject: [PATCH] hv_netvsc: fix schedule in RCU context > > When netvsc de

[PATCH net-next] hv_netvsc: Add handlers for ethtool get/set msg level

2018-05-22 Thread Haiyang Zhang
From: Haiyang Zhang The handlers for ethtool get/set msg level are missing from netvsc. This patch adds them. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net

[PATCH net-next] hv_netvsc: Add NetVSP v6 and v6.1 into version negotiation

2018-04-17 Thread Haiyang Zhang
From: Haiyang Zhang This patch adds the NetVSP v6 and 6.1 message structures, and includes these versions into NetVSC/NetVSP version negotiation process. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 164 drivers/net/hyperv

[PATCH net-next] hv_netvsc: Add NetVSP v6 into version negotiation

2018-04-05 Thread Haiyang Zhang
From: Haiyang Zhang This patch adds the NetVSP v6 message structures, and includes this version into NetVSC/NetVSP version negotiation process. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 33 + drivers/net/hyperv/netvsc.c | 3 ++- 2

[PATCH net-next] hv_netvsc: Clean up extra parameter from rndis_filter_receive_data()

2018-03-30 Thread Haiyang Zhang
From: Haiyang Zhang The variables, msg and data, have the same value. This patch removes the extra one. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/rndis_filter.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/hyperv/rndis_filter.c b

RE: [PATCH net-next, 2/2] hv_netvsc: Add range checking for rx packet offset and length

2018-03-27 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, March 27, 2018 11:23 AM > To: Haiyang Zhang > Cc: Haiyang Zhang ; da...@davemloft.net; > netdev@vger.kernel.org; o...@aepfle.de; Stephen Hemminger > ; linux-ker...@vger.kernel.org; > de...@linux

RE: [PATCH net-next,1/2] hv_netvsc: Fix the return status in RX path

2018-03-24 Thread Haiyang Zhang
> -Original Message- > From: Michael Kelley (EOSG) > Sent: Saturday, March 24, 2018 12:48 PM > To: Haiyang Zhang ; da...@davemloft.net; > netdev@vger.kernel.org > Cc: KY Srinivasan ; Stephen Hemminger > ; o...@aepfle.de; vkuzn...@redhat.com; > de...@linuxdriv

RE: [PATCH net-next,2/2] hv_netvsc: Add range checking for rx packet offset and length

2018-03-23 Thread Haiyang Zhang
> -Original Message- > From: Vitaly Kuznetsov > Sent: Friday, March 23, 2018 11:17 AM > To: Haiyang Zhang > Cc: da...@davemloft.net; netdev@vger.kernel.org; Haiyang Zhang > ; KY Srinivasan ; Stephen > Hemminger ; o...@aepfle.de; > de...@linuxdriv

[PATCH net-next,0/2] hv_netvsc: Fix/improve RX path error handling

2018-03-22 Thread Haiyang Zhang
From: Haiyang Zhang Fix the status code returned to the host. Also add range check for rx packet offset and length. Haiyang Zhang (2): hv_netvsc: Fix the return status in RX path hv_netvsc: Add range checking for rx packet offset and length drivers/net/hyperv/hyperv_net.h | 1

[PATCH net-next,1/2] hv_netvsc: Fix the return status in RX path

2018-03-22 Thread Haiyang Zhang
From: Haiyang Zhang As defined in hyperv_net.h, the NVSP_STAT_SUCCESS is one not zero. Some functions returns 0 when it actually means NVSP_STAT_SUCCESS. This patch fixes them. In netvsc_receive(), it puts the last RNDIS packet's receive status for all packets in a vmxferpage which may co

[PATCH net-next,2/2] hv_netvsc: Add range checking for rx packet offset and length

2018-03-22 Thread Haiyang Zhang
From: Haiyang Zhang This patch adds range checking for rx packet offset and length. It may only happen if there is a host side bug. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 1 + drivers/net/hyperv/netvsc.c | 17 +++-- 2 files changed, 16 insertions

RE: [RFC PATCH 0/2] hv_netvsc: Fix shutdown regression on Win2012 hosts

2018-01-23 Thread Haiyang Zhang
> -Original Message- > From: Mohammed Gamal [mailto:mga...@redhat.com] > Sent: Tuesday, January 23, 2018 4:34 AM > To: netdev@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; KY > Srinivasan ; Haiyang Zhang ; > Stephen Hemminger

[PATCH net-next] hv_netvsc: Use the num_online_cpus() for channel limit

2018-01-19 Thread Haiyang Zhang
From: Haiyang Zhang Since we no longer localize channel/CPU affiliation within one NUMA node, num_online_cpus() is used as the number of channel cap, instead of the number of processors in a NUMA node. This patch allows a bigger range for tuning the number of channels. Signed-off-by: Haiyang

[PATCH net-next] hv_netvsc: Use the num_online_cpus() for channel limit

2018-01-19 Thread Haiyang Zhang
From: Haiyang Zhang Since we no longer localize channel/CPU affiliation within one NUMA node, num_online_cpus() is used as the number of channel cap, instead of the number of processors in a NUMA node. This patch allows a bigger range for tuning the number of channels. Signed-off-by: Haiyang

RE: [PATCH] hyperv/netvsc: Delete two error messages for a failed memory allocation in netvsc_init_buf()

2018-01-08 Thread Haiyang Zhang
> -Original Message- > From: SF Markus Elfring [mailto:elfr...@users.sourceforge.net] > Sent: Sunday, January 7, 2018 3:10 PM > To: de...@linuxdriverproject.org; netdev@vger.kernel.org; Haiyang Zhang > ; KY Srinivasan ; Stephen > Hemminger > Cc: LKML ; kernel-jan

RE: [PATCH net 3/3] hv_netvsc: Fix the default receive buffer size

2017-12-08 Thread Haiyang Zhang
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Friday, December 8, 2017 5:45 AM > To: Stephen Hemminger > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; de...@linuxdriverproject.org; > netdev@vger.kernel.org >

RE: [PATCH net 1/3] hv_netvsc: Correct the max receive buffer size

2017-12-08 Thread Haiyang Zhang
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Friday, December 8, 2017 5:33 AM > To: Stephen Hemminger > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; de...@linuxdriverproject.org; > netdev@vger.kernel.org >

[PATCH next] tools/hv: Fix IP reporting by KVP daemon with SRIOV

2017-11-20 Thread Haiyang Zhang
From: Haiyang Zhang On Hyper-V the VF NIC has the same MAC as the related synthetic NIC. VF NIC can work under the synthetic NIC transparently, without its own IP address. The existing KVP daemon only gets IP from the first NIC matching a MAC address, and may not be able to find the IP in this

RE: [PATCH net v2] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

2017-11-15 Thread Haiyang Zhang
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Wednesday, November 15, 2017 9:13 AM > To: netdev@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; KY > Srinivasan ; Haiyang Zhang > ; Stephen Hemming

RE: [PATCH net] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

2017-11-14 Thread Haiyang Zhang
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, November 14, 2017 11:58 AM > To: Stephen Hemminger > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; KY Srinivasan ; Haiyang > Zhan

[PATCH net-next] hv_netvsc: Set tx_table to equal weight after subchannels open

2017-10-27 Thread Haiyang Zhang
From: Haiyang Zhang In some cases, like internal vSwitch, the host doesn't provide send indirection table updates. This patch sets the table to be equal weight after subchannels are all open. Otherwise, all workload will be on one TX channel. As tested, this patch has largely increase

[PATCH net-next,0/3] Add init of send table and var renames

2017-10-13 Thread Haiyang Zhang
From: Haiyang Zhang Add initialization of send indirection table. Otherwise it may contain old info of previous device with different number of channels. Also, did some variable renaming for easier reading. Haiyang Zhang (3): hv_netvsc: Rename ind_table to rx_table hv_netvsc: Rename

[PATCH net-next,2/3] hv_netvsc: Rename tx_send_table to tx_table

2017-10-13 Thread Haiyang Zhang
From: Haiyang Zhang Simplify the variable name: tx_send_table Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc.c | 2 +- drivers/net/hyperv/netvsc_drv.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net

[PATCH net-next,3/3] hv_netvsc: Add initialization of tx_table in netvsc_device_add()

2017-10-13 Thread Haiyang Zhang
From: Haiyang Zhang tx_table is part of the private data of kernel net_device. It is only zero-ed out when allocating net_device. We may recreate netvsc_device w/o recreating net_device, so the private netdev data, including tx_table, are not zeroed. It may contain channel numbers for the older

[PATCH net-next,1/3] hv_netvsc: Rename ind_table to rx_table

2017-10-13 Thread Haiyang Zhang
From: Haiyang Zhang Rename this variable because it is the Receive indirection table. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc_drv.c | 4 ++-- drivers/net/hyperv/rndis_filter.c | 6 +++--- 3 files changed, 6 insertions(+), 6

[PATCH net-next,1/3] hv_netvsc: Change the hash level variable to bit flags

2017-10-06 Thread Haiyang Zhang
From: Haiyang Zhang This simplifies the logic and make it easier to add more options. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 11 +-- drivers/net/hyperv/netvsc_drv.c | 73 - 2 files changed, 59 insertions(+), 25 deletions

[PATCH net-next,0/3] hv_netvsc: support changing TCP hash level

2017-10-06 Thread Haiyang Zhang
From: Haiyang Zhang The patch set simplifies the existing hash level switching code for UDP. It also adds the support for changing TCP hash level. So users can switch between L3 an L4 hash levels for TCP and UDP. Haiyang Zhang (3): hv_netvsc: Change the hash level variable to bit flags

[PATCH net-next,3/3] hv_netvsc: Update netvsc Document for TCP hash level setting

2017-10-06 Thread Haiyang Zhang
From: Haiyang Zhang Update Documentation/networking/netvsc.txt for TCP hash level setting and related info. Signed-off-by: Haiyang Zhang --- Documentation/networking/netvsc.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/networking/netvsc.txt b

[PATCH net-next,2/3] hv_netvsc: Add ethtool handler to set and get TCP hash levels

2017-10-06 Thread Haiyang Zhang
From: Haiyang Zhang The patch supports the options to switch TCP hash level between L3 and L4 by ethtool command. TCP over IPv4 and v6 can be set differently. The default hash level is L4. We currently only allow switching TX hash level from within the guests. For example, for TCP over IPv4 on

[PATCH net-next] hv_netvsc: Fix the real number of queues of non-vRSS cases

2017-09-22 Thread Haiyang Zhang
From: Haiyang Zhang For older hosts without multi-channel (vRSS) support, and some error cases, we still need to set the real number of queues to one. This patch adds this missing setting. Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug") Signed-off-by: Haiyang Zhang --- d

RE: [PATCH] hv_netvsc: make const array ver_list static, reduces object code size

2017-09-22 Thread Haiyang Zhang
> -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Friday, September 22, 2017 8:50 AM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > de...@linuxdriverproject.org; netdev@vger.kernel.org > Cc: kernel-janit...@vger.

RE: [PATCH net-next 1/1] hv_netvsc: fix deadlock on hotplug

2017-09-06 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, September 6, 2017 11:19 AM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > Cc: de...@linuxdriverproject.org; netdev@vger.kernel.org > Subject: [PATCH ne

[PATCH net-next, 0/4] cleanups and fixes of channel settings

2017-09-01 Thread Haiyang Zhang
From: Haiyang Zhang This patch set cleans up some unused variables, unnecessary checks. Also fixed some limit checking of channel number. Haiyang Zhang (4): hv_netvsc: Clean up an unused parameter in rndis_filter_set_rss_param() hv_netvsc: Simplify num_chn checking in

[PATCH net-next, 2/4] hv_netvsc: Simplify num_chn checking in rndis_filter_device_add()

2017-09-01 Thread Haiyang Zhang
From: Haiyang Zhang The minus one and assignment to a local variable is not necessary. This patch simplifies it. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/rndis_filter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/hyperv/rndis_filter.c b

[PATCH net-next, 3/4] hv_netvsc: Simplify the limit check in netvsc_set_channels()

2017-09-01 Thread Haiyang Zhang
From: Haiyang Zhang Because of the following code, net->num_tx_queues equals to VRSS_CHANNEL_MAX, and max_chn is less than or equals to VRSS_CHANNEL_MAX. netvsc_drv.c: alloc_etherdev_mq(sizeof(struct net_device_context), VRSS_CHANNEL_MAX); rndis_filte

[PATCH net-next, 4/4] hv_netvsc: Fix the channel limit in netvsc_set_rxfh()

2017-09-01 Thread Haiyang Zhang
From: Haiyang Zhang The limit of setting receive indirection table value should be the current number of channels, not the VRSS_CHANNEL_MAX. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hyperv

[PATCH net-next, 1/4] hv_netvsc: Clean up an unused parameter in rndis_filter_set_rss_param()

2017-09-01 Thread Haiyang Zhang
From: Haiyang Zhang This patch removes the parameter, num_queue in rndis_filter_set_rss_param(), which is no longer in use. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc_drv.c | 2 +- drivers/net/hyperv/rndis_filter.c | 5 ++--- 3 files

[PATCH net-next] hv_netvsc: Fix typos in the document of UDP hashing

2017-08-30 Thread Haiyang Zhang
From: Haiyang Zhang There are two typos in the document, netvsc.txt, regarding UDP hashing level. This patch fixes them. Signed-off-by: Haiyang Zhang --- Documentation/networking/netvsc.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/networking

[PATCH net-next] hv_netvsc: Fix rndis_filter_close error during netvsc_remove

2017-08-24 Thread Haiyang Zhang
From: Haiyang Zhang We now remove rndis filter before unregister_netdev(), which calls device close. It involves closing rndis filter already removed. This patch fixes this error. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c | 7 ++- 1 file changed, 6 insertions(+), 1

[PATCH net-next,2/4] hv_netvsc: Clean up unused parameter from netvsc_get_rss_hash_opts()

2017-08-21 Thread Haiyang Zhang
From: Haiyang Zhang The parameter "nvdev" is not in use. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 4677d2

[PATCH net-next,0/4] hv_netvsc: Ethtool handler to change UDP hash levels

2017-08-21 Thread Haiyang Zhang
From: Haiyang Zhang The patch set adds the functions to switch UDP hash level between L3 and L4 by ethtool command. UDP over IPv4 and v6 can be set differently. The default hash level is L4. We currently only allow switching TX hash level from within the guests. The ethtool callback function is

[PATCH net-next,4/4] hv_netvsc: Update netvsc Document for UDP hash level setting

2017-08-21 Thread Haiyang Zhang
From: Haiyang Zhang Update Documentation/networking/netvsc.txt for UDP hash level setting and related info. Signed-off-by: Haiyang Zhang --- Documentation/networking/netvsc.txt | 22 +- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/Documentation

[PATCH net-next,3/4] hv_netvsc: Add ethtool handler to set and get UDP hash levels

2017-08-21 Thread Haiyang Zhang
From: Haiyang Zhang The patch add the functions to switch UDP hash level between L3 and L4 by ethtool command. UDP over IPv4 and v6 can be set differently. The default hash level is L4. We currently only allow switching TX hash level from within the guests. On Azure, fragmented UDP packets have

  1   2   >