> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Thursday, April 8, 2021 12:52 PM
> To: Randy Dunlap <rdun...@infradead.org>
> Cc: Dexuan Cui <de...@microsoft.com>; da...@davemloft.net;
> k...@kernel.org; KY Srinivasan <k...@microsoft.com>; Haiyang Zhang
> <haiya...@microsoft.com>; Stephen Hemminger
> <sthem...@microsoft.com>; wei....@kernel.org; Wei Liu
> <li...@microsoft.com>; netdev@vger.kernel.org; l...@kernel.org;
> and...@lunn.ch; be...@petrovitsch.priv.at; linux-ker...@vger.kernel.org;
> linux-hyp...@vger.kernel.org
> Subject: Re: [PATCH v2 net-next] net: mana: Add a driver for Microsoft Azure
> Network Adapter (MANA)
>
> On Thu, 8 Apr 2021 09:22:57 -0700
> Randy Dunlap <rdun...@infradead.org> wrote:
>
> > On 4/8/21 2:15 AM, Dexuan Cui wrote:
> > > diff --git a/drivers/net/ethernet/microsoft/Kconfig
> > > b/drivers/net/ethernet/microsoft/Kconfig
> > > new file mode 100644
> > > index 000000000000..12ef6b581566
> > > --- /dev/null
> > > +++ b/drivers/net/ethernet/microsoft/Kconfig
> > > @@ -0,0 +1,30 @@
> > > +#
> > > +# Microsoft Azure network device configuration #
> > > +
> > > +config NET_VENDOR_MICROSOFT
> > > + bool "Microsoft Azure Network Device"
> >
> > Seems to me that should be generalized, more like:
> >
> > bool "Microsoft Network Devices"
>
> Yes, that is what it should be at this level.
>
> >
> >
> > > + default y
>
> This follows the existing policy for network vendor level
>
> > > + help
> > > + If you have a network (Ethernet) device belonging to this class, say
> > > Y.
> > > +
> > > + Note that the answer to this question doesn't directly affect the
> > > + kernel: saying N will just cause the configurator to skip the
> > > + question about Microsoft Azure network device. If you say Y, you
> >
> > about Microsoft networking devices.
> >
> > > + will be asked for your specific device in the following question.
> > > +
> > > +if NET_VENDOR_MICROSOFT
> > > +
> > > +config MICROSOFT_MANA
> > > + tristate "Microsoft Azure Network Adapter (MANA) support"
> > > + default m
> >
> > Please drop the default m. We don't randomly add drivers to be built.
>
> Yes, it should be no (or no default which is the default for default)
>
> > Or leave this as is and change NET_VENDOR_MICROSOFT to be default n.
> >
> >
> > > + depends on PCI_MSI && X86_64
> > > + select PCI_HYPERV
> > > + help
> > > + This driver supports Microsoft Azure Network Adapter (MANA).
> > > + So far, the driver is only validated on X86_64.
> >
> > validated how?
>
> Maybe change validated to supported?
Sounds better. We will change it to "supported".
Also other suggested changes.
Thanks,
- Haiyang
