Re: [PATCH] net: EMAC: Fix problem with mtu > 4080 on non TAH equipped 4xx PPC's

2008-01-15 Thread Eugene Surovegin
On Tue, Jan 15, 2008 at 08:46:01PM +0100, Stefan Roese wrote: > On Tuesday 15 January 2008, Eugene Surovegin wrote: > > On Tue, Jan 15, 2008 at 01:40:09PM +0100, Stefan Roese wrote: > > > Currently, all non TAH equipped 4xx PPC's call emac_start_xmit() upon > > >

Re: [PATCH] net: EMAC: Fix problem with mtu > 4080 on non TAH equipped 4xx PPC's

2008-01-15 Thread Eugene Surovegin
On Tue, Jan 15, 2008 at 01:40:09PM +0100, Stefan Roese wrote: > Currently, all non TAH equipped 4xx PPC's call emac_start_xmit() upon > xmit. This routine doesn't check if the frame length exceeds the max. > MAL buffer size. > > This patch now changes the driver to call emac_start_xmit_sg() on all

Re: [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers

2008-01-12 Thread Eugene Surovegin
On Sat, Jan 12, 2008 at 06:57:24PM +1100, Benjamin Herrenschmidt wrote: > > On Sat, 2008-01-12 at 08:26 +0100, Stefan Roese wrote: > > > > We shouldn't make it too complicated. We can always select different > > settings > > in the defconfig file. My thinking here is to better wast a little > >

Re: [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers

2008-01-11 Thread Eugene Surovegin
On Sat, Jan 05, 2008 at 01:38:17PM +0100, Stefan Roese wrote: > On Saturday 05 January 2008, Benjamin Herrenschmidt wrote: > > On Sat, 2008-01-05 at 10:50 +0100, Stefan Roese wrote: > > > Performance tests done by AMCC have shown that 256 buffer increase the > > > performance of the Linux EMAC driv

Re: [Bugme-new] [Bug 8778] New: Ocotea board: kernel reports access of bad area during boot with DEBUG_SLAB=y

2007-07-18 Thread Eugene Surovegin
On Wed, Jul 18, 2007 at 09:55:37AM -0700, Andrew Morton wrote: > On Wed, 18 Jul 2007 08:59:40 -0700 Eugene Surovegin <[EMAIL PROTECTED]> wrote: > > > On Wed, Jul 18, 2007 at 08:41:10AM -0500, Josh Boyer wrote: > > > On Wed, 2007-07-18 at 01:34 -0700, Eugene Surovegin wr

Re: [Bugme-new] [Bug 8778] New: Ocotea board: kernel reports access of bad area during boot with DEBUG_SLAB=y

2007-07-18 Thread Eugene Surovegin
On Wed, Jul 18, 2007 at 08:41:10AM -0500, Josh Boyer wrote: > On Wed, 2007-07-18 at 01:34 -0700, Eugene Surovegin wrote: > > On Wed, Jul 18, 2007 at 12:52:53AM -0700, Andrew Morton wrote: > > > On Wed, 18 Jul 2007 00:07:50 -0700 (PDT) [EMAIL PROTECTED] wrote: &

Re: [Bugme-new] [Bug 8778] New: Ocotea board: kernel reports access of bad area during boot with DEBUG_SLAB=y

2007-07-18 Thread Eugene Surovegin
On Wed, Jul 18, 2007 at 12:52:53AM -0700, Andrew Morton wrote: > On Wed, 18 Jul 2007 00:07:50 -0700 (PDT) [EMAIL PROTECTED] wrote: > > > http://bugzilla.kernel.org/show_bug.cgi?id=8778 > > > >Summary: Ocotea board: kernel reports access of bad area during > > boot

[PATCH 2/3] ibm_emac: improved PHY support

2007-05-16 Thread Eugene Surovegin
it to clear after doing the soft reset and before doing the subsequent write. Signed-off-by: Jeff Haran <[EMAIL PROTECTED]> CC: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Signed-off-by: Eugene Surovegin <[EMAIL PROTECTED]> --- drivers/net/ibm_emac/ibm_emac_phy.c | 60 +

[PATCH 3/3] ibm_emac: fix link speed detection change

2007-05-16 Thread Eugene Surovegin
Fix link speed detection change. Thanks to Stefan Roese <[EMAIL PROTECTED]> for finding this bug. CC: Stefan Roese <[EMAIL PROTECTED]> Signed-off-by: Eugene Surovegin <[EMAIL PROTECTED]> --- drivers/net/ibm_emac/ibm_emac_core.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 1/3] ibm_emac: fix section mismatch warnings

2007-05-16 Thread Eugene Surovegin
Fix "Section mismatch" warnings Signed-off-by: Eugene Surovegin <[EMAIL PROTECTED]> --- drivers/net/ibm_emac/ibm_emac_mal.c |3 +-- drivers/net/ibm_emac/ibm_emac_mal.h |3 +-- drivers/net/ibm_emac/ibm_emac_rgmii.c |2 +- drivers/net/ibm_emac/ibm_emac_rgmii.h |

Re: [PATCH] ibm_emac: Correctly detect old link speed

2007-05-16 Thread Eugene Surovegin
On Wed, May 16, 2007 at 01:00:08PM +0200, Stefan Roese wrote: > This patch fixes a bug where the link speed change was not > detected correctly. This occured on a 440SPe (EMAC4) system > where the old link speed was 100Mbps and the new link speed > is 1000Mbps. Good catch, Stefan. Unfortunately, I

Re: NAPI and shared interrupt control

2006-12-07 Thread Eugene Surovegin
On Thu, Dec 07, 2006 at 02:20:10AM -0800, David Miller wrote: > It also just occured to me that even if you use the dummy device > approach, it's the dummy device's quota that will be used by the > generic ->poll() downcall into the driver. Yes, that's true. That's why I made this parameter Konfi

Re: NAPI and shared interrupt control

2006-12-07 Thread Eugene Surovegin
On Thu, Dec 07, 2006 at 01:59:54AM -0800, David Miller wrote: > From: Eugene Surovegin <[EMAIL PROTECTED]> > Date: Thu, 7 Dec 2006 01:45:02 -0800 > > > I fail to see how this is not even more ugly and more complex than the > > solution we have right now. Instead of t

Re: NAPI and shared interrupt control

2006-12-07 Thread Eugene Surovegin
On Thu, Dec 07, 2006 at 01:16:27AM -0800, David Miller wrote: > From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > Date: Thu, 07 Dec 2006 15:24:06 +1100 > > > > > > What Eugene does currently, which seems to me like it's actually the > > > only proper solution, is to create a separate net_device

Re: IBM_EMAC_PHY_RX_CLK_FIX depends on non-existing option 440GR

2006-02-07 Thread Eugene Surovegin
On Tue, Feb 07, 2006 at 11:14:49PM +0100, Adrian Bunk wrote: > Jean-Luc Leger <[EMAIL PROTECTED]> reported the following: > > from drivers/net/Kconfig: > config IBM_EMAC_PHY_RX_CLK_FIX > bool "PHY Rx clock workaround" > depends on IBM_EMAC && (405EP || 440GX || 440EP || 440GR) > ->

[PATCH] PPC44x EMAC driver: disable TX status deferral in half-duplex mode

2005-12-27 Thread Eugene Surovegin
is is relevant only for SoCs with EMAC4 core (440GX, 440SP, 440SPe). Tested on 440GX. Signed-off-by: Eugene Surovegin <[EMAIL PROTECTED]> --- ibm_emac.h |3 ++- ibm_emac_core.c |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ibm_emac/ibm_emac.h b/

[PATCH] ibm_emac: fix graceful stop timeout handling

2005-11-24 Thread Eugene Surovegin
several times to configure multicast list). Graceful channel stop can take up to 1 frame time, so I've added device specific timeout counter which depends on current link speed and calls to udelay() to really wait required amount of time before giving up. Signed-off-by: Eugene Surovegin &l

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Eugene Surovegin
On Tue, Sep 06, 2005 at 08:49:35PM -0700, Matt Mackall wrote: > On Tue, Sep 06, 2005 at 08:37:36PM -0700, Eugene Surovegin wrote: > > On Tue, Sep 06, 2005 at 08:22:25PM -0700, Matt Mackall wrote: > > > Which would I rather have: > > > > > > "netcons

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Eugene Surovegin
On Tue, Sep 06, 2005 at 08:35:32PM -0700, Matt Mackall wrote: > On Tue, Sep 06, 2005 at 08:19:34PM -0700, David S. Miller wrote: > > From: Matt Mackall <[EMAIL PROTECTED]> > > Date: Tue, 6 Sep 2005 20:08:10 -0700 > > > > > Think upon the kgdb-over-ethernet case, please. The kernel hits a > > > bre

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Eugene Surovegin
On Tue, Sep 06, 2005 at 08:22:25PM -0700, Matt Mackall wrote: > Which would I rather have: > > "netconsole never catches my oopses, it's useless." > > "netconsole didn't work with my driver, so I tried another card and it > works great." Well, not all world which uses Linux is PC with PCI slots

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Eugene Surovegin
On Tue, Sep 06, 2005 at 07:19:21PM -0700, Matt Mackall wrote: > > or a') make this a per-driver feature (e.g. NETIF_F_NETPOLL_CHALENGED) > > > > In this case, even if driver cannot handle being called from IRQ > > context, netconsole still can be used, although in a little more > > limited fashi

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Eugene Surovegin
On Tue, Sep 06, 2005 at 06:03:38PM -0700, Matt Mackall wrote: > On Tue, Sep 06, 2005 at 04:01:24PM -0700, David S. Miller wrote: > > So you cannot call into these drivers with HW interrupts disabled or > > even worse from HW interrupt context. These drivers use locking > > strategies which are per

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Eugene Surovegin
On Tue, Sep 06, 2005 at 03:36:27PM -0700, David S. Miller wrote: > From: Eugene Surovegin <[EMAIL PROTECTED]> > Date: Tue, 6 Sep 2005 15:04:17 -0700 > > > David, correct me if I'm wrong, but I think there is a major problem > > with current netconsole/netpoll ap

Re: Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Eugene Surovegin
On Tue, Sep 06, 2005 at 02:47:14PM -0700, David S. Miller wrote: > From: Eugene Surovegin <[EMAIL PROTECTED]> > Date: Tue, 6 Sep 2005 00:40:01 -0700 > > > According to Documentation/networking/netdevices.txt > > dev->hard_start_xmit must be c

Netconsole violates dev->hard_start_xmit synch rules

2005-09-06 Thread Eugene Surovegin
According to Documentation/networking/netdevices.txt dev->hard_start_xmit must be called with interrupts *enabled*. Unfortunately, current netconsole code always calls netpoll with local interrupts disabled: write_msg (local_irq_save) netpoll_send_udp netpoll_send_skb np->de

[PATCH] Ethtool support for the new PowerPC 4xx on-chip ethernet controller driver

2005-08-30 Thread Eugene Surovegin
Jeff, this patch adds PPC4xx EMAC support to Ethtool. Patch was generated against your Ethtool BK repo - I haven't found anything more recent. Let me know if you have gkernel GIT repository somewhere and I'll redo the patch if needed. Signed-off-by: Eugene Surovegin <[EMAIL PROT

[PATCH 2/2] New PowerPC 4xx on-chip ethernet controller driver

2005-08-30 Thread Eugene Surovegin
Add new PPC 4xx NAPI EMAC driver Signed-off-by: Eugene Surovegin <[EMAIL PROTECTED]> --- drivers/net/Kconfig | 70 + drivers/net/ibm_emac/Makefile | 11 drivers/net/ibm_emac/ibm_emac.h | 309 + drivers/net/ibm_emac/ibm_emac_core.c

[PATCH 1/2] New PowerPC 4xx on-chip ethernet controller driver

2005-08-30 Thread Eugene Surovegin
Remove old PPC4xx EMAC driver Signed-off-by: Eugene Surovegin <[EMAIL PROTECTED]> --- drivers/net/Kconfig | 34 - drivers/net/ibm_emac/Makefile | 12 drivers/net/ibm_emac/ibm_emac.h | 267 drivers/net/ibm_emac/ibm_emac_core.c

[PATCH 0/2] New PowerPC 4xx on-chip ethernet controller driver

2005-08-30 Thread Eugene Surovegin
I will be maintaining this new version. Signed-off-by: Eugene Surovegin <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html