Re: [PATCH] dt-bindings: Add missing array size constraints

2021-01-05 Thread Dmitry Torokhov
On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: > .../input/touchscreen/elan,elants_i2c.yaml| 1 + Acked-by: Dmitry Torokhov -- Dmitry

Re: [PATCH v4 08/11] Input: hyperv-keyboard: Use VMBUS_RING_SIZE() for ringbuffer sizes

2020-09-15 Thread Dmitry Torokhov
be minus 4k (the size of header when > PAGE_SIZE = 4k) than the original value to keep the ringbuffer total > size unchanged when PAGE_SIZE = 4k. > > Signed-off-by: Boqun Feng > Cc: Michael Kelley > Cc: Dmitry Torokhov Acked-by: Dmitry Torokhov Please feel free to merge through

Re: [PATCH v3 08/11] Input: hyperv-keyboard: Make ringbuffer at least take two pages

2020-09-13 Thread Dmitry Torokhov
Boqun Feng > > --- > > drivers/input/serio/hyperv-keyboard.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Reviewed-by: Michael Kelley Acked-by: Dmitry Torokhov Please feel free to merge with the rest of the patches through whatever tree they will go in. Thanks. -- Dmitry

[PATCH] rt2x00: remove input-polldev.h header

2019-10-02 Thread Dmitry Torokhov
The driver does not use input subsystem so we do not need this header, and it is being removed, so stop pulling it in. Signed-off-by: Dmitry Torokhov --- drivers/net/wireless/ralink/rt2x00/rt2x00.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00.h b

Re: [PATCH v4 9/9] Input: add IOC3 serio driver

2019-08-14 Thread Dmitry Torokhov
On Wed, Aug 14, 2019 at 06:57:55PM +0200, Jonas Gorski wrote: > On Wed, 14 Aug 2019 at 16:37, Thomas Bogendoerfer > wrote: > > > > On Wed, 14 Aug 2019 15:20:14 +0200 > > Jonas Gorski wrote: > > > > > > + d = devm_kzalloc(&pdev->dev, sizeof(*d), GFP_KERNEL); > > > > > > &pdev->dev => dev >

Re: [PATCH v4 1/5] usb: split code locating ACPI companion into port and device

2019-01-22 Thread Dmitry Torokhov
anion() into usb_acpi_find_companion_for_device() and > > > usb_acpi_find_companion_for_port(). > > > > > > Signed-off-by: Dmitry Torokhov > > > Signed-off-by: Rajat Jain > > > Acked-by: Greg Kroah-Hartman > > > Tested-by: Sukumar Ghor

Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time

2017-12-13 Thread Dmitry Torokhov
On Wed, Dec 13, 2017 at 1:52 PM, Eric Dumazet wrote: > On Wed, 2017-12-13 at 13:43 -0800, Dmitry Torokhov wrote: >> Hi Eric, >> >> On Thu, Oct 19, 2017 at 7:11 AM, Eric Dumazet wrote: >> > >> > On Thu, Oct 19, 2017 at 4:48 AM, Tariq Toukan wrote: >

Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time

2017-12-13 Thread Dmitry Torokhov
Hi Eric, On Thu, Oct 19, 2017 at 7:11 AM, Eric Dumazet wrote: > > On Thu, Oct 19, 2017 at 4:48 AM, Tariq Toukan wrote: > > > > Hi Eric, > > > > I just wanted to check if this is solved already, as I don't want to keep an > > unnecessary revert patch in our internal branches. > > According to my

Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time

2017-09-26 Thread Dmitry Torokhov
ards, >>>> Tariq >>>> >>>> >>>> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd stop >>>> Unloading HCA driver: [ OK ] >>>> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd start >>&g

Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data

2017-08-31 Thread Dmitry Torokhov
On Thu, Aug 31, 2017 at 4:59 PM, Kees Cook wrote: > On Thu, Aug 31, 2017 at 4:45 PM, Dmitry Torokhov > wrote: >> On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook wrote: >>> In several places, .data is checked for initialization to gate early >>> calls to del_timer_syn

Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data

2017-08-31 Thread Dmitry Torokhov
On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook wrote: > In several places, .data is checked for initialization to gate early > calls to del_timer_sync(). Checking for .function is equally valid, so > switch to this in all callers. Not seeing the rest of patches it is unclear from the patch descriptio

Re: [PATCH v2 03/11] tty: kbd: reduce stack size with KASAN

2017-06-16 Thread Dmitry Torokhov
On Fri, Jun 16, 2017 at 1:56 PM, Arnd Bergmann wrote: > On Fri, Jun 16, 2017 at 7:29 PM, Dmitry Torokhov > wrote: >> On Fri, Jun 16, 2017 at 8:58 AM, Samuel Thibault >> wrote: >>> I'm however afraid we'd have to mark a lot of static functions that way, >

Re: [PATCH v2 03/11] tty: kbd: reduce stack size with KASAN

2017-06-16 Thread Dmitry Torokhov
On Fri, Jun 16, 2017 at 8:58 AM, Samuel Thibault wrote: > Arnd Bergmann, on ven. 16 juin 2017 17:41:47 +0200, wrote: >> The problem are the 'ch' and 'flag' variables that are passed into >> tty_insert_flip_char by value, and from there into >> tty_insert_flip_string_flags by reference. In this ca

[PATCH] drivers: net: ethernet: remove incorrect __exit markups

2017-03-01 Thread Dmitry Torokhov
: Dmitry Torokhov --- drivers/net/ethernet/amd/declance.c| 30 +++--- drivers/net/ethernet/broadcom/sb1250-mac.c | 4 ++-- drivers/net/ethernet/faraday/ftgmac100.c | 4 ++-- drivers/net/ethernet/faraday/ftmac100.c| 4 ++-- drivers/net/ethernet/seeq/sgiseeq.c

[PATCH v2 3/4] ptp: use is_visible method to hide unused attributes

2017-02-14 Thread Dmitry Torokhov
e of later) before userspace gets notified about new ptp class device. Signed-off-by: Dmitry Torokhov --- drivers/ptp/ptp_sysfs.c | 125 +--- 1 file changed, 55 insertions(+), 70 deletions(-) diff --git a/drivers/ptp/ptp_sysfs.c b/drivers/ptp/ptp_sys

[PATCH v2 4/4] ptp: create "pins" together with the rest of attributes

2017-02-14 Thread Dmitry Torokhov
Let's switch to using device_create_with_groups(), which will allow us to create "pins" attribute group together with the rest of ptp device attributes, and before userspace gets notified about ptp device creation. Signed-off-by: Dmitry Torokhov --- drivers/ptp/ptp

[PATCH v2 2/4] ptp: use kcalloc when allocating arrays

2017-02-14 Thread Dmitry Torokhov
kcalloc is more semantically correct when allocating arrays of objects, and overflow-safe. Signed-off-by: Dmitry Torokhov --- drivers/ptp/ptp_sysfs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/ptp/ptp_sysfs.c b/drivers/ptp/ptp_sysfs.c index 53d43954a974

[PATCH v2 0/4] PTP attribute handling cleanup

2017-02-14 Thread Dmitry Torokhov
rd's request - added a cover letter v1: - initial patch set Dmitry Torokhov (4): ptp: do not explicitly set drvdata in ptp_clock_register() ptp: use kcalloc when allocating arrays ptp: use is_visible method to hide unused attributes ptp: create "pins" together with the re

[PATCH v2 1/4] ptp: do not explicitly set drvdata in ptp_clock_register()

2017-02-14 Thread Dmitry Torokhov
We do not need explicitly call dev_set_drvdata(), as it is done for us by device_create(). Acked-by: Richard Cochran Signed-off-by: Dmitry Torokhov --- drivers/ptp/ptp_clock.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c index

Re: [PATCH 3/4] ptp: use is_visible method to hide unused attributes

2017-02-14 Thread Dmitry Torokhov
Hi Richard, On Tue, Feb 14, 2017 at 09:42:26AM +0100, Richard Cochran wrote: > On Mon, Feb 13, 2017 at 07:51:07PM -0800, Dmitry Torokhov wrote: > > Instead of creating selected attributes after the device is created (and > > after userspace potentially seen uevent), lets use

[PATCH 2/4] ptp: use kcalloc/kmallco_array when allocating arrays

2017-02-13 Thread Dmitry Torokhov
kcalloc/kmalloc_array are more semantically correct when allocating arrays of objects, and overflow-safe. Signed-off-by: Dmitry Torokhov --- drivers/ptp/ptp_sysfs.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/ptp/ptp_sysfs.c b/drivers/ptp/ptp_sysfs.c

[PATCH 1/4] ptp: do not explicitly set drvdata in ptp_clock_register()

2017-02-13 Thread Dmitry Torokhov
We do not need explicitly call dev_set_drvdata(), as it is done for us by device_create(). Signed-off-by: Dmitry Torokhov --- drivers/ptp/ptp_clock.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c index 9c13381b6966..b4e5e8022c29 100644

[PATCH 4/4] ptp: create "pins" together with the rest of attributes

2017-02-13 Thread Dmitry Torokhov
Let's switch to using device_create_with_groups(), which will allow us to create "pins" attribute group together with the rest of ptp device attributes, and before userspace gets notified about ptp device creation. Signed-off-by: Dmitry Torokhov --- drivers/ptp/ptp

[PATCH 3/4] ptp: use is_visible method to hide unused attributes

2017-02-13 Thread Dmitry Torokhov
e of later) before userspace gets notified about new ptp class device. Signed-off-by: Dmitry Torokhov --- drivers/ptp/ptp_sysfs.c | 125 +--- 1 file changed, 55 insertions(+), 70 deletions(-) diff --git a/drivers/ptp/ptp_sysfs.c b/drivers/ptp/ptp_sys

Re: [PATCH v3 3/3] Bluetooth: hidp: fix possible might sleep error in hidp_session_thread

2017-02-13 Thread Dmitry Torokhov
Hi Jeffy, On Sun, Feb 12, 2017 at 8:12 PM, Jeffy Chen wrote: > It looks like hidp_session_thread has same pattern as the issue reported in > old rfcomm: > > while (1) { > set_current_state(TASK_INTERRUPTIBLE); > if (condition) > brea

Re: [PATCH] net: Use ns_capable_noaudit() when determining net sysctl permissions

2016-10-01 Thread Dmitry Torokhov
On Sat, Oct 01, 2016 at 03:25:04AM -0400, David Miller wrote: > From: Dmitry Torokhov > Date: Fri, 30 Sep 2016 15:24:31 -0700 > > > From: Tyler Hicks > > > > The capability check should not be audited since it is only being used > > to determine the inode per

Re: [PATCH v2 3/3] net: make net namespace sysctls belong to container's owner

2016-09-30 Thread Dmitry Torokhov
On Fri, Sep 30, 2016 at 01:21:27AM -0400, David Miller wrote: > From: Dmitry Torokhov > Date: Thu, 29 Sep 2016 08:46:05 -0700 > > > Hi David, > > > > On Wed, Aug 10, 2016 at 2:36 PM, Dmitry Torokhov > > wrote: > >> If net namespace is attached

[PATCH] net: Use ns_capable_noaudit() when determining net sysctl permissions

2016-09-30 Thread Dmitry Torokhov
: Serge E. Hallyn Signed-off-by: James Morris [dtor: reapplied after e79c6a4fc923 ("net: make net namespace sysctls belong to container's owner") accidentally reverted the change.] Signed-off-by: Dmitry Torokhov --- net/sysctl_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [PATCH v2 3/3] net: make net namespace sysctls belong to container's owner

2016-09-29 Thread Dmitry Torokhov
Hi David, On Wed, Aug 10, 2016 at 2:36 PM, Dmitry Torokhov wrote: > If net namespace is attached to a user namespace let's make container's > root owner of sysctls affecting said network namespace instead of global > root. > > This also allows us to clean up net_ctl_pe

Re: [PATCH 0/5] Make /sys/class/net per net namespace objects belong to container

2016-09-14 Thread Dmitry Torokhov
On Mon, Aug 29, 2016 at 5:38 AM, Eric W. Biederman wrote: > David Miller writes: > >> From: Dmitry Torokhov >> Date: Tue, 16 Aug 2016 15:33:10 -0700 >> >>> There are objects in /sys hierarchy (/sys/class/net/) that logically belong >>> to a namespace/

Re: [PATCH 0/5] Make /sys/class/net per net namespace objects belong to container

2016-08-22 Thread Dmitry Torokhov
On Sun, Aug 21, 2016 at 11:41:39PM -0700, David Miller wrote: > From: Dmitry Torokhov > Date: Tue, 16 Aug 2016 15:33:10 -0700 > > > There are objects in /sys hierarchy (/sys/class/net/) that logically belong > > to a namespace/container. Unfortunately all sysfs obj

[PATCH 4/5] driver core: set up ownership of class devices in sysfs

2016-08-16 Thread Dmitry Torokhov
Plumb in get_ownership() callback for devices belonging to a class so that they can be created with uid/gid different from global root. This will allow network devices in a container to belong to container's root and not global root. Signed-off-by: Dmitry Torokhov --- drivers/base/core.c

[PATCH 0/5] Make /sys/class/net per net namespace objects belong to container

2016-08-16 Thread Dmitry Torokhov
ing a network device into a container) as userspace can easily do it. Thanks! Dmitry Torokhov (5): kernfs: allow creating kernfs objects with arbitrary uid/gid sysfs, kobject: allow creating kobject belonging to arbitrary users kobject: kset_create_and_add() - fetch ownership info from p

[PATCH 1/5] kernfs: allow creating kernfs objects with arbitrary uid/gid

2016-08-16 Thread Dmitry Torokhov
and always create objects belonging to the global root. When creating symlinks ownership (uid/gid) is taken from the target kernfs object. Signed-off-by: Dmitry Torokhov --- fs/kernfs/dir.c | 29 ++--- fs/kernfs/file.c| 8 ++-- fs/kern

[PATCH 5/5] net-sysfs: make sure objects belong to contrainer's owner

2016-08-16 Thread Dmitry Torokhov
When creating various objects in /sys/class/net/... make sure that they belong to container's owner instead of global root (if they belong to a container/namespace). Signed-off-by: Dmitry Torokhov --- net/core/net-sysfs.c | 44 +++- 1 file change

[PATCH 3/5] kobject: kset_create_and_add() - fetch ownership info from parent

2016-08-16 Thread Dmitry Torokhov
global root for network devices in a container. Signed-off-by: Dmitry Torokhov --- lib/kobject.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/kobject.c b/lib/kobject.c index 7d516d9..f81ac7c 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -890,9 +890,16 @@ static vo

[PATCH 2/5] sysfs, kobject: allow creating kobject belonging to arbitrary users

2016-08-16 Thread Dmitry Torokhov
k for allowing network namespace objects ownership to be transferred to container's root user by defining get_ownership() callback in ktype structure and using it in sysfs code to retrieve desired uid/gid when creating sysfs objects for given kobject. Signed-off-by: Dmitry Torokhov --- fs/s

[PATCH v2 0/3] Make /proc per net namespace objects belong to container

2016-08-10 Thread Dmitry Torokhov
FIG_NET_NS (new patch #1) - addressed Eric'c comments for error handling style in patch #3 and added his Ack - adjusted patch #2 to use the same style of erro handling - sent out as series instead of separate patches Dmitry Torokhov (3): netns: do not call pernet ops for not yet set u

[PATCH v2 2/3] proc: make proc entries inherit ownership from parent

2016-08-10 Thread Dmitry Torokhov
er-ns "net" proc entry set it up as owned by container's owner. Signed-off-by: Dmitry Torokhov --- fs/proc/generic.c | 2 ++ fs/proc/proc_net.c | 13 + 2 files changed, 15 insertions(+) diff --git a/fs/proc/generic.c b/fs/proc/generic.c index c633476..bca66d8 10064

[PATCH v2 1/3] netns: do not call pernet ops for not yet set up init_net namespace

2016-08-10 Thread Dmitry Torokhov
et_operations(), because many pernet ops are marked as __net_initdata and will be discarded, which wreaks havoc on our ops lists. Here we rely on the fact that we only use lists until init_net is fully initialized, which happens much earlier than discarding __net_initdata sections. Signed-off-by: Dm

[PATCH v2 3/3] net: make net namespace sysctls belong to container's owner

2016-08-10 Thread Dmitry Torokhov
er since it now owns the objects in question. Acked-by: "Eric W. Biederman" Signed-off-by: Dmitry Torokhov --- fs/proc/proc_sysctl.c | 5 + include/linux/sysctl.h | 4 net/sysctl_net.c | 29 - 3 files changed, 29 insertions(+), 9 deletions

Re: [PATCH] proc: make proc entries inherit ownership from parent

2016-08-08 Thread Dmitry Torokhov
On Thu, Aug 4, 2016 at 8:22 PM, Dmitry Torokhov wrote: > There are certain parameters that belong to net namespace and that are > exported in /proc. They should be controllable by the container's owner, > but are currently owned by global root and thus not available. > > Let&#

Re: [PATCH] net: make net namespace sysctls belong to container's owner

2016-08-08 Thread Dmitry Torokhov
On Mon, Aug 8, 2016 at 2:08 PM, Eric W. Biederman wrote: > Dmitry Torokhov writes: > >> If net namespace is attached to a user namespace let's make container's >> root owner of sysctls affecting said network namespace instead of global >> root. >

[PATCH] proc: make proc entries inherit ownership from parent

2016-08-04 Thread Dmitry Torokhov
er-ns "net" proc entry set it up as owned by container's owner. Signed-off-by: Dmitry Torokhov --- fs/proc/generic.c | 2 ++ fs/proc/proc_net.c | 13 + 2 files changed, 15 insertions(+) diff --git a/fs/proc/generic.c b/fs/proc/generic.c index c633476..bca66d8 10064

[PATCH] net: make net namespace sysctls belong to container's owner

2016-08-02 Thread Dmitry Torokhov
er since it now owns the objects in question. Signed-off-by: Dmitry Torokhov --- This helps when running Android CTS in a container, but I think it makes sense regardless. fs/proc/proc_sysctl.c | 5 + include/linux/sysctl.h | 4 net/sysctl_net.c | 27 ++---

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Dmitry Torokhov
gt; > Cc: Konrad Rzeszutek Wilk > > Cc: Boris Ostrovsky > > Cc: David Vrabel > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: "H. Peter Anvin" > > Cc: x...@kernel.org > > Cc: "Roger Pau Monné" > > Cc: Dmitry Torokhov > > C

Re: [PATCH] nf: IDLETIMER: fix lockdep warning

2015-07-13 Thread Dmitry Torokhov
On Mon, Jul 13, 2015 at 6:20 AM, Pablo Neira Ayuso wrote: > On Thu, Jul 09, 2015 at 05:15:01PM -0700, Dmitry Torokhov wrote: >> Dynamically allocated sysfs attributes should be initialized with >> sysfs_attr_init() otherwise lockdep will be angry with us: >> >&

[PATCH] nf: IDLETIMER: fix lockdep warning

2015-07-09 Thread Dmitry Torokhov
: I1da5cd96fc8e1e1e4209e81eba1165a42d4d45e9 Signed-off-by: Dmitry Torokhov --- net/netfilter/xt_IDLETIMER.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netfilter/xt_IDLETIMER.c b/net/netfilter/xt_IDLETIMER.c index 31f76cd..0975c993 100644 --- a/net/netfilter/xt_IDLETIMER.c +++ b/net

Re: [PATCH] Remove pointless casts from void pointers,

2007-10-26 Thread Dmitry Torokhov
On 10/26/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > drivers/input/touchscreen/h3600_ts_input.c |4 ++-- Acked-by: Dmitry Torokhov <[EMAIL PROTECTED]> -- Dmitry - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: linux kernel networking code review request

2007-10-19 Thread Dmitry Torokhov
On Friday 19 October 2007, Templin, Fred L wrote: > Hello, > > I would like to get a review on some new Linux > kernel networking code. The code is based on the > 2.6.23 source tree and touches three files - two > in ./net/ipv6 and one in ./include/net. What is > the proper procedure for requestin

Re: [RFC 0/3] rfkill

2007-09-09 Thread Dmitry Torokhov
Hi Ivo, On Saturday 08 September 2007 11:10, Ivo van Doorn wrote: > Hi Dmitry, > > I have a few rfkill related patches for which I would prefer if you to could > take a look at before I send them for inclusion. > Looks good, feel free to add Acked-by: Dmitry T

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-07-28 Thread Dmitry Torokhov
On Friday 27 July 2007 16:12, Andrew Morton wrote: > On Fri, 27 Jul 2007 21:43:59 +0200 > Michael Buesch <[EMAIL PROTECTED]> wrote: > > > > Sure, but why is the locking interruptible rather than plain old > > > mutex_lock()? > > > > Hm, well. We hold this mutex for several seconds, as writing tak

Re: [RFC] RF Kill

2007-05-06 Thread Dmitry Torokhov
Hi David, On Thursday 26 April 2007 03:54, David Miller wrote: > From: David Miller <[EMAIL PROTECTED]> > Date: Thu, 26 Apr 2007 00:49:51 -0700 (PDT) > > > From: Dmitry Torokhov <[EMAIL PROTECTED]> > > Date: Tue, 10 Apr 2007 02:29:31 -0400 > > >

Re: [RFC] RF Kill

2007-04-26 Thread Dmitry Torokhov
On 4/26/07, David Miller <[EMAIL PROTECTED]> wrote: From: Dmitry Torokhov <[EMAIL PROTECTED]> Date: Tue, 10 Apr 2007 02:29:31 -0400 > On Tuesday 10 April 2007 01:58, Dmitry Torokhov wrote: > > Hi, > > > > This is a modified version of rfkill patch tha

Re: [RFC] RF Kill

2007-04-26 Thread Dmitry Torokhov
On 4/26/07, David Miller <[EMAIL PROTECTED]> wrote: Actually, I'm reverting this, sorry. Besides the locking and other issues I pointed out, this thing won't even link. Please do not test the build with various configurations when submitting new code like this. Thanks. MODPOST 139 modules W

Re: [RFC] RF Kill

2007-04-09 Thread Dmitry Torokhov
On Tuesday 10 April 2007 01:58, Dmitry Torokhov wrote: > Hi, > > This is a modified version of rfkill patch that provides infrastructure > for controlling state of RF transmitters found on various cards. Well, Andrew found bunch of issues with the patch so here is an upd

[RFC] RF Kill

2007-04-09 Thread Dmitry Torokhov
Add support for input key to control wireless radio Signed-off-by Ivo van Doorn <[EMAIL PROTECTED]> Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- include/linux/rfkill.h| 85 + net/Kconfig |1 net/Makefile |1 net/rfkill/K

Re: [RFC] rfkill - Add support for input key to control wireless radio

2007-04-01 Thread Dmitry Torokhov
key to control wireless radio Signed-off-by Ivo van Doorn <[EMAIL PROTECTED]> Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- include/linux/rfkill.h| 85 + net/Kconfig |1 net/Makefile |1 net/rfkill/Kconfig| 24 ++ net/r

Re: [RFC] rfkill - Add support for input key to control wireless radio

2007-03-30 Thread Dmitry Torokhov
On 3/30/07, Ivo van Doorn <[EMAIL PROTECTED]> wrote: > > > > > > My only concern is where rfkill code should live. Since it is no > > > longer dependent on input core (embedded systems might disable > > > rfkill-input and use bare rfkill and control state from userspace) > > > it does not need to

Re: [RFC] rfkill - Add support for input key to control wireless radio

2007-03-30 Thread Dmitry Torokhov
On 3/30/07, Ivo van Doorn <[EMAIL PROTECTED]> wrote: Hi, > I am very sorry for taking so much time to respond but finally I went > through the patch and I still have the same objection as before - > it mixes two logically (and often physically) separated objects into > a single entity. I think t

Re: [RFC] rfkill - Add support for input key to control wireless radio

2007-03-29 Thread Dmitry Torokhov
control state from userspace) it does not need to live in drivers/input. Please let me know what you think. -- Dmitry From: Ivo van Doorn <[EMAIL PROTECTED]> Input: rfkill - Add support for input key to control wireless radio Signed-off-by Ivo van Doorn <[EMAIL PROTECTED]> Signed-of

Re: [RFC] rfkill - Add support for input key to control wireless radio

2007-03-29 Thread Dmitry Torokhov
Input: polled device skeleton Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/misc/Kconfig | 11 ++ drivers/input/misc/Makefile|1 drivers/input/misc/input-polldev.c | 149 + include/linux/input-pol

Re: Network: convert network devices to use struct device instead of class_device

2007-02-20 Thread Dmitry Torokhov
On 2/8/07, Greg KH <[EMAIL PROTECTED]> wrote: And it should also alow for proper power management functionality, using the changes that Linus put into the driver core about 8 months ago. Don't worry, I have input patches queued up next for you Dmitry :) Greg, Could you please forward me the

Re: Network: convert network devices to use struct device instead of class_device

2007-02-09 Thread Dmitry Torokhov
On 2/9/07, Kay Sievers <[EMAIL PROTECTED]> wrote: On Thu, 2007-02-08 at 22:59 -0500, Dmitry Torokhov wrote: > On Thursday 08 February 2007 19:56, Greg KH wrote: > > On Thu, Feb 08, 2007 at 12:29:12PM -0500, Dmitry Torokhov wrote: > > > On 2/8/07, Stephen Hemminger &

Re: Network: convert network devices to use struct device instead of class_device

2007-02-08 Thread Dmitry Torokhov
On Thursday 08 February 2007 19:56, Greg KH wrote: > On Thu, Feb 08, 2007 at 12:29:12PM -0500, Dmitry Torokhov wrote: > > On 2/8/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > >On Thu, 08 Feb 2007 07:43:18 -0500 > > >Jeff Garzik <[EMAIL PROTECTED]> w

Re: Network: convert network devices to use struct device instead of class_device

2007-02-08 Thread Dmitry Torokhov
On 2/8/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: On Thu, 08 Feb 2007 07:43:18 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Linux Kernel Mailing List wrote: > > Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=43cb76d91ee85f579a69d42bc8efc08bac

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-11 Thread Dmitry Torokhov
Hi Ivo, On Thursday 07 December 2006 16:53, Ivo van Doorn wrote: > Hi, > > > > > >  2 - Hardware key that does not control the hardware radio and does > > > > > not report anything to userspace > > > > > > > > Kind of uninteresting button ;) > > > > > > And this is the button that rfkill was ori

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-06 Thread Dmitry Torokhov
On 12/6/06, Jiri Benc <[EMAIL PROTECTED]> wrote: On Wed, 6 Dec 2006 15:18:12 -0500, Dmitry Torokhov wrote: > On 12/6/06, Ivo van Doorn <[EMAIL PROTECTED]> wrote: > > Ok, so input device opening should not block the rfkill signal and the rfkill handler > > should sti

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-06 Thread Dmitry Torokhov
On 12/6/06, Ivo van Doorn <[EMAIL PROTECTED]> wrote: > > 2 - Hardware key that does not control the hardware radio and does not report anything to userspace > > Kind of uninteresting button ;) And this is the button that rfkill was originally designed for. Laptops with integrated WiFi cards f

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-06 Thread Dmitry Torokhov
On 12/6/06, Ivo van Doorn <[EMAIL PROTECTED]> wrote: On Wednesday 06 December 2006 15:37, Dmitry Torokhov wrote: > On 12/4/06, Ivo van Doorn <[EMAIL PROTECTED]> wrote: > > > I am still not sure that tight coupling of input device with rfkill > > > structure is

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-06 Thread Dmitry Torokhov
On 12/6/06, Dan Williams <[EMAIL PROTECTED]> wrote: On Wed, 2006-12-06 at 09:37 -0500, Dmitry Torokhov wrote: > > Fans of the 3rd method, speak up ;) I think I brought up the 3rd method initially in this thread. I'm not necessarily advocating it, but I wanted to be sure peo

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-06 Thread Dmitry Torokhov
On 12/4/06, Ivo van Doorn <[EMAIL PROTECTED]> wrote: > I am still not sure that tight coupling of input device with rfkill > structure is such a good idea. Quite often the button is separated > from the device itself and radio control is done via BIOS SMM (see > wistron driver) or there is no spe

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-12-06 Thread Dmitry Torokhov
On 12/6/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: On Wednesday, 6. December 2006 02:44, you wrote: > FYI...after latest round of merges, that patch that I've been carrying > in the pending branch of wireless-2.6 no longer applies. > > John Ok, I'm waiting for Dmitry' feedback... (hello,

Re: [RFC] rfkill - Add support for input key to control wireless radio

2006-12-04 Thread Dmitry Torokhov
On 12/3/06, Ivo van Doorn <[EMAIL PROTECTED]> wrote: Hi, This patch is a resend of a patch I has been send to the linux kernel and netdev list earlier. The most recent version of a few weeks back didn't compile since I missed 1 line in my patch that changed include/linux/input.h. This patch wil

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-25 Thread Dmitry Torokhov
On Saturday 25 November 2006 11:50, [EMAIL PROTECTED] wrote: > On Saturday, 25. November 2006 06:39, you wrote: > > Ok, it looks like the patch changed the order of netdevice registration vs. > > requesting firmware. My scripts are trying to set ESSID and keys before > > firmware even gets loaded i

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-17 Thread Dmitry Torokhov
On Friday 17 November 2006 15:53, [EMAIL PROTECTED] wrote: > > > > The card is WG511 talking to netgear WGR614 router. I am using WEP128 > > with shared keys. Router is set to be "g" only. The OS is Fedora Core > > 3 (I swear I will upgrade :) ), just recompiled wireless tools from > > sources in F

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-17 Thread Dmitry Torokhov
On 11/17/06, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: On 11/17/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > > The reason for me trying the patch is that the card locks up > > frequently (the amber transmission light turns on stays this way). > &g

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-17 Thread Dmitry Torokhov
On 11/17/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > The reason for me trying the patch is that the card locks up > frequently (the amber transmission light turns on stays this way). Do you get any fancy "mgt timeout ..." or something in dmesg, when the cards locks up? (include one, if

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-17 Thread Dmitry Torokhov
On 11/17/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Am Freitag, 17. November 2006 06:42 schrieben Sie: > > > > No, more that my card doesn't successfully associate at all even > > _without_ the patch on unencrypted or WEP APs; I just can't test it, > > since my card seems to be broken... >

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-16 Thread Dmitry Torokhov
On Friday 10 November 2006 09:42, Dan Williams wrote: > On Thu, 2006-11-09 at 18:16 -0500, Luis R. Rodriguez wrote: > > On 11/9/06, Luis R. Rodriguez <[EMAIL PROTECTED]> wrote: > > > On 11/9/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > > Am Mittwoch, 8. November 2006 01:39 schrieben Sie:

Re: IPv4: ip_options_compile() how can we avoid blowing up on a NULL skb???

2006-11-16 Thread Dmitry Torokhov
On Thursday 16 November 2006 19:37, Herbert Xu wrote: > David Miller <[EMAIL PROTECTED]> wrote: > > > > I'm very happy to accept a patch which assert's this using BUG() > > checks :-) > > A BUG() won't be necessary because the NULL pointer dereferences will > OOPS anyway. > BUG()s there would be

[patch 1/2] prism54: fix potential race in reset scheduling

2006-10-07 Thread Dmitry Torokhov
is needed. This race is mostly theoretical as far as I can see but a race nonetheless. Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/net/wireless/prism54/islpci_eth.c | 23 +-- 1 files changed, 13 insertions(+), 10 deletions(-) Index: work/driv

[patch 2/2] prism54: whitespace cleanup

2006-10-07 Thread Dmitry Torokhov
NET: prism54 - whitespace cleanup Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/net/wireless/prism54/isl_38xx.c | 17 +++ drivers/net/wireless/prism54/isl_38xx.h |7 +- drivers/net/wireless/prism54/isl_ioctl.c

[patch 0/2] prism54: couple of cleanup patches

2006-10-07 Thread Dmitry Torokhov
Hi, Here are couple of patches for prism54 driver, they are against tonight pull from Linus. Please consider applying. Thanks! -- Dmitry - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.or

[patch 2/3] atmel: use ARRAY_SIZE()

2006-10-07 Thread Dmitry Torokhov
NET: atmel - switch to using ARRAY_SIZE() Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/net/wireless/atmel.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) Index: work/drivers/net/wireless/a

[patch 3/3] atmel: whitespace cleanup

2006-10-07 Thread Dmitry Torokhov
NET: atmel: whitespace cleanup Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/net/wireless/atmel.c |6 +-- drivers/net/wireless/atmel_cs.c | 74 +++ drivers/net/wireless/atmel_pci.c | 10 ++--- 3 files changed, 45 inse

[patch 0/3] atmel: couple of cleanup patches

2006-10-07 Thread Dmitry Torokhov
Hi, Here are couple of cleanup patches for atmel driver. They are against tonight pull from Linus. Please consider applying. Thanks! -- Dmitry - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ker

[patch 1/3] atmel: save on array initialization

2006-10-07 Thread Dmitry Torokhov
NET: atmel - do not initialize array over and over again Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/net/wireless/atmel.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: work/drivers/net/wireless/a

Re: 2.6.18-rc7-mm1: networking breakage on HPC nx6325 + SUSE 10.1

2006-09-19 Thread Dmitry Torokhov
representation of class_device structure from /sys/class/... to /sys/device/... to provide unified device tree; create symlinks in /sys/class pointing to /sys/device/... to preserve existing classification of devices. Create /sys/device/virtual device which is parent for all class_devices that do not

Re: [patch 8/9] smsc-ircc2: fix section reference mismatches

2006-07-07 Thread Dmitry Torokhov
On 7/7/06, Jeff Garzik <[EMAIL PROTECTED]> wrote: [EMAIL PROTECTED] wrote: > From: Dmitry Torokhov <[EMAIL PROTECTED]> > > subsystem_configurations array is only used by an __init function, > therefore it should be marked __initdata, not __devinitdata. > > Signed-o

Re: [patch 1/3] atmel: save on array initialization

2005-12-01 Thread Dmitry Torokhov
On Thursday 01 December 2005 11:36, Dmitry Torokhov wrote: > On 12/1/05, Jeff Garzik <[EMAIL PROTECTED]> wrote: > > Dmitry Torokhov wrote: > > > NET: atmel - do not initialize array over and over again > > > > > > Signed-off-by: Dmitry Torokhov <[

Re: [patch 1/3] atmel: save on array initialization

2005-12-01 Thread Dmitry Torokhov
On 12/1/05, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Dmitry Torokhov wrote: > > NET: atmel - do not initialize array over and over again > > > > Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> > > can you resend this series without MIME attachments? >

Re: Mouse issues in -mm

2005-11-25 Thread Dmitry Torokhov
On Thursday 24 November 2005 01:14, Frank Sorenson wrote: > Note: I believe this issue may also be related to the mouse protocol > extension.  I typically run with 'psmouse.proto=exps' on the kernel > command line, and the psmouse resync patch seems to break tapping in > that mode. So the resync p

Re: Mouse issues in -mm

2005-11-23 Thread Dmitry Torokhov
On Wednesday 23 November 2005 21:06, Frank Sorenson wrote: > Andrew Morton wrote: > > Marc Koschewski <[EMAIL PROTECTED]> wrote: > >>Just booted into 2.6.15-rc2-mm1. The 'mouse problem' (as reported earlier) > >>still > >>persists, > > > > You'l probably need to re-report the mouse problem if the

[patch 2/3] atmel: use ARRAY_SIZE()

2005-11-18 Thread Dmitry Torokhov
NET: atmel - switch to using ARRAY_SIZE() Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/net/wireless/atmel.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) Index: work/drivers/net/wireless/a

[patch 1/3] atmel: save on array initialization

2005-11-18 Thread Dmitry Torokhov
NET: atmel - do not initialize array over and over again Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/net/wireless/atmel.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Index: work/drivers/net/wireless/a

[patch 0/3] Minor atmel driver changes

2005-11-18 Thread Dmitry Torokhov
Hi, Have a couple of minor changes for atmel wireless driver, please consider applying. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html