[PATCH ethtool] igc: Fix output values case

This patch changes the output values to be lowercase and replaces "True"/"False" by "yes"/"no" so the output from the IGC driver is consistent with other Intel drivers. Signed-off-by: Andre Guedes --- igc.c | 36 ++

Re: [Intel-wired-lan] [PATCH ethtool 0/4] Add support for IGC driver

Hi Michal, Quoting Michal Kubecek (2020-07-19 17:10:46) > On Tue, Jul 07, 2020 at 04:47:56PM -0700, Andre Guedes wrote: > > Hi all, > > > > This patch series adds support for parsing registers dumped by the IGC > > driver. > > For now, t

[PATCH ethtool 2/4] igc: Parse RCTL register fields

This patch adds support for parsing the Receive Control (RCTL) register fields. Signed-off-by: Andre Guedes --- igc.c | 91 ++- 1 file changed, 90 insertions(+), 1 deletion(-) diff --git a/igc.c b/igc.c index 91ab64d..df3916c 100644 --- a

[PATCH ethtool 1/4] Add IGC driver support

This patch adds the initial support for parsing registers dumped by the IGC driver. At this moment, only the Receive Address Low (RAL) and the Receive Address High (RAH) registers are parsed. More registers will be added on demand. Signed-off-by: Andre Guedes --- Makefile.am | 3 ++- ethtool.c

[PATCH ethtool 4/4] igc: Parse ETQF registers

This patch adds support for parsing the EType Queue Filter (ETQF) registers fields. Signed-off-by: Andre Guedes --- igc.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/igc.c b/igc.c index 6a2e06d..9c0a750 100644 --- a/igc.c +++ b/igc.c @@ -59,6 +59,14

[PATCH ethtool 3/4] igc: Parse VLANPQF register fields

This patch adds support for parsing the VLAN Priority Queue Filter (VLANPQF) register fields. Signed-off-by: Andre Guedes --- igc.c | 98 +++ 1 file changed, 98 insertions(+) diff --git a/igc.c b/igc.c index df3916c..6a2e06d 100644 --- a

[PATCH ethtool 0/4] Add support for IGC driver

) * EType Queue Filter (ETQF) More registers should be parsed as we need/enable them. Cheers, Andre Andre Guedes (4): Add IGC driver support igc: Parse RCTL register fields igc: Parse VLANPQF register fields igc: Parse ETQF registers Makefile.am | 3 +- ethtool.c | 1 + igc.c

Re: [net-next 05/13] igc: Check __IGC_PTP_TX_IN_PROGRESS instead of ptp_tx_skb

Quoting Jakub Kicinski (2020-06-29 15:11:17) > On Mon, 29 Jun 2020 13:51:32 -0700 Andre Guedes wrote: > > > > @@ -435,6 +432,9 @@ static void igc_ptp_tx_hwtstamp(struct igc_adapter > > > > *adapter) > > > > struct igc_hw *hw =

Re: [net-next 05/13] igc: Check __IGC_PTP_TX_IN_PROGRESS instead of ptp_tx_skb

Hi Jakub, Quoting Jakub Kicinski (2020-06-26 21:30:35) > On Fri, 26 Jun 2020 18:54:23 -0700 Jeff Kirsher wrote: > > From: Andre Guedes > > > > The __IGC_PTP_TX_IN_PROGRESS flag indicates we have a pending Tx > > timestamp. In some places, instead of checking that

Re: [Intel-wired-lan] [next-queue RFC 0/4] ethtool: Add support for frame preemption

Hi, Quoting Jakub Kicinski (2020-05-18 16:09:06) > On Mon, 18 May 2020 16:05:08 -0700 Vinicius Costa Gomes wrote: > > Jakub Kicinski writes: > > >> That was the (only?) strong argument in favor of having frame preemption > > >> in the TC side when this was last discussed. > > >> > > >> We can ha

Re: [net-next 00/14][pull request] 1GbE Intel Wired LAN Driver Updates 2020-05-19

Hi Jakub, Quoting Jakub Kicinski (2020-05-19 19:00:26) > On Tue, 19 May 2020 17:04:05 -0700 Jeff Kirsher wrote: > > This series contains updates to igc only. > > > > Sasha cleans up the igc driver code that is not used or needed. > > > > Vitaly cleans up driver code that was used to support Virt

Re: [next-queue RFC 0/4] ethtool: Add support for frame preemption

Hi, Quoting Vinicius Costa Gomes (2020-05-18 12:34:22) > Hi, > > Michal Kubecek writes: > > > On Fri, May 15, 2020 at 06:29:44PM -0700, Vinicius Costa Gomes wrote: > >> Hi, > >> > >> This series adds support for configuring frame preemption, as defined > >> by IEEE 802.1Q-2018 (previously IEEE

Re: [next-queue RFC 0/4] ethtool: Add support for frame preemption

Hi, Quoting Vinicius Costa Gomes (2020-05-15 18:29:44) > One example, for retrieving and setting the configuration: > > $ ethtool $ sudo ./ethtool --show-frame-preemption enp3s0 > Frame preemption settings for enp3s0: > support: supported > active: active IIUC the code in patch 2

Re: [net-next v3 4/9] igc: Use netdev log helpers in igc_ethtool.c

Hi Jeff, Quoting Jeff Kirsher (2020-05-14 21:21:34) > From: Andre Guedes > > In igc_ethtool.c we print log messages using dev_* helpers, generating > inconsistent output with the rest of the driver. Since this is a network > device driver, we should preferably use netdev_* helpe

Re: [net-next v2 2/9] igc: Use netdev log helpers in igc_main.c

Hi Heiner, Quoting Heiner Kallweit (2020-05-14 15:07:42) > On 14.05.2020 23:31, Jeff Kirsher wrote: > > @@ -4877,8 +4870,7 @@ static int igc_probe(struct pci_dev *pdev, > > > > if (igc_get_flash_presence_i225(hw)) { > > if (hw->nvm.ops.validate(hw) < 0) { > > -

[PATCH net-next v2 3/5] net: sched: taprio: Remove should_restart_cycle()

t and call list_is_last() within advance_sched() instead. Signed-off-by: Andre Guedes --- net/sched/sch_taprio.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index d0aae7b5e608..77cca993710a 100644 --- a/net/sched/sch_taprio.c

[PATCH net-next v2 1/5] net: sched: taprio: Remove pointless variable assigment

This patch removes a pointless variable assigment in taprio_change(). The 'err' variable is not used from this assignment to the next one so this patch removes it. Signed-off-by: Andre Guedes --- net/sched/sch_taprio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/sched/sch_

[PATCH net-next v2 4/5] net: sched: taprio: Fix taprio_peek()

_OPEN macro instead of the magic number '-1'. Fixes: 5a781ccbd19e (“tc: Add support for configuring the taprio scheduler”) Signed-off-by: Andre Guedes --- net/sched/sch_taprio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_taprio.c b/net/sched/sch

[PATCH net-next v2 2/5] net: sched: taprio: Refactor taprio_get_start_time()

e that code to the beginning of the function. Also, if 'cycle' calculation is zero, something went really wrong with taprio and we should log that internal error properly. Signed-off-by: Andre Guedes --- net/sched/sch_taprio.c | 37 +++-- 1 file changed,

[PATCH net-next v2 0/5] Taprio qdisc fixes

de effect, that function becomes a dummy wrapper on list_is_last() so we simply remove it and call list_is_last() instead. Best regards, Andre Andre Guedes (5): net: sched: taprio: Remove pointless variable assigment net: sched: taprio: Refactor taprio_get_start_time() net: sched:

[PATCH net-next v2 5/5] net: sched: taprio: Fix taprio_dequeue()

scheduler”) Signed-off-by: Andre Guedes --- net/sched/sch_taprio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index 0df924f87f3e..df848a36b222 100644 --- a/net/sched/sch_taprio.c +++ b/net/sched/sch_taprio.c @@ -188,12

[PATCH 1/5] net: sched: taprio: Remove pointless variable assigment

This patch removes a pointless variable assigment in taprio_change(). The 'err' variable is not used from this assignment to the next one so this patch removes it. Signed-off-by: Andre Guedes --- net/sched/sch_taprio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/sched/sch_

[PATCH 4/5] net: sched: taprio: Fix taprio_peek()

_OPEN macro instead of the magic number '-1'. Fixes: 5a781ccbd19e (“tc: Add support for configuring the taprio scheduler”) Signed-off-by: Andre Guedes --- net/sched/sch_taprio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_taprio.c b/net/sched/sch

[PATCH 2/5] net: sched: taprio: Refactor taprio_get_start_time()

e that code to the beginning of the function. Also, if 'cycle' calculation is zero, something went really wrong with taprio and we should log that internal error properly. Signed-off-by: Andre Guedes --- net/sched/sch_taprio.c | 37 +++-- 1 file changed,

[PATCH 5/5] net: sched: taprio: Fix taprio_dequeue()

scheduler”) Signed-off-by: Andre Guedes --- net/sched/sch_taprio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index 110436d11f86..9f361f2b7510 100644 --- a/net/sched/sch_taprio.c +++ b/net/sched/sch_taprio.c @@ -180,12

[PATCH 0/5] Taprio qdisc fixes

Hi all, This series contains some minor improvements (patches 1 and 2) and fixes (patches 3-5) to taprio qdisc. Best regards, Andre Andre Guedes (5): net: sched: taprio: Remove pointless variable assigment net: sched: taprio: Refactor taprio_get_start_time() net: sched: taprio: Fix null

[PATCH 3/5] net: sched: taprio: Fix null pointer deref bug

If 'entry' is NULL we WARN_ON() but dereference the pointer anyway, generating a null pointer dereference bug. This patch fixes should_ restart_cycle() so we return if the pointer is NULL. Fixes: 5a781ccbd19e (“tc: Add support for configuring the taprio scheduler”) Signed-off-by: An