Hi Jeff, Quoting Jeff Kirsher (2020-05-14 21:21:34) > From: Andre Guedes <andre.gue...@intel.com> > > In igc_ethtool.c we print log messages using dev_* helpers, generating > inconsistent output with the rest of the driver. Since this is a network > device driver, we should preferably use netdev_* helpers because they > append the interface name to the message, helping making sense the of > the logs. > > This patch converts all dev_* calls to netdev_*. It also takes this > opportunity to remove the '\n' character at the end of messages since it > is automatically added by netdev_* log helpers.
It seems you missed removing the statement about '\n' from the commit message. It doesn't apply anymore, as mentioned in the cover letter. The commit message from the other patches in this series needs to be updated as well. Thank you, Andre
