>-Original Message-
>From: Jakub Kicinski
>Sent: Thursday, April 8, 2021 7:07 PM
>To: Y.b. Lu
>Cc: netdev@vger.kernel.org; David S . Miller ;
>Richard Cochran ; Claudiu Manoil
>; Vladimir Oltean ;
>Russell King
>Subject: Re: [net-next, v2, 2/2] enetc: support PTP Sync packet one-step
>ti
On Thu, Apr 08, 2021 at 07:11:48PM +, Jianmin Wang wrote:
> On Mon, Apr 05, 2021 at 16:14 UTC, Greg KH wrote:
> > On Mon, Apr 05, 2021 at 01:55:15PM +, Jianmin Wang wrote:
> > > There is same problem found in linux 4.19.y as upstream commit. The
> > > changes of crypto_user_* and cryptouse
The 04/08/2021 14:16, Jakub Kicinski wrote:
> On Thu, 8 Apr 2021 07:47:18 + Jianbo Liu wrote:
> > When device is removed, indirect block is unregisterd. As
> > bo->unlocked_driver_cb is not initialized, the following UBSAN is
> > triggered.
> >
> > UBSAN: invalid-load in net/sched/cls_api.c:14
On Fri, 9 Apr 2021 at 05:03, Jason A. Donenfeld wrote:
>
> On Fri, Apr 09, 2021 at 10:49:07AM +0800, Hangbin Liu wrote:
> > On Thu, Apr 08, 2021 at 08:44:35PM -0600, Jason A. Donenfeld wrote:
> > > Since it's just a normal module library, you can simply do this in the
> > > module_init function, r
From: Zhongjun Tan
seliunx_xfrm_policy_lookup() is hooks of security_xfrm_policy_lookup().
The dir argument is uselss in security_xfrm_policy_lookup(). So
remove the dir argument from selinux_xfrm_policy_lookup() and
security_xfrm_policy_lookup().
Signed-off-by: Zhongjun Tan
---
include/linux/
Hi Andrew,
Thank you for the feedback. You can find a (leaked) datasheet at:
https://github.com/libc0607/Realtek_switch_hacking/blob/files/RTL8231_Datasheet_1.2.pdf
On Fri, 2021-04-09 at 00:18 +0200, Andrew Lunn wrote:
> > - Providing no compatible for an MDIO child node is considered to
> > be e
在 2021/4/8 下午5:36, Yongji Xie 写道:
On Thu, Apr 8, 2021 at 2:57 PM Jason Wang wrote:
在 2021/3/31 下午4:05, Xie Yongji 写道:
This VDUSE driver enables implementing vDPA devices in userspace.
Both control path and data path of vDPA devices will be able to
be handled in userspace.
In the control pa
From: wenxu
In the nft_offload there is the mate flow_dissector with no
ingress_ifindex but with ingress_iftype that only be used
in the software. So if the mask of ingress_ifindex in meta is
0, this meta check should be bypass.
Fixes: 6d65bc64e232 ("net/mlx5e: Add mlx5e_flower_parse_meta suppor
On 25.03.21 04:13, Yunsheng Lin wrote:
Lockless qdisc has below concurrent problem:
cpu0 cpu1
. .
q->enqueue .
. .
qdisc_run_begin() .
. .
dequeue_skb() .
On Thu, Apr 8, 2021 at 5:26 PM John Fastabend wrote:
>
> Cong Wang wrote:
> > From: Cong Wang
> >
> > The last refcnt of the psock can be gone right after
> > sock_map_remove_links(), so sk_psock_stop() could trigger a UAF.
> > The reason why I placed sk_psock_stop() there is to avoid RCU read
>
> -Original Message-
> From: David Miller
> Sent: Thursday, April 8, 2021 8:41 PM
> To: Dexuan Cui
> Cc: k...@kernel.org; KY Srinivasan ; Haiyang Zhang
> ; Stephen Hemminger
> ; wei@kernel.org; Wei Liu
> ; netdev@vger.kernel.org; l...@kernel.org;
> and...@lunn.ch; be...@petrovitsch
On Fri, Apr 09, 2021 at 10:49:07AM +0800, Hangbin Liu wrote:
> On Thu, Apr 08, 2021 at 08:44:35PM -0600, Jason A. Donenfeld wrote:
> > Since it's just a normal module library, you can simply do this in the
> > module_init function, rather than deep within registration
> > abstractions.
>
> I did a
On Thu, Apr 08, 2021 at 08:44:35PM -0600, Jason A. Donenfeld wrote:
> Since it's just a normal module library, you can simply do this in the
> module_init function, rather than deep within registration
> abstractions.
I did a try but looks it's not that simple. Not sure if it's because wireguard
c
On Thu, Apr 08, 2021 at 04:30:45PM -0700, John Fastabend wrote:
> Hangbin,
>
> If possible please try to capture some of the design discussion in
> the commit message on the next rev along with the tradeoffs we are making
> so we don't lose these important details. Some of these points are fairly
Hi Hangbin,
On Thu, Apr 8, 2021 at 8:41 PM Hangbin Liu wrote:
> I agree that the best way is to disable the crypto modules in FIPS mode.
> But the code in lib/crypto looks not the same with crypto/. For modules
> in crypto, there is an alg_test() to check if the crytpo is FIPS allowed
> when do r
On Thu, Apr 08, 2021 at 03:55:59PM -0600, Jason A. Donenfeld wrote:
> On Thu, Apr 8, 2021 at 7:55 AM Simo Sorce wrote:
> > > I'm not sure this makes so much sense to do _in wireguard_. If you
> > > feel like the FIPS-allergic part is actually blake, 25519, chacha, and
> > > poly1305, then wouldn't
On Thu, Apr 08, 2021 at 08:11:34AM -0700, Eric Biggers wrote:
> On Thu, Apr 08, 2021 at 07:58:08PM +0800, Hangbin Liu wrote:
> > On Thu, Apr 08, 2021 at 09:06:52AM +0800, Hangbin Liu wrote:
> > > > Also, couldn't you just consider WireGuard to be outside your FIPS
> > > > module
> > > > boundary,
> Subject: Re: [PATCH v4 01/23] iidc: Introduce iidc.h
>
> On Wed, Apr 07, 2021 at 07:43:24PM -0300, Jason Gunthorpe wrote:
> > On Wed, Apr 07, 2021 at 08:58:49PM +, Saleem, Shiraz wrote:
> > > > Subject: Re: [PATCH v4 01/23] iidc: Introduce iidc.h
> > > >
> > > > On Tue, Apr 06, 2021 at 04:01
Hi Andrew,
On Thu, Apr 8, 2021 at 9:02 PM Andrew Lunn wrote:
>
> Adding a Suggested-by: would be good. And it might sometime help
> Johnathan Corbet extract some interesting statistics from the commit
> messages if everybody uses the same format.
Thank you for the suggestion. I'll definitely use
Hi Sven
> Many thanks to Heiner Kallweit for suggesting this solution.
Adding a Suggested-by: would be good. And it might sometime help
Johnathan Corbet extract some interesting statistics from the commit
messages if everybody uses the same format.
Andrew
Lorenzo Bianconi wrote:
> This series introduce XDP multi-buffer support. The mvneta driver is
> the first to support these new "non-linear" xdp_{buff,frame}. Reviewers
> please focus on how these new types of xdp_{buff,frame} packets
> traverse the different layers and the layout design. It is on
> From: Andrew Lunn
> Sent: Thursday, April 8, 2021 5:30 PM
> To: Stephen Hemminger
> ...
> > Linux kernel doesn't do namespaces in the code, so every new driver needs
> > to worry about global symbols clashing
>
> This driver is called mana, yet the code uses ana. It would be good to
> resolve
> From: David Miller
> Sent: Thursday, April 8, 2021 5:41 PM
> > ...
> > In the driver code, all the structs/unions marked by __packed are used to
> > talk with the hardware, so I think __packed is necessary here?
>
> It actually isan't in many cases, check with and without the __packed
> direct
From: Dexuan Cui
Date: Fri, 9 Apr 2021 00:24:51 +
>> From: David Miller
>> Sent: Thursday, April 8, 2021 4:46 PM
>> ...
>> > +struct gdma_msg_hdr {
>> > + u32 hdr_type;
>> > + u32 msg_type;
>> > + u16 msg_version;
>> > + u16 hwc_msg_id;
>> > + u32 msg_size;
>> > +} __packed;
>> > +
>> >
From: Sven Van Asbroeck
The ethernet frame length is calculated incorrectly. Depending on
the value of RX_HEAD_PADDING, this may result in ethernet frames
that are too short (cut off at the end), or too long (garbage added
to the end).
Fix by calculating the ethernet frame length correctly. For
> Linux kernel doesn't do namespaces in the code, so every new driver needs
> to worry about global symbols clashing
This driver is called mana, yet the code uses ana. It would be good to
resolve this inconsistency as well. Ideally, you want to prefix
everything with ana_ or mana_, depending on wh
Cong Wang wrote:
> From: Cong Wang
>
> The last refcnt of the psock can be gone right after
> sock_map_remove_links(), so sk_psock_stop() could trigger a UAF.
> The reason why I placed sk_psock_stop() there is to avoid RCU read
> critical section, and more importantly, some callee of
> sock_map_r
> From: David Miller
> Sent: Thursday, April 8, 2021 4:46 PM
> ...
> > +struct gdma_msg_hdr {
> > + u32 hdr_type;
> > + u32 msg_type;
> > + u16 msg_version;
> > + u16 hwc_msg_id;
> > + u32 msg_size;
> > +} __packed;
> > +
> > +struct gdma_dev_id {
> > + union {
> > + struct {
On 4/8/21 3:58 PM, Dexuan Cui wrote:
> Changes in v3:
> Changed the Kconfig file:
> Microsoft Azure Network Device ==> Microsoft Network Devices
> Drop the default m
> validated ==> supported
Hi,
I am satisfied with the Kconfig changes.
thanks.
--
~Randy
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 9 Apr 2021 03:01:29 +0500 you wrote:
> nlh is being checked for validtity two times when it is dereferenced in
> this function. Check for validity again when updating the flags through
> nlh pointer to make the dereferen
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Thu, 8 Apr 2021 20:38:26 +0200 you wrote:
> Hello,
>
> after my last patch got accepted and is now in net as commit
> 3e6fdeb28f4c33 ("net: dsa: lantiq_gswip: Let GSWIP automatically set
> the xMII clock") [0] some more pe
From: Dexuan Cui
Date: Thu, 8 Apr 2021 15:58:40 -0700
> +struct gdma_msg_hdr {
> + u32 hdr_type;
> + u32 msg_type;
> + u16 msg_version;
> + u16 hwc_msg_id;
> + u32 msg_size;
> +} __packed;
> +
> +struct gdma_dev_id {
> + union {
> + struct {
> +
On Thu, 8 Apr 2021 15:58:40 -0700
Dexuan Cui wrote:
> Add a VF driver for Microsoft Azure Network Adapter (MANA) that will be
> available in the future.
>
> Co-developed-by: Haiyang Zhang
> Signed-off-by: Haiyang Zhang
> Signed-off-by: Dexuan Cui
> ---
> MAINTAINERS
Cong Wang wrote:
> From: Cong Wang
>
> Using sk_psock() to retrieve psock pointer from sock requires
> RCU read lock, but we already get psock pointer before calling
> ->psock_update_sk_prot() in both cases, so we can just pass it
> without bothering sk_psock().
>
> Reported-and-tested-by: syzbo
Toke Høiland-Jørgensen wrote:
> John Fastabend writes:
>
> > Toke Høiland-Jørgensen wrote:
> >> John Fastabend writes:
> >>
> >> > Toke Høiland-Jørgensen wrote:
> >> >> Hangbin Liu writes:
> >> >>
> >> >> > On Mon, Apr 05, 2021 at 05:24:48PM -0700, John Fastabend wrote:
> >> >> >> Hangbin Liu
On Thu, Apr 08, 2021 at 08:38:27PM +0200, Martin Blumenstingl wrote:
> PHY auto polling on the GSWIP hardware can be used so link changes
> (speed, link up/down, etc.) can be detected automatically. Internally
> GSWIP reads the PHY's registers for this functionality. Based on this
> automatic detec
On Tue, Apr 6, 2021 at 4:36 PM Song Liu wrote:
> I am not sure whether this makes sense. I feel there is still some
> misunderstanding. It will be helpful if you can share more information
> about the overall design.
>
> BTW: this could be a good topic for the BPF office hour. See more details
> h
Hi Heiner,
On Thu, Apr 8, 2021 at 3:06 PM Heiner Kallweit wrote:
>
> A completely unrelated question:
> How about VLAN packets with a 802.1Q tag? Should VLAN_ETH_HLEN be used?
That's a good question. My use-case does not involve 802.1Q though, so
I'm unable to test.
Thank you so much for your s
Hi George,
On Thu, Apr 8, 2021 at 3:55 PM George McCollister
wrote:
>
> Works for me too.
Sounds good. I'll post a proper patch soon. Would you be able to
review+test, and perhaps offer your Reviewed-by/Tested-by tags when
everything looks ok?
> - Providing no compatible for an MDIO child node is considered to be
> equivalent
> to a c22 ethernet phy, so one must be provided. However, this node is then
> not automatically probed.
It cannot be automatically probed, since register 2 and 3 do not
contain an ID, which PHYs do. So you ne
On Thu, 2021-04-08 at 15:55 -0600, Jason A. Donenfeld wrote:
> On Thu, Apr 8, 2021 at 7:55 AM Simo Sorce wrote:
> > > I'm not sure this makes so much sense to do _in wireguard_. If you
> > > feel like the FIPS-allergic part is actually blake, 25519, chacha, and
> > > poly1305, then wouldn't it mak
> But the patch series under review adds support to generate such packets.
Willem, yes, good point. Let me add some more context.
This quote might be misleading:
>> Therefore, LINUX hosts will not send RFC 5837 ICMP extensions often
Linux _hosts_ won’t send 5837 extensions often, but Linux is
On Wed, Apr 7, 2021 at 8:36 AM Vlad Buslov wrote:
>
> This series fixes reference counting of action instances and modules in
> several parts of action init code. The first patch reverts previous fix
> that didn't properly account for rollback from a failure in the middle of
> the loop in tcf_acti
nlh is being checked for validtity two times when it is dereferenced in
this function. Check for validity again when updating the flags through
nlh pointer to make the dereferencing safe.
CC:
Addresses-Coverity: ("NULL pointer dereference")
Signed-off-by: Muhammad Usama Anjum
---
net/ipv6/route
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Thu, 8 Apr 2021 10:35:31 -0700 you wrote:
> This series contains updates to i40e and ice drivers.
>
> Grzegorz fixes the ordering of parameters to i40e_aq_get_phy_register()
> which is causing incorrect information to be r
On Thu, Apr 8, 2021 at 7:55 AM Simo Sorce wrote:
> > I'm not sure this makes so much sense to do _in wireguard_. If you
> > feel like the FIPS-allergic part is actually blake, 25519, chacha, and
> > poly1305, then wouldn't it make most sense to disable _those_ modules
> > instead? And then the var
On Thu, Apr 8, 2021 at 4:59 AM Jamal Hadi Salim wrote:
>
> On 2021-04-07 7:50 p.m., Cong Wang wrote:
> > On Wed, Apr 7, 2021 at 8:36 AM Vlad Buslov wrote:
> >>
> >> Action init code increments reference counter when it changes an action.
> >> This is the desired behavior for cls API which needs t
On Thu, Apr 8, 2021 at 12:50 AM Vlad Buslov wrote:
>
>
> On Thu 08 Apr 2021 at 02:50, Cong Wang wrote:
> > In my last comments, I actually meant whether we can avoid this
> > 'init_res[]' array. Since here you want to check whether an action
> > returned by tcf_action_init_1() is a new one or an
On 4/8/21 7:20 AM, Ciara Loftus wrote:
Wait until after the UMEM is checked for null to dereference it.
Fixes: 43f1bc1efff1 ("libbpf: Restore umem state after socket create failure")
Signed-off-by: Ciara Loftus
Applied, thanks!
Hello:
This pull request was applied to netdev/net-next.git (refs/heads/master):
On Thu, 8 Apr 2021 09:45:06 -0700 you wrote:
> The following changes since commit d310ec03a34e92a77302edb804f7d68ee4f01ba0:
>
> Merge tag 'perf-core-2021-02-17' of
> git://git.kernel.org/pub/scm/linux/kernel/git
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 8 Apr 2021 09:13:06 -0700 you wrote:
> This series contains updates to ice driver only.
>
> Chinh adds retrying of sending some AQ commands when receiving EBUSY
> error.
>
> Victor modifies how nodes are added t
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 8 Apr 2021 13:53:59 +0200 you wrote:
> From: Linus Lüssing
>
> During the inlining process of kerneldoc in commit 8b84cc4fb556
> ("batman-adv: Use inline kernel-doc for enum/struct"), some comments were
> placed
On Thu, 8 Apr 2021 10:05:07 -0400 Jamal Hadi Salim wrote:
> On 2021-04-08 9:38 a.m., Petr Machata wrote:
> > The TC action "trap" is used to instruct the HW datapath to drop the
> > matched packet and transfer it for processing in the SW pipeline. If
> > instead it is desirable to forward the packe
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 8 Apr 2021 18:14:31 +0300 you wrote:
> Reproduce:
>
> modprobe sch_teql
> tc qdisc add dev teql0 root teql0
>
> This leads to (for instance in Centos 7 VM) OOPS:
>
> [...]
Here is the summary with links:
- net
On Thu, 8 Apr 2021 07:47:18 + Jianbo Liu wrote:
> When device is removed, indirect block is unregisterd. As
> bo->unlocked_driver_cb is not initialized, the following UBSAN is
> triggered.
>
> UBSAN: invalid-load in net/sched/cls_api.c:1496:10
> load of value 6 is not a valid value for type '_
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 7 Apr 2021 08:59:12 -0700 you wrote:
> From: Stephen Hemminger
>
> Setting iftoken can fail for several different reasons but there
> and there was no report to user as to the cause. Add netlink
> extended errors to t
On Thu, Apr 08, 2021 at 02:51:01PM +0200, Lorenzo Bianconi wrote:
> From: Eelco Chaudron
>
> This patch adds support for multi-buffer for the following helpers:
> - bpf_xdp_output()
> - bpf_perf_event_output()
>
> Signed-off-by: Eelco Chaudron
> Signed-off-by: Lorenzo Bianconi
> ---
Also
Basic support for MIIM bus access. Support only includes clause-22
register access, with 5-bit addresses, and 16-bit wide registers.
Signed-off-by: Sander Vanheule
---
drivers/base/regmap/Kconfig | 6 +++-
drivers/base/regmap/Makefile | 1 +
drivers/base/regmap/regmap-miim.c | 58 ++
The RTL8231 GPIO and LED expander can be configured for use as an MIIM or I2C
bus device. To provide uniform data access between these two modes, the regmap
interface is used. Since no regmap interface exists for MIIM busses, a basic
implementation is provided.
Currently outstanding questions:
- T
The RTL8231 GPIO and LED expander chip can be controlled via a MIIM or
I2C bus. A regmap interface is used to allow for portable code.
This patch only provides GPIO support, since this is the only known use,
as found on commercial devices.
Signed-off-by: Sander Vanheule
---
drivers/gpio/Kconfig
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Wed, 7 Apr 2021 18:46:41 +0300 you wrote:
> Add two new tests for action create/change code.
>
> Vlad Buslov (2):
> tc-testing: add simple action test to verify batch add cleanup
> tc-testing: add simple action tes
On Thu, Apr 08, 2021 at 02:51:01PM +0200, Lorenzo Bianconi wrote:
> From: Eelco Chaudron
>
> This patch adds support for multi-buffer for the following helpers:
> - bpf_xdp_output()
> - bpf_perf_event_output()
>
> Signed-off-by: Eelco Chaudron
> Signed-off-by: Lorenzo Bianconi
> ---
> diff
On Thu, Apr 08, 2021 at 10:15:47PM +0300, Vladimir Oltean wrote:
> > + if (unlikely(offset > ((int)(xdp->data_end - xdp->data) +
> > + xdp_sinfo->data_length -
> > + ETH_HLEN)))
>
> Also: should we have some sort of helper
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Thu, 8 Apr 2021 15:00:41 +0800 you wrote:
> Remove including that don't need it.
>
> Signed-off-by: Tian Tao
> Signed-off-by: Zhiqi Song
> ---
> include/linux/qed/qed_ll2_if.h | 1 -
> 1 file changed, 1 deletion(-)
Joe Stringer writes:
> Hey Aaron, long time no chat :)
Same :)
> On Fri, Mar 19, 2021 at 1:43 PM Aaron Conole wrote:
>>
>> When a user instructs a flow pipeline to perform connection tracking,
>> there is an implicit L3 operation that occurs - namely the IP fragments
>> are reassembled and the
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Wed, 7 Apr 2021 16:19:53 -0700 you wrote:
> A few little changes after review comments and
> additional internal testing.
>
> Shannon Nelson (8):
> ionic: fix up a couple of code style nits
> ionic: remove unneces
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 8 Apr 2021 11:40:03 +0800 you wrote:
> This series adds support for pm_ops in the HNS3 ethernet driver.
>
> Jiaran Zhang (2):
> net: hns3: change flr_prepare/flr_done function names
> net: hns3: add suspend an
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Wed, 7 Apr 2021 22:22:38 +0200 you wrote:
> Here are some updates for marvell10g PHY driver.
>
> I am still working on some more changes for this driver, but I would
> like to have at least something reviewed / applie
Hey,
>
> * Note: Userspace tools like ModemManager are able to link control
> ports and netdev by looking at the sysfs hierarchy, it's fine for
> simple connection management, but probably not enough for 'multi PDN'
> support for which devices may have multiple netdev and ports
> targetting differ
On Thu, Apr 8, 2021 at 1:35 PM Sven Van Asbroeck wrote:
>
> Hi George,
>
> On Thu, Apr 8, 2021 at 2:26 PM Sven Van Asbroeck wrote:
> >
> > George, I will send a patch for you to try shortly. Except if you're
> > already ahead :)
>
> Would this work for you? It does for me.
Works for me too.
>
>
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Colin King
> Sent: Wednesday, March 31, 2021 7:46 AM
> To: Brandeburg, Jesse ; Nguyen, Anthony L
> ; David S . Miller ;
> Jakub Kicinski ; Cao, Chinh T ;
> intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org
> Cc: kernel-jani
> From: Stephen Hemminger
> Sent: Thursday, April 8, 2021 9:52 AM
Thanks all for your input! We'll make the below changes as suggested:
Microsoft Azure Network Device ==> Microsoft Network Devices
Drop the default m
validated ==> supported
We'll also fix some warnings reported by "kernel test r
On Thu, Apr 08, 2021 at 02:51:00PM +0200, Lorenzo Bianconi wrote:
> From: Eelco Chaudron
>
> This change adds support for tail growing and shrinking for XDP multi-buff.
>
> Signed-off-by: Eelco Chaudron
> Signed-off-by: Lorenzo Bianconi
> ---
> include/net/xdp.h | 5
> net/core/filter.c
On Mon, Apr 05, 2021 at 16:14 UTC, Greg KH wrote:
> On Mon, Apr 05, 2021 at 01:55:15PM +, Jianmin Wang wrote:
> > There is same problem found in linux 4.19.y as upstream commit. The
> > changes of crypto_user_* and cryptouser.h files from upstream patch are
> > merged into
> > crypto/crypto_
On 08.04.2021 20:35, Sven Van Asbroeck wrote:
> Hi George,
>
> On Thu, Apr 8, 2021 at 2:26 PM Sven Van Asbroeck wrote:
>>
>> George, I will send a patch for you to try shortly. Except if you're
>> already ahead :)
>
> Would this work for you? It does for me.
>
> diff --git a/drivers/net/etherne
On 08.04.2021 06:42, Pkshih wrote:
-Original Message-
From: Maciej S. Szmigiero [mailto:m...@maciej.szmigiero.name]
Sent: Thursday, April 08, 2021 4:53 AM
To: Larry Finger; Pkshih
Cc: linux-wirel...@vger.kernel.org; netdev@vger.kernel.org;
linux-ker...@vger.kernel.org;
johan...@sipsoluti
When using a Python script to send max sized vlan packets
on a BCM4401 nic (driver: b44), the Intel I217-V nic (driver: e1000e) only
receives packets with a maximum size of 1514 bytes and reports a
length error for the 1518 bytes sized packet.
When sending the packet from the I217-V and receiving
On Wed, Apr 07, 2021 at 04:35:34PM -0700, Andrii Nakryiko wrote:
> On Wed, Apr 7, 2021 at 4:24 PM Rustam Kovhaev wrote:
> >
> > On Mon, Mar 01, 2021 at 09:43:00PM +0100, Dmitry Vyukov wrote:
> > > On Mon, Mar 1, 2021 at 9:39 PM Rustam Kovhaev wrote:
> > > >
> > > > On Mon, Mar 01, 2021 at 08:05:4
Hi Mel Gorman,
I may have found a problem in pfmemalloc skb handling in
net/core/dev.c. I see there are "if" conditions checking for
"sk_memalloc_socks() && skb_pfmemalloc(skb)", and when the condition
is true, the skb is handled specially as a pfmemalloc skb, otherwise
it is handled as a normal s
On 4/7/21 11:18 AM, Nitesh Narayan Lal wrote:
> On 4/6/21 1:22 PM, Jesse Brandeburg wrote:
>> Continuing a thread from a bit ago...
>>
>> Nitesh Narayan Lal wrote:
>>
After a little more digging, I found out why cpumask_local_spread change
affects the general/initial smp_affinity for ce
On 4/8/2021 11:38 AM, Martin Blumenstingl wrote:
> There are a few more bits in the GSWIP_MII_CFG register for which we
> did rely on the boot-loader (or the hardware defaults) to set them up
> properly.
>
> For some external RMII PHYs we need to select the GSWIP_MII_CFG_RMII_CLK
> bit and also
On 4/8/2021 11:38 AM, Martin Blumenstingl wrote:
> PHY auto polling on the GSWIP hardware can be used so link changes
> (speed, link up/down, etc.) can be detected automatically. Internally
> GSWIP reads the PHY's registers for this functionality. Based on this
> automatic detection GSWIP can al
On Thu, Apr 08, 2021 at 02:50:57PM +0200, Lorenzo Bianconi wrote:
> Introduce the capability to map non-linear xdp buffer running
> mvneta_xdp_submit_frame() for XDP_TX and XDP_REDIRECT
>
> Signed-off-by: Lorenzo Bianconi
> ---
> drivers/net/ethernet/marvell/mvneta.c | 94 +--
There are a few more bits in the GSWIP_MII_CFG register for which we
did rely on the boot-loader (or the hardware defaults) to set them up
properly.
For some external RMII PHYs we need to select the GSWIP_MII_CFG_RMII_CLK
bit and also we should un-set it for non-RMII PHYs. The
GSWIP_MII_CFG_RMII_C
PHY auto polling on the GSWIP hardware can be used so link changes
(speed, link up/down, etc.) can be detected automatically. Internally
GSWIP reads the PHY's registers for this functionality. Based on this
automatic detection GSWIP can also automatically re-configure it's port
settings. Unfortunat
Hello,
after my last patch got accepted and is now in net as commit
3e6fdeb28f4c33 ("net: dsa: lantiq_gswip: Let GSWIP automatically set
the xMII clock") [0] some more people from the OpenWrt community
(many thanks to everyone involved) helped test the GSWIP driver: [1]
It turns out that the prev
Hi George,
On Thu, Apr 8, 2021 at 2:26 PM Sven Van Asbroeck wrote:
>
> George, I will send a patch for you to try shortly. Except if you're
> already ahead :)
Would this work for you? It does for me.
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c
b/drivers/net/ethernet/microchip/lan
On Thu, Apr 08, 2021 at 02:50:56PM +0200, Lorenzo Bianconi wrote:
> Take into account if the received xdp_buff/xdp_frame is non-linear
> recycling/returning the frame memory to the allocator or into
> xdp_frame_bulk.
> Introduce xdp_return_num_frags_from_buff to return a given number of
> fragments
Hi Heiner,
On Thu, Apr 8, 2021 at 2:22 PM Heiner Kallweit wrote:
>
> Just an idea:
> RX_HEAD_PADDING is an alias for NET_IP_ALIGN that can have two values:
> 0 and 2
> The two systems you use may have different NET_IP_ALIGN values.
> This could explain the behavior. Then what I proposed should wo
On 08.04.2021 20:00, George McCollister wrote:
> On Thu, Apr 8, 2021 at 12:46 PM Sven Van Asbroeck wrote:
>>
>> Hi George,
>>
>> On Thu, Apr 8, 2021 at 1:36 PM George McCollister
>> wrote:
>>>
>>> Can you explain the difference in behavior with what I was observing
>>> on the LAN7431?
>>
>> I'm n
On Thu, 8 Apr 2021 12:10:19 +0200
Lorenzo Bianconi wrote:
> > On Thu, Apr 1, 2021 at 9:49 AM Lorenzo Bianconi wrote:
> >
> > >
> > > > On Thu, Apr 1, 2021 at 1:57 AM Lorenzo Bianconi
> > > > wrote:
> > > > >
> > >
> > > [...]
> > >
> > > > > - /* Inject into ne
On Thu, Apr 08, 2021 at 02:50:55PM +0200, Lorenzo Bianconi wrote:
> Update multi-buffer bit (mb) in xdp_buff to notify XDP/eBPF layer and
> XDP remote drivers if this is a "non-linear" XDP buffer. Access
> xdp_shared_info only if xdp_buff mb is set.
>
> Signed-off-by: Lorenzo Bianconi
> ---
> dr
On Thu, Apr 08, 2021 at 02:50:53PM +0200, Lorenzo Bianconi wrote:
> Introduce multi-buffer bit (mb) in xdp_frame/xdp_buffer data structure
> in order to specify if this is a linear buffer (mb = 0) or a multi-buffer
> frame (mb = 1). In the latter case the shared_info area at the end of the
> first
Hi Lorenzo,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/Lorenzo-Bianconi/mvneta-introduce-XDP-multi-buffer-support/20210408-205429
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf
On Thu, Apr 8, 2021 at 12:46 PM Sven Van Asbroeck wrote:
>
> Hi George,
>
> On Thu, Apr 8, 2021 at 1:36 PM George McCollister
> wrote:
> >
> > Can you explain the difference in behavior with what I was observing
> > on the LAN7431?
>
> I'm not using DSA in my application, so I cannot test or repl
Hi Heiner,
On Thu, Apr 8, 2021 at 1:49 PM Heiner Kallweit wrote:
>
> Can't we use frame_length - ETH_FCS_LEN direcctly here?
If the hard-coded "4" refers to ETH_FCS_LEN, then yes, good point. I'd
love to find out first why George and I need different patches to make
the driver work in our use ca
On 08.04.2021 19:23, Sven Van Asbroeck wrote:
> From: Sven Van Asbroeck
>
> This reverts commit 3e21a10fdea3c2e4e4d1b72cb9d720256461af40.
>
> The reverted patch completely breaks all network connectivity on the
> lan7430. tcpdump indicates missing bytes when receiving ping
> packets from an exte
Hi George,
On Thu, Apr 8, 2021 at 1:36 PM George McCollister
wrote:
>
> Can you explain the difference in behavior with what I was observing
> on the LAN7431?
I'm not using DSA in my application, so I cannot test or replicate
what you were observing. It would be great if we could work together
a
DCCP is virtually never used, so no need to use space in struct net for it.
Put the pernet ipv4/v6 socket in the dccp ipv4/ipv6 modules instead.
Signed-off-by: Florian Westphal
---
include/net/net_namespace.h | 4
include/net/netns/dccp.h| 12
net/dccp/ipv4.c
1 - 100 of 245 matches
Mail list logo
