> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of
> Colin King
> Sent: Wednesday, March 31, 2021 7:46 AM
> To: Brandeburg, Jesse <jesse.brandeb...@intel.com>; Nguyen, Anthony L
> <anthony.l.ngu...@intel.com>; David S . Miller <da...@davemloft.net>;
> Jakub Kicinski <k...@kernel.org>; Cao, Chinh T <chinh.t....@intel.com>;
> intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org
> Cc: kernel-janit...@vger.kernel.org; linux-ker...@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH][next] ice: Fix potential infinite loop when
> using u8 loop counter
>
> From: Colin Ian King <colin.k...@canonical.com>
>
> A for-loop is using a u8 loop counter that is being compared to a u32
> cmp_dcbcfg->numapp to check for the end of the loop. If cmp_dcbcfg-
> >numapp is larger than 255 then the counter j will wrap around to zero and
> hence an infinite loop occurs. Fix this by making counter j the same type as
> cmp_dcbcfg->numapp.
>
> Addresses-Coverity: ("Infinite loop")
> Fixes: aeac8ce864d9 ("ice: Recognize 860 as iSCSI port in CEE mode")
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
> ---
> drivers/net/ethernet/intel/ice/ice_dcb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Tested-by: Tony Brelinski <tonyx.brelin...@intel.com> A Contingent Worker at
Intel
