Re: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

2020-11-26 Thread Lee Jones
On Fri, 27 Nov 2020, Pkshih wrote: > > The subject prefix doesn't need 'realtek:'; use 'rtw88:'. > > On Thu, 2020-11-26 at 13:31 +, Lee Jones wrote: > > Also strip out other duplicates from driver specific headers. > > > > Ensure 'main.h' is explicitly included in 'pci.h' since the latter >

Re: [PATCH v4 bpf-next 2/2] samples/bpf: sample application for eBPF load and socket creation split

2020-11-26 Thread Magnus Karlsson
On Thu, Nov 26, 2020 at 12:10 PM wrote: > > From: Mariusz Dudek > > Introduce a sample program to demonstrate the control and data > plane split. For the control plane part a new program called > xdpsock_ctrl_proc is introduced. For the data plane part, some code > was added to xdpsock_user.c to

Re: [PATCH] can: remove WARN() statement from list operation sanity check

2020-11-26 Thread Marc Kleine-Budde
On 11/26/20 8:21 PM, Oliver Hartkopp wrote: > To detect potential bugs in CAN protocol implementations (double removal > of receiver entries) a WARN() statement has been used if no matching list > item was found for removal. > > The fault injection issued by syzkaller was able to create a situatio

[PATCH] bpf, x64: add extra passes without size optimizations

2020-11-26 Thread Gary Lin
The x64 bpf jit expects bpf images converge within the given passes, but it could fail to do so with some corner cases. For example: l0: ldh [4] l1: jeq #0x537d, l2, l40 l2: ld [0] l3: jeq #0xfa163e0d, l4, l40 l4: ldh [12] l5: ldx #0xe

Re: [PATCH v5 1/1] xdp: remove the functions xsk_map_inc and xsk_map_put

2020-11-26 Thread Magnus Karlsson
On Thu, Nov 26, 2020 at 4:05 PM Zhu Yanjun wrote: > > From: Zhu Yanjun > > The functions xsk_map_put and xsk_map_inc are simple wrappers. > As such, replacing these functions with the functions bpf_map_inc > and bpf_map_put and removing some test codes. > > Fixes: d20a1676df7e ("xsk: Move xskmap.

Re: [PATCH bpf-next v3 6/6] bpf: Test bpf_sk_storage_get in tcp iterators

2020-11-26 Thread Yonghong Song
On 11/26/20 8:44 AM, Florent Revest wrote: This extends the existing bpf_sk_storage_get test where a socket is created and tagged with its creator's pid by a task_file iterator. A TCP iterator is now also used at the end of the test to negate the values already stored in the local storage. Th

Re: [PATCH bpf-next v3 5/6] bpf: Add an iterator selftest for bpf_sk_storage_get

2020-11-26 Thread Yonghong Song
On 11/26/20 8:44 AM, Florent Revest wrote: The eBPF program iterates over all files and tasks. For all socket files, it stores the tgid of the last task it encountered with a handle to that socket. This is a heuristic for finding the "owner" of a socket similar to what's done by lsof, ss, nets

Re: [PATCHv2 bpf-next] samples/bpf: add xdp program on egress for xdp_redirect_map

2020-11-26 Thread Yonghong Song
On 11/26/20 12:43 AM, Hangbin Liu wrote: Current sample test xdp_redirect_map only count pkts on ingress. But we can't know whether the pkts are redirected or dropped. So add a counter on egress interface so we could know how many pkts are redirect in fact. sample result: $ ./xdp_redirect_ma

RE: [PATCH] can: m_can: add support for bosch mcan version 3.3.0

2020-11-26 Thread pankj.sharma
> From: Oliver Hartkopp > Subject: Re: [PATCH] can: m_can: add support for bosch mcan version 3.3.0 > > > > On 26.11.20 11:48, Marc Kleine-Budde wrote: > > On 11/26/20 5:51 AM, Pankaj Sharma wrote: > >> Add support for mcan bit timing and control mode according to bosch > >> mcan IP version 3

Re: [PATCH net-next 1/3] nfc: s3fwrn5: use signed integer for parsing GPIO numbers

2020-11-26 Thread Bongsu Jeon
On 11/27/20, Bongsu Jeon wrote: > On Fri, Nov 27, 2020 at 2:06 AM Krzysztof Kozlowski > wrote: >> >> On Fri, Nov 27, 2020 at 12:33:37AM +0900, bongsu.je...@gmail.com wrote: >> > From: Krzysztof Kozlowski >> > >> > GPIOs - as returned by of_get_named_gpio() and used by the gpiolib - >> > are >> >

Re: [RFC][PATCH 00/18] crypto: Add generic Kerberos library

2020-11-26 Thread Herbert Xu
On Thu, Nov 26, 2020 at 08:19:41AM +, David Howells wrote: > > I haven't done that yet. Sorry, I should've been more explicit with what I > was after. I was wanting to find out if the nfs/nfsd people are okay with > this (and if there are any gotchas I should know about - it turns out, if I >

Re: [PATCH bpf-next v3 2/5] selftests/bpf: xsk selftests - SKB POLL, NOPOLL

2020-11-26 Thread Yonghong Song
On 11/25/20 10:37 AM, Weqaar Janjua wrote: Adds following tests: 1. AF_XDP SKB mode Generic mode XDP is driver independent, used when the driver does not have support for XDP. Works on any netdevice using sockets and generic XDP path. XDP hook from netif_receive_skb(). a. nopo

Re: [PATCH 0/7] Introduce vdpa management tool

2020-11-26 Thread Jason Wang
On 2020/11/12 下午2:39, Parav Pandit wrote: This patchset covers user requirements for managing existing vdpa devices, using a tool and its internal design notes for kernel drivers. Background and user requirements: -- (1) Currently VDPA device is created by drive

Re: [PATCH bpf-next v3 1/7] samples: bpf: refactor hbm program with libbpf

2020-11-26 Thread Andrii Nakryiko
On Tue, Nov 24, 2020 at 1:03 AM Daniel T. Lee wrote: > > This commit refactors the existing cgroup programs with libbpf > bpf loader. Since bpf_program__attach doesn't support cgroup program > attachment, this explicitly attaches cgroup bpf program with > bpf_program__attach_cgroup(bpf_prog, cg1).

Re: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

2020-11-26 Thread Pkshih
The subject prefix doesn't need 'realtek:'; use 'rtw88:'. On Thu, 2020-11-26 at 13:31 +, Lee Jones wrote: > Also strip out other duplicates from driver specific headers. > > Ensure 'main.h' is explicitly included in 'pci.h' since the latter > uses some defines from the former.  It avoids iss

Re: [RFC PATCH] bpf, x64: add extra passes and relax size convergence check

2020-11-26 Thread Gary Lin
On Thu, Nov 26, 2020 at 04:01:30PM +0800, Gary Lin wrote: > The x64 bpf jit expects bpf images converge within the given passes, but > it could fail to do so with some corner cases. For example: > > l0: ldh [4] > l1: jeq #0x537d, l2, l40 > l2: ld [0] > l3: j

Re: [PATCH net-next] net/sched: act_ct: enable stats for HW offloaded entries

2020-11-26 Thread wenxu
On 11/27/2020 2:40 AM, Marcelo Ricardo Leitner wrote: > By setting NF_FLOWTABLE_COUNTER. Otherwise, the updates added by > commit ef803b3cf96a ("netfilter: flowtable: add counter support in HW > offload") are not effective when using act_ct. > > While at it, now that we have the flag set, protect

Re: [PATCH v7] lib: optimize cpumask_local_spread()

2020-11-26 Thread Shaokun Zhang
Hi Dave, Apologies for later reply. 在 2020/11/21 1:48, Dave Hansen 写道: > On 11/17/20 6:54 PM, Shaokun Zhang wrote: >> From: Yuqi Jin >> >> In multi-processor and NUMA system, I/O driver will find cpu cores that >> which shall be bound IRQ. When cpu cores in the local numa have been >> used up, i

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-26 Thread Andrew Lunn
> > I would push back and say that the switch offers bridge acceleration > > for the FEC. > > Am I correct, that the "bridge acceleration" means in-hardware support > for L2 packet bridging? You should think of the hardware as an accelerator, not a switch. The hardware is there to accelerate wh

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-26 Thread Andrew Lunn
> (A side question - DSA uses switchdev, so when one shall use switchdev > standalone?) DSA gives you a framework for an Ethernet switch connected to a host via Ethernet for the data plane. Generally, that Ethernet link to the switch is a MAC to MAC connection. It can be PHY to PHY. But those are

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-26 Thread Lukasz Majewski
Hi Andrew, > > > What is not yet clear to me is how you direct frames out specific > > > interfaces. This is where i think we hit problems. I don't see a > > > generic mechanism, which is probably why Lukasz put tagger as > > > None. > > > > I've put the "None" tag just to share the "testable"

Re: [PATCH net 1/2] ibmvnic: Ensure that SCRQ entry reads are correctly ordered

2020-11-26 Thread Michael Ellerman
Thomas Falcon writes: > On 11/24/20 11:43 PM, Michael Ellerman wrote: >> Thomas Falcon writes: >>> Ensure that received Subordinate Command-Response Queue (SCRQ) >>> entries are properly read in order by the driver. These queues >>> are used in the ibmvnic device to process RX buffer and TX compl

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-26 Thread Lukasz Majewski
Hi Vladimir, > Hi Lukasz, > > On Thu, Nov 26, 2020 at 12:24:55AM +0100, Lukasz Majewski wrote: > > This is the first attempt to add support for L2 switch available on > > some NXP devices - i.e. iMX287 or VF610. This patch set uses common > > FEC and DSA code. > > > > This code provides _very_ ba

Re: [PATCH net-next 3/3] nfc: s3fwrn5: extract the common phy blocks

2020-11-26 Thread Bongsu Jeon
On Fri, Nov 27, 2020 at 2:13 AM Krzysztof Kozlowski wrote: > > On Fri, Nov 27, 2020 at 12:33:39AM +0900, bongsu.je...@gmail.com wrote: > > From: Bongsu Jeon > > > > Extract the common phy blocks to reuse it. > > The UART module will use the common blocks. > > > Hi, > > Thanks for the patch. Few c

Re: [PATCH bpf-next v3 3/6] bpf: Expose bpf_sk_storage_* to iterator programs

2020-11-26 Thread KP Singh
On Thu, Nov 26, 2020 at 5:45 PM Florent Revest wrote: > > Iterators are currently used to expose kernel information to userspace > over fast procfs-like files but iterators could also be used to > manipulate local storage. For example, the task_file iterator could be > used to initialize a socket

Re: [PATCH bpf-next v3 1/6] net: Remove the err argument from sock_from_file

2020-11-26 Thread KP Singh
On Thu, Nov 26, 2020 at 5:45 PM Florent Revest wrote: > > Currently, the sock_from_file prototype takes an "err" pointer that is > either not set or set to -ENOTSOCK IFF the returned socket is NULL. This > makes the error redundant and it is ignored by a few callers. > > This patch simplifies the

Re: [PATCH net-next 2/4] net: dsa: Link aggregation support

2020-11-26 Thread Andrew Lunn
> If you go with the static array, you theoretically can not get the > equivalent of an ENOMEM. Practically though you have to iterate through > the array and look for a free entry, but you still have to put a return > statement at the bottom of that function, right? Or panic I suppose. My > guess

Re: [PATCH net-next 1/3] nfc: s3fwrn5: use signed integer for parsing GPIO numbers

2020-11-26 Thread Bongsu Jeon
On Fri, Nov 27, 2020 at 2:06 AM Krzysztof Kozlowski wrote: > > On Fri, Nov 27, 2020 at 12:33:37AM +0900, bongsu.je...@gmail.com wrote: > > From: Krzysztof Kozlowski > > > > GPIOs - as returned by of_get_named_gpio() and used by the gpiolib - are > > signed integers, where negative number indicate

Re: [PATCH net-next 2/4] net: dsa: Link aggregation support

2020-11-26 Thread Tobias Waldekranz
On Fri, Nov 20, 2020 at 14:30, Andrew Lunn wrote: > On Thu, Nov 19, 2020 at 06:43:38PM -0800, Florian Fainelli wrote: >> > >> > Hi Tobias >> > >> > My comment last time was to statically allocated them at probe >> > time. Worse case scenario is each port is alone in a LAG. Pointless, >> > but so

Re: dsa/mv88e6xxx: leaking packets on MV88E6341 switch

2020-11-26 Thread Andrew Lunn
> > I tested setting .tag_protocol=DSA_TAG_PROTO_DSA for the 6341 switch > > instead, resulting in a register setting of 04 Port control for port 5 > > = 0x053f (i.e. EgressMode=Unmodified mode, frames are transmitted > > unmodified), which looks correct to me. It does not fix the above > > problem

Re: [PATCH net-next v2 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-11-26 Thread Vladimir Oltean
On Thu, Nov 26, 2020 at 01:07:12PM -0600, George McCollister wrote: > On Thu, Nov 26, 2020 at 11:56 AM Vladimir Oltean wrote: > > > > On Thu, Nov 26, 2020 at 03:24:18PM +0200, Vladimir Oltean wrote: > > > On Wed, Nov 25, 2020 at 08:25:11PM -0600, George McCollister wrote: > > > > > > + {XRS_RX

Re: dsa/mv88e6xxx: leaking packets on MV88E6341 switch

2020-11-26 Thread Tobias Waldekranz
On Wed, Nov 25, 2020 at 15:09, Peter Vollmer wrote: > Hi, > I am still investigating the leaking packets problem we are having > with a setup of an armada-3720 SOC and a 88E6341 switch ( connected > via cpu port 5 , SGMII ,C_MODE=0xB, 2500 BASE-x). I now jumped to the > net-next kernel (5.10.0-rc4

[RFC PATCH V2 net-next 4/9] net: ena: fix coding style nits

2020-11-26 Thread akiyano
From: Arthur Kiyanovski This commit fixes two nits, but it does not generate any change to binary because of the optimization of gcc. - use `count` instead of `channels->combined_count` - change return type from `int` to `bool` Also add spaces and change macro order in OR assignment to make

Re: [PATCH bpf-next v3 1/5] selftests/bpf: xsk selftests framework

2020-11-26 Thread Weqaar Janjua
On Thu, 26 Nov 2020 at 09:01, Björn Töpel wrote: > > On 2020-11-26 07:44, Yonghong Song wrote: > > > [...] > > > > What other configures I am missing? > > > > BTW, I cherry-picked the following pick from bpf tree in this experiment. > >commit e7f4a5919bf66e530e08ff352d9b78ed89574e6b (HEAD -> x

[RFC PATCH V2 net-next 9/9] net: ena: introduce ndo_xdp_xmit() function for XDP_REDIRECT

2020-11-26 Thread akiyano
From: Arthur Kiyanovski This patch implements the ndo_xdp_xmit() net_device function which is called when a packet is redirected to this driver using an XDP_REDIRECT directive. The function receives an array of xdp frames that it needs to xmit. The TX queues that are used to xmit these frames ar

[RFC PATCH V2 net-next 7/9] net: ena: introduce XDP redirect implementation

2020-11-26 Thread akiyano
From: Arthur Kiyanovski This patch adds a partial support for the XDP_REDIRECT directive which instructs the driver to pass the packet to an interface specified by the program. The directive is passed to the driver by calling bpf_redirect() or bpf_redirect_map() functions from the eBPF program.

[RFC PATCH V2 net-next 6/9] net: ena: use xdp_frame in XDP TX flow

2020-11-26 Thread akiyano
From: Arthur Kiyanovski Rename the ena_xdp_xmit_buff() function to ena_xdp_xmit_frame() and pass it an xdp_frame struct instead of xdp_buff. This change lays the ground for XDP redirect implementation which uses xdp_frames when 'xmit'ing packets. Signed-off-by: Shay Agroskin Signed-off-by: Arth

[RFC PATCH V2 net-next 5/9] net: ena: aggregate stats increase into a function

2020-11-26 Thread akiyano
From: Arthur Kiyanovski Introduce ena_increase_stat() function to increase statistics by a certain number. The function includes the - lock aquire (on 32bit machines) - stat increase - lock release (on 32bit machines) line sequence that is ubiquitous across the driver. The function

[RFC PATCH V2 net-next 8/9] net: ena: use xdp_return_frame() to free xdp frames

2020-11-26 Thread akiyano
From: Arthur Kiyanovski XDP subsystem has a function to free XDP frames and their associated pages. Using this function would help the driver's XDP implementation to adjust to new changes in the XDP subsystem in the kernel (e.g. introduction of XDP MB). Also, remove 'xdp_rx_page' field from ena_

[RFC PATCH V2 net-next 3/9] net: ena: add explicit casting to variables

2020-11-26 Thread akiyano
From: Arthur Kiyanovski This patch adds explicit casting to some implicit conversions in the ena driver. The implicit conversions fail some of our static checkers that search for accidental conversions in our driver. Adding this cast won't affect the end results, and would sooth the checkers. Si

[RFC PATCH V2 net-next 2/9] net: ena: add device distinct log prefix to files

2020-11-26 Thread akiyano
From: Arthur Kiyanovski ENA logs are adjusted to display the full ENA representation to distinct each ENA device in case of multiple interfaces. Using netdev_err/warn and dev_info functions for logging provides uniform printing with clear distinction of the device and interface. This patch chang

[RFC PATCH V2 net-next 1/9] net: ena: use constant value for net_device allocation

2020-11-26 Thread akiyano
From: Arthur Kiyanovski The patch changes the maximum number of RX/TX queues it advertises to the kernel (via alloc_etherdev_mq()) from a value received from the device to a constant value which is the minimum between 128 and the number of CPUs in the system. By allocating the net_device struct

[RFC PATCH V2 net-next 0/9] XDP Redirect implementation for ENA driver

2020-11-26 Thread akiyano
From: Arthur Kiyanovski V2 Changes: --- 1. Changed this to RFC, since we are waiting for the recently merged net patches to be merged so there will be no merge conflicts. But still would like to get review comments beforehand. 2. Removed the word "atomic" from the name of ena_increas

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-11-26 Thread Michal Kubecek
On Wed, Nov 25, 2020 at 10:35:35AM +, Danielle Ratson wrote: > > > What do you think of passing the link modes you have suggested as a > > > bitmask, similar to "supported", that contains only one positive bit? > > > Something like that: > > Hi Michal, > > Thanks for your response. > > Actua

[PATCH net-next v6 07/14] net/smc: Refactor smc ism v2 capability handling

2020-11-26 Thread Karsten Graul
From: Guvenc Gulce Encapsulate the smc ism v2 capability boolean value in a function for better information hiding. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- net/smc/af_smc.c | 12 ++-- net/smc/smc_ism.c | 8 +++- net/smc/smc_ism.h | 5 ++--- 3 files changed,

[PATCH net-next v6 04/14] net/smc: Add link counters for IB device ports

2020-11-26 Thread Karsten Graul
From: Guvenc Gulce Add link counters to the structure of the smc ib device, one counter per ib port. Increase/decrease the counters as needed in the corresponding routines. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- net/smc/smc_core.c | 13 + net/smc/smc_ib.h |

[PATCH net-next v6 02/14] net/smc: Use active link of the connection

2020-11-26 Thread Karsten Graul
From: Guvenc Gulce Use active link of the connection directly and not via linkgroup array structure when obtaining link data of the connection. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- net/smc/smc_diag.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) dif

[PATCH net-next v6 14/14] net/smc: Add support for obtaining SMCR device list

2020-11-26 Thread Karsten Graul
From: Guvenc Gulce Deliver SMCR device information via netlink based diagnostic interface. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- include/uapi/linux/smc.h | 13 +++- net/smc/smc_core.c | 2 +- net/smc/smc_ib.c | 156 ++

[PATCH net-next v6 13/14] net/smc: Add support for obtaining SMCD device list

2020-11-26 Thread Karsten Graul
From: Guvenc Gulce Deliver SMCD device information via netlink based diagnostic interface. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- include/uapi/linux/smc.h | 28 + net/smc/smc_core.h | 28 + net/smc/smc_ism.c| 91 +

[PATCH net-next v6 12/14] net/smc: Add SMC-D Linkgroup diagnostic support

2020-11-26 Thread Karsten Graul
From: Guvenc Gulce Deliver SMCD Linkgroup information via netlink based diagnostic interface. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- include/uapi/linux/smc.h | 27 net/smc/smc_core.c | 130 +++ net/smc/smc_core.h

[PATCH net-next v6 08/14] net/smc: Introduce generic netlink interface for diagnostic purposes

2020-11-26 Thread Karsten Graul
From: Guvenc Gulce Introduce generic netlink interface infrastructure to expose the diagnostic information regarding smc linkgroups, links and devices. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- include/uapi/linux/smc.h | 11 ++ net/smc/Makefile | 2 +- net/

[PATCH net-next v6 05/14] net/smc: Add diagnostic information to smc ib-device

2020-11-26 Thread Karsten Graul
From: Guvenc Gulce During smc ib-device creation, add network device ifindex to smc ib-device structure. Register for netdevice changes and update ib-device accordingly. This is needed for diagnostic purposes. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- net/smc/smc_ib.c | 4

[PATCH net-next v6 03/14] net/smc: Add connection counters for links

2020-11-26 Thread Karsten Graul
From: Guvenc Gulce Add connection counters to the structure of the link. Increase/decrease the counters as needed in the corresponding routines. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- net/smc/smc_core.c | 16 ++-- net/smc/smc_core.h | 1 + 2 files changed, 1

[PATCH net-next v6 11/14] net/smc: Introduce SMCR get link command

2020-11-26 Thread Karsten Graul
From: Guvenc Gulce Introduce get link command which loops through all available links of all available link groups. It uses the SMC-R linkgroup list as entry point, not the socket list, which makes linkgroup diagnosis possible, in case linkgroup does not contain active connections anymore. Signe

[PATCH net-next v6 10/14] net/smc: Introduce SMCR get linkgroup command

2020-11-26 Thread Karsten Graul
From: Guvenc Gulce Introduce get linkgroup command which loops through all available SMCR linkgroups. It uses the SMC-R linkgroup list as entry point, not the socket list, which makes linkgroup diagnosis possible, in case linkgroup does not contain active connections anymore. Signed-off-by: Guve

[PATCH net-next v6 06/14] net/smc: Add diagnostic information to link structure

2020-11-26 Thread Karsten Graul
From: Guvenc Gulce During link creation add net-device ifindex and ib-device name to link structure. This is needed for diagnostic purposes. When diagnostic information is gathered, we need to traverse device, linkgroup and link structures, to be able to do that we need to hold a spinlock for th

[PATCH net-next v6 09/14] net/smc: Add support for obtaining system information

2020-11-26 Thread Karsten Graul
From: Guvenc Gulce Add new netlink command to obtain system information of the smc module. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- include/uapi/linux/smc.h | 18 net/smc/smc_clc.c| 5 net/smc/smc_clc.h| 1 + net/smc/smc_core.c | 6

[PATCH net-next v6 01/14] net/smc: use helper smc_conn_abort() in listen processing

2020-11-26 Thread Karsten Graul
The helper smc_connect_abort() can be used by the listen processing functions, too. And rename this helper to smc_conn_abort() to make the purpose clearer. No functional change. Signed-off-by: Karsten Graul --- net/smc/af_smc.c | 17 + 1 file changed, 5 insertions(+), 12 deletion

[PATCH net-next v6 00/14] net/smc: Add support for generic netlink API

2020-11-26 Thread Karsten Graul
Please apply the following patch series for smc to netdev's net-next tree. Up to version 4 this patch series was using the sock_diag netlink infrastructure. This version is using the generic netlink API. Generic netlink API offers a better type safety between kernel and userspace communication. Us

Re: Hardcoded multicast queue length in macvlan.c driver causes poor multicast receive performance

2020-11-26 Thread Thomas Karlsson
On 2020-11-26 00:01, Jakub Kicinski wrote: > On Wed, 25 Nov 2020 23:15:39 +0100 Thomas Karlsson wrote: This is my first time ever attemting a contribution to the kernel so I'm quite happy to keep it simple like that too :) >>> >>> Module params are highly inflexible, we have a general p

Re: [PATCH 1/3] mwifiex: disable ps_mode explicitly by default instead

2020-11-26 Thread Tsuchiya Yuto
On Fri, 2020-11-20 at 13:04 -0800, Brian Norris wrote: > On Fri, Oct 30, 2020 at 1:04 AM Tsuchiya Yuto wrote: > > On Thu, 2020-10-29 at 11:25 -0700, Brian Norris wrote: > > > For the record, Chrome OS supports plenty of mwifiex systems with 8897 > > > (SDIO only) and 8997 (PCIe), with PS enabled,

[PATCH] can: remove WARN() statement from list operation sanity check

2020-11-26 Thread Oliver Hartkopp
To detect potential bugs in CAN protocol implementations (double removal of receiver entries) a WARN() statement has been used if no matching list item was found for removal. The fault injection issued by syzkaller was able to create a situation where the closing of a socket runs simultaneously to

Re: [PATCH net-next v2 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-11-26 Thread George McCollister
notice anything. If you haven't already you might do a quick grep and see if anything pops out to you. > > What exactly is it that incurs the atomic context? I cannot seem to > figure out from this stack trace: I think something in fs/seq_file.c is taking an rcu lock. I suppose it doesn'

Re: [PATCH net-next v7 2/5] net/lapb: support netdev events

2020-11-26 Thread Xie He
Acked-by: Xie He

[PATCH net-next] selftests: tc-testing: enable CONFIG_NET_SCH_RED as a module

2020-11-26 Thread Davide Caratti
a proper kernel configuration for running kselftest can be obtained with: $ yes | make kselftest-merge enable compile support for the 'red' qdisc: otherwise, tdc kselftest fail when trying to run tdc test items contained in red.json. Signed-off-by: Davide Caratti --- tools/testing/selftests/t

[PATCH net-next] net/sched: act_ct: enable stats for HW offloaded entries

2020-11-26 Thread Marcelo Ricardo Leitner
By setting NF_FLOWTABLE_COUNTER. Otherwise, the updates added by commit ef803b3cf96a ("netfilter: flowtable: add counter support in HW offload") are not effective when using act_ct. While at it, now that we have the flag set, protect the call to nf_ct_acct_update() by commit beb97d3a3192 ("net/sch

Re: [PATCH] mwifiex: pcie: add enable_device_dump module parameter

2020-11-26 Thread Tsuchiya Yuto
On Fri, 2020-11-20 at 12:53 -0800, Brian Norris wrote: > (Sorry if anything's a bit slow here. I don't really have time to > write out full proposals myself.) Don’t worry, I (and other owners) am already glad to hear from upstream devs, including you :) (and I'm also sorry for the late reply from

Re: [PATCH 1/2] vxlan: Add needed_headroom for lower device

2020-11-26 Thread Annika Wickert
Tested-by: Annika Wickert On 26.11.20, 13:53, "Sven Eckelmann" wrote: It was observed that sending data via batadv over vxlan (on top of wireguard) reduced the performance massively compared to raw ethernet or batadv on raw ethernet. A check of perf data showed that the vxlan

[PATCH net] ipv4: Fix tos mask in inet_rtm_getroute()

2020-11-26 Thread Guillaume Nault
When inet_rtm_getroute() was converted to use the RCU variants of ip_route_input() and ip_route_output_key(), the TOS parameters stopped being masked with IPTOS_RT_MASK before doing the route lookup. As a result, "ip route get" can return a different route than what would be used when sending real

Re: [PATCH net-next v2 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-11-26 Thread Vladimir Oltean
urdly high pressure on the limited SPI bandwidth would be a readout interval that gives you very old counters. What exactly is it that incurs the atomic context? I cannot seem to figure out from this stack trace: [ 869.692526] [ cut here ]---- [ 869.697174] WARNING: CPU: 0 PID: 44

[PATCH v2] SUNRPC: Use zero-copy to perform socket send operations

2020-11-26 Thread Chuck Lever
Daire Byrne reports a ~50% aggregrate throughput regression on his Linux NFS server after commit da1661b93bf4 ("SUNRPC: Teach server to use xprt_sock_sendmsg for socket sends"), which replaced kernel_send_page() calls in NFSD's socket send path with calls to sock_sendmsg() using iov_iter. Investig

Re: [PATCH bpf-next v8 06/34] bpf: prepare for memcg-based memory accounting for bpf maps

2020-11-26 Thread Alexei Starovoitov
On Wed, Nov 25, 2020 at 6:30 PM Roman Gushchin wrote: > > I did consider this option. There are pros and cons. In general we tend to > charge the cgroup > which actually allocates the memory, and I decided to stick with this rule. I > agree, it's fairly > easy to come with arguments why always c

Re: [PATCH net-next 3/3] nfc: s3fwrn5: extract the common phy blocks

2020-11-26 Thread Krzysztof Kozlowski
On Fri, Nov 27, 2020 at 12:33:39AM +0900, bongsu.je...@gmail.com wrote: > From: Bongsu Jeon > > Extract the common phy blocks to reuse it. > The UART module will use the common blocks. Hi, Thanks for the patch. Few comments below. > Signed-off-by: Bongsu Jeon > --- > drivers/nfc/s3fwrn5/i2c

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-26 Thread Miguel Ojeda
On Thu, Nov 26, 2020 at 4:28 PM Geert Uytterhoeven wrote: > > The maintainer is not necessarily the owner/author of the code, and > thus may not know the intent of the code. Agreed, I was not blaming maintainers -- just trying to point out that the problem is there :-) In those cases, it is stil

Re: [PATCH net-next 2/3] nfc: s3fwrn5: reduce the EN_WAIT_TIME

2020-11-26 Thread Krzysztof Kozlowski
On Fri, Nov 27, 2020 at 12:33:38AM +0900, bongsu.je...@gmail.com wrote: > From: Bongsu Jeon > > The delay of 20ms is enough to enable and > wake up the Samsung's nfc chip. > > Signed-off-by: Bongsu Jeon > --- > drivers/nfc/s3fwrn5/i2c.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletion

Re: [PATCH net-next 1/3] nfc: s3fwrn5: use signed integer for parsing GPIO numbers

2020-11-26 Thread Krzysztof Kozlowski
On Fri, Nov 27, 2020 at 12:33:37AM +0900, bongsu.je...@gmail.com wrote: > From: Krzysztof Kozlowski > > GPIOs - as returned by of_get_named_gpio() and used by the gpiolib - are > signed integers, where negative number indicates error. The return > value of of_get_named_gpio() should not be assig

[PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

2020-11-26 Thread Uwe Kleine-König
The driver core ignores the return value of struct device_driver::remove because there is only little that can be done. For the shutdown callback it's ps3_system_bus_shutdown() which ignores the return value. To simplify the quest to make struct device_driver::remove return void, let struct ps3_sy

[PATCH 1/2] ALSA: ppc: drop if block with always false condition

2020-11-26 Thread Uwe Kleine-König
The remove callback is only called for devices that were probed successfully before. As the matching probe function cannot complete without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to check this here. Signed-off-by: Uwe Kleine-König --- sound/ppc/snd_ps3.c | 2 -- 1 file chang

Re: [PATCH net-next v3 00/12] net: dsa: microchip: PTP support for KSZ956x

2020-11-26 Thread Christian Eggers
Hi Microchip, as ACL based blocking of PTP traffic seems not to work, I tried to install MAC based static lookup rules on the switch I successfully managed to block other non-PTP traffic, but for PTP the lookup table entry (see below) seems not to work. Incoming SYNC messages on port are still for

[PATCH bpf-next v3 1/6] net: Remove the err argument from sock_from_file

2020-11-26 Thread Florent Revest
Currently, the sock_from_file prototype takes an "err" pointer that is either not set or set to -ENOTSOCK IFF the returned socket is NULL. This makes the error redundant and it is ignored by a few callers. This patch simplifies the API by letting callers deduce the error based on whether the retur

[PATCH bpf-next v3 4/6] bpf: Add an iterator selftest for bpf_sk_storage_delete

2020-11-26 Thread Florent Revest
The eBPF program iterates over all entries (well, only one) of a socket local storage map and deletes them all. The test makes sure that the entry is indeed deleted. Signed-off-by: Florent Revest Acked-by: Martin KaFai Lau --- .../selftests/bpf/prog_tests/bpf_iter.c | 64 +

[PATCH bpf-next v3 6/6] bpf: Test bpf_sk_storage_get in tcp iterators

2020-11-26 Thread Florent Revest
This extends the existing bpf_sk_storage_get test where a socket is created and tagged with its creator's pid by a task_file iterator. A TCP iterator is now also used at the end of the test to negate the values already stored in the local storage. The test therefore expects -getpid() to be stored

[PATCH bpf-next v3 5/6] bpf: Add an iterator selftest for bpf_sk_storage_get

2020-11-26 Thread Florent Revest
The eBPF program iterates over all files and tasks. For all socket files, it stores the tgid of the last task it encountered with a handle to that socket. This is a heuristic for finding the "owner" of a socket similar to what's done by lsof, ss, netstat or fuser. Potentially, this information coul

[PATCH bpf-next v3 2/6] bpf: Add a bpf_sock_from_file helper

2020-11-26 Thread Florent Revest
While eBPF programs can check whether a file is a socket by file->f_op == &socket_file_ops, they cannot convert the void private_data pointer to a struct socket BTF pointer. In order to do this a new helper wrapping sock_from_file is added. This is useful to tracing programs but also other program

[PATCH bpf-next v3 3/6] bpf: Expose bpf_sk_storage_* to iterator programs

2020-11-26 Thread Florent Revest
Iterators are currently used to expose kernel information to userspace over fast procfs-like files but iterators could also be used to manipulate local storage. For example, the task_file iterator could be used to initialize a socket local storage with associations between processes and sockets or

Re: [PATCH v2 5/5] bpf: Add an iterator selftest for bpf_sk_storage_get

2020-11-26 Thread Florent Revest
On Thu, 2020-11-19 at 16:32 -0800, Martin KaFai Lau wrote: > Does it affect all sk(s) in the system? Can it be limited to > the sk that the test is testing? Oh I just realized I haven't answered you here yet! Thanks for the reviews. :D I'm sending a v3 addressing your comments

Re: [PATCH net-next] net: switch to storing KCOV handle directly in sk_buff

2020-11-26 Thread Willem de Bruijn
On Thu, Nov 26, 2020 at 3:19 AM Marco Elver wrote: > > On Wed, 25 Nov 2020 at 21:43, Jakub Kicinski wrote: > > > > On Wed, 25 Nov 2020 18:34:36 +0100 Marco Elver wrote: > > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > > > index ffe3dcc0ebea..070b1077d976 100644 > > > --- a/net/core/skbu

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-26 Thread Karol Herbst
On Thu, Nov 26, 2020 at 4:28 PM Geert Uytterhoeven wrote: > > Hi Miguel, > > On Thu, Nov 26, 2020 at 3:54 PM Miguel Ojeda > wrote: > > On Wed, Nov 25, 2020 at 11:44 PM Edward Cree wrote: > > > To make the intent clear, you have to first be certain that you > > > understand the intent; otherwise

Re: Get MAC supported link modes for SFP port

2020-11-26 Thread Russell King - ARM Linux admin
On Thu, Nov 26, 2020 at 06:01:35PM +0200, Baruch Siach wrote: > Hi Andrew, > > On Thu, Nov 26 2020, Andrew Lunn wrote: > > On Thu, Nov 26, 2020 at 05:37:22PM +0200, Baruch Siach wrote: > >> I am trying to retrieve all MAC supported link modes > >> (ETHTOOL_LINK_MODE_*) for network interfaces with

Re: [PATCH bpf-next v8 06/34] bpf: prepare for memcg-based memory accounting for bpf maps

2020-11-26 Thread Roman Gushchin
On Thu, Nov 26, 2020 at 10:56:12AM +0100, Toke Høiland-Jørgensen wrote: > Roman Gushchin writes: > > > On Thu, Nov 26, 2020 at 01:21:41AM +0100, Daniel Borkmann wrote: > >> On 11/25/20 4:00 AM, Roman Gushchin wrote: > >> > In the absolute majority of cases if a process is making a kernel > >> > a

Re: Get MAC supported link modes for SFP port

2020-11-26 Thread Baruch Siach
Hi Andrew, On Thu, Nov 26 2020, Andrew Lunn wrote: > On Thu, Nov 26, 2020 at 05:37:22PM +0200, Baruch Siach wrote: >> I am trying to retrieve all MAC supported link modes >> (ETHTOOL_LINK_MODE_*) for network interfaces with SFP port. The >> 'supported' bit mask that ETHTOOL_GLINKSETTINGS provides

Re: [PATCH] dpaa2-mac: select NET_DEVLINK to fix build

2020-11-26 Thread Vladimir Oltean
On Thu, Nov 26, 2020 at 02:09:33PM +, Sudeep Holla wrote: > When NET_DEVLINK is not selected, we get the following build error: [...] > > Commit f6b19b354d50 ("net: devlink: select NET_DEVLINK from drivers") > selected NET_DEVLINK from several drivers and rely on the functions > being there. >

Re: Get MAC supported link modes for SFP port

2020-11-26 Thread Andrew Lunn
On Thu, Nov 26, 2020 at 05:37:22PM +0200, Baruch Siach wrote: > Hi netdev list, > > I am trying to retrieve all MAC supported link modes > (ETHTOOL_LINK_MODE_*) for network interfaces with SFP port. The > 'supported' bit mask that ETHTOOL_GLINKSETTINGS provides in > link_mode_masks[] changes to ma

Get MAC supported link modes for SFP port

2020-11-26 Thread Baruch Siach
Hi netdev list, I am trying to retrieve all MAC supported link modes (ETHTOOL_LINK_MODE_*) for network interfaces with SFP port. The 'supported' bit mask that ETHTOOL_GLINKSETTINGS provides in link_mode_masks[] changes to match the SFP module that happens to be plugged in. When no SFP module is pl

Re: Get MAC supported link modes for SFP port

2020-11-26 Thread Russell King - ARM Linux admin
On Thu, Nov 26, 2020 at 05:37:22PM +0200, Baruch Siach wrote: > Hi netdev list, > > I am trying to retrieve all MAC supported link modes > (ETHTOOL_LINK_MODE_*) for network interfaces with SFP port. The > 'supported' bit mask that ETHTOOL_GLINKSETTINGS provides in > link_mode_masks[] changes to ma

[PATCH net-next 1/3] nfc: s3fwrn5: use signed integer for parsing GPIO numbers

2020-11-26 Thread bongsu . jeon2
From: Krzysztof Kozlowski GPIOs - as returned by of_get_named_gpio() and used by the gpiolib - are signed integers, where negative number indicates error. The return value of of_get_named_gpio() should not be assigned to an unsigned int because in case of !CONFIG_GPIOLIB such number would be a v

[PATCH net-next 3/3] nfc: s3fwrn5: extract the common phy blocks

2020-11-26 Thread bongsu . jeon2
From: Bongsu Jeon Extract the common phy blocks to reuse it. The UART module will use the common blocks. Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/i2c.c| 111 --- drivers/nfc/s3fwrn5/phy_common.h | 86 ++ 2 files

[PATCH net-next 2/3] nfc: s3fwrn5: reduce the EN_WAIT_TIME

2020-11-26 Thread bongsu . jeon2
From: Bongsu Jeon The delay of 20ms is enough to enable and wake up the Samsung's nfc chip. Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/i2c.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/s3fwrn5/i2c.c index ae26594..9a

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-26 Thread Geert Uytterhoeven
Hi Miguel, On Thu, Nov 26, 2020 at 3:54 PM Miguel Ojeda wrote: > On Wed, Nov 25, 2020 at 11:44 PM Edward Cree wrote: > > To make the intent clear, you have to first be certain that you > > understand the intent; otherwise by adding either a break or a > > fallthrough to suppress the warning yo

Re: [PATCH net] mptcp: fix NULL ptr dereference on bad MPJ

2020-11-26 Thread Matthieu Baerts
Hi Paolo, On 26/11/2020 15:17, Paolo Abeni wrote: If an msk listener receives an MPJ carrying an invalid token, it will zero the request socket msk entry. That should later cause fallback and subflow reset - as per RFC - at subflow_syn_recv_sock() time due to failing hmac validation. Since comm

  1   2   >