[PATCH net-next] openvswitch: Use IS_ERR instead of IS_ERR_OR_NULL

2020-10-30 Thread YueHaibing
Fix smatch warning: net/openvswitch/meter.c:427 ovs_meter_cmd_set() warn: passing zero to 'PTR_ERR' dp_meter_create() never returns NULL, use IS_ERR instead of IS_ERR_OR_NULL to fix this. Signed-off-by: YueHaibing --- net/openvswitch/meter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [PATCH net-next 00/19] net: phy: add support for shared interrupts (part 1)

2020-10-30 Thread Ioana Ciornei
On Fri, Oct 30, 2020 at 10:56:24PM +0100, Heiner Kallweit wrote: > On 29.10.2020 11:07, Ioana Ciornei wrote: > > From: Ioana Ciornei > > > > This patch set aims to actually add support for shared interrupts in > > phylib and not only for multi-PHY devices. While we are at it, > > streamline the i

Re: [PATCH net-next 00/19] net: phy: add support for shared interrupts (part 1)

2020-10-30 Thread Ioana Ciornei
On Sat, Oct 31, 2020 at 12:36:27AM +0100, Andrew Lunn wrote: > > > - Every PHY driver gains a .handle_interrupt() implementation that, for > > > the most part, would look like below: > > > > > > irq_status = phy_read(phydev, INTR_STATUS); > > > if (irq_status < 0) { > > > phy_error

Re: [PATCH net-next] net: dlci: Deprecate the DLCI driver (aka the Frame Relay layer)

2020-10-30 Thread Xie He
On Fri, Oct 30, 2020 at 8:07 PM Jakub Kicinski wrote: > > This code has only seen cleanup patches since the git era begun - > do you think that it may still have users? Or is it completely unused? I don't think it is still used. But I don't have solid evidence. So I asked people in the warning me

Re: [PATCH net-next] net/smc: improve return codes for SMC-Dv2

2020-10-30 Thread Jakub Kicinski
On Wed, 28 Oct 2020 12:00:39 +0100 Karsten Graul wrote: > To allow better problem diagnosis the return codes for SMC-Dv2 are > improved by this patch. A few more CLC DECLINE codes are defined and > sent to the peer when an SMC connection cannot be established. > There are now multiple SMC variation

[PATCH] sfp: Fix error handing in sfp_probe()

2020-10-30 Thread YueHaibing
gpiod_to_irq() never return 0, but returns negative in case of error, check it and set gpio_irq to 0. Fixes: 73970055450e ("sfp: add SFP module support") Signed-off-by: YueHaibing --- drivers/net/phy/sfp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/sfp.

Re: [PATCH net-next] net: dlci: Deprecate the DLCI driver (aka the Frame Relay layer)

2020-10-30 Thread Jakub Kicinski
On Wed, 28 Oct 2020 00:05:04 -0700 Xie He wrote: > I wish to deprecate the Frame Relay layer (dlci.c) in the kernel because > we already have a newer and better "HDLC Frame Relay" layer (hdlc_fr.c). > > Reasons why hdlc_fr.c is better than dlci.c include: > > 1. > dlci.c is dated 1997, while hdlc

Re: [PATCH v11 4/4] bus: mhi: Add userspace client interface driver

2020-10-30 Thread Manivannan Sadhasivam
hi Hemant, On Fri, Oct 30, 2020 at 06:26:38PM -0700, Hemant Kumar wrote: > Hi Mani, > > On 10/30/20 3:34 AM, Manivannan Sadhasivam wrote: > > Hi Hemant, > > > > On Thu, Oct 29, 2020 at 07:45:46PM -0700, Hemant Kumar wrote: > > > This MHI client driver allows userspace clients to transfer > > > r

[PATCH net-next] net/mlx5e: Remove duplicated include

2020-10-30 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c index 599f5b5ebc97..58c177756dc4 100644 -

[PATCH net-next] net: hns3: Remove duplicated include

2020-10-30 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c index 3606240025a8..

[PATCH net-next] liquidio: cn68xx: Remove duplicated include

2020-10-30 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/ethernet/cavium/liquidio/cn68xx_device.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c b/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c index 2a6d1cadac9e..30254e

Re: [PATCH net] ip6_tunnel: set inner ipproto before ip6_tnl_encap.

2020-10-30 Thread Vadim Fedorenko
On 30.10.2020 12:54, Alexander Ovechkin wrote: On 30 Oct 2020, at 14:01, Vadim Fedorenko wrote: Could not reproduce the bug. Could you please provide a test scenario? It can be reproduced if your net device doesn’t support udp tunnel segmentation (i.e its features do not have SKB_GSO_UDP_TUNN

Re: arping stuck with ENOBUFS in 4.19.150

2020-10-30 Thread Yunsheng Lin
On 2020/10/30 19:50, Joakim Tjernlund wrote: > On Fri, 2020-10-30 at 09:36 +0800, Yunsheng Lin wrote: >> CAUTION: This email originated from outside of the organization. Do not >> click links or open attachments unless you recognize the sender and know the >> content is safe. >> >> >> On 2020/10/

Re: [PATCH net v2 2/2] dpaa_eth: fix the RX headroom size alignment

2020-10-30 Thread Jakub Kicinski
On Wed, 28 Oct 2020 18:41:00 +0200 Camelia Groza wrote: > @@ -2842,7 +2842,8 @@ static int dpaa_ingress_cgr_init(struct dpaa_priv *priv) > return err; > } > > -static inline u16 dpaa_get_headroom(struct dpaa_buffer_layout *bl) > +static inline u16 dpaa_get_headroom(struct dpaa_buffer_layout

Re: [PATCH net v2 1/2] dpaa_eth: update the buffer layout for non-A050385 erratum scenarios

2020-10-30 Thread Jakub Kicinski
On Wed, 28 Oct 2020 18:40:59 +0200 Camelia Groza wrote: > Impose a large RX private data area only when the A050385 erratum is > present on the hardware. A smaller buffer size is sufficient in all > other scenarios. This enables a wider range of linear frame sizes > in non-erratum scenarios Any wo

Re: [PATCH net-next 0/5] L2 multicast forwarding for Ocelot switch

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 04:27:33 +0200 Vladimir Oltean wrote: > This series enables the mscc_ocelot switch to forward raw L2 (non-IP) > mdb entries as configured by the bridge driver after this patch: > > https://patchwork.ozlabs.org/project/netdev/patch/20201028233831.610076-1-vladimir.olt...@nxp.com

Re: [PATCH v11 4/4] bus: mhi: Add userspace client interface driver

2020-10-30 Thread Hemant Kumar
Hi Mani, On 10/30/20 3:34 AM, Manivannan Sadhasivam wrote: Hi Hemant, On Thu, Oct 29, 2020 at 07:45:46PM -0700, Hemant Kumar wrote: This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device ob

Re: [PATCH net-next 4/5] net: mscc: ocelot: make entry_type a member of struct ocelot_multicast

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 04:27:37 +0200 Vladimir Oltean wrote: > + mc = devm_kzalloc(ocelot->dev, sizeof(*mc), GFP_KERNEL); > + if (!mc) > + return -ENOMEM; > + > + mc->entry_type = ocelot_classify_mdb(mdb->addr); > + ether_addr_copy(mc

Re: [PATCH nf 0/2] route_me_harder routing loop with tunnels

2020-10-30 Thread Pablo Neira Ayuso
On Sat, Oct 31, 2020 at 02:00:03AM +0100, Pablo Neira Ayuso wrote: > On Sat, Oct 31, 2020 at 01:05:03AM +0100, Jason A. Donenfeld wrote: > > On Fri, Oct 30, 2020 at 8:23 PM Pablo Neira Ayuso > > wrote: > > > > > > On Thu, Oct 29, 2020 at 03:56:04AM +0100, Jason A. Donenfeld wrote: > > > > Hi Pabl

Re: [PATCH nf 0/2] route_me_harder routing loop with tunnels

2020-10-30 Thread Pablo Neira Ayuso
On Sat, Oct 31, 2020 at 01:05:03AM +0100, Jason A. Donenfeld wrote: > On Fri, Oct 30, 2020 at 8:23 PM Pablo Neira Ayuso wrote: > > > > On Thu, Oct 29, 2020 at 03:56:04AM +0100, Jason A. Donenfeld wrote: > > > Hi Pablo, > > > > > > This series fixes a bug in the route_me_harder family of functions

[PATCH net-next 2/2] drivers: net: davicom Add COMPILE_TEST support

2020-10-30 Thread Andrew Lunn
Improve the build testing of this davicom driver by enabling it when COMPILE_TEST is selected. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/davicom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/davicom/Kconfig b/drivers/net/ethernet/davi

Re: [PATCH net-next] net: bridge: explicitly convert between mdb entry state and port group flags

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 01:48:15 +0200 Vladimir Oltean wrote: > When creating a new multicast port group, there is implicit conversion > between the __u8 state member of struct br_mdb_entry and the unsigned > char flags member of struct net_bridge_port_group. This implicit > conversion relies on the fa

[PATCH net-next 1/2] drivers: net: davicom: Fixed unused but set variable with W=1

2020-10-30 Thread Andrew Lunn
drivers/net/ethernet/davicom//dm9000.c: In function ‘dm9000_dumpblk_8bit’: drivers/net/ethernet/davicom//dm9000.c:235:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] The driver needs to read packet data from the device even when the packet is known bad. There is no need to

[PATCH net-next 0/2] davicom W=1 fixes

2020-10-30 Thread Andrew Lunn
Fixup various W=1 warnings, and then add COMPILE_TEST support, which explains why these where missed on the previous pass. Andrew Lunn (2): drivers: net: davicom: Fixed unused but set variable with W=1 drivers: net: davicom Add COMPILE_TEST support drivers/net/ethernet/davicom/Kconfig | 2 +

Re: [PATCH v4 net-next] net: bridge: mcast: add support for raw L2 multicast groups

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 01:38:31 +0200 Vladimir Oltean wrote: > From: Nikolay Aleksandrov > > Extend the bridge multicast control and data path to configure routes > for L2 (non-IP) multicast groups. > > The uapi struct br_mdb_entry union u is extended with another variant, > mac_addr, which does no

[PATCH net-next] drivers: net: tulip: Fix set but not used with W=1

2020-10-30 Thread Andrew Lunn
When compiled for platforms other than __i386__ or __x86_64__: drivers/net/ethernet/dec/tulip/tulip_core.c: In function ‘tulip_init_one’: drivers/net/ethernet/dec/tulip/tulip_core.c:1296:13: warning: variable ‘last_irq’ set but not used [-Wunused-but-set-variable] 1296 | static int last_irq; A

[PATCH net-next 2/7] drivers: net: smc91x: Fix missing kerneldoc reported by W=1

2020-10-30 Thread Andrew Lunn
drivers/net/ethernet/smsc/smc91x.c:2199: warning: Function parameter or member 'dev' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2199: warning: Function parameter or member 'desc' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2199:

[PATCH net-next 0/7] smsc W=1 warning fixes

2020-10-30 Thread Andrew Lunn
Fixup various W=1 warnings, and then add COMPILE_TEST support, which explains why these where missed on the previous pass. One of these patches added as a new checkpatch warning, by copy/pasting an existing macro and slightly modifying it. The code already has lots of checkpatch warnings, so one m

[PATCH net-next 1/7] drivers: net: smc91x: Fix set but unused W=1 warning

2020-10-30 Thread Andrew Lunn
drivers/net/ethernet/smsc/smc91x.c:706:51: warning: variable ‘pkt_len’ set but not used [-Wunused-but-set-variable] 706 | unsigned int saved_packet, packet_no, tx_status, pkt_len; Add a new macro for getting fields out of the header, which only gets the status, not the length which in this cas

[PATCH net-next 4/7] drivers: net: smc911x: Fix set but unused status because of DBG macro

2020-10-30 Thread Andrew Lunn
drivers/net/ethernet/smsc/smc911x.c: In function ‘smc911x_timeout’: drivers/net/ethernet/smsc/smc911x.c:1251:6: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] 1251 | int status, mask; The status is read in order to print it via the DBG macro. However, due to the way DBG

[PATCH net-next 7/7] drivers: net: smsc: Add COMPILE_TEST support

2020-10-30 Thread Andrew Lunn
Improve the build testing of these SMSC drivers by enabling them when COMPILE_TEST is selected. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/smsc/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/smsc/Kconfig b/drivers/net/ethernet/sms

[PATCH net-next v6 5/5] net: hdlc_fr: Add support for any Ethertype

2020-10-30 Thread Xie He
Change the fr_rx function to make this driver support any Ethertype when receiving skbs on normal (non-Ethernet-emulating) PVC devices. (This driver is already able to handle any Ethertype when sending.) Originally in the fr_rx function, the code that parses the long (10-byte) header only recogniz

[PATCH net-next v6 3/5] net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devices

2020-10-30 Thread Xie He
When an skb is received on a normal (non-Ethernet-emulating) PVC device, call skb_reset_mac_header before we pass it to upper layers. This is because normal PVC devices don't have header_ops, so any header we have would not be visible to upper layer code when sending, so the header shouldn't be vi

[PATCH net-next 5/7] drivers: net: smc911x: Fix passing wrong number of parameters to DBG() macro

2020-10-30 Thread Andrew Lunn
Now that the compiler always sees the parameters passed to the DBG() macro, it gives an error message about wrong parameters. The comment says it all: /* ndev is not valid yet, so avoid passing it in. */ DBG(SMC_DEBUG_FUNC, "--> %s\n", __func__); You cannot not just pass a parame

[PATCH net-next 3/7] drivers: net: smc911x: Work around set but unused status

2020-10-30 Thread Andrew Lunn
drivers/net/ethernet/smsc/smc911x.c: In function ‘smc911x_phy_interrupt’: drivers/net/ethernet/smsc/smc911x.c:976:6: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] 976 | int status; A comment indicates the status needs to be read from the PHY, otherwise bad things happ

[PATCH net-next 6/7] drivers: net: smc911x: Fix cast from pointer to integer of different size

2020-10-30 Thread Andrew Lunn
drivers/net/ethernet/smsc/smc911x.c: In function ‘smc911x_hardware_send_pkt’: drivers/net/ethernet/smsc/smc911x.c:471:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 471 | cmdA = (((u32)skb->data & 0x3) << 16) | When built on 64bit targets, the skb->data poi

[PATCH net-next v6 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-30 Thread Xie He
When the fr_rx function drops a received frame (because the protocol type is not supported, or because the PVC virtual device that corresponds to the DLCI number and the protocol type doesn't exist), the function frees the skb and returns. The code for freeing the skb and returning is repeated sev

[PATCH net-next v6 4/5] net: hdlc_fr: Improve the initial checks when we receive an skb

2020-10-30 Thread Xie He
1. Change the skb->len check from "<= 4" to "< 4". At first we only need to ensure a 4-byte header is present. We indeed normally need the 5th byte, too, but it'd be more logical and cleaner to check its existence when we actually need it. 2. Add an fh->ea2 check to the initial checks in fr_rx. fh

[PATCH net-next v6 2/5] net: hdlc_fr: Change the use of "dev" in fr_rx to make the code cleaner

2020-10-30 Thread Xie He
The eth_type_trans function is called when we receive frames carrying Ethernet frames. This function expects a non-NULL pointer as an argument, and assigns it directly to skb->dev. However, the code handling other types of frames first assigns the pointer to "dev", and then at the end checks wheth

[PATCH net-next v6 0/5] net: hdlc_fr: Improve fr_rx and add support for any Ethertype

2020-10-30 Thread Xie He
The main purpose of this series is the last patch. The previous 4 patches are just code clean-ups so that the last patch will not make the code too messy. The patches must be applied in sequence. The receiving code of this driver doesn't support arbitrary Ethertype values. It only recognizes a few

Re: [PATCH net-next 0/4] sfc: EF100 TSO enhancements

2020-10-30 Thread Jakub Kicinski
On Wed, 28 Oct 2020 20:41:21 + Edward Cree wrote: > Support TSO over encapsulation (with GSO_PARTIAL), and over VLANs > (which the code already handled but we didn't advertise). Also > correct our handling of IPID mangling. > > I couldn't find documentation of exactly what shaped SKBs we ca

[PATCH net-next v5 3/5] net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devices

2020-10-30 Thread Xie He
When an skb is received on a normal (non-Ethernet-emulating) PVC device, call skb_reset_mac_header before we pass it to upper layers. This is because normal PVC devices don't have header_ops, so any header we have would not be visible to upper layer code when sending, so the header shouldn't be vi

[PATCH net-next v5 2/5] net: hdlc_fr: Change the use of "dev" in fr_rx to make the code cleaner

2020-10-30 Thread Xie He
The eth_type_trans function is called when we receive frames carrying Ethernet frames. This function expects a non-NULL pointer as an argument, and assigns it directly to skb->dev. However, the code handling other types of frames first assigns the pointer to "dev", and then at the end checks wheth

[PATCH net-next v5 4/5] net: hdlc_fr: Improve the initial checks when we receive an skb

2020-10-30 Thread Xie He
1. Change the skb->len check from "<= 4" to "< 4". At first we only need to ensure a 4-byte header is present. We indeed normally need the 5th byte, too, but it'd be more logical and cleaner to check its existence when we actually need it. 2. Add an fh->ea2 check to the initial checks in fr_rx. fh

[PATCH net-next v5 5/5] net: hdlc_fr: Add support for any Ethertype

2020-10-30 Thread Xie He
Change the fr_rx function to make this driver support any Ethertype when receiving skbs on normal (non-Ethernet-emulating) PVC devices. (This driver is already able to handle any Ethertype when sending.) Originally in the fr_rx function, the code that parses the long (10-byte) header only recogniz

[PATCH net-next v5 0/5] net: hdlc_fr: Improve fr_rx and add support for any Ethertype

2020-10-30 Thread Xie He
The main purpose of this series is the last patch. The previous 4 patches are just code clean-ups so that the last patch will not make the code too messy. The patches must be applied in sequence. The receiving code of this driver doesn't support arbitrary Ethertype values. It only recognizes a few

[PATCH net-next v5 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-30 Thread Xie He
When the fr_rx function drops a received frame (because the protocol type is not supported, or because the PVC virtual device that corresponds to the DLCI number and the protocol type doesn't exist), the function frees the skb and returns. The code for freeing the skb and returning is repeated sev

Re: [PATCH v11 4/4] bus: mhi: Add userspace client interface driver

2020-10-30 Thread Hemant Kumar
Hi Randy, On 10/29/20 10:48 PM, Randy Dunlap wrote: On 10/29/20 7:45 PM, Hemant Kumar wrote: diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig index e841c10..476cc55 100644 --- a/drivers/bus/mhi/Kconfig +++ b/drivers/bus/mhi/Kconfig @@ -20,3 +20,16 @@ config MHI_BUS_DEBUG

Re: [PATCH v2 net 0/5] net: ipa: minor bug fixes

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 11:50:52 -0500 Alex Elder wrote: > On 10/29/20 11:11 AM, Jakub Kicinski wrote: > > On Wed, 28 Oct 2020 14:41:43 -0500 Alex Elder wrote: > >> This series fixes several bugs. They are minor, in that the code > >> currently works on supported platforms even without these patches

Re: [PATCH net-next v4] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

2020-10-30 Thread Jakub Kicinski
On Wed, 28 Oct 2020 10:21:25 -0700 Moritz Fischer wrote: > The driver does not implement a shutdown handler which leads to issues > when using kexec in certain scenarios. The NIC keeps on fetching > descriptors which gets flagged by the IOMMU with errors like this: > > DMAR: DMAR:[DMA read] Reques

Re: [PATCH net-next v5] net: phy: marvell: add special handling of Finisar modules with 88E1111

2020-10-30 Thread Jakub Kicinski
On Wed, 28 Oct 2020 11:15:40 -0600 Robert Hancock wrote: > The Finisar FCLF8520P2BTL 1000BaseT SFP module uses a Marvel 88E PHY > with a modified PHY ID. Add support for this ID using the 88E > methods. > > By default these modules do not have 1000BaseX auto-negotiation enabled, > which is

[PATCH net-next] mpls: drop skb's dst in mpls_forward()

2020-10-30 Thread Guillaume Nault
Commit 394de110a733 ("net: Added pointer check for dst->ops->neigh_lookup in dst_neigh_lookup_skb") added a test in dst_neigh_lookup_skb() to avoid a NULL pointer dereference. The root cause was the MPLS forwarding code, which doesn't call skb_dst_drop() on incoming packets. That is, if the packet

Re: [PATCH nf 0/2] route_me_harder routing loop with tunnels

2020-10-30 Thread Jason A. Donenfeld
On Fri, Oct 30, 2020 at 8:23 PM Pablo Neira Ayuso wrote: > > On Thu, Oct 29, 2020 at 03:56:04AM +0100, Jason A. Donenfeld wrote: > > Hi Pablo, > > > > This series fixes a bug in the route_me_harder family of functions with > > regards to tunnel interfaces. The first patch contains an addition to >

Re: [PATCH] fix for potential NULL pointer dereference with bare lan743x

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 03:28:45 +0300 Sergej Bauer wrote: > This is just a minor fix which prevents a kernel NULL pointer > dereference when using phy-less lan743x. > > Signed-off-by: Sergej Bauer I take you mean when the device is down netdev->phydev will be NULL? > diff --git a/drivers/net/eth

Re: [PATCHv5 net-next 00/16] sctp: Implement RFC6951: UDP Encapsulation of SCTP

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 15:04:54 +0800 Xin Long wrote: >This patchset is using the udp4/6 tunnel APIs to implement the UDP >Encapsulation of SCTP with not much change in SCTP protocol stack >and with all current SCTP features keeped in Linux Kernel. > >1 - 4: Fix some UDP issues that m

Re: [PATCH RFC leds + net-next 2/7] leds: trigger: netdev: simplify the driver by using bit field members

2020-10-30 Thread Marek Behún
On Fri, 30 Oct 2020 23:37:52 +0100 Jacek Anaszewski wrote: > Hi Marek, > > Bitops are guaranteed to be atomic and this was done for a reason. Hmm okay... Sooo, netdev_trig_work cannot be executed at the same time as the link/linkup/rx/tx changing stuff from netdev_trig_notify, interval_store or

Re: [PATCH net-next 00/19] net: phy: add support for shared interrupts (part 1)

2020-10-30 Thread Andrew Lunn
> > - Every PHY driver gains a .handle_interrupt() implementation that, for > > the most part, would look like below: > > > > irq_status = phy_read(phydev, INTR_STATUS); > > if (irq_status < 0) { > > phy_error(phydev); > > return IRQ_NONE; > > } > > > > i

Re: [PATCH bpf-next 03/11] libbpf: unify and speed up BTF string deduplication

2020-10-30 Thread Song Liu
> On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote: > > From: Andrii Nakryiko > > Revamp BTF dedup's string deduplication to match the approach of writable BTF > string management. This allows to transfer deduplicated strings index back to > BTF object after deduplication without expensive

RE: [PATCH v2 31/39] docs: ABI: cleanup several ABI documents

2020-10-30 Thread Peter Chen
Acked-by: Peter Chen For: Documentation/ABI/testing/usb-charger-uevent Peter

Re: [PATCH net-next] net: avoid unneeded UDP L4 and fraglist GSO resegmentation

2020-10-30 Thread Willem de Bruijn
On Fri, Oct 30, 2020 at 2:33 PM Alexander Lobakin wrote: > > Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") added a support > for fraglist UDP L4 and fraglist GSO not only for local traffic, but also > for forwarding. This works well on simple setups, but when any logical > netdev (e.g

Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-10-30 Thread Jakub Kicinski
On Fri, 30 Oct 2020 12:29:50 -0500 Dan Murphy wrote: > The DP83TD510E is an ultra-low power Ethernet physical layer transceiver > that supports 10M single pair cable. > > The device supports both 2.4-V p2p and 1-V p2p output voltage as defined > by IEEE 802.3cg 10Base-T1L specfications. These mode

Re: [PATCH] Documentation: tproxy: more gentle intro

2020-10-30 Thread Jakub Kicinski
On Tue, 27 Oct 2020 14:06:20 +0200 Motiejus Jakštys wrote: > Clarify tproxy odcumentation, so it's easier to read/understand without > a-priori in-kernel transparent proxying knowledge: > > - re-shuffle the sections, as the "router" section is easier to > understand when getting started. > - add

Re: [PATCH net-next v4 4/5] net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devices

2020-10-30 Thread Xie He
On Fri, Oct 30, 2020 at 3:22 PM Willem de Bruijn wrote: > > It's indirect: > > skb_reset_network_header(skb); > if (!skb_transport_header_was_set(skb)) > skb_reset_transport_header(skb); > skb_reset_mac_len(skb); Oh. I see. skb_reset_mac_len would set skb->

Re: [PATCH net-next 00/19] net: phy: add support for shared interrupts (part 1)

2020-10-30 Thread Vladimir Oltean
On Sat, Oct 31, 2020 at 12:06:42AM +0200, Vladimir Oltean wrote: > On Fri, Oct 30, 2020 at 10:56:24PM +0100, Heiner Kallweit wrote: > > I'd just like to avoid the term "shared interrupt", because it has > > a well-defined meaning. Our major concern isn't shared interrupts > > but support for multip

[PATCH net-next 3/6] tcp: propagate MPTCP skb extensions on xmit splits

2020-10-30 Thread Mat Martineau
From: Paolo Abeni When the TCP stack splits a packet on the write queue, the tail half currently lose the associated skb extensions, and will not carry the DSM on the wire. The above does not cause functional problems and is allowed by the RFC, but interact badly with GRO and RX coalescing, as p

[PATCH net-next 1/6] mptcp: adjust mptcp receive buffer limit if subflow has larger one

2020-10-30 Thread Mat Martineau
From: Florian Westphal In addition to tcp autotuning during read, it may also increase the receive buffer in tcp_clamp_window(). In this case, mptcp should adjust its receive buffer size as well so it can move all pending skbs from the subflow socket to the mptcp socket. At this time, TCP can h

[PATCH net-next 6/6] selftests: mptcp: add ADD_ADDR timeout test case

2020-10-30 Thread Mat Martineau
From: Geliang Tang This patch added the test case for retransmitting ADD_ADDR when timeout occurs. It set NS1's add_addr_timeout to 1 second, and drop NS2's ADD_ADDR echo packets. Here we need to slow down the transfer process of all data to let the ADD_ADDR suboptions can be retransmitted three

[PATCH net-next 2/6] mptcp: use _fast lock version in __mptcp_move_skbs

2020-10-30 Thread Mat Martineau
From: Florian Westphal The function is short and won't sleep, so this can use the _fast version. Acked-by: Paolo Abeni Reviewed-by: Mat Martineau Signed-off-by: Florian Westphal --- net/mptcp/protocol.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/mptcp/protoc

[PATCH net-next 0/6] mptcp: Miscellaneous MPTCP fixes

2020-10-30 Thread Mat Martineau
This is a collection of small fixup and minor enhancement patches that have accumulated in the MPTCP tree while net-next was closed. These are prerequisites for larger changes we have queued up. Patch 1 refines receive buffer autotuning. Patches 2 and 4 are some minor locking and refactoring chan

[PATCH net-next 5/6] mptcp: add a new sysctl add_addr_timeout

2020-10-30 Thread Mat Martineau
From: Geliang Tang This patch added a new sysctl, named add_addr_timeout, to control the timeout value (in seconds) of the ADD_ADDR retransmission. Suggested-by: Matthieu Baerts Suggested-by: Paolo Abeni Acked-by: Paolo Abeni Reviewed-by: Matthieu Baerts Signed-off-by: Geliang Tang --- net

[PATCH net-next 4/6] mptcp: split mptcp_clean_una function

2020-10-30 Thread Mat Martineau
From: Florian Westphal mptcp_clean_una() will wake writers in case memory could be reclaimed. When called from mptcp_sendmsg the wakeup code isn't needed. Move the wakeup to a new helper and then use that from the mptcp worker. Reviewed-by: Mat Martineau Signed-off-by: Florian Westphal --- n

Re: [PATCH net-next 00/19] net: phy: add support for shared interrupts (part 1)

2020-10-30 Thread Heiner Kallweit
On 30.10.2020 23:06, Vladimir Oltean wrote: > On Fri, Oct 30, 2020 at 10:56:24PM +0100, Heiner Kallweit wrote: >> I'd just like to avoid the term "shared interrupt", because it has >> a well-defined meaning. Our major concern isn't shared interrupts >> but support for multiple interrupt sources (in

Re: [PATCH net-next 00/19] net: phy: add support for shared interrupts (part 1)

2020-10-30 Thread Heiner Kallweit
On 29.10.2020 11:07, Ioana Ciornei wrote: > From: Ioana Ciornei > > This patch set aims to actually add support for shared interrupts in > phylib and not only for multi-PHY devices. While we are at it, > streamline the interrupt handling in phylib. > > For a bit of context, at the moment, there

Re: [PATCH RFC leds + net-next 2/7] leds: trigger: netdev: simplify the driver by using bit field members

2020-10-30 Thread Jacek Anaszewski
Hi Marek, Bitops are guaranteed to be atomic and this was done for a reason. On 10/30/20 12:44 PM, Marek Behún wrote: Use bit fields members in struct led_netdev_data instead of one mode member and set_bit/clear_bit/test_bit functions. These functions are suitable for longer or variable length

[PATCH v7 5/6] can: ctucanfd: CTU CAN FD open-source IP core - platform/SoC support.

2020-10-30 Thread Pavel Pisa
Platform bus adaptation for CTU CAN FD open-source IP core. The core has been tested together with OpenCores SJA1000 modified to be CAN FD frames tolerant on MicroZed Zynq based MZ_APO education kits designed by Petr Porazil from PiKRON.com company. FPGA design https://gitlab.fel.cvut.cz/canbus

[PATCH v7 6/6] docs: ctucanfd: CTU CAN FD open-source IP core documentation.

2020-10-30 Thread Pavel Pisa
CTU CAN FD IP core documentation based on Martin Jeřábek's diploma theses Open-source and Open-hardware CAN FD Protocol Support https://dspace.cvut.cz/handle/10467/80366 . Signed-off-by: Pavel Pisa Signed-off-by: Martin Jerabek Signed-off-by: Ondrej Ille --- .../device_drivers/ctu/ctucanfd-dri

[PATCH v7 3/6] can: ctucanfd: add support for CTU CAN FD open-source IP core - bus independent part.

2020-10-30 Thread Pavel Pisa
From: Martin Jerabek This driver adds support for the CTU CAN FD open-source IP core. More documentation and core sources at project page (https://gitlab.fel.cvut.cz/canbus/ctucanfd_ip_core). The core integration to Xilinx Zynq system as platform driver is available (https://gitlab.fel.cvut.cz/ca

[PATCH v7 4/6] can: ctucanfd: CTU CAN FD open-source IP core - PCI bus support.

2020-10-30 Thread Pavel Pisa
PCI bus adaptation for CTU CAN FD open-source IP core. The project providing FPGA design for Intel EP4CGX15 based DB4CGX15 PCIe board with PiKRON.com designed transceiver riser shield is available at https://gitlab.fel.cvut.cz/canbus/pcie-ctucanfd . Signed-off-by: Pavel Pisa Signed-off-by: Marti

Re: [PATCH bpf-next 02/11] selftest/bpf: relax btf_dedup test checks

2020-10-30 Thread Song Liu
On Fri, Oct 30, 2020 at 11:45 AM Andrii Nakryiko wrote: > [...] > > > @@ -6775,10 +6774,15 @@ static void do_test_dedup(unsigned int test_num) > > > err = -1; > > > goto done; > > > } > > > - if (CHECK(memcmp((void *)tes

[PATCH v7 2/6] dt-bindings: net: can: binding for CTU CAN FD open-source IP core.

2020-10-30 Thread Pavel Pisa
The device-tree bindings for open-source/open-hardware CAN FD IP core designed at the Czech Technical University in Prague. CTU CAN FD IP core and other CTU CAN bus related projects listing and documentation page http://canbus.pages.fel.cvut.cz/ Signed-off-by: Pavel Pisa Reviewed-by: Rob Her

[PATCH v7 1/6] dt-bindings: vendor-prefix: add prefix for the Czech Technical University in Prague.

2020-10-30 Thread Pavel Pisa
The Czech Technical University in Prague (CTU) is one of the biggest and oldest (founded 1707) technical universities in Europe. The abbreviation in Czech language is ČVUT according to official name in Czech language České vysoké učení technické v Praze The English translation The Czech Tech

Re: [PATCH net-next v4 4/5] net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devices

2020-10-30 Thread Willem de Bruijn
On Fri, Oct 30, 2020 at 5:49 PM Xie He wrote: > > On Fri, Oct 30, 2020 at 2:28 PM Willem de Bruijn > wrote: > > > > Yes, it might require holding off the other patches until net is > > merged into net-next. > > > > Packet sockets are likely not the only way these packets are received? > > It chan

[PATCH v7 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

2020-10-30 Thread Pavel Pisa
This driver adds support for the CTU CAN FD open-source IP core. More documentation and core sources at project page (https://gitlab.fel.cvut.cz/canbus/ctucanfd_ip_core). The core integration to Xilinx Zynq system as platform driver is available (https://gitlab.fel.cvut.cz/canbus/zynq/zynq-can-sja1

Re: [PATCH net-next 00/19] net: phy: add support for shared interrupts (part 1)

2020-10-30 Thread Vladimir Oltean
On Fri, Oct 30, 2020 at 10:56:24PM +0100, Heiner Kallweit wrote: > I'd just like to avoid the term "shared interrupt", because it has > a well-defined meaning. Our major concern isn't shared interrupts > but support for multiple interrupt sources (in addition to > link change) in a PHY. You may be

Re: [PATCH net-next 00/19] net: phy: add support for shared interrupts (part 1)

2020-10-30 Thread Heiner Kallweit
On 29.10.2020 11:07, Ioana Ciornei wrote: > From: Ioana Ciornei > > This patch set aims to actually add support for shared interrupts in > phylib and not only for multi-PHY devices. While we are at it, > streamline the interrupt handling in phylib. > > For a bit of context, at the moment, there

Re: [PATCH net-next v4 4/5] net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devices

2020-10-30 Thread Xie He
On Fri, Oct 30, 2020 at 2:28 PM Willem de Bruijn wrote: > > Yes, it might require holding off the other patches until net is > merged into net-next. > > Packet sockets are likely not the only way these packets are received? > It changes mac_len as computed in __netif_receive_skb_core. I looked at

Re: [PATCH net 1/1] ptp: idt82p33: add adjphase support

2020-10-30 Thread Jakub Kicinski
On Fri, 30 Oct 2020 13:55:32 -0400 min.li...@renesas.com wrote: > From: Min Li > > Add idt82p33_adjwritephase() to support PHC write phase mode. > > Signed-off-by: Min Li Doesn't build on 32bit. make[2]: *** Deleting file 'Module.symvers' ERROR: modpost: "__divdi3" [drivers/ptp/ptp_idt82p33.k

Re: [PATCH net-next v4 3/5] net: hdlc_fr: Improve the initial checks when we receive an skb

2020-10-30 Thread Xie He
On Fri, Oct 30, 2020 at 2:20 PM Willem de Bruijn wrote: > > Thanks for that context. If it's not captured in the code, it would be > great to include in the commit message. OK. I'll update the commit message. > From a quick scan, RFC 2427 does not appear to actually define the > Q.922 address. F

Re: [PATCH net-next] net: dsa: mv88e6xxx: fix vlan setup

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 16:09:03 + Russell King wrote: > DSA assumes that a bridge which has vlan filtering disabled is not > vlan aware, and ignores all vlan configuration. However, the kernel > software bridge code allows configuration in this state. > > This causes the kernel's idea of the brid

Re: [PATCH net-next v4 4/5] net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devices

2020-10-30 Thread Willem de Bruijn
On Fri, Oct 30, 2020 at 4:08 PM Xie He wrote: > > On Fri, Oct 30, 2020 at 9:30 AM Willem de Bruijn > wrote: > > > > Acked-by: Willem de Bruijn > > Thanks for your ack! > > > Should this go to net if a bugfix though? > > Yes, this should theoretically be a bug fix. But I didn't think this > was a

Re: [PATCH net] net: openvswitch: silence suspicious RCU usage warning

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 15:53:21 +0100 Eelco Chaudron wrote: > Silence suspicious RCU usage warning in ovs_flow_tbl_masks_cache_resize() > by replacing rcu_dereference() with rcu_dereference_ovsl(). > > In addition, when creating a new datapath, make sure it's configured under > the ovs_lock. > > Fix

Re: [PATCH net-next v4 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-30 Thread Xie He
On Fri, Oct 30, 2020 at 2:12 PM Willem de Bruijn wrote: > > Jakub recently made stats behavior less ambiguous, in commit > 0db0c34cfbc9 ("net: tighten the definition of interface statistics"). > > That said, it's not entirely clear whether rx_dropped would be allowed > to include rx_errors. > > My

Re: [PATCH net-next v4 5/5] net: hdlc_fr: Add support for any Ethertype

2020-10-30 Thread Willem de Bruijn
On Fri, Oct 30, 2020 at 3:29 PM Xie He wrote: > > On Fri, Oct 30, 2020 at 9:33 AM Willem de Bruijn > wrote: > > > > Should this still check data[5] == FR_PAD? > > No, the 6th byte (data[5]) is not a padding field. It is the first > byte of the SNAP header. The original code is misleading. That is

Re: [PATCH net-next v4 3/5] net: hdlc_fr: Improve the initial checks when we receive an skb

2020-10-30 Thread Willem de Bruijn
On Fri, Oct 30, 2020 at 3:21 PM Xie He wrote: > > On Fri, Oct 30, 2020 at 9:31 AM Willem de Bruijn > wrote: > > > > > Add an fh->ea2 check to the initial checks in fr_rx. fh->ea2 == 1 means > > > the second address byte is the final address byte. We only support the > > > case where the address l

Re: [PATCH] drivers: net: phy: Fix spelling in comment defalut to default

2020-10-30 Thread Jakub Kicinski
On Thu, 29 Oct 2020 14:09:23 +0100 Andrew Lunn wrote: > On Thu, Oct 29, 2020 at 03:25:25PM +0530, Bhaskar Chowdhury wrote: > > Fixed spelling in comment like below: > > > > s/defalut/default/p > > > > This is in linux-next. > > > > Signed-off-by: Bhaskar Chowdhury > > Reviewed-by: Andrew Lun

Re: [PATCH net-next v4 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-30 Thread Willem de Bruijn
On Fri, Oct 30, 2020 at 4:02 PM Xie He wrote: > > On Fri, Oct 30, 2020 at 9:35 AM Willem de Bruijn > wrote: > > > > In general we try to avoid changing counter behavior like that, as > > existing users > > may depend on current behavior, e.g., in dashboards or automated monitoring. > > > > I don'

Re: [PATCH] net: cls_api: remove unneeded local variable in tc_dump_chain()

2020-10-30 Thread Jakub Kicinski
On Wed, 28 Oct 2020 12:35:33 +0100 Lukas Bulwahn wrote: > make clang-analyzer on x86_64 defconfig caught my attention with: > > net/sched/cls_api.c:2964:3: warning: Value stored to 'parent' is never read > [clang-analyzer-deadcode.DeadStores] > parent = 0; > ^ >

Re: [PATCH] ipv6: mcast: make annotations for ip6_mc_msfget() consistent

2020-10-30 Thread Jakub Kicinski
On Wed, 28 Oct 2020 12:53:49 +0100 Lukas Bulwahn wrote: > Commit 931ca7ab7fe8 ("ip*_mc_gsfget(): lift copyout of struct group_filter > into callers") adjusted the type annotations for ip6_mc_msfget() at its > declaration, but missed the type annotations at its definition. > > Hence, sparse complai

Re: [PATCH net-next 2/4] sfc: implement encap TSO on EF100

2020-10-30 Thread Willem de Bruijn
On Fri, Oct 30, 2020 at 2:14 PM Edward Cree wrote: > > On 30/10/2020 17:33, Willem de Bruijn wrote: > > On Fri, Oct 30, 2020 at 12:43 PM Edward Cree wrote: > >> But possibly I don't need to have NETIF_F_GSO_UDP_TUNNEL[_CSUM] in > >> net_dev->gso_partial_features? > > If the device can handle fix

Re: pull-request: mac80211 2020-10-30

2020-10-30 Thread Jakub Kicinski
On Fri, 30 Oct 2020 10:43:48 +0100 Johannes Berg wrote: > Hi Jakub, > > Here's a first set of fixes, in particular the nl80211 eapol one > has people waiting for it. > > Please pull and let me know if there's any problem. Two patches seem to have your signature twice, do you want to respin? It's

  1   2   3   4   >