On Fri, Oct 30, 2020 at 2:28 PM Willem de Bruijn <willemdebruijn.ker...@gmail.com> wrote: > > Yes, it might require holding off the other patches until net is > merged into net-next. > > Packet sockets are likely not the only way these packets are received? > It changes mac_len as computed in __netif_receive_skb_core.
I looked at __netif_receive_skb_core. I didn't see it computing mac_len? I thought only AF_PACKET/RAW sockets would need this information because other upper layers would not care about what happened in L2. I see mac_len is computed in netif_receive_generic_xdp. I'm not clear about the reason why it calculates it. But it seems that it considers the L2 header as an Ethernet header, which is incorrect for this driver. > If there is no real bug that is fixed, net-next is fine.
