On 16.10.2020 18:55, Willem de Bruijn wrote:
On Fri, Oct 16, 2020 at 7:14 AM Alexander Ovechkin wrote:
ip6_tnl_encap assigns to proto transport protocol which
encapsulates inner packet, but we must pass to set_inner_ipproto
protocol of that inner packet.
Calling set_inner_ipproto after ip6_tnl
On Fri, 2020-10-16 at 21:15 +0200, Heiner Kallweit wrote:
>
> But we should spend at least a few thoughts on whether and how the
> irqoff version could be improved. This would have two benefits:
I disagree, using the irqoff version in a place that irqoff is not
always true is a bug.
*Maybe* it wo
Please trim your replies.
On Fri, 16 Oct 2020 17:52:28 -0700 Hemant Kumar wrote:
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +
> > +#define MIN_MTUETH_MIN_MTU
> > +#define MAX_MTU0x
> uci driver patch se
On 10/16/2020 1:02 PM, Christian Eggers wrote:
[snip]
On Friday, 16 October 2020, 20:03:11 CEST, Jakub Kicinski wrote:
FWIW if you want to avoid the reallocs you may want to set
needed_tailroom on the netdev.
I haven't looked for this yet. If this can really solve the tagging AND
padding p
On 10/16/2020 1:02 PM, Christian Eggers wrote:
Ensure that the skb is not cloned and has enough tail room for the tail
tag. This code will be removed from the drivers in the next commits.
Signed-off-by: Christian Eggers
---
[snip]
+ /* We have to pad he packet to the minimum Ethern
On 10/16/20 11:29 AM, Ido Schimmel wrote:
> From: Ido Schimmel
>
> While insertion of 16k nexthops all using the same netdev ('dummy10')
> takes less than a second, deletion takes about 130 seconds:
>
> # time -p ip -b nexthop.batch
> real 0.29
> user 0.01
> sys 0.15
>
> # time -p ip link set d
Jakub Kicinski wrote:
> On Sat, 17 Oct 2020 01:50:59 +0200 Ian Kumlien wrote:
> > On Sat, Oct 17, 2020 at 1:20 AM Jakub Kicinski wrote:
> > > Ian reports that after upgrade from v5.8.14 to v5.9 only one
> > > of his 4 ixgbe netdevs appear in the system.
> > >
> > > Quoting the comment on ixgbe_x5
Vladimir Oltean wrote:
> On Fri, Oct 16, 2020 at 02:36:25PM -0700, Jesse Brandeburg wrote:
> > > Signed-off-by: zhudi
> >
> > Kernel documentation says for you to use your real name, please do so,
> > unless you're a rock star and have officially changed your name to
> > zhudi.
I apologize for
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 15 Oct 2020 11:42:00 -0700 you wrote:
> From: Eric Dumazet
>
> Keyu Man reported that the ICMP rate limiter could be used
> by attackers to get useful signal. Details will be provided
> in an upcoming academic publicat
On Mon, 2020-10-05 at 14:52 -0400, Nitesh Narayan Lal wrote:
> On 10/4/20 7:14 PM, Frederic Weisbecker wrote:
> > On Sun, Oct 04, 2020 at 02:44:39PM +, Alex Belits wrote:
> > > On Thu, 2020-10-01 at 15:56 +0200, Frederic Weisbecker wrote:
> > > > External Email
> > > >
> > > > ---
> + if (priv->is_aspeed &&
> + phy_intf != PHY_INTERFACE_MODE_RMII &&
> + phy_intf != PHY_INTERFACE_MODE_RGMII &&
> + phy_intf != PHY_INTERFACE_MODE_RGMII_ID &&
> + phy_intf != PHY_INTERFACE_MODE_RGMII_RXID &&
> +
On Tue, 2020-10-06 at 12:35 +0200, Frederic Weisbecker wrote:
> On Mon, Oct 05, 2020 at 02:52:49PM -0400, Nitesh Narayan Lal wrote:
> > On 10/4/20 7:14 PM, Frederic Weisbecker wrote:
> > > On Sun, Oct 04, 2020 at 02:44:39PM +, Alex Belits wrote:
> > >
> > > > The idea behind this is that isol
Jakub Kicinski wrote:
> On Fri, 16 Oct 2020 14:23:48 -0700 Jesse Brandeburg wrote:
> > > These are tested to be the latest as part of the tools/lib/bpf build.
> >
> > But you didn't mention why you're making these changes, and you're
> > removing a lot of comments without explaining why/where t
On Fri, Oct 16, 2020 at 10:02:24PM +0200, Christian Eggers wrote:
> Ensure that the skb is not cloned and has enough tail room for the tail
> tag. This code will be removed from the drivers in the next commits.
>
> Signed-off-by: Christian Eggers
> ---
Does 1588 work for you using this change, o
On Tue, 2020-10-06 at 23:41 +0200, Frederic Weisbecker wrote:
> On Sun, Oct 04, 2020 at 03:22:09PM +, Alex Belits wrote:
> > On Thu, 2020-10-01 at 16:44 +0200, Frederic Weisbecker wrote:
> > > > @@ -268,7 +269,8 @@ static void tick_nohz_full_kick(void)
> > > > */
> > > > void tick_nohz_full
Hi Jakub,
On Fri, Oct 16, 2020 at 11:18 PM Jakub Kicinski wrote:
>
> On Fri, 16 Oct 2020 08:59:43 +0530 sundeep subbaraya wrote:
> > On Thu, Oct 15, 2020 at 9:02 PM Jakub Kicinski wrote:
> > > On Thu, 15 Oct 2020 17:53:07 +0530 sundeep subbaraya wrote:
> > > > Hi Jakub,
> > > >
> > > > On Thu, O
1. Change the fr_rx function to make this driver support any Ethertype
when receiving. (This driver is already able to handle any Ethertype
when sending.)
Originally in the fr_rx function, the code that parses the long (10-byte)
header only recognizes a few Ethertype values and drops frames with o
On Sat, 17 Oct 2020 01:50:59 +0200 Ian Kumlien wrote:
> On Sat, Oct 17, 2020 at 1:20 AM Jakub Kicinski wrote:
> > Ian reports that after upgrade from v5.8.14 to v5.9 only one
> > of his 4 ixgbe netdevs appear in the system.
> >
> > Quoting the comment on ixgbe_x550em_a_has_mii():
> > * Returns tr
On Thu, 15 Oct 2020 23:00:23 +0300 Ioana Ciornei wrote:
> The below compile time error can be seen when PHYLIB is configured as a
> module.
>
> ld: drivers/net/pcs/pcs-xpcs.o: in function `xpcs_read':
> pcs-xpcs.c:(.text+0x29): undefined reference to `mdiobus_read'
> ld: drivers/net/pcs/pcs-xpc
On Sat, Oct 17, 2020 at 1:20 AM Jakub Kicinski wrote:
>
> Ian reports that after upgrade from v5.8.14 to v5.9 only one
> of his 4 ixgbe netdevs appear in the system.
>
> Quoting the comment on ixgbe_x550em_a_has_mii():
> * Returns true if hw points to lowest numbered PCI B:D.F x550_em_a device in
On Thu, 15 Oct 2020 11:42:00 -0700 Eric Dumazet wrote:
> From: Eric Dumazet
>
> Keyu Man reported that the ICMP rate limiter could be used
> by attackers to get useful signal. Details will be provided
> in an upcoming academic publication.
>
> Our solution is to add some noise, so that the attac
On Thu, 15 Oct 2020 19:09:33 +0200 Eelco Chaudron wrote:
> The flow_lookup() function uses per CPU variables, which must be called
> with BH disabled. However, this is fine in the general NAPI use case
> where the local BH is disabled. But, it's also called from the netlink
> context. The below pat
On Fri, 16 Oct 2020 12:12:11 +0800 Po-Hsu Lin wrote:
> The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh
> needs the fou module to work. Otherwise it will fail with:
>
> $ ip netns exec "$testns" ip fou add port ipproto 47
> RTNETLINK answers: No such file or directory
>
Ian reports that after upgrade from v5.8.14 to v5.9 only one
of his 4 ixgbe netdevs appear in the system.
Quoting the comment on ixgbe_x550em_a_has_mii():
* Returns true if hw points to lowest numbered PCI B:D.F x550_em_a device in
* the SoC. There are up to 4 MACs sharing a single MDIO bus on
On Thu, Oct 15, 2020 at 08:06:06PM +0900, Benjamin Poirier wrote:
On 2020-10-15 11:37 +0800, Coiby Xu wrote:
On Tue, Oct 13, 2020 at 09:37:04AM +0900, Benjamin Poirier wrote:
> On 2020-10-12 19:24 +0800, Coiby Xu wrote:
> [...]
> > > I think, but didn't check in depth, that in those drivers, the
On Thu, Oct 15, 2020 at 10:01:36AM +0900, Benjamin Poirier wrote:
On 2020-10-14 18:43 +0800, Coiby Xu wrote:
To avoid namespace clashes with other qlogic drivers and also for the
sake of naming consistency, use the "qlge_" prefix as suggested in
drivers/staging/qlge/TODO.
Suggested-by: Benjamin
On Sat, 17 Oct 2020 00:39:11 +0200 Ian Kumlien wrote:
> On Fri, Oct 16, 2020 at 9:21 PM Jakub Kicinski wrote:
> > > > You can actually see it dmesg... And i tried some basic looking at
> > > > changes to see if it was obvious but..
> >
> > Showing a full dmesg may be helpful, but looking at
On Sat, 17 Oct 2020 00:33:02 +0300 Vladimir Oltean wrote:
> On Sat, Oct 17, 2020 at 12:16:28AM +0300, Vladimir Oltean wrote:
> > On Fri, Oct 16, 2020 at 11:03:18PM +0200, Andrew Lunn wrote:
> > > 2ecbc1f684482b4ed52447a39903bd9b0f222898 does not have net-next, as
> > > far as i see,
> >
> > No
On Fri, Oct 16, 2020 at 02:36:25PM -0700, Jesse Brandeburg wrote:
> > Signed-off-by: zhudi
>
> Kernel documentation says for you to use your real name, please do so,
> unless you're a rock star and have officially changed your name to
> zhudi.
Well, his real name is probably 朱棣, and the pinyin t
On Fri, Oct 16, 2020 at 9:21 PM Jakub Kicinski wrote:
>
> On Fri, 16 Oct 2020 11:35:15 +0200 Ian Kumlien wrote:
> > Adding netdev, someone might have a clue of what to look at...
> >
> > On Mon, Oct 12, 2020 at 9:20 PM Ian Kumlien wrote:
> > >
> > > Hi,
> > >
> > > I was really surprised when i r
On Wed, 14 Oct 2020 14:06:32 +0800 Dylan Hung wrote:
> The new HW arbitration feature on Aspeed ast2600 will cause MAC TX to
> hang when handling scatter-gather DMA. Disable the problematic feature
> by setting MAC register 0x58 bit28 and bit27.
>
> Signed-off-by: Dylan Hung
Applied, thank you.
On Tue, 13 Oct 2020 19:18:48 +0200 Kleber Sacilotto de Souza wrote:
> From: Thadeu Lima de Souza Cascardo
>
> When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason
> del_timer_sync can't be used is because this relies on keeping a reference
> to struct sock. But as we keep a p
> Example:
> - swp1 is a 200G port with 4 lanes.
> - QSFP28 is plugged in.
> - The user wants to select configuration of 100G speed using 2 lanes, 50G
> each.
>
> $ ethtool swp1
> Settings for swp1:
> Supported ports: [ FIBRE Backplane ]
> Supported link modes: 1000baseT
On Thu, Oct 08, 2020 at 11:23:47AM -0500, Dan Murphy wrote:
> The DP83TD510E is an ultra-low power Ethernet physical layer transceiver
> that supports 10M single pair cable.
Hi Dan
I think you are going to have to add
ETHTOOL_LINK_MODE_10baseT1_Full_BIT? We already have 100T1 and 1000T1,
but not
Hi Jeff,
Jeff Dike wrote:
Your subject should indicate net or net-next as the tree, please see:
https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
> Commit 58956317c8de guarantees arp table entries a five-second lifetime. We
> have some apps which make heavy use of multicast,
Hello Thomas,
That's surprising regression, I'll try to reproduce it next week.
- Mathy
On 10/15/20 5:44 AM, Thomas Deutschmann wrote:
> Hi,
>
> after upgrading to linux-5.9.0 I noticed that my wifi got disassociated
> every 10 minutes when access point triggered rekeying for GTK.
>
> This hap
Ido Schimmel wrote:
> From: Ido Schimmel
>
> While insertion of 16k nexthops all using the same netdev ('dummy10')
> takes less than a second, deletion takes about 130 seconds:
>
> # time -p ip -b nexthop.batch
> real 0.29
> user 0.01
> sys 0.15
>
> # time -p ip link set dev dummy10 down
> rea
zhudi wrote:
> "ip addr show" command execute error when we have a physical
> network card with number of VFs larger than 247.
Oh man, this bug has been hurting us forever and I've tried to fix it
several times without much luck, so thanks for working on it!
CC: David Ahern
As he's mentioned t
On Sat, Oct 17, 2020 at 12:16:28AM +0300, Vladimir Oltean wrote:
> On Fri, Oct 16, 2020 at 11:03:18PM +0200, Andrew Lunn wrote:
> > 2ecbc1f684482b4ed52447a39903bd9b0f222898 does not have net-next, as
> > far as i see,
>
> Not sure what you mean by that.
Ah, I do understand what you mean now. In g
On Fri, 16 Oct 2020 14:23:48 -0700 Jesse Brandeburg wrote:
> > These are tested to be the latest as part of the tools/lib/bpf build.
>
> But you didn't mention why you're making these changes, and you're
> removing a lot of comments without explaining why/where there might be
> a replacement or
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Fri, 16 Oct 2020 09:31:18 +0700 you wrote:
> The queue limit of the broadcast link is being calculated base on initial
> MTU. However, when MTU value changed (e.g manual changing MTU on NIC
> device, MTU negotiation etc.,) w
Grygorii Strashko wrote:
> Hi
>
> This series adds multi-port support in mac-only mode (multi MAC mode) to TI
> AM65x CPSW driver in preparation for enabling support for multi-port devices,
> like Main CPSW0 on K3 J721E SoC or future CPSW3g on K3 AM64x SoC.
For the series
Reviewed-by: Jesse Bran
Hi Ian,
Ian Rogers wrote:
> These are tested to be the latest as part of the tools/lib/bpf build.
But you didn't mention why you're making these changes, and you're
removing a lot of comments without explaining why/where there might be
a replacement or why the comments are useless. I now see tha
On Fri, 16 Oct 2020 09:31:18 +0700 Hoang Huu Le wrote:
> The queue limit of the broadcast link is being calculated base on initial
> MTU. However, when MTU value changed (e.g manual changing MTU on NIC
> device, MTU negotiation etc.,) we do not re-calculate queue limit.
> This gives throughput does
On Fri, Oct 16, 2020 at 11:03:18PM +0200, Andrew Lunn wrote:
> 2ecbc1f684482b4ed52447a39903bd9b0f222898 does not have net-next, as
> far as i see,
Not sure what you mean by that.
> and tail_tag only hit net when net-next was merged into
> net.
net-next is only merged into net via Linus Torvalds,
I have a FPGA sending frames (payload length=1280) over RGMII to a
Samsung module which includes STMMAC MAC IP (v3.5).
If the FCS is correct, I manage to receive data from the FPGA to the MAC
in the kernel.
For multiple reasons, I wish to disable FCS so that frames are received
in the kernel
On Fri, Oct 16, 2020 at 11:19:30PM +0300, Vladimir Oltean wrote:
> On Fri, Oct 16, 2020 at 10:14:28PM +0200, Andrew Lunn wrote:
> > On Fri, Oct 16, 2020 at 08:33:17PM +0300, Vladimir Oltean wrote:
> > > On Sat, Oct 17, 2020 at 01:25:08AM +0800, kernel test robot wrote:
> > > > Hi Christian,
> > > >
On Fri, Oct 16, 2020 at 09:37:22PM +0200, Lukasz Stelmach wrote:
> It was <2020-10-16 pią 20:09>, when Andrew Lunn wrote:
> > On Thu, Oct 15, 2020 at 10:44:35AM +0200, Łukasz Stelmach wrote:
> >> Do not report advertised link modes (local and remote) when
> >> autonegotiation is turned off. mii_eth
On Fri, Oct 16, 2020 at 05:38:26PM +0200, Vlastimil Babka wrote:
> On 10/13/20 10:09 AM, Mike Rapoport wrote:
> > > We are not complaining about TCP using too much memory, but how do
> > > we know that TCP uses a lot of memory. When I firstly face this problem,
> > > I do not know who uses the 25GB
The caller (dsa_slave_xmit) guarantees that the frame length is at least
ETH_ZLEN and that enough memory for tail tagging is available.
Signed-off-by: Christian Eggers
---
net/dsa/tag_trailer.c | 31 ++-
1 file changed, 2 insertions(+), 29 deletions(-)
diff --git a/n
syzbot has bisected this issue to:
commit 4d004099a668c41522242aa146a38cc4eb59cb1e
Author: Peter Zijlstra
Date: Fri Oct 2 09:04:21 2020 +
lockdep: Fix lockdep recursion
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=174a766f90
start commit: 9ff9b0d3 Merge tag 'net-
On Fri, Oct 16, 2020 at 10:14:28PM +0200, Andrew Lunn wrote:
> On Fri, Oct 16, 2020 at 08:33:17PM +0300, Vladimir Oltean wrote:
> > On Sat, Oct 17, 2020 at 01:25:08AM +0800, kernel test robot wrote:
> > > Hi Christian,
> > >
> > > Thank you for the patch! Yet something to improve:
> > >
> > > [auto
On Fri, Oct 16, 2020 at 12:41:55PM +0300, Maxim Kochetkov wrote:
> The VSC9953 Seville switch has 2 megabits of buffer split into 4360
> words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabits.
> 2 megabits is (2048 / 8) * 1024 = 256 * 1024.
>
> Signed-off-by: Maxim Kochetkov
> R
On Fri, Oct 16, 2020 at 08:33:17PM +0300, Vladimir Oltean wrote:
> On Sat, Oct 17, 2020 at 01:25:08AM +0800, kernel test robot wrote:
> > Hi Christian,
> >
> > Thank you for the patch! Yet something to improve:
> >
> > [auto build test ERROR on net/master]
> >
> > url:
> > https://github.com/0d
The caller (dsa_slave_xmit) guarantees that the frame length is at least
ETH_ZLEN and that enough memory for tail tagging is available.
Signed-off-by: Christian Eggers
---
net/dsa/tag_ksz.c | 73 ++-
1 file changed, 9 insertions(+), 64 deletions(-)
di
Ensure that the skb is not cloned and has enough tail room for the tail
tag. This code will be removed from the drivers in the next commits.
Signed-off-by: Christian Eggers
---
net/dsa/dsa_priv.h | 3 +++
net/dsa/slave.c| 38 ++
2 files changed, 41 insert
This series moves the reallocation of a skb which may be required due to
tail tagging or padding, from the tag_trailer and tag_ksz drivers to
dsa_slave_xmit. Additionally it prevents a skb_panic in a very special
corner case described here:
https://patchwork.ozlabs.org/project/netdev/patch/20201014
It was <2020-10-16 pią 20:09>, when Andrew Lunn wrote:
> On Thu, Oct 15, 2020 at 10:44:35AM +0200, Łukasz Stelmach wrote:
>> Do not report advertised link modes (local and remote) when
>> autonegotiation is turned off. mii_ethtool_get_link_ksettings() exhibits
>> the same behaviour and this patch a
On 2/14/20 1:09 PM, Oleksij Rempel wrote:
> Hi all,
>
> any comments on this patch?
I'm going to take this patch now for 5.10Comments?
Marc
>
> On Fri, Jan 24, 2020 at 02:26:56PM +0100, Oleksij Rempel wrote:
>> All user space generated SKBs are owned by a socket (unless injected
>> into th
On Fri, 16 Oct 2020 11:35:15 +0200 Ian Kumlien wrote:
> Adding netdev, someone might have a clue of what to look at...
>
> On Mon, Oct 12, 2020 at 9:20 PM Ian Kumlien wrote:
> >
> > Hi,
> >
> > I was really surprised when i rebooted my firewall and there was
> > network issues, I was even more su
It was <2020-10-16 pią 20:01>, when Andrew Lunn wrote:
>> >> +static void
>> >> +ax88796c_get_regs(struct net_device *ndev, struct ethtool_regs *regs,
>> >> void *_p)
>> >> +{
>> >> + struct ax88796c_device *ax_local = to_ax88796c_device(ndev);
>> >> + u16 *p = _p;
>> >> + int offset, i;
>> >> +
>
On 16.10.2020 19:11, Mike Galbraith wrote:
> On Fri, 2020-10-16 at 17:26 +0300, Vladimir Oltean wrote:
>> On Fri, Oct 16, 2020 at 01:34:55PM +0200, Heiner Kallweit wrote:
>>> I'm aware of the topic, but missing the benefits of the irqoff version
>>> unconditionally doesn't seem to be the best optio
On Fri, 16 Oct 2020 10:43:53 +0800 Voon Weifeng wrote:
> From: "Vineetha G. Jaya Kumaran"
>
> This patch enables the HW LPI Timer which controls the automatic entry
> and exit of the LPI state.
> The EEE LPI timer value is configured through ethtool. The driver will
> auto select the LPI HW timer
On Fri, 16 Oct 2020 21:13:19 +0300 Vladimir Oltean wrote:
> On Fri, Oct 16, 2020 at 11:03:11AM -0700, Jakub Kicinski wrote:
> > On Fri, 16 Oct 2020 18:56:45 +0300 Vladimir Oltean wrote:
> > > > 3. "Manually" unsharing in dsa_slave_xmit(), reserving enough tailroom
> > > > for the tail tag (and ET
On Fri, Oct 16, 2020 at 11:03:11AM -0700, Jakub Kicinski wrote:
> On Fri, 16 Oct 2020 18:56:45 +0300 Vladimir Oltean wrote:
> > > 3. "Manually" unsharing in dsa_slave_xmit(), reserving enough tailroom
> > > for the tail tag (and ETH_ZLEN?). Would moving the "else" clause from
> > > ksz_common_xmit(
On Thu, Oct 15, 2020 at 10:44:35AM +0200, Łukasz Stelmach wrote:
> Do not report advertised link modes (local and remote) when
> autonegotiation is turned off. mii_ethtool_get_link_ksettings() exhibits
> the same behaviour and this patch aims at unifying the behavior of both
> functions.
Does etht
On Fri, 16 Oct 2020 11:20:07 +0200 Loic Poulain wrote:
> This patch adds a new network driver implementing MHI transport for
> network packets. Packets can be in any format, though QMAP (rmnet)
> is the usual protocol (flow control + PDN mux).
>
> It support two MHI devices, IP_HW0 which is, the p
On Fri, 16 Oct 2020 18:56:45 +0300 Vladimir Oltean wrote:
> > 3. "Manually" unsharing in dsa_slave_xmit(), reserving enough tailroom
> > for the tail tag (and ETH_ZLEN?). Would moving the "else" clause from
> > ksz_common_xmit() to dsa_slave_xmit() do the job correctly?
>
> I was thinking about
> >> +static void
> >> +ax88796c_get_regs(struct net_device *ndev, struct ethtool_regs *regs,
> >> void *_p)
> >> +{
> >> + struct ax88796c_device *ax_local = to_ax88796c_device(ndev);
> >> + u16 *p = _p;
> >> + int offset, i;
> >> +
> >> + memset(p, 0, AX88796C_REGDUMP_LEN);
> >> +
> >> + fo
On Fri, Oct 16, 2020 at 7:14 AM Alexander Ovechkin wrote:
>
> ip6_tnl_encap assigns to proto transport protocol which
> encapsulates inner packet, but we must pass to set_inner_ipproto
> protocol of that inner packet.
>
> Calling set_inner_ipproto after ip6_tnl_encap might break gso.
> For example
On Fri, 16 Oct 2020 08:59:43 +0530 sundeep subbaraya wrote:
> On Thu, Oct 15, 2020 at 9:02 PM Jakub Kicinski wrote:
> > On Thu, 15 Oct 2020 17:53:07 +0530 sundeep subbaraya wrote:
> > > Hi Jakub,
> > >
> > > On Thu, Oct 15, 2020 at 8:18 AM Jakub Kicinski wrote:
> > > >
> > > > On Tue, 13 Oct
On Sat, Oct 17, 2020 at 01:25:08AM +0800, kernel test robot wrote:
> Hi Christian,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on net/master]
>
> url:
> https://github.com/0day-ci/linux/commits/Christian-Eggers/net-dsa-point-out-the-tail-taggers/20201017-00
From: Ido Schimmel
While insertion of 16k nexthops all using the same netdev ('dummy10')
takes less than a second, deletion takes about 130 seconds:
# time -p ip -b nexthop.batch
real 0.29
user 0.01
sys 0.15
# time -p ip link set dev dummy10 down
real 131.03
user 0.06
sys 0.52
This is because
On Wed, 14 Oct 2020 11:15:43 +0530, Amitesh Chandra wrote:
> From: Amitesh Chandra
>
> Add bindings for BCM4389 bluetooth controller.
>
> Signed-off-by: Amitesh Chandra
> ---
> Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Ro
Hi Christian,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master]
url:
https://github.com/0day-ci/linux/commits/Christian-Eggers/net-dsa-point-out-the-tail-taggers/20201017-003007
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
2ecb
On Fri, Oct 16, 2020 at 07:16:03PM +0200, Christian Eggers wrote:
> I added it manually because the commit ID is not from Linus' tree. Is there
> any
> value using Fixes tags with id's from other trees?
Yes, that's what "git merge" does, it keeps sha1sums.
You should check out "git log --oneline
The length of Remote Transmission Request (RTR) frames is always 0
bytes. The DLC represents the requested length, not the actual length
of the RTR. But __can_get_echo_skb() returns the DLC value regardless.
Apply get_can_len() function to retrieve the correct length.
Signed-off-by: Vincent Mailh
In classical CAN, the length of the data (i.e. CAN payload) is not
always equal to the DLC! If the frame is a Remote Transmission Request
(RTR), data length is always zero regardless of DLC value and else, if
the DLC is greater than 8, the length is 8. Contrary to common belief,
ISO 11898-1 Chapter
On Fri, Oct 16, 2020 at 07:11:22PM +0200, Mike Galbraith wrote:
> Yeah, it's a straight up correctness issue as it sits.
Yeah, tell me about it, you don't even want to know what it looks like
when the local_softirq_pending_ref percpu mask gets corrupted. The
symptom will be that random syscalls, l
The Marvell 88E6060 uses tag_trailer.c and the KSZ8795, KSZ9477 and
KSZ9893 switches also use tail tags.
Fixes: 7a6ffe764be3 ("net: dsa: point out the tail taggers")
Signed-off-by: Christian Eggers
Reviewed-by: Florian Fainelli
---
On Friday, 16 October 2020, 18:56:51 CEST, Vladimir Oltean wrote
If a driver calls can_get_echo_skb() during a hardware IRQ (which is
often, but not always, the case), the 'WARN_ON(in_irq)' in
net/core/skbuff.c#skb_release_head_state() might be triggered, under
network congestion circumstances, together with the potential risk of
a NULL pointer dereference.
The
syzbot has found a reproducer for the following issue on:
HEAD commit:9ff9b0d3 Merge tag 'net-next-5.10' of git://git.kernel.org..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1663860790
kernel config: https://syzkaller.appspot.com/x/.config?x=d13c3fa
The purpose of this patch series is to introduce a new CAN USB
driver to support ETAS USB interfaces (ES58X series).
During development, issues in drivers/net/can/dev.c were discovered,
the fix for those issues are included in this patch series.
We also propose to add one helper functions in incl
On Fri, 2020-10-16 at 17:26 +0300, Vladimir Oltean wrote:
> On Fri, Oct 16, 2020 at 01:34:55PM +0200, Heiner Kallweit wrote:
> > I'm aware of the topic, but missing the benefits of the irqoff version
> > unconditionally doesn't seem to be the best option.
>
> What are the benefits of the irqoff ver
Neal Cardwell writes:
> On Thu, Oct 15, 2020 at 6:12 PM Apollon Oikonomopoulos
> wrote:
>> Neal, would it be possible to re-send the patch as an attachment? The
>> inlined version does not apply cleanly due to linewrapping and
>> whitespace changes and, although I can re-type it, I would prefer
Hi Christian,
On Fri, Oct 16, 2020 at 06:28:00PM +0200, Christian Eggers wrote:
> From a recent commit with the same summary:
>
> "The Marvell 88E6060 uses tag_trailer.c and the KSZ8795, KSZ9477 and
> KSZ9893 switches also use tail tags."
>
> Set "tail_tag" to true for KSZ8795 and KSZ9477 which
On 10/16/20 8:43 AM, Vladimir Oltean wrote:
> On Fri, Oct 16, 2020 at 02:11:06PM +0200, Kurt Kanzenbach wrote:
>> When VLAN awareness is disabled, the packet is still classified with the
>> pvid. But, later all rules regarding VLANs (except for the PCP field)
>> are ignored then. So, the programmed
On Fri, Oct 16, 2020 at 01:43:06PM +, Nikolay Aleksandrov wrote:
> It can potentially use after free, multicast resources (per-cpu stats) are
> freed
> in br_multicast_del_port() and can be used due to a race with port state
> sync on other CPUs since the handler can still process packets. Tha
On 10/16/20 9:28 AM, Christian Eggers wrote:
> From a recent commit with the same summary:
>
> "The Marvell 88E6060 uses tag_trailer.c and the KSZ8795, KSZ9477 and
> KSZ9893 switches also use tail tags."
>
> Set "tail_tag" to true for KSZ8795 and KSZ9477 which were missing in the
> original comm
On Fri 16 Oct 2020 at 19:07, Jamal Hadi Salim wrote:
> On 2020-10-16 10:42 a.m., Vlad Buslov wrote:
>> From: Vlad Buslov
>>
>> Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS
>> tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when
>> user reques
>From a recent commit with the same summary:
"The Marvell 88E6060 uses tag_trailer.c and the KSZ8795, KSZ9477 and
KSZ9893 switches also use tail tags."
Set "tail_tag" to true for KSZ8795 and KSZ9477 which were missing in the
original commit.
Fixes: 7a6ffe764be3 [net] ("net: dsa: point out the t
On Fri, Oct 16, 2020 at 6:46 AM Loktionov, Aleksandr
wrote:
>
> Good day Willem
>
> The issue patch fixes has been introduced from the very beginning.
> So as fixes tag I can suggest the very first commit
> 5c3c48ac6bf56367c4e89f6453cd2d61e50375bd "i40e: implement virtual device
> interface"
F
Hi Herbert, Dave, Trond,
I've written basic gssapi-derived security support for AF_RXRPC:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rxgk
I've borrowed some bits from net/sunrpc/auth_gss/ but there's a lot in there
that is quite specific to the su
On Fri, Oct 16, 2020 at 09:33:14AM +0200, Oleksij Rempel wrote:
> For now we have only node name as common rule for all CAN controllers
>
> Signed-off-by: Oleksij Rempel
> ---
> .../bindings/net/can/can-controller.yaml | 16
> 1 file changed, 16 insertions(+)
> create m
On Fri, 16 Oct 2020 09:33:14 +0200, Oleksij Rempel wrote:
> For now we have only node name as common rule for all CAN controllers
>
> Signed-off-by: Oleksij Rempel
> ---
> .../bindings/net/can/can-controller.yaml | 16
> 1 file changed, 16 insertions(+)
> create mode 10
On 2020-10-16 10:42 a.m., Vlad Buslov wrote:
From: Vlad Buslov
Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS
tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when
user requested it with following example CLI (-br for 'brief'):
$ tc -s -brief f
On Fri, Oct 16, 2020 at 02:44:46PM +0200, Christian Eggers wrote:
> Machine:
> - ARMv7 (i.MX6ULL), SMP_CACHE_BYTES is 64
> - DSA device: Microchip KSZ9563 (I am currently working on time stamping
> support)
I have a board very similar to this on which I am going to test.
> Last, CONFIG_SLOB must
Commit 58956317c8de guarantees arp table entries a five-second lifetime. We
have some apps which make heavy use of multicast, and these can cause the table
to overflow by filling it with multicast addresses which can't be GC-ed until
their five seconds are up.
This patch allows multicast addres
On Fri, Oct 16, 2020 at 02:11:06PM +0200, Kurt Kanzenbach wrote:
> When VLAN awareness is disabled, the packet is still classified with the
> pvid. But, later all rules regarding VLANs (except for the PCP field)
> are ignored then. So, the programmed pvid doesn't matter in this case.
Ok, clear now
On Fri, Oct 16, 2020 at 04:41:50PM +0200, Heiner Kallweit wrote:
> On 16.10.2020 16:26, Vladimir Oltean wrote:
> > On Fri, Oct 16, 2020 at 01:34:55PM +0200, Heiner Kallweit wrote:
> >> I'm aware of the topic, but missing the benefits of the irqoff version
> >> unconditionally doesn't seem to be the
1 - 100 of 171 matches
Mail list logo
