On Fri 16 Oct 2020 at 19:07, Jamal Hadi Salim <j...@mojatatu.com> wrote: > On 2020-10-16 10:42 a.m., Vlad Buslov wrote: >> From: Vlad Buslov <vla...@mellanox.com> >> >> Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS >> tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when >> user requested it with following example CLI (-br for 'brief'): >> >> $ tc -s -brief filter show dev ens1f0 ingress >> filter protocol all pref 49151 flower chain 0 >> filter protocol all pref 49151 flower chain 0 handle 0x1 >> not_in_hw >> action order 1: Action statistics: >> Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0) >> backlog 0b 0p requeues 0 >> >> filter protocol all pref 49152 flower chain 0 >> filter protocol all pref 49152 flower chain 0 handle 0x1 >> not_in_hw >> action order 1: Action statistics: >> Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0) >> backlog 0b 0p requeues 0 >> > > Should the action name at least show up? > > > cheers, > jamal
All action print callbacks have arg==NULL check and return at the beginning. To print action type we need either to have dedicated 'brief_dump' callback instead of reusing print_aop() or extend/refactor print_aop() implementation for all actions to always print the type before checking the arg. What do you suggest?
