KASAN: use-after-free Write in xp_put_pool

2020-09-01 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:dc1a9bf2 octeontx2-pf: Add UDP segmentation offload support git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=16ff67de90 kernel config: https://syzkaller.appspot.com/x/.config?x=b6856d16f78d8fa9 dash

Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-01 Thread Yunsheng Lin
On 2020/9/2 12:41, Cong Wang wrote: > On Tue, Sep 1, 2020 at 6:42 PM Yunsheng Lin wrote: >> >> On 2020/9/2 2:24, Cong Wang wrote: >>> On Mon, Aug 31, 2020 at 5:59 PM Yunsheng Lin wrote: Currently there is concurrent reset and enqueue operation for the same lockless qdisc when there

RE: [net-next v2 1/4] tipc: optimize key switching time and logic

2020-09-01 Thread Tuong Tong Lien
> -Original Message- > From: David Miller > Sent: Wednesday, September 2, 2020 5:10 AM > To: Tuong Tong Lien > Cc: jma...@redhat.com; ma...@donjonn.com; ying@windriver.com; > netdev@vger.kernel.org; tipc- > discuss...@lists.sourceforge.net > Subject: Re: [net-next v2 1/4] tipc: op

RE: [PATCH v2 bpf-next 03/14] libbpf: support CO-RE relocations for multi-prog sections

2020-09-01 Thread John Fastabend
Andrii Nakryiko wrote: > Fix up CO-RE relocation code to handle relocations against ELF sections > containing multiple BPF programs. This requires lookup of a BPF program by its > section name and instruction index it contains. While it could have been done > as a simple loop, it could run into per

RE: [PATCH v2 bpf-next 02/14] libbpf: parse multi-function sections into multiple BPF programs

2020-09-01 Thread John Fastabend
Andrii Nakryiko wrote: > Teach libbpf how to parse code sections into potentially multiple bpf_program > instances, based on ELF FUNC symbols. Each BPF program will keep track of its > position within containing ELF section for translating section instruction > offsets into program instruction offs

Re: [PATCH v4 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-09-01 Thread Kurt Kanzenbach
On Tue Sep 01 2020, David Miller wrote: > From: Richard Cochran > Date: Tue, 1 Sep 2020 09:36:10 -0700 > >> On Tue, Sep 01, 2020 at 05:59:45PM +0200, Andrew Lunn wrote: >>> Maybe, at the moment, RTNL is keeping things atomic. But that is >>> because there is no HWMON, or MDIO bus. Those sort of op

Re: [PATCH v2 bpf-next 14/14] selftests/bpf: convert cls_redirect selftest to use __noinline

2020-09-01 Thread Alexei Starovoitov
On Mon, Aug 31, 2020 at 06:50:03PM -0700, Andrii Nakryiko wrote: > -static bool ipv4_is_fragment(const struct iphdr *ip) > +static __noinline bool ipv4_is_fragment(const struct iphdr *ip) > { > uint16_t frag_off = ip->frag_off & bpf_htons(IP_OFFSET_MASK); > return (ip->frag_off & bpf_h

Re: [PATCH v2 bpf-next 12/14] selftests/bpf: convert pyperf, strobemeta, and l4lb_noinline to __noinline

2020-09-01 Thread Alexei Starovoitov
On Mon, Aug 31, 2020 at 06:50:01PM -0700, Andrii Nakryiko wrote: > diff --git a/tools/testing/selftests/bpf/progs/pyperf.h > b/tools/testing/selftests/bpf/progs/pyperf.h > index cc615b82b56e..13998aee887f 100644 > --- a/tools/testing/selftests/bpf/progs/pyperf.h > +++ b/tools/testing/selftests/bpf

[PATCH 1/1 v6] igb: add XDP support

2020-09-01 Thread Sven Auhagen
Add XDP support to the IGB driver. The implementation follows the IXGBE XDP implementation closely and I used the following patches as basis: 1. commit 924708081629 ("ixgbe: add XDP support for pass and drop actions") 2. commit 33fdc82f0883 ("ixgbe: add support for XDP_TX action") 3. commit ed93a3

RE: [PATCH v2 bpf-next 01/14] libbpf: ensure ELF symbols table is found before further ELF processing

2020-09-01 Thread John Fastabend
Andrii Nakryiko wrote: > libbpf ELF parsing logic might need symbols available before ELF parsing is > completed, so we need to make sure that symbols table section is found in > a separate pass before all the subsequent sections are processed. > > Signed-off-by: Andrii Nakryiko > --- LGTM Acke

Re: [PATCH v2 bpf-next 07/14] selftests/bpf: add selftest for multi-prog sections and bpf-to-bpf calls

2020-09-01 Thread Alexei Starovoitov
On Mon, Aug 31, 2020 at 06:49:56PM -0700, Andrii Nakryiko wrote: > + > +__noinline int sub1(int x) > +{ > + return x + 1; > +} > + > +static __noinline int sub5(int v); > + > +__noinline int sub2(int y) > +{ > + return sub5(y + 2); > +} > + > +static __noinline int sub3(int z) > +{ > +

Re: [PATCH v2 bpf-next 04/14] libbpf: make RELO_CALL work for multi-prog sections and sub-program calls

2020-09-01 Thread Alexei Starovoitov
On Mon, Aug 31, 2020 at 06:49:53PM -0700, Andrii Nakryiko wrote: > + > +static int > +bpf_object__reloc_code(struct bpf_object *obj, struct bpf_program *main_prog, > +struct bpf_program *prog) > +{ > + size_t sub_insn_idx, insn_idx, new_cnt; > + struct bpf_program *subpr

Re: [PATCH 4/5] net: phy: smsc: add phy refclk in support

2020-09-01 Thread Florian Fainelli
On 9/1/2020 1:24 AM, Marco Felsch wrote: Create :) Can you provide me a link? What I can say for now is: This solution was used by the micrel driver too and it seems to work. I wanted to keep the change smaller/more local because the current upstream state is: SMSC-Phy <-> FEC-Host ==> IRQ bro

RE: [PATCH net-next 2/3] devlink: Consider other controller while building phys_port_name

2020-09-01 Thread Parav Pandit
> From: netdev-ow...@vger.kernel.org On > Behalf Of Parav Pandit > > > From: Jakub Kicinski > > Sent: Wednesday, September 2, 2020 2:59 AM > > > > On Tue, 1 Sep 2020 11:17:42 +0200 Jiri Pirko wrote: > > > >> The external PFs need to have an extra attribute with "external > > > >> enumeration"

Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-01 Thread Cong Wang
On Tue, Sep 1, 2020 at 6:42 PM Yunsheng Lin wrote: > > On 2020/9/2 2:24, Cong Wang wrote: > > On Mon, Aug 31, 2020 at 5:59 PM Yunsheng Lin wrote: > >> > >> Currently there is concurrent reset and enqueue operation for the > >> same lockless qdisc when there is no lock to synchronize the > >> q->e

RE: [PATCH net-next 2/3] devlink: Consider other controller while building phys_port_name

2020-09-01 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Wednesday, September 2, 2020 2:59 AM > > On Tue, 1 Sep 2020 11:17:42 +0200 Jiri Pirko wrote: > > >> The external PFs need to have an extra attribute with "external > > >> enumeration" what would be used for the representor netdev name as well. > > >> > > >> pci/0

[PATCH net-next 2/2] ipmr: Use full VIF ID in netlink cache reports

2020-09-01 Thread Paul Davey
Insert the full 16 bit VIF ID into ipmr Netlink cache reports. If using more than 255 multicast interfaces it is necessary to have access to a VIF ID for cache reports that is wider than 8 bits, the VIF ID present in the igmpmsg reports sent to mroute_sk are only 8 bits wide in the igmpmsg header.

[PATCH net-next 1/2] ipmr: Add route table ID to netlink cache reports

2020-09-01 Thread Paul Davey
Insert the multicast route table ID as a Netlink attribute to Netlink cache report notifications. When multiple route tables are in use it is necessary to have a way to determine which route table a given cache report belongs to when receiving the cache report. Signed-off-by: Paul Davey --- inc

[PATCH net-next 0/2] Allow more than 255 IPv4 multicast interfaces

2020-09-01 Thread Paul Davey
Currently it is not possible to use more than 255 multicast interfaces for IPv4 due to the format of the igmpmsg header which only has 8 bits available for the VIF ID. There is enough space for the full VIF ID in the Netlink cache notifications, however the value is currently taken directly from t

[RFC v2 04/11] Drivers: hv: Use HV_HYP_PAGE in hv_synic_enable_regs()

2020-09-01 Thread Boqun Feng
Both the base_*_gpa should use the guest page number in Hyper-V page, so use HV_HYP_PAGE instead of PAGE. Signed-off-by: Boqun Feng --- drivers/hv/hv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c index 7499079f4077..8ac8bbf5b5aa 10064

[RFC v2 00/11] Hyper-V: Support PAGE_SIZE larger than 4K

2020-09-01 Thread Boqun Feng
This patchset add the necessary changes to support guests whose page size is larger than 4K. Previous version: v1: https://lore.kernel.org/lkml/20200721014135.84140-1-boqun.f...@gmail.com/ Changes since v1: * Introduce a hv_ring_gpadl_send_offset() to improve the readability as per

[RFC v2 03/11] Drivers: hv: vmbus: Introduce types of GPADL

2020-09-01 Thread Boqun Feng
This patch introduces two types of GPADL: HV_GPADL_{BUFFER, RING}. The types of GPADL are purely the concept in the guest, IOW the hypervisor treat them as the same. The reason of introducing the types of GPADL is to support guests whose page size is not 4k (the page size of Hyper-V hypervisor). I

[RFC v2 02/11] Drivers: hv: vmbus: Move __vmbus_open()

2020-09-01 Thread Boqun Feng
Pure function movement, no functional changes. The move is made, because in a later change, __vmbus_open() will rely on some static functions afterwards, so we sperate the move and the modification of __vmbus_open() in two patches to make it easy to review. Signed-off-by: Boqun Feng Reviewed-by:

[RFC v2 07/11] hv_netvsc: Use HV_HYP_PAGE_SIZE for Hyper-V communication

2020-09-01 Thread Boqun Feng
When communicating with Hyper-V, HV_HYP_PAGE_SIZE should be used since that's the page size used by Hyper-V and Hyper-V expects all page-related data using the unit of HY_HYP_PAGE_SIZE, for example, the "pfn" in hv_page_buffer is actually the HV_HYP_PAGE (i.e. the Hyper-V page) number. In order to

[RFC v2 11/11] scsi: storvsc: Support PAGE_SIZE larger than 4K

2020-09-01 Thread Boqun Feng
Hyper-V always use 4k page size (HV_HYP_PAGE_SIZE), so when communicating with Hyper-V, a guest should always use HV_HYP_PAGE_SIZE as the unit for page related data. For storvsc, the data is vmbus_packet_mpb_array. And since in scsi_cmnd, sglist of pages (in unit of PAGE_SIZE) is used, we need conv

[RFC v2 05/11] Drivers: hv: vmbus: Move virt_to_hvpfn() to hyperv header

2020-09-01 Thread Boqun Feng
There will be more places other than vmbus where we need to calculate the Hyper-V page PFN from a virtual address, so move virt_to_hvpfn() to hyperv generic header. Signed-off-by: Boqun Feng --- drivers/hv/channel.c | 13 - include/linux/hyperv.h | 15 +++ 2 files chang

[RFC v2 10/11] Driver: hv: util: Make ringbuffer at least take two pages

2020-09-01 Thread Boqun Feng
When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at least 2 * PAGE_SIZE: one page for the header and at least one page of the data part (because of the alignment requirement for double mapping). So make sure the ringbuffer sizes to be at least 2 * PAGE_SIZE when using vmbus_ope

[RFC v2 09/11] HID: hyperv: Make ringbuffer at least take two pages

2020-09-01 Thread Boqun Feng
When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at least 2 * PAGE_SIZE: one page for the header and at least one page of the data part (because of the alignment requirement for double mapping). So make sure the ringbuffer sizes to be at least 2 * PAGE_SIZE when using vmbus_ope

[RFC v2 08/11] Input: hyperv-keyboard: Make ringbuffer at least take two pages

2020-09-01 Thread Boqun Feng
When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at least 2 * PAGE_SIZE: one page for the header and at least one page of the data part (because of the alignment requirement for double mapping). So make sure the ringbuffer sizes to be at least 2 * PAGE_SIZE when using vmbus_ope

[RFC v2 06/11] hv: hyperv.h: Introduce some hvpfn helper functions

2020-09-01 Thread Boqun Feng
When a guest communicate with the hypervisor, it must use HV_HYP_PAGE to calculate PFN, so introduce a few hvpfn helper functions as the counterpart of the page helper functions. This is the preparation for supporting guest whose PAGE_SIZE is not 4k. Signed-off-by: Boqun Feng --- include/linux/h

[RFC v2 01/11] Drivers: hv: vmbus: Always use HV_HYP_PAGE_SIZE for gpadl

2020-09-01 Thread Boqun Feng
Since the hypervisor always uses 4K as its page size, the size of PFNs used for gpadl should be HV_HYP_PAGE_SIZE rather than PAGE_SIZE, so adjust this accordingly as the preparation for supporting 16K/64K page size guests. No functional changes on x86, since PAGE_SIZE is always 4k (equals to HV_HYP

[PATCH bpf-next v4 2/2] selftests/bpf: test task_file iterator without visiting pthreads

2020-09-01 Thread Yonghong Song
Modified existing bpf_iter_test_file.c program to check whether all accessed files from the main thread or not. Modified existing bpf_iter_test_file program to check whether all accessed files from the main thread or not. $ ./test_progs -n 4 ... #4/7 task_file:OK ... #4 bpf_iter:OK Sum

[PATCH bpf-next v4 0/2] bpf: avoid iterating duplicated files for task_file iterator

2020-09-01 Thread Yonghong Song
Commit e679654a704e ("bpf: Fix a rcu_sched stall issue with bpf task/task_file iterator") introduced rate limiting in bpf_seq_read() to fix a case where traversing too many tasks and files (tens of millions of files) may cause kernel rcu stall. But rate limiting won't reduce the amount of work to t

[PATCH bpf-next v4 1/2] bpf: avoid iterating duplicated files for task_file iterator

2020-09-01 Thread Yonghong Song
Currently, task_file iterator iterates all files from all tasks. This may potentially visit a lot of duplicated files if there are many tasks sharing the same files, e.g., typical pthreads where these pthreads and the main thread are sharing the same files. This patch changed task_file iterator to

Re: [PATCH bpf-next 2/5] bpf: add main_thread_only customization for task/task_file iterators

2020-09-01 Thread Yonghong Song
On 9/1/20 5:34 PM, Andrii Nakryiko wrote: On Thu, Aug 27, 2020 at 11:09 AM Yonghong Song wrote: On 8/26/20 10:07 PM, Andrii Nakryiko wrote: On Wed, Aug 26, 2020 at 5:07 PM Yonghong Song wrote: Currently, task and task_file by default iterates through all tasks. For task_file, by defau

Re: [PATCH bpf-next v2 2/2] selftests/bpf: test task_file iterator without visiting pthreads

2020-09-01 Thread Yonghong Song
On 9/1/20 5:41 PM, Andrii Nakryiko wrote: On Thu, Aug 27, 2020 at 10:38 PM Yonghong Song wrote: Modified existing bpf_iter_test_file.c program to check whether all accessed files from the main thread or not. Modified existing bpf_iter_test_file program to check whether all accessed files f

Re: [PATCH bpf-next] bpf: add bpf_get_xdp_hash helper function

2020-09-01 Thread David Ahern
On 9/1/20 6:52 PM, Ramamurthy, Harshitha wrote: >> On 8/31/20 1:25 PM, Harshitha Ramamurthy wrote: >>> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index >>> a613750d5515..bffe93b526e7 100644 >>> --- a/include/uapi/linux/bpf.h >>> +++ b/include/uapi/linux/bpf.h >>> @@ -3576,6 +3

Re: [iproute2-next] tipc: support 128bit node identity for peer removing

2020-09-01 Thread David Ahern
On 8/26/20 8:30 PM, Hoang Huu Le wrote: > From: Hoang Le > > Problem: > In kernel upstream, we add the support to set node identity with > 128bit. However, we are still using legacy format in command tipc > peer removing. Then, we got a problem when trying to remove > offline node i.e: > > $ tip

Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-01 Thread Yunsheng Lin
On 2020/9/2 2:24, Cong Wang wrote: > On Mon, Aug 31, 2020 at 5:59 PM Yunsheng Lin wrote: >> >> Currently there is concurrent reset and enqueue operation for the >> same lockless qdisc when there is no lock to synchronize the >> q->enqueue() in __dev_xmit_skb() with the qdisc reset operation in >>

Re: [PATCH iproute2-next] ip xfrm: support printing XFRMA_SET_MARK_MASK attribute in states

2020-09-01 Thread David Ahern
On 8/28/20 8:59 AM, Antony Antony wrote: > The XFRMA_SET_MARK_MASK attribute is set in states (4.19+). > It is the mask of XFRMA_SET_MARK(a.k.a. XFRMA_OUTPUT_MARK in 4.18) > > sample output: note the output-mark mask > ip xfrm state > src 192.1.2.23 dst 192.1.3.33 > proto esp spi 0xSPI

Re: [PATCH iproute2 net-next v2] iplink: add support for protodown reason

2020-09-01 Thread David Ahern
On 8/28/20 9:42 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch adds support for recently > added link IFLA_PROTO_DOWN_REASON attribute. > IFLA_PROTO_DOWN_REASON enumerates reasons > for the already existing IFLA_PROTO_DOWN link > attribute. > > $ cat /etc/iproute2/protodown_reasons.

Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-01 Thread Yunsheng Lin
On 2020/9/2 2:34, David Miller wrote: > From: Yunsheng Lin > Date: Tue, 1 Sep 2020 15:27:44 +0800 > >> On 2020/9/1 14:48, Eric Dumazet wrote: >>> We request Fixes: tag for fixes in networking land. >> >> ok. >> >> Fixes: 6b3ba9146fe6 ("net: sched: allow qdiscs to handle locking") > > You should

RE: [PATCH bpf-next] bpf: add bpf_get_xdp_hash helper function

2020-09-01 Thread Ramamurthy, Harshitha
> From: Daniel Borkmann > Sent: Monday, August 31, 2020 1:33 PM > To: Ramamurthy, Harshitha ; > b...@vger.kernel.org; netdev@vger.kernel.org; a...@kernel.org; > da...@davemloft.net; k...@kernel.org > Cc: dsah...@gmail.com; Duyck, Alexander H > ; Herbert, Tom > Subject: Re: [PATCH bpf-next] bpf: a

Re: COMPILE_TEST

2020-09-01 Thread Randy Dunlap
On 9/1/20 5:17 PM, Jakub Kicinski wrote: > On Tue, 1 Sep 2020 23:48:52 +0200 Andrew Lunn wrote: >> On Tue, Sep 01, 2020 at 03:22:31PM -0500, Alex Elder wrote: >>> Jakub, you suggested/requested that the Qualcomm IPA driver get >>> built when the COMPILE_TEST config option is enabled. I started >>>

RE: [PATCH bpf-next] bpf: add bpf_get_xdp_hash helper function

2020-09-01 Thread Ramamurthy, Harshitha
> From: bpf-ow...@vger.kernel.org On Behalf > Of David Ahern > Sent: Monday, August 31, 2020 12:54 PM > To: Ramamurthy, Harshitha ; > b...@vger.kernel.org; netdev@vger.kernel.org; a...@kernel.org; > dan...@iogearbox.net; da...@davemloft.net; k...@kernel.org > Cc: Duyck, Alexander H ; Herbert, Tom

Re: [net-next PATCH 0/2 v2] RTL8366 stabilization

2020-09-01 Thread David Miller
From: Florian Fainelli Date: Tue, 1 Sep 2020 15:42:40 -0700 > > > On 9/1/2020 3:39 PM, David Miller wrote: >> From: Linus Walleij >> Date: Tue, 1 Sep 2020 21:08:52 +0200 >> >>> This stabilizes the RTL8366 driver by checking validity >>> of the passed VLANs and refactoring the member config >

Re: [PATCH net-next v2 5/9] gve: Add Gvnic stats AQ command and ethtool show/set-priv-flags.

2020-09-01 Thread Jakub Kicinski
On Tue, 1 Sep 2020 14:51:45 -0700 David Awogbemila wrote: > @@ -297,6 +317,22 @@ static inline void gve_clear_probe_in_progress(struct > gve_priv *priv) > clear_bit(GVE_PRIV_FLAGS_PROBE_IN_PROGRESS, &priv->service_task_flags); > } > > +static inline bool gve_get_do_report_stats(struct g

Re: PMTUD broken inside network namespace with multipath routing

2020-09-01 Thread David Ahern
On 9/1/20 4:40 AM, mastertheknife wrote: > > P.S: while reading the relevant code in the kernel, i think i spotted > some mistake in net/ipv4/route.c, in function "update_or_create_fnhe". > It looks like it loops over all the exceptions for the nexthop entry, > but always overwriting the first (an

Re: [PATCH bpf-next v2 2/2] selftests/bpf: test task_file iterator without visiting pthreads

2020-09-01 Thread Andrii Nakryiko
On Thu, Aug 27, 2020 at 10:38 PM Yonghong Song wrote: > > Modified existing bpf_iter_test_file.c program to check whether > all accessed files from the main thread or not. > > Modified existing bpf_iter_test_file program to check > whether all accessed files from the main thread or not. > $ ./te

Re: [PATCH net-next v2 4/9] gve: Add support for dma_mask register

2020-09-01 Thread Jakub Kicinski
On Tue, 1 Sep 2020 14:51:44 -0700 David Awogbemila wrote: > From: Catherine Sullivan > > Add the dma_mask register and read it to set the dma_masks. > gve_alloc_page will alloc_page with: > GFP_DMA if priv->dma_mask is 24, > GFP_DMA32 if priv->dma_mask is 32. What about Andrew's request to CC

Re: [PATCH bpf-next 2/5] bpf: add main_thread_only customization for task/task_file iterators

2020-09-01 Thread Andrii Nakryiko
On Thu, Aug 27, 2020 at 11:09 AM Yonghong Song wrote: > > > > On 8/26/20 10:07 PM, Andrii Nakryiko wrote: > > On Wed, Aug 26, 2020 at 5:07 PM Yonghong Song wrote: > >> > >> Currently, task and task_file by default iterates through > >> all tasks. For task_file, by default, all files from all task

Re: [PATCH net-next v2 2/9] gve: Add stats for gve.

2020-09-01 Thread Jakub Kicinski
On Tue, 1 Sep 2020 14:51:42 -0700 David Awogbemila wrote: > From: Kuo Zhao > > Sample output of "ethtool -S " with 1 RX queue and 1 TX > queue: Acked-by: Jakub Kicinski Looking forward to the standard stats.

[PATCH bpf-next v3 0/2] bpf: avoid iterating duplicated files for task_file iterator

2020-09-01 Thread Yonghong Song
Commit e679654a704e ("bpf: Fix a rcu_sched stall issue with bpf task/task_file iterator") introduced rate limiting in bpf_seq_read() to fix a case where traversing too many tasks and files (tens of millions of files) may cause kernel rcu stall. But rate limiting won't reduce the amount of work to t

[PATCH bpf-next v3 1/2] bpf: avoid iterating duplicated files for task_file iterator

2020-09-01 Thread Yonghong Song
Currently, task_file iterator iterates all files from all tasks. This may potentially visit a lot of duplicated files if there are many tasks sharing the same files, e.g., typical pthreads where these pthreads and the main thread are sharing the same files. This patch changed task_file iterator to

[PATCH bpf-next v3 2/2] selftests/bpf: test task_file iterator without visiting pthreads

2020-09-01 Thread Yonghong Song
Modified existing bpf_iter_test_file.c program to check whether all accessed files from the main thread or not. Modified existing bpf_iter_test_file program to check whether all accessed files from the main thread or not. $ ./test_progs -n 4 ... #4/7 task_file:OK ... #4 bpf_iter:OK Sum

Re: COMPILE_TEST

2020-09-01 Thread Jakub Kicinski
On Tue, 1 Sep 2020 23:48:52 +0200 Andrew Lunn wrote: > On Tue, Sep 01, 2020 at 03:22:31PM -0500, Alex Elder wrote: > > Jakub, you suggested/requested that the Qualcomm IPA driver get > > built when the COMPILE_TEST config option is enabled. I started > > working on this a few months ago but didn't

Re: [PATCH net-next RFC v3 02/14] devlink: Add reload actions counters

2020-09-01 Thread Jakub Kicinski
On Tue, 1 Sep 2020 22:05:36 +0300 Moshe Shemesh wrote: > >> +void devlink_reload_actions_cnts_update(struct devlink *devlink, unsigned > >> long actions_done) > >> +{ > >> + int action; > >> + > >> + for (action = 0; action < DEVLINK_RELOAD_ACTION_MAX; action++) { > >> + if (!test_bit(a

Re: [PATCH bpf-next v1 4/8] bpf/libbpf: BTF support for typed ksyms

2020-09-01 Thread Andrii Nakryiko
On Tue, Sep 1, 2020 at 1:35 PM Hao Luo wrote: > > On Tue, Sep 1, 2020 at 11:11 AM Andrii Nakryiko > wrote: > > > > On Thu, Aug 27, 2020 at 3:29 PM Hao Luo wrote: > > > > > > On Fri, Aug 21, 2020 at 3:37 PM Andrii Nakryiko > > > wrote: > > > > > > > > On Wed, Aug 19, 2020 at 3:42 PM Hao Luo wro

[PATCH net-next 2/3] net: dsa: bcm_sf2: request and handle clocks

2020-09-01 Thread Florian Fainelli
Fetch the corresponding clock resource and enable/disable it during suspend/resume if and only if we have no ports defined for Wake-on-LAN. Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 20 ++-- drivers/net/dsa/bcm_sf2.h | 2 ++ 2 files changed, 20 insertions(+

[PATCH net-next 0/3] net: dsa: bcm_sf2: Clock support

2020-09-01 Thread Florian Fainelli
Hi David, This patch series adds support for controlling the SF2 switch core and divider clock (where applicable). Florian Fainelli (3): dt-bindings: net: Document Broadcom SF2 switch clocks net: dsa: bcm_sf2: request and handle clocks net: dsa: bcm_sf2: recalculate switch clock rate based

[PATCH net-next 3/3] net: dsa: bcm_sf2: recalculate switch clock rate based on ports

2020-09-01 Thread Florian Fainelli
Whenever a port gets enabled/disabled, recalcultate the required switch clock rate to make sure it always gets set to the expected rate targeting our switch use case. This is only done for the BCM7445 switch as there is no clocking profile available for BCM7278. Signed-off-by: Florian Fainelli --

[PATCH net-next 1/3] dt-bindings: net: Document Broadcom SF2 switch clocks

2020-09-01 Thread Florian Fainelli
Describe the two possible clocks feeding into the Broadcom SF2 integrated Ethernet switch. BCM7445 systems have two clocks, one for the main switch core clock, and another for controlling the switch clock divider whereas BCM7278 systems only have the first kind. Signed-off-by: Florian Fainelli --

Re: [PATCH] veth: fix memory leak in veth_newlink()

2020-09-01 Thread Rustam Kovhaev
On Tue, Sep 01, 2020 at 01:01:27PM -0700, David Miller wrote: > From: Rustam Kovhaev > Date: Sun, 30 Aug 2020 06:13:36 -0700 > > > when register_netdevice(dev) fails we should check whether struct > > veth_rq has been allocated via ndo_init callback and free it, because, > > depending on the code

Re: [PATCH bpf-next v3 4/8] libbpf: implement bpf_prog_find_metadata

2020-09-01 Thread Alexei Starovoitov
On Mon, Aug 31, 2020 at 08:40:01AM -0700, s...@google.com wrote: > On 08/28, Toke H�iland-J�rgensen wrote: > > Stanislav Fomichev writes: > > > > This is a low-level function (hence in bpf.c) to find out the metadata > > > map id for the provided program fd. > > > It will be used in the next comm

Re: [net-next PATCH 0/2 v2] RTL8366 stabilization

2020-09-01 Thread Florian Fainelli
On 9/1/2020 3:39 PM, David Miller wrote: From: Linus Walleij Date: Tue, 1 Sep 2020 21:08:52 +0200 This stabilizes the RTL8366 driver by checking validity of the passed VLANs and refactoring the member config (MC) code so we do not require strict call order and de-duplicate some code. Chan

Re: [PATCH] net: usb: dm9601: Add USB ID of Keenetic Plus DSL

2020-09-01 Thread David Miller
From: Kamil Lorenc Date: > I received an error from Peter Korsgaard's mailserver informing that his > email address does not exist. Should I do something with that fact? Probably need a MAINTAINERS update. Is there any other email address by which Peter can be reached?

Re: [net-next PATCH 0/2 v2] RTL8366 stabilization

2020-09-01 Thread David Miller
From: Linus Walleij Date: Tue, 1 Sep 2020 21:08:52 +0200 > This stabilizes the RTL8366 driver by checking validity > of the passed VLANs and refactoring the member config > (MC) code so we do not require strict call order and > de-duplicate some code. > > Changes from v1: incorporate review com

Re: [PATCH net-next] octeontx2-pf: Add UDP segmentation offload support

2020-09-01 Thread David Miller
From: Date: Tue, 1 Sep 2020 15:01:42 +0530 > From: Sunil Goutham > > Defines UDP segmentation algorithm in hardware and supports > offloading UDP segmentation. > > Signed-off-by: Sunil Goutham Applied, thank you.

Re: [PATCH] net: usb: dm9601: Add USB ID of Keenetic Plus DSL

2020-09-01 Thread David Miller
From: Kamil Lorenc Date: Tue, 1 Sep 2020 10:57:38 +0200 > Keenetic Plus DSL is a xDSL modem that uses dm9620 as its USB interface. > > Signed-off-by: Kamil Lorenc Applied, thanks.

Re: [PATCH net-next] vhost: fix typo in error message

2020-09-01 Thread David Miller
From: Yunsheng Lin Date: Tue, 1 Sep 2020 10:39:09 +0800 > "enable" should be "disable" when the function name is > vhost_disable_notify(), which does the disabling work. > > Signed-off-by: Yunsheng Lin Applied to 'net'.

Re: [PATCH net-next] net: dsa: mv88e6xxx: Fix W=1 warning with !CONFIG_OF

2020-09-01 Thread David Miller
From: Andrew Lunn Date: Tue, 1 Sep 2020 04:32:57 +0200 > When building on platforms without device tree, e.g. amd64, W=1 gives > a warning about mv88e6xxx_mdio_external_match being unused. Replace > of_match_node() with of_device_is_compatible() to prevent this > warning. > > Suggested-by: Andy

Re: [net-next v2 1/4] tipc: optimize key switching time and logic

2020-09-01 Thread David Miller
From: Tuong Lien Date: Mon, 31 Aug 2020 15:38:14 +0700 > We reduce the lasting time for a pending TX key to be active as well as > for a passive RX key to be freed which generally helps speed up the key > switching. It is not expected to be too fast but should not be too slow > either. Also the k

[net-next PATCH 0/2 v3] RTL8366 stabilization

2020-09-01 Thread Linus Walleij
This stabilizes the RTL8366 driver by checking validity of the passed VLANs and refactoring the member config (MC) code so we do not require strict call order and de-duplicate some code. Changes from v1: incorporate review comments on patch 2. Changes from v2: a oneline bug fix in patch 2. Linus

[net-next PATCH 1/2 v3] net: dsa: rtl8366: Check validity of passed VLANs

2020-09-01 Thread Linus Walleij
The rtl8366_set_vlan() and rtl8366_set_pvid() get invalid VLANs tossed at it, especially VLAN0, something the hardware and driver cannot handle. Check validity and bail out like we do in the other callbacks. Reviewed-by: Florian Fainelli Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Resen

[net-next PATCH 2/2 v3] net: dsa: rtl8366: Refactor VLAN/PVID init

2020-09-01 Thread Linus Walleij
The VLANs and PVIDs on the RTL8366 utilizes a "member configuration" (MC) which is largely unexplained in the code. This set-up requires a special ordering: rtl8366_set_pvid() must be called first, followed by rtl8366_set_vlan(), else the MC will not be properly allocated. Relax this by factoring

Re: [PATCH net-next v2 3/9] gve: Use dev_info/err instead of netif_info/err.

2020-09-01 Thread Andrew Lunn
> @@ -1133,7 +1133,9 @@ static int gve_probe(struct pci_dev *pdev, const struct > pci_device_id *ent) > goto abort_with_db_bar; > } > SET_NETDEV_DEV(dev, &pdev->dev); > + > pci_set_drvdata(pdev, dev); > + > dev->ethtool_ops = &gve_ethtool_ops; > dev->net

Re: [PATCH net-next v2 1/9] gve: Get and set Rx copybreak via ethtool

2020-09-01 Thread Andrew Lunn
On Tue, Sep 01, 2020 at 02:51:41PM -0700, David Awogbemila wrote: > From: Kuo Zhao > > This adds support for getting and setting the RX copybreak > value via ethtool. > > Reviewed-by: Yangchun Fu > Signed-off-by: Kuo Zhao > Signed-off-by: David Awogbemila Reviewed-by: Andrew Lunn Andre

Re: [PATCH ethtool] ethtool: add support show/set-hwtstamp

2020-09-01 Thread Andrew Lunn
On Tue, Sep 01, 2020 at 05:20:09PM -0400, Kevin(Yudong) Yang wrote: > Before this patch, ethtool has -T/--show-time-stamping that only > shows the device's time stamping capabilities but not the time > stamping policy that is used by the device. Hi Kavin How does this differ from hwstamp_ctl(1)?

Re: COMPILE_TEST

2020-09-01 Thread Andrew Lunn
On Tue, Sep 01, 2020 at 03:22:31PM -0500, Alex Elder wrote: > Jakub, you suggested/requested that the Qualcomm IPA driver get > built when the COMPILE_TEST config option is enabled. I started > working on this a few months ago but didn't finish, and picked > it up again today. I'd really like to

[PATCH net-next 3/3] net: systemport: Manage Wake-on-LAN clock

2020-09-01 Thread Florian Fainelli
It is necessary to manage the Wake-on-LAN clock to turn on the appropriate blocks for MPD or CFP-based packet matching to work otherwise we will not be able to reliably match packets during suspend. Reported-by: Blair Prescott Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bc

[PATCH net-next 0/3] net: systemport: Clock support

2020-09-01 Thread Florian Fainelli
Hi David, This patch series makes the SYSTEMPORT driver request and manage its main and Wake-on-LAN clocks appropriately. Florian Fainelli (3): dt-bindings: net: Document Broadcom SYSTEMPORT clocks net: systemport: fetch and use clock resources net: systemport: Manage Wake-on-LAN clock ..

[PATCH net-next 2/3] net: systemport: fetch and use clock resources

2020-09-01 Thread Florian Fainelli
We disable clocks shortly after probing the device to save as much power as possible in case the interface is never used. When bcm_sysport_open() is invoked, clocks are enabled, and disabled in bcm_sysport_stop(). A similar scheme is applied to the suspend/resume functions. Signed-off-by: Florian

[PATCH net-next 1/3] dt-bindings: net: Document Broadcom SYSTEMPORT clocks

2020-09-01 Thread Florian Fainelli
The Broadcom SYSTEMPORT adapters require the use of two clocks for normal operations and during Wake-on-LAN, document those in the binding document. Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/net/brcm,systemport.txt | 5 + 1 file changed, 5 insertions(+) diff --gi

Re: [PATCH net-next 2/3] devlink: Consider other controller while building phys_port_name

2020-09-01 Thread Jakub Kicinski
On Tue, 1 Sep 2020 11:17:42 +0200 Jiri Pirko wrote: > >> The external PFs need to have an extra attribute with "external > >> enumeration" what would be used for the representor netdev name as well. > >> > >> pci/:00:08.0/0: type eth netdev enp0s8f0 flavour physical > >> pci/:00:08.0/1: ty

Re: pull-request: bpf-next 2020-09-01

2020-09-01 Thread David Miller
From: Daniel Borkmann Date: Tue, 1 Sep 2020 21:49:50 +0200 > The following pull-request contains BPF updates for your *net-next* tree. > > There are two small conflicts when pulling, resolve as follows: ... > We've added 133 non-merge commits during the last 14 day(s) which contain > a total o

COMPILE_TEST

2020-09-01 Thread Alex Elder
Jakub, you suggested/requested that the Qualcomm IPA driver get built when the COMPILE_TEST config option is enabled. I started working on this a few months ago but didn't finish, and picked it up again today. I'd really like to get this done soon. The QCOM_IPA config option depends on and selec

Re: [PATCH net-next 0/3] dpaa2-eth: add a dpaa2_eth_ prefix to all functions

2020-09-01 Thread David Miller
From: Ioana Ciornei Date: Mon, 31 Aug 2020 21:12:37 +0300 > This is just a quick cleanup that aims at adding a dpaa2_eth_ prefix to > all functions within the dpaa2-eth driver even if those are static and > private to the driver. The main reason for doing this is that looking a > perf top, for ex

Re: [PATCH net-next] ibmvnic: Harden device Command Response Queue handshake

2020-09-01 Thread David Miller
From: Thomas Falcon Date: Mon, 31 Aug 2020 11:59:57 -0500 > In some cases, the device or firmware may be busy when the > driver attempts to perform the CRQ initialization handshake. > If the partner is busy, the hypervisor will return the H_CLOSED > return code. The aim of this patch is that, if

Re: [PATCH net] net: ethernet: mlx4: Fix memory allocation in mlx4_buddy_init()

2020-09-01 Thread David Miller
From: Shung-Hsi Yu Date: Mon, 31 Aug 2020 22:37:09 +0800 > On machines with much memory (> 2 TByte) and log_mtts_per_seg == 0, a > max_order of 31 will be passed to mlx_buddy_init(), which results in > s = BITS_TO_LONGS(1 << 31) becoming a negative value, leading to > kvmalloc_array() failure whe

Re: [PATCH v2] net: openvswitch: pass NULL for unused parameters

2020-09-01 Thread David Miller
From: t...@redhat.com Date: Sun, 30 Aug 2020 14:26:30 -0700 > Passing unused parameters is a waste. Poorly predicted branches are an even bigger waste. I'm not a big fan of this change and others have asked for performance analysis to be performed. So I'm not applying this as-is, sorry. It's a

Re: [PATCH net-next] net: openvswitch: fixes crash if nf_conncount_init() fails

2020-09-01 Thread David Miller
From: Eelco Chaudron Date: Mon, 31 Aug 2020 11:57:57 +0200 > If nf_conncount_init fails currently the dispatched work is not canceled, > causing problems when the timer fires. This change fixes this by not > scheduling the work until all initialization is successful. > > Fixes: a65878d6f00b ("ne

Re: [PATCH net-next RFC v3 00/14] Add devlink reload action option

2020-09-01 Thread Moshe Shemesh
On 8/31/2020 1:49 PM, Jiri Pirko wrote: Sun, Aug 30, 2020 at 05:27:20PM CEST, mo...@mellanox.com wrote: Introduce new option on devlink reload API to enable the user to select the reload action required. Complete support for all actions in mlx5. The following reload actions are supported: dr

Re: [PATCH] veth: fix memory leak in veth_newlink()

2020-09-01 Thread David Miller
From: Rustam Kovhaev Date: Sun, 30 Aug 2020 06:13:36 -0700 > when register_netdevice(dev) fails we should check whether struct > veth_rq has been allocated via ndo_init callback and free it, because, > depending on the code path, register_netdevice() might not call > priv_destructor() callback >

[PATCH net-next 0/1] Support for VLAN interface over HSR/PRP

2020-09-01 Thread Murali Karicheri
This series add support for creating VLAN interface over HSR or PRP interface. Typically industrial networks uses VLAN in deployment and this capability is needed to support these networks. This is tested using two TI AM572x IDK boards connected back to back over CPSW ports (eth0 and eth1). Foll

[PATCH net-next 1/1] net: hsr/prp: add vlan support

2020-09-01 Thread Murali Karicheri
This patch add support for creating vlan interfaces over hsr/prp interface. Signed-off-by: Murali Karicheri --- net/hsr/hsr_device.c | 4 net/hsr/hsr_forward.c | 16 +--- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.

INFO: task can't die in register_netdevice_notifier

2020-09-01 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:b36c9697 Add linux-next specific files for 20200828 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1666027190 kernel config: https://syzkaller.appspot.com/x/.config?x=5e3cf99580b5542c dashboard

pull-request: bpf-next 2020-09-01

2020-09-01 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. There are two small conflicts when pulling, resolve as follows: 1) Merge conflict in tools/lib/bpf/libbpf.c between 88a82120282b ("libbpf: Factor out common ELF operations and improve logging") in bpf-next an

[PATCH iproute2 1/1] ip: updated ip-link man page

2020-09-01 Thread Roman Mashak
Added description of link flags allmulticast, promisc and trailers. Signed-off-by: Roman Mashak --- man/man8/ip-link.8.in | 22 ++ 1 file changed, 22 insertions(+) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index 367105b72f44..f451ecf3418f 100644 --- a/man/ma

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-01 Thread Moshe Shemesh
On 8/31/2020 3:15 PM, Jiri Pirko wrote: Sun, Aug 30, 2020 at 05:27:21PM CEST, mo...@mellanox.com wrote: Add devlink reload action to allow the user to request a specific reload action. The action parameter is optional, if not specified then devlink driver re-init action is used (backward compa

[PATCH] net: usb: dm9601: Add USB ID of Keenetic Plus DSL

2020-09-01 Thread Kamil Lorenc
> Keenetic Plus DSL is a xDSL modem that uses dm9620 as its USB interface. > > Signed-off-by: Kamil Lorenc > --- > drivers/net/usb/dm9601.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c > index b91f92e4e5f2..915ac75b55fc 100644 >

  1   2   3   >