On Tue, 1 Sep 2020 11:17:42 +0200 Jiri Pirko wrote: > >> The external PFs need to have an extra attribute with "external > >> enumeration" what would be used for the representor netdev name as well. > >> > >> pci/0000:00:08.0/0: type eth netdev enp0s8f0 flavour physical > >> pci/0000:00:08.0/1: type eth netdev enp0s8f0_pf0 flavour pcipf pfnum 0 > >> pci/0000:00:08.0/2: type eth netdev enp0s8f0_e0pf0 flavour pcipf extnum 0 > >> pfnum 0 > > > >How about a prefix of "ec" instead of "e", like? > >pci/0000:00:08.0/2: type eth netdev enp0s8f0_ec0pf0 flavour pcipf ecnum 0 > >pfnum 0 > > Yeah, looks fine to me. Jakub?
I don't like that local port doesn't have the controller ID. Whether PCI port is external or not is best described by a the peer relation. Failing that, at the very least "external" should be a separate attribute/flag from the controller ID. I didn't quite get the fact that you want to not show controller ID on the local port, initially.
