From: Tuong Lien <tuong.t.l...@dektech.com.au>
Date: Mon, 31 Aug 2020 15:38:14 +0700
> We reduce the lasting time for a pending TX key to be active as well as
> for a passive RX key to be freed which generally helps speed up the key
> switching. It is not expected to be too fast but should not be too slow
> either. Also the key handling logic is simplified that a pending RX key
> will be removed automatically if it is found not working after a number
> of times; the probing for a pending TX key is now carried on a specific
> message user ('LINK_PROTOCOL' or 'LINK_CONFIG') which is more efficient
> than using a timer on broadcast messages, the timer is reserved for use
> later as needed.
>
> The kernel logs or 'pr***()' are now made as clear as possible to user.
> Some prints are added, removed or changed to the debug-level. The
> 'TIPC_CRYPTO_DEBUG' definition is removed, and the 'pr_debug()' is used
> instead which will be much helpful in runtime.
>
> Besides we also optimize the code in some other places as a preparation
> for later commits.
>
> This commit does not change the en/decryption functionalities.
>
> Acked-by: Jon Maloy <jma...@redhat.com>
> Signed-off-by: Tuong Lien <tuong.t.l...@dektech.com.au>
Random log messages in response to user config requests are
inappropriate especially with netlink.
Report such informational responses to errors using the
genl_info->extack instead, as is standard practice across
the entire kernel.
Please remove all kernel log messages that get emitted due to
netlink operations and use extack notifications instead.
I also disagree with the commit message stating:
This commit does not change the en/decryption functionalities.
You are changing timer lengths and other aspects of crypto behavior,
so the patch is in fact changing things.
