Re: [RFC PATCH v1 1/2] Bluetooth: queue ACL packets if no handle is found

Hi Alain, > >>> There is a possibility that an ACL packet is received before we > >>> receive the HCI connect event for the corresponding handle. If this > >>> happens, we discard the ACL packet. > >>> > >>> Rather than just ignoring them, this patch provides a queue for > >>> incoming ACL packet

[PATCH 02/22] net: streamline __sys_setsockopt

Return early when sockfd_lookup_light fails to reduce a level of indentation for most of the function body. Signed-off-by: Christoph Hellwig --- net/socket.c | 57 +--- 1 file changed, 27 insertions(+), 30 deletions(-) diff --git a/net/socket.c b/

[PATCH 04/22] net: simplify cBPF setsockopt compat handling

Add a helper that copies either a native or compat bpf_fprog from userspace after verifying the length, and remove the compat setsockopt handlers that now aren't required. Signed-off-by: Christoph Hellwig --- include/linux/filter.h | 4 ++-- include/net/compat.h | 1 - net/compat.c

[PATCH 08/22] netfilter/ip_tables: clean up compat {get,set}sockopt handling

Merge the native and compat {get,set}sockopt handlers using in_compat_syscall(). Signed-off-by: Christoph Hellwig --- net/ipv4/netfilter/ip_tables.c | 86 +- 1 file changed, 21 insertions(+), 65 deletions(-) diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/

[PATCH 09/22] netfilter/ip6_tables: clean up compat {get,set}sockopt handling

Merge the native and compat {get,set}sockopt handlers using in_compat_syscall(). Signed-off-by: Christoph Hellwig --- net/ipv6/netfilter/ip6_tables.c | 87 - 1 file changed, 21 insertions(+), 66 deletions(-) diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6

[PATCH 05/22] net: remove compat_sock_common_{get,set}sockopt

Add the compat handling to sock_common_{get,set}sockopt instead, keyed of in_compat_syscall(). This allow to remove the now unused ->compat_{get,set}sockopt methods from struct proto_ops. Signed-off-by: Christoph Hellwig --- include/linux/net.h | 6 -- include/net/sock.h | 4 --

sockopt cleanups

Hi Dave, this series cleans up various lose ends in the sockopt code, most importantly removing the compat_{get,set}sockopt infrastructure in favor of just using in_compat_syscall() in the few places that care. Diffstat: arch/arm64/include/asm/unistd32.h |4 arch/mips/kerne

[PATCH 06/22] net: remove compat_sys_{get,set}sockopt

Now that the ->compat_{get,set}sockopt proto_ops methods are gone there is no good reason left to keep the compat syscalls separate. This fixes the odd use of unsigned int for the compat_setsockopt optlen and the missing sock_use_custom_sol_socket. It would also easily allow running the eBPF hook

[PATCH 01/22] net/atm: remove the atmdev_ops {get,set}sockopt methods

All implementations of these two methods are dummies that always return -EINVAL. Signed-off-by: Christoph Hellwig --- drivers/atm/eni.c| 17 - drivers/atm/firestream.c | 2 -- drivers/atm/fore200e.c | 27 --- drivers/atm/horizon.c| 40 --

[PATCH 10/22] netfilter/ebtables: clean up compat {get,set}sockopt handling

Merge the native and compat {get,set}sockopt handlers using in_compat_syscall(). Note that this required moving a fair amout of code around to be done sanely. Signed-off-by: Christoph Hellwig --- net/bridge/netfilter/ebtables.c | 214 +++- 1 file changed, 98 insertio

[PATCH 07/22] netfilter/arp_tables: clean up compat {get,set}sockopt handling

Merge the native and compat {get,set}sockopt handlers using in_compat_syscall(). Signed-off-by: Christoph Hellwig --- net/ipv4/netfilter/arp_tables.c | 85 - 1 file changed, 21 insertions(+), 64 deletions(-) diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4

[PATCH 14/22] net/ipv4: factor out MCAST_MSFILTER getsockopt helpers

Factor out one helper each for getting the native and compat version of the MCAST_MSFILTER option. Signed-off-by: Christoph Hellwig --- net/ipv4/ip_sockglue.c | 131 ++--- 1 file changed, 70 insertions(+), 61 deletions(-) diff --git a/net/ipv4/ip_sockglue.c b

[PATCH 11/22] netfilter: remove the compat_{get,set} methods

All instances handle compat sockopts via in_compat_syscall() now, so remove the compat_{get,set} methods as well as the compat_nf_{get,set}sockopt wrappers. Signed-off-by: Christoph Hellwig --- include/linux/netfilter.h | 14 - net/ipv4/ip_sockglue.c | 5 ++--- net/ipv6/ipv6_so

[PATCH 1/2] xdp: i40e: ixgbe: ixgbevf: not flip rx buffer for copy mode xdp

i40e/ixgbe/ixgbevf_rx_buffer_flip in copy mode xdp can lead to data corruption, like the following flow: 1. first skb is not for xsk, and forwarded to another device or socket queue 2. seconds skb is for xsk, copy data to xsk memory, and page of skb->data is released 3. rx_buf

[PATCH 13/22] netfilter: split nf_sockopt

Split nf_sockopt into a getsockopt and setsockopt side as they share very little code. Signed-off-by: Christoph Hellwig --- net/netfilter/nf_sockopt.c | 30 +- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/net/netfilter/nf_sockopt.c b/net/netfilter/n

[PATCH 2/2] ice/xdp: not adjust rx buffer for copy mode xdp

ice_rx_buf_adjust_pg_offset in copy mode xdp can lead to data corruption, like the following flow: 1. first skb is not for xsk, and forwarded to another device or socket queue 2. seconds skb is for xsk, copy data to xsk memory, and page of skb->data is released 3. rx_buff is r

[PATCH 17/22] net/ipv4: remove compat_ip_{get,set}sockopt

Handle the few cases that need special treatment in-line using in_compat_syscall(). Signed-off-by: Christoph Hellwig --- include/net/ip.h | 4 - net/dccp/ipv4.c| 4 - net/ipv4/ip_sockglue.c | 214 - net/ipv4/raw.c | 22 - net

[PATCH 16/22] net/ipv4: factor out mcast join/leave setsockopt helpers

Factor out one helper each for setting the native and compat version of the MCAST_MSFILTER option. Signed-off-by: Christoph Hellwig --- net/ipv4/ip_sockglue.c | 109 + 1 file changed, 56 insertions(+), 53 deletions(-) diff --git a/net/ipv4/ip_sockglue.c b

[PATCH 15/22] net/ipv4: factor out MCAST_MSFILTER setsockopt helpers

Factor out one helper each for setting the native and compat version of the MCAST_MSFILTER option. Signed-off-by: Christoph Hellwig --- net/ipv4/ip_sockglue.c | 162 ++--- 1 file changed, 86 insertions(+), 76 deletions(-) diff --git a/net/ipv4/ip_sockglue.c b

[PATCH 20/22] net/ipv6: factor out mcast join/leave setsockopt helpers

Factor out one helper each for setting the native and compat version of the MCAST_MSFILTER option. Signed-off-by: Christoph Hellwig --- net/ipv6/ipv6_sockglue.c | 103 --- 1 file changed, 53 insertions(+), 50 deletions(-) diff --git a/net/ipv6/ipv6_sockglue.c

[PATCH 21/22] net/ipv6: remove compat_ipv6_{get,set}sockopt

Handle the few cases that need special treatment in-line using in_compat_syscall(). This also removes all the now unused compat_{get,set}sockopt methods. Signed-off-by: Christoph Hellwig --- include/net/inet_connection_sock.h | 13 -- include/net/ipv6.h | 4 - include/net/sct

[PATCH 22/22] net: make ->{get,set}sockopt in proto_ops optional

Just check for a NULL method instead of wiring up sock_no_{get,set}sockopt. Signed-off-by: Christoph Hellwig --- crypto/af_alg.c | 1 - crypto/algif_aead.c | 4 crypto/algif_hash.c | 4 crypto/algif_rng.c | 2 -- crypto/algif_skcipher.c | 4

[PATCH 0/2] intel/xdp fixes for fliping rx buffer

This fixes ice/i40e/ixgbe/ixgbevf_rx_buffer_flip in copy mode xdp that can lead to data corruption. I split two patches, since i40e/xgbe/ixgbevf supports xsk receiving from 4.18, put their fixes in a patch Li RongQing (2): xdp: i40e: ixgbe: ixgbevf: not flip rx buffer for copy mode xdp ice/x

[PATCH 19/22] net/ipv6: factor out MCAST_MSFILTER setsockopt helpers

Factor out one helper each for setting the native and compat version of the MCAST_MSFILTER option. Signed-off-by: Christoph Hellwig --- net/ipv6/ipv6_sockglue.c | 159 --- 1 file changed, 83 insertions(+), 76 deletions(-) diff --git a/net/ipv6/ipv6_sockglue.c

[PATCH 18/22] net/ipv6: factor out MCAST_MSFILTER getsockopt helpers

Factor out one helper each for getting the native and compat version of the MCAST_MSFILTER option. Signed-off-by: Christoph Hellwig --- net/ipv6/ipv6_sockglue.c | 139 +-- 1 file changed, 74 insertions(+), 65 deletions(-) diff --git a/net/ipv6/ipv6_sockglue.c

[PATCH 12/22] netfilter: remove the compat argument to xt_copy_counters_from_user

Lift the in_compat_syscall() from the callers instead. Signed-off-by: Christoph Hellwig --- include/linux/netfilter/x_tables.h | 2 +- net/ipv4/netfilter/arp_tables.c| 3 +-- net/ipv4/netfilter/ip_tables.c | 3 +-- net/ipv6/netfilter/ip6_tables.c| 3 +-- net/netfilter/x_tables.c

[PATCH 03/22] net: streamline __sys_getsockopt

Return early when sockfd_lookup_light fails to reduce a level of indentation for most of the function body. Signed-off-by: Christoph Hellwig --- net/socket.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/net/socket.c b/net/socket.c index 49

[PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe failure

The driver forgets to call destroy_workqueue when cxgb3 probe fails. Add the missed calls to fix it. Fixes: 4d22de3e6cc4 ("Add support for the latest 1G/10G Chelsio adapter, T3.") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 1 + 1 file c

[PATCH] net: cxgb3: add missed destroy_workqueue in nci_register_device

When nfc_register_device fails in nci_register_device, destroy_workqueue() shouled be called to destroy ndev->tx_wq. Fixes: 3c1c0f5dc80b ("NFC: NCI: Fix nci_register_device init sequence") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/nfc/nci/core.c | 5 - 1 file changed, 4 insert

net: decnet: TODO Items

Hi Maintainers and Developers, I am interested in the DECnet TODO list. I just need a quick response whether they are worth doing or not for the amount of development happening in this subsystem is extremely low and I can't help but question whether I should indulge in any of the listed wor

Re: [PATCH iproute2-next v3 1/2] tc: Look for blocks in qevents

Thu, Jul 16, 2020 at 06:47:07PM CEST, pe...@mellanox.com wrote: >When a list of filters at a given block is requested, tc first validates >that the block exists before doing the filter query. Currently the >validation routine checks ingress and egress blocks. But now that blocks >can be bound to qe

[PATCH net-next] net: hyperv: Add attributes to show RX/TX indirection table

The network is observed with low performance, if TX indirection table is imbalance. But the table is in memory and set in runtime, it's hard to know. Add them to attributes can help on troubleshooting. --- drivers/net/hyperv/netvsc_drv.c | 46 + 1 file changed, 46

Re: bug: net: dsa: mv88e6xxx: unable to tx or rx with Clearfog GT 8K (with git bisect)

On Sun, 12 Jul 2020 at 13:26, Russell King - ARM Linux admin wrote: > If you have machine A with address 192.168.2.1/24 on lan1 and machine B > with address 192.168.2.2/24 on lan2, then they should be able to ping > each other - the packet flow will be through the DSA switch without > involving th

how is the bpfilter sockopt processing supposed to work

Hi Alexei, I've just been auditing the sockopt code, and bpfilter looks really odd. Both getsockopts and setsockopt eventually end up in__bpfilter_process_sockopt, which then passes record to the userspace helper containing the address of the optval buffer. Which depending on bpf-cgroup might be

Re: [PATCH V2 5/6] ifcvf: replace irq_request/free with vDPA helpers

On 2020/7/16 下午7:23, Zhu Lingshan wrote: This commit replaced irq_request/free() with helpers in vDPA core, so that it can request/free irq and setup irq offloading on order. Signed-off-by: Zhu Lingshan Suggested-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 14 +- 1 fi

Re: [PATCH V2 4/6] vhost_vdpa: implement IRQ offloading in vhost_vdpa

On 2020/7/16 下午7:23, Zhu Lingshan wrote: This patch introduce a set of functions for setup/unsetup and update irq offloading respectively by register/unregister and re-register the irq_bypass_producer. Signed-off-by: Zhu Lingshan Suggested-by: Jason Wang --- drivers/vhost/Kconfig | 1 +

Re: [PATCH v4 net-next 3/3] octeontx2-pf: Add support for PTP clock

Hi Jakub, On Fri, Jul 17, 2020 at 5:41 AM Jakub Kicinski wrote: > > On Wed, 15 Jul 2020 18:08:09 +0530 Subbaraya Sundeep wrote: > > @@ -1730,10 +1745,149 @@ static void otx2_reset_task(struct work_struct > > *work) > > if (!netif_running(pf->netdev)) > > return; > > > > +

Re: [PATCH 03/20] thermal: rcar_gen3_thermal: Add r8a774e1 support

On 15/07/2020 13:08, Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Add r8a774e1 specific compatible string. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar --- Applied, thanks -- Linaro.org │ Open source software for ARM SoC

[PATCH v2 bpf-next 0/4] bpf: Populate bpffs with map and prog iterators

From: Alexei Starovoitov v1->v2: - changed names to 'progs.debug' and 'maps.debug' to hopefully better indicate instability of the text output. Having dot in the name also guarantees that these special files will not conflict with normal bpf objects pinned in bpffs, since dot is disallowed

[PATCH v2 bpf-next 1/4] bpf: Add bpf_prog iterator

From: Alexei Starovoitov It's mostly a copy paste of commit 6086d29def80 ("bpf: Add bpf_map iterator") that is use to implement bpf_seq_file opreations to traverse all bpf programs. Signed-off-by: Alexei Starovoitov Acked-by: Yonghong Song --- include/linux/bpf.h| 1 + kernel/bpf/Makefil

[PATCH v2 bpf-next 4/4] bpf: Add kernel module with user mode driver that populates bpffs.

From: Alexei Starovoitov Add kernel module with user mode driver that populates bpffs with BPF iterators. $ mount bpffs /my/bpffs/ -t bpf $ ls -la /my/bpffs/ total 4 drwxrwxrwt 2 root root0 Jul 2 00:27 . drwxr-xr-x 19 root root 4096 Jul 2 00:09 .. -rw--- 1 root root0 Jul 2 00:27

[PATCH v2 bpf-next 2/4] bpf: Factor out bpf_link_get_by_id() helper.

From: Alexei Starovoitov Refactor the code a bit to extract bpf_link_get_by_id() helper. It's similar to existing bpf_prog_by_id(). Signed-off-by: Alexei Starovoitov Acked-by: Andrii Nakryiko --- include/linux/bpf.h | 1 + kernel/bpf/syscall.c | 46 +++---

[PATCH v2 bpf-next 3/4] bpf: Add BPF program and map iterators as built-in BPF programs.

From: Alexei Starovoitov The program and map iterators work similar to seq_file-s. Once the program is pinned in bpffs it can be read with "cat" tool to print human readable output. In this case about BPF programs and maps. For example: $ cat /sys/fs/bpf/progs.debug id namepages att

Re: [PATCH V2 3/6] vDPA: implement IRQ offloading helpers in vDPA core

On 2020/7/16 下午7:23, Zhu Lingshan wrote: This commit implements IRQ offloading helpers Let's say "vq irq allocate/free helpers" here. in vDPA core by introducing two couple of functions: vdpa_alloc_vq_irq() and vdpa_free_vq_irq(): request irq and free irq, will setup irq offloading. vdp

Re: [PATCH] net: ethernet: ave: Fix error returns in ave_init

Hi Wang, On 2020/07/17 11:50, Wang Hai wrote: When regmap_update_bits failed in ave_init(), calls of the functions reset_control_assert() and clk_disable_unprepare() were missed. Add goto out_reset_assert to do this. Fixes: 57878f2f4697 ("net: ethernet: ave: add support for phy-mode setting of

Re: [PATCH V2 2/6] kvm: detect assigned device via irqbypass manager

On 2020/7/16 下午7:23, Zhu Lingshan wrote: vDPA devices has dedicated backed hardware like passthrough-ed devices. Then it is possible to setup irq offloading to vCPU for vDPA devices. Thus this patch tries to manipulated assigned device counters via irqbypass manager. This part needs some twe

PROBLEM: [e1000e] 10% throughput drop on I219-LM after the buffer overrun fix even with TSO&GSO disabled

[1.] One line summary of the problem: [e1000e] 10% throughput drop on I219-LM after the buffer overrun fix even with TSO&GSO disabled [2.] Full description of the problem/report: With e1000e 3.6.2-k and 3.8.4-NAPI driver, which include the fix for the buffer overrun problem (https://github.com/t

Re: [PATCH V2 1/6] vhost: introduce vhost_call_ctx

On 2020/7/16 下午7:23, Zhu Lingshan wrote: This commit introduces struct vhost_call_ctx which replaced raw struct eventfd_ctx *call_ctx in struct vhost_virtqueue. Besides eventfd_ctx, it contains a spin lock and an irq_bypass_producer in its structure. Signed-off-by: Zhu Lingshan Suggested-by:

Re: BPF logging infrastructure. Was: [PATCH bpf-next 4/6] tools: add new members to bpf_attr.raw_tracepoint in bpf.h

On Thu, Jul 16, 2020 at 12:59:30PM -0700, Andrii Nakryiko wrote: > On Wed, Jul 15, 2020 at 10:44 PM Alexei Starovoitov > wrote: > > > > On Wed, Jul 15, 2020 at 06:11:39PM -0700, Andrii Nakryiko wrote: > > > > > > > > On Wed, Jul 15, 2020, Andrii Nakryiko wrote: > > > > > > > > > > Inability to fig

[PATCH] net: ethernet: ave: Fix error returns in ave_init

When regmap_update_bits failed in ave_init(), calls of the functions reset_control_assert() and clk_disable_unprepare() were missed. Add goto out_reset_assert to do this. Fixes: 57878f2f4697 ("net: ethernet: ave: add support for phy-mode setting of system controller") Reported-by: Hulk Robot Sig

[PATCH net-next v3] bareudp: Reverted support to enable & disable rx metadata collection

From: Martin Varghese The commit fe80536acf83 ("bareudp: Added attribute to enable & disable rx metadata collection") breaks the the original(5.7) default behavior of bareudp module to collect RX metadadata at the receive. It was added to avoid the crash at the kernel neighbour subsytem when pack

Re: [PATCH bpf-next 4/5] bpf, x64: rework pro/epilogue and tailcall handling in JIT

On Fri, Jul 17, 2020 at 01:06:07AM +0200, Daniel Borkmann wrote: > > + ret = bpf_arch_text_poke(poke->tailcall_bypass, > > +BPF_MOD_JUMP, > > +NULL, bypass_addr); > > +

Re: [Intel-wired-lan] [PATCH] igc: Do not use link uninitialized in igc_check_for_copper_link

On Thu, Jul 16, 2020 at 07:29:03PM +0300, Neftin, Sasha wrote: > On 7/16/2020 07:49, Nathan Chancellor wrote: > > Clang warns: > > > Hello Nathan, > Thanks for tracking our code.Please, look at > https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200709073416.14126-1-sasha.nef...@intel.

[PATCH] ebpf: fix parameter naming confusing

Signed-off-by: YangYuxi --- kernel/bpf/syscall.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c index 0fd80ac81f70..300ae16baffc 100644 --- a/kernel/bpf/syscall.c +++ b/kernel/bpf/syscall.c @@ -1881,13 +1881,13 @@ struct

Re: [PATCH bpf-next v2 3/6] bpf: support attaching freplace programs to multiple attach points

On Thu, Jul 16, 2020 at 12:50:05PM +0200, Toke Høiland-Jørgensen wrote: > Alexei Starovoitov writes: > > > On Wed, Jul 15, 2020 at 03:09:02PM +0200, Toke Høiland-Jørgensen > > wrote: > >> > >> + if (tgt_prog_fd) { > >> + /* For now we only allow new targets for BPF_PROG_TYPE_EX

Re: [PATCH net-next 10/13] qed: add support for new port modes

On Thu, 16 Jul 2020 14:54:43 +0300 Alexander Lobakin wrote: > These ports ship on new boards revisions and are supported by newer > firmware versions. > > Signed-off-by: Alexander Lobakin > Signed-off-by: Igor Russkikh What is the driver actually doing with them, tho? Looks like you translate

Re: [PATCH v2 bpf-next 1/2] bpf: separate bpf_get_[stack|stackid] for perf events BPF

config: arm64-randconfig-r004-20200716 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ed6b578040a85977026c93bf4188f996148f3218) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O

Re: [PATCH v2] selftests: net: ip_defrag: modprobe missing nf_defrag_ipv6 support

On Thu, 16 Jul 2020 17:51:14 +0200 Paolo Pisati wrote: > Fix ip_defrag.sh when CONFIG_NF_DEFRAG_IPV6=m: > > $ sudo ./ip_defrag.sh > + set -e > + mktemp -u XX > + readonly NETNS=ns-rGlXcw > + trap cleanup EXIT > + setup > + ip netns add ns-rGlXcw > + ip -netns ns-rGlXcw link set lo up > + ip ne

Re: [pull request][net-next V2 00/15] mlx5 updates 2020-07-16

On Thu, 16 Jul 2020 17:03:55 -0700 Saeed Mahameed wrote: > Hi Dave, Jakub, > > This patchset includes mlx5 RX XFRM ipsec offloads for ConnectX devices > and some other misc updates and fixes to net-next. > v1->v2: > - Fix "was not declared" build warning when RETPOLINE=y, reported by Jakub. > >

Re: [PATCH net-next v4] net: dccp: Add SIOCOUTQ IOCTL support (send buffer fill)

On 16/07/2020 21:56, Jakub Kicinski wrote: > On Mon, 13 Jul 2020 00:55:20 +0200 Richard Sailer wrote: >> This adds support for the SIOCOUTQ IOCTL to get the send buffer fill >> of a DCCP socket, like UDP and TCP sockets already have. >> >> Regarding the used data field: DCCP uses per packet seque

Re: [PATCH net-next 2/2] hinic: add log in exception handling processes

On 2020/7/16 23:27, Jakub Kicinski wrote: > On Thu, 16 Jul 2020 20:50:56 +0800 Luo bin wrote: >> improve the error message when functions return failure and dump >> relevant registers in some exception handling processes >> >> Signed-off-by: Luo bin > > For kernel builds with W=1 C=1 flags this p

Re: [PATCH V3 net-next 1/8] net: ena: avoid unnecessary rearming of interrupt vector when busy-polling

On Thu, 16 Jul 2020 21:10:03 +0300 akiy...@amazon.com wrote: > This patch doesn't require smp_rmb() instruction in the napi routine > because it assumes cache coherency between two cores. I.e. the > 'interrupts_masked' flag set would be seen by the napi routine, even if > the flag is stored in L1 c

Re: [PATCH net-next v3 0/2] net: sched: Do not drop root lock in tcf_qevent_handle()

On Tue, 14 Jul 2020 20:03:06 +0300 Petr Machata wrote: > Mirred currently does not mix well with blocks executed after the qdisc > root lock is taken. This includes classification blocks (such as in PRIO, > ETS, DRR qdiscs) and qevents. The locking caused by the packet mirrored by > mirred can caus

Re: [PATCH net 2/3] net: bcmgenet: test RBUF_ACPI_EN when resuming

On 7/16/2020 4:38 PM, Doug Berger wrote: > When the GENET driver resumes from deep sleep the UMAC_CMD > register may not be accessible and therefore should not be > accessed from bcmgenet_wol_power_up_cfg() if the GENET has > been reset. > > This commit adds a check of the RBUF_ACPI_EN flag whe

Re: [PATCH net 1/3] net: bcmgenet: test MPD_EN when resuming

On 7/16/2020 4:38 PM, Doug Berger wrote: > When the GENET driver resumes from deep sleep the UMAC_CMD > register may not be accessible and therefore should not be > accessed from bcmgenet_wol_power_up_cfg() if the GENET has > been reset. > > This commit adds a check of the MPD_EN flag when Wake

Re: [PATCH net-next] ibmvnic: Increase driver logging

On Thu, 16 Jul 2020 13:22:00 -0700 Jakub Kicinski wrote: > On Thu, 16 Jul 2020 18:07:37 +0200 Michal Suchánek wrote: > > On Thu, Jul 16, 2020 at 10:59:58AM -0500, Thomas Falcon wrote: > > > On 7/15/20 8:29 PM, David Miller wrote: > > > > From: Jakub Kicinski > > > > Date: Wed, 15 Jul 2020

Re: [PATCH v4 net-next 3/3] octeontx2-pf: Add support for PTP clock

On Wed, 15 Jul 2020 18:08:09 +0530 Subbaraya Sundeep wrote: > @@ -1730,10 +1745,149 @@ static void otx2_reset_task(struct work_struct *work) > if (!netif_running(pf->netdev)) > return; > > + rtnl_lock(); > otx2_stop(pf->netdev); > pf->reset_count++; > otx

Re: [Intel-wired-lan] NAT performance issue 944mbit -> ~40mbit

On Thu, Jul 16, 2020 at 12:47 PM Ian Kumlien wrote: > > Sorry, tried to respond via the phone, used the webbrowser version but > still html mails... :/ > > On Thu, Jul 16, 2020 at 5:18 PM Alexander Duyck > wrote: > > On Wed, Jul 15, 2020 at 5:00 PM Ian Kumlien wrote: > > > On Thu, Jul 16, 2020 a

[net-next V2 15/15] net/mlx5e: CT: Map 128 bits labels to 32 bit map ID

From: Eli Britstein The 128 bits ct_label field is matched using a 32 bit hardware register. As such, only the lower 32 bits of ct_label field are offloaded. Change this logic to support setting and matching higher bits too. Map the 128 bits data to a unique 32 bits ID. Matching is done as exact

[net-next V2 09/15] net/mlx5e: IPsec: Add IPsec steering in local NIC RX

From: Huy Nguyen Introduce decrypt FT, the RX error FT and the default rules. The IPsec RX decrypt flow table is pointed by the TTC (Traffic Type Classifier) ESP steering rules. The decrypt flow table has two flow groups. The first flow group keeps the decrypt steering rule programmed via the "i

[net-next V2 12/15] net/mlx5e: XDP, Avoid indirect call in TX flow

From: Tariq Toukan Use INDIRECT_CALL_2() helper to avoid the cost of the indirect call when/if CONFIG_RETPOLINE=y. Signed-off-by: Tariq Toukan Reviewed-by: Maxim Mikityanskiy Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 27 ++- .../net/eth

[net-next V2 14/15] net/mlx5e: Do not request completion on every single UMR WQE

From: Tariq Toukan UMR WQEs are posted in bulks, and HW is notified once per a bulk. Reduce the number of completions by requesting such only for the last WQE of the bulk. Signed-off-by: Tariq Toukan Reviewed-by: Maxim Mikityanskiy Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mella

[net-next V2 03/15] net/mlx5: Make MLX5_EN_TLS non-prompt

From: Tariq Toukan TLS runs only over Eth, and the Eth driver is the only user of the core TLS functionality. There is no meaning of having the core functionality without the usage in Eth driver. Hence, let both TLS core implementations depend on MLX5_CORE_EN, and select MLX5_EN_TLS. Signed-off-

[net-next V2 06/15] net/mlx5: Accel, Add core IPsec support for the Connect-X family

From: Raed Salem This to set the base for downstream patches to support the new IPsec implementation of the Connect-X family. Following modifications made: - Remove accel layer dependency from MLX5_FPGA_IPSEC. - Introduce accel_ipsec_ops, each IPsec device will have to support these ops. Sign

[net-next V2 04/15] net/mlx5: E-switch, Avoid function change handler for non ECPF

From: Parav Pandit for non ECPF eswitch manager function, vports are already enabled/disabled when eswitch is enabled/disabled respectively. Simplify function change handler for such eswitch manager function. Therefore, ECPF is the only one which remains PF/VF function change handler. Signed-of

[net-next V2 10/15] net/mlx5e: IPsec: Add Connect-X IPsec Rx data path offload

From: Raed Salem On receive flow inspect received packets for IPsec offload indication using the cqe, for IPsec offloaded packets propagate offload status and stack handle to stack for further processing. Supported statuses: - Offload ok. - Authentication failure. - Bad trailer indication. Conn

[net-next V2 13/15] net/mlx5e: RX, Avoid indirect call in representor CQE handling

From: Tariq Toukan Use INDIRECT_CALL_2() helper to avoid the cost of the indirect call when/if CONFIG_RETPOLINE=y. Signed-off-by: Tariq Toukan Reviewed-by: Maxim Mikityanskiy Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 5 - 1 file changed, 4 insert

[net-next V2 08/15] net/mlx5: Add IPsec related Flow steering entry's fields

From: Huy Nguyen Add FTE actions IPsec ENCRYPT/DECRYPT Add ipsec_obj_id field in FTE Add new action field MLX5_ACTION_IN_FIELD_IPSEC_SYNDROME Signed-off-by: Huy Nguyen Reviewed-by: Raed Salem Signed-off-by: Saeed Mahameed --- include/linux/mlx5/fs.h | 5 - include/linux/mlx5/mlx5_

[net-next V2 07/15] net/mlx5: IPsec: Add HW crypto offload support

From: Raed Salem This patch adds support for Connect-X IPsec crypto offload by implementing the IPsec acceleration layer needed routines, which delegates IPsec offloads to Connect-X routines. In Connect-X IPsec, a Security Association (SA) is added or deleted via allocating a HW context of an en

[net-next V2 11/15] net/mlx5e: IPsec: Add Connect-X IPsec ESN update offload support

From: Raed Salem Synchronize offloading device ESN with xfrm received SN by updating an existing IPsec HW context with the new SN. Signed-off-by: Raed Salem Reviewed-by: Boris Pismenny Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/accel/ipsec_offload.c | 88 +++ 1

[net-next V2 05/15] net/mlx5: E-switch, Reduce dependency on num_vfs during mode set

From: Parav Pandit Currently only ECPF allows enabling eswitch when SR-IOV is disabled. Enable PF also to enable eswitch when SR-IOV is disabled. Load VF vports when eswitch is already enabled. Signed-off-by: Parav Pandit Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- drivers/net/

[pull request][net-next V2 00/15] mlx5 updates 2020-07-16

Hi Dave, Jakub, This patchset includes mlx5 RX XFRM ipsec offloads for ConnectX devices and some other misc updates and fixes to net-next. v1->v2: - Fix "was not declared" build warning when RETPOLINE=y, reported by Jakub. For more information please see tag log below. Please pull and let me

[net-next V2 02/15] net/mlx5e: Fix build break when CONFIG_XPS is not set

mlx5e_accel_sk_get_rxq is only used in ktls_rx.c file which already depends on XPS to be compiled, move it from the generic en_accel.h header to be local in ktls_rx.c, to fix the below build break In file included from ../drivers/net/ethernet/mellanox/mlx5/core/en_main.c:49:0: ../drivers/net/ether

[net-next V2 01/15] net/mlx5e: Fix missing switch_id for representors

From: Parav Pandit Cited commit in fixes tag missed to set the switch id of the PF and VF ports. Due to this flow cannot be offloaded, a simple command like below fails to offload with below error. tc filter add dev ens2f0np0 parent : prio 1 flower \ dst_mac 00:00:00:00:00:00/00:00:00:00:00

Re: [PATCH net-next 1/3] ptp: add ability to configure duty cycle for periodic output

On 7/16/2020 3:09 PM, Vladimir Oltean wrote: > On Fri, Jul 17, 2020 at 12:49:27AM +0300, Vladimir Oltean wrote: >> On Thu, Jul 16, 2020 at 02:36:45PM -0700, Jacob Keller wrote: >>> >>> >>> On 7/16/2020 2:20 PM, Vladimir Oltean wrote: There are external event timestampers (PHCs with support

Re: [net-next PATCH v2 0/9] Add PRP driver and bug fixes

Hi Murali, thanks for the patches. It seems like at least the first patch addresses a problem which exist in Linus's tree, i.e. Linux 5.8-rc. Could you please separate bug fixes like that out to a new series addressed to the net tree, and add appropriate Fixes tags?

Re: [net-next 12/15] net/mlx5e: XDP, Avoid indirect call in TX flow

On Thu, 16 Jul 2020 14:33:18 -0700 Saeed Mahameed wrote: > From: Tariq Toukan > > Use INDIRECT_CALL_2() helper to avoid the cost of the indirect call > when/if CONFIG_RETPOLINE=y. > > Signed-off-by: Tariq Toukan > Reviewed-by: Maxim Mikityanskiy > Signed-off-by: Saeed Mahameed Are these expe

Re: [PATCH net-next 3/3] net: mscc: ocelot: add support for PTP waveform configuration

On Fri, 17 Jul 2020 00:36:22 +0300 Vladimir Oltean wrote: > which I used for testing until I exposed this into an ioctl. I knew I > forgot to do something, and that was to squash that patch into this one. > So I'll need to send a v2, because otherwise this doesn't apply to > mainline. Please review

Re: [PATCH net-next 0/3] Fully describe the waveform for PTP periodic output

On Fri, 17 Jul 2020 00:20:29 +0300 Vladimir Oltean wrote: > While using the ancillary pin functionality of PTP hardware clocks to > synchronize multiple DSA switches on a board, a need arised to be able > to configure the duty cycle of the master of this PPS hierarchy. > > Also, the PPS master is

[PATCH v2] drivers/net/wan/x25_asy: Fix to make it work

This driver is not working because of problems of its receiving code. This patch fixes it to make it work. When the driver receives an LAPB frame, it should first pass the frame to the LAPB module to process. After processing, the LAPB module passes the data (the packet) back to the driver, the dr

[PATCH net 2/3] net: bcmgenet: test RBUF_ACPI_EN when resuming

When the GENET driver resumes from deep sleep the UMAC_CMD register may not be accessible and therefore should not be accessed from bcmgenet_wol_power_up_cfg() if the GENET has been reset. This commit adds a check of the RBUF_ACPI_EN flag when Wake on Filter is enabled. A clear flag indicates that

[PATCH net 3/3] net: bcmgenet: restore HFB filters on resume

The Hardware Filter Block RAM may not be preserved when the GENET block is reset during a deep sleep, so it is not sufficient to only backup and restore the enables. This commit clears out the HFB block and reprograms the rxnfc rules when the system resumes from a suspended state. To support this

[PATCH net 0/3] net: bcmgenet: fix WAKE_FILTER resume from deep sleep

The WAKE_FILTER logic can only wake the system from the standby power state. However, some systems that include the GENET IP support deeper power saving states and the driver should suspend and resume correctly from those states as well. This commit set squashes a few issues uncovered while testin

[PATCH net 1/3] net: bcmgenet: test MPD_EN when resuming

When the GENET driver resumes from deep sleep the UMAC_CMD register may not be accessible and therefore should not be accessed from bcmgenet_wol_power_up_cfg() if the GENET has been reset. This commit adds a check of the MPD_EN flag when Wake on Magic Packet is enabled. A clear flag indicates that

[PATCH v2 net-next 3/6] net: mvneta: move mvneta_run_xdp after descriptors processing

Move mvneta_run_xdp routine after all descriptor processing. This is a preliminary patch to enable multi-buffers and JUMBO frames support for XDP Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-

[PATCH v2 net-next 5/6] net: mvneta: get rid of skb in mvneta_rx_queue

Remove skb pointer in mvneta_rx_queue data structure since it is no longer used Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index

[PATCH v2 net-next 6/6] net: mvneta: move rxq->left_size on the stack

Allocate rxq->left_size on mvneta_rx_swbm stack since it is used just in sw bm napi_poll Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 29 --- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta

[PATCH v2 net-next 1/6] xdp: introduce xdp_get_shared_info_from_{buff,frame} utility routines

Introduce xdp_get_shared_info_from_{buff,frame} utility routines to get skb_shared_info from xdp buffer/frame pointer. xdp_get_shared_info_from_{buff,frame} will be used to implement xdp multi-buffer support Signed-off-by: Lorenzo Bianconi --- include/net/xdp.h | 15 +++ 1 file chang

[PATCH v2 net-next 4/6] net: mvneta: drop all fragments in XDP_DROP

Release all consumed pages if the eBPF program returns XDP_DROP for XDP multi-buffers Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c

[PATCH v2 net-next 2/6] net: mvneta: move skb build after descriptors processing

Move skb build after all descriptors processing. This is a preliminary patch to enable multi-buffers and JUMBO frames support for XDP. Introduce mvneta_xdp_put_buff routine to release all pages used by a XDP multi-buffer Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c |

  1   2   3   4   >