Hello,
syzbot found the following crash on:
HEAD commit:23212a70 Merge branch 'mptcp-add-receive-buffer-auto-tuning'
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=155842d510
kernel config: https://syzkaller.appspot.com/x/.config?x=829871134ca5e230
das
When transmitting data from upper layers or from AF_PACKET sockets,
this driver will first remove a pseudo header of 1 byte,
then the lapb module will prepend the LAPB header of 2 or 3 bytes,
then this driver will prepend a length field of 2 bytes,
then the underlying Ethernet device will p
This patch populates a database of idlechk tests (registers and
predicates) and performs the idlechk using this data.
Signed-off-by: Sudarsana Reddy Kalluru
---
drivers/net/ethernet/broadcom/bnx2x/Makefile |2 +-
drivers/net/ethernet/broadcom/bnx2x/bnx2x.h| 10 +-
drivers/net
Idlechk test verifies that the chip is in idle state. If there are any
errors, Idlechk dump would capture the same. This data will help in
debugging the device related issues.
The patch series adds driver support for dumping IdleChk data during the
debug dump collection.
Patch (1) adds register def
The patch adds driver changes to perform Idlechk dump during the debug
data collection.
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Igor Russkikh
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/net/ethernet/broa
The patch adds register definitions required for Idlechk implementation.
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Igor Russkikh
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_reg.h | 78 -
1 file changed, 76 insertions(+), 2 deletions(-)
diff --git a/drivers
Hi Edward,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Edward-Cree/sfc_ef100-driver-for-EF100-family-NICs-part-1/20200703-233750
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net
> -Original Message-
> From: David Miller
> Sent: Saturday, July 4, 2020 1:34 AM
> To: Sudarsana Reddy Kalluru
> Cc: netdev@vger.kernel.org; Ariel Elior ; Igor Russkikh
> ; Michal Kalderon
> Subject: [EXT] Re: [PATCH net-next v2 2/4] bnx2x: Populate database for
> Idlechk tests.
>
> Ext
On 2020/07/04 5:26, Toke Høiland-Jørgensen wrote:
...
+/* A getter for the SKB protocol field which will handle VLAN tags consistently
+ * whether VLAN acceleration is enabled or not.
+ */
+static inline __be16 skb_protocol(const struct sk_buff *skb, bool skip_vlan)
+{
+ unsigned int offset
Hi Edward,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Edward-Cree/sfc_ef100-driver-for-EF100-family-NICs-part-1/20200703-233750
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net
On Fri, Jul 03, 2020 at 03:41:12PM -0700, Randy Dunlap wrote:
> Drop the doubled word "in".
>
> Signed-off-by: Randy Dunlap
> Cc: Jonathan Corbet
> Cc: linux-...@vger.kernel.org
> Cc: "David S. Miller"
> Cc: Jakub Kicinski
> Cc: netdev@vger.kernel.org
> Cc: Andrew Lunn
> Cc: Vivien Didelot
>
On Fri, Jul 3, 2020 at 4:37 PM Jakub Kicinski wrote:
>
> On Fri, 3 Jul 2020 03:19:45 -0400 Michael Chan wrote:
> > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> > b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> > index 6c90a94..0edb692 100644
> > --- a/drivers/net/ethernet/broadcom/bnxt
Hi David,
The following pull-request contains BPF updates for your *net-next* tree.
We've added 73 non-merge commits during the last 17 day(s) which contain
a total of 106 files changed, 5233 insertions(+), 1283 deletions(-).
The main changes are:
1) bpftool ability to show PIDs of processes ha
From: Eric Dumazet
Whenever ip_set_alloc() is used, allocated memory can either
use kmalloc() or vmalloc(). We should call kvfree() or
ip_set_free()
invalid opcode: [#1] PREEMPT SMP KASAN
CPU: 0 PID: 21935 Comm: syz-executor.3 Not tainted 5.8.0-rc2-syzkaller #0
Hardware name: Google Google
Hi,
The following patchset contains Netfilter fixes for net:
1) Use kvfree() to release vmalloc()'ed areas in ipset, from Eric Dumazet.
2) UAF in nfnetlink_queue from the nf_conntrack_update() path.
Please, pull these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git
__nf_conntrack_update() might refresh the conntrack object that is
attached to the skbuff. Otherwise, this triggers UAF.
[ 633.200434]
==
[ 633.200472] BUG: KASAN: use-after-free in nf_conntrack_update+0x34e/0x770
[nf_conntrack]
[
On Tue, Jun 23, 2020 at 04:09:02PM -0700, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski
>
> Fixes two issues with NO_SHARED_LIBS:
> - #include is ifdef'ed out and thus dlclose()
>triggers an undeclared function compiler warning
> - dlreg_add() is unused and thus triggers an unused
On Fri, Jul 03, 2020 at 01:18:43PM +0200, Toke Høiland-Jørgensen wrote:
> > The user mode driver will load BPF Type Formats, create BPF maps, populate
> > BPF
> > maps, load two BPF programs, attach them to BPF iterators, and finally send
> > two
> > bpf_link IDs back to the kernel.
> > The kerne
Hi Gaurav,
On Wed, Jun 24, 2020 at 10:36:25PM -0400, Gaurav Singh wrote:
> ah cannot be NULL since its already checked above after
> assignment and is being dereferenced before in pr().
> Remove the redundant null check.
Could you collapse all your patches into one?
They look like the same logic
On Thu, Jul 02, 2020 at 08:34:17PM -0700, Linus Torvalds wrote:
> On Thu, Jul 2, 2020 at 7:35 PM Alexei Starovoitov
> wrote:
> >
> > On Thu, Jul 02, 2020 at 06:05:29PM -0700, Linus Torvalds wrote:
> > > On Thu, Jul 2, 2020 at 1:03 PM Alexei Starovoitov
> > > wrote:
> > > >
> > > > The BPF program
From: David Miller
Date: Fri, 03 Jul 2020 12:59:33 -0700 (PDT)
> From: Alexander Lobakin
> Date: Fri, 3 Jul 2020 12:02:58 +0300
>
> > When generating debug dump, driver firstly collects all data in binary
> > form, and then performs per-feature formatting to human-readable if it
> > is supp
On Fri, 3 Jul 2020 06:27:31 +0300 Moshe Shemesh wrote:
> Implement support for devlink health reporters on per-port basis. First
> part in the series prepares common functions parts for health reporter
> implementation. Second introduces required API to devlink-health and
> mlx5e ones demonstrate
On Fri, 3 Jul 2020 03:19:44 -0400 Michael Chan wrote:
> + if (bp->flags & BNXT_FLAG_CHIP_P5) {
> + return (bp->rx_nr_rings + BNXT_RSS_TABLE_ENTRIES_P5 - 1) &
> +~(BNXT_RSS_TABLE_ENTRIES_P5 - 1);
> + }
ALIGN() here as well?
On Fri, 3 Jul 2020 03:19:45 -0400 Michael Chan wrote:
> With the new infrastructure in place, we can now support the setting of
> the indirection table from ethtool.
>
> When changing channels, in a rare case that firmware cannot reserve the
> rings that were promised, the RSS map will revert to
Hello,
syzbot found the following crash on:
HEAD commit:aab20039 Add linux-next specific files for 20200701
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=17a00a5b10
kernel config: https://syzkaller.appspot.com/x/.config?x=739f6fbf326049f4
dashboard
Hello,
syzbot found the following crash on:
HEAD commit:cd77006e Merge tag 'hyperv-fixes-signed' of git://git.kern..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=134c490f10
kernel config: https://syzkaller.appspot.com/x/.config?x=7be693511b29b338
das
Drop the doubled word "have".
Signed-off-by: Randy Dunlap
Cc: Jonathan Corbet
Cc: linux-...@vger.kernel.org
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: netdev@vger.kernel.org
Cc: David Howells
Cc: linux-...@lists.infradead.org
---
Documentation/networking/rxrpc.rst |2 +-
1 file changed
Drop the doubled word "to".
Signed-off-by: Randy Dunlap
Cc: Jonathan Corbet
Cc: linux-...@vger.kernel.org
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: netdev@vger.kernel.org
---
Documentation/networking/arcnet.rst |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-202007
Drop all duplicated words in Documentation/networking/ files.
Cc: Jonathan Corbet
Cc: linux-...@vger.kernel.org
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: netdev@vger.kernel.org
Cc: Ralf Baechle
Cc: linux-h...@vger.kernel.org
Cc: Wolfgang Grandegger
Cc: Marc Kleine-Budde
Cc: linux-...@vger
Drop the doubled word "that".
Signed-off-by: Randy Dunlap
Cc: Jonathan Corbet
Cc: linux-...@vger.kernel.org
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: netdev@vger.kernel.org
---
Documentation/networking/ip-sysctl.rst |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-2
Drop the doubled word "that".
Signed-off-by: Randy Dunlap
Cc: Jonathan Corbet
Cc: linux-...@vger.kernel.org
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: netdev@vger.kernel.org
---
Documentation/networking/ipvs-sysctl.rst |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next
Drop the doubled word "and".
Signed-off-by: Randy Dunlap
Cc: Jonathan Corbet
Cc: linux-...@vger.kernel.org
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: netdev@vger.kernel.org
Cc: Ralf Baechle
Cc: linux-h...@vger.kernel.org
---
Documentation/networking/ax25.rst |2 +-
1 file changed, 1 in
Drop the doubled word "in".
Signed-off-by: Randy Dunlap
Cc: Jonathan Corbet
Cc: linux-...@vger.kernel.org
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: netdev@vger.kernel.org
Cc: Andrew Lunn
Cc: Vivien Didelot
Cc: Florian Fainelli
---
Documentation/networking/dsa/dsa.rst |2 +-
1 file c
Drop the doubled words "the" and "of".
Signed-off-by: Randy Dunlap
Cc: Jonathan Corbet
Cc: linux-...@vger.kernel.org
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: netdev@vger.kernel.org
Cc: Wolfgang Grandegger
Cc: Marc Kleine-Budde
Cc: linux-...@vger.kernel.org
---
Documentation/networking/c
On 7/3/20 10:48 PM, Lorenzo Bianconi wrote:
On 6/30/20 2:49 PM, Lorenzo Bianconi wrote:
[...]
[...]
old_rcpu = xchg(&cmap->cpu_map[key_cpu], rcpu);
if (old_rcpu) {
+ if (old_rcpu->prog)
+ bpf_prog_put(old_rcpu->prog);
call_rc
On 7/3/20 10:26 PM, Toke Høiland-Jørgensen wrote:
There are a couple of places in net/sched/ that check skb->protocol and act
on the value there. However, in the presence of VLAN tags, the value stored
in skb->protocol can be inconsistent based on whether VLAN acceleration is
enabled. The commit
From: Matteo Croce
Date: Thu, 2 Jul 2020 16:12:39 +0200
> From: Matteo Croce
>
> From: Matteo Croce
>
> Add XDP support to mvpp2. This series converts the driver to the
> page_pool API for RX buffer management, and adds native XDP support.
>
> XDP support comes with extack error reporting a
From: Tanner Love
Date: Fri, 3 Jul 2020 14:53:06 -0400
> From: tannerlove
>
> Add the options --ipv4, --ipv6 to specify running over ipv4 and/or
> ipv6. If neither is specified, then run both.
>
> Signed-off-by: Tanner Love
> Acked-by: Willem de Bruijn
Applied.
From: Alex Elder
Date: Fri, 3 Jul 2020 16:23:33 -0500
> The function ipa_reg_init_hol_block_timer_val() generates the value
> to write into the HOL_BLOCK_TIMER endpoint configuration register,
> to represent a given timeout value (in microseconds). It only
> supports a timer value of 0 though,
From: Toke Høiland-Jørgensen
Date: Fri, 3 Jul 2020 22:26:43 +0200
> There are a couple of places in net/sched/ that check skb->protocol and act
> on the value there. However, in the presence of VLAN tags, the value stored
> in skb->protocol can be inconsistent based on whether VLAN acceleration
From: Willem de Bruijn
Date: Fri, 3 Jul 2020 16:43:08 -0400
> From: Willem de Bruijn
>
> IPv6 ping sockets route based on fwmark, but do not yet set skb->mark.
> Add this. IPv4 ping sockets also do both.
>
> Signed-off-by: Willem de Bruijn
Applied, thank you.
On 7/3/20 8:17 PM, Song Liu wrote:
selftests/bpf shows compilation error as
libbpf: invalid relo for 'entries' in special section 0xfff2; forgot to
initialize global var?..
Fix it by initializing 'entries' to zeros.
Fixes: c7568114bc56 ("selftests/bpf: Add bpf_iter test with
bpf_get_tas
For IPA v4.2, the exact interpretation of the register that defines
the timeout for avoiding head-of-line blocking was a little unclear.
We're only assigning a 0 timeout to it right now, so that wasn't
very important. But now that I know how it's supposed to work, I'm
fixing it.
The register repr
Create a new function that returns the current rate of the IPA core
clock.
Signed-off-by: Alex Elder
---
drivers/net/ipa/ipa_clock.c | 6 ++
drivers/net/ipa/ipa_clock.h | 8
2 files changed, 14 insertions(+)
diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c
ind
The function ipa_reg_init_hol_block_timer_val() generates the value
to write into the HOL_BLOCK_TIMER endpoint configuration register,
to represent a given timeout value (in microseconds). It only
supports a timer value of 0 though, in part because that's
sufficient, but mainly because there was s
On 7/3/20 6:31 AM, John Fastabend wrote:
Fix segfault from bpftool by adding emit_obj_refs_plain when skeleton
code is disabled.
Tested by deleting BUILD_BPF_SKELS in Makefile. We found this doing
backports for Cilium when a testing image pulled in latest bpf-next
bpftool, but kept using an olde
> On 6/30/20 2:49 PM, Lorenzo Bianconi wrote:
> [...]
[...]
> > old_rcpu = xchg(&cmap->cpu_map[key_cpu], rcpu);
> > if (old_rcpu) {
> > + if (old_rcpu->prog)
> > + bpf_prog_put(old_rcpu->prog);
> > call_rcu(&old_rcpu->rcu, __cpu_map_entry_free);
> >
From: Willem de Bruijn
IPv6 ping sockets route based on fwmark, but do not yet set skb->mark.
Add this. IPv4 ping sockets also do both.
Signed-off-by: Willem de Bruijn
---
net/ipv6/ping.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv6/ping.c b/net/ipv6/ping.c
index 98ac32b49d8c..
There are a couple of places in net/sched/ that check skb->protocol and act
on the value there. However, in the presence of VLAN tags, the value stored
in skb->protocol can be inconsistent based on whether VLAN acceleration is
enabled. The commit quoted in the Fixes tag below fixed the users of
skb
Roman Mashak writes:
> Toke Høiland-Jørgensen writes:
>
>
> [...]
>
>> +/* A getter for the SKB protocol field which will handle VLAN tags
>> consistently
>> + * whether VLAN acceleration is enabled or not.
>> + */
>> +static inline __be16 skb_protocol(const struct sk_buff *skb, bool skip_vlan)
Toke Høiland-Jørgensen writes:
[...]
> +/* A getter for the SKB protocol field which will handle VLAN tags
> consistently
> + * whether VLAN acceleration is enabled or not.
> + */
> +static inline __be16 skb_protocol(const struct sk_buff *skb, bool skip_vlan)
> +{
> + unsigned int offset =
Cong Wang writes:
> On Fri, Jul 3, 2020 at 8:22 AM Toke Høiland-Jørgensen wrote:
>> diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
>> index b05e855f1ddd..d0c1cb0d264d 100644
>> --- a/include/linux/if_vlan.h
>> +++ b/include/linux/if_vlan.h
>> @@ -308,6 +308,35 @@ static inline bo
From: David Miller
Date: Fri, 03 Jul 2020 13:03:07 -0700 (PDT)
> From: Sudarsana Reddy Kalluru
> Date: Fri, 3 Jul 2020 17:39:48 +0530
>
>> +/* struct holding the database of self test checks (registers and
>> predicates) */
>> +/* lines start from 2 since line 1 is heading in csv */
>> +#defin
From: Sudarsana Reddy Kalluru
Date: Fri, 3 Jul 2020 17:39:48 +0530
> +/* struct holding the database of self test checks (registers and
> predicates) */
> +/* lines start from 2 since line 1 is heading in csv */
> +#define ST_DB_LINES 468
> +struct st_record st_database[ST_DB_LINES] = {
This wi
From: Alexander Lobakin
Date: Fri, 3 Jul 2020 12:02:58 +0300
> When generating debug dump, driver firstly collects all data in binary
> form, and then performs per-feature formatting to human-readable if it
> is supported.
> The size of the new formatted data is often larger than the raw's. This
From: Michael Chan
Date: Fri, 3 Jul 2020 03:19:39 -0400
> This patchset implements ethtool -X to setup user-defined RSS indirection
> table. The new infrastructure also allows the proper logical ring index
> to be used to populate the RSS indirection when queried by ethtool -x.
> Prior to these
Hi Edward,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Edward-Cree/sfc_ef100-driver-for-EF100-family-NICs-part-1/20200703-233750
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net
From: Daniel Drown
Date: Fri, 3 Jul 2020 01:22:34 -0500
> This adds kernel TX timestamps to the xen-netfront driver. Tested with chrony
> on an AWS EC2 instance.
>
> Signed-off-by: Daniel Drown
Applied, thanks.
From: Florian Fainelli
Date: Thu, 2 Jul 2020 21:57:00 -0700
> The GENET driver interfaces with internal MoCA interface as well as
> external MoCA chips like the BCM6802/6803 through a fixed link
> interface. It is desirable for the mocad user-space daemon to be able to
> control the carrier stat
From: Saeed Mahameed
Date: Thu, 2 Jul 2020 21:08:20 -0700
> This series adds misc updates.
> For more information please see tag log below.
>
> Please pull and let me know if there is any problem.
Pulled, thank you.
On Fri, Jul 3, 2020 at 8:22 AM Toke Høiland-Jørgensen wrote:
> diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
> index b05e855f1ddd..d0c1cb0d264d 100644
> --- a/include/linux/if_vlan.h
> +++ b/include/linux/if_vlan.h
> @@ -308,6 +308,35 @@ static inline bool eth_type_vlan(__be16 eth
From: tannerlove
Add the options --ipv4, --ipv6 to specify running over ipv4 and/or
ipv6. If neither is specified, then run both.
Signed-off-by: Tanner Love
Acked-by: Willem de Bruijn
---
tools/testing/selftests/net/rxtimestamp.c | 85 ---
1 file changed, 59 insertions(+),
Size is read from a dma region as input from device. Add sanity
check of size before calling dma_sync_single_range_for_cpu
with it.
This would prevent DMA-API warning: device driver tries to sync DMA
memory it has not allocated.
Signed-off-by: Zekun Shen
---
drivers/net/ethernet/intel/fm10k/fm1
selftests/bpf shows compilation error as
libbpf: invalid relo for 'entries' in special section 0xfff2; forgot to
initialize global var?..
Fix it by initializing 'entries' to zeros.
Fixes: c7568114bc56 ("selftests/bpf: Add bpf_iter test with
bpf_get_task_stack()")
Reported-by: Jesper Dangaar
On Fri, 3 Jul 2020 06:15:09 + Saeed Mahameed wrote:
> > > To read mcast counter we need to execute FW command which is
> > > blocking,
> > > we can't block in atomic context .ndo_get_stats64 :( .. we have to
> > > count in SW.
> > >
> > > the previous approach wasn't accurate as we read the m
On Fri, Jul 03, 2020 at 06:19:51PM +0800, wenxu wrote:
>
> On 7/3/2020 8:47 AM, Marcelo Ricardo Leitner wrote:
> > On Thu, Jul 02, 2020 at 02:39:07PM -0700, Cong Wang wrote:
> >> On Thu, Jul 2, 2020 at 10:32 AM Marcelo Ricardo Leitner
> >> wrote:
> >>> On Thu, Jul 02, 2020 at 05:36:38PM +0800, we
Hi Edward,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Edward-Cree/sfc_ef100-driver-for-EF100-family-NICs-part-1/20200703-233750
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net
Signed-off-by: kernel test robot
---
ef100_netdev.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/sfc/ef100_netdev.c
b/drivers/net/ethernet/sfc/ef100_netdev.c
index 356938104cb27..8e23ffed3f0ec 100644
--- a/drivers/net/ethernet/sfc/ef100_netdev
On Fri, 3 Jul 2020 15:25:04 +0200 Andre Edich wrote:
> The patchset fixes two problems in the function smsc95xx_bind:
> - return of false success
> - memory leak
Could you add Fixes tags to both patches?
On Fri, 3 Jul 2020 16:31:33 +0100 Edward Cree wrote:
> No TX or RX path, no MCDI, not even an ifup/down handler.
> Besides stubs, the bulk of the patch deals with reading the Xilinx
> extended PCIe capability, which tells us where to find our BAR.
>
> Signed-off-by: Edward Cree
Warnings:
drive
In a case where the ID_REV register read is failed, the memory for a
private data structure has to be freed before returning error from the
function smsc95xx_bind.
Signed-off-by: Andre Edich
Signed-off-by: Parthiban Veerasooran
---
drivers/net/usb/smsc95xx.c | 3 ++-
1 file changed, 2 insertion
The return value of the function smsc95xx_reset() must be checked
to avoid returning false success from the function smsc95xx_bind().
Signed-off-by: Andre Edich
Signed-off-by: Parthiban Veerasooran
---
drivers/net/usb/smsc95xx.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/
The patchset fixes two problems in the function smsc95xx_bind:
- return of false success
- memory leak
Andre Edich (2):
smsc95xx: check return value of smsc95xx_reset
smsc95xx: avoid memory leak in smsc95xx_bind
drivers/net/usb/smsc95xx.c | 9 -
1 file changed, 8 insertions(+), 1 d
rwlock.h should not be included directly. Instead linux/splinlock.h
should be included. Including it directly will break the RT build.
Fixes: 549c243e4e010 ("net/mlx5e: Extract neigh-specific code from en_rep.c to
rep/neigh.c")
Signed-off-by: Sebastian Andrzej Siewior
---
It would be nice if thi
On 7/1/20, Vaibhav Gupta wrote:
> With legacy PM, drivers themselves were responsible for managing the
> device's power states and takes care of register states.
>
> After upgrading to the generic structure, PCI core will take care of
> required tasks and drivers should do only device-specific ope
The RFC 8684 mandates that no-data DATA FIN packets should carry
a DSS with 0 sequence number and data len equal to 1. Currently,
on FIN retransmission we re-use the existing mapping; if the previous
fin transmission was part of a partially acked data packet, we could
end-up writing in the egress p
On Thu, Jul 02, 2020 at 06:00:17PM -0700, Linus Torvalds wrote:
> If somebody is interested in looking into things like that, it might
> be a good idea to have kernel threads with that counter incremented by
> default.
With 67 kthreads on a booted system, this patch does not immediately
blow up...
> On 6/30/20 2:49 PM, Lorenzo Bianconi wrote:
> [...]
[...]
> > + prog = READ_ONCE(rcpu->prog);
>
> What purpose does the READ_ONCE() have here, also given you don't use it in
> above check?
> Since upon map update you realloc, repopulate and then xchg() the rcpu entry
> itself, there
> is n
On Thu, Jul 02, 2020 at 02:55:41PM -0300, Jason Gunthorpe wrote:
> On Tue, Jun 23, 2020 at 02:01:03PM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky
> >
> > >From Michael,
> >
> > This series handles IPoIB child interface creation with setting
> > interface's HW address.
> >
> > In curren
Before can be possible show only all qeueue disciplines on an interface.
There wasn't a way to get the qdisc info by handle or parent, only full
dump of the disciplines with a following grep/sed usage.
Now new and old options work as expected to filter a qdisc by handle or
parent.
Full syntax of
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/ef100_netdev.c | 2 ++
drivers/net/ethernet/sfc/ef100_nic.c| 21 +
2 files changed, 23 insertions(+)
diff --git a/drivers/net/ethernet/sfc/ef100_netdev.c
b/drivers/net/ethernet/sfc/ef100_netdev.c
index 3e4e7241d9a8
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/ef100_nic.c | 40 +++-
drivers/net/ethernet/sfc/ef100_nic.h | 1 +
2 files changed, 40 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/ef100_nic.c
b/drivers/net/ethernet/sfc/ef100_nic.c
index ace
In ef100_reset(), make the MCDI call to do the reset.
Also, do a reset at start-of-day during probe, to put the function in
a clean state.
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/ef100_nic.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/net/ethernet/sfc/ef
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/ef100_nic.c | 42 +++-
1 file changed, 41 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sfc/ef100_nic.c
b/drivers/net/ethernet/sfc/ef100_nic.c
index f449960e5b02..aced682a7b08 100644
--- a/drivers/n
MC_CMD_GET_CAPABILITIES now has a third word of flags; extend the
efx_has_cap() machinery to cover it.
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/ef100_nic.c | 9 -
drivers/net/ethernet/sfc/ef100_nic.h | 1 +
drivers/net/ethernet/sfc/mcdi.h | 4 ++--
3 files changed, 1
Currently RX and TX-completion events are unhandled, as neither the RX
nor the TX path has been implemented yet.
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/ef100_nic.c | 57 +++-
1 file changed, 56 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ether
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/ef100_nic.c | 58 +++-
drivers/net/ethernet/sfc/ef100_nic.h | 2 +
2 files changed, 58 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/sfc/ef100_nic.c
b/drivers/net/ethernet/sfc/ef100_nic.c
index d4
Channels are probed, but actual event handling is still stubbed out.
Stub implementation of check_caps is needed because ptp.c will call into
it from efx_ptp_use_mac_tx_timestamps() to decide if it wants TXQs.
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/ef100_netdev.c | 143 +++
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/ef100_nic.c | 106 +++
drivers/net/ethernet/sfc/ef100_nic.h | 1 +
2 files changed, 107 insertions(+)
diff --git a/drivers/net/ethernet/sfc/ef100_nic.c
b/drivers/net/ethernet/sfc/ef100_nic.c
index 27e00b003039..57
We handle everything ourselves in ef100_reset(), rather than relying on
the generic down/up routines.
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/efx_common.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/sfc/efx_common.c
b/driver
We can't actually do the MCDI to probe it fully until we have working
MCDI, which comes later, but we need efx->phy_data to be allocated so
that when we get MCDI events the link-state change handler doesn't
NULL-dereference.
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/ef100_nic.c
We don't actually do the efx_mcdi_reset() because we don't have MCDI yet.
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/ef100_nic.c | 50
1 file changed, 50 insertions(+)
diff --git a/drivers/net/ethernet/sfc/ef100_nic.c
b/drivers/net/ethernet/sfc/ef100_n
No TX or RX path, no MCDI, not even an ifup/down handler.
Besides stubs, the bulk of the patch deals with reading the Xilinx
extended PCIe capability, which tells us where to find our BAR.
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/Kconfig | 10 +
drivers/net/ethernet/sfc/
EF100 adds a few new valid addresses for efx_writed_page(), as well as
a Function Control Window in the BAR whose location is variable.
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/io.h | 16 +---
drivers/net/ethernet/sfc/net_driver.h | 2 ++
2 files changed, 15
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/ef100_regs.h | 693 ++
1 file changed, 693 insertions(+)
create mode 100644 drivers/net/ethernet/sfc/ef100_regs.h
diff --git a/drivers/net/ethernet/sfc/ef100_regs.h
b/drivers/net/ethernet/sfc/ef100_regs.h
new file
On Fri, Jul 03, 2020 at 08:02:07AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Jul 02, 2020 at 04:26:35PM -0700, Kees Cook wrote:
> > + sattr->battr.size = 3 /* "0x", "\n" */ + (BITS_PER_LONG / 4);
>
> They get a correct "size" value now, nice!
Yeah, though I do have some concerns that s
In order to maintain bisectability while splitting into patches of a
reasonable size, I had to do a certain amount of back-and-forth with
stubs for things that the common code may try to call, mainly because
we can't do them until we've set up MCDI, but we can't set up MCDI
without probing the
There are a couple of places in net/sched/ that check skb->protocol and act
on the value there. However, in the presence of VLAN tags, the value stored
in skb->protocol can be inconsistent based on whether VLAN acceleration is
enabled. The commit quoted in the Fixes tag below fixed the users of
skb
On Thu, Jul 02, 2020 at 06:00:17PM -0700, Linus Torvalds wrote:
> On Thu, Jul 2, 2020 at 4:26 PM Kees Cook wrote:
> >
> > The kprobe show() functions were using "current"'s creds instead
> > of the file opener's creds for kallsyms visibility. Fix to use
> > seq_file->file->f_cred.
>
> Side note:
IPv4 ping sockets don't set fl4.fl4_icmp_{type,code}, which leads to
incomplete IPsec ACQUIRE messages being sent to userspace. Currently,
both raw sockets and IPv6 ping sockets set those fields.
Expected output of "ip xfrm monitor":
acquire proto esp
sel src 10.0.2.15/32 dst 8.8.8.8/32
1 - 100 of 163 matches
Mail list logo
