From: David Miller <da...@davemloft.net>
Date: Fri, 03 Jul 2020 13:03:07 -0700 (PDT)
> From: Sudarsana Reddy Kalluru <skall...@marvell.com>
> Date: Fri, 3 Jul 2020 17:39:48 +0530
>
>> +/* struct holding the database of self test checks (registers and
>> predicates) */
>> +/* lines start from 2 since line 1 is heading in csv */
>> +#define ST_DB_LINES 468
>> +struct st_record st_database[ST_DB_LINES] = {
>
> This will introduce a build warning because there is no external declaration
> for
> this global variable.
>
> A patch series must be fully bisectable, meaning that you can't just
> add this declaration in a future patch in the series. It has to be
> added in the same patch where the symbol is defined.
Actually, looking further, it's even worse.
You mark it global here, and then mark it static in the next patch.
Don't do that please.
