RE: [EXT] Re: [PATCH net-next] net: ethernet: fec: prevent tx starvation under high rx load

2020-06-27 Thread Andy Duan
From: David Miller Sent: Friday, June 26, 2020 3:20 AM > From: Tobias Waldekranz > Date: Thu, 25 Jun 2020 10:57:28 +0200 > > > In the ISR, we poll the event register for the queues in need of > > service and then enter polled mode. After this point, the event > > register will never be read agai

Re: [PATCH] virtio: VIRTIO_F_IOMMU_PLATFORM -> VIRTIO_F_ACCESS_PLATFORM

2020-06-27 Thread Jason Wang
On 2020/6/25 上午6:25, Michael S. Tsirkin wrote: Rename the bit to match latest virtio spec. Add a compat macro to avoid breaking existing userspace. Signed-off-by: Michael S. Tsirkin --- arch/um/drivers/virtio_uml.c | 2 +- drivers/vdpa/ifcvf/ifcvf_base.h| 2 +- drivers/vdpa/vd

KASAN: use-after-free Read in macvlan_dev_get_iflink

2020-06-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:1590a2e1 Merge tag 'acpi-5.8-rc3' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1070059b10 kernel config: https://syzkaller.appspot.com/x/.config?x=20c907630cbdbe5 dash

[iproute2-next] action police: make 'mtu' could be set independently in police action

2020-06-27 Thread Po Liu
Current police action must set 'rate' and 'burst'. 'mtu' parameter set the max frame size and could be set alone without 'rate' and 'burst' in some situation. Offloading to hardware for example, 'mtu' could limit the flow max frame size. Signed-off-by: Po Liu --- tc/m_police.c | 4 ++-- 1 file c

Re: IPv4: Why are sysctl settings of abandoned route cache / GC still around?

2020-06-27 Thread David Miller
From: Oliver Herms Date: Sat, 27 Jun 2020 14:33:30 +0200 > is there a reason sysctl settings like net/ipv4/route/ > - max_size > - gc_thresh > - gc_min_interval > - gc_min_interval_ms > - gc_elasticity > are still around in current kernels? Because otherwise scripts would break. Sysctl is a us

Re: [PATCH] net: ipv4: Fix wrong type conversion from hint to rt in ip_route_use_hint()

2020-06-27 Thread David Miller
From: linmiaohe Date: Sat, 27 Jun 2020 15:47:51 +0800 > From: Miaohe Lin > > We can't cast sk_buff to rtable by (struct rtable *)hint. Use skb_rtable(). > > Fixes: 02b24941619f ("ipv4: use dst hint for ipv4 list receive") > > Signed-off-by: Miaohe Lin Please do not put empty lines between F

Re: [PATCH net-next v3 0/5] hinic: add some ethtool ops support

2020-06-27 Thread luobin (L)
On 2020/6/28 8:52, David Miller wrote: > From: Luo bin > Date: Sat, 27 Jun 2020 14:52:37 +0800 > >> patch #1: support to set and get pause params with >> "ethtool -A/a" cmd >> patch #2: support to set and get irq coalesce params with >> "ethtool -C/c" cmd >> patch #3: support

Re: [PATCH net-next v3 0/5] hinic: add some ethtool ops support

2020-06-27 Thread David Miller
From: Luo bin Date: Sat, 27 Jun 2020 14:52:37 +0800 > patch #1: support to set and get pause params with > "ethtool -A/a" cmd > patch #2: support to set and get irq coalesce params with > "ethtool -C/c" cmd > patch #3: support to do self test with "ethtool -t" cmd > patch #4:

Re: [PATCH net-next 0/4] tcp: improve delivered counts in SCM_TSTAMP_ACK

2020-06-27 Thread David Miller
From: Yousuk Seung Date: Fri, 26 Jun 2020 21:05:31 -0700 > Currently delivered and delivered_ce in OPT_STATS of SCM_TSTAMP_ACK do > not fully reflect the current ack being timestamped. Also they are not > in sync as the delivered count includes packets being sacked and some of > cumulatively acke

Re: [net-next 01/13] igc: Add initial EEE support

2020-06-27 Thread David Miller
From: Jeff Kirsher Date: Fri, 26 Jun 2020 18:54:19 -0700 > +static int igc_ethtool_get_eee(struct net_device *netdev, > +struct ethtool_eee *edata) > +{ > + struct igc_adapter *adapter = netdev_priv(netdev); > + struct igc_hw *hw = &adapter->hw; > + u32 eee

Re: [PATCH net] genetlink: take netlink table lock when (un)registering

2020-06-27 Thread David Miller
From: Sean Tranchetti Date: Fri, 26 Jun 2020 18:31:03 -0600 > @@ -328,6 +325,10 @@ int genl_register_family(struct genl_family *family) > if (err) > return err; > > + /* Acquire netlink table lock before any GENL-specific locks to ensure > + * sync with any netlink

[PATCH v3] net: phylink: correct trivial kernel-doc inconsistencies

2020-06-27 Thread Colton Lewis
Silence documentation build warnings by correcting kernel-doc comments. In the case of pcs_{config,an_restart,link_up}, change the declaration to a normal function since these only there for documentation anyway. ./include/linux/phylink.h:74: warning: Function parameter or member 'poll_fixed_stat

Re: [Patch net] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-06-27 Thread Roman Gushchin
On Fri, Jun 26, 2020 at 10:58:14AM -0700, Cong Wang wrote: > On Thu, Jun 25, 2020 at 10:23 PM Cameron Berkenpas wrote: > > > > Hello, > > > > Somewhere along the way I got the impression that it generally takes > > those affected hours before their systems lock up. I'm (generally) able > > to repr

Re: [Patch net] cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

2020-06-27 Thread Cameron Berkenpas
The box has been up without issue for over 25 hours now. The patch seems solid. On 6/26/20 3:03 PM, Cameron Berkenpas wrote: Box has been up for 25 minutes without issue. Probably the patch works, but I can further confirm by tomorrow. On 6/26/2020 10:58 AM, Cong Wang wrote: On Thu, Jun 25, 2

Re: [net-next 04/15] net/mlx5e: Receive flow steering framework for accelerated TCP flows

2020-06-27 Thread Tom Herbert
On Sat, Jun 27, 2020 at 2:19 PM Saeed Mahameed wrote: > > From: Boris Pismenny > > The framework allows creating flow tables to steer incoming traffic of > TCP sockets to the acceleration TIRs. > This is used in downstream patches for TLS, and will be used in the > future for other offloads. > >

[no subject]

2020-06-27 Thread helen
MONEY-GRAM TRANSFERRED PAYMENT INFO: Below is the sender’s information 1. MG. REFERENCE NO#: 36360857 2. SENDER'S NAME: Johnson Williams 3. AMOUNT TO PICKUP: US$10,000 Go to any Money Gram office near you and pick up the payment Track the Reference Number by visiting and click the link be

[PATCH net-next] 8390: Fix coding-style issues

2020-06-27 Thread Armin Wolf
Fix some coding-style issues, including one which made the function pointers in the struct ei_device hard to understand. Signed-off-by: Armin Wolf --- drivers/net/ethernet/8390/8390.h | 61 +++- 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/drivers/n

[net-next 12/15] net/mlx5e: kTLS, Add kTLS RX stats

2020-06-27 Thread Saeed Mahameed
From: Tariq Toukan Add global and per-channel ethtool SW stats for the device offload. Document the new counters in tls-offload.rst. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- Documentation/networking/tls-offload.rst | 18 + .../mellanox/mlx5/core/en_accel/ktls

[net-next 15/15] net/mlx5e: kTLS, Improve rx handler function call

2020-06-27 Thread Saeed Mahameed
From: Tariq Toukan Prior to this patch mlx5e tls rx handler was called unconditionally on all rx frames and the decision whether a frame is a valid tls record is done inside that function. A function call can be expensive especially for regular rx packet rate. To avoid this, check the tls valid

[net-next 09/15] Revert "net/tls: Add force_resync for driver resync"

2020-06-27 Thread Saeed Mahameed
From: Boris Pismenny This reverts commit b3ae2459f89773adcbf16fef4b68deaaa3be1929. Revert the force resync API. Not in use. To be replaced by a better async resync API downstream. Signed-off-by: Boris Pismenny Signed-off-by: Tariq Toukan Reviewed-by: Maxim Mikityanskiy Signed-off-by: Saeed Ma

[pull request][net-next 00/15] mlx5 tls rx offload 2020-06-26

2020-06-27 Thread Saeed Mahameed
Hi Dave, Jakub This is a re-spin of the previous kernel cycle mlx5 rx tls submission, From Tariq and Boris. Changes from previous iteration: 1) Better handling of error flows in the resyc procedure. 2) An improved TLS device API for Asynchronous Resync to replace "force resync" For this Tariq an

[net-next 03/15] net/mlx5e: API to manipulate TTC rules destinations

2020-06-27 Thread Saeed Mahameed
Store the default destinations of the on-load generated TTC (Traffic Type Classifier) rules in the ttc rules table. Introduce TTC API functions to manipulate/restore and get the TTC rule destination and use these API functions in arfs implementation. This will allow a better decoupling between TT

[net-next 01/15] net/mlx5e: Turn XSK ICOSQ into a general asynchronous one

2020-06-27 Thread Saeed Mahameed
From: Tariq Toukan There is an upcoming demand (in downstream patches) for an ICOSQ to be populated out of the NAPI context, asynchronously. There is already an existing one serving XSK-related use case. In this patch, promote this ICOSQ to serve as general async ICOSQ, to be used for XSK and no

[net-next 02/15] net/mlx5e: Refactor build channel params

2020-06-27 Thread Saeed Mahameed
From: Tariq Toukan Take the CQ params into their respective RQ/SQ params. Split the params build of the different ICOSQs (sync and async), as they require different init values. Signed-off-by: Tariq Toukan Reviewed-by: Maxim Mikityanskiy Signed-off-by: Saeed Mahameed --- .../ethernet/mellano

[net-next 10/15] net/tls: Add asynchronous resync

2020-06-27 Thread Saeed Mahameed
From: Boris Pismenny This patch adds support for asynchronous resynchronization in tls_device. Async resync follows two distinct stages: 1. The NIC driver indicates that it would like to resync on some TLS record within the received packet (P), but the driver does not know (yet) which of the TLS

[net-next 11/15] net/mlx5e: kTLS, Add kTLS RX resync support

2020-06-27 Thread Saeed Mahameed
From: Tariq Toukan Implement the RX resync procedure, using the TLS async resync API. The HW offload of TLS decryption in RX side might get out-of-sync due to out-of-order reception of packets. This requires SW intervention to update the HW context and get it back in-sync. Performance: CPU: Int

[net-next 06/15] net/mlx5e: kTLS, Improve TLS feature modularity

2020-06-27 Thread Saeed Mahameed
From: Tariq Toukan Better separate the code into c/h files, so that kTLS internals are exposed to the corresponding non-accel flow as follows: - Necessary datapath functions are exposed via ktls_txrx.h. - Necessary caps and configuration functions are exposed via ktls.h, which became very small

[net-next 14/15] net/mlx5e: kTLS, Cleanup redundant capability check

2020-06-27 Thread Saeed Mahameed
From: Tariq Toukan All callers of mlx5e_ktls_build_netdev() check capability before the call. Remove the repeated check in the function. Signed-off-by: Tariq Toukan Reviewed-by: Maxim Mikityanskiy Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c | 3 -

[net-next 13/15] net/mlx5e: Increase Async ICO SQ size

2020-06-27 Thread Saeed Mahameed
From: Tariq Toukan Resync communication with HW for kTLS RX is done via the async ICOSQs. kTLS RX resync requests might come in bursts. To improve the success chances for such bursts, use a larger ICOSQ. Signed-off-by: Tariq Toukan Reviewed-by: Maxim Mikityanskiy Signed-off-by: Saeed Mahameed

[net-next 08/15] net/mlx5e: kTLS, Add kTLS RX HW offload support

2020-06-27 Thread Saeed Mahameed
From: Tariq Toukan Implement driver support for the kTLS RX HW offload feature. Resync support is added in a downstream patch. New offload contexts post their static/progress params WQEs over the per-channel async ICOSQ, protected under a spin-lock. The Channel/RQ is selected according to the so

[net-next 04/15] net/mlx5e: Receive flow steering framework for accelerated TCP flows

2020-06-27 Thread Saeed Mahameed
From: Boris Pismenny The framework allows creating flow tables to steer incoming traffic of TCP sockets to the acceleration TIRs. This is used in downstream patches for TLS, and will be used in the future for other offloads. Signed-off-by: Boris Pismenny Signed-off-by: Tariq Toukan Signed-off-

[net-next 07/15] net/mlx5e: kTLS, Use kernel API to extract private offload context

2020-06-27 Thread Saeed Mahameed
From: Tariq Toukan Modify the implementation of the private kTLS TX HW offload context getter and setter, so it uses the kernel API functions, instead of a local shadow structure. A single BUILD_BUG_ON check is sufficient, remove the duplicate. Signed-off-by: Tariq Toukan Reviewed-by: Maxim Mik

[net-next 05/15] net/mlx5e: Accel, Expose flow steering API for rules add/del

2020-06-27 Thread Saeed Mahameed
From: Tariq Toukan Given a socket, the function extracts the TCP/IP{4,6} ntuple and adds rule to steering. Another function gets the rule and deletes it. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed Reviewed-by: Maxim Mikityanskiy --- .../mellanox/mlx5/core/en_accel/fs_tcp.c

Re: KASAN: slab-out-of-bounds Read in qrtr_endpoint_post

2020-06-27 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:1590a2e1 Merge tag 'acpi-5.8-rc3' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14b2b50310 kernel config: https://syzkaller.appspot.com/x/.config?x=bf3aec3

Re: [PATCH mlx5-next 0/3] mlx5 next updates 2020-06-25

2020-06-27 Thread Saeed Mahameed
On Thu, 2020-06-25 at 22:56 -0700, Saeed Mahameed wrote: > This small patchset includes 3 patches to mlx5-next branch. > > 1) Include directives cleanup from Parav. > 2) TLS Hardware layouts improvements from Tariq. > > Thanks, > Saeed. > Series applied

Re: [PATCH net-next 1/2] mlxsw: core: Add ethtool support for QSFP-DD transceivers

2020-06-27 Thread Adrian Pop
> > Hi Adrian, Andrew, > > Not sure I understand... You want the kernel to always pass page 03h to > user space (potentially zeroed)? Page 03h is not mandatory according to > the standard and page 01h contains information if page 03h is present or Hi Ido! Andrew was thinking of having 03h after 0

possible deadlock in dev_mc_sync

2020-06-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:4a21185c Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=105b374d10 kernel config: https://syzkaller.appspot.com/x/.config?x=bf3aec367b9ab569 dashboar

Re: [PATCH v3 bpf-next 2/4] bpf: introduce helper bpf_get_task_stack()

2020-06-27 Thread Andrii Nakryiko
On Fri, Jun 26, 2020 at 5:29 PM Song Liu wrote: > > Introduce helper bpf_get_task_stack(), which dumps stack trace of given > task. This is different to bpf_get_stack(), which gets stack track of > current task. One potential use case of bpf_get_task_stack() is to call > it from bpf_iter__task and

Re: [PATCH v3 bpf-next 1/4] perf: expose get/put_callchain_entry()

2020-06-27 Thread Andrii Nakryiko
On Fri, Jun 26, 2020 at 5:26 PM Song Liu wrote: > > Sanitize and expose get/put_callchain_entry(). This would be used by bpf > stack map. > > Suggested-by: Peter Zijlstra > Signed-off-by: Song Liu > --- Acked-by: Andrii Nakryiko > include/linux/perf_event.h | 2 ++ > kernel/events/callchain

Re: [PATCH bpf-next 07/10] bpf: selftests: Restore netns after each test

2020-06-27 Thread Andrii Nakryiko
On Fri, Jun 26, 2020 at 5:23 PM Martin KaFai Lau wrote: > > On Fri, Jun 26, 2020 at 03:45:04PM -0700, Andrii Nakryiko wrote: > > On Fri, Jun 26, 2020 at 10:56 AM Martin KaFai Lau wrote: > > > > > > It is common for networking tests creating its netns and making its own > > > setting under this ne

Re: [PATCH net-next 1/2] mlxsw: core: Add ethtool support for QSFP-DD transceivers

2020-06-27 Thread Ido Schimmel
On Fri, Jun 26, 2020 at 11:13:42PM +0100, Adrian Pop wrote: > > You are saying pages 00h, 01h and 02h are mandatory for QSPF-DD. Page > > 03h is optional, but when present, it seems to contain what is page > > 02h above. Since the QSPF KAPI has it, QSPF-DD KAPI should also have > > it. So i would

Re: [PATCH net] genetlink: take netlink table lock when (un)registering

2020-06-27 Thread Cong Wang
On Fri, Jun 26, 2020 at 5:32 PM Sean Tranchetti wrote: > > A potential deadlock can occur during registering or unregistering a new > generic netlink family between the main nl_table_lock and the cb_lock where > each thread wants the lock held by the other, as demonstrated below. > > 1) Thread 1 i

Re: possible deadlock in dev_mc_unsync

2020-06-27 Thread Cong Wang
#syz test: https://github.com/congwang/linux.git net

Re: ADQ - comparison to aRFS, clarifications on NAPI ID, binding with busy-polling

2020-06-27 Thread Tom Herbert
On Wed, Jun 24, 2020 at 1:21 PM Samudrala, Sridhar wrote: > > > > On 6/17/2020 6:15 AM, Maxim Mikityanskiy wrote: > > Hi, > > > > I discovered Intel ADQ feature [1] that allows to boost performance by > > picking dedicated queues for application traffic. We did some research, > > and I got some le

Re: [PATCH 1/4] fix trailing */ in block comment

2020-06-27 Thread Coiby Xu
On Sat, Jun 27, 2020 at 12:47:08PM +0200, Greg Kroah-Hartman wrote: On Sat, Jun 27, 2020 at 06:14:44PM +0800, Coiby Xu wrote: Remove trailing "*/" in block comments. Signed-off-by: Coiby Xu The subject lines of all of your patches should match other patches for this driver. It should look l

[PATCH v2 4/4] staging: qlge: replace pr_err with netdev_err

2020-06-27 Thread Coiby Xu
Replace all pr_errs with netdev_err. Suggested-by: Joe Perches Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_dbg.c | 568 1 file changed, 289 insertions(+), 279 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c

[PATCH v2 3/4] staging: qlge: fix ql_sem_unlock

2020-06-27 Thread Coiby Xu
Some functions return without releasing the lock. Replace return with break. Suggested-by Dan Carpenter . Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_dbg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/

[PATCH v2 1/4] staging: qlge: fix trailing */ in block comment

2020-06-27 Thread Coiby Xu
Remove trailing "*/" in block comments. Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_main.c | 3 ++- drivers/staging/qlge/qlge_mpi.c | 10 ++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c inde

[PATCH v2 2/4] staging: qlge: fix else after return or break

2020-06-27 Thread Coiby Xu
Remove unnecessary elses after return or break. Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_dbg.c | 23 ++- drivers/staging/qlge/qlge_main.c | 8 drivers/staging/qlge/qlge_mpi.c | 4 ++-- 3 files changed, 16 insertions(+), 19 deletions(-) diff --git a/

[PATCH ghak90 V9 13/13] audit: add capcontid to set contid outside init_user_ns

2020-06-27 Thread Richard Guy Briggs
Provide a mechanism similar to CAP_AUDIT_CONTROL to explicitly give a process in a non-init user namespace the capability to set audit container identifiers of individual children. Provide the /proc/$PID/audit_capcontid interface to capcontid. Valid values are: 1==enabled, 0==disabled Writing a "

[PATCH ghak90 V9 10/13] audit: add support for containerid to network namespaces

2020-06-27 Thread Richard Guy Briggs
This also adds support to qualify NETFILTER_PKT records. Audit events could happen in a network namespace outside of a task context due to packets received from the net that trigger an auditing rule prior to being associated with a running task. The network namespace could be in use by multiple c

[PATCH ghak90 V9 11/13] audit: contid check descendancy and nesting

2020-06-27 Thread Richard Guy Briggs
Require the target task to be a descendant of the container orchestrator/engine. You would only change the audit container ID from one set or inherited value to another if you were nesting containers. If changing the contid, the container orchestrator/engine must be a descendant and not same orch

[PATCH ghak90 V9 12/13] audit: track container nesting

2020-06-27 Thread Richard Guy Briggs
Track the parent container of a container to be able to filter and report nesting. Now that we have a way to track and check the parent container of a container, modify the contid field format to be able to report that nesting using a carrat ("^") modifier to indicate nesting. The original field

[PATCH ghak90 V9 09/13] audit: add containerid filtering

2020-06-27 Thread Richard Guy Briggs
Implement audit container identifier filtering using the AUDIT_CONTID field name to send an 8-character string representing a u64 since the value field is only u32. Sending it as two u32 was considered, but gathering and comparing two fields was more complex. The feature indicator is AUDIT_FEATUR

[PATCH ghak90 V9 08/13] audit: add containerid support for user records

2020-06-27 Thread Richard Guy Briggs
Add audit container identifier auxiliary record to user event standalone records. Signed-off-by: Richard Guy Briggs Acked-by: Neil Horman Reviewed-by: Ondrej Mosnacek --- kernel/audit.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/kernel/audit.c b/ke

[PATCH ghak90 V9 07/13] audit: add support for non-syscall auxiliary records

2020-06-27 Thread Richard Guy Briggs
Standalone audit records have the timestamp and serial number generated on the fly and as such are unique, making them standalone. This new function audit_alloc_local() generates a local audit context that will be used only for a standalone record and its auxiliary record(s). The context is disca

[PATCH ghak90 V9 05/13] audit: log container info of syscalls

2020-06-27 Thread Richard Guy Briggs
Create a new audit record AUDIT_CONTAINER_ID to document the audit container identifier of a process if it is present. Called from audit_log_exit(), syscalls are covered. Include target_cid references from ptrace and signal. A sample raw event: type=SYSCALL msg=audit(1519924845.499:257): arch=c0

[PATCH ghak90 V9 06/13] audit: add contid support for signalling the audit daemon

2020-06-27 Thread Richard Guy Briggs
Add audit container identifier support to the action of signalling the audit daemon. Since this would need to add an element to the audit_sig_info struct, a new record type AUDIT_SIGNAL_INFO2 was created with a new audit_sig_info2 struct. Corresponding support is required in the userspace code to

[PATCH ghak90 V9 02/13] audit: add container id

2020-06-27 Thread Richard Guy Briggs
Implement the proc fs write to set the audit container identifier of a process, emitting an AUDIT_CONTAINER_OP record to document the event. This is a write from the container orchestrator task to a proc entry of the form /proc/PID/audit_containerid where PID is the process ID of the newly created

[PATCH ghak90 V9 00/13] audit: implement container identifier

2020-06-27 Thread Richard Guy Briggs
Implement kernel audit container identifier. This patchset is an eighth based on the proposal document (V4) posted: https://www.redhat.com/archives/linux-audit/2019-September/msg00052.html The first patch was the last patch from ghak81 that was absorbed into this patchset since its primar

[PATCH ghak90 V9 04/13] audit: log drop of contid on exit of last task

2020-06-27 Thread Richard Guy Briggs
Since we are tracking the life of each audit container indentifier, we can match the creation event with the destruction event. Log the destruction of the audit container identifier when the last process in that container exits. Signed-off-by: Richard Guy Briggs --- kernel/audit.c | 20 ++

[PATCH ghak90 V9 03/13] audit: read container ID of a process

2020-06-27 Thread Richard Guy Briggs
Add support for reading the audit container identifier from the proc filesystem. This is a read from the proc entry of the form /proc/PID/audit_containerid where PID is the process ID of the task whose audit container identifier is sought. The read expects up to a u64 value (unset: 18446744073709

[PATCH ghak90 V9 01/13] audit: collect audit task parameters

2020-06-27 Thread Richard Guy Briggs
The audit-related parameters in struct task_struct should ideally be collected together and accessed through a standard audit API. Collect the existing loginuid, sessionid and audit_context together in a new struct audit_task_info called "audit" in struct task_struct. Use kmem_cache to manage thi

Re: possible deadlock in dev_mc_unsync

2020-06-27 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:4a21185c Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=12e8e9c510 kernel config: https://syzkaller.appspot.com/x/.config?x=bf3aec367b9a

IPv4: Why are sysctl settings of abandoned route cache / GC still around?

2020-06-27 Thread Oliver Herms
Hi list, is there a reason sysctl settings like net/ipv4/route/ - max_size - gc_thresh - gc_min_interval - gc_min_interval_ms - gc_elasticity are still around in current kernels? I find this just confusing and misleading. If there are no concerns I'd like to remove those. I have a patch ready.

[PATCH net-next] net: mscc: ocelot: remove EXPORT_SYMBOL from ocelot_net.c

2020-06-27 Thread Vladimir Oltean
From: Vladimir Oltean Now that all net_device operations are bundled together inside mscc_ocelot.ko and no longer part of the common library, there's no reason to export these symbols. Signed-off-by: Vladimir Oltean --- drivers/net/ethernet/mscc/ocelot_net.c | 4 1 file changed, 4 deletio

Re: [PATCH 1/4] fix trailing */ in block comment

2020-06-27 Thread Greg Kroah-Hartman
On Sat, Jun 27, 2020 at 06:14:44PM +0800, Coiby Xu wrote: > Remove trailing "*/" in block comments. > > Signed-off-by: Coiby Xu The subject lines of all of your patches should match other patches for this driver. It should look like "staging: qlge: ..." Please fix up and resend a v2 of this se

Re: wireguard: problem sending via libpcap's packet socket

2020-06-27 Thread Hans Wippel
Hi Jason, thanks for quick replies and patches! For whatever it's worth, I have attached another simple test program to this mail. It opens AF_PACKET sockets without libpcap and (incorrectly) sets the protocol to 0. It works with my ethernet device. Looking at the code, it should also work with t

Re: [PATCH 2/2] staging: qlge: fix else after return or break

2020-06-27 Thread Coiby Xu
On Fri, Jun 26, 2020 at 05:06:33PM -0700, Joe Perches wrote: On Sat, 2020-06-27 at 07:57 +0800, Coiby Xu wrote: On Thu, Jun 25, 2020 at 03:13:14PM -0700, Joe Perches wrote: > On Fri, 2020-06-26 at 05:57 +0800, Coiby Xu wrote: > > Remove unnecessary elses after return or break. > > unrelated triv

[PATCH 4/4] replace pr_err with netdev_err

2020-06-27 Thread Coiby Xu
Replace all pr_errs with netdev_err. Suggested-by: Joe Perches Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_dbg.c | 568 1 file changed, 289 insertions(+), 279 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c

[PATCH 3/4] fix ql_sem_unlock

2020-06-27 Thread Coiby Xu
Some functions return without releasing the lock. Replace return with break. Suggested-by Dan Carpenter . Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_dbg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/

[PATCH 2/4] fix else after return or break

2020-06-27 Thread Coiby Xu
Remove unnecessary elses after return or break. Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_dbg.c | 23 ++- drivers/staging/qlge/qlge_main.c | 8 drivers/staging/qlge/qlge_mpi.c | 4 ++-- 3 files changed, 16 insertions(+), 19 deletions(-) diff --git a/

[PATCH 1/4] fix trailing */ in block comment

2020-06-27 Thread Coiby Xu
Remove trailing "*/" in block comments. Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_main.c | 3 ++- drivers/staging/qlge/qlge_mpi.c | 10 ++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c inde

Re: [PATCH net 2/2] wireguard: device: avoid circular netns references

2020-06-27 Thread Jason A. Donenfeld
Hi Dmitry, On Sat, Jun 27, 2020 at 2:59 AM Dmitry Vyukov wrote: > Hard to say. syzkaller frequently needs some time (days) to get > reasonable coverage of new code. > Is wg_netns_pre_exit executed synchronously in the context of a > syscall? If not, then it won't be shown as covered. If yes, then

KASAN: slab-out-of-bounds Read in qrtr_endpoint_post

2020-06-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:1590a2e1 Merge tag 'acpi-5.8-rc3' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1142febb10 kernel config: https://syzkaller.appspot.com/x/.config?x=bf3aec367b9ab569 das

[PATCH net 4/5] wireguard: queueing: make use of ip_tunnel_parse_protocol

2020-06-27 Thread Jason A. Donenfeld
Now that wg_examine_packet_protocol has been added for general consumption as ip_tunnel_parse_protocol, it's possible to remove wg_examine_packet_protocol and simply use the new ip_tunnel_parse_protocol function directly. Signed-off-by: Jason A. Donenfeld --- drivers/net/wireguard/queueing.h | 1

[PATCH net 3/5] wireguard: implement header_ops->parse_protocol for AF_PACKET

2020-06-27 Thread Jason A. Donenfeld
WireGuard uses skb->protocol to determine packet type, and bails out if it's not set or set to something it's not expecting. For AF_PACKET injection, we need to support its call chain of: packet_sendmsg -> packet_snd -> packet_parse_headers -> dev_parse_header_protocol -> parse_protocol

[PATCH net 5/5] tun: implement header_ops->parse_protocol for AF_PACKET

2020-06-27 Thread Jason A. Donenfeld
The tun driver passes up skb->protocol to userspace in the form of PI headers. For AF_PACKET injection, we need to support its call chain of: packet_sendmsg -> packet_snd -> packet_parse_headers -> dev_parse_header_protocol -> parse_protocol Without a valid parse_protocol, this returns

[PATCH net 2/5] net: ipip: implement header_ops->parse_protocol for AF_PACKET

2020-06-27 Thread Jason A. Donenfeld
Ipip uses skb->protocol to determine packet type, and bails out if it's not set. For AF_PACKET injection, we need to support its call chain of: packet_sendmsg -> packet_snd -> packet_parse_headers -> dev_parse_header_protocol -> parse_protocol Without a valid parse_protocol, this return

[PATCH net 1/5] net: ip_tunnel: add header_ops for layer 3 devices

2020-06-27 Thread Jason A. Donenfeld
Some devices that take straight up layer 3 packets benefit from having a shared header_ops so that AF_PACKET sockets can inject packets that are recognized. This shared infrastructure will be used by other drivers that currently can't inject packets using AF_PACKET. It also exposes the parser funct

[PATCH net 0/5] support AF_PACKET for layer 3 devices

2020-06-27 Thread Jason A. Donenfeld
Hans reported that packets injected by a correct-looking and trivial libpcap-based program was not being accepted by wireguard. In investigating that, I noticed that a few devices weren't properly handling AF_PACKET- injected packes, and so this series introduces a bit of shared infrastructure to s

[PATCH] net: ipv4: Fix wrong type conversion from hint to rt in ip_route_use_hint()

2020-06-27 Thread linmiaohe
From: Miaohe Lin We can't cast sk_buff to rtable by (struct rtable *)hint. Use skb_rtable(). Fixes: 02b24941619f ("ipv4: use dst hint for ipv4 list receive") Signed-off-by: Miaohe Lin --- net/ipv4/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/route.c b/n

KASAN: slab-out-of-bounds Read in decode_session6

2020-06-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:b835a71e usbnet: smsc95xx: Fix use-after-free after removal git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=1565a5fd10 kernel config: https://syzkaller.appspot.com/x/.config?x=dcc6334acae363d4 dashboard

KASAN: vmalloc-out-of-bounds Read in __nla_validate_parse

2020-06-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:4e15507f libbpf: Forward-declare bpf_stats_type for system.. git tree: bpf console output: https://syzkaller.appspot.com/x/log.txt?x=12805f5310 kernel config: https://syzkaller.appspot.com/x/.config?x=dcc6334acae363d4 dashboar

KASAN: vmalloc-out-of-bounds Read in __cfg8NUM_wpan_dev_from_attrs

2020-06-27 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:7a64135f libbpf: Adjust SEC short cut for expected attach .. git tree: bpf console output: https://syzkaller.appspot.com/x/log.txt?x=1365a5c510 kernel config: https://syzkaller.appspot.com/x/.config?x=dcc6334acae363d4 dashboar

[Patch net] genetlink: get rid of family->attrbuf

2020-06-27 Thread Cong Wang
genl_family_rcv_msg_attrs_parse() reuses the global family->attrbuf when family->parallel_ops is false. However, family->attrbuf is not protected by any lock on the genl_family_rcv_msg_doit() code path. This leads to several different consequences, one of them is UAF, like the following: genl_fam

Re: [PATCH] qlge.h: Adding the missing blank line after declarations

2020-06-27 Thread Greg Kroah-Hartman
On Sat, Jun 27, 2020 at 02:07:58AM -0400, B K Karthik wrote: > Signed-off-by: B K Karthik > --- > drivers/staging/qlge/qlge.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h > index fc8c5ca8935d..0b971a633001 100644 > --- a/drive

Re: [PATCH net] xsk: remove cheap_dma optimization

2020-06-27 Thread Christoph Hellwig
On Sat, Jun 27, 2020 at 01:00:19AM +0200, Daniel Borkmann wrote: > Given there is roughly a ~5 weeks window at max where this removal could > still be applied in the worst case, could we come up with a fix / proposal > first that moves this into the DMA mapping core? If there is something that > ca

Re: the XSK buffer pool needs be to reverted

2020-06-27 Thread Christoph Hellwig
On Fri, Jun 26, 2020 at 01:54:12PM -0700, Jonathan Lemon wrote: > On Fri, Jun 26, 2020 at 09:47:25AM +0200, Christoph Hellwig wrote: > > > > Note that this is somewhat urgent, as various of the APIs that the code > > is abusing are slated to go away for Linux 5.9, so this addition comes > > at a re

Re: [PATCH net-next 1/3] cxgb4: add mirror action to TC-MATCHALL offload

2020-06-27 Thread Rahul Lakkireddy
On Friday, June 06/26/20, 2020 at 21:18:44 -0700, Jakub Kicinski wrote: > On Thu, 25 Jun 2020 17:28:41 +0530 Rahul Lakkireddy wrote: > > + if (refcount_read(&pi->vi_mirror_refcnt) > 1) { > > + refcount_dec(&pi->vi_mirror_refcnt); > > + return; > > + } > > FWIW this looks ve