From: Luo bin <luob...@huawei.com> Date: Sat, 27 Jun 2020 14:52:37 +0800
> patch #1: support to set and get pause params with > "ethtool -A/a" cmd > patch #2: support to set and get irq coalesce params with > "ethtool -C/c" cmd > patch #3: support to do self test with "ethtool -t" cmd > patch #4: support to identify physical device with "ethtool -p" cmd > patch #5: support to get eeprom information with "ethtool -m" cmd In general, I want you to decrease the amount of log messages. You should only use them when the device or the kernel does something unexpected which should be notifier to the user. Kernel log messages are not for informating the user of limitations of what they can perform with "ethtool". For example, when setting pause paramenters, you complain in the logs if the autonet setting is different. This is completely inappropriate. Then in patch #2 you have these crazy macros that print out state changes with netdev_info(). That is also inappropriate. The user gets a success status, and they can query the settings later if they like as well. Please stop abusing kernel log messaging, it isn't a framework for giving more detailed ethtool command result statuses. Thank you.
