Re: [net-next 10/10] net/mlx5e: Add support for PCI relaxed ordering

2020-06-23 Thread Saeed Mahameed
On Tue, 2020-06-23 at 14:31 -0700, Jakub Kicinski wrote: > On Tue, 23 Jun 2020 12:52:29 -0700 Saeed Mahameed wrote: > > From: Aya Levin > > > > The concept of Relaxed Ordering in the PCI Express environment > > allows > > switches in the path between the Requester and Completer to reorder > > som

Re: [PATCH v3 bpf-next 2/3] selftests/bpf: add variable-length data concatenation pattern test

2020-06-23 Thread Andrii Nakryiko
On Tue, Jun 23, 2020 at 11:04 PM John Fastabend wrote: > > Andrii Nakryiko wrote: > > On Tue, Jun 23, 2020 at 5:25 PM Yonghong Song wrote: > > > > > > > > > > > > On 6/23/20 4:25 PM, Alexei Starovoitov wrote: > > > > On Tue, Jun 23, 2020 at 11:15:58PM +0200, Daniel Borkmann wrote: > > > >> On 6/2

Re: [PATCH bpf-next] libbpf: add debug message for each created program

2020-06-23 Thread Alexei Starovoitov
On Tue, Jun 23, 2020 at 5:34 PM Andrii Nakryiko wrote: > > Similar message for map creation is extremely useful, so add similar for BPF > programs. 'extremely useful' is quite subjective. If we land this patch then everyone will be allowed to add pr_debug() everywhere in libbpf with the same reas

Re: [pull request][net-next V3 0/9] mlx5 updates 2020-06-23

2020-06-23 Thread Saeed Mahameed
On Tue, 2020-06-23 at 21:46 -0700, Saeed Mahameed wrote: > Hi Dave, Jakub > > This series adds misc updates and one small feature, Relaxed > ordering, > to mlx5 driver. > > v1->v2: > - Removed unnecessary Fixes Tags > > v2->v3: > - Drop "macro undefine" patch, it has no value > > For more i

Re: xilinx_axienet_main.c:undefined reference to `devm_ioremap_resource'

2020-06-23 Thread Michal Simek
On 23. 06. 20 23:27, Brendan Higgins wrote: > On Sat, Jun 20, 2020 at 1:59 AM kernel test robot wrote: >> >> Hi Brendan, >> >> It's probably a bug fix that unveils the link errors. >> >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> master >> head: 4333a9b0b67

RE: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-23 Thread Christian Benvenuti (benve)
> -Original Message- > From: netdev-ow...@vger.kernel.org > On Behalf Of Kaige Li > Sent: Tuesday, June 23, 2020 8:41 PM > To: David Miller > Cc: Christian Benvenuti (benve) ; _gov...@gmx.com; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > lixuef...@loongson.cn; yangtie...@loon

general protection fault in qrtr_endpoint_post

2020-06-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:7ae77150 Merge tag 'powerpc-5.8-1' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12c27f7910 kernel config: https://syzkaller.appspot.com/x/.config?x=d195fe572fb15312 das

Re: [PATCH v3 bpf-next 2/3] selftests/bpf: add variable-length data concatenation pattern test

2020-06-23 Thread John Fastabend
Andrii Nakryiko wrote: > On Tue, Jun 23, 2020 at 5:25 PM Yonghong Song wrote: > > > > > > > > On 6/23/20 4:25 PM, Alexei Starovoitov wrote: > > > On Tue, Jun 23, 2020 at 11:15:58PM +0200, Daniel Borkmann wrote: > > >> On 6/23/20 10:52 PM, Andrii Nakryiko wrote: > > >>> On Tue, Jun 23, 2020 at 1:39

Re: [PATCH v3 bpf-next 9/9] selftest: add tests for XDP programs in CPUMAP entries

2020-06-23 Thread Andrii Nakryiko
On Tue, Jun 23, 2020 at 2:40 PM Lorenzo Bianconi wrote: > > Similar to what have been done for DEVMAP, introduce tests to verify > ability to add a XDP program to an entry in a CPUMAP. > Verify CPUMAP programs can not be attached to devices as a normal > XDP program, and only programs with BPF_XDP

Re: [PATCH v3 bpf-next 7/9] libbpf: add SEC name for xdp programs attached to CPUMAP

2020-06-23 Thread Andrii Nakryiko
On Tue, Jun 23, 2020 at 2:40 PM Lorenzo Bianconi wrote: > > As for DEVMAP, support SEC("xdp_cpumap*") as a short cut for loading > the program with type BPF_PROG_TYPE_XDP and expected attach type > BPF_XDP_CPUMAP. > > Signed-off-by: Lorenzo Bianconi > --- Thanks! Acked-by: Andrii Nakryiko >

[net-next V3 8/9] net/mlx5e: vxlan: Return bool instead of opaque ptr in port_lookup()

2020-06-23 Thread Saeed Mahameed
struct mlx5_vxlan_port is not exposed to the outside callers, it is redundant to return a pointer to it from mlx5_vxlan_port_lookup(), to be only used as a boolean, so just return a boolean. Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c | 9 + driv

[net-next V3 7/9] net/mlx5e: vxlan: Use RCU for vxlan table lookup

2020-06-23 Thread Saeed Mahameed
Remove the spinlock protecting the vxlan table and use RCU instead. This will improve performance as it will eliminate contention on data path cores. Fixes: b3f63c3d5e2c ("net/mlx5e: Add netdev support for VXLAN tunneling") Signed-off-by: Saeed Mahameed Reviewed-by: Maxim Mikityanskiy --- .../e

[net-next V3 9/9] net/mlx5e: Add support for PCI relaxed ordering

2020-06-23 Thread Saeed Mahameed
From: Aya Levin The concept of Relaxed Ordering in the PCI Express environment allows switches in the path between the Requester and Completer to reorder some transactions just received before others that were previously enqueued. In ETH driver, there is no question of write integrity since each

[net-next V3 1/9] net/mlx5: Avoid eswitch header inclusion in fs core layer

2020-06-23 Thread Saeed Mahameed
From: Parav Pandit Flow steering core layer is independent of the eswitch layer. Hence avoid fs_core dependency on eswitch. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 10 -- drivers/net/ethernet/mellanox/mlx5/core/

[net-next V3 5/9] net/mlx5e: Move including net/arp.h from en_rep.c to rep/neigh.c

2020-06-23 Thread Saeed Mahameed
From: Alaa Hleihel After the cited commit, the header net/arp.h is no longer used in en_rep.c. So, move it to the new file rep/neigh.c that uses it now. Signed-off-by: Alaa Hleihel Reviewed-by: Vlad Buslov Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/rep/neigh

[net-next V3 4/9] net/mlx5e: Remove unused mlx5e_xsk_first_unused_channel

2020-06-23 Thread Saeed Mahameed
From: Maxim Mikityanskiy mlx5e_xsk_first_unused_channel is a leftover from old versions of the first XSK commit, and it was never used. Remove it. Fixes: db05815b36cb ("net/mlx5e: Add XSK zero-copy support") Signed-off-by: Maxim Mikityanskiy Signed-off-by: Saeed Mahameed --- .../net/ethernet/

[net-next V3 2/9] net/mlx5: FWTrace: Add missing space

2020-06-23 Thread Saeed Mahameed
From: Hu Haowen Missing space at the end of a comment line, add it. Signed-off-by: Hu Haowen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/d

[net-next V3 6/9] net/mlx5e: Move TC-specific function definitions into MLX5_CLS_ACT

2020-06-23 Thread Saeed Mahameed
From: Vlad Buslov en_tc.h header file declares several TC-specific functions in CONFIG_MLX5_ESWITCH block even though those functions are only compiled when CONFIG_MLX5_CLS_ACT is set, which is a recent change. Move them to proper block. Signed-off-by: Vlad Buslov Reviewed-by: Roi Dayan Review

[net-next V3 3/9] net/mlx5: Use kfree(ft->g) in arfs_create_groups()

2020-06-23 Thread Saeed Mahameed
From: Denis Efremov Use kfree() instead of kvfree() on ft->g in arfs_create_groups() because the memory is allocated with kcalloc(). Signed-off-by: Denis Efremov Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[pull request][net-next V3 0/9] mlx5 updates 2020-06-23

2020-06-23 Thread Saeed Mahameed
Hi Dave, Jakub This series adds misc updates and one small feature, Relaxed ordering, to mlx5 driver. v1->v2: - Removed unnecessary Fixes Tags v2->v3: - Drop "macro undefine" patch, it has no value For more information please see tag log below. Please pull and let me know if there is any p

Re: [RFC net-next] devlink: Add reset subcommand.

2020-06-23 Thread Vasundhara Volam
On Wed, Jun 24, 2020 at 2:26 AM Michal Kubecek wrote: > > On Tue, Jun 23, 2020 at 05:02:49PM +0530, Vasundhara Volam wrote: > > Advanced NICs support live reset of some of the hardware > > components, that resets the device immediately with all the > > host drivers loaded. > > > > Add devlink rese

[PATCH bpf-next] libbpf: prevent loading vmlinux BTF twice

2020-06-23 Thread Andrii Nakryiko
Prevent loading/parsing vmlinux BTF twice in some cases: for CO-RE relocations and for BTF-aware hooks (tp_btf, fentry/fexit, etc). Fixes: a6ed02cac690 ("libbpf: Load btf_vmlinux only once per object.") Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/libbpf.c | 33 ++

Re: [PATCH net-next 0/2] cxgb4: fix more warnings reported by sparse

2020-06-23 Thread David Miller
From: Rahul Lakkireddy Date: Wed, 24 Jun 2020 02:03:21 +0530 > Patch 1 ensures all callers take on-chip memory lock when flashing > PHY firmware to fix lock context imbalance warnings. > > Patch 2 moves all static arrays in header file to respective C file > in device dump collection path. Seri

Re: [PATCH net 0/2] Two phylink pause fixes

2020-06-23 Thread David Miller
From: Russell King - ARM Linux admin Date: Tue, 23 Jun 2020 17:46:42 +0100 > While testing, I discovered two issues with ethtool -A with phylink. > First, if there is a PHY bound to the network device, we hit a > deadlock when phylib tries to notify us of the link changing as a > result of trigge

Re: [PATCH net V2] net: Do not clear the sock TX queue in sk_set_socket()

2020-06-23 Thread David Miller
From: Tariq Toukan Date: Mon, 22 Jun 2020 23:26:04 +0300 > Clearing the sock TX queue in sk_set_socket() might cause unexpected > out-of-order transmit when called from sock_orphan(), as outstanding > packets can pick a different TX queue and bypass the ones already queued. > > This is undesired

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-23 Thread Kaige Li
On 06/24/2020 11:23 AM, David Miller wrote: From: Kaige Li Date: Wed, 24 Jun 2020 09:56:47 +0800 On 06/24/2020 06:26 AM, David Miller wrote: From: David Miller Date: Tue, 23 Jun 2020 14:33:11 -0700 (PDT) Calling a NIC driver open function from a context holding a spinlock is very much th

Re: [PATCH net-next] selftests/net: plug rxtimestamp test into kselftest framework

2020-06-23 Thread David Miller
From: Tanner Love Date: Mon, 22 Jun 2020 13:43:24 -0400 > From: tannerlove > > Run rxtimestamp as part of TEST_PROGS. Analogous to other tests, add > new rxtimestamp.sh wrapper script, so that the test runs isolated > from background traffic in a private network namespace. > > Also ignore fail

Re: [PATCH v3 2/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-23 Thread Florian Fainelli
Le 2020-06-23 à 20:26, Jisheng Zhang a écrit : > Call phy_disable_interrupts() in phy_init_hw() to "have a defined init > state as we don't know in which state the PHY is if the PHY driver is > loaded. We shouldn't assume that it's the chip power-on defaults, BIOS > or boot loader could have change

Re: [PATCH net-next] net: thunderbolt: Add comment clarifying prtcstns flags

2020-06-23 Thread David Miller
From: Mika Westerberg Date: Mon, 22 Jun 2020 19:30:22 +0300 > ThunderboltIP protocol currently has two flags from which we only > support and set match frags ID. The first flag is reserved for full E2E > flow control. Add a comment that clarifies them. > > Suggested-by: Yehezkel Bernat > Signed

Re: [net-next PATCH v3 0/3] ACPI support for xgmac_mdio drivers.

2020-06-23 Thread David Miller
From: Calvin Johnson Date: Mon, 22 Jun 2020 20:35:31 +0530 > This patch series provides ACPI support for xgmac_mdio driver. > > Changes in v3: > - handle case MDIOBUS_NO_CAP > > Changes in v2: > - Reserve "0" to mean that no mdiobus capabilities have been declared. > - bus->id: change to approp

Re: [PATCH v1 0/5] ethernet: dec: tulip: use generic power management

2020-06-23 Thread David Miller
From: Vaibhav Gupta Date: Mon, 22 Jun 2020 17:12:23 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management > callbacks and invocation of PCI helper functions, from tulip ethernet drivers. > > With legacy PM, drivers

Re: [PATCH v2 0/3] ethernet: amd: Convert to generic power management

2020-06-23 Thread David Miller
From: Vaibhav Gupta Date: Mon, 22 Jun 2020 16:43:57 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management > callbacks > from amd ethernet drivers. > > The callbacks performing suspend() and resume() operations are

Re: [PATCH][next] net: ipv6: Use struct_size() helper and kcalloc()

2020-06-23 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 22 Jun 2020 18:07:41 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. Also, remove unnecessary > function ipv6_rpl_srh_alloc_size() and replace kzalloc() with kcalloc(), > which ha

Re: [PATCH] [net] dcb_doit: remove redundant skb check

2020-06-23 Thread David Miller
From: Gaurav Singh Date: Mon, 22 Jun 2020 22:50:39 -0400 > skb cannot be NULL here since its already being accessed > before: sock_net(skb->sk). Remove the redundant null check. > > Signed-off-by: Gaurav Singh Applied.

Re: [PATCH] [net/decnet] dn_route_rcv: remove redundant dev null check

2020-06-23 Thread David Miller
From: Gaurav Singh Date: Mon, 22 Jun 2020 23:41:19 -0400 > dev cannot be NULL here since its already being accessed > before. Remove the redundant null check. > > Signed-off-by: Gaurav Singh Applied.

[PATCH v3 1/2] net: phy: make phy_disable_interrupts() non-static

2020-06-23 Thread Jisheng Zhang
We face an issue with rtl8211f, a pin is shared between INTB and PMEB, and the PHY Register Accessible Interrupt is enabled by default, so the INTB/PMEB pin is always active in polling mode case. As Heiner pointed out "I was thinking about calling phy_disable_interrupts() in phy_init_hw(), to have

[PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-23 Thread Jisheng Zhang
We face an issue with rtl8211f, a pin is shared between INTB and PMEB, and the PHY Register Accessible Interrupt is enabled by default, so the INTB/PMEB pin is always active in polling mode case. As Heiner pointed out "I was thinking about calling phy_disable_interrupts() in phy_init_hw(), to have

[PATCH v3 2/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-23 Thread Jisheng Zhang
Call phy_disable_interrupts() in phy_init_hw() to "have a defined init state as we don't know in which state the PHY is if the PHY driver is loaded. We shouldn't assume that it's the chip power-on defaults, BIOS or boot loader could have changed this. Or in case of dual-boot systems the other OS co

Re: [PATCH] net: qrtr: free flow in __qrtr_node_release

2020-06-23 Thread David Miller
From: Carl Huang Date: Tue, 23 Jun 2020 11:22:03 +0800 > @@ -168,6 +168,7 @@ static void __qrtr_node_release(struct kref *kref) > struct radix_tree_iter iter; > unsigned long flags; > void __rcu **slot; > + struct qrtr_tx_flow *flow; Please retain the reverse christmas tree

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-23 Thread David Miller
From: Kaige Li Date: Wed, 24 Jun 2020 10:07:16 +0800 > You are right. Should I do spin_unlock before the enic_open, or remove > spin_lock in enic_reset? You need to learn how this driver's locking works and design a correct adjustment.

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-23 Thread David Miller
From: Kaige Li Date: Wed, 24 Jun 2020 09:56:47 +0800 > > On 06/24/2020 06:26 AM, David Miller wrote: >> From: David Miller >> Date: Tue, 23 Jun 2020 14:33:11 -0700 (PDT) >> >>> Calling a NIC driver open function from a context holding a spinlock >>> is very much the real problem, so many operat

Re: [PATCH net] net: ethtool: Handle missing cable test TDR parameters

2020-06-23 Thread David Miller
From: Andrew Lunn Date: Wed, 24 Jun 2020 03:25:45 +0200 > A last minute change put the TDR cable test parameters into a nest. > The validation is not sufficient, resulting in an oops if the nest is > missing. Set default values first, then update them if the nest is > provided. > > Fixes: f2bc8a

Re: [PATCH] [net/wan] cosa_init: check bounds before access

2020-06-23 Thread David Miller
From: Gaurav Singh Date: Tue, 23 Jun 2020 21:04:49 -0400 > Check i < io bounds before accessing io[i]. > > Signed-off-by: Gaurav Singh The io[] array is intentionally zero terminated, there is no problem.

Re: [PATCH] [net/ethernet] do_reset: remove dev null check

2020-06-23 Thread David Miller
From: Gaurav Singh Date: Tue, 23 Jun 2020 20:55:45 -0400 > dev cannot be NULL here since its already being accessed > before. Remove the redundant null check. > > Signed-off-by: Gaurav Singh I changed your Subject to be: [PATCH net-next] xirc2ps_cs: remove dev null check from do_reset(). Sin

Re: [PATCH net 0/4] bnxt_en: Bug fixes.

2020-06-23 Thread David Miller
From: Michael Chan Date: Tue, 23 Jun 2020 19:01:34 -0400 > The first patch stores the firmware version code which is needed by the > next 2 patches to determine some worarounds based on the firmware version. > The workarounds are to disable legacy TX push mode and to clear the > hardware statisti

Re: [PATCH net-next 0/5] net: adress some sparse warnings

2020-06-23 Thread David Miller
From: Eric Dumazet Date: Tue, 23 Jun 2020 15:31:10 -0700 > This series adds missing declarations and move others to > address W=1 C=1 warnings in tcp and udp. I fixed up 's/adress/address/' for you. Applied and queued up for -stable.

Re: [net-next V2 03/10] net/mlx5: Add a missing macro undefinition

2020-06-23 Thread Saeed Mahameed
On Tue, 2020-06-23 at 19:18 -0700, Saeed Mahameed wrote: > From: Hu Haowen > > The macro ODP_CAP_SET_MAX is only used in function > handle_hca_cap_odp() > in file main.c, so it should be undefined when there are no more uses > of it. > > Signed-off-by: Hu Haowen > Reviewed-by: Leon Romanovsky

Re: [PATCH ipsec-next 3/6] xfrm: replay: remove advance indirection

2020-06-23 Thread kernel test robot
Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on ipsec-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Westphal/xfrm-remove-xfrm-replay-indirections/20200624-035102 base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ips

[net-next V2 05/10] net/mlx5e: Remove unused mlx5e_xsk_first_unused_channel

2020-06-23 Thread Saeed Mahameed
From: Maxim Mikityanskiy mlx5e_xsk_first_unused_channel is a leftover from old versions of the first XSK commit, and it was never used. Remove it. Fixes: db05815b36cb ("net/mlx5e: Add XSK zero-copy support") Signed-off-by: Maxim Mikityanskiy Signed-off-by: Saeed Mahameed --- .../net/ethernet/

[net-next V2 08/10] net/mlx5e: vxlan: Use RCU for vxlan table lookup

2020-06-23 Thread Saeed Mahameed
Remove the spinlock protecting the vxlan table and use RCU instead. This will improve performance as it will eliminate contention on data path cores. Fixes: b3f63c3d5e2c ("net/mlx5e: Add netdev support for VXLAN tunneling") Signed-off-by: Saeed Mahameed Reviewed-by: Maxim Mikityanskiy --- .../e

[net-next V2 10/10] net/mlx5e: Add support for PCI relaxed ordering

2020-06-23 Thread Saeed Mahameed
From: Aya Levin The concept of Relaxed Ordering in the PCI Express environment allows switches in the path between the Requester and Completer to reorder some transactions just received before others that were previously enqueued. In ETH driver, there is no question of write integrity since each

[net-next V2 03/10] net/mlx5: Add a missing macro undefinition

2020-06-23 Thread Saeed Mahameed
From: Hu Haowen The macro ODP_CAP_SET_MAX is only used in function handle_hca_cap_odp() in file main.c, so it should be undefined when there are no more uses of it. Signed-off-by: Hu Haowen Reviewed-by: Leon Romanovsky Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core

[net-next V2 09/10] net/mlx5e: vxlan: Return bool instead of opaque ptr in port_lookup()

2020-06-23 Thread Saeed Mahameed
struct mlx5_vxlan_port is not exposed to the outside callers, it is redundant to return a pointer to it from mlx5_vxlan_port_lookup(), to be only used as a boolean, so just return a boolean. Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c | 9 + driv

[net-next V2 04/10] net/mlx5: Use kfree(ft->g) in arfs_create_groups()

2020-06-23 Thread Saeed Mahameed
From: Denis Efremov Use kfree() instead of kvfree() on ft->g in arfs_create_groups() because the memory is allocated with kcalloc(). Signed-off-by: Denis Efremov Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[net-next V2 02/10] net/mlx5: FWTrace: Add missing space

2020-06-23 Thread Saeed Mahameed
From: Hu Haowen Missing space at the end of a comment line, add it. Signed-off-by: Hu Haowen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/d

[net-next V2 07/10] net/mlx5e: Move TC-specific function definitions into MLX5_CLS_ACT

2020-06-23 Thread Saeed Mahameed
From: Vlad Buslov en_tc.h header file declares several TC-specific functions in CONFIG_MLX5_ESWITCH block even though those functions are only compiled when CONFIG_MLX5_CLS_ACT is set, which is a recent change. Move them to proper block. Signed-off-by: Vlad Buslov Reviewed-by: Roi Dayan Review

[pull request][net-next V2 00/10] mlx5 updates 2020-06-23

2020-06-23 Thread Saeed Mahameed
Hi Dave, Jakub This series adds misc updates and one small feature, Relaxed ordering, to mlx5 driver. v1->v2: - Removed unnecessary Fixes Tags For more information please see tag log below. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since

[net-next V2 01/10] net/mlx5: Avoid eswitch header inclusion in fs core layer

2020-06-23 Thread Saeed Mahameed
From: Parav Pandit Flow steering core layer is independent of the eswitch layer. Hence avoid fs_core dependency on eswitch. Signed-off-by: Parav Pandit Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.h | 10 -- drivers/net/ethernet/mellanox/mlx5/core/

[net-next V2 06/10] net/mlx5e: Move including net/arp.h from en_rep.c to rep/neigh.c

2020-06-23 Thread Saeed Mahameed
From: Alaa Hleihel After the cited commit, the header net/arp.h is no longer used in en_rep.c. So, move it to the new file rep/neigh.c that uses it now. Signed-off-by: Alaa Hleihel Reviewed-by: Vlad Buslov Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/rep/neigh

Re: Multicast routing: wrong output interface selected unless VRF default route is added

2020-06-23 Thread David Ahern
On 6/23/20 11:38 AM, Ido Schimmel wrote: >> >> My questions are: >> 1. is fib_lookup supposed to work with multicast daddr? If so, has >> multicast routing been working for the wrong reason? yes; it is a quirk with Linux routing. see the code after fib_lookup in ip_route_output_key_hash_rcu. perf

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-23 Thread Kaige Li
On 06/24/2020 04:50 AM, Jakub Kicinski wrote: On Tue, 23 Jun 2020 16:13:09 +0800 Kaige Li wrote: The kernel module may sleep with holding a spinlock. The function call paths (from bottom to top) are: [FUNC] zalloc_cpumask_var(GFP_KERNEL) drivers/net/ethernet/cisco/enic/enic_main.c, 125: zall

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-23 Thread Kaige Li
On 06/24/2020 06:26 AM, David Miller wrote: From: David Miller Date: Tue, 23 Jun 2020 14:33:11 -0700 (PDT) Calling a NIC driver open function from a context holding a spinlock is very much the real problem, so many operations have to sleep and in face that ->ndo_open() method is defined as b

[PATCH net] net: ethtool: Handle missing cable test TDR parameters

2020-06-23 Thread Andrew Lunn
A last minute change put the TDR cable test parameters into a nest. The validation is not sufficient, resulting in an oops if the nest is missing. Set default values first, then update them if the nest is provided. Fixes: f2bc8ad31a7f ("net: ethtool: Allow PHY cable test TDR data to configured")

Re: [PATCH bpf] libbpf: fix CO-RE relocs against .text section

2020-06-23 Thread Yonghong Song
On 6/23/20 5:40 PM, Alexei Starovoitov wrote: On Sat, Jun 20, 2020 at 12:06 AM Yonghong Song wrote: On 6/19/20 4:04 PM, Andrii Nakryiko wrote: bpf_object__find_program_by_title(), used by CO-RE relocation code, doesn't return .text "BPF program", if it is a function storage for sub-progr

Re: [PATCH net-next v2 1/3] i40e: optimize AF_XDP Tx completion path

2020-06-23 Thread Samudrala, Sridhar
On 6/23/2020 2:44 AM, Magnus Karlsson wrote: Improve the performance of the AF_XDP zero-copy Tx completion path. When there are no XDP buffers being sent using XDP_TX or XDP_REDIRECT, we do not have go through the SW ring to clean up any entries since the AF_XDP path does not use these. In the

[PATCH] [net/wan] cosa_init: check bounds before access

2020-06-23 Thread Gaurav Singh
Check i < io bounds before accessing io[i]. Signed-off-by: Gaurav Singh --- drivers/net/wan/cosa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c index 5d6532ad6b78..8797adfa0ab0 100644 --- a/drivers/net/wan/cosa.c +++ b/driver

Re: [PATCH bpf] bpf: fix formatting in documentation for BPF helpers

2020-06-23 Thread Alexei Starovoitov
On Tue, Jun 23, 2020 at 8:39 AM Quentin Monnet wrote: > > When producing the bpf-helpers.7 man page from the documentation from > the BPF user space header file, rst2man complains: > > :2636: (ERROR/3) Unexpected indentation. > :2640: (WARNING/2) Block quote ends without a blank line; > u

[PATCH ethtool v1 3/6] json_writer: Import the iproute2 helper code for JSON output

2020-06-23 Thread Andrew Lunn
In general, Linux network tools use JSON for machine readable output. See for example -json for iproute2 and devlink. In order to support JSON output from ethtool, import the iproute2 helper code. Maybe some time in the future it would make sense to either have a shared library, or to merge ethtoo

[PATCH ethtool v1 1/6] Add cable test support

2020-06-23 Thread Andrew Lunn
Add support for starting a cable test, and report the results. This code does not follow the usual patterns because of the way the kernel reports the results of the cable test. It can take a number of seconds for cable testing to occur. So the action request messages is immediately acknowledges, a

[PATCH ethtool v1 4/6] Add --json command line argument parsing

2020-06-23 Thread Andrew Lunn
Allow --json to be passed as an option to select JSON output. The option is handled in the same way as --debug, setting a variable in the command context, which can then later be used per option to select JSON outputters. Signed-off-by: Andrew Lunn --- ethtool.c| 33 ++--- inter

[PATCH ethtool v1 6/6] ethtool.8.in: Add --json option

2020-06-23 Thread Andrew Lunn
Document the --json option, which the --cable-test and --cable-test-tdr options support. Signed-off-by: Andrew Lunn --- ethtool.8.in | 8 1 file changed, 8 insertions(+) diff --git a/ethtool.8.in b/ethtool.8.in index 9e2017d..267eb3b 100644 --- a/ethtool.8.in +++ b/ethtool.8.in @@ -137

[PATCH ethtool v1 0/6] ethtool(1) cable test support

2020-06-23 Thread Andrew Lunn
Add the user space side of the ethtool cable test. The TDR output is most useful when fed to some other tool which can visualize the data. So add JSON support, by borrowing code from iproute2. Andrew Lunn (6): Add cable test support Add cable test TDR support json_writer: Import the iproute

[PATCH ethtool v1 2/6] Add cable test TDR support

2020-06-23 Thread Andrew Lunn
Add support for accessing the cable test time domain reflectromatry data. Add a new command --cable-test-tdr, and support for dumping the data which is returned. signed-off-by: Andrew Lunn --- ethtool.c| 8 ++ netlink/cable_test.c | 289 +++

[PATCH ethtool v1 5/6] ethtool.8.in: Document the cable test commands

2020-06-23 Thread Andrew Lunn
Extend the man page with --cable-test and --cable-test-tdr commands. Signed-off-by: Andrew Lunn --- ethtool.8.in | 45 + 1 file changed, 45 insertions(+) diff --git a/ethtool.8.in b/ethtool.8.in index 9c5f45c..9e2017d 100644 --- a/ethtool.8.in +++ b/e

Re: [net-next v2 8/8] i40e: Remove scheduling while atomic possibility

2020-06-23 Thread Jakub Kicinski
On Tue, 23 Jun 2020 17:22:52 -0700 Jeff Kirsher wrote: > From: Aleksandr Loktionov > > In some occasions task held spinlock, Which spin lock? > while being rescheduled due to mutex_lock. Which mutex? > Moved function call outside of atomic context. What function? > Without this patch ther

[PATCH] [net/ethernet] do_reset: remove dev null check

2020-06-23 Thread Gaurav Singh
dev cannot be NULL here since its already being accessed before. Remove the redundant null check. Signed-off-by: Gaurav Singh --- drivers/net/ethernet/xircom/xirc2ps_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xircom/xirc2ps_cs.c b/drivers/net/e

Re: [PATCH bpf v2] restore behaviour of CAP_SYS_ADMIN allowing the loading of networking bpf programs

2020-06-23 Thread Alexei Starovoitov
On Mon, Jun 22, 2020 at 12:44 PM John Stultz wrote: > > On Sat, Jun 20, 2020 at 2:26 PM Maciej Żenczykowski > wrote: > > > > From: Maciej Żenczykowski > > > > This is a fix for a regression introduced in 5.8-rc1 by: > > commit 2c78ee898d8f10ae6fb2fa23a3fbaec96b1b7366 > > 'bpf: Implement CAP_

Re: [PATCH v3 bpf-next 2/3] selftests/bpf: add variable-length data concatenation pattern test

2020-06-23 Thread Andrii Nakryiko
On Tue, Jun 23, 2020 at 5:25 PM Yonghong Song wrote: > > > > On 6/23/20 4:25 PM, Alexei Starovoitov wrote: > > On Tue, Jun 23, 2020 at 11:15:58PM +0200, Daniel Borkmann wrote: > >> On 6/23/20 10:52 PM, Andrii Nakryiko wrote: > >>> On Tue, Jun 23, 2020 at 1:39 PM Daniel Borkmann > >>> wrote: > >>

Re: [PATCH net 3/4] bnxt_en: Fix statistics counters issue during ifdown with older firmware.

2020-06-23 Thread Jakub Kicinski
On Tue, 23 Jun 2020 19:01:37 -0400 Michael Chan wrote: > On older firmware, the hardware statistics are not cleared when the > driver frees the hardware stats contexts during ifdown. The driver > expects these stats to be cleared and saves a copy before freeing > the stats contexts. During the ne

Re: [PATCH bpf] libbpf: fix CO-RE relocs against .text section

2020-06-23 Thread Alexei Starovoitov
On Sat, Jun 20, 2020 at 12:06 AM Yonghong Song wrote: > > > > On 6/19/20 4:04 PM, Andrii Nakryiko wrote: > > bpf_object__find_program_by_title(), used by CO-RE relocation code, doesn't > > return .text "BPF program", if it is a function storage for sub-programs. > > Because of that, any CO-RE relo

[PATCH bpf-next] libbpf: add debug message for each created program

2020-06-23 Thread Andrii Nakryiko
Similar message for map creation is extremely useful, so add similar for BPF programs. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/libbpf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 18461deb1b19..f24a90c86c58

Re: [PATCH v3 bpf-next 2/3] selftests/bpf: add variable-length data concatenation pattern test

2020-06-23 Thread Yonghong Song
On 6/23/20 4:25 PM, Alexei Starovoitov wrote: On Tue, Jun 23, 2020 at 11:15:58PM +0200, Daniel Borkmann wrote: On 6/23/20 10:52 PM, Andrii Nakryiko wrote: On Tue, Jun 23, 2020 at 1:39 PM Daniel Borkmann wrote: On 6/23/20 5:22 AM, Andrii Nakryiko wrote: Add selftest that validates variable

[net-next v2 8/8] i40e: Remove scheduling while atomic possibility

2020-06-23 Thread Jeff Kirsher
From: Aleksandr Loktionov In some occasions task held spinlock, while being rescheduled due to mutex_lock. Moved function call outside of atomic context. Without this patch there is a race condition, which might result in scheduling while atomic. Signed-off-by: Arkadiusz Kubalewski Signed-off

[net-next v2 7/8] i40e: Add support for 5Gbps cards

2020-06-23 Thread Jeff Kirsher
From: Aleksandr Loktionov Make possible for the i40e driver to bind to the new v710 for 5GBASE-T NICs. Signed-off-by: Aleksandr Loktionov Signed-off-by: Arkadiusz Kubalewski Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_common.c | 3 +++ drive

[net-next v2 5/8] i40e: Add a check to see if MFS is set

2020-06-23 Thread Jeff Kirsher
From: Todd Fujinaka A customer was chain-booting to provision his systems and one of the steps was setting MFS. MFS isn't cleared by normal warm reboots (clearing requires a GLOBR) and there was no indication of why Jumbo Frame receives were failing. Add a warning if MFS is set to anything lower

[net-next v2 6/8] net/intel: remove driver versions from Intel drivers

2020-06-23 Thread Jeff Kirsher
As with other networking drivers, remove the unnecessary driver version from the Intel drivers. The ethtool driver information and module version will then report the kernel version instead. For ixgbe, i40e and ice drivers, the driver passes the driver version to the firmware to confirm that we ar

[net-next v2 3/8] i40e: make PF wait reset loop reliable

2020-06-23 Thread Jeff Kirsher
From: Piotr Kwapulinski Use jiffies to limit max waiting time for PF reset to succeed. Previous wait loop was unreliable. It required unreasonably long time to wait for PF reset after reboot when NIC was about to enter recovery mode Reviewed-by: Aleksandr Loktionov Signed-off-by: Piotr Kwapulin

[net-next v2 4/8] i40e: detect and log info about pre-recovery mode

2020-06-23 Thread Jeff Kirsher
From: Piotr Kwapulinski Detect and log information about pre-recovery mode when firmware transitions to a recovery mode. When a firmware transitions to a recovery mode it stores a number of unexpected EMP resets in one of its registers. The number of EMP resets ranging from 0x21 to 0x2A indicates

[net-next v2 1/8] i40e: Move client header location

2020-06-23 Thread Jeff Kirsher
From: Shiraz Saleem Move i40e_client.h to include/linux/net/intel/* since its shared between i40iw and i40e. Signed-off-by: Shiraz Saleem Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/infiniband/hw/i40iw/Makefile| 1 - drivers/infiniband/hw/i40i

[net-next v2 0/8][pull request] 40GbE Intel Wired LAN Driver Updates 2020-06-23

2020-06-23 Thread Jeff Kirsher
This series contains updates to i40e driver and removes the individual driver versions from all of the Intel wired LAN drivers. Shiraz moves the client header so that it can easily be shared between the i40e LAN driver and i40iw RDMA driver. Jesse cleans up the unused defines, since they are just

RE: [net-next v2 15/15] idpf: Introduce idpf driver

2020-06-23 Thread Brady, Alan
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, June 23, 2020 4:39 PM > To: Kirsher, Jeffrey T > Cc: da...@davemloft.net; Brady, Alan ; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Michael, Alice ; Burra, Phani R > ; Hay, Joshua A ; Chittim, > Madhu ;

Re: [PATCH iproute2 0/5] Eliminate the term slave in iproute2

2020-06-23 Thread Jakub Kicinski
On Tue, 23 Jun 2020 16:53:02 -0700 Stephen Hemminger wrote: > These patches remove the term slave from the iproute2 visible > command line, documentation, and variable naming. > > This needs doing despite the fact it will cause cosmetic > changes to visible outputs. And non-cosmetic changes in ma

Re: [PATCH ipsec-next 3/6] xfrm: replay: remove advance indirection

2020-06-23 Thread kernel test robot
Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on ipsec-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Westphal/xfrm-remove-xfrm-replay-indirections/20200624-035102 base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ips

[PATCH iproute2 5/5] ip: rename slave to subport

2020-06-23 Thread Stephen Hemminger
Replace use of slave by subport in bridge/bond/team/vrf and hsr. The word slave is unnecessarily hostile and is not used in any of the relevant standards from IETF or IEEE. Use the term subport across the iproute2 command set instead. Patches to keep old term on input with nag warnings are underc

[PATCH iproute2 2/5] bridge: remove slave from comments and message

2020-06-23 Thread Stephen Hemminger
No need for slave in comment and message. Can't change API (yet) since part of Linux uapi. Signed-off-by: Stephen Hemminger --- bridge/vlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bridge/vlan.c b/bridge/vlan.c index 0d142bc9055d..9128769eaf3d 100644 --- a/bridge

[PATCH iproute2 0/5] Eliminate the term slave in iproute2

2020-06-23 Thread Stephen Hemminger
These patches remove the term slave from the iproute2 visible command line, documentation, and variable naming. This needs doing despite the fact it will cause cosmetic changes to visible outputs. Stephen Hemminger (5): bpf: replace slave with sub bridge: remove slave from comments and messag

[PATCH iproute2 3/5] testsuite: replace Enslave with Insert

2020-06-23 Thread Stephen Hemminger
Use the term insert instead of enslave because it is more descriptive and less offensive. Signed-off-by: Stephen Hemminger --- testsuite/tests/bridge/vlan/show.t | 4 ++-- testsuite/tests/bridge/vlan/tunnelshow.t | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/testsu

[PATCH iproute2 4/5] ip: replace slave_kind

2020-06-23 Thread Stephen Hemminger
Instead of slave_kind, rename variable to sub_kind to describe the kind of sub-device that is being looked for when filtering messages. Signed-off-by: Stephen Hemminger --- ip/ip_common.h | 2 +- ip/ipaddress.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ip/ip_common

[PATCH iproute2 1/5] bpf: replace slave with sub

2020-06-23 Thread Stephen Hemminger
The term sub interface is more appropriate for bpf devices. Signed-off-by: Stephen Hemminger --- lib/bpf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/bpf.c b/lib/bpf.c index c7d45077c14e..9271e169a992 100644 --- a/lib/bpf.c +++ b/lib/bpf.c @@ -666,7 +666,7 @@

RE: Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-23 Thread Po Liu
Hi Jamal, > -Original Message- > From: Jamal Hadi Salim > Sent: 2020年6月23日 20:18 > To: Po Liu ; da...@davemloft.net; linux- > ker...@vger.kernel.org; netdev@vger.kernel.org; ido...@idosch.org > Cc: j...@resnulli.us; vinicius.go...@intel.com; v...@buslov.dev; Claudiu > Manoil ; Vladimir O

  1   2   3   4   5   >