> -----Original Message----- > From: Jakub Kicinski <k...@kernel.org> > Sent: Tuesday, June 23, 2020 4:39 PM > To: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com> > Cc: da...@davemloft.net; Brady, Alan <alan.br...@intel.com>; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Michael, Alice <alice.mich...@intel.com>; Burra, Phani R > <phani.r.bu...@intel.com>; Hay, Joshua A <joshua.a....@intel.com>; Chittim, > Madhu <madhu.chit...@intel.com>; Linga, Pavan Kumar > <pavan.kumar.li...@intel.com>; Skidmore, Donald C > <donald.c.skidm...@intel.com>; Brandeburg, Jesse > <jesse.brandeb...@intel.com>; Samudrala, Sridhar > <sridhar.samudr...@intel.com>; lkp <l...@intel.com> > Subject: Re: [net-next v2 15/15] idpf: Introduce idpf driver > > On Tue, 23 Jun 2020 15:40:43 -0700 Jeff Kirsher wrote: > > +/** > > + * idpf_probe - Device initialization routine > > + * @pdev: PCI device information struct > > + * @ent: entry in idpf_pci_tbl > > + * > > + * Returns 0 on success, negative on failure */ int > > +idpf_probe(struct pci_dev *pdev, > > + const struct pci_device_id __always_unused *ent) > > > drivers/net/ethernet/intel/idpf/idpf_main.c:46:5: warning: symbol 'idpf_probe' > was not declared. Should it be static? > drivers/net/ethernet/intel/idpf/idpf_main.c:46:5: warning: no previous > prototype for idpf_probe [-Wmissing-prototypes] > 46 | int idpf_probe(struct pci_dev *pdev, > | ^~~~~~~~~~
Woops, missed one, sorry for the thrash and thanks for double checking. Will get another version fixing this soon. Alan
