Re: [PATCH 4/4] ipv6: symbol_get to access a sit symbol

2020-05-14 Thread Christoph Hellwig
On Thu, May 14, 2020 at 05:53:55PM -0700, David Miller wrote: > You're not undoing one, but two levels of abstraction here. > > Is this "ipip6_tunnel_locate()" call part of the SIT ioctl implementation? Yes. Take a look at the convoluted case handling the SIOCADDTUNNEL and SIOCCHGTUNNEL commands

Re: [PATCH bpf-next v2 00/14] Introduce AF_XDP buffer allocation API

2020-05-14 Thread Björn Töpel
On 2020-05-14 10:36, Björn Töpel wrote: Overview Driver adoption for AF_XDP has been slow. The amount of code required to proper support AF_XDP is substantial and the driver/core APIs are vague or even non-existing. Drivers have to manually adjust data offsets, updating AF_XDP handles d

linux-next: manual merge of the devicetree tree with the net-next tree

2020-05-14 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the devicetree tree got a conflict in: Documentation/devicetree/bindings/net/qcom,ipa.yaml between commit: 8456c54408a2 ("dt-bindings: net: add IPA iommus property") from the net-next tree and commit: fba5618451d2 ("dt-bindings: Fix incorrect 'reg' pr

Re: [PATCH net-next v4 00/33] XDP extend with knowledge of frame size

2020-05-14 Thread Alexei Starovoitov
On Thu, May 14, 2020 at 3:49 AM Jesper Dangaard Brouer wrote: > > (Patchset based on net-next due to all the driver updates) > > V4: > - Fixup checkpatch.pl issues > - Collected more ACKs Applied to bpf-next. Thanks

[PATCH] e1000e: Relax condition to trigger reset for ME workaround

2020-05-14 Thread Punit Agrawal
It's an error if the value of the RX/TX tail descriptor does not match what was written. The error condition is true regardless the duration of the interference from ME. But the driver only performs the reset if E1000_ICH_FWSM_PCIM2PCI_COUNT (2000) iterations of 50us delay have transpired. The extr

[net-next v3 7/9] igc: Use netdev log helpers in igc_base.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes This patch coverts one pr_debug() call to hw_dbg() in order to keep log output aligned with the rest of the driver. hw_dbg() is actually a macro defined in igc_hw.h that expands to netdev_dbg(). It also takes this opportunity to remove the '\n' character at the end of messages

[net-next v3 8/9] igc: Remove unneeded definition

2020-05-14 Thread Jeff Kirsher
From: Sasha Neftin PHY_FORCE_LIMIT definition not in use and could be removed i225 parts support auto negotiation mechanism Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_defines.h | 1 - 1 file changed, 1 deletion(-) di

[net-next v3 4/9] igc: Use netdev log helpers in igc_ethtool.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes In igc_ethtool.c we print log messages using dev_* helpers, generating inconsistent output with the rest of the driver. Since this is a network device driver, we should preferably use netdev_* helpers because they append the interface name to the message, helping making sense t

[net-next v3 9/9] igc: Remove unneeded register

2020-05-14 Thread Jeff Kirsher
From: Sasha Neftin Flow control status register not applicable for i225 parts so clean up the unneeded define. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_regs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drive

[net-next v3 5/9] igc: Use netdev log helpers in igc_ptp.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes In igc_ptp.c we print log messages using dev_* helpers, generating inconsistent output with the rest of the driver. Since this is a network device driver, we should preferably use netdev_* helpers because they append the interface name to the message, helping making sense out o

[net-next v3 2/9] igc: Use netdev log helpers in igc_main.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes In igc_main.c we print log messages using both dev_* and netdev_* helpers, generating inconsistent output. Since this is a network device driver, we should preferably use netdev_* helpers because they append the interface name to the message, helping making sense out of the log

[net-next v3 1/9] igc: Add ECN support for TSO

2020-05-14 Thread Jeff Kirsher
From: Sasha Neftin Align with other Intel drivers and add ECN support for TSO. Add NETIF_F_TSO_ECN flag Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ne

[net-next v3 6/9] igc: Use netdev log helpers in igc_dump.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes In igc_dump.c we print log messages using dev_* and pr_* helpers, generating inconsistent output with the rest of the driver. Since this is a network device driver, we should preferably use netdev_* helpers because they append the interface name to the message, helping making s

[net-next v3 0/9][pull request] 1GbE Intel Wired LAN Driver Updates 2020-05-14

2020-05-14 Thread Jeff Kirsher
This series contains updates to igc driver only. Sasha adds ECN support for TSO by adding the NETIF_F_TSO_ECN flag, which aligns with other Intel drivers. Also cleaned up defines that are not supported or used in the igc driver. Andre does most of the changes with updating the log messages for i

[net-next v3 3/9] igc: add support to eeprom, registers and link self-tests

2020-05-14 Thread Jeff Kirsher
From: Vitaly Lifshits Introduced igc_diag.c and igc_diag.h, these files have the diagnostics functionality of igc driver. For the time being these files are being used by ethtool self-test callbacks. Which mean that eeprom, registers and link self-tests for ethtool were implemented. Signed-off-b

Re: pull-request: bpf-next 2020-05-14

2020-05-14 Thread David Miller
From: Alexei Starovoitov Date: Thu, 14 May 2020 19:03:21 -0700 > The following pull-request contains BPF updates for your *net-next* tree. > > The main changes are: > > 1) Merged tag 'perf-for-bpf-2020-05-06' from tip tree that includes > CAP_PERFMON. > > 2) support for narrow loads in bpf_so

[PATCH] net: mscc: ocelot: replace readx_poll_timeout with readx_poll_timeout_atomic

2020-05-14 Thread Xulin Sun
This fixes call trace like below to use atomic safe API: BUG: sleeping function called from invalid context at drivers/net/ethernet/mscc/ocelot.c:59 in_atomic(): 1, irqs_disabled(): 0, pid: 3778, name: ifconfig INFO: lockdep is turned off. Preemption disabled at: [] dev_set_rx_mode+0x24/0x40 Hard

linux-next: manual merge of the bpf-next tree with the bpf tree

2020-05-14 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the bpf-next tree got a conflict in: kernel/bpf/verifier.c between commit: e92888c72fbd ("bpf: Enforce returning 0 for fentry/fexit progs") from the bpf tree and commit: 15d83c4d7cef ("bpf: Allow loading of a bpf_iter program") from the bpf-next tree

pull-request: bpf-next 2020-05-14

2020-05-14 Thread Alexei Starovoitov
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Merged tag 'perf-for-bpf-2020-05-06' from tip tree that includes CAP_PERFMON. 2) support for narrow loads in bpf_sock_addr progs and additional helpers in cg-skb progs, from Andrey.

Re: [RFC] e1000e: Relax condition to trigger reset for ME workaround

2020-05-14 Thread Punit Agrawal
Alexander Duyck writes: > On Mon, May 11, 2020 at 9:45 PM Punit Agrawal > wrote: >> >> It's an error if the value of the RX/TX tail descriptor does not match >> what was written. The error condition is true regardless the duration >> of the interference from ME. But the code only performs the re

Re: [PATCH][next] selftest/bpf: fix spelling mistake "SIGALARM" -> "SIGALRM"

2020-05-14 Thread Alexei Starovoitov
On Thu, May 14, 2020 at 8:01 AM Yonghong Song wrote: > > > > On 5/14/20 5:15 AM, Colin King wrote: > > From: Colin Ian King > > > > There is a spelling mistake in an error message, fix it. > > > > Signed-off-by: Colin Ian King > Acked-by: Yonghong Song Applied. Thanks

Re: [PATCH v2 bpf-next] bpf: fix bpf_iter's task iterator logic

2020-05-14 Thread Alexei Starovoitov
On Wed, May 13, 2020 at 10:54 PM Andrii Nakryiko wrote: > > task_seq_get_next might stop prematurely if get_pid_task() fails to get > task_struct. Failure to do so doesn't mean that there are no more tasks with > higher pids. Procfs's iteration algorithm (see next_tgid in fs/proc/base.c) > does a

[PATCH] netfilter/ipvs: expire no destination UDP connections when expire_nodest_conn=1

2020-05-14 Thread Andrew Sy Kim
When expire_nodest_conn=1 and an IPVS destination is deleted, IPVS doesn't expire connections with the IP_VS_CONN_F_ONE_PACKET flag set (any UDP connection). If there are many UDP packets to a virtual server from a single client and a destination is deleted, many packets are silently dropped whenev

Re: [PATCH bpf-next v2] samples/bpf: xdp_redirect_cpu: set MAX_CPUS according to NR_CPUS

2020-05-14 Thread Alexei Starovoitov
On Tue, May 12, 2020 at 10:03 AM Yonghong Song wrote: > > > > On 5/12/20 9:30 AM, Lorenzo Bianconi wrote: > > xdp_redirect_cpu is currently failing in bpf_prog_load_xattr() > > allocating cpu_map map if CONFIG_NR_CPUS is less than 64 since > > cpu_map_alloc() requires max_entries to be less than N

Re: [PATCH] MAINTAINERS: Add Jakub to networking drivers.

2020-05-14 Thread Florian Fainelli
On 5/14/2020 6:05 PM, David Miller wrote: > From: Andrew Lunn > Date: Thu, 14 May 2020 23:24:08 +0200 > >> Now there are two of you, do you think you can do a bit better than >> Odd Fixes? > > Your expectations are really high :-) I think Andrew was just shy of suggesting himself to be added

Re: [PATCH] MAINTAINERS: Add Jakub to networking drivers.

2020-05-14 Thread David Miller
From: Andrew Lunn Date: Thu, 14 May 2020 23:24:08 +0200 > Now there are two of you, do you think you can do a bit better than > Odd Fixes? Your expectations are really high :-) Yeah I guess we can put Maintained in there, I'll do that right now. [PATCH] MAINTAINERS: Mark n

Re: [PATCH][next] net: dsa: felix: fix incorrect clamp calculation for burst

2020-05-14 Thread David Miller
From: Colin King Date: Thu, 14 May 2020 19:33:02 +0100 > From: Colin Ian King > > Currently burst is clamping on rate and not burst, the assignment > of burst from the clamping discards the previous assignment of burst. > This looks like a cut-n-paste error from the previous clamping > calculat

Re: r8169: don't include linux/moduleparam.h

2020-05-14 Thread David Miller
From: Heiner Kallweit Date: Thu, 14 May 2020 23:44:07 +0200 > 93882c6f210a ("r8169: switch from netif_xxx message functions to > netdev_xxx") removed the last module parameter from the driver, > therefore there's no need any longer to include linux/moduleparam.h. > > Signed-off-by: Heiner Kallwe

Re: r8169: remove not needed checks in rtl8169_set_eee

2020-05-14 Thread David Miller
From: Heiner Kallweit Date: Thu, 14 May 2020 23:39:34 +0200 > After 9de5d235b60a ("net: phy: fix aneg restart in phy_ethtool_set_eee") > we don't need the check for aneg being enabled any longer, and as > discussed with Russell configuring the EEE advertisement should be > supported even if we're

Re: [PATCH net v2 1/2] ipmr: Fix RCU list debugging warning

2020-05-14 Thread David Miller
From: Amol Grover Date: Thu, 14 May 2020 23:31:02 +0530 > ipmr_for_each_table() macro uses list_for_each_entry_rcu() > for traversing outside of an RCU read side critical section > but under the protection of rtnl_mutex. Hence, add the > corresponding lockdep expression to silence the following >

Re: [PATCH net v2 2/2] ipmr: Add lockdep expression to ipmr_for_each_table macro

2020-05-14 Thread David Miller
From: Amol Grover Date: Thu, 14 May 2020 23:31:03 +0530 > During the initialization process, ipmr_new_table() is called > to create new tables which in turn calls ipmr_get_table() which > traverses net->ipv4.mr_tables without holding the writer lock. > However, this is safe to do so as no tables

Re: [PATCH] net: phy: mdio-moxart: remove unneeded include

2020-05-14 Thread David Miller
From: Bartosz Golaszewski Date: Thu, 14 May 2020 18:59:38 +0200 > From: Bartosz Golaszewski > > mdio-moxart doesn't use regulators in the driver code. We can remove > the regulator include. > > Signed-off-by: Bartosz Golaszewski Applied to net-next.

Re: [PATCH net-next] dt-bindings: dp83867: Convert DP83867 to yaml

2020-05-14 Thread David Miller
From: Dan Murphy Date: Thu, 14 May 2020 10:59:05 -0500 > Convert the dp83867 binding to yaml. > > Signed-off-by: Dan Murphy Applied.

Re: [PATCH net-next] dt-bindings: net: dp83869: Update licensing info

2020-05-14 Thread David Miller
From: Dan Murphy Date: Thu, 14 May 2020 09:50:12 -0500 > Add BSD 2 Clause to the licensing. > > CC: Rob Herring > Signed-off-by: Dan Murphy Applied.

Re: [PATCH 4/4] ipv6: symbol_get to access a sit symbol

2020-05-14 Thread David Miller
From: Christoph Hellwig Date: Thu, 14 May 2020 16:51:01 +0200 > Instead of going through the ioctl handler from kernel space, use > symbol_get to the newly factored out ipip6_set_dstaddr helper, bypassing > addrconf.c entirely. > > Signed-off-by: Christoph Hellwig ... > - memset(&p

Re: [PATCH 1/4] ipv6: lift copy_from_user out of ipv6_route_ioctl

2020-05-14 Thread David Miller
From: Christoph Hellwig Date: Thu, 14 May 2020 16:45:32 +0200 > --- a/net/ipv6/af_inet6.c > +++ b/net/ipv6/af_inet6.c > @@ -542,19 +542,23 @@ int inet6_ioctl(struct socket *sock, unsigned int cmd, > unsigned long arg) > { > struct sock *sk = sock->sk; > struct net *net = sock_net(sk

Re: [PATCH 4/4] ipv4,appletalk: move SIOCADDRT and SIOCDELRT handling into ->compat_ioctl

2020-05-14 Thread David Miller
From: Christoph Hellwig Date: Thu, 14 May 2020 16:45:35 +0200 > #ifdef CONFIG_COMPAT > +static int atalk_compat_routing_ioctl(struct sock *sk, unsigned int cmd, > + struct compat_rtentry __user *ur) > +{ > + struct rtentry rt; > + compat_uptr_t rtdev; > + Reverse christmas t

Re: [PATCH 2/4] ipv6: move SIOCADDRT and SIOCDELRT handling into ->compat_ioctl

2020-05-14 Thread David Miller
From: Christoph Hellwig Date: Thu, 14 May 2020 16:45:33 +0200 > +int inet6_compat_ioctl(struct socket *sock, unsigned int cmd, unsigned long > arg) > +{ > + struct sock *sk = sock->sk; > + void __user *argp = compat_ptr(arg); Reverse chrstimas tree please.

Re: [PATCH net] drivers: net: hamradio: Fix suspicious RCU usage warning in bpqether.c

2020-05-14 Thread David Miller
From: madhuparnabhowmi...@gmail.com Date: Thu, 14 May 2020 19:41:15 +0530 > From: Madhuparna Bhowmik > > This patch fixes the following warning: > = > WARNING: suspicious RCU usage > 5.7.0-rc5-next-20200514-syzkal

Re: [PATCH v2 bpf-next 4/7] printk: add type-printing %pT format specifier which uses BTF

2020-05-14 Thread Yonghong Song
On 5/14/20 3:37 PM, Alan Maguire wrote: On Wed, 13 May 2020, Yonghong Song wrote: On 5/11/20 10:56 PM, Alan Maguire wrote: printk supports multiple pointer object type specifiers (printing netdev features etc). Extend this support using BTF to cover arbitrary types. "%pT" specifies th

Re: [PATCH net-next] net: phy: broadcom: fix BCM54XX_SHD_SCR3_TRDDAPD value for BCM54810

2020-05-14 Thread David Miller
From: Kevin Lo Date: Thu, 14 May 2020 08:57:33 +0800 > Set the correct bit when checking for PHY_BRCM_DIS_TXCRXC_NOENRGY on the > BCM54810 PHY. > > Signed-off-by: Kevin Lo Applied to 'net', thanks.

Re: [PATCH net-next] hinic: add set_ringparam ethtool_ops support

2020-05-14 Thread David Miller
From: Luo bin Date: Wed, 13 May 2020 22:37:33 + > support to change TX/RX queue depth with ethtool -G > > Signed-off-by: Luo bin Applied.

Re: [PATCH net-next] hinic: update huawei ethernet driver maintainer

2020-05-14 Thread David Miller
From: Luo bin Date: Wed, 13 May 2020 22:50:49 + > update huawei ethernet driver maintainer from aviad to Bin luo > > Signed-off-by: Luo bin Applied.

Re: [PATCH 0/3] Patch series for a PTP Grandmaster use case using stmmac/gmac3 ptp clock

2020-05-14 Thread Richard Cochran
On Thu, May 14, 2020 at 05:09:01PM +0200, Olivier Dautricourt wrote: > My issue is that the default behavior of the stmmac driver is to > set the mac into fine mode which implies to continuously do frequency > adjustment, So if i'm not mistaken using the nullf servo will not address > that

Re: [PATCH net-next] devlink: refactor end checks in devlink_nl_cmd_region_read_dumpit

2020-05-14 Thread David Miller
From: Jakub Kicinski Date: Wed, 13 May 2020 10:28:22 -0700 > Clean up after recent fixes, move address calculations > around and change the variable init, so that we can have > just one start_offset == end_offset check. > > Make the check a little stricter to preserve the -EINVAL > error if requ

Re: [PATCH net-next 0/2] am65-cpsw: add taprio/EST offload support

2020-05-14 Thread David Miller
From: Murali Karicheri Date: Wed, 13 May 2020 09:26:13 -0400 > AM65 CPSW h/w supports Enhanced Scheduled Traffic (EST – defined > in P802.1Qbv/D2.2 that later got included in IEEE 802.1Q-2018) > configuration. EST allows express queue traffic to be scheduled > (placed) on the wire at specific rep

Re: [PATCH 2/3] net: uapi: Add HWTSTAMP_FLAGS_ADJ_FINE/ADJ_COARSE

2020-05-14 Thread Richard Cochran
On Thu, May 14, 2020 at 05:20:41PM +0200, Olivier Dautricourt wrote: > Can't we consider this as a time stamp settings ? No. It really is not a time stamp setting at all. > I don't see where we could put those driver-specific flags. > That flag field was reserved for futher improvements so i fou

Re: [PATCH 0/8 net] the indirect flow_block offload, revisited

2020-05-14 Thread David Miller
From: Pablo Neira Ayuso Date: Fri, 15 May 2020 00:36:27 +0200 > The TC CT action crashes the kernel with an indirect flow_block in place: > > https://lore.kernel.org/netfilter-devel/db9dfe4f-62e7-241b-46a0-d878c8969...@ucloud.cn/ I've read over this patch set at least three times, and reread th

Re: [PATCH][next] rtw88: 8723d: fix incorrect setting of ldo_pwr

2020-05-14 Thread Pkshih
On Thu, 2020-05-14 at 18:13 +, Colin King wrote: > From: Colin Ian King > > Currently ldo_pwr has the LDO25 voltage bits set to zero and then > it is overwritten with the new voltage setting. The assignment > looks incorrect, it should be bit-wise or'ing in the new voltage > setting rather th

Re: [PATCH v2 bpf-next 4/7] printk: add type-printing %pT format specifier which uses BTF

2020-05-14 Thread Joe Perches
On Thu, 2020-05-14 at 17:09 -0700, Alexei Starovoitov wrote: > On Thu, May 14, 2020 at 04:43:24PM -0700, Joe Perches wrote: > > The ``BTF_INT_BITS()`` specifies the number of actual bits held by this int > > type. For example, a 4-bit bitfield encodes ``BTF_INT_BITS()`` equals to 4. > > diff --gi

Re: [PATCH v2 bpf-next 7/7] bpf: add tests for %pT format specifier

2020-05-14 Thread Andrii Nakryiko
On Mon, May 11, 2020 at 10:59 PM Alan Maguire wrote: > > tests verify we get > 0 return value from bpf_trace_print() > using %pT format specifier with various modifiers/pointer > values. > > Signed-off-by: Alan Maguire > --- There is no need to use perf buffer for returning results to user-space

Re: [PATCH v2 bpf-next 4/7] printk: add type-printing %pT format specifier which uses BTF

2020-05-14 Thread Alexei Starovoitov
On Thu, May 14, 2020 at 04:43:24PM -0700, Joe Perches wrote: > The ``BTF_INT_BITS()`` specifies the number of actual bits held by this int > type. For example, a 4-bit bitfield encodes ``BTF_INT_BITS()`` equals to 4. > diff --git a/include/uapi/linux/btf.h b/include/uapi/linux/btf.h > index 5a667

Re: [PATCH bpf 1/3] bpf: restrict bpf_probe_read{,str}() only to archs where they work

2020-05-14 Thread Masami Hiramatsu
On Thu, 14 May 2020 18:16:05 +0200 Daniel Borkmann wrote: > Given the legacy bpf_probe_read{,str}() BPF helpers are broken on archs > with overlapping address ranges, we should really take the next step to > disable them from BPF use there. > > To generally fix the situation, we've recently adde

Re: [RFC v2] current devlink extension plan for NICs

2020-05-14 Thread Jacob Keller
On 5/1/2020 2:14 AM, Jiri Pirko wrote: > == > || || > || SF (subfunction) user cmdline API draft || > ||

[PATCH net-next] mptcp: Use 32-bit DATA_ACK when possible

2020-05-14 Thread Christoph Paasch
RFC8684 allows to send 32-bit DATA_ACKs as long as the peer is not sending 64-bit data-sequence numbers. The 64-bit DSN is only there for extreme scenarios when a very high throughput subflow is combined with a long-RTT subflow such that the high-throughput subflow wraps around the 32-bit sequence

Re: [PATCH v2 bpf-next 4/7] printk: add type-printing %pT format specifier which uses BTF

2020-05-14 Thread Joe Perches
On Wed, 2020-05-13 at 16:22 -0700, Joe Perches wrote: > On Wed, 2020-05-13 at 16:07 -0700, Alexei Starovoitov wrote: > > On Wed, May 13, 2020 at 4:05 PM Joe Perches wrote: > > > On Tue, 2020-05-12 at 06:56 +0100, Alan Maguire wrote: > > > > printk supports multiple pointer object type specifiers (

Re: [PATCH bpf-next] bpf, bpftool: Allow probing for CONFIG_HZ from kernel config

2020-05-14 Thread Andrii Nakryiko
On Wed, May 13, 2020 at 1:00 AM Daniel Borkmann wrote: > > In Cilium we've recently switched to make use of bpf_jiffies64() for > parts of our tc and XDP datapath since bpf_ktime_get_ns() is more > expensive and high-precision is not needed for our timeouts we have > anyway. Our agent has a probe

Re: bpf selftest execution issues

2020-05-14 Thread Andrii Nakryiko
On Tue, May 12, 2020 at 7:46 AM Alan Maguire wrote: > > When running BPF tests I ran into some issues and couldn't get a clean > set of results on the bpf-next master branch. Just wanted to check if anyone > else is seeing any of these failures. > > 1. Timeouts. When running "make run_tests" in to

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Andrii Nakryiko
On Thu, May 14, 2020 at 3:56 PM Alexei Starovoitov wrote: > > On Thu, May 14, 2020 at 02:30:11PM -0700, Andrii Nakryiko wrote: > > On Thu, May 14, 2020 at 1:39 PM Thomas Gleixner wrote: > > > > > > Jakub Kicinski writes: > > > > > > > On Wed, 13 May 2020 12:25:27 -0700 Andrii Nakryiko wrote: > >

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Alexei Starovoitov
On Thu, May 14, 2020 at 02:30:11PM -0700, Andrii Nakryiko wrote: > On Thu, May 14, 2020 at 1:39 PM Thomas Gleixner wrote: > > > > Jakub Kicinski writes: > > > > > On Wed, 13 May 2020 12:25:27 -0700 Andrii Nakryiko wrote: > > >> One interesting implementation bit, that significantly simplifies (an

Re: [PATCH 8/9] selftests/bpf: Add test for d_path helper

2020-05-14 Thread Andrii Nakryiko
On Wed, May 6, 2020 at 6:32 AM Jiri Olsa wrote: > > Adding test for d_path helper which is pretty much > copied from Wenbo Zhang's test for bpf_get_fd_path, > which never made it in. > > I've failed so far to compile the test with > kernel header, so for now adding 'struct file' with f_path > mem

Re: [PATCH 7/9] bpf: Compile the BTF id whitelist data in vmlinux

2020-05-14 Thread Andrii Nakryiko
On Thu, May 14, 2020 at 1:05 AM Jiri Olsa wrote: > > On Wed, May 13, 2020 at 11:29:40AM -0700, Alexei Starovoitov wrote: > > SNIP > > > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > > > index d09ab4afbda4..dee91c6bf450 100755 > > > --- a/scripts/link-vmlinux.sh > > > +++ b/scr

Re: [net-next v2 2/9] igc: Use netdev log helpers in igc_main.c

2020-05-14 Thread Andre Guedes
Hi Heiner, Quoting Heiner Kallweit (2020-05-14 15:07:42) > On 14.05.2020 23:31, Jeff Kirsher wrote: > > @@ -4877,8 +4870,7 @@ static int igc_probe(struct pci_dev *pdev, > > > > if (igc_get_flash_presence_i225(hw)) { > > if (hw->nvm.ops.validate(hw) < 0) { > > -

Re: [PATCH v2 bpf-next 4/7] printk: add type-printing %pT format specifier which uses BTF

2020-05-14 Thread Alan Maguire
On Wed, 13 May 2020, Yonghong Song wrote: > > > On 5/11/20 10:56 PM, Alan Maguire wrote: > > printk supports multiple pointer object type specifiers (printing > > netdev features etc). Extend this support using BTF to cover > > arbitrary types. "%pT" specifies the typed format, and the poin

Re: [PATCH 6/9] bpf: Compile bpfwl tool at kernel compilation start

2020-05-14 Thread Andrii Nakryiko
On Wed, May 6, 2020 at 6:31 AM Jiri Olsa wrote: > > The bpfwl tool will be used during the vmlinux linking, > so it's necessary it's ready. > > Signed-off-by: Jiri Olsa > --- > Makefile | 21 + > tools/Makefile | 3 +++ > tools/bpf/Makefile | 5 - > 3 file

Re: [PATCH 0/8 net] the indirect flow_block offload, revisited

2020-05-14 Thread Pablo Neira Ayuso
On Thu, May 14, 2020 at 12:44:48PM +0100, Edward Cree wrote: > On 13/05/2020 17:41, Pablo Neira Ayuso wrote: > > Hi, > > > > This patchset fixes the indirect flow_block support for the tc CT action > > offload. Please, note that this batch is probably slightly large for the > > net tree, however, I

Re: [PATCH 4/9] bpf: Allow nested BTF object to be refferenced by BTF object + offset

2020-05-14 Thread Andrii Nakryiko
On Wed, May 6, 2020 at 6:31 AM Jiri Olsa wrote: > > Adding btf_struct_address function that takes 2 BTF objects > and offset as arguments and checks wether object A is nested > in object B on given offset. > > This function is be used when checking the helper function > PTR_TO_BTF_ID arguments. If

[PATCH v17 17/23] LSM: security_secid_to_secctx in netlink netfilter

2020-05-14 Thread Casey Schaufler
Change netlink netfilter interfaces to use lsmcontext pointers, and remove scaffolding. Reviewed-by: Kees Cook Reviewed-by: John Johansen Acked-by: Stephen Smalley Signed-off-by: Casey Schaufler cc: netdev@vger.kernel.org --- net/netfilter/nfnetlink_queue.c | 31 --

[PATCH v17 15/23] LSM: Use lsmcontext in security_secid_to_secctx

2020-05-14 Thread Casey Schaufler
Replace the (secctx,seclen) pointer pair with a single lsmcontext pointer to allow return of the LSM identifier along with the context and context length. This allows security_release_secctx() to know how to release the context. Callers have been modified to use or save the returned data from the n

[PATCH v17 14/23] LSM: Ensure the correct LSM context releaser

2020-05-14 Thread Casey Schaufler
Add a new lsmcontext data structure to hold all the information about a "security context", including the string, its size and which LSM allocated the string. The allocation information is necessary because LSMs have different policies regarding the lifecycle of these strings. SELinux allocates and

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Alan Maguire
On Wed, 13 May 2020, Andrii Nakryiko wrote: > On Wed, May 13, 2020 at 2:59 PM Alan Maguire wrote: > > > > > > - attach a kprobe program to record the data via bpf_ringbuf_reserve(), > > and store the reserved pointer value in a per-task keyed hashmap. > > Then record the values of interest in

RE: [net-next v2 3/9] igc: add support to eeprom, registers and link self-tests

2020-05-14 Thread Kirsher, Jeffrey T
> -Original Message- > From: David Miller > Sent: Thursday, May 14, 2020 15:08 > To: k...@kernel.org > Cc: Kirsher, Jeffrey T ; Lifshits, Vitaly > ; netdev@vger.kernel.org; nhor...@redhat.com; > sassm...@redhat.com; lkp ; dan.carpen...@oracle.com; > Brown, Aaron F > Subject: Re: [net-next

Re: [PATCH net-next] net: dsa: sja1105: disable rxvlan offload for the DSA master

2020-05-14 Thread David Miller
From: Vladimir Oltean Date: Wed, 13 May 2020 02:49:21 +0300 > From: Vladimir Oltean > > On sja1105 operating in best_effort_vlan_filtering mode (when the TPID > of the DSA tags is 0x8100), it can be seen that __netif_receive_skb_core > calls __vlan_hwaccel_clear_tag right before passing the skb

Re: [PATCH 3/9] bpf: Add bpfwl tool to construct bpf whitelists

2020-05-14 Thread Andrii Nakryiko
On Wed, May 6, 2020 at 6:30 AM Jiri Olsa wrote: > > This tool takes vmlinux object and whitelist directory on input > and produces C source object with BPF whitelist data. > > The vmlinux object needs to have a BTF information compiled in. > > The whitelist directory is expected to contain files w

Re: [PATCH net-next 0/3] mptcp: fix MP_JOIN failure handling

2020-05-14 Thread David Miller
Paolo, please respond to the feedback you received for patch #1. Thank you.

[PATCH v17 05/23] net: Prepare UDS for security module stacking

2020-05-14 Thread Casey Schaufler
Change the data used in UDS SO_PEERSEC processing from a secid to a more general struct lsmblob. Update the security_socket_getpeersec_dgram() interface to use the lsmblob. There is a small amount of scaffolding code that will come out when the security_secid_to_secctx() code is brought in line wit

Re: [PATCH net] tcp: fix error recovery in tcp_zerocopy_receive()

2020-05-14 Thread David Miller
From: Eric Dumazet Date: Thu, 14 May 2020 13:58:13 -0700 > If user provides wrong virtual address in TCP_ZEROCOPY_RECEIVE > operation we want to return -EINVAL error. > > But depending on zc->recv_skip_hint content, we might return > -EIO error if the socket has SOCK_DONE set. > > Make sure to

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Paul E. McKenney
On Thu, May 14, 2020 at 02:30:11PM -0700, Andrii Nakryiko wrote: > On Thu, May 14, 2020 at 1:39 PM Thomas Gleixner wrote: > > > > Jakub Kicinski writes: > > > > > On Wed, 13 May 2020 12:25:27 -0700 Andrii Nakryiko wrote: > > >> One interesting implementation bit, that significantly simplifies (an

Re: [net-next v2 3/9] igc: add support to eeprom, registers and link self-tests

2020-05-14 Thread David Miller
From: Jakub Kicinski Date: Thu, 14 May 2020 14:52:19 -0700 > On Thu, 14 May 2020 14:31:11 -0700 Jeff Kirsher wrote: >> diff --git a/drivers/net/ethernet/intel/igc/igc_diag.c >> b/drivers/net/ethernet/intel/igc/igc_diag.c >> new file mode 100644 >> index ..1c4536105e56 >> --- /dev/nul

Re: [net-next v2 2/9] igc: Use netdev log helpers in igc_main.c

2020-05-14 Thread Heiner Kallweit
On 14.05.2020 23:31, Jeff Kirsher wrote: > From: Andre Guedes > > In igc_main.c we print log messages using both dev_* and netdev_* > helpers, generating inconsistent output. Since this is a network device > driver, we should preferably use netdev_* helpers because they append > the interface nam

Re: [PATCH 1/9] bpf: Add d_path helper

2020-05-14 Thread Andrii Nakryiko
On Wed, May 6, 2020 at 6:30 AM Jiri Olsa wrote: > > Adding d_path helper function that returns full path > for give 'struct path' object, which needs to be the > kernel BTF 'path' object. > > The helper calls directly d_path function. > > Updating also bpf.h tools uapi header and adding > 'path' t

Re: [PATCH net-next 2/2] net: phy: DP83822: Add ability to advertise Fiber connection

2020-05-14 Thread Dan Murphy
Andrew On 5/14/20 1:52 PM, Andrew Lunn wrote: +static int dp83822_config_init(struct phy_device *phydev) +{ + struct dp83822_private *dp83822 = phydev->priv; + int err = 0; + + if (dp83822->fx_enabled) { + linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BIT, +

Re: [net-next v2 3/9] igc: add support to eeprom, registers and link self-tests

2020-05-14 Thread Jakub Kicinski
On Thu, 14 May 2020 14:31:11 -0700 Jeff Kirsher wrote: > diff --git a/drivers/net/ethernet/intel/igc/igc_diag.c > b/drivers/net/ethernet/intel/igc/igc_diag.c > new file mode 100644 > index ..1c4536105e56 > --- /dev/null > +++ b/drivers/net/ethernet/intel/igc/igc_diag.c > @@ -0,0 +1,186

r8169: remove not needed checks in rtl8169_set_eee

2020-05-14 Thread Heiner Kallweit
After 9de5d235b60a ("net: phy: fix aneg restart in phy_ethtool_set_eee") we don't need the check for aneg being enabled any longer, and as discussed with Russell configuring the EEE advertisement should be supported even if we're in a half-duplex mode currently. Signed-off-by: Heiner Kallweit ---

r8169: don't include linux/moduleparam.h

2020-05-14 Thread Heiner Kallweit
93882c6f210a ("r8169: switch from netif_xxx message functions to netdev_xxx") removed the last module parameter from the driver, therefore there's no need any longer to include linux/moduleparam.h. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 1 - 1 file changed

Re: [PATCH AUTOSEL 5.6 30/62] net: Make PTP-specific drivers depend on PTP_1588_CLOCK

2020-05-14 Thread Arnd Bergmann
On Thu, May 14, 2020 at 8:52 PM Sasha Levin wrote: > > From: Clay McClure > > [ Upstream commit b6d49cab44b567b3e0a5544b3d61e516a7355fad ] > > Commit d1cbfd771ce8 ("ptp_clock: Allow for it to be optional") changed > all PTP-capable Ethernet drivers from `select PTP_1588_CLOCK` to `imply > PTP_158

[net-next v2 5/9] igc: Use netdev log helpers in igc_ptp.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes In igc_ptp.c we print log messages using dev_* helpers, generating inconsistent output with the rest of the driver. Since this is a network device driver, we should preferably use netdev_* helpers because they append the interface name to the message, helping making sense out o

[net-next v2 3/9] igc: add support to eeprom, registers and link self-tests

2020-05-14 Thread Jeff Kirsher
From: Vitaly Lifshits Introduced igc_diag.c and igc_diag.h, these files have the diagnostics functionality of igc driver. For the time being these files are being used by ethtool self-test callbacks. Which mean that eeprom, registers and link self-tests for ethtool were implemented. Signed-off-b

[net-next v2 8/9] igc: Remove unneeded definition

2020-05-14 Thread Jeff Kirsher
From: Sasha Neftin PHY_FORCE_LIMIT definition not in use and could be removed i225 parts support auto negotiation mechanism Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_defines.h | 1 - 1 file changed, 1 deletion(-) di

[net-next v2 2/9] igc: Use netdev log helpers in igc_main.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes In igc_main.c we print log messages using both dev_* and netdev_* helpers, generating inconsistent output. Since this is a network device driver, we should preferably use netdev_* helpers because they append the interface name to the message, helping making sense out of the log

[net-next v2 7/9] igc: Use netdev log helpers in igc_base.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes This patch coverts one pr_debug() call to hw_dbg() in order to keep log output aligned with the rest of the driver. hw_dbg() is actually a macro defined in igc_hw.h that expands to netdev_dbg(). It also takes this opportunity to remove the '\n' character at the end of messages

[net-next v2 6/9] igc: Use netdev log helpers in igc_dump.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes In igc_dump.c we print log messages using dev_* and pr_* helpers, generating inconsistent output with the rest of the driver. Since this is a network device driver, we should preferably use netdev_* helpers because they append the interface name to the message, helping making s

[net-next v2 1/9] igc: Add ECN support for TSO

2020-05-14 Thread Jeff Kirsher
From: Sasha Neftin Align with other Intel drivers and add ECN support for TSO. Add NETIF_F_TSO_ECN flag Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ne

[net-next v2 9/9] igc: Remove unneeded register

2020-05-14 Thread Jeff Kirsher
From: Sasha Neftin Flow control status register not applicable for i225 parts so clean up the unneeded define. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igc/igc_regs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drive

[net-next v2 4/9] igc: Use netdev log helpers in igc_ethtool.c

2020-05-14 Thread Jeff Kirsher
From: Andre Guedes In igc_ethtool.c we print log messages using dev_* helpers, generating inconsistent output with the rest of the driver. Since this is a network device driver, we should preferably use netdev_* helpers because they append the interface name to the message, helping making sense t

[net-next v2 0/9][pull request] 1GbE Intel Wired LAN Driver Updates 2020-05-14

2020-05-14 Thread Jeff Kirsher
This series contains updates to igc driver only. Sasha adds ECN support for TSO by adding the NETIF_F_TSO_ECN flag, which aligns with other Intel drivers. Also cleaned up defines that are not supported or used in the igc driver. Andre does most of the changes with updating the log messages for i

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Andrii Nakryiko
On Thu, May 14, 2020 at 1:39 PM Thomas Gleixner wrote: > > Jakub Kicinski writes: > > > On Wed, 13 May 2020 12:25:27 -0700 Andrii Nakryiko wrote: > >> One interesting implementation bit, that significantly simplifies (and thus > >> speeds up as well) implementation of both producers and consumers

Re: [PATCH] MAINTAINERS: Add Jakub to networking drivers.

2020-05-14 Thread Andrew Lunn
On Thu, May 14, 2020 at 01:14:03PM -0700, David Miller wrote: > > Signed-off-by: David S. Miller > --- > > Honestly this is just a formality as NETWORKING general is > a superset of this. > > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > inde

Re: [PATCH bpf-next 1/6] bpf: implement BPF ring buffer and verifier support for it

2020-05-14 Thread Andrii Nakryiko
On Thu, May 14, 2020 at 1:53 PM wrote: > > On 05/14, Andrii Nakryiko wrote: > > On Thu, May 14, 2020 at 10:33 AM wrote: > > > > > > On 05/13, Andrii Nakryiko wrote: > > [...] > > > > > + * void bpf_ringbuf_submit(void *data) > > > > + * Description > > > > + * Submit reserved ring buf

Re: [PATCH bpf 0/3] Restrict bpf_probe_read{,str}() and bpf_trace_printk()'s %s

2020-05-14 Thread Daniel Borkmann
On 5/14/20 9:58 PM, Christoph Hellwig wrote: On Thu, May 14, 2020 at 09:54:06PM +0200, Daniel Borkmann wrote: On 5/14/20 6:58 PM, Christoph Hellwig wrote: On Thu, May 14, 2020 at 06:16:04PM +0200, Daniel Borkmann wrote: Small set of fixes in order to restrict BPF helpers for tracing which are

  1   2   3   4   5   >