Re: [PATCH iproute2-next v3] devlink: support kernel-side snapshot id allocation

2020-05-01 Thread Jiri Pirko
Thu, Apr 30, 2020 at 07:57:59PM CEST, k...@kernel.org wrote: >Make ID argument optional and read the snapshot info >that kernel sends us. > >$ devlink region new netdevsim/netdevsim1/dummy >netdevsim/netdevsim1/dummy: snapshot 0 >$ devlink -jp region new netdevsim/netdevsim1/dummy >{ >"regions"

Re: [PATCH] net: fix memory leaks in flush_backlog() with RPS

2020-05-01 Thread Qian Cai
> On May 1, 2020, at 11:32 PM, Eric Dumazet wrote: > > kfree_skb() is supposed to call skb_dst_drop() (look in > skb_release_head_state()) > > If you think about it, we would have hundreds of similar bugs if this was not > the case. Thanks for quick response. Funny thing is that once I app

[PATCH v2 net-next 0/3] ptp: Add adjust phase to support phase offset.

2020-05-01 Thread vincent.cheng.xh
From: Vincent Cheng This series adds adjust phase to the PTP Hardware Clock device interface. Some PTP hardware clocks have a write phase mode that has a built-in hardware filtering capability. The write phase mode utilizes a phase offset control word instead of a frequency offset control word

[PATCH v2 net-next 1/3] ptp: Add adjphase function to support phase offset control.

2020-05-01 Thread vincent.cheng.xh
From: Vincent Cheng Adds adjust phase function to take advantage of a PHC clock's hardware filtering capability that uses phase offset control word instead of frequency offset control word. Signed-off-by: Vincent Cheng --- drivers/ptp/ptp_clock.c | 3 +++ include/linux/ptp_clock_kerne

[PATCH v2 net-next 2/3] ptp: Add adjust_phase to ptp_clock_caps capability.

2020-05-01 Thread vincent.cheng.xh
From: Vincent Cheng Add adjust_phase to ptp_clock_caps capability to allow user to query if a PHC driver supports adjust phase with ioctl PTP_CLOCK_GETCAPS command. Signed-off-by: Vincent Cheng Reviewed-by: Richard Cochran --- drivers/ptp/ptp_chardev.c | 1 + include/uapi/linux/pt

[PATCH v2 net-next 3/3] ptp: ptp_clockmatrix: Add adjphase() to support PHC write phase mode.

2020-05-01 Thread vincent.cheng.xh
From: Vincent Cheng Add idtcm_adjphase() to support PHC write phase mode. Signed-off-by: Vincent Cheng --- drivers/ptp/ptp_clockmatrix.c | 92 +++ drivers/ptp/ptp_clockmatrix.h | 8 +++- 2 files changed, 98 insertions(+), 2 deletions(-) diff --git a/dr

Re: [PATCH] net: fix memory leaks in flush_backlog() with RPS

2020-05-01 Thread Eric Dumazet
On 5/1/20 8:15 PM, Qian Cai wrote: > netif_receive_skb_list_internal() could call enqueue_to_backlog() to put > some skb to softnet_data.input_pkt_queue and then in > ip_route_input_slow(), it allocates a dst_entry to be used in > skb_dst_set(). Later, > > cleanup_net > default_device_exit_ba

[PATCH] net: fix memory leaks in flush_backlog() with RPS

2020-05-01 Thread Qian Cai
netif_receive_skb_list_internal() could call enqueue_to_backlog() to put some skb to softnet_data.input_pkt_queue and then in ip_route_input_slow(), it allocates a dst_entry to be used in skb_dst_set(). Later, cleanup_net default_device_exit_batch unregister_netdevice_many rollback_reg

Re: [PATCH] bpf: Tweak BPF jump table optimizations for objtool compatibility

2020-05-01 Thread Alexei Starovoitov
On Fri, May 01, 2020 at 02:56:17PM -0500, Josh Poimboeuf wrote: > On Fri, May 01, 2020 at 12:40:53PM -0700, Alexei Starovoitov wrote: > > On Fri, May 01, 2020 at 02:22:04PM -0500, Josh Poimboeuf wrote: > > > On Fri, May 01, 2020 at 12:09:30PM -0700, Alexei Starovoitov wrote: > > > > On Thu, Apr 30,

[PATCH net 1/1] neigh: send protocol value in neighbor create notification

2020-05-01 Thread Roman Mashak
When a new neighbor entry has been added, event is generated but it does not include protocol, because its value is assigned after the event notification routine has run, so move protocol assignment code earlier. Fixes: df9b0e30d44c ("neighbor: Add protocol attribute") Cc: David Ahern Signed-off-

Re: [RFC PATCH bpf-next 0/6] bpf, printk: add BTF-based type printing

2020-05-01 Thread Joe Perches
On Thu, 2020-04-30 at 03:03 -0700, Alan Maguire wrote: > On Mon, 20 Apr 2020, Joe Perches wrote: > > Here as well the individual field types don't contain > > enough information to determine if a field should be > > output as %x or %u. > Right, we could add some more format modifiers for cases > l

linux-next: Fixes tags needs some work in the net tree

2020-05-01 Thread Stephen Rothwell
Hi all, In commit 6c599044b0c1 ("net: phy: DP83TC811: Fix WoL in config init to be disabled") Fixes tag Fixes: 6d749428788b ("net: phy: DP83TC811: Introduce support for the has these problem(s): - Target SHA1 does not exist Maybe you meant Fixes: b753a9faaf9a ("net: phy: DP83TC811: In

Re: pull-request: bpf-next 2020-05-01 (v2)

2020-05-01 Thread David Miller
From: Alexei Starovoitov Date: Fri, 1 May 2020 16:55:18 -0700 > The following pull-request contains BPF updates for your *net-next* tree. > > We've added 61 non-merge commits during the last 6 day(s) which contain > a total of 153 files changed, 6739 insertions(+), 3367 deletions(-). > > The m

pull-request: bpf-next 2020-05-01 (v2)

2020-05-01 Thread Alexei Starovoitov
Hi David, The following pull-request contains BPF updates for your *net-next* tree. We've added 61 non-merge commits during the last 6 day(s) which contain a total of 153 files changed, 6739 insertions(+), 3367 deletions(-). The main changes are: 1) pulled work.sysctl from vfs tree with sysctl

Re: [PATCH bpf-next] selftests/bpf: use reno instead of dctcp

2020-05-01 Thread Alexei Starovoitov
On Fri, May 1, 2020 at 3:57 PM Martin KaFai Lau wrote: > > On Fri, May 01, 2020 at 03:43:20PM -0700, Stanislav Fomichev wrote: > > Andrey pointed out that we can use reno instead of dctcp for CC > > tests and drop CONFIG_TCP_CONG_DCTCP=y requirement. > Acked-by: Martin KaFai Lau Applied. Thanks

Re: [PATCH 1/1] selftests/bpf: add cls_redirect classifier

2020-05-01 Thread Daniel Borkmann
On 4/27/20 11:45 AM, Lorenz Bauer wrote: On Sun, 26 Apr 2020 at 18:33, Alexei Starovoitov wrote: [...] +/* Linux packet pointers are either aligned to NET_IP_ALIGN (aka 2 bytes), + * or not aligned if the arch supports efficient unaligned access. + * + * Since the verifier ensures that eBPF pa

Re: [PATCH net-next 00/13] net/smc: extent buffer mapping and port handling

2020-05-01 Thread David Miller
From: Karsten Graul Date: Fri, 1 May 2020 12:48:00 +0200 > Add functionality to map/unmap and register/unregister memory buffers for > specific SMC-R links and for the whole link group. Prepare LLC layer messages > for the support of multiple links and extent the processing of adapter events. >

Re: [v5,net-next 0/4] Introduce a flow gate control action and apply IEEE

2020-05-01 Thread David Miller
From: Po Liu Date: Fri, 1 May 2020 08:53:14 +0800 ... > These patches add stream gate action policing in IEEE802.1Qci (Per-Stream > Filtering and Policing) software support and hardware offload support in > tc flower, and implement the stream identify, stream filtering and > stream gate filteri

Re: [PATCH net-next 0/2] ethtool: Add support for 100Gbps per lane link modes

2020-05-01 Thread David Miller
From: Saeed Mahameed Date: Thu, 30 Apr 2020 16:41:04 -0700 > This small series adds new ethtool link modes bits to > Define 100G, 200G and 400G link modes using 100Gbps per lane. Andrew, could you please give this series a quick review? Thank you.

Re: [PATCH bpf-next] selftests/bpf: use reno instead of dctcp

2020-05-01 Thread Martin KaFai Lau
On Fri, May 01, 2020 at 03:43:20PM -0700, Stanislav Fomichev wrote: > Andrey pointed out that we can use reno instead of dctcp for CC > tests and drop CONFIG_TCP_CONG_DCTCP=y requirement. Acked-by: Martin KaFai Lau

Re: [PATCH net-next] net: bcmgenet: Move wake-up event out of side band ISR

2020-05-01 Thread David Miller
From: Doug Berger Date: Thu, 30 Apr 2020 16:26:51 -0700 > The side band interrupt service routine is not available on chips > like 7211, or rather, it does not permit the signaling of wake-up > events due to the complex interrupt hierarchy. > > Move the wake-up event accounting into a .resume_no

Re: [PATCH net-next 0/2] net: ipa: don't cache channel state

2020-05-01 Thread David Miller
From: Alex Elder Date: Thu, 30 Apr 2020 17:13:21 -0500 > This series removes a field that holds a copy of a channel's state > at the time it was last fetched. In principle the state can change > at any time, so it's better to just fetch it whenever needed. The > first patch is just preparatory,

Re: [PATCH v2 bpf-next] bpf: fix use-after-free of bpf_link when priming half-fails

2020-05-01 Thread Alexei Starovoitov
On Fri, May 1, 2020 at 1:00 PM Martin KaFai Lau wrote: > > On Fri, May 01, 2020 at 11:56:22AM -0700, Andrii Nakryiko wrote: > > If bpf_link_prime() succeeds to allocate new anon file, but then fails to > > allocate ID for it, link priming is considered to be failed and user is > > supposed ot be a

Re: [PATCH net-next v2] net: ethernet: fec: Prevent MII event after MII_SPEED write

2020-05-01 Thread Andrew Lunn
On Fri, May 01, 2020 at 03:29:54PM -0700, David Miller wrote: > From: Andrew Lunn > Date: Wed, 29 Apr 2020 22:53:23 +0200 > > > The change to polled IO for MDIO completion assumes that MII events > > are only generated for MDIO transactions. However on some SoCs writing > > to the MII_SPEED regis

Re: [PATCH v2 net-next 0/4] Cross-chip bridging for disjoint DSA trees

2020-05-01 Thread David Miller
From: Vladimir Oltean Date: Thu, 30 Apr 2020 23:25:38 +0300 > This series adds support for boards where DSA switches of multiple types > are cascaded together. ... I'm expecting another respin of this once you sort out the symmetry issues.

Re: [PATCH net-next 0/2] net: dsa: mv88e6xxx: augment phylink support for 10G

2020-05-01 Thread David Miller
From: Russell King - ARM Linux admin Date: Thu, 30 Apr 2020 09:21:04 +0100 > This series adds phylink 10G support for the 88E6390 series switches, > as suggested by Andrew Lunn. > > The first patch cleans up the code to use generic definitions for the > registers in a similar way to what was don

Re: [PATCH v2 net-next 00/17] net: atlantic: A2 support

2020-05-01 Thread David Miller
From: Igor Russkikh Date: Thu, 30 Apr 2020 11:04:28 +0300 > This patchset adds support for the new generation of Atlantic NICs. > > Chip generations are mostly compatible register-wise, but there are still > some differences. Therefore we've made some of first generation (A1) code > non-static t

Re: [PATCH net] gtp: set NLM_F_MULTI flag in gtp_genl_dump_pdp()

2020-05-01 Thread David Miller
From: Yoshiyuki Kurauchi Date: Thu, 30 Apr 2020 14:01:36 +0900 > In drivers/net/gtp.c, gtp_genl_dump_pdp() should set NLM_F_MULTI > flag since it returns multipart message. > This patch adds a new arg "flags" in gtp_genl_fill_info() so that > flags can be set by the callers. > > Signed-off-by: Y

Re: [net] ice: cleanup language in ice.rst for fw.app

2020-05-01 Thread David Miller
From: Jacob Keller Date: Wed, 29 Apr 2020 13:59:50 -0700 > The documentation for the ice driver around "fw.app" has a spelling > mistake in variation. Additionally, the language of "shall have a unique > name" sounds like a requirement. Reword this to read more like > a description or property. >

Re: [PATCH net-next v2] net: ethernet: fec: Prevent MII event after MII_SPEED write

2020-05-01 Thread David Miller
From: Andrew Lunn Date: Wed, 29 Apr 2020 22:53:23 +0200 > The change to polled IO for MDIO completion assumes that MII events > are only generated for MDIO transactions. However on some SoCs writing > to the MII_SPEED register can also trigger an MII event. As a result, > the next MDIO read has a

Re: [PATCH v2] net: Make PTP-specific drivers depend on PTP_1588_CLOCK

2020-05-01 Thread David Miller
From: Clay McClure Date: Wed, 29 Apr 2020 00:59:00 -0700 > Commit d1cbfd771ce8 ("ptp_clock: Allow for it to be optional") changed > all PTP-capable Ethernet drivers from `select PTP_1588_CLOCK` to `imply > PTP_1588_CLOCK`, "in order to break the hard dependency between the PTP > clock subsystem a

Re: [PATCH net-next v2] drivers: net: davinci_mdio: fix potential NULL dereference in davinci_mdio_probe()

2020-05-01 Thread David Miller
From: Wei Yongjun Date: Wed, 29 Apr 2020 02:52:20 + > platform_get_resource() may fail and return NULL, so we should > better check it's return value to avoid a NULL pointer dereference > since devm_ioremap() does not check input parameters for null. > > This is detected by Coccinelle semant

Re: [PATCH v2] hv_netvsc: Fix netvsc_start_xmit's return type

2020-05-01 Thread David Miller
From: Nathan Chancellor Date: Tue, 28 Apr 2020 10:54:56 -0700 > netvsc_start_xmit is used as a callback function for the ndo_start_xmit > function pointer. ndo_start_xmit's return type is netdev_tx_t but > netvsc_start_xmit's return type is int. > > This causes a failure with Control Flow Integr

Re: [PATCH net v3 0/2] WoL fixes for DP83822 and DP83tc811

2020-05-01 Thread David Miller
From: Dan Murphy Date: Tue, 28 Apr 2020 11:03:52 -0500 > The WoL feature for each device was enabled during boot or when the PHY was > brought up which may be undesired. These patches disable the WoL in the > config_init. The disabling and enabling of the WoL is now done though the > set_wol ca

Re: [PATCH net] dt-bindings: net: Convert UniPhier AVE4 controller to json-schema

2020-05-01 Thread David Miller
From: Kunihiko Hayashi Date: Tue, 28 Apr 2020 15:31:22 +0900 > Convert the UniPhier AVE4 controller binding to DT schema format. > This changes phy-handle property to required. > > Signed-off-by: Kunihiko Hayashi DT folks, is it ok if I take this into net-next or do you folks want to take it i

Re: [PATCH net-next] net: fix skb_panic to output real address

2020-05-01 Thread David Miller
From: Jesper Dangaard Brouer Date: Mon, 27 Apr 2020 18:37:43 +0200 > In skb_panic() the real pointer values are really needed to diagnose > issues, e.g. data and head are related (to calculate headroom). The > hashed versions of the addresses doesn't make much sense here. The > patch use the prin

Re: [PATCH bpf-next v3] bpf: bpf_{g,s}etsockopt for struct bpf_sock_addr

2020-05-01 Thread Andrey Ignatov
Stanislav Fomichev [Fri, 2020-05-01 15:07 -0700]: > On Fri, May 1, 2020 at 2:52 PM Andrey Ignatov wrote: > > > > Stanislav Fomichev [Thu, 2020-04-30 16:32 -0700]: > > > Currently, bpf_getsockopt and bpf_setsockopt helpers operate on the > > > 'struct bpf_sock_ops' context in BPF_PROG_TYPE_SOCK_O

Re: [PATCH net-next v3] net: Replace the limit of TCP_LINGER2 with TCP_FIN_TIMEOUT_MAX

2020-05-01 Thread David Miller
From: Cambda Zhu Date: Fri, 24 Apr 2020 16:06:16 +0800 > This patch changes the behavior of TCP_LINGER2 about its limit. The > sysctl_tcp_fin_timeout used to be the limit of TCP_LINGER2 but now it's > only the default value. A new macro named TCP_FIN_TIMEOUT_MAX is added > as the limit of TCP_LIN

Re: [PATCH v5] net: Option to retrieve the pending data from send queue of UDP socket

2020-05-01 Thread David Miller
From: Lese Doru Calin Date: Fri, 24 Apr 2020 01:15:15 +0300 > @@ -1794,18 +1924,8 @@ int udp_recvmsg(struct sock *sk, struct msghdr *msg, > size_t len, int noblock, > > sock_recv_ts_and_drops(msg, sk, skb); > > - /* Copy the address. */ > - if (sin) { > - sin->sin_f

Re: [PATCH net-next 1/4] arm64: dts: sdm845: add IPA iommus property

2020-05-01 Thread Alex Elder
On 5/1/20 4:46 PM, Alex Elder wrote: Add an "iommus" property to the IPA node in "sdm845.dtsi". It is required because there are two regions of memory the IPA accesses through an SMMU. The next few patches define and map those regions. Signed-off-by: Alex Elder I'm very sorry, I grouped the

Re: [PATCH RFC v2 02/11] dt-bindings: net: dwmac-meson: Document the "timing-adjustment" clock

2020-05-01 Thread Martin Blumenstingl
Hi Rob, On Fri, May 1, 2020 at 11:09 PM Rob Herring wrote: > > On Wed, 29 Apr 2020 22:16:35 +0200, Martin Blumenstingl wrote: > > The PRG_ETHERNET registers can add an RX delay in RGMII mode. This > > requires an internal re-timing circuit whose input clock is called > > "timing adjustment clock"

Re: [PATCH bpf-next v3] bpf: bpf_{g,s}etsockopt for struct bpf_sock_addr

2020-05-01 Thread Andrey Ignatov
Stanislav Fomichev [Thu, 2020-04-30 16:32 -0700]: > Currently, bpf_getsockopt and bpf_setsockopt helpers operate on the > 'struct bpf_sock_ops' context in BPF_PROG_TYPE_SOCK_OPS program. > Let's generalize them and make them available for 'struct bpf_sock_addr'. > That way, in the future, we can a

[PATCH net-next 4/4] net: ipa: define SMEM memory region for IPA

2020-05-01 Thread Alex Elder
Arrange to use an item from SMEM memory for IPA. SMEM item number 497 is designated to be used by the IPA. Specify the item ID and size of the region in platform configuration data. Allocate and get a pointer to this region from ipa_mem_init(). The memory must be mapped for access through an SM

[PATCH net-next 3/4] net: ipa: define IMEM memory region for IPA

2020-05-01 Thread Alex Elder
Define a region of IMEM memory available for use by IPA in the platform configuration data. Initialize it from ipa_mem_init(). The memory must be mapped for access through an SMMU. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa.h | 5 ++ drivers/net/ipa/ipa_data-sc7180.c | 2 +

[PATCH net-next 2/4] net: ipa: redefine struct ipa_mem_data

2020-05-01 Thread Alex Elder
The ipa_mem_data structure type was never actually used. Instead, the IPA memory regions were defined using the ipa_mem structure. Redefine struct ipa_mem_data so it encapsulates the array of IPA-local memory region descriptors along with the count of entries in that array. Pass just an ipa_mem

[PATCH net-next 1/4] arm64: dts: sdm845: add IPA iommus property

2020-05-01 Thread Alex Elder
Add an "iommus" property to the IPA node in "sdm845.dtsi". It is required because there are two regions of memory the IPA accesses through an SMMU. The next few patches define and map those regions. Signed-off-by: Alex Elder --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++ 1 file changed, 2 in

[PATCH net-next 0/4] net: ipa: I/O map SMEM and IMEM

2020-05-01 Thread Alex Elder
This series adds the definition of two memory regions that must be mapped for IPA to access through an SMMU. It defines the SMMU for the SDM845 SoC; the SC7180 already had this defined, though these memory regions were not previously defined or mapped. -Ale

[PATCH] dt-bindings: net: add IPA iommus property

2020-05-01 Thread Alex Elder
The IPA accesses "IMEM" and main system memory through an SMMU, so its DT node requires an iommus property to define range of stream IDs it uses. Signed-off-by: Alex Elder --- Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) dif

Re: [PATCH net-next v2] devlink: let kernel allocate region snapshot id

2020-05-01 Thread Jacob Keller
On 5/1/2020 2:32 PM, Jakub Kicinski wrote: > On Fri, 1 May 2020 21:23:25 + Keller, Jacob E wrote: >>> Could you please send the snapshot id just before you return 0 in this >>> function, as you offered in v1? I think it would be great to do it like >>> that. >>> >> >> Also: Does it make sens

Re: [PATCH net-next v4 2/3] devlink: let kernel allocate region snapshot id

2020-05-01 Thread Jacob Keller
On 5/1/2020 9:40 AM, Jakub Kicinski wrote: > Currently users have to choose a free snapshot id before > calling DEVLINK_CMD_REGION_NEW. This is potentially racy > and inconvenient. > > Make the DEVLINK_ATTR_REGION_SNAPSHOT_ID optional and try > to allocate id automatically. Send a message back

Re: [PATCH net-next v4 1/3] devlink: factor out building a snapshot notification

2020-05-01 Thread Jacob Keller
On 5/1/2020 9:40 AM, Jakub Kicinski wrote: > We'll need to send snapshot info back on the socket > which requested a snapshot to be created. Factor out > constructing a snapshot description from the broadcast > notification code. > > v3: new patch > > Signed-off-by: Jakub Kicinski > Reviewed-

Re: [PATCH net-next v3 3/3] docs: devlink: clarify the scope of snapshot id

2020-05-01 Thread Jacob Keller
On 4/30/2020 10:57 AM, Jakub Kicinski wrote: > In past discussions Jiri explained snapshot ids are cross-region. > Explain this in the docs. > > v3: new patch > > Signed-off-by: Jakub Kicinski Reviewed-by: Jacob Keller

Re: [PATCH net-next v2] devlink: let kernel allocate region snapshot id

2020-05-01 Thread Jakub Kicinski
On Fri, 1 May 2020 21:23:25 + Keller, Jacob E wrote: > > Could you please send the snapshot id just before you return 0 in this > > function, as you offered in v1? I think it would be great to do it like > > that. > > > > Also: Does it make sense to send the snapshot id regardless of > whethe

Re: [PATCH net-next v3 2/3] devlink: let kernel allocate region snapshot id

2020-05-01 Thread Jacob Keller
On 4/30/2020 10:57 AM, Jakub Kicinski wrote: > Currently users have to choose a free snapshot id before > calling DEVLINK_CMD_REGION_NEW. This is potentially racy > and inconvenient. > > Make the DEVLINK_ATTR_REGION_SNAPSHOT_ID optional and try > to allocate id automatically. Send a message bac

[PATCH net-next 2/2] r8169: use fsleep in polling functions

2020-05-01 Thread Heiner Kallweit
Use new flexible sleep function fsleep() to merge the udelay and msleep polling functions. We can safely do this because no polling function is used in atomic context in this driver. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 108 +- 1 file

[PATCH net-next 1/2] timer: add fsleep for flexible sleeping

2020-05-01 Thread Heiner Kallweit
Sleeping for a certain amount of time requires use of different functions, depending on the time period. Documentation/timers/timers-howto.rst explains when to use which function, and also checkpatch checks for some potentially problematic cases. So let's create a helper that automatically chooses

Re: [PATCH net-next v3 1/3] devlink: factor out building a snapshot notification

2020-05-01 Thread Jacob Keller
On 4/30/2020 10:57 AM, Jakub Kicinski wrote: > We'll need to send snapshot info back on the socket > which requested a snapshot to be created. Factor out > constructing a snapshot description from the broadcast > notification code. > > v3: new patch > > Signed-off-by: Jakub Kicinski > --- Re

[PATCH net-next 0/2] timer: add fsleep for flexible sleeping

2020-05-01 Thread Heiner Kallweit
Sleeping for a certain amount of time requires use of different functions, depending on the time period. Documentation/timers/timers-howto.rst explains when to use which function, and also checkpatch checks for some potentially problematic cases. So let's create a helper that automatically chooses

RE: [PATCH net-next v2] devlink: let kernel allocate region snapshot id

2020-05-01 Thread Keller, Jacob E
> -Original Message- > From: Jiri Pirko > Sent: Wednesday, April 29, 2020 9:53 PM > To: Jakub Kicinski > Cc: da...@davemloft.net; netdev@vger.kernel.org; kernel-t...@fb.com; > Keller, Jacob E > Subject: Re: [PATCH net-next v2] devlink: let kernel allocate region snapshot > id > > Th

Re: [PATCH RFC v2 02/11] dt-bindings: net: dwmac-meson: Document the "timing-adjustment" clock

2020-05-01 Thread Rob Herring
On Wed, 29 Apr 2020 22:16:35 +0200, Martin Blumenstingl wrote: > The PRG_ETHERNET registers can add an RX delay in RGMII mode. This > requires an internal re-timing circuit whose input clock is called > "timing adjustment clock". Document this clock input so the clock can be > enabled as needed. >

Re: [PATCH net-next v4 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-05-01 Thread Michal Kubecek
On Fri, May 01, 2020 at 05:52:10PM +0200, Michal Kubecek wrote: > On Fri, May 01, 2020 at 09:46:32AM +0200, Oleksij Rempel wrote: > [...] > > static int ethnl_update_linkmodes(struct genl_info *info, struct nlattr > > **tb, > > struct ethtool_link_ksettings *ksetting

[PATCH net-next 5/7] arm64: dts: ti: k3-am65-main: add main navss cpts node

2020-05-01 Thread Grygorii Strashko
Add DT node for Main NAVSS CPTS module. Signed-off-by: Grygorii Strashko --- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi index 6fbb0f2f1d9

[PATCH net-next 3/7] net: ethernet: ti: am65-cpsw-nuss: enable packet timestamping support

2020-05-01 Thread Grygorii Strashko
The MCU CPSW Common Platform Time Sync (CPTS) provides possibility to timestamp TX PTP packets and all RX packets. This enables corresponding support in TI AM65x/J721E MCU CPSW driver. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/Kconfig | 1 + drivers/net/ethernet

[PATCH net-next 7/7] arm64: dts: ti: j721e-main: add main navss cpts node

2020-05-01 Thread Grygorii Strashko
Add DT node for Main NAVSS CPTS module. Signed-off-by: Grygorii Strashko --- arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi index 0b9d14b838a1..844a

[PATCH net-next 6/7] arm64: dts: ti: k3-j721e-mcu: add mcu cpsw cpts node

2020-05-01 Thread Grygorii Strashko
Add DT node for The TI J721E MCU CPSW CPTS which is part of MCU CPSW NUSS. Signed-off-by: Grygorii Strashko --- arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k

[PATCH net-next 2/7] net: ethernet: ti: introduce am654 common platform time sync driver

2020-05-01 Thread Grygorii Strashko
The CPTS module is used to facilitate host control of time sync operations. Main features of CPTS module are: - selection of multiple external clock sources - control of time sync events via interrupt or polling - 64-bit timestamp mode in ns with HW PPM and nudge adjustment. - hardware timestamp ex

[PATCH net-next 4/7] arm64: dts: ti: k3-am65-mcu: add cpsw cpts node

2020-05-01 Thread Grygorii Strashko
Add DT node for the TI AM65x SoC Common Platform Time Sync (CPTS). Signed-off-by: Grygorii Strashko --- arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.d

[PATCH net-next 0/7] net: ethernet: ti: k3: introduce common platform time sync driver - cpts

2020-05-01 Thread Grygorii Strashko
Hi This series introduced support for significantly upgraded TI A65x/J721E Common platform time sync (CPTS) modules which are part of AM65xx Time Synchronization Architecture [1]. The TI A65x/J721E now contain more than one CPTS instance: - MCU CPSW CPTS (IEEE 1588 compliant) - Main NAVSS CPTS (ce

[PATCH net-next 1/7] dt-binding: ti: am65x: document common platform time sync cpts module

2020-05-01 Thread Grygorii Strashko
Document device tree bindings for TI AM654/J721E SoC The Common Platform Time Sync (CPTS) module. The CPTS module is used to facilitate host control of time sync operations. Main features of CPTS module are: - selection of multiple external clock sources - 64-bit timestamp mode in ns with ppm a

Re: [EXT] [PATCH 15/37] docs: networking: device drivers: convert aquantia/atlantic.txt to ReST

2020-05-01 Thread Igor Russkikh
On 01/05/2020 5:44 pm, Mauro Carvalho Chehab wrote: > External Email > > -- > - add SPDX header; > - use copyright symbol; > - adjust title and its markup; > - comment out text-only TOC from html/pdf output; > - mark code block

Re: [EXT] Re: [PATCH v2 net-next 15/17] net: atlantic: common functions needed for basic A2 init/deinit hw_ops

2020-05-01 Thread Igor Russkikh
> On Thu, 30 Apr 2020 11:04:43 +0300 Igor Russkikh wrote: >> +if (hw_atl_utils_ver_match(HW_ATL2_FW_VER_1X, >> + self->fw_ver_actual) == 0) { >> +*fw_ops = &aq_a2_fw_ops; >> +} else { >> +aq_pr_err("Bad FW version detected: %x, but con

Re: [PATCH v2 bpf-next] bpf: fix use-after-free of bpf_link when priming half-fails

2020-05-01 Thread Martin KaFai Lau
On Fri, May 01, 2020 at 11:56:22AM -0700, Andrii Nakryiko wrote: > If bpf_link_prime() succeeds to allocate new anon file, but then fails to > allocate ID for it, link priming is considered to be failed and user is > supposed ot be able to directly kfree() bpf_link, because it was never exposed > t

Re: [PATCH] bpf: Tweak BPF jump table optimizations for objtool compatibility

2020-05-01 Thread Josh Poimboeuf
On Fri, May 01, 2020 at 12:40:53PM -0700, Alexei Starovoitov wrote: > On Fri, May 01, 2020 at 02:22:04PM -0500, Josh Poimboeuf wrote: > > On Fri, May 01, 2020 at 12:09:30PM -0700, Alexei Starovoitov wrote: > > > On Thu, Apr 30, 2020 at 02:07:43PM -0500, Josh Poimboeuf wrote: > > > > Objtool decodes

Re: [PATCH net-next 0/4] r8169: improve user message handling

2020-05-01 Thread David Miller
From: Heiner Kallweit Date: Fri, 1 May 2020 19:20:25 +0200 > Series improves few aspects of handling messages to users. Series applied, thanks.

Re: [PATCH bpf-next v3] bpf: bpf_{g,s}etsockopt for struct bpf_sock_addr

2020-05-01 Thread Alexei Starovoitov
On Fri, May 1, 2020 at 11:33 AM John Fastabend wrote: > > Stanislav Fomichev wrote: > > Currently, bpf_getsockopt and bpf_setsockopt helpers operate on the > > 'struct bpf_sock_ops' context in BPF_PROG_TYPE_SOCK_OPS program. > > Let's generalize them and make them available for 'struct bpf_sock_ad

Re: [PATCH v2 net] ipv6: Use global sernum for dst validation with nexthop objects

2020-05-01 Thread David Miller
From: David Ahern Date: Fri, 1 May 2020 08:53:08 -0600 > Nik reported a bug with pcpu dst cache when nexthop objects are > used illustrated by the following: ... > Conversion of FIB entries to work with external nexthop objects > missed an important difference between IPv4 and IPv6 - how dst >

Re: [PATCH] bpf: Tweak BPF jump table optimizations for objtool compatibility

2020-05-01 Thread Alexei Starovoitov
On Fri, May 01, 2020 at 02:22:04PM -0500, Josh Poimboeuf wrote: > On Fri, May 01, 2020 at 12:09:30PM -0700, Alexei Starovoitov wrote: > > On Thu, Apr 30, 2020 at 02:07:43PM -0500, Josh Poimboeuf wrote: > > > Objtool decodes instructions and follows all potential code branches > > > within a functio

Re: [PATCH 00/37]net: manually convert files to ReST format - part 3 (final)

2020-05-01 Thread David Miller
From: Mauro Carvalho Chehab Date: Fri, 1 May 2020 16:44:22 +0200 > That's the third part (and the final one) of my work to convert the networking > text files into ReST. it is based on linux-next next-20200430 branch. > > The full series (including those ones) are at: > > https://git.lin

Re: [PATCH V8 mlx5-next 00/16] Add support to get xmit slave

2020-05-01 Thread Saeed Mahameed
On Fri, 2020-05-01 at 11:44 -0300, Jason Gunthorpe wrote: > On Thu, Apr 30, 2020 at 10:21:30PM +0300, Maor Gottlieb wrote: > > Hi Dave, > > > > This series is a combination of netdev and RDMA, so in order to > > avoid > > conflicts, we would like to ask you to route this series through > > mlx5-ne

Re: [PATCH] bpf: Tweak BPF jump table optimizations for objtool compatibility

2020-05-01 Thread Josh Poimboeuf
On Fri, May 01, 2020 at 12:09:30PM -0700, Alexei Starovoitov wrote: > On Thu, Apr 30, 2020 at 02:07:43PM -0500, Josh Poimboeuf wrote: > > Objtool decodes instructions and follows all potential code branches > > within a function. But it's not an emulator, so it doesn't track > > register values.

Re: [PATCH bpf-next] libbpf: fix probe code to return EPERM if encountered

2020-05-01 Thread Andrii Nakryiko
On Fri, May 1, 2020 at 2:56 AM Eelco Chaudron wrote: > > > > On 30 Apr 2020, at 20:12, Andrii Nakryiko wrote: > > > On Thu, Apr 30, 2020 at 3:24 AM Eelco Chaudron > > wrote: > >> > >> When the probe code was failing for any reason ENOTSUP was returned, > >> even > >> if this was due to no having

Re: NET: r8168/r8169 identifying fix

2020-05-01 Thread Lauri Jakku
Hi, On 19.4.2020 19.00, Heiner Kallweit wrote: On 19.04.2020 18:49, Lauri Jakku wrote: Hi, On 19.4.2020 18.09, Lauri Jakku wrote: Hi, On 18.4.2020 21.46, Lauri Jakku wrote: Hi, On 18.4.2020 14.06, Lauri Jakku wrote: Hi, On 17.4.2020 10.30, Lauri Jakku wrote: Hi, On 17.4.2020 9.23, La

Re: [PATCH net-next] r8169: remove not needed parameter in rtl8169_set_magic_reg

2020-05-01 Thread David Miller
From: Heiner Kallweit Date: Fri, 1 May 2020 10:11:28 +0200 > Remove a not needed parameter in rtl8169_set_magic_reg. > > Signed-off-by: Heiner Kallweit Applied, thanks.

Re: [PATCH] bpf: Tweak BPF jump table optimizations for objtool compatibility

2020-05-01 Thread Alexei Starovoitov
On Thu, Apr 30, 2020 at 02:07:43PM -0500, Josh Poimboeuf wrote: > Objtool decodes instructions and follows all potential code branches > within a function. But it's not an emulator, so it doesn't track > register values. For that reason, it usually can't follow > intra-function indirect branches,

Re: [PATCH bpf-next v1 11/19] bpf: add task and task/file targets

2020-05-01 Thread Andrii Nakryiko
On Fri, May 1, 2020 at 10:23 AM Yonghong Song wrote: > > > > On 4/29/20 7:08 PM, Andrii Nakryiko wrote: > > On Mon, Apr 27, 2020 at 1:17 PM Yonghong Song wrote: > >> > >> Only the tasks belonging to "current" pid namespace > >> are enumerated. > >> > >> For task/file target, the bpf program will

Re: [PATCH net-next V2] net: sched: fallback to qdisc noqueue if default qdisc setup fail

2020-05-01 Thread Jakub Kicinski
On Fri, 1 May 2020 13:56:02 +0200 Jesper Dangaard Brouer wrote: > On Thu, 30 Apr 2020 12:45:49 -0700 > Jakub Kicinski wrote: > > > On Thu, 30 Apr 2020 13:42:22 +0200 Jesper Dangaard Brouer wrote: > > > Currently if the default qdisc setup/init fails, the device ends up with > > > qdisc "noop",

[PATCH v2 bpf-next] bpf: fix use-after-free of bpf_link when priming half-fails

2020-05-01 Thread Andrii Nakryiko
If bpf_link_prime() succeeds to allocate new anon file, but then fails to allocate ID for it, link priming is considered to be failed and user is supposed ot be able to directly kfree() bpf_link, because it was never exposed to user-space. But at that point file already keeps a pointer to bpf_link

Re: [PATCH] lan743x: Added fixed_phy support / Question regarding proper devicetree

2020-05-01 Thread Andrew Lunn
On Fri, May 01, 2020 at 08:09:05PM +0200, Roelof Berg wrote: > Working status: I added fixed_phy support to the Microchip lan743x ethernet > driver and for upstream contribution I need to make it runtime configurable > via > the device tree. > > Question: > > There are, amongst other, the follow

Re: [PATCH] net: dsa: sja1105: fix speed setting for 10 MBPS

2020-05-01 Thread Russell King - ARM Linux admin
On Fri, May 01, 2020 at 06:00:52PM +, Walter Harms wrote: > IMHO it would be better to use switch case here to improve readability. > > switch (bmcr & mask) { > > case BMCR_SPEED1000: > speed = SPEED_1000; > break; > case BMC

RE: [PATCH bpf-next v3] bpf: bpf_{g,s}etsockopt for struct bpf_sock_addr

2020-05-01 Thread John Fastabend
Stanislav Fomichev wrote: > Currently, bpf_getsockopt and bpf_setsockopt helpers operate on the > 'struct bpf_sock_ops' context in BPF_PROG_TYPE_SOCK_OPS program. > Let's generalize them and make them available for 'struct bpf_sock_addr'. > That way, in the future, we can allow those helpers in mor

Re: [PATCH] libertas_tf: Avoid a null pointer dereference in if_usb_disconnect()

2020-05-01 Thread Markus Elfring
> Currently there is a check if priv is null when calling lbtf_remove_card > but not in a previous call to if_usb_reset_dev that can also dereference > priv. Fix this by also only calling lbtf_remove_card if priv is null. I suggest to recheck this description (and the corresponding patch subject)

Re: [PATCH] lan743x: Added fixed_phy support / Question regarding proper devicetree

2020-05-01 Thread Roelof Berg
Working status: I added fixed_phy support to the Microchip lan743x ethernet driver and for upstream contribution I need to make it runtime configurable via the device tree. Question: There are, amongst other, the following devices on my target (i.mx6): /soc/aips-bus@210/ethernet@2188000 /s

[Patch net] atm: fix a memory leak of vcc->user_back

2020-05-01 Thread Cong Wang
In lec_arp_clear_vccs() only entry->vcc is freed, but vcc could be installed on entry->recv_vcc too in lec_vcc_added(). This fixes the following memory leak: unreferenced object 0x8880d9266b90 (size 16): comm "atm2", pid 425, jiffies 4294907980 (age 23.488s) hex dump (first 16 bytes):

[Patch net] atm: fix a UAF in lec_arp_clear_vccs()

2020-05-01 Thread Cong Wang
Gengming reported a UAF in lec_arp_clear_vccs(), where we add a vcc socket to an entry in a per-device list but free the socket without removing it from the list when vcc->dev is NULL. We need to call lec_vcc_close() to search and remove those entries contain the vcc being destroyed. This can be d

Re: Net: [DSA]: dsa-loop kernel panic

2020-05-01 Thread Florian Fainelli
On 5/1/20 10:58 AM, Allen wrote: >>> >>>   It maps to "eth0". Please let me know if you need further details. >> >> I suppose I should have been clearer, what network device driver created >> eth0? >> > >  This was seen on a VM. > eth0 [52:54:00:c1:cd:65]: virtio_net (up) Thanks, I will try to re

AW: [PATCH] net: dsa: sja1105: fix speed setting for 10 MBPS

2020-05-01 Thread Walter Harms
IMHO it would be better to use switch case here to improve readability. switch (bmcr & mask) { case BMCR_SPEED1000: speed = SPEED_1000; break; case BMCR_SPEED100: speed = SPEED_100;

Re: Net: [DSA]: dsa-loop kernel panic

2020-05-01 Thread Allen
 It maps to "eth0". Please let me know if you need further details. I suppose I should have been clearer, what network device driver created eth0? This was seen on a VM. eth0 [52:54:00:c1:cd:65]: virtio_net (up) Thanks.

Re: [PATCH v9 bpf-next 0/3] bpf: sharing bpf runtime stats with

2020-05-01 Thread Alexei Starovoitov
On Thu, Apr 30, 2020 at 12:15 AM Song Liu wrote: > > run_time_ns is a useful stats for BPF programs. However, it is gated by > sysctl kernel.bpf_stats_enabled. When multiple user space tools are > toggling kernl.bpf_stats_enabled at the same time, they may confuse each > other. > > Solve this prob

Re: [Potential Spoof] [PATCH bpf-next] bpf: fix use-after-free of bpf_link when priming half-fails

2020-05-01 Thread Andrii Nakryiko
On Fri, May 1, 2020 at 12:09 AM Martin KaFai Lau wrote: > > On Thu, Apr 30, 2020 at 11:32:59PM -0700, Andrii Nakryiko wrote: > > On Thu, Apr 30, 2020 at 11:25 PM Martin KaFai Lau wrote: > > > > > > On Thu, Apr 30, 2020 at 12:46:08PM -0700, Andrii Nakryiko wrote: > > > > If bpf_link_prime() succee

[PATCH] libertas_tf: avoid a null dereference in pointer priv

2020-05-01 Thread Colin King
From: Colin Ian King Currently there is a check if priv is null when calling lbtf_remove_card but not in a previous call to if_usb_reset_dev that can also dereference priv. Fix this by also only calling lbtf_remove_card if priv is null. It is noteable that there don't seem to be any bugs report

  1   2   3   >