Re: [patch net-next v2 3/3] net: devlink: move reload fail indication to devlink core and expose to user

2019-09-10 Thread Jiri Pirko
Sun, Sep 08, 2019 at 12:39:32PM CEST, ido...@mellanox.com wrote: >On Sat, Sep 07, 2019 at 10:54:00PM +0200, Jiri Pirko wrote: >> diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h >> index 546e75dd74ac..7cb5e8c5ae0d 100644 >> --- a/include/uapi/linux/devlink.h >> +++ b/include

Re: [patch net-next v2 3/3] net: devlink: move reload fail indication to devlink core and expose to user

2019-09-10 Thread Jiri Pirko
Sun, Sep 08, 2019 at 01:25:36PM CEST, ido...@mellanox.com wrote: >On Sat, Sep 07, 2019 at 10:54:00PM +0200, Jiri Pirko wrote: >> +bool devlink_is_reload_failed(struct devlink *devlink) > >Forgot to mention that this can be 'const' ok. > >> +{ >> +return devlink->reload_failed; >> +} >> +EXPOR

Re: ixgbe: driver drops packets routed from an IPSec interface with a "bad sa_idx" error

2019-09-10 Thread Steffen Klassert
On Tue, Sep 10, 2019 at 06:53:30PM -0400, Michael Marley wrote: > > StrongSwan has hardware offload disabled by default, and I didn't enable > it explicitly.  I also already tried turning off all those switches with > ethtool and it has no effect.  This doesn't surprise me though, because > as I s

RE: VRF Issue Since kernel 5

2019-09-10 Thread Gowen
Thanks for the link - that's really useful. I did re-order ip rules Friday (I think) - no change -Original Message- From: David Ahern Sent: 10 September 2019 17:36 To: Alexis Bauvin ; Gowen Cc: netdev@vger.kernel.org Subject: Re: VRF Issue Since kernel 5 On 9/9/19 1:01 PM, Alexis Bauv

Re: [PATCH bpf-next v10 2/4] bpf: new helper to obtain namespace data from current task New bpf helper bpf_get_current_pidns_info.

2019-09-10 Thread Carlos Antonio Neira Bustos
Thanks for reviewing the rest of the code, I'll include these changes in ver 11. Bests On Tue, Sep 10, 2019 at 10:46:45PM +, Yonghong Song wrote: > > > On 9/6/19 4:09 PM, Carlos Neira wrote: > > This helper(bpf_get_current_pidns_info) obtains the active namespace from > > current and retur

Re: [PATCH bpf-next v10 2/4] bpf: new helper to obtain namespace data from current task New bpf helper bpf_get_current_pidns_info.

2019-09-10 Thread Carlos Antonio Neira Bustos
On Tue, Sep 10, 2019 at 10:35:09PM +, Yonghong Song wrote: Thanks a lot Yonghong. I'll include this patch when submitting changes for version 11 of this patch. > > Carlos, > > Discussed with Eric today for what is the best way to get > the device number for a namespace. The following patch s

Re: [PATCH v4] tun: fix use-after-free when register netdev failed

2019-09-10 Thread Jason Wang
On 2019/9/10 下午6:56, Yang Yingliang wrote: I got a UAF repport in tun driver when doing fuzzy test: [ 466.269490] == [ 466.271792] BUG: KASAN: use-after-free in tun_chr_read_iter+0x2ca/0x2d0 [ 466.271806] Read of size 8 at add

Re: [PATCH net-next 03/11] net: aquantia: add basic ptp_clock callbacks

2019-09-10 Thread kbuild test robot
Hi Igor, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Igor-Russkikh/net-aquantia-PTP-support-for-AQC-devices/20190909-233041 config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian

Re: [PATCH net-next 03/11] net: aquantia: add basic ptp_clock callbacks

2019-09-10 Thread kbuild test robot
Hi Igor, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Igor-Russkikh/net-aquantia-PTP-support-for-AQC-devices/20190909-233041 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian

Re: [PATCH net-next 11/11] net: aquantia: add support for PIN funcs

2019-09-10 Thread kbuild test robot
Hi Igor, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Igor-Russkikh/net-aquantia-PTP-support-for-AQC-devices/20190909-233041 config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian

Re: Strange routing with VRF and 5.2.7+

2019-09-10 Thread Ben Greear
On 9/10/19 3:17 PM, Ben Greear wrote: Today we were testing creating 200 virtual station vdevs on ath9k, and using VRF for the routing. Looks like the same issue happens w/out VRF, but there I have oodles of routing rules, so it is an area ripe for failure. Will upgrade to 5.2.14+ and retest,

Re: [PATCH net-next] tcp: force a PSH flag on TSO packets

2019-09-10 Thread Neal Cardwell
On Tue, Sep 10, 2019 at 5:49 PM Eric Dumazet wrote: > > When tcp sends a TSO packet, adding a PSH flag on it > reduces the sojourn time of GRO packet in GRO receivers. > > This is particularly the case under pressure, since RX queues > receive packets for many concurrent flows. > > A sender can gi

RE: [PATCH v1 net-next 00/15] tc-taprio offload for SJA1105 DSA

2019-09-10 Thread Gomes, Vinicius
Hi Vladimir, [...] > > I'll make sure this subtlety is more clearly formulated in the next version > of the > patch. > Ack. > Actually let me ask you a few questions as well: > > - I'm trying to understand what is the correct use of the tc-mqprio "queues" > argument. I've only tested it wit

Re: [PATCH bpf-next v10 2/4] bpf: new helper to obtain namespace data from current task New bpf helper bpf_get_current_pidns_info.

2019-09-10 Thread Al Viro
On Tue, Sep 10, 2019 at 10:35:09PM +, Yonghong Song wrote: > > Carlos, > > Discussed with Eric today for what is the best way to get > the device number for a namespace. The following patch seems > a reasonable start although Eric would like to see > how the helper is used in order to decide

Re: [PATCH bpf-next v10 4/4] tools/testing/selftests/bpf: Add self-tests for helper bpf_get_pidns_info.

2019-09-10 Thread Yonghong Song
On 9/6/19 4:09 PM, Carlos Neira wrote: > Added 2 selftest: > > bpf_get_current_pidns_info helper is called in an interrupt > context and also in a non interrupt context. > > Signed-off-by: Carlos Neira > --- > tools/testing/selftests/bpf/Makefile | 2 +- > tools/testing/self

Re: ixgbe: driver drops packets routed from an IPSec interface with a "bad sa_idx" error

2019-09-10 Thread Michael Marley
On 9/10/19 5:43 PM, Shannon Nelson wrote: > On 9/9/19 11:45 AM, Michael Marley wrote: >> On 2019-09-09 14:21, Shannon Nelson wrote: >>> On 9/6/19 11:13 AM, Michael Marley wrote: (This is also reported at https://bugzilla.kernel.org/show_bug.cgi?id=204551, but it was recommended that

Re: [PATCH bpf-next v10 2/4] bpf: new helper to obtain namespace data from current task New bpf helper bpf_get_current_pidns_info.

2019-09-10 Thread Yonghong Song
On 9/6/19 4:09 PM, Carlos Neira wrote: > This helper(bpf_get_current_pidns_info) obtains the active namespace from > current and returns pid, tgid, device and namespace id as seen from that > namespace, allowing to instrument a process inside a container. > > Signed-off-by: Carlos Neira > --- >

Re: [PATCH bpf-next v10 2/4] bpf: new helper to obtain namespace data from current task New bpf helper bpf_get_current_pidns_info.

2019-09-10 Thread Yonghong Song
Carlos, Discussed with Eric today for what is the best way to get the device number for a namespace. The following patch seems a reasonable start although Eric would like to see how the helper is used in order to decide whether the interface looks right. commit bb00fc36d5d263047a8bceb3e51e969d7f

Re: [PATCH v2] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-10 Thread Neal Cardwell
On Tue, Sep 10, 2019 at 4:39 PM Eric Dumazet wrote: > > On Tue, Sep 10, 2019 at 10:11 PM Thomas Higdon wrote: > > > > > ... > > Because an additional 32-bit member in struct tcp_info would cause > > a hole on 64-bit systems, we reserve a struct member '_reserved'. > ... > > diff --git a/include/u

Re: [net-next 11/14] ixgbe: Prevent u8 wrapping of ITR value to something less than 10us

2019-09-10 Thread Alexander Duyck
On Tue, 2019-09-10 at 09:34 -0700, Jeff Kirsher wrote: > From: Alexander Duyck > > There were a couple cases where the ITR value generated via the adaptive > ITR scheme could exceed 126. This resulted in the value becoming either 0 > or something less than 10. Switching back and forth between a v

Strange routing with VRF and 5.2.7+

2019-09-10 Thread Ben Greear
Today we were testing creating 200 virtual station vdevs on ath9k, and using VRF for the routing. This really slows down the machine in question. During the minutes that it takes to bring these up and configure them, we loose network connectivity on the management port. If I do 'ip route show',

Re: [PATCH net-next] tcp: force a PSH flag on TSO packets

2019-09-10 Thread Soheil Hassas Yeganeh
On Tue, Sep 10, 2019 at 5:49 PM Eric Dumazet wrote: > > When tcp sends a TSO packet, adding a PSH flag on it > reduces the sojourn time of GRO packet in GRO receivers. > > This is particularly the case under pressure, since RX queues > receive packets for many concurrent flows. > > A sender can gi

[PATCH net-next] tcp: force a PSH flag on TSO packets

2019-09-10 Thread Eric Dumazet
When tcp sends a TSO packet, adding a PSH flag on it reduces the sojourn time of GRO packet in GRO receivers. This is particularly the case under pressure, since RX queues receive packets for many concurrent flows. A sender can give a hint to GRO engines when it is appropriate to flush a super-pa

[net-next 3/3] net/mlx5: FWTrace, Reduce stack usage

2019-09-10 Thread Saeed Mahameed
Mark mlx5_tracer_print_trace as noinline as the function only uses 512 bytes on the stack to avoid the following build warning: drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c:660:13: error: stack frame size of 1032 bytes in function 'mlx5_fw_tracer_handle_traces' [-Werror,-Wframe-large

[net-next 1/3] net/mlx5: Fix rt's type in dr_action_create_reformat_action

2019-09-10 Thread Saeed Mahameed
From: Nathan Chancellor clang warns: drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1080:9: warning: implicit conversion from enumeration type 'enum mlx5_reformat_ctx_type' to different enumeration type 'enum mlx5dr_action_type' [-Wenum-conversion] rt = MLX5

[pull request][net-next 0/3] Mellanox, mlx5 build cleanup 2019-09-10

2019-09-10 Thread Saeed Mahameed
Hi Dave, This series provides three build warnings cleanup patches for mlx5, Originally i wanted to wait a bit more and attach more patches to this series, but apparently this can't wait since already 3 different patches for the same fix were submitted this week :). For more information please se

[net-next 2/3] net/mlx5: Fix addr's type in mlx5dr_icm_dm

2019-09-10 Thread Saeed Mahameed
From: Nathan Chancellor clang errors when CONFIG_PHYS_ADDR_T_64BIT is not set: drivers/net/ethernet/mellanox/mlx5/core/steering/dr_icm_pool.c:121:8: error: incompatible pointer types passing 'u64 *' (aka 'unsigned long long *') to parameter of type 'phys_addr_t *' (aka 'unsigned int *') [-Werror

Re: ixgbe: driver drops packets routed from an IPSec interface with a "bad sa_idx" error

2019-09-10 Thread Shannon Nelson
On 9/9/19 11:45 AM, Michael Marley wrote: On 2019-09-09 14:21, Shannon Nelson wrote: On 9/6/19 11:13 AM, Michael Marley wrote: (This is also reported at https://bugzilla.kernel.org/show_bug.cgi?id=204551, but it was recommended that I send it to this list as well.) I have a put together a ro

Re: [PATCH 3/7] dt-bindings: mv88e6xxx: add ability to set default queue priorities per port

2019-09-10 Thread Vladimir Oltean
Hi guys, On 10/09/2019, Vivien Didelot wrote: > Hi Robert, > > On Tue, 10 Sep 2019 09:42:24 -0700, Florian Fainelli > wrote: >> This is a vendor specific driver/property, >> marvell,default-queue-priority (which be cheapskate on words) would be >> more readable. But still, I have some more funda

Re: [PATCH v2] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-10 Thread Eric Dumazet
On Tue, Sep 10, 2019 at 10:11 PM Thomas Higdon wrote: > > ... > Because an additional 32-bit member in struct tcp_info would cause > a hole on 64-bit systems, we reserve a struct member '_reserved'. ... > diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h > index b3564f85a762..990a5b

[PATCH net] net: Fix null de-reference of device refcount

2019-09-10 Thread Subash Abhinov Kasiviswanathan
In event of failure during register_netdevice, free_netdev is invoked immediately. free_netdev assumes that all the netdevice refcounts have been dropped prior to it being called and as a result frees and clears out the refcount pointer. However, this is not necessarily true as some of the operati

Re: [PATCH] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-10 Thread Thomas Higdon
On Mon, Sep 09, 2019 at 05:01:46PM +0200, Eric Dumazet wrote: > On Mon, Sep 9, 2019 at 4:30 PM Thomas Higdon wrote: > > diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h > > index b3564f85a762..20237987ccc8 100644 > > --- a/include/uapi/linux/tcp.h > > +++ b/include/uapi/linux/tcp.h

Re: INFO: rcu detected stall in br_handle_frame

2019-09-10 Thread Cong Wang
#syz fix: sch_hhf: ensure quantum and hhf_non_hh_weight are non-zero

Re: [PATCH net-next 03/11] net: aquantia: add basic ptp_clock callbacks

2019-09-10 Thread Andrew Lunn
> +static s64 ptp_clk_offset; > +static void hw_atl_b0_get_ptp_ts(struct aq_hw_s *self, u64 *stamp) > +{ > + u64 ns; > + > + hw_atl_pcs_ptp_clock_read_enable(self, 1); > + hw_atl_pcs_ptp_clock_read_enable(self, 0); > + ns = (get_ptp_ts_val_u64(self, 0) + > + (get_ptp_ts_v

Re: [PATCH net-next 01/11] net: aquantia: PTP skeleton declarations and callbacks

2019-09-10 Thread Andrew Lunn
On Mon, Sep 09, 2019 at 01:38:38PM +, Igor Russkikh wrote: > From: Dmitry Bezrukov Hi Igor, et al. > @@ -331,6 +332,10 @@ int aq_nic_init(struct aq_nic_s *self) > self->aq_vecs > i; ++i, aq_vec = self->aq_vec[i]) > aq_vec_init(aq_vec, self->aq_hw_ops, self->aq_hw)

Re: [PATCH net-next v2 2/2] net: stmmac: Support enhanced addressing mode for DWMAC 4.10

2019-09-10 Thread Florian Fainelli
On 9/10/19 1:35 AM, Jose Abreu wrote: > From: Thierry Reding > Date: Sep/09/2019, 20:13:29 (UTC+00:00) > >> On Mon, Sep 09, 2019 at 04:05:52PM +, Jose Abreu wrote: >>> From: Thierry Reding >>> Date: Sep/09/2019, 16:25:46 (UTC+00:00) >>> @@ -79,6 +79,10 @@ static void dwmac4_dma_init_rx_

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-10 Thread Florian Fainelli
On 9/10/19 11:26 AM, Andrew Lunn wrote: > On Tue, Sep 10, 2019 at 04:41:47PM +0100, Robert Beckett wrote: >> This enables us to negoatiate pause frame transmission to prioritise >> packet delivery over throughput. > > I don't think we can unconditionally enable this. It is a big > behaviour change

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-10 Thread Andrew Lunn
On Tue, Sep 10, 2019 at 04:41:47PM +0100, Robert Beckett wrote: > This enables us to negoatiate pause frame transmission to prioritise > packet delivery over throughput. I don't think we can unconditionally enable this. It is a big behaviour change, and it is likely to break running systems. It ha

Re: Default qdisc not correctly initialized with custom MTU

2019-09-10 Thread Holger Hoffstätte
On 9/10/19 6:56 PM, Cong Wang wrote: It is _not_ created when sysctl is configured, it is either created via tc command, or implicitly created by kernel when you bring up eth0. sysctl only tells kernel what to create by default, but never commits it. Ok, thank you - that's good to know, because

Re: [PATCH net] sctp: fix the missing put_user when dumping transport thresholds

2019-09-10 Thread David Miller
From: Xin Long Date: Mon, 9 Sep 2019 15:33:29 +0800 > This issue causes SCTP_PEER_ADDR_THLDS sockopt not to be able to dump > a transport thresholds info. > > Fix it by adding 'goto' put_user in sctp_getsockopt_paddr_thresholds. > > Fixes: 8add543e369d ("sctp: add SCTP_FUTURE_ASSOC for SCTP_PE

Re: [Patch net] sch_hhf: ensure quantum and hhf_non_hh_weight are non-zero

2019-09-10 Thread David Miller
From: Cong Wang Date: Sun, 8 Sep 2019 13:40:51 -0700 > In case of TCA_HHF_NON_HH_WEIGHT or TCA_HHF_QUANTUM is zero, > it would make no progress inside the loop in hhf_dequeue() thus > kernel would get stuck. > > Fix this by checking this corner case in hhf_change(). > > Fixes: 10239edf86f1 ("n

Re: [Patch net] net_sched: check cops->tcf_block in tc_bind_tclass()

2019-09-10 Thread David Miller
From: Cong Wang Date: Sun, 8 Sep 2019 12:11:23 -0700 > At least sch_red and sch_tbf don't implement ->tcf_block() > while still have a non-zero tc "class". > > Instead of adding nop implementations to each of such qdisc's, > we can just relax the check of cops->tcf_block() in > tc_bind_tclass()

Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-10 Thread David Miller
From: Xin Long Date: Mon, 9 Sep 2019 15:56:51 +0800 > diff --git a/include/uapi/linux/sctp.h b/include/uapi/linux/sctp.h > index a15cc28..dfd81e1 100644 > --- a/include/uapi/linux/sctp.h > +++ b/include/uapi/linux/sctp.h > @@ -1069,6 +1069,7 @@ struct sctp_paddrthlds { > struct sockaddr_st

RE: [PATCH net-next v2 1/2] net: stmmac: Only enable enhanced addressing mode when needed

2019-09-10 Thread Jose Abreu
From: Thierry Reding Date: Sep/10/2019, 14:54:27 (UTC+00:00) > On Tue, Sep 10, 2019 at 08:32:38AM +, Jose Abreu wrote: > > From: Thierry Reding > > Date: Sep/09/2019, 20:11:27 (UTC+00:00) > > > > > On Mon, Sep 09, 2019 at 04:07:04PM +, Jose Abreu wrote: > > > > From: Thierry Reding > >

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-10 Thread Vivien Didelot
Hi Robert, On Tue, 10 Sep 2019 16:41:46 +0100, Robert Beckett wrote: > This patch-set adds support for some features of the Marvell switch > chips that can be used to handle packet storms. > > The rationale for this was a setup that requires the ability to receive > traffic from one port, while

Re: [PATCH 4/7] net: dsa: mv88e6xxx: add ability to set queue scheduling

2019-09-10 Thread Vivien Didelot
Hi Robert, On Tue, 10 Sep 2019 16:41:50 +0100, Robert Beckett wrote: > Add code to set Schedule for any port that specifies "schedule" in their > device tree node. > This allows port prioritization in conjunction with port default queue > priorities or packet priorities. > > Signed-off-by: Robe

Re: [PATCH 6/7] net: dsa: mv88e6xxx: add egress rate limiting

2019-09-10 Thread Vivien Didelot
Hi Robert, On Tue, 10 Sep 2019 16:41:52 +0100, Robert Beckett wrote: > Add code for specifying egress rate limiting per port. > The rate can be specified as ethernet frames or bits per second. > > Signed-off-by: Robert Beckett > --- > drivers/net/dsa/mv88e6xxx/chip.c | 72 ++-

Re: Is bug 200755 in anyone's queue??

2019-09-10 Thread Willem de Bruijn
On Tue, Sep 10, 2019 at 12:56 PM Paolo Abeni wrote: > > Hi all, > > On Tue, 2019-09-10 at 11:52 -0400, Willem de Bruijn wrote: > > This clearly has some loose ends and is no shorter or simpler. So > > unless anyone has comments or a different solution, I'll finish > > up the first variant. > > I'm

Re: Default qdisc not correctly initialized with custom MTU

2019-09-10 Thread Cong Wang
On Tue, Sep 10, 2019 at 2:14 AM Holger Hoffstätte wrote: > > On 9/10/19 12:52 AM, Cong Wang wrote: > > On Mon, Sep 9, 2019 at 5:44 AM Holger Hoffstätte > > wrote: > >> I can't help but feel this is a slight bug in terms of initialization > >> order, > >> and that the default qdisc should only be

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-10 Thread Florian Fainelli
On 9/10/19 8:41 AM, Robert Beckett wrote: > Configure autoneg for phy connected CPU ports. > This allows us to use autoneg between the CPU port's phy and the link > partner's phy. > This enables us to negoatiate pause frame transmission to prioritise > packet delivery over throughput. s/autoneg/au

Re: Is bug 200755 in anyone's queue??

2019-09-10 Thread Paolo Abeni
Hi all, On Tue, 2019-09-10 at 11:52 -0400, Willem de Bruijn wrote: > This clearly has some loose ends and is no shorter or simpler. So > unless anyone has comments or a different solution, I'll finish > up the first variant. I'm sorry for the late feedback. I was wondering if we could use a new

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-10 Thread Florian Fainelli
+Ido, Jiri, On 9/10/19 8:41 AM, Robert Beckett wrote: > This patch-set adds support for some features of the Marvell switch > chips that can be used to handle packet storms. > > The rationale for this was a setup that requires the ability to receive > traffic from one port, while a packet storm i

Re: [PATCH 3/7] dt-bindings: mv88e6xxx: add ability to set default queue priorities per port

2019-09-10 Thread Vivien Didelot
Hi Robert, On Tue, 10 Sep 2019 09:42:24 -0700, Florian Fainelli wrote: > This is a vendor specific driver/property, > marvell,default-queue-priority (which be cheapskate on words) would be > more readable. But still, I have some more fundamental issues with the > general approach, see my respons

Re: [PATCH 2/7] net: dsa: mv88e6xxx: add ability to set default queue priorities per port

2019-09-10 Thread Vivien Didelot
Hi Robert, On Tue, 10 Sep 2019 16:41:48 +0100, Robert Beckett wrote: > +static int mv88e6xxx_set_port_defqpri(struct mv88e6xxx_chip *chip, int port) > +{ > + struct dsa_switch *ds = chip->ds; > + struct device_node *dn = ds->ports[port].dn; > + int err; > + u32 pri; > + > + i

Re: [PATCH 3/7] dt-bindings: mv88e6xxx: add ability to set default queue priorities per port

2019-09-10 Thread Florian Fainelli
On 9/10/19 8:41 AM, Robert Beckett wrote: > Document a new setting for Marvell switch chips to set the default queue > priorities per port. > > Signed-off-by: Robert Beckett > --- > Documentation/devicetree/bindings/net/dsa/marvell.txt | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: VRF Issue Since kernel 5

2019-09-10 Thread David Ahern
On 9/9/19 8:46 AM, Gowen wrote: > > I can run: > > > Admin@NETM06:~$ host www.google.co.uk > www.google.co.uk has address 172.217.169.3 > www.google.co.uk has IPv6 address 2a00:1450:4009:80d::2003 > > > but I get a timeout for: > > > sudo ip vrf  exec mgmt-vrf host www.google.co.uk sudo per

Re: VRF Issue Since kernel 5

2019-09-10 Thread David Ahern
On 9/9/19 1:01 PM, Alexis Bauvin wrote: > Could you try swapping the local and l3mdev rules? > > `ip rule del pref 0; ip rule add from all lookup local pref 1001` yes, the rules should be re-ordered so that local rule is after l3mdev rule (VRF is implemented as policy routing). In general, I woul

[net-next 13/14] net/ixgbevf: make array api static const, makes object smaller

2019-09-10 Thread Jeff Kirsher
From: Colin Ian King Don't populate the array API on the stack but instead make it static const. Makes the object code smaller by 58 bytes. Before: textdata bss dec hex filename 829699763 256 92988 16b3c ixgbevf/ixgbevf_main.o After: textdata bss

[net-next 14/14] i40e: fix potential RX buffer starvation for AF_XDP

2019-09-10 Thread Jeff Kirsher
From: Magnus Karlsson When the RX rings are created they are also populated with buffers so that packets can be received. Usually these are kernel buffers, but for AF_XDP in zero-copy mode, these are user-space buffers and in this case the application might not have sent down any buffers to the d

[net-next 06/14] i40e: mark additional missing bits as reserved

2019-09-10 Thread Jeff Kirsher
From: Jacob Keller Mark bits 0xD through 0xF for the command flags of a cloud filter as reserved. These bits are not yet defined and are considered as reserved in the data sheet. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i

[net-next 00/14][pull request] Intel Wired LAN Driver Updates 2019-09-10

2019-09-10 Thread Jeff Kirsher
This series contains updates to i40e, ixgbe/vf and iavf. Wenwen Wang fixes a potential memory leak where 3 allocated variables are not properly cleaned up on failure for ixgbe. Stefan Assmann fixes a potential kernel panic found when repeatedly spawning and destroying VFs in i40e when a NULL poin

[net-next 04/14] i40e: use ktime_get_real_ts64 instead of ktime_to_timespec64

2019-09-10 Thread Jeff Kirsher
From: Jacob Keller Remove a call to ktime_to_timespec64 by calling ktime_get_real_ts64 directly. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[net-next 07/14] i40e: fix missed "Negotiated" string in i40e_print_link_message()

2019-09-10 Thread Jeff Kirsher
From: Aleksandr Loktionov The "Negotiated" string in i40e_print_link_message() function was missed. This string has been added to the dmesg and small refactoring done removing common substrings and unifying link status message format. Without this patch it was not clear that FEC is related to neg

[net-next 11/14] ixgbe: Prevent u8 wrapping of ITR value to something less than 10us

2019-09-10 Thread Jeff Kirsher
From: Alexander Duyck There were a couple cases where the ITR value generated via the adaptive ITR scheme could exceed 126. This resulted in the value becoming either 0 or something less than 10. Switching back and forth between a value less than 10 and a value greater than 10 can cause issues as

[net-next 02/14] i40e: check __I40E_VF_DISABLE bit in i40e_sync_filters_subtask

2019-09-10 Thread Jeff Kirsher
From: Stefan Assmann While testing VF spawn/destroy the following panic occurred. BUG: unable to handle kernel NULL pointer dereference at 0029 [...] Workqueue: i40e i40e_service_task [i40e] RIP: 0010:i40e_sync_vsi_filters+0x6fd/0xc60 [i40e] [...] Call Trace: ? __switch_to_asm+0x35/

[net-next 09/14] i40e: use BIT macro to specify the cloud filter field flags

2019-09-10 Thread Jeff Kirsher
From: Jacob Keller The macros used to specify the cloud filter fields are intended to be individual bits. Declare them using the BIT() macro to make their intention a little more clear. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/

[net-next 01/14] ixgbe: fix memory leaks

2019-09-10 Thread Jeff Kirsher
From: Wenwen Wang In ixgbe_configure_clsu32(), 'jump', 'input', and 'mask' are allocated through kzalloc() respectively in a for loop body. Then, ixgbe_clsu32_build_input() is invoked to build the input. If this process fails, next iteration of the for loop will be executed. However, the allocate

[net-next 10/14] i40e: clear __I40E_VIRTCHNL_OP_PENDING on invalid min Tx rate

2019-09-10 Thread Jeff Kirsher
From: Stefan Assmann In the case of an invalid min Tx rate being requested i40e_ndo_set_vf_bw() immediately returns -EINVAL instead of releasing __I40E_VIRTCHNL_OP_PENDING first. Signed-off-by: Stefan Assmann Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel

[net-next 12/14] iavf: fix MAC address setting for VFs when filter is rejected

2019-09-10 Thread Jeff Kirsher
From: Stefan Assmann Currently iavf unconditionally applies MAC address change requests. This brings the VF in a state where it is no longer able to pass traffic if the PF rejects a MAC filter change for the VF. A typical scenario for a rejected MAC filter is for an untrusted VF to request to cha

[net-next 08/14] i40e: Fix message for other card without FEC.

2019-09-10 Thread Jeff Kirsher
From: Czeslaw Zagorski When variable "req_fec, fec, an" are empty, dmesg shows log with "Requested FEC: , Negotiated FEC: , Autoneg:". Add link dmesg log for cards without FEC. Signed-off-by: Czeslaw Zagorski Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel

[net-next 05/14] i40e: remove I40E_AQC_ADD_CLOUD_FILTER_OIP

2019-09-10 Thread Jeff Kirsher
From: Jacob Keller The bit 0x0001 used in the cloud filters adminq command is reserved, and is not actually a valid type. The Linux driver has never used this type, and it's not clear if any driver ever has. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 03/14] ixgbe: use skb_get_queue_mapping in tx path

2019-09-10 Thread Jeff Kirsher
From: Tonghao Zhang Use the common api, and don't access queue_mapping directly. Signed-off-by: Tonghao Zhang Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

Re: [PATCH net-next v2 00/11] nfp: implement firmware loading policy

2019-09-10 Thread David Miller
From: Simon Horman Date: Mon, 9 Sep 2019 00:54:16 +0100 > Dirk says: > > This series adds configuration capabilities to the firmware loading policy of > the NFP driver. > > NFP firmware loading is controlled via three HWinfo keys which can be set per > device: 'abi_drv_reset', 'abi_drv_load_if

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-10 Thread Vivien Didelot
Hi Robert, On Tue, 10 Sep 2019 16:41:47 +0100, Robert Beckett wrote: > Configure autoneg for phy connected CPU ports. > This allows us to use autoneg between the CPU port's phy and the link > partner's phy. > This enables us to negoatiate pause frame transmission to prioritise > packet delivery

Re: [PATCH net-next 0/3] net: dsa: mv88e6xxx: add PCL support

2019-09-10 Thread David Miller
From: Vivien Didelot Date: Sat, 7 Sep 2019 16:00:46 -0400 > This small series implements the ethtool RXNFC operations in the > mv88e6xxx DSA driver to configure a port's Layer 2 Policy Control List > (PCL) supported by models such as 88E6352 and 88E6390 and equivalent. > > This allows to config

Re: Is bug 200755 in anyone's queue??

2019-09-10 Thread Willem de Bruijn
On Wed, Sep 4, 2019 at 11:46 AM Willem de Bruijn wrote: > > On Wed, Sep 4, 2019 at 10:51 AM Steve Zabele wrote: > > > > I think a dual table approach makes a lot of sense here, especially if we > > look at the different use cases. For the DNS server example, almost > > certainly there will not

[PATCH 6/7] net: dsa: mv88e6xxx: add egress rate limiting

2019-09-10 Thread Robert Beckett
Add code for specifying egress rate limiting per port. The rate can be specified as ethernet frames or bits per second. Signed-off-by: Robert Beckett --- drivers/net/dsa/mv88e6xxx/chip.c | 72 ++--- drivers/net/dsa/mv88e6xxx/chip.h | 3 +- drivers/net/dsa/mv88e6xxx/port.c | 10

Re: [PATCH v3 1/2] PTP: introduce new versions of IOCTLs

2019-09-10 Thread Richard Cochran
On Mon, Sep 09, 2019 at 10:59:39AM +0300, Felipe Balbi wrote: > case PTP_PEROUT_REQUEST: > + case PTP_PEROUT_REQUEST2: ... > + if (((req.perout.flags & ~PTP_PEROUT_VALID_FLAGS) || > + req.perout.rsv[0] || req.perout.rsv[1] || > + req.

[PATCH 7/7] dt-bindings: mv88e6xxx: add egress rate limiting

2019-09-10 Thread Robert Beckett
Document port egress rate limiting settings. Add defines for specifying egress rate limiting mode. Signed-off-by: Robert Beckett --- .../devicetree/bindings/net/dsa/marvell.txt | 22 +++ include/dt-bindings/net/dsa-mv88e6xxx.h | 5 + 2 files changed, 27 insertions(+)

[PATCH 4/7] net: dsa: mv88e6xxx: add ability to set queue scheduling

2019-09-10 Thread Robert Beckett
Add code to set Schedule for any port that specifies "schedule" in their device tree node. This allows port prioritization in conjunction with port default queue priorities or packet priorities. Signed-off-by: Robert Beckett --- drivers/net/dsa/mv88e6xxx/chip.c | 25 + dr

[PATCH 5/7] dt-bindings: mv88e6xxx: add ability to set queue scheduling

2019-09-10 Thread Robert Beckett
Document port queue scheduling settings. Add definitions for specific valid values. Signed-off-by: Robert Beckett --- .../devicetree/bindings/net/dsa/marvell.txt | 12 include/dt-bindings/net/dsa-mv88e6xxx.h | 17 + 2 files changed, 29 insertions(+) crea

[PATCH 3/7] dt-bindings: mv88e6xxx: add ability to set default queue priorities per port

2019-09-10 Thread Robert Beckett
Document a new setting for Marvell switch chips to set the default queue priorities per port. Signed-off-by: Robert Beckett --- Documentation/devicetree/bindings/net/dsa/marvell.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/D

[PATCH 2/7] net: dsa: mv88e6xxx: add ability to set default queue priorities per port

2019-09-10 Thread Robert Beckett
Add code to set DefQPri for any port that specifies "defqpri" in their device tree node. This allows setting the default output queue priority for all packets entering the switch via the port that uses this, which is useful for prioritizing traffic based on port. Signed-off-by: Robert Beckett ---

[PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-10 Thread Robert Beckett
Configure autoneg for phy connected CPU ports. This allows us to use autoneg between the CPU port's phy and the link partner's phy. This enables us to negoatiate pause frame transmission to prioritise packet delivery over throughput. Signed-off-by: Robert Beckett --- net/dsa/port.c | 10

[PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-10 Thread Robert Beckett
This patch-set adds support for some features of the Marvell switch chips that can be used to handle packet storms. The rationale for this was a setup that requires the ability to receive traffic from one port, while a packet storm is occuring on another port (via an external switch with a deliber

Re: [PATCH net-next] ipv6: Don't use dst gateway directly in ip6_confirm_neigh()

2019-09-10 Thread Guillaume Nault
On Mon, Sep 09, 2019 at 10:44:06PM +0200, Stefano Brivio wrote: > This is the equivalent of commit 2c6b55f45d53 ("ipv6: fix neighbour > resolution with raw socket") for ip6_confirm_neigh(): we can send a > packet with MSG_CONFIRM on a raw socket for a connected route, so the > gateway would be :: h

Re: VRF Issue Since kernel 5

2019-09-10 Thread Gowen
Hi Alexis, I enabled the target TRACE and found that the packet is passing through the security table - which I thought was for SELinux only. As far as I can tell the config is working, is being seen by iptables nut for some reason is not getting accepted by the local process - which isn't righ

Re: [PATCH net-next v2 1/2] net: stmmac: Only enable enhanced addressing mode when needed

2019-09-10 Thread Thierry Reding
On Tue, Sep 10, 2019 at 08:32:38AM +, Jose Abreu wrote: > From: Thierry Reding > Date: Sep/09/2019, 20:11:27 (UTC+00:00) > > > On Mon, Sep 09, 2019 at 04:07:04PM +, Jose Abreu wrote: > > > From: Thierry Reding > > > Date: Sep/09/2019, 16:25:45 (UTC+00:00) > > > > > > > @@ -92,6 +92,7 @@

RE: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-10 Thread David Laight
From: Xin Long > Sent: 09 September 2019 08:57 > Section 7.2 of rfc7829: "Peer Address Thresholds (SCTP_PEER_ADDR_THLDS) > Socket Option" extends 'struct sctp_paddrthlds' with 'spt_pathcpthld' > added to allow a user to change ps_retrans per sock/asoc/transport, as > other 2 paddrthlds: pf_retrans,

Re: [PATCH net-next 11/11] net: aquantia: add support for PIN funcs

2019-09-10 Thread kbuild test robot
Hi Igor, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Igor-Russkikh/net-aquantia-PTP-support-for-AQC-devices/20190909-233041 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian

Re: ❌ FAIL: Stable queue: queue-5.2

2019-09-10 Thread Hangbin Liu
On Tue, Sep 10, 2019 at 06:52:23AM -0400, Sasha Levin wrote: > On Tue, Sep 10, 2019 at 05:40:25PM +0800, Hangbin Liu wrote: > > On Tue, Sep 10, 2019 at 05:30:21PM +0800, Hangbin Liu wrote: > > > Xiumei Mu also forwarded me a mail. It looks Sasha has fixed something. > > > But I don't know the detai

Re: ❌ FAIL: Stable queue: queue-5.2

2019-09-10 Thread Sasha Levin
On Tue, Sep 10, 2019 at 05:40:25PM +0800, Hangbin Liu wrote: On Tue, Sep 10, 2019 at 05:30:21PM +0800, Hangbin Liu wrote: Xiumei Mu also forwarded me a mail. It looks Sasha has fixed something. But I don't know the details. Oh, I checked that thread. It's the same issue. So Sasha should has fi

[PATCH bpf-next 07/11] samples: bpf: add makefile.prog for separate CC build

2019-09-10 Thread Ivan Khoronzhuk
The makefile.prog is added only, will be used in sample/bpf/Makefile later in order to switch cross-compiling on CC from HOSTCC. The HOSTCC is supposed to build binaries and tools running on the host afterwards, in order to simplify build or so, like "fixdep" or else. In case of cross compiling "f

[PATCH bpf-next 03/11] samples: bpf: makefile: use --target from cross-compile

2019-09-10 Thread Ivan Khoronzhuk
For cross compiling the target triple can be inherited from cross-compile prefix as it's done in CLANG_FLAGS from kernel makefile. So copy-paste this decision from kernel Makefile. Signed-off-by: Ivan Khoronzhuk --- samples/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v4] tun: fix use-after-free when register netdev failed

2019-09-10 Thread Yang Yingliang
I got a UAF repport in tun driver when doing fuzzy test: [ 466.269490] == [ 466.271792] BUG: KASAN: use-after-free in tun_chr_read_iter+0x2ca/0x2d0 [ 466.271806] Read of size 8 at addr 888372139250 by task tun-test/2699 [ 466

[PATCH bpf-next 01/11] samples: bpf: makefile: fix HDR_PROBE "echo"

2019-09-10 Thread Ivan Khoronzhuk
echo should be replaced on echo -e to handle \n correctly, but instead, replace it on printf as some systems can't handle echo -e. Signed-off-by: Ivan Khoronzhuk --- samples/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/bpf/Makefile b/samples/bpf/Makefi

Re: ❌ FAIL: Stable queue: queue-5.2

2019-09-10 Thread Hangbin Liu
On Tue, Sep 10, 2019 at 05:30:21PM +0800, Hangbin Liu wrote: > Xiumei Mu also forwarded me a mail. It looks Sasha has fixed something. > But I don't know the details. Oh, I checked that thread. It's the same issue. So Sasha should has fixed it. I just wonder the commit id now. Thanks Hangbin > >

Re: ❌ FAIL: Stable queue: queue-5.2

2019-09-10 Thread Hangbin Liu
On Tue, Sep 10, 2019 at 09:58:10AM +0100, Greg KH wrote: > On Tue, Sep 10, 2019 at 04:19:56PM +0800, Hangbin Liu wrote: > > On Wed, Aug 28, 2019 at 08:36:14AM -0400, CKI Project wrote: > > > > > > Hello, > > > > > > We ran automated tests on a patchset that was proposed for merging into > > > th

Re: Default qdisc not correctly initialized with custom MTU

2019-09-10 Thread Holger Hoffstätte
On 9/10/19 12:52 AM, Cong Wang wrote: On Mon, Sep 9, 2019 at 5:44 AM Holger Hoffstätte wrote: I can't help but feel this is a slight bug in terms of initialization order, and that the default qdisc should only be created when it's first being used/attached to a link, not when the sysctls are co

Re: ❌ FAIL: Stable queue: queue-5.2

2019-09-10 Thread Greg KH
On Tue, Sep 10, 2019 at 04:19:56PM +0800, Hangbin Liu wrote: > On Wed, Aug 28, 2019 at 08:36:14AM -0400, CKI Project wrote: > > > > Hello, > > > > We ran automated tests on a patchset that was proposed for merging into this > > kernel tree. The patches were applied to: > > > >Kernel repo

  1   2   >