[PATCH] ethtool: igb: dump RR2DCDELAY register

2019-07-14 Thread Artem Bityutskiy
Decode 'RR2DCDELAY' register which Linux kernel provides starting from version 5.3. The corresponding commit in the Linux kernel is: cd502a7f7c9c igb: add RR2DCDELAY to ethtool registers dump The RR2DCDELAY register is present in I210 and I211 Intel Gigabit Ethernet chips and it stands for "Re

[PATCH net] caif-hsi: fix possible deadlock in cfhsi_exit_module()

2019-07-14 Thread Taehee Yoo
cfhsi_exit_module() calls unregister_netdev() under rtnl_lock(). but unregister_netdev() internally calls rtnl_lock(). So deadlock would occur. Fixes: c41254006377 ("caif-hsi: Add rtnl support") Signed-off-by: Taehee Yoo --- I did only compile test because I don't have the testbed. Could anyone t

Re: [PATCH net-next 01/16] qlge: Remove irq_cnt

2019-07-14 Thread Benjamin Poirier
On 2019/06/17 16:48, Benjamin Poirier wrote: > qlge uses an irq enable/disable refcounting scheme that is: > * poorly implemented > Uses a spin_lock to protect accesses to the irq_cnt atomic variable > * buggy > Breaks when there is not a 1:1 sequence of irq - napi_poll, such as >

[PATCH net v3] net: neigh: fix multiple neigh timer scheduling

2019-07-14 Thread Lorenzo Bianconi
Neigh timer can be scheduled multiple times from userspace adding multiple neigh entries and forcing the neigh timer scheduling passing NTF_USE in the netlink requests. This will result in a refcount leak and in the following dump stack: [ 32.465295] NEIGH: BUG, double timer add, state is 8 [

Re: [PATCH net v2] net: neigh: fix multiple neigh timer scheduling

2019-07-14 Thread Lorenzo Bianconi
> On 7/14/19 2:45 AM, Lorenzo Bianconi wrote: > > @@ -1124,7 +1125,9 @@ int __neigh_event_send(struct neighbour *neigh, > > struct sk_buff *skb) > > > > atomic_set(&neigh->probes, > >NEIGH_VAR(neigh->parms, UCAST_PROBES)); > > -

Re: [PATCH] sis900: correct a few typos

2019-07-14 Thread David Miller
From: Sergej Benilov Date: Sun, 14 Jul 2019 18:56:27 +0200 > Correct a few typos in comments and debug text. > > Signed-off-by: Sergej Benilov Applied.

Re: [PATCH] sit: use dst_cache in ipip6_tunnel_xmit

2019-07-14 Thread David Miller
From: Haishuang Yan Date: Sun, 14 Jul 2019 21:31:22 +0800 > Same as other ip tunnel, use dst_cache in xmit action to avoid > unnecessary fib lookups. > > Signed-off-by: Haishuang Yan Looks good, applied, thanks.

Re: [PATCH net v2] net: neigh: fix multiple neigh timer scheduling

2019-07-14 Thread David Miller
From: David Ahern Date: Sun, 14 Jul 2019 07:58:19 -0600 > On 7/14/19 2:45 AM, Lorenzo Bianconi wrote: >> @@ -1124,7 +1125,9 @@ int __neigh_event_send(struct neighbour *neigh, struct >> sk_buff *skb) >> >> atomic_set(&neigh->probes, >> NEIGH_

[PATCH] sis900: correct a few typos

2019-07-14 Thread Sergej Benilov
Correct a few typos in comments and debug text. Signed-off-by: Sergej Benilov --- drivers/net/ethernet/sis/sis900.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c index aba6eea72..6e07f5eba 100644 -

Re: [PATCH iproute2-next] Makefile: pass -pipe to the compiler

2019-07-14 Thread Matteo Croce
On Tue, Jun 11, 2019 at 9:28 PM Stephen Hemminger wrote: > > On Tue, 11 Jun 2019 20:05:13 +0200 > Matteo Croce wrote: > > > Pass the -pipe option to GCC, to use pipes instead of temp files. > > On a slow AMD G-T40E CPU we get a non negligible 6% improvement > > in build time. > > > > real1m15

Re: [PATCH iproute2] utils: don't match empty strings as prefixes

2019-07-14 Thread Matteo Croce
On Wed, Jul 10, 2019 at 1:18 AM Matteo Croce wrote: > > On Tue, Jul 9, 2019 at 11:38 PM Stephen Hemminger > wrote: > > > > On Tue, 9 Jul 2019 22:40:40 +0200 > > Matteo Croce wrote: > > > > > iproute has an utility function which checks if a string is a prefix for > > > another one, to allow use

Re: [PATCH net v2] net: neigh: fix multiple neigh timer scheduling

2019-07-14 Thread David Ahern
On 7/14/19 2:45 AM, Lorenzo Bianconi wrote: > @@ -1124,7 +1125,9 @@ int __neigh_event_send(struct neighbour *neigh, struct > sk_buff *skb) > > atomic_set(&neigh->probes, > NEIGH_VAR(neigh->parms, UCAST_PROBES)); > - neigh

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-14 Thread Ido Schimmel
On Sun, Jul 14, 2019 at 07:29:04AM -0400, Neil Horman wrote: > On Fri, Jul 12, 2019 at 04:52:30PM +0300, Ido Schimmel wrote: > > On Thu, Jul 11, 2019 at 07:53:54PM -0400, Neil Horman wrote: > > > A few things here: > > > IIRC we don't announce individual hardware drops, drivers record them in > > >

Re: [PATCH net-next 00/11] Add drop monitor for offloaded data paths

2019-07-14 Thread Neil Horman
On Fri, Jul 12, 2019 at 04:52:30PM +0300, Ido Schimmel wrote: > On Thu, Jul 11, 2019 at 07:53:54PM -0400, Neil Horman wrote: > > A few things here: > > IIRC we don't announce individual hardware drops, drivers record them in > > internal structures, and they are retrieved on demand via ethtool call

[PATCH net v2] net: neigh: fix multiple neigh timer scheduling

2019-07-14 Thread Lorenzo Bianconi
Neigh timer can be scheduled multiple times from userspace adding multiple neigh entries and forcing the neigh timer scheduling passing NTF_USE in the netlink requests. This will result in a refcount leak and in the following dump stack: [ 32.465295] NEIGH: BUG, double timer add, state is 8 [