From: David Ahern <dsah...@gmail.com> Date: Sun, 14 Jul 2019 07:58:19 -0600
> On 7/14/19 2:45 AM, Lorenzo Bianconi wrote: >> @@ -1124,7 +1125,9 @@ int __neigh_event_send(struct neighbour *neigh, struct >> sk_buff *skb) >> >> atomic_set(&neigh->probes, >> NEIGH_VAR(neigh->parms, UCAST_PROBES)); >> - neigh->nud_state = NUD_INCOMPLETE; >> + if (check_timer) >> + neigh_del_timer(neigh); > > Why not just always call neigh_del_timer and avoid the check_timer flag? > Let the NUD_IN_TIMER flag handle whether anything needs to be done. Agreed.
