Re: [PATCH net-next 08/17] netdevsim: Adjust accounting for IPv6 multipath notifications

2019-06-16 Thread Ido Schimmel
On Sun, Jun 16, 2019 at 07:27:13PM -0600, David Ahern wrote: > On 6/15/19 8:07 AM, Ido Schimmel wrote: > > diff --git a/drivers/net/netdevsim/fib.c b/drivers/net/netdevsim/fib.c > > index 83ba5113210d..6e5498ef3855 100644 > > --- a/drivers/net/netdevsim/fib.c > > +++ b/drivers/net/netdevsim/fib.c >

Re: [PATCH net-next 03/17] ipv6: Extend notifier info for multipath routes

2019-06-16 Thread Ido Schimmel
On Sun, Jun 16, 2019 at 07:22:44PM -0600, David Ahern wrote: > On 6/15/19 8:07 AM, Ido Schimmel wrote: > > From: Ido Schimmel > > > > Extend the IPv6 FIB notifier info with number of sibling routes being > > notified. > > > > This will later allow listeners to process one notification for a > >

Re: [PATCH net-next 02/17] netlink: Add field to skip in-kernel notifications

2019-06-16 Thread Ido Schimmel
On Sun, Jun 16, 2019 at 07:17:26PM -0600, David Ahern wrote: > On 6/15/19 8:07 AM, Ido Schimmel wrote: > > From: Ido Schimmel > > > > The struct includes a 'skip_notify' flag that indicates if netlink > > notifications to user space should be suppressed. As explained in commit > > 3b1137fe7482 ("

[net-next] tipc: include retrans failure detection for unicast

2019-06-16 Thread Tuong Lien
In patch series, commit 9195948fbf34 ("tipc: improve TIPC throughput by Gap ACK blocks"), as for simplicity, the repeated retransmit failures' detection in the function - "tipc_link_retrans()" was kept there for broadcast retransmissions only. This commit now reapplies this feature for link unicas

[net] tipc: fix issues with early FAILOVER_MSG from peer

2019-06-16 Thread Tuong Lien
It appears that a FAILOVER_MSG can come from peer even when the failure link is resetting (i.e. just after the 'node_write_unlock()'...). This means the failover procedure on the node has not been started yet. The situation is as follows: node1node2 linkb

Re: [PATCH net-next 0/2] selftests: pmtu: List/flush IPv4 cached routes, improve IPv6 test

2019-06-16 Thread David Miller
From: Stefano Brivio Date: Sat, 15 Jun 2019 03:38:16 +0200 > This series introduce a new test, list_flush_ipv4_exception, and improves > the existing list_flush_ipv6_exception test by making it as demanding as > the IPv4 one. I suspect this will need a respin because semantics are still being di

Re: [PATCH net] lapb: fixed leak of control-blocks.

2019-06-16 Thread David Miller
From: Jeremy Sowden Date: Sun, 16 Jun 2019 16:54:37 +0100 > lapb_register calls lapb_create_cb, which initializes the control- > block's ref-count to one, and __lapb_insert_cb, which increments it when > adding the new block to the list of blocks. > > lapb_unregister calls __lapb_remove_cb, whic

Re: [PATCH net] tipc: purge deferredq list for each grp member in tipc_group_delete

2019-06-16 Thread David Miller
From: Xin Long Date: Sun, 16 Jun 2019 17:24:07 +0800 > Syzbot reported a memleak caused by grp members' deferredq list not > purged when the grp is be deleted. > > The issue occurs when more(msg_grp_bc_seqno(hdr), m->bc_rcv_nxt) in > tipc_group_filter_msg() and the skb will stay in deferredq. >

Re: [PATCH net] tipc: purge deferredq list for each grp member in tipc_group_delete

2019-06-16 Thread Ying Xue
On 6/16/19 5:24 PM, Xin Long wrote: > Syzbot reported a memleak caused by grp members' deferredq list not > purged when the grp is be deleted. > > The issue occurs when more(msg_grp_bc_seqno(hdr), m->bc_rcv_nxt) in > tipc_group_filter_msg() and the skb will stay in deferredq. > > So fix it by cal

Re: [PATCH] ipv4: fix inet_select_addr() when enable route_localnet

2019-06-16 Thread Luoshijie (Poincare Lab)
On 2019/6/15 9:00, David Ahern wrote: > On 6/14/19 10:55 AM, luoshijie wrote: >> From: Shijie Luo >> >> Suppose we have two interfaces eth0 and eth1 in two hosts, follow >> the same steps in the two hosts: >> # sysctl -w net.ipv4.conf.eth1.route_localnet=1 >> # sysctl -w net.ipv4.conf.eth1.arp_an

kernel/workqueue.c:3030 __flush_work+0x2c2/0x2d0

2019-06-16 Thread Naresh Kamboju
Kernel warning while running kernel selftest bpf test_sockmap test case on x86_64 and arm64. The kernel warning log pops up continuously. Linux version 5.1.10-rc2 Steps to reproduce: Boot stable rc 5.1.10-rc2 kernel on x86_64 or arm64 cd selftests/bpf ./test_sockmap [ 37.600406] WARNING: CPU:

[PATCH v3 0/7] Hexdump Enhancements

2019-06-16 Thread Alastair D'Silva
From: Alastair D'Silva Apologies for the large CC list, it's a heads up for those responsible for subsystems where a prototype change in generic code causes a change in those subsystems. This series enhances hexdump. These improve the readability of the dumped data in certain situations (eg. wi

[PATCH v3 5/7] lib/hexdump.c: Allow multiple groups to be separated by lines '|'

2019-06-16 Thread Alastair D'Silva
From: Alastair D'Silva With the wider display format, it can become hard to identify how many bytes into the line you are looking at. The patch adds new flags to hex_dump_to_buffer() and print_hex_dump() to print vertical lines to separate every N groups of bytes. eg. buf:: 454d414e 434

[PATCH v3 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-06-16 Thread Alastair D'Silva
From: Alastair D'Silva In order to support additional features in hex_dump_to_buffer, replace the ascii bool parameter with flags. Signed-off-by: Alastair D'Silva --- drivers/gpu/drm/i915/intel_engine_cs.c| 2 +- drivers/isdn/hardware/mISDN/mISDNisar.c | 6 -- drive

[PATCH v3 1/7] lib/hexdump.c: Fix selftests

2019-06-16 Thread Alastair D'Silva
From: Alastair D'Silva The overflow tests did not account for the situation where no overflow occurs and len < rowsize. This patch renames the cryptic variables and accounts for the above case. The selftests now pass. Signed-off-by: Alastair D'Silva --- lib/test_hexdump.c | 47 ++

[PATCH v3 2/7] lib/hexdump.c: Relax rowsize checks in hex_dump_to_buffer

2019-06-16 Thread Alastair D'Silva
From: Alastair D'Silva This patch removes the hardcoded row limits and allows for other lengths. These lengths must still be a multiple of groupsize. This allows structs that are not 16/32 bytes to display on a single line. This patch also expands the self-tests to test row sizes up to 64 bytes

[PATCH v3 3/7] lib/hexdump.c: Optionally suppress lines of repeated bytes

2019-06-16 Thread Alastair D'Silva
From: Alastair D'Silva Some buffers may only be partially filled with useful data, while the rest is padded (typically with 0x00 or 0xff). This patch introduces a flag to allow the supression of lines of repeated bytes, which are replaced with '** Skipped %u bytes of value 0x%x **' An inline wr

[PATCH v3 6/7] lib/hexdump.c: Allow multiple groups to be separated by spaces

2019-06-16 Thread Alastair D'Silva
From: Alastair D'Silva Similar to the previous patch, this patch separates groups by 2 spaces for the hex fields, and 1 space for the ASCII field. eg. buf:: 454d414e 43415053 4e495f45 00584544 NAMESPAC E_INDEX. buf:0010: 0002 Sign

[PATCH v3 7/7] lib/hexdump.c: Optionally retain byte ordering

2019-06-16 Thread Alastair D'Silva
From: Alastair D'Silva The behaviour of hexdump groups is to print the data out as if it was a native-endian number. This patch tweaks the documentation to make this clear, and also adds the HEXDUMP_RETAIN_BYTE_ORDER flag to allow groups of multiple bytes to be printed without affecting the orde

Re: [RFC PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-16 Thread Lucas Bates
On Fri, Jun 14, 2019 at 5:37 AM Nicolas Dichtel wrote: > > Le 05/06/2019 à 23:08, Lucas Bates a écrit : > > Apologies for the delay in getting this out. I've been busy > > with other things and this change was a little trickier than > > I expected. > > > > This patch restores the original behaviou

linux-next: manual merge of the net-next tree with the net tree

2019-06-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/wireless/nl80211.c between commit: 180aa422ef27 ("nl80211: fill all policy .type entries") from the net tree and commit: 1a28ed213696 ("nl80211: fill all policy .type entries") from the net-next tree. I fixed

linux-next: manual merge of the net-next tree with the net tree

2019-06-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/vmw_vsock/hyperv_transport.c between commit: d424a2afd7da ("hv_sock: Suppress bogus "may be used uninitialized" warnings") from the net tree and commit: ac383f58f3c9 ("hv_sock: perf: Allow the socket buffer siz

linux-next: manual merge of the net-next tree with Linus' tree

2019-06-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/mac80211/cfg.c between commit: 28c61a66abd6 ("treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 432") from Linus' tree and commit: bd718fc11d5b ("mac80211: use STA info in rate_control_send_low()"

linux-next: manual merge of the net-next tree with the sh tree

2019-06-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got conflicts in: arch/sh/configs/se7712_defconfig arch/sh/configs/se7721_defconfig arch/sh/configs/titan_defconfig between commit: 7c04efc8d2ef ("sh: configs: Remove useless UEVENT_HELPER_PATH") from the sh tree and commit: a514

[PATCHv2 net-next] team: add ethtool get_link_ksettings

2019-06-16 Thread Hangbin Liu
Like bond, add ethtool get_link_ksettings to show the total speed. v2: no update, just repost. Signed-off-by: Hangbin Liu --- drivers/net/team/team.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index b48006e7fa

Re: [PATCH net-next 08/17] netdevsim: Adjust accounting for IPv6 multipath notifications

2019-06-16 Thread David Ahern
On 6/15/19 8:07 AM, Ido Schimmel wrote: > diff --git a/drivers/net/netdevsim/fib.c b/drivers/net/netdevsim/fib.c > index 83ba5113210d..6e5498ef3855 100644 > --- a/drivers/net/netdevsim/fib.c > +++ b/drivers/net/netdevsim/fib.c > @@ -137,19 +137,20 @@ static int nsim_fib_rule_event(struct nsim_fib_d

Re: [PATCH v2] net: ipv4: move tcp_fastopen server side code to SipHash library

2019-06-16 Thread Herbert Xu
On Fri, Jun 14, 2019 at 04:01:22PM +0200, Ard Biesheuvel wrote: > Using a bare block cipher in non-crypto code is almost always a bad idea, > not only for security reasons (and we've seen some examples of this in > the kernel in the past), but also for performance reasons. > > In the TCP fastopen

Re: [PATCH net-next 03/17] ipv6: Extend notifier info for multipath routes

2019-06-16 Thread David Ahern
On 6/15/19 8:07 AM, Ido Schimmel wrote: > From: Ido Schimmel > > Extend the IPv6 FIB notifier info with number of sibling routes being > notified. > > This will later allow listeners to process one notification for a > multipath routes instead of N, where N is the number of nexthops. > > Signed

Re: [PATCH net-next 02/17] netlink: Add field to skip in-kernel notifications

2019-06-16 Thread David Ahern
On 6/15/19 8:07 AM, Ido Schimmel wrote: > From: Ido Schimmel > > The struct includes a 'skip_notify' flag that indicates if netlink > notifications to user space should be suppressed. As explained in commit > 3b1137fe7482 ("net: ipv6: Change notifications for multipath add to > RTA_MULTIPATH"), t

Re: [PATCH net-next 01/17] netlink: Document all fields of 'struct nl_info'

2019-06-16 Thread David Ahern
On 6/15/19 8:07 AM, Ido Schimmel wrote: > From: Ido Schimmel > > Some fields were not documented. Add documentation. > > Signed-off-by: Ido Schimmel > Acked-by: Jiri Pirko > --- > include/net/netlink.h | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: David Ahern

[PATCH] ipmroute: Prevent overlapping storage of `filter` global

2019-06-16 Thread Michael Forney
This variable has the same name as `struct xfrm_filter filter` in ip/ipxfrm.c, but overrides that definition since `struct rtfilter` is larger. This is visible when built with -Wl,--warn-common in LDFLAGS: /usr/bin/ld: ipxfrm.o: warning: common of `filter' overridden by larger common fro

Re: [PATCH net-next] selftests/net: fix warnings in TFO key rotation selftest

2019-06-16 Thread David Miller
From: Willem de Bruijn Date: Sun, 16 Jun 2019 13:15:01 -0400 > From: Willem de Bruijn > > One warning each on signedness, unused variable and return type. > > Fixes: 10fbcdd12aa2 ("selftests/net: add TFO key rotation selftest") > Signed-off-by: Willem de Bruijn Applied.

Re: [PATCH net-next] x25_asy: fixed function name in error message.

2019-06-16 Thread David Miller
From: Jeremy Sowden Date: Sun, 16 Jun 2019 11:43:32 +0100 > Replaced incorrect hard-coded function-name in error message with > __func__. > > Signed-off-by: Jeremy Sowden Applied.

Re: [PATCH net-next] lapb: moved export of lapb_register.

2019-06-16 Thread David Miller
From: Jeremy Sowden Date: Sun, 16 Jun 2019 11:41:59 +0100 > The EXPORT_SYMBOL for lapb_register was next to a different function. > Moved it to the right place. > > Signed-off-by: Jeremy Sowden Applied, thanks.

Re: [PATCH net] ax25: fix inconsistent lock state in ax25_destroy_timer

2019-06-16 Thread David Miller
From: Eric Dumazet Date: Sat, 15 Jun 2019 16:40:52 -0700 > Before thread in process context uses bh_lock_sock() > we must disable bh. > > sysbot reported : ... > Signed-off-by: Eric Dumazet > Reported-by: syzbot Applied and queued up for -stable.

Re: [PATCH net] neigh: fix use-after-free read in pneigh_get_next

2019-06-16 Thread David Miller
From: Eric Dumazet Date: Sat, 15 Jun 2019 16:28:48 -0700 > Nine years ago, I added RCU handling to neighbours, not pneighbours. > (pneigh are not commonly used) > > Unfortunately I missed that /proc dump operations would use a > common entry and exit point : neigh_seq_start() and neigh_seq_stop(

Re: [PATCH net] tcp: fix compile error if !CONFIG_SYSCTL

2019-06-16 Thread David Miller
From: Eric Dumazet Date: Sat, 15 Jun 2019 13:19:55 -0700 > tcp_tx_skb_cache_key and tcp_rx_skb_cache_key must be available > even if CONFIG_SYSCTL is not set. > > Fixes: 0b7d7f6b2208 ("tcp: add tcp_tx_skb_cache sysctl") > Fixes: ede61ca474a0 ("tcp: add tcp_rx_skb_cache sysctl") > Signed-off-by:

Re: [PATCH net-next 1/1] tc-tests: updated skbedit tests

2019-06-16 Thread David Miller
From: Roman Mashak Date: Sat, 15 Jun 2019 16:25:50 -0400 > - Added index upper bound test case > - Added mark upper bound test case > - Re-worded descriptions to few cases for clarity > > Signed-off-by: Roman Mashak Applied.

Re: [PATCH net-next 1/1] tc-tests: added path to ip command in tdc

2019-06-16 Thread David Miller
From: Roman Mashak Date: Sat, 15 Jun 2019 15:41:43 -0400 > This macro $IP will be used in upcoming tc tests, which require > to create interfaces etc. > > Signed-off-by: Roman Mashak Applied.

Re: [PATCH net-next 00/17] mlxsw: Improve IPv6 route insertion rate

2019-06-16 Thread David Miller
David A., please review the ipv6 notification changes. Thank you.

Re: [PATCH net v2] net: handle 802.1P vlan 0 packets properly

2019-06-16 Thread David Miller
From: Govindarajulu Varadarajan Date: Fri, 14 Jun 2019 06:13:54 -0700 > When stack receives pkt: [802.1P vlan 0][802.1AD vlan 100][IPv4], > vlan_do_receive() returns false if it does not find vlan_dev. Later > __netif_receive_skb_core() fails to find packet type handler for > skb->protocol 801.1A

Re: [PATCH net] bnx2x: Check if transceiver implements DDM before access

2019-06-16 Thread David Miller
From: "Mauro S. M. Rodrigues" Date: Thu, 13 Jun 2019 16:25:40 -0300 > Some transceivers may comply with SFF-8472 even though they do not > implement the Digital Diagnostic Monitoring (DDM) interface described in > the spec. The existence of such area is specified by the 6th bit of byte > 92, set

Re: [PATCH net v4 1/8] ipv4/fib_frontend: Rename ip_valid_fib_dump_req, provide non-strict version

2019-06-16 Thread Stefano Brivio
On Sat, 15 Jun 2019 05:27:05 +0200 Stefano Brivio wrote: > On Fri, 14 Jun 2019 21:16:54 -0600 > David Ahern wrote: > > > On 6/14/19 9:13 PM, Stefano Brivio wrote: > > > On Fri, 14 Jun 2019 20:54:49 -0600 > > > David Ahern wrote: > > > > > >> On 6/14/19 7:32 PM, Stefano Brivio wrote:

[PATCH net-next 2/2] net: dsa: mt7530: Add MT7621 TRGMII mode support

2019-06-16 Thread René van Dorst
MT7621 internal MT7530 switch also supports TRGMII mode. TRGMII speed is 1200MBit. Signed-off-by: René van Dorst --- drivers/net/dsa/mt7530.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index c7d352da544

[PATCH net-next 0/2] net: mediatek: Add MT7621 TRGMII mode support

2019-06-16 Thread René van Dorst
Like many other mediatek SOCs, the MT7621 SOC and the internal MT7530 switch both supports TRGMII mode. MT7621 TRGMII speed is 1200MBit. René van Dorst (2): net: ethernet: mediatek: Add MT7621 TRGMII mode support net: dsa: mt7530: Add MT7621 TRGMII mode support drivers/net/dsa/mt7530.c

[PATCH net-next 1/2] net: ethernet: mediatek: Add MT7621 TRGMII mode support

2019-06-16 Thread René van Dorst
MT7621 SOC also supports TRGMII. TRGMII speed is 1200MBit. Signed-off-by: René van Dorst --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 38 ++--- drivers/net/ethernet/mediatek/mtk_eth_soc.h | 11 ++ 2 files changed, 45 insertions(+), 4 deletions(-) diff --git a/drivers/ne

[PATCH net-next] selftests/net: fix warnings in TFO key rotation selftest

2019-06-16 Thread Willem de Bruijn
From: Willem de Bruijn One warning each on signedness, unused variable and return type. Fixes: 10fbcdd12aa2 ("selftests/net: add TFO key rotation selftest") Signed-off-by: Willem de Bruijn --- tools/testing/selftests/net/tcp_fastopen_backup_key.c | 5 ++--- 1 file changed, 2 insertions(+), 3 d

[PATCH net] lapb: fixed leak of control-blocks.

2019-06-16 Thread Jeremy Sowden
lapb_register calls lapb_create_cb, which initializes the control- block's ref-count to one, and __lapb_insert_cb, which increments it when adding the new block to the list of blocks. lapb_unregister calls __lapb_remove_cb, which decrements the ref-count when removing control-block from the list o

HI

2019-06-16 Thread James Williams
-- My greeting to you and your family, I am Captain JAMES WILLIAMS. I'm 49 years old, from the united states, but I am currently in Syria for peace keeping mission. I am the commanding officer of the third Battalion soldier regime. Please forgive my manners I am not good when it comes to the

net: ethernet: stmmac: dwmac: mac10_100_1000 star report

2019-06-16 Thread Avi Fishman
Hi all, Synopsys hasn't changed its wdc_ether_mac10_100_1000 since version 3.73a in 2013. They have some open starss (errata) that some of them can be worked around with SW. See https://www.synopsys.com/dw/star.php?c=dwc_ether_mac10_100_1000_universal Does stmmac driver implement those workaround

Re: [PATCH rdma-next v1 0/4] Expose ENCAP mode to mlx5_ib

2019-06-16 Thread Leon Romanovsky
On Wed, Jun 12, 2019 at 03:20:10PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Changelog v0->v1: > * Added patch to devlink to use declared enum for encap mode instead of u8 > * Constify input argumetn to encap mode function > * fix encap variable type to be boolean > > --

Re: [PATCH mlx5-next v1 1/4] net/mlx5: Declare more strictly devlink encap mode

2019-06-16 Thread Jiri Pirko
Sun, Jun 16, 2019 at 12:53:27PM CEST, l...@kernel.org wrote: >On Sun, Jun 16, 2019 at 12:39:40PM +0200, Jiri Pirko wrote: >> Sun, Jun 16, 2019 at 12:15:07PM CEST, l...@kernel.org wrote: >> >On Sun, Jun 16, 2019 at 12:07:07PM +0200, Jiri Pirko wrote: >> >> Thu, Jun 13, 2019 at 07:59:54AM CEST, l...@

Re: [PATCH net-next v1 08/11] xdp: tracking page_pool resources and safe removal

2019-06-16 Thread Tariq Toukan
On 6/15/2019 12:33 PM, Ivan Khoronzhuk wrote: > On Thu, Jun 13, 2019 at 08:28:42PM +0200, Jesper Dangaard Brouer wrote: > Hi, Jesper > >> This patch is needed before we can allow drivers to use page_pool for >> DMA-mappings. Today with page_pool and XDP return API, it is possible to >> remove th

Re: [PATCH mlx5-next v1 1/4] net/mlx5: Declare more strictly devlink encap mode

2019-06-16 Thread Leon Romanovsky
On Sun, Jun 16, 2019 at 12:39:40PM +0200, Jiri Pirko wrote: > Sun, Jun 16, 2019 at 12:15:07PM CEST, l...@kernel.org wrote: > >On Sun, Jun 16, 2019 at 12:07:07PM +0200, Jiri Pirko wrote: > >> Thu, Jun 13, 2019 at 07:59:54AM CEST, l...@kernel.org wrote: > >> >On Thu, Jun 13, 2019 at 04:32:25AM +,

[PATCH net-next] x25_asy: fixed function name in error message.

2019-06-16 Thread Jeremy Sowden
Replaced incorrect hard-coded function-name in error message with __func__. Signed-off-by: Jeremy Sowden --- drivers/net/wan/x25_asy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/wan/x25_asy.c index d78bc838d631..914be5847386 10

[PATCH net-next] lapb: moved export of lapb_register.

2019-06-16 Thread Jeremy Sowden
The EXPORT_SYMBOL for lapb_register was next to a different function. Moved it to the right place. Signed-off-by: Jeremy Sowden --- net/lapb/lapb_iface.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/lapb/lapb_iface.c b/net/lapb/lapb_iface.c index 03f0cd872dce..600d75

Re: [PATCH mlx5-next v1 1/4] net/mlx5: Declare more strictly devlink encap mode

2019-06-16 Thread Jiri Pirko
Sun, Jun 16, 2019 at 12:15:07PM CEST, l...@kernel.org wrote: >On Sun, Jun 16, 2019 at 12:07:07PM +0200, Jiri Pirko wrote: >> Thu, Jun 13, 2019 at 07:59:54AM CEST, l...@kernel.org wrote: >> >On Thu, Jun 13, 2019 at 04:32:25AM +, Parav Pandit wrote: >> >> >> >> >> >> > -Original Message-

Re: [PATCH mlx5-next v1 1/4] net/mlx5: Declare more strictly devlink encap mode

2019-06-16 Thread Leon Romanovsky
On Sun, Jun 16, 2019 at 12:07:07PM +0200, Jiri Pirko wrote: > Thu, Jun 13, 2019 at 07:59:54AM CEST, l...@kernel.org wrote: > >On Thu, Jun 13, 2019 at 04:32:25AM +, Parav Pandit wrote: > >> > >> > >> > -Original Message- > >> > From: Leon Romanovsky > >> > Sent: Wednesday, June 12, 2019

Re: [PATCH mlx5-next v1 1/4] net/mlx5: Declare more strictly devlink encap mode

2019-06-16 Thread Jiri Pirko
Thu, Jun 13, 2019 at 07:59:54AM CEST, l...@kernel.org wrote: >On Thu, Jun 13, 2019 at 04:32:25AM +, Parav Pandit wrote: >> >> >> > -Original Message- >> > From: Leon Romanovsky >> > Sent: Wednesday, June 12, 2019 5:50 PM >> > To: Doug Ledford ; Jason Gunthorpe >> > >> > Cc: Leon Roman

Re: [PATCH] net: phylink: set the autoneg state in phylink_phy_change

2019-06-16 Thread Russell King - ARM Linux admin
On Sat, Jun 15, 2019 at 06:08:54PM -0700, David Miller wrote: > From: Russell King - ARM Linux admin > Date: Sat, 15 Jun 2019 23:13:28 +0100 > > > On Sat, Jun 15, 2019 at 01:30:21PM -0700, David Miller wrote: > >> From: Ioana Ciornei > >> Date: Thu, 13 Jun 2019 09:37:51 +0300 > >> > >> > The ph

[PATCH net] tipc: purge deferredq list for each grp member in tipc_group_delete

2019-06-16 Thread Xin Long
Syzbot reported a memleak caused by grp members' deferredq list not purged when the grp is be deleted. The issue occurs when more(msg_grp_bc_seqno(hdr), m->bc_rcv_nxt) in tipc_group_filter_msg() and the skb will stay in deferredq. So fix it by calling __skb_queue_purge for each member's deferredq

Re: Understanding Ethernet Architecture (I/O --> MDIO --> MII vs I/O --> MAC) for mt7620 (OpenWRT)

2019-06-16 Thread Daniel Santos
Ah hah! I've found my answer on page 340 (414. PIAC: PHY Indirect Access Control(offset:0x7004)) and in mt7620_gsw_config: static int mt7620_gsw_config(struct fe_priv *priv) { struct mt7620_gsw *gsw = (struct mt7620_gsw *) priv->soc->swpriv; /* is the mt7530 internal or external *

Re: [PATCH net 3/4] tcp: add tcp_tx_skb_cache sysctl

2019-06-16 Thread Feng Tang
Hi Eric, On Fri, Jun 14, 2019 at 04:22:20PM -0700, Eric Dumazet wrote: > Feng Tang reported a performance regression after introduction > of per TCP socket tx/rx caches, for TCP over loopback (netperf) > > There is high chance the regression is caused by a change on > how well the 32 KB per-threa

Re: [PATCH net 2/4] tcp: add tcp_rx_skb_cache sysctl

2019-06-16 Thread Feng Tang
On Fri, Jun 14, 2019 at 04:22:19PM -0700, Eric Dumazet wrote: > Instead of relying on rps_needed, it is safer to use a separate > static key, since we do not want to enable TCP rx_skb_cache > by default. This feature can cause huge increase of memory > usage on hosts with millions of sockets. Than

Re: [PATCH net-next 1/3] net/sched: Introduce action ct

2019-06-16 Thread Paul Blakey
On 6/14/2019 9:02 PM, Cong Wang wrote: > On Tue, Jun 11, 2019 at 7:05 AM Paul Blakey wrote: >> Allow sending a packet to conntrack and set conntrack zone, mark, >> labels and nat parameters. >> > This is too short to justify why you want to play with L3 stuff in L2. > Please be as specific as you