On Sat, Jun 15, 2019 at 06:08:54PM -0700, David Miller wrote:
> From: Russell King - ARM Linux admin <li...@armlinux.org.uk>
> Date: Sat, 15 Jun 2019 23:13:28 +0100
>
> > On Sat, Jun 15, 2019 at 01:30:21PM -0700, David Miller wrote:
> >> From: Ioana Ciornei <ioana.cior...@nxp.com>
> >> Date: Thu, 13 Jun 2019 09:37:51 +0300
> >>
> >> > The phy_state field of phylink should carry only valid information
> >> > especially when this can be passed to the .mac_config callback.
> >> > Update the an_enabled field with the autoneg state in the
> >> > phylink_phy_change function.
> >> >
> >> > Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
> >> > Signed-off-by: Ioana Ciornei <ioana.cior...@nxp.com>
> >>
> >> Applied and queued up for -stable, thanks.
> >
> > This is not a fix; it is an attempt to make phylink work differently
> > from how it's been designed for the dpaa2 driver. I've already stated
> > that this field is completely meaningless, so I'm surprised you
> > applied it.
>
> I'm sorry, I did wait a day or so to see any direct responses to this
> patch and I saw no feedback.
>
> I'll revert.
Hi Dave,
Thanks for the revert. There was discussion surrounding this patch:
https://www.mail-archive.com/netdev@vger.kernel.org/thrd2.html#302220
It was then re-posted as part of a later RFC series ("DPAA2 MAC
Driver") which shows why the change was proposed, where the discussion
continued on Friday. The patch ended up with a slightly different
subject line.
There is still further discussion required to try and work out a way
forward.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
