Re: [PATCH bpf] bpf: Check sk_fullsock() before returning from bpf_sk_lookup()

2019-05-18 Thread Martin Lau
On Sat, May 18, 2019 at 06:52:48PM -0700, Joe Stringer wrote: > On Sat, May 18, 2019, 09:05 Martin Lau wrote: > > > > On Sat, May 18, 2019 at 08:38:46AM -1000, Joe Stringer wrote: > > > On Fri, May 17, 2019, 12:02 Martin Lau wrote: > > > > > > > On Fri, May 17, 2019 at 02:51:48PM -0700, Eric Duma

Re: [PATCH bpf] bpf: Check sk_fullsock() before returning from bpf_sk_lookup()

2019-05-18 Thread Joe Stringer
On Sat, May 18, 2019, 09:05 Martin Lau wrote: > > On Sat, May 18, 2019 at 08:38:46AM -1000, Joe Stringer wrote: > > On Fri, May 17, 2019, 12:02 Martin Lau wrote: > > > > > On Fri, May 17, 2019 at 02:51:48PM -0700, Eric Dumazet wrote: > > > > > > > > > > > > On 5/17/19 2:21 PM, Martin KaFai Lau wr

Re: PROBLEM: [1/2] Marvell 88E8040 (sky2) stopped working

2019-05-18 Thread Octavio Alvarez
Hi, Petr, On 5/18/19 4:58 PM, Petr Štetiar wrote: >> Linux version 5.1.0-12511-g72cf0b07418a (alvarezp@alvarezp-samsung) > > What do I need to do/apply in order to get the same source tree with > 72cf0b07418a hash? I'm not able to find that commit. It's the most recent master, so my guess is jus

Re: RFC: Fixing SK_REUSEPORT from sk_lookup_* helpers

2019-05-18 Thread Joe Stringer
On Fri, May 17, 2019 at 7:15 AM Lorenz Bauer wrote: > > On Thu, 16 May 2019 at 21:33, Alexei Starovoitov > wrote: > > > > On Thu, May 16, 2019 at 09:41:34AM +0100, Lorenz Bauer wrote: > > > On Wed, 15 May 2019 at 18:16, Joe Stringer wrote: > > > > > > > > On Wed, May 15, 2019 at 8:11 AM Lorenz B

Re: [PATCH net] kselftests: netfilter: fix leftover net/net-next merge conflict

2019-05-18 Thread David Miller
From: Florian Westphal Date: Sat, 18 May 2019 23:33:35 +0200 > In nf-next, I had extended this script to also cover NAT support for the > inet family. > > In nf, I extended it to cover a regression with 'fully-random' masquerade. > > Make this script work again by resolving the conflicts as nee

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-18 Thread Pablo Neira Ayuso
On Fri, May 17, 2019 at 04:27:29PM +0100, Edward Cree wrote: > On 15/05/2019 20:39, Edward Cree wrote: [...] > Pablo, how do the two options interact with your netfilter offload?  I'm >  guessing it's easier for you to find a unique pointer than to generate >  a unique u32 action_index for each act

Re: PROBLEM: [1/2] Marvell 88E8040 (sky2) stopped working

2019-05-18 Thread Petr Štetiar
Hi Octavio, > PROBLEM: [1/2] Marvell 88E8040 (sky2) stopped working I'm sorry, that I've ruined your day. > Linux version 5.1.0-12511-g72cf0b07418a (alvarezp@alvarezp-samsung) What do I need to do/apply in order to get the same source tree with 72cf0b07418a hash? I'm not able to find that commi

Re: ARCNET Contemporary Controls PCI20EX PCIe Card

2019-05-18 Thread Kenton, Stephen M.
On 5/17/19 2:38 PM, Michael Grzeschik wrote: > On Fri, May 17, 2019 at 07:03:19PM +, Kenton, Stephen M. wrote: >> I've got some old optical (as in eyeglasses) equipment that only talks >> over ARCNET that I want to get up and running. The PEX PCIe-to-PCI >> bridge is on the card with the SMC C

[PATCH net] kselftests: netfilter: fix leftover net/net-next merge conflict

2019-05-18 Thread Florian Westphal
In nf-next, I had extended this script to also cover NAT support for the inet family. In nf, I extended it to cover a regression with 'fully-random' masquerade. Make this script work again by resolving the conflicts as needed. Fixes: 8b4483658364f0 ("Merge git://git.kernel.org/pub/scm/linux/ker

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-18 Thread Jamal Hadi Salim
On 2019-05-17 1:14 p.m., Edward Cree wrote: On 17/05/2019 16:27, Edward Cree wrote: I'm now leaning towards the approach of adding "unsigned long cookie" to struct flow_action_entry and populating it with (unsigned long)act in tc_setup_flow_action(). For concreteness, here's what that look

Re: [RFC PATCH v2 net-next 2/3] flow_offload: restore ability to collect separate stats per action

2019-05-18 Thread Jamal Hadi Salim
On 2019-05-15 3:42 p.m., Edward Cree wrote: In the TC_CLSFLOWER_STATS callback from fl_hw_update_stats(), pass an array of struct flow_stats_entry, one for each action in the flow rule. Current drivers (which do not collect per-action stats, but rather per- rule) call flow_stats_update() in a

Re: [RFC PATCH v2 net-next 1/3] flow_offload: copy tcfa_index into flow_action_entry

2019-05-18 Thread Jamal Hadi Salim
On 2019-05-15 3:42 p.m., Edward Cree wrote: Required for support of shared counters (and possibly other shared per- action entities in future). Signed-off-by: Edward Cree --- include/net/flow_offload.h | 1 + net/sched/cls_api.c| 1 + 2 files changed, 2 insertions(+) diff --git a

Re: [RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-18 Thread Jamal Hadi Salim
On 2019-05-15 3:39 p.m., Edward Cree wrote: [..] A point for discussion: would it be better if, instead of the tcfa_index (for which the driver has to know the rules about which flow_action types share a namespace), we had some kind of globally unique cookie? In the same way that rule->coo

Re: [PATCH net 0/2] mlxsw: Two port module fixes

2019-05-18 Thread David Miller
From: Ido Schimmel Date: Sat, 18 May 2019 18:58:27 +0300 > From: Ido Schimmel > > Patch #1 fixes driver initialization failure on old ASICs due to > unsupported register access. This is fixed by first testing if the > register is supported. > > Patch #2 fixes reading of certain modules' EEPROM

Re: [PATCH bpf] bpf: Check sk_fullsock() before returning from bpf_sk_lookup()

2019-05-18 Thread Martin Lau
On Sat, May 18, 2019 at 08:38:46AM -1000, Joe Stringer wrote: > On Fri, May 17, 2019, 12:02 Martin Lau wrote: > > > On Fri, May 17, 2019 at 02:51:48PM -0700, Eric Dumazet wrote: > > > > > > > > > On 5/17/19 2:21 PM, Martin KaFai Lau wrote: > > > > The BPF_FUNC_sk_lookup_xxx helpers return RET_PTR

Re: [PATCH v2] net: phy: rename Asix Electronics PHY driver

2019-05-18 Thread Andrew Lunn
> My apologies - I had hoped that as a bugfix. this could go straight to net. Ah, O.K. You then need to put "PATCH net" to make it clear this is for net. Andrew

Re: [PATCH v2] net: phy: rename Asix Electronics PHY driver

2019-05-18 Thread Michael Schmitz
Hi Andrew, Am 19.05.2019 um 02:20 schrieb Andrew Lunn: On Sat, May 18, 2019 at 01:14:55PM +1200, Michael Schmitz wrote: Commit 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver") introduced a new PHY driver drivers/net/phy/asix.c that causes a module name conflict with a pre-existit

Re: [PATCH net] net: ip6_gre: access skb data after skb_cow_head()

2019-05-18 Thread David Miller
From: William Tu Date: Thu, 16 May 2019 09:25:48 -0700 > When increases the headroom, skb's pointer might get re-allocated. > Fix it by moving skb_cow_head before accessing the skb->data pointer. > > Fixes: 01b8d064d58b4 ("net: ip6_gre: Request headroom in __gre6_xmit()") > Reported-by: Haichao

[PATCH net 0/2] mlxsw: Two port module fixes

2019-05-18 Thread Ido Schimmel
From: Ido Schimmel Patch #1 fixes driver initialization failure on old ASICs due to unsupported register access. This is fixed by first testing if the register is supported. Patch #2 fixes reading of certain modules' EEPROM. The problem and solution are explained in detail in the commit message.

[PATCH net 2/2] mlxsw: core: Prevent reading unsupported slave address from SFP EEPROM

2019-05-18 Thread Ido Schimmel
From: Vadim Pasternak Prevent reading unsupported slave address from SFP EEPROM by testing Diagnostic Monitoring Type byte in EEPROM. Read only page zero of EEPROM, in case this byte is zero. If some SFP transceiver does not support Digital Optical Monitoring (DOM), reading SFP EEPROM slave addr

[PATCH net 1/2] mlxsw: core: Prevent QSFP module initialization for old hardware

2019-05-18 Thread Ido Schimmel
From: Vadim Pasternak Old Mellanox silicons, like switchx-2, switch-ib do not support reading QSFP modules temperature through MTMP register. Attempt to access this register on systems equipped with the this kind of silicon will cause initialization flow failure. Test for hardware resource capabi

RE: [PATCH 0/3] brcmfmac: sdio: Deal better w/ transmission errors waking from sleep

2019-05-18 Thread Avri Altman
> > This series attempts to deal better with the expected transmission > errors that we get when waking up the SDIO-based WiFi on > rk3288-veyron-minnie, rk3288-veyron-speedy, and rk3288-veyron-mickey. > > Some details about those errors can be found in > , but to summar

Re: [PATCH v2] net: phy: rename Asix Electronics PHY driver

2019-05-18 Thread Andrew Lunn
On Sat, May 18, 2019 at 01:14:55PM +1200, Michael Schmitz wrote: > Commit 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver") > introduced a new PHY driver drivers/net/phy/asix.c that causes a module > name conflict with a pre-existiting driver (drivers/net/usb/asix.c). > > The PHY dri

Re: [PATCH V5] net: phy: tja11xx: Add TJA11xx PHY driver

2019-05-18 Thread Andrew Lunn
On Sat, May 18, 2019 at 01:51:23AM +0200, Marek Vasut wrote: > Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special > BroadRReach 100BaseT1 PHYs used in automotive. Hi Marek > + }, { > + PHY_ID_MATCH_MODEL(PHY_ID_TJA1101), > + .name = "NXP

Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking

2019-05-18 Thread Peter Geis
On Tue, May 14, 2019 at 12:20 PM Serge Semin wrote: > > Hello Peter > > On Tue, May 14, 2019 at 07:53:21AM -0400, Peter Geis wrote: > > On Sun, May 12, 2019 at 3:34 AM Heiner Kallweit > > wrote: > > > > > > On 12.05.2019 04:50, Peter Geis wrote: > > > > On 5/11/2019 10:37 PM, Andrew Lunn wrote:

[PATCH v3] net/mlx5e: Add bonding device for indr block to offload the packet received from bonding device

2019-05-18 Thread wenxu
From: wenxu The mlx5e support the lag mode. When add mlx_p0 and mlx_p1 to bond0. packet received from mlx_p0 or mlx_p1 and in the ingress tc flower forward to vf0. The tc rule can't be offloaded because there is no indr_register_block for the bonding device. Signed-off-by: wenxu --- drivers/ne

[PATCH v2] can: gw: Fix error path of cgw_module_init

2019-05-18 Thread YueHaibing
This patch add error path for cgw_module_init to avoid possible crash if some error occurs. Fixes: c1aabdf379bc ("can-gw: add netlink based CAN routing") Signed-off-by: YueHaibing --- net/can/gw.c | 48 +--- 1 file changed, 33 insertions(+), 15 deletio

Re: [RFC bpf-next 0/7] busy poll support for AF_XDP sockets

2019-05-18 Thread Magnus Karlsson
On Fri, May 17, 2019 at 8:20 PM Jakub Kicinski wrote: > > On Thu, 16 May 2019 14:37:51 +0200, Magnus Karlsson wrote: > > Applications > > method cores irqstxpushrxdrop l2fwd > > ---

可鐦鳔

2019-05-18 Thread Hbdw
1365口09口04255微