On 2019-05-15 3:39 p.m., Edward Cree wrote: [..]
A point for discussion: would it be better if, instead of the tcfa_index (for which the driver has to know the rules about which flow_action types share a namespace), we had some kind of globally unique cookie? In the same way that rule->cookie is really a pointer, could we use the address of the TC-internal data structure representing the action?
tcfa_index + action identifier seem to be sufficiently global, no? Then we dont have a mismatch with what the kernel(non-offloaded) semantics. Note: The kernel is free to generate the index (if the user doesnt specify).
Do rules that share an action all point to the same struct tc_action in their tcf_exts, for instance?
Yes they do. cheers, jamal
