On 2019-05-15 3:42 p.m., Edward Cree wrote:
In the TC_CLSFLOWER_STATS callback from fl_hw_update_stats(), pass an
array of struct flow_stats_entry, one for each action in the flow rule.
Current drivers (which do not collect per-action stats, but rather per-
rule) call flow_stats_update() in a loop with the same values for all
actions; this is roughly what they did before 3b1903ef97c0, except that
there is not a helper function (like tcf_exts_stats_update()) that does
it for them, because we don't want to encourage future drivers to do
the same thing (and there isn't a need for a preempt_disable() like in
tcf_exts_stats_update()).
Also do the same in mall_stats_hw_filter()'s TC_CLSMATCHALL_STATS
callback, since it also uses tcf_exts_stats_update().
Signed-off-by: Edward Cree <ec...@solarflare.com>
Looks good to me.
Your patch doesnt have U32. IIRC, I have seen stats on ixgbe with the
u32 classifier last time i mucked around with it
(maybe Pablo's changes removed it?).
cheers,
jamal
