Re: dsa: using multi-gbps speeds on CPU port

2019-05-15 Thread Vladimir Oltean
On Wed, 15 May 2019 at 19:19, Russell King - ARM Linux admin wrote: > > On Wed, May 15, 2019 at 09:09:26AM -0700, Florian Fainelli wrote: > > Vladimir mentioned a few weeks ago that he is considering adding support > > for PHYLIB and PHYLINK to run without a net_device instance, you two > > should

Re: [Xen-devel] [PATCH] xen/netfront: Remove unneeded .resume callback

2019-05-15 Thread Oleksandr Andrushchenko
Hello, Anchal! On 3/29/19 1:19 AM, Anchal Agarwal wrote: [snip] Great, could you please let us know what is the progress and further plans on that, so we do not work on the same code and can coordinate our efforts somehow? Anchal, could you please shed some light on this? Looks like my previous

WARNING: locking bug in udpv6_pre_connect

2019-05-15 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:8f779443 net: phy: realtek: fix double page ops in generic.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=13f16ee8a0 kernel config: https://syzkaller.appspot.com/x/.config?x=4005028a9d5ddac8 dashboa

WARNING: locking bug in inet_autobind

2019-05-15 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:35c99ffa Merge tag 'for_linus' of git://git.kernel.org/pub.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=10e970f4a0 kernel config: https://syzkaller.appspot.com/x/.config?x=82f0809e8f0a8c87 da

Re: [PATCH net] rhashtable: fix sparse RCU warnings on bit lock in bucket pointer

2019-05-15 Thread Herbert Xu
On Wed, May 15, 2019 at 01:55:01PM -0700, Jakub Kicinski wrote: > Since the bit_spin_lock() operations don't actually dereference > the pointer, it's fine to forcefully drop the RCU annotation. > This fixes 7 sparse warnings per include site. > > Fixes: 8f0db018006a ("rhashtable: use bit_spin_lock

Re: [PATCH net] ipv6: prevent possible fib6 leaks

2019-05-15 Thread Martin Lau
On Wed, May 15, 2019 at 07:39:52PM -0700, Eric Dumazet wrote: > At ipv6 route dismantle, fib6_drop_pcpu_from() is responsible > for finding all percpu routes and set their ->from pointer > to NULL, so that fib6_ref can reach its expected value (1). > > The problem right now is that other cpus can

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread Martin Lau
On Wed, May 15, 2019 at 06:06:58PM -0600, David Ahern wrote: > On 5/15/19 6:03 PM, Wei Wang wrote: > > Thanks Martin. > > Changing __rt6_find_exception_xxx() might not be easy cause other > > callers of this function does not really need to back off and use > > another saddr. > > And the validation

RE: [PATCH v2] hv_sock: Add support for delayed close

2019-05-15 Thread Dexuan Cui
> From: Sunil Muthuswamy > Sent: Tuesday, May 14, 2019 5:56 PM > ... > +static bool hvs_close_lock_held(struct vsock_sock *vsk) > { > ... > + schedule_delayed_work(&vsk->close_work, HVS_CLOSE_TIMEOUT); Reviewed-by: Dexuan Cui The patch looks good to me. Thank you, Sunil! Next, we're going

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread Wei Wang
On Wed, May 15, 2019 at 5:07 PM David Ahern wrote: > > On 5/15/19 6:03 PM, Wei Wang wrote: > > Thanks Martin. > > Changing __rt6_find_exception_xxx() might not be easy cause other > > callers of this function does not really need to back off and use > > another saddr. > > And the validation of the

Re: [PATCH net] ipv6: prevent possible fib6 leaks

2019-05-15 Thread Wei Wang
On Wed, May 15, 2019 at 7:40 PM Eric Dumazet wrote: > > At ipv6 route dismantle, fib6_drop_pcpu_from() is responsible > for finding all percpu routes and set their ->from pointer > to NULL, so that fib6_ref can reach its expected value (1). > > The problem right now is that other cpus can still ca

[PATCH bpf] libbpf: move logging helpers into libbpf_internal.h

2019-05-15 Thread Andrii Nakryiko
libbpf_util.h header was recently exposed as public as a dependency of xsk.h. In addition to memory barriers, it contained logging helpers, which are not supposed to be exposed. This patch moves those into libbpf_internal.h, which is kept as an internal header. Cc: Stanislav Fomichev Cc: Daniel B

Re: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread Zhangshaokun
Hi Will, On 2019/5/15 17:47, Will Deacon wrote: > On Mon, Apr 15, 2019 at 07:18:22PM +0100, Robin Murphy wrote: >> On 12/04/2019 10:52, Will Deacon wrote: >>> I'm waiting for Robin to come back with numbers for a C implementation. >>> >>> Robin -- did you get anywhere with that? >> >> Still not wh

[PATCH net] ipv6: prevent possible fib6 leaks

2019-05-15 Thread Eric Dumazet
At ipv6 route dismantle, fib6_drop_pcpu_from() is responsible for finding all percpu routes and set their ->from pointer to NULL, so that fib6_ref can reach its expected value (1). The problem right now is that other cpus can still catch the route being deleted, since there is no rcu grace period

Re: [PATCH bpf] libbpf: don't fail when feature probing fails

2019-05-15 Thread Daniel Borkmann
On 05/15/2019 05:38 AM, Stanislav Fomichev wrote: > Otherwise libbpf is unusable from unprivileged process with > kernel.kernel.unprivileged_bpf_disabled=1. > All I get is EPERM from the probes, even if I just want to > open an ELF object and look at what progs/maps it has. > > Instead of dying on

Re: [bpf PATCH] net: tcp_bpf, correctly handle DONT_WAIT flags and timeo == 0

2019-05-15 Thread Daniel Borkmann
On 05/14/2019 06:42 AM, John Fastabend wrote: > The tcp_bpf_wait_data() routine needs to check timeo != 0 before > calling sk_wait_event() otherwise we may see unexpected stalls > on receiver. > > Arika did all the leg work here I just formaatted, posted and ran > a few tests. > > Fixes: 604326b4

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread Wei Wang
On Wed, May 15, 2019 at 2:51 PM Martin Lau wrote: > > On Tue, May 14, 2019 at 05:46:10PM -0700, Wei Wang wrote: > > From: Wei Wang > > > > When inserting route cache into the exception table, the key is > > generated with both src_addr and dest_addr with src addr routing. > > However, current log

Re: [PATCH bpf 1/2] selftests/bpf: add missing \n to flow_dissector CHECK errors

2019-05-15 Thread Daniel Borkmann
On 05/14/2019 11:12 PM, Stanislav Fomichev wrote: > Otherwise, in case of an error, everything gets mushed together. > > Fixes: a5cb33464e53 ("selftests/bpf: make flow dissector tests more > extensible") > Signed-off-by: Stanislav Fomichev Both applied, thanks!

Re: [RFC] folding socket->wq into struct socket

2019-05-15 Thread Eric Dumazet
On 5/5/19 11:25 AM, David Miller wrote: > From: Al Viro > Date: Sun, 5 May 2019 18:59:43 +0100 > >> On Sun, May 05, 2019 at 10:04:21AM -0700, David Miller wrote: >>> From: Al Viro >>> Date: Thu, 2 May 2019 17:32:23 +0100 >>> it appears that we might take freeing the socket itself to the

pull-request: bpf 2019-05-16

2019-05-15 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix a use after free in __dev_map_entry_free(), from Eric. 2) Several sockmap related bug fixes: a splat in strparser if it was never initialized, remove duplicate ingress msg list purg

Re: pull-request: bpf 2019-05-16

2019-05-15 Thread David Miller
From: Daniel Borkmann Date: Thu, 16 May 2019 01:54:28 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Fix a use after free in __dev_map_entry_free(), from Eric. > > 2) Several sockmap related bug fixes: a splat in strparser if >

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread David Ahern
On 5/15/19 6:03 PM, Wei Wang wrote: > Thanks Martin. > Changing __rt6_find_exception_xxx() might not be easy cause other > callers of this function does not really need to back off and use > another saddr. > And the validation of the result is a bit different for different callers. > What about add

Re: [PATCH net] rhashtable: fix sparse RCU warnings on bit lock in bucket pointer

2019-05-15 Thread Jakub Kicinski
On Thu, 16 May 2019 07:42:29 +1000, NeilBrown wrote: > On Wed, May 15 2019, Jakub Kicinski wrote: > > > Since the bit_spin_lock() operations don't actually dereference > > the pointer, it's fine to forcefully drop the RCU annotation. > > This fixes 7 sparse warnings per include site. > > > > Fixes

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-15 Thread Martin Lau
On Wed, May 15, 2019 at 11:31:44AM -0700, Wei Wang wrote: > On Wed, May 15, 2019 at 11:06 AM Martin Lau wrote: > > > > On Tue, May 14, 2019 at 12:33:25PM -0700, Wei Wang wrote: > > > I think the bug is because when creating exceptions, src_addr is not > > > always set even though fib6_info is in t

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread Martin Lau
On Tue, May 14, 2019 at 05:46:10PM -0700, Wei Wang wrote: > From: Wei Wang > > When inserting route cache into the exception table, the key is > generated with both src_addr and dest_addr with src addr routing. > However, current logic always assumes the src_addr used to generate the > key is a /

Re: [PATCH bpf v1 3/3] selftests/bpf: Avoid a clobbering of errno

2019-05-15 Thread Jakub Kicinski
On Wed, 15 May 2019 15:47:28 +0200, Krzesimir Nowak wrote: > Save errno right after bpf_prog_test_run returns, so we later check > the error code actually set by bpf_prog_test_run, not by some libcap > function. > > Cc: Jakub Kicinski > Fixes: 5a8d5209ac022 ("selftests: bpf: add trivial JSET test

Re: [PATCH bpf v1 2/3] selftests/bpf: Print a message when tester could not run a program

2019-05-15 Thread Jakub Kicinski
On Wed, 15 May 2019 15:47:27 +0200, Krzesimir Nowak wrote: > This prints a message when the error is about program type being not > supported by the test runner or because of permissions problem. This > is to see if the program we expected to run was actually executed. > > The messages are open-co

Re: [PATCH net] rhashtable: fix sparse RCU warnings on bit lock in bucket pointer

2019-05-15 Thread NeilBrown
On Wed, May 15 2019, Jakub Kicinski wrote: > Since the bit_spin_lock() operations don't actually dereference > the pointer, it's fine to forcefully drop the RCU annotation. > This fixes 7 sparse warnings per include site. > > Fixes: 8f0db018006a ("rhashtable: use bit_spin_locks to protect hash buc

[PATCH net] rhashtable: fix sparse RCU warnings on bit lock in bucket pointer

2019-05-15 Thread Jakub Kicinski
Since the bit_spin_lock() operations don't actually dereference the pointer, it's fine to forcefully drop the RCU annotation. This fixes 7 sparse warnings per include site. Fixes: 8f0db018006a ("rhashtable: use bit_spin_locks to protect hash bucket.") Signed-off-by: Jakub Kicinski Reviewed-by: Si

Re: [PATCH v12 1/5] can: m_can: Create a m_can platform framework

2019-05-15 Thread Dan Murphy
Marc On 5/9/19 11:11 AM, Dan Murphy wrote: > Create a m_can platform framework that peripheral > devices can register to and use common code and register sets. > The peripheral devices may provide read/write and configuration > support of the IP. > > Acked-by: Wolfgang Grandegger > Signed-off-by

[PATCH net 3/3] Documentation: add TLS offload documentation

2019-05-15 Thread Jakub Kicinski
Describe existing kernel TLS offload (added back in Linux 4.19) - the mechanism, the expected behavior and the notable corner cases. This documentation is mostly targeting hardware vendors who want to implement offload, to ensure consistency between implementations. Signed-off-by: Jakub Kicinski

[PATCH net 2/3] Documentation: tls: RSTify the ktls documentation

2019-05-15 Thread Jakub Kicinski
Convert the TLS doc to RST. Use C code blocks for the code samples, and mark hyperlinks. Signed-off-by: Jakub Kicinski Acked-by: Dave Watson Acked-by: Alexei Starovoitov --- Documentation/networking/index.rst| 1 + Documentation/networking/{tls.txt => tls.rst} | 42 +-

[PATCH net 0/3] Documentation: tls: add offload documentation

2019-05-15 Thread Jakub Kicinski
Hi! This set adds documentation for TLS offload. It starts by making the networking documentation a little easier to navigate by hiding driver docs a little deeper. It then RSTifys the existing Kernel TLS documentation. Last but not least TLS offload documentation is added. This should help vendor

[PATCH net 1/3] Documentation: net: move device drivers docs to a submenu

2019-05-15 Thread Jakub Kicinski
Some of the device drivers have really long document titles making the networking table of contents hard to look through. Place vendor drivers under a submenu. Signed-off-by: Jakub Kicinski Acked-by: Dave Watson Acked-by: Alexei Starovoitov --- .../networking/device_drivers/index.rst | 3

Kernel UDP behavior with missing destinations

2019-05-15 Thread Adam Urban
We have an application where we are use sendmsg() to send (lots of) UDP packets to multiple destinations over a single socket, repeatedly, and at a pretty constant rate using IPv4. In some cases, some of these destinations are no longer present on the network, but we continue sending data to them

Re: [PATCH net-next,RFC 2/2] netfilter: nf_tables: add hardware offload support

2019-05-15 Thread Jiri Pirko
Wed, May 15, 2019 at 11:13:26AM CEST, pa...@netfilter.org wrote: >On Wed, May 15, 2019 at 01:03:31AM +0200, Pablo Neira Ayuso wrote: >> On Tue, May 14, 2019 at 07:01:08PM +0200, Jiri Pirko wrote: >> > Thu, May 09, 2019 at 06:39:51PM CEST, pa...@netfilter.org wrote: >> > >This patch adds hardware of

[RFC PATCH v2 net-next 2/3] flow_offload: restore ability to collect separate stats per action

2019-05-15 Thread Edward Cree
In the TC_CLSFLOWER_STATS callback from fl_hw_update_stats(), pass an array of struct flow_stats_entry, one for each action in the flow rule. Current drivers (which do not collect per-action stats, but rather per- rule) call flow_stats_update() in a loop with the same values for all actions; thi

[RFC PATCH v2 net-next 3/3] flow_offload: include linux/kernel.h from flow_offload.h

2019-05-15 Thread Edward Cree
flow_stats_update() uses max_t, so ensure we have that defined. Signed-off-by: Edward Cree --- include/net/flow_offload.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h index 9e2c64eb6726..ccc280c5e0ac 100644 --- a/include/net/flow_off

[RFC PATCH v2 net-next 1/3] flow_offload: copy tcfa_index into flow_action_entry

2019-05-15 Thread Edward Cree
Required for support of shared counters (and possibly other shared per- action entities in future). Signed-off-by: Edward Cree --- include/net/flow_offload.h | 1 + net/sched/cls_api.c| 1 + 2 files changed, 2 insertions(+) diff --git a/include/net/flow_offload.h b/include/net/flow_off

[RFC PATCH v2 net-next 0/3] flow_offload: Re-add per-action statistics

2019-05-15 Thread Edward Cree
When the flow_offload infrastructure was added, per-action statistics, which were previously possible for drivers to support in TC offload, were not plumbed through, perhaps because the drivers in the tree did not implement them. In TC (and in the previous offload API) statistics are per-action,

Re: [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

2019-05-15 Thread Heiner Kallweit
On 15.05.2019 20:44, Andrew Lunn wrote: > On Wed, May 15, 2019 at 07:25:14PM +0200, Heiner Kallweit wrote: >> On 15.05.2019 18:19, Florian Fainelli wrote: >>> On 5/15/19 8:07 AM, Madalin-cristian Bucur wrote: XGMII interface mode no longer works on AQR107 after the recent changes, adding

Re: [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

2019-05-15 Thread Andrew Lunn
On Wed, May 15, 2019 at 07:25:14PM +0200, Heiner Kallweit wrote: > On 15.05.2019 18:19, Florian Fainelli wrote: > > On 5/15/19 8:07 AM, Madalin-cristian Bucur wrote: > >> XGMII interface mode no longer works on AQR107 after the recent changes, > >> adding back support. > >> > >> Fixes: 570c8a7d5303

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-15 Thread Wei Wang
On Wed, May 15, 2019 at 11:06 AM Martin Lau wrote: > > On Tue, May 14, 2019 at 12:33:25PM -0700, Wei Wang wrote: > > I think the bug is because when creating exceptions, src_addr is not > > always set even though fib6_info is in the subtree. (because of > > rt6_is_gw_or_nonexthop() check) > > Howe

Re: CFP: 4th RDMA Mini-Summit at LPC 2019

2019-05-15 Thread Yuval Shaia
On Wed, May 15, 2019 at 07:36:26PM +0300, Leon Romanovsky wrote: > On Wed, May 15, 2019 at 06:30:51PM +0300, Yuval Shaia wrote: > > On Tue, May 14, 2019 at 03:23:21PM +0300, Leon Romanovsky wrote: > > > This is a call for proposals for the 4th RDMA mini-summit at the Linux > > > Plumbers Conference

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-15 Thread Martin Lau
On Tue, May 14, 2019 at 12:33:25PM -0700, Wei Wang wrote: > I think the bug is because when creating exceptions, src_addr is not > always set even though fib6_info is in the subtree. (because of > rt6_is_gw_or_nonexthop() check) > However, when looking up for exceptions, we always set src_addr to t

RE: [RFC 1/2] netvsc: invoke xdp_generic from VF frame handler

2019-05-15 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, May 15, 2019 1:54 PM > To: Haiyang Zhang > Cc: KY Srinivasan ; da...@davemloft.net; > netdev@vger.kernel.org; Stephen Hemminger > Subject: Re: [RFC 1/2] netvsc: invoke xdp_generic from VF frame handler > > On Wed, 15 M

Re: [RFC 1/2] netvsc: invoke xdp_generic from VF frame handler

2019-05-15 Thread Stephen Hemminger
On Wed, 15 May 2019 17:50:25 + Haiyang Zhang wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Wednesday, May 15, 2019 4:03 AM > > To: KY Srinivasan ; Haiyang Zhang > > ; da...@davemloft.net > > Cc: netdev@vger.kernel.org; Stephen Hemminger > > Subject: [RFC 1/2] n

RE: [RFC 1/2] netvsc: invoke xdp_generic from VF frame handler

2019-05-15 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, May 15, 2019 4:03 AM > To: KY Srinivasan ; Haiyang Zhang > ; da...@davemloft.net > Cc: netdev@vger.kernel.org; Stephen Hemminger > Subject: [RFC 1/2] netvsc: invoke xdp_generic from VF frame handler > > XDP generic does

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread David Ahern
On 5/15/19 11:45 AM, Wei Wang wrote: >> >> you have to pass in a device. The first line in ip6_del_cached_rt: >> >> if (cfg->fc_ifindex && rt->dst.dev->ifindex != cfg->fc_ifindex) >> goto out; >> >> 'ip route get' is one way to check if it has been deleted. We really >> need to add

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread Wei Wang
From: David Ahern Date: Wed, May 15, 2019 at 10:33 AM To: Wei Wang Cc: Wei Wang, David Miller, Linux Kernel Network Developers, Martin KaFai Lau, Mikael Magnusson, Eric Dumazet > On 5/15/19 11:28 AM, Wei Wang wrote: > > From: Wei Wang > > Date: Wed, May 15, 2019 at 10:25 AM > > To: David Ahern >

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread David Ahern
On 5/15/19 11:28 AM, Wei Wang wrote: > From: Wei Wang > Date: Wed, May 15, 2019 at 10:25 AM > To: David Ahern > Cc: Wei Wang, David Miller, Linux Kernel Network Developers, Martin > KaFai Lau, Mikael Magnusson, Eric Dumazet > >>> >>> What about rt6_remove_exception_rt? >>> >>> You can add a 'cach

Re: FW: [PATCH] net: phy: aquantia: readd XGMII support for AQR107

2019-05-15 Thread Heiner Kallweit
On 15.05.2019 10:46, Madalin-cristian Bucur wrote: > XGMII interface mode no longer works on AQR107 after the recent changes, > adding back support. > I'd like to check the configuration of the system with the AQR107. Which board is it, and which DT config is used? > Signed-off-by: Madalin Bucur

[PATCH net] net: test nouarg before dereferencing zerocopy pointers

2019-05-15 Thread Willem de Bruijn
From: Willem de Bruijn Zerocopy skbs without completion notification were added for packet sockets with PACKET_TX_RING user buffers. Those signal completion through the TP_STATUS_USER bit in the ring. Zerocopy annotation was added only to avoid premature notification after clone or orphan, by tri

Re: [RFC net-next v2 00/14] net: stmmac: Selftests

2019-05-15 Thread Corentin Labbe
On Tue, May 14, 2019 at 05:45:22PM +0200, Jose Abreu wrote: > [ Submitting with net-next closed for proper review and testing. ] > > This introduces selftests support in stmmac driver. We add 9 basic sanity > checks and MAC loopback support for all cores within the driver. This way > more tests ca

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread Wei Wang
From: Wei Wang Date: Wed, May 15, 2019 at 10:25 AM To: David Ahern Cc: Wei Wang, David Miller, Linux Kernel Network Developers, Martin KaFai Lau, Mikael Magnusson, Eric Dumazet > > > > What about rt6_remove_exception_rt? > > > > You can add a 'cache' hook to ip/iproute.c to delete the cached rout

Re: [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

2019-05-15 Thread Heiner Kallweit
On 15.05.2019 18:19, Florian Fainelli wrote: > On 5/15/19 8:07 AM, Madalin-cristian Bucur wrote: >> XGMII interface mode no longer works on AQR107 after the recent changes, >> adding back support. >> >> Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface >> modes in config_init

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread Wei Wang
> > What about rt6_remove_exception_rt? > > You can add a 'cache' hook to ip/iproute.c to delete the cached routes > and verify that it works. I seem to have misplaced my patch to do it. I don't think rt6_remove_exception_rt() needs any change. It is because it gets the route cache rt6_info as the

Re: NVMEM address DT post processing [Was: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order]

2019-05-15 Thread Srinivas Kandagatla
On 14/05/2019 18:44, Petr Štetiar wrote: Srinivas Kandagatla [2019-05-14 16:13:22]: On 13/05/2019 12:16, Petr Štetiar wrote: Srinivas Kandagatla [2019-05-13 11:06:48]: On 13/05/2019 10:07, Petr Štetiar wrote: Srinivas Kandagatla [2019-05-13 09:25:55]: My initial idea was to add comp

Re: RFC: Fixing SK_REUSEPORT from sk_lookup_* helpers

2019-05-15 Thread Joe Stringer
On Wed, May 15, 2019 at 8:11 AM Lorenz Bauer wrote: > > In the BPF-based TPROXY session with Joe Stringer [1], I mentioned > that the sk_lookup_* helpers currently return inconsistent results if > SK_REUSEPORT programs are in play. > > SK_REUSEPORT programs are a hook point in inet_lookup. They ge

Re: [PATCH next] sysctl: add proc_dointvec_jiffies_minmax to limit the min/max write value

2019-05-15 Thread Kees Cook
On Wed, May 15, 2019 at 10:53:55PM +0800, Zhiqiang Liu wrote: > Friendly ping... > > 在 2019/4/24 12:04, Zhiqiang Liu 写道: > > > > Friendly ping... Hi! (Please include akpm on CC for next versions of this, as he's likely the person to take this patch.) > > > >> From: Zhiqiang Liu > >> > >> In

Re: [PATCH net] tcp: do not recycle cloned skbs

2019-05-15 Thread Eric Dumazet
On Wed, May 15, 2019 at 9:41 AM David Miller wrote: > > From: Eric Dumazet > Date: Wed, 15 May 2019 09:26:54 -0700 > > > On Wed, May 15, 2019 at 9:24 AM David Miller wrote: > >> > >> From: Eric Dumazet > >> Date: Wed, 15 May 2019 09:10:15 -0700 > >> > >> > It is illegal to change arbitrary fiel

Re: [PATCH net] tcp: do not recycle cloned skbs

2019-05-15 Thread David Miller
From: Eric Dumazet Date: Wed, 15 May 2019 09:26:54 -0700 > On Wed, May 15, 2019 at 9:24 AM David Miller wrote: >> >> From: Eric Dumazet >> Date: Wed, 15 May 2019 09:10:15 -0700 >> >> > It is illegal to change arbitrary fields in skb_shared_info if the >> > skb is cloned. >> > >> > Before callin

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread David Ahern
On 5/15/19 9:56 AM, David Ahern wrote: > You can add a 'cache' hook to ip/iproute.c to delete the cached routes > and verify that it works. I seem to have misplaced my patch to do it. found it. From 7a328753a93321a07a5228fb32ed881d82d7a537 Mon Sep 17 00:00:00 2001 From: David Ahern Date: Mon, 6 M

Re: CFP: 4th RDMA Mini-Summit at LPC 2019

2019-05-15 Thread Leon Romanovsky
On Wed, May 15, 2019 at 06:30:51PM +0300, Yuval Shaia wrote: > On Tue, May 14, 2019 at 03:23:21PM +0300, Leon Romanovsky wrote: > > This is a call for proposals for the 4th RDMA mini-summit at the Linux > > Plumbers Conference in Lisbon, Portugal, which will be happening on > > September 9-11h, 201

Re: [PATCH net-next] net: stmmac: socfpga: add RMII phy mode

2019-05-15 Thread Andrew Lunn
On Wed, May 15, 2019 at 09:18:15AM -0700, Florian Fainelli wrote: > On 5/15/19 8:24 AM, Andrew Lunn wrote: > >> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > >> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > >> @@ -251,6 +251,9 @@ static int socfpga_dwmac_set_phy_mode(str

Re: [PATCH net] tcp: do not recycle cloned skbs

2019-05-15 Thread Eric Dumazet
On Wed, May 15, 2019 at 9:24 AM David Miller wrote: > > From: Eric Dumazet > Date: Wed, 15 May 2019 09:10:15 -0700 > > > It is illegal to change arbitrary fields in skb_shared_info if the > > skb is cloned. > > > > Before calling skb_zcopy_clear() we need to ensure this rule, > > therefore we nee

Re: [PATCH net] tcp: do not recycle cloned skbs

2019-05-15 Thread David Miller
From: Eric Dumazet Date: Wed, 15 May 2019 09:10:15 -0700 > It is illegal to change arbitrary fields in skb_shared_info if the > skb is cloned. > > Before calling skb_zcopy_clear() we need to ensure this rule, > therefore we need to move the test from sk_stream_alloc_skb() > to sk_wmem_free_skb()

Re: [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

2019-05-15 Thread Florian Fainelli
On 5/15/19 8:07 AM, Madalin-cristian Bucur wrote: > XGMII interface mode no longer works on AQR107 after the recent changes, > adding back support. > > Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface modes > in config_init") > > Signed-off-by: Madalin Bucur Just so you

Re: dsa: using multi-gbps speeds on CPU port

2019-05-15 Thread Russell King - ARM Linux admin
On Wed, May 15, 2019 at 09:09:26AM -0700, Florian Fainelli wrote: > Vladimir mentioned a few weeks ago that he is considering adding support > for PHYLIB and PHYLINK to run without a net_device instance, you two > should probably coordinate with each other and make sure both of your > requirements

Re: [PATCH net-next] net: stmmac: socfpga: add RMII phy mode

2019-05-15 Thread Florian Fainelli
On 5/15/19 8:24 AM, Andrew Lunn wrote: >> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c >> @@ -251,6 +251,9 @@ static int socfpga_dwmac_set_phy_mode(struct >> socfpga_dwmac *dwmac) >> case PHY_INTERFACE_MODE_SGMII: >>

Re: [PATCH net-next] net: stmmac: socfpga: add RMII phy mode

2019-05-15 Thread Florian Fainelli
On 5/15/19 7:46 AM, Dinh Nguyen wrote: > Add option for enabling RMII phy mode. > > Signed-off-by: Wei Liang Lim > Signed-off-by: Dinh Nguyen Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net 2/3] enetc: Allow to disable Tx SG

2019-05-15 Thread David Miller
From: Claudiu Manoil Date: Wed, 15 May 2019 19:08:57 +0300 > The fact that the Tx SG flag is fixed to 'on' is only > an oversight. Non-SG mode is also supported. Fix this > by allowing to turn SG off. > > Signed-off-by: Claudiu Manoil Applied.

Re: [PATCH net 3/3] enetc: Add missing link state info for ethtool

2019-05-15 Thread David Miller
From: Claudiu Manoil Date: Wed, 15 May 2019 19:08:58 +0300 > Just hook get_link to standard ethtool_op_get_link, > nothing special needed at this point. > > Signed-off-by: Claudiu Manoil Applied.

Re: [PATCH net 1/3] enetc: Fix NULL dma address unmap for Tx BD extensions

2019-05-15 Thread David Miller
From: Claudiu Manoil Date: Wed, 15 May 2019 19:08:56 +0300 > For the unlikely case of TxBD extensions (i.e. ptp) > the driver tries to unmap the tx_swbd corresponding > to the extension, which is bogus as it has no buffer > attached. > > Signed-off-by: Claudiu Manoil Applied.

Re: dsa: using multi-gbps speeds on CPU port

2019-05-15 Thread Russell King - ARM Linux admin
On Wed, May 15, 2019 at 03:27:01PM +0200, Andrew Lunn wrote: > On the master interface, the armada 8040, eth0, you still need > something. However, if you look at phylink_parse_fixedlink(), it puts > the speed etc into a phylink_link_state. It never instantiates a > fixed-phy. So i think that could

[PATCH net] tcp: do not recycle cloned skbs

2019-05-15 Thread Eric Dumazet
It is illegal to change arbitrary fields in skb_shared_info if the skb is cloned. Before calling skb_zcopy_clear() we need to ensure this rule, therefore we need to move the test from sk_stream_alloc_skb() to sk_wmem_free_skb() Fixes: 4f661542a402 ("tcp: fix zerocopy and notsent_lowat issues") Si

Re: dsa: using multi-gbps speeds on CPU port

2019-05-15 Thread Florian Fainelli
On 5/15/19 7:02 AM, Maxime Chevallier wrote: > Hi Andrew, > > On Wed, 15 May 2019 15:27:01 +0200 > Andrew Lunn wrote: > >> I think you are getting your terminology wrong. 'master' is eth0 in >> the example you gave above. CPU and DSA ports don't have netdev >> structures, and so any PHY used wit

[PATCH net 2/3] enetc: Allow to disable Tx SG

2019-05-15 Thread Claudiu Manoil
The fact that the Tx SG flag is fixed to 'on' is only an oversight. Non-SG mode is also supported. Fix this by allowing to turn SG off. Signed-off-by: Claudiu Manoil --- drivers/net/ethernet/freescale/enetc/enetc_pf.c | 2 +- drivers/net/ethernet/freescale/enetc/enetc_vf.c | 2 +- 2 files change

[PATCH net 3/3] enetc: Add missing link state info for ethtool

2019-05-15 Thread Claudiu Manoil
Just hook get_link to standard ethtool_op_get_link, nothing special needed at this point. Signed-off-by: Claudiu Manoil --- drivers/net/ethernet/freescale/enetc/enetc_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c b/drivers/n

[PATCH net 1/3] enetc: Fix NULL dma address unmap for Tx BD extensions

2019-05-15 Thread Claudiu Manoil
For the unlikely case of TxBD extensions (i.e. ptp) the driver tries to unmap the tx_swbd corresponding to the extension, which is bogus as it has no buffer attached. Signed-off-by: Claudiu Manoil --- drivers/net/ethernet/freescale/enetc/enetc.c | 4 +++- 1 file changed, 3 insertions(+), 1 delet

Re: [PATCH 1/1] net: usb: qmi_wwan: add Telit 0x1260 and 0x1261 compositions

2019-05-15 Thread Bjørn Mork
Daniele Palmas writes: > Added support for Telit LE910Cx 0x1260 and 0x1261 compositions. Thanks. Acked-by: Bjørn Mork

Re: [PATCH net] ipv6: fix src addr routing with the exception table

2019-05-15 Thread David Ahern
On 5/14/19 6:46 PM, Wei Wang wrote: > From: Wei Wang > > When inserting route cache into the exception table, the key is > generated with both src_addr and dest_addr with src addr routing. > However, current logic always assumes the src_addr used to generate the > key is a /128 host address. This

Re: IPv6 PMTU discovery fails with source-specific routing

2019-05-15 Thread David Ahern
On 5/14/19 1:33 PM, Wei Wang wrote: > I think the bug is because when creating exceptions, src_addr is not > always set even though fib6_info is in the subtree. (because of > rt6_is_gw_or_nonexthop() check) > However, when looking up for exceptions, we always set src_addr to the > passed in flow->s

Re: [PATCH -next] 9p/xen: Add cleanup path in p9_trans_xen_init

2019-05-15 Thread Dominique Martinet
YueHaibing wrote on Tue, Apr 30, 2019: > If xenbus_register_frontend() fails in p9_trans_xen_init, > we should call v9fs_unregister_trans() to do cleanup. > > Fixes: 868eb122739a ("xen/9pfs: introduce Xen 9pfs transport driver") > Signed-off-by: YueHaibing Thanks, queued both in my repo - sorry

Re: [PATCH] net: sh_eth: fix mdio access in sh_eth_close() for some SoCs

2019-05-15 Thread Sergei Shtylyov
Hello! It's not "some SoCs", it's only R-Car gen2 and RZ/G1 SoCs. On 05/15/2019 08:36 AM, Yoshihiro Shimoda wrote: > The sh_eth_close() resets the MAC and then calls phy_stop() > so that mdio read access result is incorrect without any error > according to kernel trace like below: > > ifconf

Re: CFP: 4th RDMA Mini-Summit at LPC 2019

2019-05-15 Thread Yuval Shaia
On Tue, May 14, 2019 at 03:23:21PM +0300, Leon Romanovsky wrote: > This is a call for proposals for the 4th RDMA mini-summit at the Linux > Plumbers Conference in Lisbon, Portugal, which will be happening on > September 9-11h, 2019. > > We are looking for topics with focus on active audience discu

[PATCH 1/1] net: usb: qmi_wwan: add Telit 0x1260 and 0x1261 compositions

2019-05-15 Thread Daniele Palmas
Added support for Telit LE910Cx 0x1260 and 0x1261 compositions. Signed-off-by: Daniele Palmas --- lsusb output for the compositions: Bus 003 Device 004: ID 1bc7:1260 Telit Wireless Solutions Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.00

Re: [PATCH net-next] net: stmmac: socfpga: add RMII phy mode

2019-05-15 Thread Andrew Lunn
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > @@ -251,6 +251,9 @@ static int socfpga_dwmac_set_phy_mode(struct > socfpga_dwmac *dwmac) > case PHY_INTERFACE_MODE_SGMII: > val = SYSMGR_EMACGRP_CTRL_PHYSEL

Re: [RFC 1/2] netvsc: invoke xdp_generic from VF frame handler

2019-05-15 Thread Stephen Hemminger
On Wed, 15 May 2019 16:12:42 +0800 Jason Wang wrote: > On 2019/5/15 下午4:03, Stephen Hemminger wrote: > > XDP generic does not work correctly with the Hyper-V/Azure netvsc > > device because of packet processing order. Only packets on the > > synthetic path get seen by the XDP program. The VF devi

RFC: Fixing SK_REUSEPORT from sk_lookup_* helpers

2019-05-15 Thread Lorenz Bauer
In the BPF-based TPROXY session with Joe Stringer [1], I mentioned that the sk_lookup_* helpers currently return inconsistent results if SK_REUSEPORT programs are in play. SK_REUSEPORT programs are a hook point in inet_lookup. They get access to the full packet that triggered the look up. To suppo

[PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

2019-05-15 Thread Madalin-cristian Bucur
XGMII interface mode no longer works on AQR107 after the recent changes, adding back support. Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface modes in config_init") Signed-off-by: Madalin Bucur --- drivers/net/phy/aquantia_main.c | 1 + 1 file changed, 1 insertion(+) d

[PATCH net-next] net: stmmac: socfpga: add RMII phy mode

2019-05-15 Thread Dinh Nguyen
Add option for enabling RMII phy mode. Signed-off-by: Wei Liang Lim Signed-off-by: Dinh Nguyen --- drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmma

Re: [PATCH 2/3] aqc111: fix writing to the phy on BE

2019-05-15 Thread Igor Russkikh
>>> - aqc111_write32_cmd(dev, AQ_PHY_OPS, 0, 0, &aqc111_data->phy_cfg); >>> + phy_on_the_wire = aqc111_data->phy_cfg; >>> + aqc111_write32_cmd(dev, AQ_PHY_OPS, 0, 0, &phy_on_the_wire); >> >> Hi Oliver, >> >> I see all write32_cmd and write16_cmd are using a temporary variable to do an >> int

Re: [PATCH net-next] sctp: remove unused cmd SCTP_CMD_GEN_INIT_ACK

2019-05-15 Thread Neil Horman
On Sun, May 12, 2019 at 01:52:48PM +0800, Xin Long wrote: > On Fri, May 10, 2019 at 7:27 PM Neil Horman wrote: > > > > On Thu, May 09, 2019 at 09:39:13AM -0700, David Miller wrote: > > > From: Neil Horman > > > Date: Thu, 9 May 2019 07:32:35 -0400 > > > > > > > This is definately a valid cleanup,

Re: dsa: using multi-gbps speeds on CPU port

2019-05-15 Thread Maxime Chevallier
Hi Andrew, On Wed, 15 May 2019 15:27:01 +0200 Andrew Lunn wrote: >I think you are getting your terminology wrong. 'master' is eth0 in >the example you gave above. CPU and DSA ports don't have netdev >structures, and so any PHY used with them is not corrected to a >netdev. Ah yes sorry, I'm stil

RE: [PATCH] arm64: do_csum: implement accelerated scalar version

2019-05-15 Thread David Laight
From: Robin Murphy > Sent: 15 May 2019 13:40 > On 15/05/2019 12:13, David Laight wrote: > > From: Robin Murphy > >> Sent: 15 May 2019 11:58 > >> To: David Laight; 'Will Deacon' > >> Cc: Zhangshaokun; Ard Biesheuvel; linux-arm-ker...@lists.infradead.org; > >> netdev@vger.kernel.org; > >> ilias.apal

[PATCH bpf v1 2/3] selftests/bpf: Print a message when tester could not run a program

2019-05-15 Thread Krzesimir Nowak
This prints a message when the error is about program type being not supported by the test runner or because of permissions problem. This is to see if the program we expected to run was actually executed. The messages are open-coded because strerror(ENOTSUPP) returns "Unknown error 524". Signed-o

[PATCH bpf v1 3/3] selftests/bpf: Avoid a clobbering of errno

2019-05-15 Thread Krzesimir Nowak
Save errno right after bpf_prog_test_run returns, so we later check the error code actually set by bpf_prog_test_run, not by some libcap function. Cc: Jakub Kicinski Fixes: 5a8d5209ac022 ("selftests: bpf: add trivial JSET tests") Signed-off-by: Krzesimir Nowak --- tools/testing/selftests/bpf/te

[PATCH bpf v1 1/3] selftests/bpf: Test correctness of narrow 32bit read on 64bit field

2019-05-15 Thread Krzesimir Nowak
Test the correctness of the 32bit narrow reads by reading both halves of the 64 bit field and doing a binary or on them to see if we get the original value. This isn't really tested - the program is not being run, because BPF_PROG_TYPE_PERF_EVENT is not supported by bpf_test_run_prog. Signed-off-

[PATCH bpf v1 0/3] Test the 32bit narrow reads

2019-05-15 Thread Krzesimir Nowak
These patches try to test the fix made in commit e2f7fc0ac695 ("bpf: fix undefined behavior in narrow load handling"). The problem existed in the generated BPF bytecode that was doing a 32bit narrow read of a 64bit field, so to test it the code would need to be executed. Currently the only such fie

Re: dsa: using multi-gbps speeds on CPU port

2019-05-15 Thread Andrew Lunn
On Wed, May 15, 2019 at 02:39:36PM +0200, Maxime Chevallier wrote: > Hello everyone, > > I'm working on a setup where I have a 88e6390X DSA switch connected to > a CPU (an armada 8040) with 2500BaseX and RXAUI interfaces (we only use > one at a time). Hi Maxime RXAUI should just work. By default

  1   2   >