RE: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-20 Thread liweihang
> -Original Message- > From: Heiner Kallweit [mailto:hkallwe...@gmail.com] > Sent: Thursday, March 21, 2019 2:15 AM > To: liweihang ; Florian Fainelli > ; Phil Reid ; > netdev@vger.kernel.org > Cc: Andrew Lunn ; David S. Miller > ; dongsheng.w...@hxt-semitech.com; > cphe...@gmail.com; cle

[Patch net v2 2/3] bluetooth: validate HCI_EV_LE_META packet carefully

2019-03-20 Thread Cong Wang
Similarly, we need to check skb->data boundary for HCI_EV_LE_META event too. Note, hci_le_adv_report_evt() and hci_le_ext_adv_report_evt() are slightly complicated, as they read the length of the field from the packet too. Cc: Marcel Holtmann Cc: Johan Hedberg Signed-off-by: Cong Wang --- net

[Patch net v2 0/3] bluetooth: validate packet boundary carefully

2019-03-20 Thread Cong Wang
This patchset fixes the out-of-bound access in bluetooth stack. Although it is large, all of them follow the same pattern, so it should not be hard to review. I try to group them as much as I can. Please check each patch for details. Cong Wang (3): bluetooth: validate HCI_EVENT_PKT packet caref

[Patch net v2 3/3] bluetooth: validate HCI_EV_CMD_COMPLETE packet carefully

2019-03-20 Thread Cong Wang
Similarly, we need to check skb->data boundary for HCI_EV_CMD_COMPLETE event too. Cc: Marcel Holtmann Cc: Johan Hedberg Signed-off-by: Cong Wang --- net/bluetooth/hci_event.c | 258 +++--- 1 file changed, 215 insertions(+), 43 deletions(-) diff --git a/net/blue

[Patch net v2 1/3] bluetooth: validate HCI_EVENT_PKT packet carefully

2019-03-20 Thread Cong Wang
hci_event_packet() blindly assumes all packets are sane, at least for packets allocated via vhci_get_user() path this is not true. We have to check if we access skb data out-of-bound with pskb_may_pull() before each skb->data dereference on RX path. Reported-and-tested-by: syzbot+cec7a50c412a2c03f

Re: [PATCH v2 4/8] bpf: add helper to check for a valid SYN cookie

2019-03-20 Thread Alexei Starovoitov
On Wed, Mar 20, 2019 at 9:53 PM Lorenz Bauer wrote: > > > > So please resubmit as-is. > > It doesn't apply cleanly yet. > > Sorry about this. It requires Martin KaFai Lau's fix for the > bpf_tcp_sock reference > tracking, since it depends on sk_release on PTR_TO_SOCK_COMMON. How do I fix > this fo

Re: [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection

2019-03-20 Thread Sergey Senozhatsky
On (03/20/19 20:24), Alexei Starovoitov wrote: > On Wed, Mar 20, 2019 at 09:53:33PM +0900, Sergey Senozhatsky wrote: > > Not all compilers have __builtin_bswap16() and __builtin_bswap32(), > > thus not all compilers are able to compile the following code: > > > > (__builtin_constant_p(x) ?

RE: [PATCH net-next 0/2] qed* enhancements.

2019-03-20 Thread Sudarsana Reddy Kalluru
> -Original Message- > From: David Miller > Sent: Wednesday, March 20, 2019 11:44 PM > To: Sudarsana Reddy Kalluru > Cc: netdev@vger.kernel.org; Ariel Elior ; Michal > Kalderon > Subject: Re: [PATCH net-next 0/2] qed* enhancements. > > From: Sudarsana Reddy Kalluru > Date: Wed, 20 Ma

Re: [PATCH v2 4/8] bpf: add helper to check for a valid SYN cookie

2019-03-20 Thread Lorenz Bauer
On Thu, 21 Mar 2019 at 03:03, Alexei Starovoitov wrote: > > On Thu, Mar 21, 2019 at 02:09:08AM +, Lorenz Bauer wrote: > > On Tue, 19 Mar 2019 at 22:17, Alexei Starovoitov > > wrote: > > > > > > On Tue, Mar 19, 2019 at 10:20:59AM +, Lorenz Bauer wrote: > > > > Using bpf_skc_lookup_tcp it's

Re: [BUG] BPF splat on latest kernels

2019-03-20 Thread Eric Dumazet
On 03/08/2019 04:29 PM, Alexei Starovoitov wrote: > On Fri, Mar 8, 2019 at 12:33 PM Eric Dumazet wrote: >> >> Running test_progs on a LOCKDEP enabled kernel (latest David Miller net tree) >> >> I got the following splat. >> >> It is not immediately obvious to me. Any idea ? > > I think I saw s

Re: [RFC bpf-next v2 1/9] net: introduce __init_skb{,_data,_shinfo} helpers

2019-03-20 Thread Eric Dumazet
On 03/20/2019 08:39 PM, Alexei Starovoitov wrote: > I think you need to convince Dave and Eric that > above surgery is necessary to do the hack in patch 6 with > +static DEFINE_PER_CPU(struct sk_buff, bpf_flow_skb); > Yes, this is a huge code churn. Honestly I believe we are going too far in

Re: [PATCH net-next] net/tls: Replace kfree_skb() with consume_skb()

2019-03-20 Thread Eric Dumazet
On 03/20/2019 06:51 PM, Vakul Garg wrote: > To free the skb in normal course of processing, consume_skb() should be > used. Only for failure paths, skb_free() is intended to be used. > > https://www.kernel.org/doc/htmldocs/networking/API-consume-skb.html > > Signed-off-by: Vakul Garg > --- .

Re: [PATCH net-next 2/2] openvswitch: Add timeout support to ct action

2019-03-20 Thread Pravin Shelar
On Wed, Mar 20, 2019 at 2:19 PM Yi-Hung Wei wrote: > > Add support for fine-grain timeout support to conntrack action. > The new OVS_CT_ATTR_TIMEOUT attribute of the conntrack action > specifies a timeout to be associated with this connection. > If no timeout is specified, it acts as is, that is t

[PATCH net-next] nfp: remove defines for unused control bits

2019-03-20 Thread Jakub Kicinski
NFP driver ABI contains bits for L2 switching which were never implemented in initially envisioned form. Remove the defines, and open up the possibility of reclaiming the bits for other uses. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/ethernet/netronome/nfp/n

Re: [PATCH net-next v4 0/4] net/mlx5e: Make little improvement for mlx5e

2019-03-20 Thread Saeed Mahameed
On Wed, Mar 20, 2019 at 6:58 PM Tonghao Zhang wrote: > > On Thu, Feb 28, 2019 at 11:03 PM wrote: > > > > Tonghao Zhang (4): > > net/mlx5e: Make the log friendly when decapsulation offload not > > supported > > net/mlx5e: Remove 'parse_attr' argument in parse_tc_fdb_actions() > > net/mlx

Re: [RFC bpf-next v2 1/9] net: introduce __init_skb{,_data,_shinfo} helpers

2019-03-20 Thread Alexei Starovoitov
On Tue, Mar 19, 2019 at 03:19:40PM -0700, Stanislav Fomichev wrote: > __init_skb is essentially a version of __build_skb which accepts skb as > an argument (instead of doing kmem_cache_alloc to allocate it). > > __init_skb_shinfo initializes shinfo. > > __init_skb_data initializes skb data pointe

Re: [PATCH bpf-next] bpf: make bpf_skb_ecn_set_ce callable from BPF_PROG_TYPE_SCHED_ACT

2019-03-20 Thread Alexei Starovoitov
On Wed, Mar 20, 2019 at 12:06:40AM -0700, Peter Oskolkov wrote: > This helper is useful if a bpf tc filter sets skb->tstamp. > > Signed-off-by: Peter Oskolkov > --- > net/core/filter.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/core/filter.c b/net/core/filter.c > index 647c6

Re: [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection

2019-03-20 Thread Alexei Starovoitov
On Wed, Mar 20, 2019 at 09:53:33PM +0900, Sergey Senozhatsky wrote: > Not all compilers have __builtin_bswap16() and __builtin_bswap32(), > thus not all compilers are able to compile the following code: > > (__builtin_constant_p(x) ? \ > ___constant_swab16(x) : __builtin_bs

Re: [PATCH bpf-next 09/13] bpf: add bpf_skb_adjust_room encap flags

2019-03-20 Thread Alexei Starovoitov
On Wed, Mar 20, 2019 at 10:49:40AM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > When pushing tunnel headers, annotate skbs in the same way as tunnel > devices. > > For GSO packets, the network stack requires certain fields set to > segment packets with tunnel headers. gro_gse_segm

Re: [PATCH v2 4/8] bpf: add helper to check for a valid SYN cookie

2019-03-20 Thread Alexei Starovoitov
On Thu, Mar 21, 2019 at 02:09:08AM +, Lorenz Bauer wrote: > On Tue, 19 Mar 2019 at 22:17, Alexei Starovoitov > wrote: > > > > On Tue, Mar 19, 2019 at 10:20:59AM +, Lorenz Bauer wrote: > > > Using bpf_skc_lookup_tcp it's possible to ascertain whether a packet > > > belongs to a known connec

Re: [PATCH v2 4/8] bpf: add helper to check for a valid SYN cookie

2019-03-20 Thread Lorenz Bauer
On Tue, 19 Mar 2019 at 22:17, Alexei Starovoitov wrote: > > On Tue, Mar 19, 2019 at 10:20:59AM +, Lorenz Bauer wrote: > > Using bpf_skc_lookup_tcp it's possible to ascertain whether a packet > > belongs to a known connection. However, there is one corner case: no > > sockets are created if SYN

Re: [PATCH net-next v4 0/4] net/mlx5e: Make little improvement for mlx5e

2019-03-20 Thread Tonghao Zhang
On Thu, Feb 28, 2019 at 11:03 PM wrote: > > From: Tonghao Zhang > > This serial patches are not bugfixes, and just little improvement for mlx5e. > v3->v4: > Patch4: change the long message info and introduce a helper function. > > v2->v3: > Patch 1 and 5 are merged to patch 4 now. > > v1->v2 > Pa

[PATCH net-next] net/tls: Replace kfree_skb() with consume_skb()

2019-03-20 Thread Vakul Garg
To free the skb in normal course of processing, consume_skb() should be used. Only for failure paths, skb_free() is intended to be used. https://www.kernel.org/doc/htmldocs/networking/API-consume-skb.html Signed-off-by: Vakul Garg --- net/tls/tls_sw.c | 8 1 file changed, 4 insertions(

Re: [PATCH bpf] libbpf: Check if map names are not NULL

2019-03-20 Thread Alexei Starovoitov
On Wed, Mar 20, 2019 at 01:27:42PM +0100, Michal Rostecki wrote: > BPF maps do not have to be named, so map names can be NULL. Map name > pointers should be checked before doing any operations which cannot be > done on NULL pointers. > > This issue was detected by the following errors coming from

Re: [PATCH bpf] bpf: Only print ref_obj_id for refcounted reg

2019-03-20 Thread Alexei Starovoitov
On Mon, Mar 18, 2019 at 10:37:13AM -0700, Martin KaFai Lau wrote: > Naresh reported that test_align fails because of the mismatch at the > verbose printout of the register states. The reason is due to the newly > added ref_obj_id. > > ref_obj_id is only useful for refcounted reg. Thus, this patc

Re: [PATCH v3 bpf-next 1/3] BPF: helpers: New helper to obtain namespace data from current task

2019-03-20 Thread Alexei Starovoitov
On Wed, Mar 20, 2019 at 01:49:22PM -0300, Carlos Antonio Neira Bustos wrote: > > This is a series of patches to introduce a new helper called > bpf_get_current_pidns_info, > this change has been splitted into the following patches: > > 1- Feature introduction > 2- Update tools/.../bpf.h > 3- Sel

Re: [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection

2019-03-20 Thread Sergey Senozhatsky
On (03/20/19 15:27), Stanislav Fomichev wrote: [..] > > Inside kernel clang compiler header (linux/compiler-clang.h) does not > > define __HAVE_BUILTIN_BSWAP16__. So it will go to the "else" branch in > > the above. So I think it should work with clang + bpf. > Hm, isn't it the opposite of what w

Re: [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection

2019-03-20 Thread Yonghong Song
On 3/20/19 5:03 PM, Stanislav Fomichev wrote: > On 03/21, Daniel Borkmann wrote: >> On 03/20/2019 11:45 PM, Yonghong Song wrote: >>> On 3/20/19 3:27 PM, Stanislav Fomichev wrote: On 03/20, Yonghong Song wrote: > On 3/20/19 10:13 AM, Stanislav Fomichev wrote: >> On 03/20, Sergey Senoz

Re: [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection

2019-03-20 Thread Sergey Senozhatsky
On (03/20/19 10:13), Stanislav Fomichev wrote: > Tested them locally with the compiler I saw the initial issues with - all > fine, I don't see any errors with the older gcc. Thanks! > One last question I have is: what happens in the llvm+bpf case? Have > you tested that? I think LLVM has all the

Re: [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection

2019-03-20 Thread Stanislav Fomichev
On 03/21, Daniel Borkmann wrote: > On 03/20/2019 11:45 PM, Yonghong Song wrote: > > On 3/20/19 3:27 PM, Stanislav Fomichev wrote: > >> On 03/20, Yonghong Song wrote: > >>> On 3/20/19 10:13 AM, Stanislav Fomichev wrote: > On 03/20, Sergey Senozhatsky wrote: > > Not all compilers have __buil

Re: [PATCH bpf-next v3] tools/bpf: generate pkg-config file for libbpf

2019-03-20 Thread Andrey Ignatov
luca.bocca...@gmail.com [Wed, 2019-03-20 06:28 -0700]: > From: Luca Boccassi > > Generate a libbpf.pc file at build time so that users can rely > on pkg-config to find the library, its CFLAGS and LDFLAGS. > > Signed-off-by: Luca Boccassi > --- > v2: use QUIET_GEN instead of QUIET_LINK to gener

Re: [net-next 12/15] net: Add IANA_VXLAN_UDP_PORT definition to vxlan header file

2019-03-20 Thread Jakub Kicinski
On Wed, 20 Mar 2019 16:39:56 -0700, Saeed Mahameed wrote: > diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.h > b/drivers/net/ethernet/netronome/nfp/flower/main.h > index 7afe66eff684..f214759d485b 100644 > --- a/drivers/net/ethernet/netronome/nfp/flower/main.h > +++ b/drivers/net/ethe

Re: [net-next 09/15] net: Move the definition of the default Geneve udp port to public header file

2019-03-20 Thread Jakub Kicinski
On Wed, 20 Mar 2019 16:39:53 -0700, Saeed Mahameed wrote: > From: Moshe Shemesh > > Move the definition of the default Geneve udp port from the geneve > source to the header file, so we can re-use it from drivers. > Modify existing drivers to use it. > > Signed-off-by: Moshe Shemesh > Reviewed-

[net-next 08/15] net/mlx5: E-Switch, Protect from invalid memory access in offload fdb table

2019-03-20 Thread Saeed Mahameed
From: Roi Dayan The esw offloads structures share a union with the legacy mode structs. Reset the offloads struct to zero in init to protect from null assumptions made by the legacy mode code. Signed-off-by: Roi Dayan Reviewed-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethe

[net-next 14/15] net/mlx5e: Support VLAN modify action

2019-03-20 Thread Saeed Mahameed
From: Eli Britstein Support VLAN modify action by emulating a rewrite action for the VLAN fields. Currently, the only supported field is the vid. The prio in the action must be set to 0 to indicate no change. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --

[net-next 06/15] net/mlx5e: Fix compilation warning in en_tc.c

2019-03-20 Thread Saeed Mahameed
Amazingly a mlx5e_tc function is being called from the eswitch layer, which is by itself very terrible! The function was declared locally in eswitch_offloads.c so it could be used there, which caused the following compilation warning, fix that. drivers/.../mlx5/core/en_tc.c:3242:6: [-Werror=missin

[net-next 10/15] net/mlx5e: Take SW parser code to a separate function

2019-03-20 Thread Saeed Mahameed
From: Moshe Shemesh Refactor mlx5e_ipsec_set_swp() code, split the part which sets the eseg software parser (SWP) offsets and flags, so it can be used in a downstream patch by other mlx5e functionality which needs to set eseg SWP. The new function mlx5e_set_eseg_swp() is useful for setting swp fo

[net-next 15/15] net/mlx5e: Replace TC VLAN pop and push actions with VLAN modify

2019-03-20 Thread Saeed Mahameed
From: Eli Britstein Changing the VLAN header may be implemented by pop the existing header and push a new one. Translate those operations as VLAN modify. Applicable for use cases such as OVS where the controller translates a vlan modify meta (OF) rule to DP pop+push actions rule. Signed-off-by:

[net-next 05/15] net/mlx5e: Fix port buffer function documentation format

2019-03-20 Thread Saeed Mahameed
This patch fixes compiler warnings: In drivers/.../mlx5/core/en/port_buffer.c:190: warning: Function parameter or member 'pfc_en' not described... ... warning: Function parameter or member 'change' not described... Fixes: 0696d60853d5 ("net/mlx5e: Receive buffer configuration") Signed-off-by: Saee

[net-next 01/15] net/mlx5: Simplify sriov enable/disable flow

2019-03-20 Thread Saeed Mahameed
From: Parav Pandit Simplify sriov enable/disable flow for below two checks. 1. PCI core driver allows sriov configuration only on a PF. This is done in drivers/pci/pci-sysfs.c sriov_attrs_are_visible(). 2. PCI core driver allow sriov enablement if the sriov is currently disabled for for a PF. T

[net-next 13/15] net/mlx5e: Add VLAN ID rewrite fields

2019-03-20 Thread Saeed Mahameed
From: Eli Britstein Add VLAN ID rewrite fields as a pre-step to support this rewrite. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 ++ include/linux/mlx5/mlx5_ifc.h | 1 + 2 files c

[net-next 02/15] net/mlx5: Rename total_vfs to total_vports

2019-03-20 Thread Saeed Mahameed
From: Parav Pandit Macro MLX5_TOTAL_VPORTS() returns total number of vports. Therefore, rename variable total_vfs to total_vports to improve code readability. Signed-off-by: Parav Pandit Reviewed-by: Bodong Wang Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/eswitc

[net-next 09/15] net: Move the definition of the default Geneve udp port to public header file

2019-03-20 Thread Saeed Mahameed
From: Moshe Shemesh Move the definition of the default Geneve udp port from the geneve source to the header file, so we can re-use it from drivers. Modify existing drivers to use it. Signed-off-by: Moshe Shemesh Reviewed-by: Or Gerlitz Cc: John Hurley Cc: Jakub Kicinski Reviewed-by: Tariq To

[net-next 12/15] net: Add IANA_VXLAN_UDP_PORT definition to vxlan header file

2019-03-20 Thread Saeed Mahameed
From: Moshe Shemesh Added IANA_VXLAN_UDP_PORT (4789) definition to vxlan header file so it can be used by drivers instead of local definition. Updated drivers which locally defined it as 4789 to use it. Signed-off-by: Moshe Shemesh Reviewed-by: Or Gerlitz Cc: John Hurley Cc: Jakub Kicinski C

[net-next 03/15] net/mlx5: Simplify mlx5_sriov_is_enabled() by using pci core API

2019-03-20 Thread Saeed Mahameed
From: Parav Pandit It is desired to get rid of num_vfs stored inside mlx5_core_sriov to safely support vports more than vfs. To reduce dependency on mlx5_core_sriov num_vfs, start using pci_num_vf() from pci core. Signed-off-by: Parav Pandit Reviewed-by: Bodong Wang Signed-off-by: Saeed Mahame

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-20 Thread Parav Pandit
> -Original Message- > From: Jakub Kicinski > Sent: Wednesday, March 20, 2019 3:23 PM > To: Parav Pandit > Cc: Jiri Pirko ; Samudrala, Sridhar > ; da...@davemloft.net; > netdev@vger.kernel.org; oss-driv...@netronome.com > Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on

[net-next 11/15] net/mlx5e: TX, Add geneve tunnel stateless offload support

2019-03-20 Thread Saeed Mahameed
From: Moshe Shemesh Currently support only default geneve udp port (6081). For the tx side, the HW is assisted by SW parsing, which sets the headers offset to offload tunneled LSO and csum. Note that for udp tunnels, we don't use special rx offloads, as rss on the outer headers is enough, we supp

[net-next 07/15] net/mlx5e: Remove redundant assignment

2019-03-20 Thread Saeed Mahameed
From: "Gustavo A. R. Silva" Remove redundant assignment to tun_entropy->enabled. Addesses-Coverity-ID: 1477328 ("Unused value") Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tunnel entropy calculation") Signed-off-by: Gustavo A. R. Silva Reviewed-by: Roi Dayan Reviewed-by:

[pull request][net-next 00/15] Mellanox, mlx5 updates 2019-03-20

2019-03-20 Thread Saeed Mahameed
Hi Dave, This series includes mlx5 updates. For more information please see tag log below. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit a534ea30e70fc51c4cef31c0683955dd8a568a11: net: isdn: Make isdn_ppp_mp_discard and isdn_ppp_mp_

[net-next 04/15] net/mlx5: Fix compilation warning in eq.c

2019-03-20 Thread Saeed Mahameed
mlx5_eq_table_get_rmap is being used only when CONFIG_RFS_ACCEL is enabled, this patch fixes the below warning when CONFIG_RFS_ACCEL is disabled. drivers/.../mlx5/core/eq.c:903:18: [-Werror=missing-prototypes] error: no previous prototype for ‘mlx5_eq_table_get_rmap’ Fixes: f2f3df550139 ("net/mlx

Re: [PATCH bpf-next 0/2] bpf: remove incorrect 'verifier bug' warning

2019-03-20 Thread Yonghong Song
On 3/20/19 5:57 AM, Paul Chaignon wrote: > The BPF verifier checks the maximum number of call stack frames twice, > first in the main CFG traversal (do_check) and then in a subsequent > traversal (check_max_stack_depth). If the second check fails, it logs a > 'verifier bug' warning and errors ou

Re: [PATCH net-next] ipv6: Add icmp_echo_ignore_anycast for ICMPv6

2019-03-20 Thread David Miller
From: Stephen Suryaputra Date: Wed, 20 Mar 2019 10:29:27 -0400 > In addition to icmp_echo_ignore_multicast, there is a need to also > prevent responding to pings to anycast addresses for security. > > Signed-off-by: Stephen Suryaputra Applied, thank you.

Re: [PATCH net] dpaa2-eth: Fix possible access beyond end of array

2019-03-20 Thread David Miller
From: Ioana Ciocoi Radulescu Date: Wed, 20 Mar 2019 14:11:04 + > Make sure we don't try to enqueue XDP_REDIRECT frames to an > inexistent FQ. > > While it is guaranteed not to have more than one queue per core, > having fewer queues than CPUs on an interface is a valid > configuration. > >

Re: [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection

2019-03-20 Thread Daniel Borkmann
On 03/20/2019 11:45 PM, Yonghong Song wrote: > On 3/20/19 3:27 PM, Stanislav Fomichev wrote: >> On 03/20, Yonghong Song wrote: >>> On 3/20/19 10:13 AM, Stanislav Fomichev wrote: On 03/20, Sergey Senozhatsky wrote: > Not all compilers have __builtin_bswap16() and __builtin_bswap32(), >

Re: [PATCH net-next] net: dst: remove gc leftovers

2019-03-20 Thread Wei Wang
On Wed, Mar 20, 2019 at 12:03 PM Julian Wiedmann wrote: > > Get rid of some obsolete gc-related documentation and macros that were > missed in commit 5b7c9a8ff828 ("net: remove dst gc related code"). > > CC: Wei Wang > Signed-off-by: Julian Wiedmann > --- Acked-by: Wei Wang > > one more time,

Re: [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection

2019-03-20 Thread Yonghong Song
On 3/20/19 3:27 PM, Stanislav Fomichev wrote: > On 03/20, Yonghong Song wrote: >> >> >> On 3/20/19 10:13 AM, Stanislav Fomichev wrote: >>> On 03/20, Sergey Senozhatsky wrote: Not all compilers have __builtin_bswap16() and __builtin_bswap32(), thus not all compilers are able to compile t

Re: [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection

2019-03-20 Thread Stanislav Fomichev
On 03/20, Yonghong Song wrote: > > > On 3/20/19 10:13 AM, Stanislav Fomichev wrote: > > On 03/20, Sergey Senozhatsky wrote: > >> Not all compilers have __builtin_bswap16() and __builtin_bswap32(), > >> thus not all compilers are able to compile the following code: > >> > >> (__builtin_co

Re: [PATCHv2 bpf-next 1/3] bpf, tests: tweak endianness selection

2019-03-20 Thread Yonghong Song
On 3/20/19 10:13 AM, Stanislav Fomichev wrote: > On 03/20, Sergey Senozhatsky wrote: >> Not all compilers have __builtin_bswap16() and __builtin_bswap32(), >> thus not all compilers are able to compile the following code: >> >> (__builtin_constant_p(x) ? \ >> ___constant

Re: [PATCH v3 3/3] net: dsa: qca8k: extend slave-bus implementations

2019-03-20 Thread Florian Fainelli
On 3/20/19 3:02 PM, Christian Lamparter wrote: > Sorry. I hit Sent by accident and then I had to run... > This is the full response. > > On Wednesday, March 20, 2019 7:27:09 PM CET Florian Fainelli wrote: >> On 3/19/19 12:54 PM, Christian Lamparter wrote: >>> This patch implements accessors for th

Re: [PATCH v3 3/3] net: dsa: qca8k: extend slave-bus implementations

2019-03-20 Thread Christian Lamparter
Sorry. I hit Sent by accident and then I had to run... This is the full response. On Wednesday, March 20, 2019 7:27:09 PM CET Florian Fainelli wrote: > On 3/19/19 12:54 PM, Christian Lamparter wrote: > > This patch implements accessors for the QCA8337 MDIO access > > through the MDIO_MASTER regist

Re: [PATCH net-next] net: phy: aquantia: add downshift support

2019-03-20 Thread Florian Fainelli
On 3/20/19 2:15 PM, Heiner Kallweit wrote: > Aquantia PHY's of the AQR107 family support the downshift feature. > Add support for it as standard PHY tunable so that it can be controlled > via ethtool. > The AQCS109 supports a proprietary 2-pair 1Gbps mode. If two such PHY's > are connected to each

[PATCH net-next 1/2] netfilter: Export nf_ct_destroy_timeout()

2019-03-20 Thread Yi-Hung Wei
This patch moves xt_ct_destroy_timeout from xt_CT.c to nf_conntrack_timeout.c, renames it to nf_ct_destroy_timeout(), and exports it. It does not contain any functional change. It would be useful for other users (i.e. OVS) that utilizes the finer-grain conntrack timeout feature. CC: Pablo Neira A

[PATCH net-next 2/2] openvswitch: Add timeout support to ct action

2019-03-20 Thread Yi-Hung Wei
Add support for fine-grain timeout support to conntrack action. The new OVS_CT_ATTR_TIMEOUT attribute of the conntrack action specifies a timeout to be associated with this connection. If no timeout is specified, it acts as is, that is the default timeout for the connection will be automatically ap

[PATCH net-next] net: phy: aquantia: add downshift support

2019-03-20 Thread Heiner Kallweit
Aquantia PHY's of the AQR107 family support the downshift feature. Add support for it as standard PHY tunable so that it can be controlled via ethtool. The AQCS109 supports a proprietary 2-pair 1Gbps mode. If two such PHY's are connected to each other with a 2-pair cable, they may not be able to es

Re: [PATCH bpf-next v2] tools/bpf: generate pkg-config file for libbpf

2019-03-20 Thread Stanislav Fomichev
On 03/20, Daniel Borkmann wrote: > On 03/20/2019 09:44 PM, Stanislav Fomichev wrote: > > On 03/20, Luca Boccassi wrote: > >> On Wed, 2019-03-20 at 10:21 -0700, Stanislav Fomichev wrote: > >>> On 03/20, Luca Boccassi wrote: > On Wed, 2019-03-20 at 13:22 +, Luca Boccassi wrote: > > On Tu

Re: [ipsec/xfrm] IPv6 fragmentation/path-mtu

2019-03-20 Thread Bram Yvahk
> > What I would've expected to happen is that 'Gateway A' would send out > two fragmented IPv6 packets containing the encrypted data. 'Gateway A' > is the originator of the IPv6 ESP packet so it can fragment these. > This similar to how it's done for IPv4. When the ESP is fragmented > then the IPv

Re: [PATCH bpf-next v2] tools/bpf: generate pkg-config file for libbpf

2019-03-20 Thread Daniel Borkmann
On 03/20/2019 09:44 PM, Stanislav Fomichev wrote: > On 03/20, Luca Boccassi wrote: >> On Wed, 2019-03-20 at 10:21 -0700, Stanislav Fomichev wrote: >>> On 03/20, Luca Boccassi wrote: On Wed, 2019-03-20 at 13:22 +, Luca Boccassi wrote: > On Tue, 2019-03-19 at 16:17 -0700, Stanislav Fomic

Re: [PATCH bpf-next v2] tools/bpf: generate pkg-config file for libbpf

2019-03-20 Thread Stanislav Fomichev
On 03/20, Luca Boccassi wrote: > On Wed, 2019-03-20 at 10:21 -0700, Stanislav Fomichev wrote: > > On 03/20, Luca Boccassi wrote: > > > On Wed, 2019-03-20 at 13:22 +, Luca Boccassi wrote: > > > > On Tue, 2019-03-19 at 16:17 -0700, Stanislav Fomichev wrote: > > > > > On 03/19, Luca Boccassi wrote

Re: [PATCH bpf-next v2] tools/bpf: generate pkg-config file for libbpf

2019-03-20 Thread Luca Boccassi
On Wed, 2019-03-20 at 10:21 -0700, Stanislav Fomichev wrote: > On 03/20, Luca Boccassi wrote: > > On Wed, 2019-03-20 at 13:22 +, Luca Boccassi wrote: > > > On Tue, 2019-03-19 at 16:17 -0700, Stanislav Fomichev wrote: > > > > On 03/19, Luca Boccassi wrote: > > > > > Generate a libbpf.pc file at

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-20 Thread Maxim Uvarov
also it's suspicions that in m88e1116r_config_init() delay is present after first soft_reset() and missed after second. Maxim. ср, 20 мар. 2019 г. в 21:17, Heiner Kallweit : > > On 20.03.2019 13:22, liweihang wrote: > > > > > >> -Original Message- > >> From: Florian Fainelli [mailto:f.fai

Re: [PATCH net-next v2 0/7] devlink: expose PF and VF representors as ports

2019-03-20 Thread Jakub Kicinski
On Fri, 1 Mar 2019 10:04:46 -0800, Jakub Kicinski wrote: > Hi! > > This series is a long overdue follow up to Jiri's work on providing > a common .ndo_phys_port_name implementation based on devlink ports. Hi Jiri, unfortunately I need to focus on some urgent work, so I won't have time to work o

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-20 Thread Jakub Kicinski
On Wed, 20 Mar 2019 18:24:15 +, Parav Pandit wrote: > Hi Jiri, Jakub, Samudrala Sridhar, > > > > > > And physical port in include/uapi/linux/devlink.h also describe > > > > > > that. > > > > > > > > > > By "that" you must mean that the physical is a user facing port. > > > > > > > > Can you

Re: [RFC bpf-next v2 7/9] bpf: when doing BPF_PROG_TEST_RUN for flow dissector use no-skb mode

2019-03-20 Thread Willem de Bruijn
On Wed, Mar 20, 2019 at 3:48 PM Stanislav Fomichev wrote: > > On 03/20, Willem de Bruijn wrote: > > On Wed, Mar 20, 2019 at 3:19 PM Stanislav Fomichev wrote: > > > > > > On 03/20, Willem de Bruijn wrote: > > > > On Wed, Mar 20, 2019 at 3:02 PM Stanislav Fomichev > > > > wrote: > > > > > > > > >

Re: [RFC bpf-next v2 7/9] bpf: when doing BPF_PROG_TEST_RUN for flow dissector use no-skb mode

2019-03-20 Thread Stanislav Fomichev
On 03/20, Willem de Bruijn wrote: > On Wed, Mar 20, 2019 at 3:19 PM Stanislav Fomichev wrote: > > > > On 03/20, Willem de Bruijn wrote: > > > On Wed, Mar 20, 2019 at 3:02 PM Stanislav Fomichev > > > wrote: > > > > > > > > On 03/20, Willem de Bruijn wrote: > > > > > On Wed, Mar 20, 2019 at 12:57

Re: [PATCH 0/6] ks8851 fixes & cleanups

2019-03-20 Thread David Miller
From: Lukas Wunner Date: Wed, 20 Mar 2019 15:02:00 +0100 > Four fixes and two cleanups for the Microchip (formerly Micrel) KSZ8851 > SPI Ethernet driver. > > Some of the fixes might even pass as stable material, but I haven't marked > them as such for cautiousness: Doesn't hurt letting them bake

Re: [RFC PATCH net-next] selftests: tc-testing: Add pedit tests

2019-03-20 Thread Lucas Bates
On Fri, Mar 1, 2019 at 7:33 AM Dmytro Linkin wrote: > > Add 36 pedit action tests to check pedit options described in tc-pedit(8) > man page. Test cases can be specified by categories: actions, pedit, > raw_op, layered_op. RAW_OP cases check offset option for u8, u16 and u32 > offset size. LAYERED

Re: [PATCH net v2 00/18] net/sched: validate the control action with all the other parameters

2019-03-20 Thread David Miller
From: Davide Caratti Date: Wed, 20 Mar 2019 14:59:58 +0100 > currently, the kernel checks for bad values of the control action in > tcf_action_init_1(), after a successful call to the action's init() > function. When the control action is 'goto chain', this causes two > undesired behaviors: ...

Re: [RFC bpf-next v2 7/9] bpf: when doing BPF_PROG_TEST_RUN for flow dissector use no-skb mode

2019-03-20 Thread Willem de Bruijn
On Wed, Mar 20, 2019 at 3:19 PM Stanislav Fomichev wrote: > > On 03/20, Willem de Bruijn wrote: > > On Wed, Mar 20, 2019 at 3:02 PM Stanislav Fomichev wrote: > > > > > > On 03/20, Willem de Bruijn wrote: > > > > On Wed, Mar 20, 2019 at 12:57 PM Stanislav Fomichev > > > > wrote: > > > > > > > >

Re: [RFC bpf-next v2 7/9] bpf: when doing BPF_PROG_TEST_RUN for flow dissector use no-skb mode

2019-03-20 Thread Stanislav Fomichev
On 03/20, Willem de Bruijn wrote: > On Wed, Mar 20, 2019 at 3:02 PM Stanislav Fomichev wrote: > > > > On 03/20, Willem de Bruijn wrote: > > > On Wed, Mar 20, 2019 at 12:57 PM Stanislav Fomichev > > > wrote: > > > > > > > > On 03/19, Willem de Bruijn wrote: > > > > > On Tue, Mar 19, 2019 at 6:21

Re: [RFC bpf-next v2 7/9] bpf: when doing BPF_PROG_TEST_RUN for flow dissector use no-skb mode

2019-03-20 Thread Willem de Bruijn
On Wed, Mar 20, 2019 at 3:02 PM Stanislav Fomichev wrote: > > On 03/20, Willem de Bruijn wrote: > > On Wed, Mar 20, 2019 at 12:57 PM Stanislav Fomichev > > wrote: > > > > > > On 03/19, Willem de Bruijn wrote: > > > > On Tue, Mar 19, 2019 at 6:21 PM Stanislav Fomichev > > > > wrote: > > > > > >

[PATCH net-next] net: dst: remove gc leftovers

2019-03-20 Thread Julian Wiedmann
Get rid of some obsolete gc-related documentation and macros that were missed in commit 5b7c9a8ff828 ("net: remove dst gc related code"). CC: Wei Wang Signed-off-by: Julian Wiedmann --- one more time, with cc netdev... include/net/dst.h | 11 --- net/core/dst.c| 17

Re: [RFC bpf-next v2 7/9] bpf: when doing BPF_PROG_TEST_RUN for flow dissector use no-skb mode

2019-03-20 Thread Stanislav Fomichev
On 03/20, Willem de Bruijn wrote: > On Wed, Mar 20, 2019 at 12:57 PM Stanislav Fomichev wrote: > > > > On 03/19, Willem de Bruijn wrote: > > > On Tue, Mar 19, 2019 at 6:21 PM Stanislav Fomichev > > > wrote: > > > > > > > > Now that we have __flow_bpf_dissect which works on raw data (by > > > > c

[PATCH v4 bpf-next 2/3] BPF: helpers: New helper to obtain namespace data from current task

2019-03-20 Thread Carlos Antonio Neira Bustos
This is a fix for patch series 2 from v3.It fixes a typo on the helper documentation. >From e505e591020ca1d2224e318d8502446b1821f07a Mon Sep 17 00:00:00 2001 From: Carlos Date: Wed, 20 Mar 2019 15:32:22 -0300 Subject: [PATCH] [PATCH bpf-next v4 2/3] BPF: New helper to obtain namespace data from

Re: [PATCH v3 3/3] net: dsa: qca8k: extend slave-bus implementations

2019-03-20 Thread Christian Lamparter
On Wednesday, March 20, 2019 7:27:09 PM CET Florian Fainelli wrote: > On 3/19/19 12:54 PM, Christian Lamparter wrote: > > This patch implements accessors for the QCA8337 MDIO access > > through the MDIO_MASTER register, which makes it possible to > > access the PHYs on slave-bus through the switch.

Re: [RFC bpf-next v2 7/9] bpf: when doing BPF_PROG_TEST_RUN for flow dissector use no-skb mode

2019-03-20 Thread Willem de Bruijn
On Wed, Mar 20, 2019 at 12:57 PM Stanislav Fomichev wrote: > > On 03/19, Willem de Bruijn wrote: > > On Tue, Mar 19, 2019 at 6:21 PM Stanislav Fomichev wrote: > > > > > > Now that we have __flow_bpf_dissect which works on raw data (by > > > constructing temporary on-stack skb), use it when doing

Re: [PATCH v3 3/3] net: dsa: qca8k: extend slave-bus implementations

2019-03-20 Thread Florian Fainelli
On 3/19/19 12:54 PM, Christian Lamparter wrote: > This patch implements accessors for the QCA8337 MDIO access > through the MDIO_MASTER register, which makes it possible to > access the PHYs on slave-bus through the switch. In cases > where the switch ports are already mapped via external > "phy-ph

RE: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-20 Thread Parav Pandit
Hi Jiri, Jakub, Samudrala Sridhar, > -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Parav Pandit > Sent: Monday, March 18, 2019 5:12 PM > To: Jakub Kicinski > Cc: Jiri Pirko ; Samudrala, Sridhar > ; da...@davemloft.net; > netdev@vger.kernel.org; oss-driv...@netron

Re: [PATCH net-next v2 0/3] net: refactor ndo_select_queue()

2019-03-20 Thread David Miller
From: Paolo Abeni Date: Wed, 20 Mar 2019 11:02:03 +0100 > Currently, on most devices implementing ndo_select_queue(), we get 2 > indirect calls per xmit packet, at least in some scenarios. > > We can avoid one of such indirect calls refactoring the ndo_select_queue() > usage so that we don't nee

Re: regression from: net: phy: marvell: Avoid unnecessary soft reset

2019-03-20 Thread Heiner Kallweit
On 20.03.2019 13:22, liweihang wrote: > > >> -Original Message- >> From: Florian Fainelli [mailto:f.faine...@gmail.com] >> Sent: Wednesday, March 20, 2019 11:37 AM >> To: liweihang ; Phil Reid >> ; netdev@vger.kernel.org >> Cc: Andrew Lunn ; David S. Miller >> ; dongsheng.w...@hxt-semitec

Re: [PATCH net-next 0/2] qed* enhancements.

2019-03-20 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Wed, 20 Mar 2019 00:26:24 -0700 > The patch series adds couple of enhancements for qed/qede drivers. > Please consider applying it to 'net-next' tree. > > Sudarsana Reddy Kalluru (2): > qede: Populate mbi version in ethtool driver query data. > qed: Define

[PATCH net 1/1] net: sched: fix cleanup NULL pointer exception in act_mirr

2019-03-20 Thread John Hurley
A new mirred action is created by the tcf_mirred_init function. This contains a list head struct which is inserted into a global list on successful creation of a new action. However, after a creation, it is still possible to error out if the egress device does not exist. This calls the act_mirr cle

Re: [PATCH bpf-next 09/13] bpf: add bpf_skb_adjust_room encap flags

2019-03-20 Thread Willem de Bruijn
On Wed, Mar 20, 2019 at 11:51 AM Alan Maguire wrote: > > On Wed, 20 Mar 2019, Willem de Bruijn wrote: > > > From: Willem de Bruijn > > > > When pushing tunnel headers, annotate skbs in the same way as tunnel > > devices. > > > This is great stuff Willem! > > > For GSO packets, the network stack r

Re: [PATCH net] sctp: use memdup_user instead of vmemdup_user

2019-03-20 Thread David Miller
From: Xin Long Date: Wed, 20 Mar 2019 14:49:38 +0800 > In sctp_setsockopt_bindx()/__sctp_setsockopt_connectx(), it allocates > memory with addrs_size which is passed from userspace. We used flag > GFP_USER to put some more restrictions on it in Commit cacc06215271 > ("sctp: use GFP_USER for user-

Re: [PATCHv2 net] ipv6: make ip6_create_rt_rcu return ip6_null_entry instead of NULL

2019-03-20 Thread David Miller
From: Xin Long Date: Wed, 20 Mar 2019 14:45:48 +0800 > Jianlin reported a crash: > > [ 381.484332] BUG: unable to handle kernel NULL pointer dereference at > 0068 > [ 381.619802] RIP: 0010:fib6_rule_lookup+0xa3/0x160 > [ 382.009615] Call Trace: > [ 382.020762] > [ 3

Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device

2019-03-20 Thread David Miller
From: Hangbin Liu Date: Wed, 20 Mar 2019 10:23:33 +0800 > Similiar to commit a6111d3c93d0 ("vlan: Pass SIOC[SG]HWTSTAMP ioctls to > real device") and commit 37dd9255b2f6 ("vlan: Pass ethtool get_ts_info > queries to real device."), add MACVlan HW ptp support. > > Signed-off-by: Hangbin Liu App

Re: [PATCH v3 2/3] dt-bindings: net: dsa: qca8k: support internal mdio-bus

2019-03-20 Thread Florian Fainelli
On 3/19/19 12:54 PM, Christian Lamparter wrote: > This patch updates the qca8k's binding to document to the > approach for using the internal mdio-bus of the supported > qca8k switches. > > Signed-off-by: Christian Lamparter Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 1/3] dt-bindings: net: dsa: qca8k: fix example

2019-03-20 Thread Florian Fainelli
On 3/19/19 12:54 PM, Christian Lamparter wrote: > In the example, the phy at phy@0 is clashing with > the switch0@0 at the same address. Usually, the switches > are accessible through pseudo PHYs which in case of the > qca8k are located at 0x10 - 0x18. > > Signed-off-by: Christian Lamparter Revi

Re: [PATCH net-next v2] net/tls: Add support of AES128-CCM based ciphers

2019-03-20 Thread David Miller
From: Vakul Garg Date: Wed, 20 Mar 2019 02:03:36 + > Added support for AES128-CCM based record encryption. AES128-CCM is > similar to AES128-GCM. Both of them have same salt/iv/mac size. The > notable difference between the two is that while invoking AES128-CCM > operation, the salt||nonce (w

Re: [PATCH net-next 0/2] net: phy: aquantia: add interface mode handling

2019-03-20 Thread David Miller
From: Heiner Kallweit Date: Tue, 19 Mar 2019 23:02:22 +0100 > These two patches add interface mode handling for the AQR107/AQCS109. Series applied, thanks Heiner.

Re: Remove tasklet_hrtimer

2019-03-20 Thread Sebastian Andrzej Siewior
On 2019-03-20 10:45:41 [-0700], David Miller wrote: > > tglx can take them, feel free to add my: > > Acked-by: David S. Miller Thank you. Sebastian

  1   2   >