> -----Original Message----- > From: David Miller <da...@davemloft.net> > Sent: Wednesday, March 20, 2019 11:44 PM > To: Sudarsana Reddy Kalluru <skall...@marvell.com> > Cc: netdev@vger.kernel.org; Ariel Elior <ael...@marvell.com>; Michal > Kalderon <mkalde...@marvell.com> > Subject: Re: [PATCH net-next 0/2] qed* enhancements. > > From: Sudarsana Reddy Kalluru <skall...@marvell.com> > Date: Wed, 20 Mar 2019 00:26:24 -0700 > > > The patch series adds couple of enhancements for qed/qede drivers. > > Please consider applying it to 'net-next' tree. > > > > Sudarsana Reddy Kalluru (2): > > qede: Populate mbi version in ethtool driver query data. > > qed: Define new MF bit for no_vlan config > > Series appied. > > I don't know how big your MBI version strings are, but if you are printing now > both it and the MFW versions into that one string you might hit the > ETHTOOL_FWVERS_LEN limit often. > > Just a thought...
Dave, Thanks for your comments and accepting the changes. Size of mbi version string is 7 bytes and the mfw is 10 bytes. Hence the total string size including the spaces would be under ETHTOOL_FWVERS_LEN. Thanks, Sudarsana
