From: Moshe Shemesh <mo...@mellanox.com>

Added IANA_VXLAN_UDP_PORT (4789) definition to vxlan header file so it
can be used by drivers instead of local definition.
Updated drivers which locally defined it as 4789 to use it.

Signed-off-by: Moshe Shemesh <mo...@mellanox.com>
Reviewed-by: Or Gerlitz <ogerl...@mellanox.com>
Cc: John Hurley <john.hur...@netronome.com>
Cc: Jakub Kicinski <jakub.kicin...@netronome.com>
Cc: Yunsheng Lin <linyunsh...@huawei.com>
Cc: Peng Li <lipeng...@huawei.com>
Reviewed-by: Tariq Toukan <tar...@mellanox.com>
Signed-off-by: Saeed Mahameed <sae...@mellanox.com>
---
 drivers/net/ethernet/hisilicon/hns3/hns3_enet.c     | 4 ++--
 drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c | 5 +++--
 drivers/net/ethernet/netronome/nfp/flower/main.h    | 2 +-
 include/net/vxlan.h                                 | 2 ++
 4 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c 
b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index 1c1f17ec6be2..1f4d181f169f 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -826,12 +826,12 @@ static void hns3_set_l2l3l4_len(struct sk_buff *skb, u8 
ol4_proto,
  */
 static bool hns3_tunnel_csum_bug(struct sk_buff *skb)
 {
-#define IANA_VXLAN_PORT        4789
        union l4_hdr_info l4;
 
        l4.hdr = skb_transport_header(skb);
 
-       if (!(!skb->encapsulation && l4.udp->dest == htons(IANA_VXLAN_PORT)))
+       if (!(!skb->encapsulation &&
+             l4.udp->dest == htons(IANA_VXLAN_UDP_PORT)))
                return false;
 
        skb_checksum_help(skb);
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c 
b/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c
index 9a8fd762167b..b9d4f4e19ff9 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/vxlan.c
@@ -33,6 +33,7 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/mlx5/driver.h>
+#include <net/vxlan.h>
 #include "mlx5_core.h"
 #include "vxlan.h"
 
@@ -204,8 +205,8 @@ struct mlx5_vxlan *mlx5_vxlan_create(struct mlx5_core_dev 
*mdev)
        spin_lock_init(&vxlan->lock);
        hash_init(vxlan->htable);
 
-       /* Hardware adds 4789 by default */
-       mlx5_vxlan_add_port(vxlan, 4789);
+       /* Hardware adds 4789 (IANA_VXLAN_UDP_PORT) by default */
+       mlx5_vxlan_add_port(vxlan, IANA_VXLAN_UDP_PORT);
 
        return vxlan;
 }
diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.h 
b/drivers/net/ethernet/netronome/nfp/flower/main.h
index 7afe66eff684..f214759d485b 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/main.h
+++ b/drivers/net/ethernet/netronome/nfp/flower/main.h
@@ -34,7 +34,7 @@ struct nfp_app;
 #define NFP_FL_MASK_REUSE_TIME_NS      40000
 #define NFP_FL_MASK_ID_LOCATION                1
 
-#define NFP_FL_VXLAN_PORT              4789
+#define NFP_FL_VXLAN_PORT              IANA_VXLAN_UDP_PORT
 #define NFP_FL_GENEVE_PORT             GENEVE_UDP_PORT
 
 /* Extra features bitmap. */
diff --git a/include/net/vxlan.h b/include/net/vxlan.h
index 00254a58824b..83b5999a2587 100644
--- a/include/net/vxlan.h
+++ b/include/net/vxlan.h
@@ -8,6 +8,8 @@
 #include <net/rtnetlink.h>
 #include <net/switchdev.h>
 
+#define IANA_VXLAN_UDP_PORT     4789
+
 /* VXLAN protocol (RFC 7348) header:
  * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
  * |R|R|R|R|I|R|R|R|               Reserved                        |
-- 
2.20.1

Reply via email to