Since commit fc62814d690c ("net/packet: fix 4gb buffer limit due to overflow
check")
one can now allocate packet ring buffers >= UINT_MAX. However, syzkaller
found that that triggers a warning:
[ 21.10] WARNING: CPU: 2 PID: 2075 at mm/page_alloc.c:4584
__alloc_pages_nod0
[ 21.101490] Mod
Especially for a patch series this big, you must provide an
appropriate cover posting explaining at a high level what this series
is doing, how it is doing it, and why it is doing it that way.
Thank you.
On Mon, Mar 18, 2019 at 10:08:24PM -0700, Cong Wang wrote:
>
> +static inline bool xfrm_id_proto_valid(u8 proto)
> +{
> + switch (proto) {
> + case IPPROTO_AH:
> + case IPPROTO_ESP:
> + case IPPROTO_COMP:
> +#if IS_ENABLED(CONFIG_IPV6)
> + case IPPROTO_ROUTING:
> + case IPPR
Added support for AES128-CCM based record encryption. AES128-CCM is
similar to AES128-GCM. Both of them have same salt/iv/mac size. The
notable difference between the two is that while invoking AES128-CCM
operation, the salt||nonce (which is passed as IV) has to be prefixed
with a hardcoded value '
In commit 6a53b7593233 ("xfrm: check id proto in validate_tmpl()")
I introduced a check for xfrm protocol, but unfortunately
xfrm_id_proto_match() could still miss IPPROTO_ROUTING which causes
entries left in net->xfrm.state_all.
This patch extracts the check from validate_tmpl() to
xfrm_id_proto_
Bring it.
From: Florian Fainelli
Date: Mon, 18 Mar 2019 11:07:33 -0700
> Provide an explanation of what is expected with respect to sending new
> versions of specific patches within a patch series, as well as what
> happens if an earlier patch series accidentally gets merged).
>
> Signed-off-by: Florian F
Prefer bpf_htons() instead (since __bpf_constant_htons() was removed).
Signed-off-by: Sergey Senozhatsky
---
tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 4 ++--
tools/testing/selftests/bpf/test_progs.c| 8
2 files changed, 6 insertions(+), 6 deletions(-)
d
Not all compilers have __builtin_bswap16() and __builtin_bswap32(),
thus not all compilers are able to compile the following code
(bpf_htons):
(__builtin_constant_p(x) ? \
___constant_swab16(x) : __builtin_bswap16(x))
That's why, for instance, bpf_htons() doesn't work on G
From: Julian Wiedmann
Date: Mon, 18 Mar 2019 16:40:53 +0100
> please apply the following three patches to -net. The first two are fixes
> for minor race conditions in the probe code, while the third one gets
> dropwatch working (again).
Series applied, thanks Julian.
On 19/03/2019 1:09 am, Florian Fainelli wrote:
On 3/17/19 7:11 PM, Phil Reid wrote:
On 16/03/2019 5:58 am, Florian Fainelli wrote:
On 3/15/19 1:52 AM, Phil Reid wrote:
G'day All,
I've just update from kernel 4.19 to 5.0 on a custom board that has a
marvell
dsa mv88e6085 and the phy on the mv8
On Mon, Mar 18, 2019 at 1:45 PM Cong Wang wrote:
> @@ -3978,6 +3982,9 @@ static void hci_inquiry_result_with_rssi_evt(struct
> hci_dev *hdev,
>
> if ((skb->len - 1) / num_rsp != sizeof(struct
> inquiry_info_with_rssi)) {
> struct inquiry_info_with_rssi_and_pscan_mode *inf
From: Xin Long
Date: Mon, 18 Mar 2019 20:05:58 +0800
> This is a patchset to fix ignoring asoc_id for tcp-style sockets on
> some setsockopts, introduced by SCTP_CURRENT_ASSOC of the patchset:
>
> [net-next,00/24] sctp: support SCTP_FUTURE/CURRENT/ALL_ASSOC
> (https://patchwork.ozlabs.org/co
From: Xin Long
Date: Mon, 18 Mar 2019 19:58:29 +0800
> Now sctp_copy_descendant() copies pd_lobby from old sctp scok to new
> sctp sock. If sctp_sock_migrate() returns error, it will panic when
> releasing new sock and trying to purge pd_lobby due to the incorrect
> pointers in pd_lobby.
>
> [
From: Xin Long
Date: Mon, 18 Mar 2019 19:47:00 +0800
> sctp_hdr(skb) only works when skb->transport_header is set properly.
>
> But in Netfilter, skb->transport_header for ipv6 is not guaranteed
> to be right value for sctphdr. It would cause to fail to check the
> checksum for sctp packets.
>
From: Willem de Bruijn
Date: Mon, 18 Mar 2019 10:49:56 -0400
> On Mon, Mar 18, 2019 at 1:41 AM Yoshiki Komachi
> wrote:
>>
>> I am using "protocol ip" filters in TC to manipulate TC flower
>> classifiers, which are only available with "protocol ip". However,
>> I faced an issue that packets sent
From: Zhiqiang Liu
Date: Sat, 16 Mar 2019 17:02:54 +0800
> Commit ad6c9986bcb62 ("vxlan: Fix GRO cells race condition between
> receive and link delete") fixed a race condition for the typical case a vxlan
> device is dismantled from the current netns. But if a netns is dismantled,
> vxlan_destro
I agree with Florian's minor comment regarding pr_info->netdev_dgb change.
But, apart from that, I reviewed both the patches look good to me:
Reviewed-By: Vedang Patel
On 3/15/19, 2:17 PM, "netdev-ow...@vger.kernel.org on behalf of Leandro
Dorileo" wrote:
This set fixes miscalculations
From: Igor Russkikh
Date: Sat, 16 Mar 2019 08:28:18 +
> From: Dmitry Bogdanov
>
> TCP/UDP checksum validity was propagated to skb
> only if IP checksum is valid.
> But for IPv6 there is no validity as there is no checksum in IPv6.
> This patch propagates TCP/UDP checksum validity regardless
From: Matteo Croce
Date: Sat, 16 Mar 2019 01:00:50 +0100
> Similarly to commit a7603ac1fc8c ("geneve: change NET_UDP_TUNNEL
> dependency to select"), GTP has a dependency on NET_UDP_TUNNEL which
> makes impossible to compile it if no other protocol depending on
> NET_UDP_TUNNEL is selected.
>
>
From: Eric Dumazet
Date: Fri, 15 Mar 2019 10:41:14 -0700
> rose_write_internal() uses a temp buffer of 100 bytes, but a manual
> inspection showed that given arbitrary input, rose_create_facilities()
> can fill up to 110 bytes.
>
> Lets use a tailroom of 256 bytes for peace of mind, and remove
>
> -Original Message-
> From: Jakub Kicinski
> Sent: Monday, March 18, 2019 4:30 PM
> To: Parav Pandit
> Cc: Jiri Pirko ; Samudrala, Sridhar
> ; da...@davemloft.net;
> netdev@vger.kernel.org; oss-driv...@netronome.com
> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on dev
On Mon, Mar 18, 2019 at 12:48 PM David Ahern wrote:
>
> On 3/18/19 12:36 PM, Xin Long wrote:
> > diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> > index 4ef4bbd..754777d 100644
> > --- a/net/ipv6/route.c
> > +++ b/net/ipv6/route.c
> > @@ -1040,13 +1040,17 @@ static struct rt6_info *ip6_create_r
On Mon, 18 Mar 2019 20:35:02 +, Parav Pandit wrote:
> > > > > physical and pf has some overlapping definitions.
> > > >
> > > > What "overlapping definitions" do physical and PF have?
> > > PF has physically user facing port.
> >
> > PF doesn't "have a user facing port" in switchdev mode
Hi Florian,
Florian Fainelli writes:
> On 3/15/19 2:16 PM, Leandro Dorileo wrote:
>> The Time Aware Priority Scheduler is heavily dependent to link speed,
>> it relies on it to calculate transmission bytes per cycle, we can't
>> properly calculate the so called budget if the device has failed
hci_event_packet() blindly assumes all packets are sane, at least
for packets allocated via vhci_get_user() path this is not true.
We have to check if we access skb data out-of-bound with
pskb_may_pull() before each skb->data dereference on RX path.
Probably we need to same check for other hci_eve
> -Original Message-
> From: Jakub Kicinski
> Sent: Monday, March 18, 2019 3:00 PM
> To: Parav Pandit
> Cc: Jiri Pirko ; Samudrala, Sridhar
> ; da...@davemloft.net;
> netdev@vger.kernel.org; oss-driv...@netronome.com
> Subject: RE: [PATCH net-next v2 4/7] devlink: allow subports on dev
On Mon, 18 Mar 2019 19:44:21 +, Parav Pandit wrote:
> > -Original Message-
> > From: Jakub Kicinski
> > Sent: Monday, March 18, 2019 2:37 PM
> > To: Parav Pandit
> > Cc: Jiri Pirko ; Samudrala, Sridhar
> > ; da...@davemloft.net;
> > netdev@vger.kernel.org; oss-driv...@netronome.com
>
On 3/18/19 12:36 PM, Xin Long wrote:
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 4ef4bbd..754777d 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -1040,13 +1040,17 @@ static struct rt6_info *ip6_create_rt_rcu(struct
> fib6_info *rt)
> struct rt6_info *nrt;
>
>
> -Original Message-
> From: Jakub Kicinski
> Sent: Monday, March 18, 2019 2:37 PM
> To: Parav Pandit
> Cc: Jiri Pirko ; Samudrala, Sridhar
> ; da...@davemloft.net;
> netdev@vger.kernel.org; oss-driv...@netronome.com
> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on dev
> -Original Message-
> From: Jakub Kicinski
> Sent: Monday, March 18, 2019 2:19 PM
> To: Jiri Pirko
> Cc: Parav Pandit ; Samudrala, Sridhar
> ; da...@davemloft.net;
> netdev@vger.kernel.org; oss-driv...@netronome.com
> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on dev
On Mon, 18 Mar 2019 16:22:33 +, Parav Pandit wrote:
>>2. flavour should not be vf/pf, flavour should be hostport, switchport.
>>> >Because switch is flat and agnostic of pf/vf/mdev.
>
> Not sure. It's good to have this kind of visibility.
>
port can have label/attribut
This patch adds support for 6PE (RFC 4798) which uses IPv4-mapped IPv6
nexthop to connect IPv6 islands over IPv4 only MPLS network core.
Prior to this fix, to find the link-layer destination mac address, 6PE
enabled host/router was sending IPv6 ND requests for IPv4-mapped IPv6
nexthop address ove
On Mon, 18 Mar 2019 15:43:20 +, Parav Pandit wrote:
> > -Original Message-
> > From: Jakub Kicinski
> > Sent: Friday, March 15, 2019 8:16 PM
> > To: Parav Pandit
> > Cc: Jiri Pirko ; Samudrala, Sridhar
> > ; da...@davemloft.net;
> > netdev@vger.kernel.org; oss-driv...@netronome.com
>
On Mon, Mar 18, 2019 at 10:37 AM Martin KaFai Lau wrote:
>
> Naresh reported that test_align fails because of the mismatch at the
> verbose printout of the register states. The reason is due to the newly
> added ref_obj_id.
>
> ref_obj_id is only useful for refcounted reg. Thus, this patch fixes
On Mon, 18 Mar 2019 13:21:05 +0100, Jiri Pirko wrote:
> >First two entries shows the link between hostport and switchport.
> >$ devlink port show
> >pci/:05:00.0/10002 eth netdev flavour switchport switch_id 00154d130d2f
> >peer pci/:05:00.0/1
> >
> >pci/:05:00.0/1 eth netdev flavour h
On Mon, 18 Mar 2019 13:11:54 +0100, Jiri Pirko wrote:
> >> >2. flavour should not be vf/pf, flavour should be hostport, switchport.
> >> >Because switch is flat and agnostic of pf/vf/mdev.
> >>
> >> Not sure. It's good to have this kind of visibility.
> >
> >Yes, this subthread honestly make
On 18.03.2019 17:17, VDR User wrote:
> Just a quick check-in... I was able to do a decent amount of testing
> yesterday after applying Heiner's patches that "removes an extra PCI
> register read in the
> interrupt handler" and adds some debug logging. So far I haven't seen
> any crashes, everythin
The Anybus-S PROFINET IRT communication module provides instant integration
to any Ethernet based LAN via SMTP, FTP, HTTP as well as PROFINET and
Modbus-TCP. Additional protocols can be implemented on top of TCP/IP
or UDP using the transparent socket interface.
Official documentation:
https://www.
Fieldbus device (client) adapters allow data exchange with a PLC aka.
"Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.)
They are typically used when a Linux device wants to expose itself
as an actuator, motor, console light, switch, etc. over the fieldbus.
This framework is designed t
Add a driver for the Arcx anybus controller.
This device implements two Anybus-S hosts (buses),
and connects to the SoC via a parallel memory bus.
There is also a CAN power readout, unrelated to the Anybus,
modelled as a regulator.
Signed-off-by: Sven Van Asbroeck
---
drivers/staging/fieldbus/M
arcx Inc. is an engineering company which provides advanced
embedded systems and consulting services.
Archronix is a technology design and product engineering firm
specializing in hardware control systems and enabling software.
Clients include OEM's in the transportation, aerospace,
medical and co
This patch:
1. adds a Fieldbus subsystem
2. adds support for the HMS Industrial Networks AB Profinet card.
1. Fieldbus subsystem
-
Fieldbus device (client) adapters allow data exchange with a PLC aka.
"Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.)
They are t
The Anybus-S/Anybus-M is a series of interchangeable fieldbus communication
modules featuring on board memory and processing power. All software and
hardware functionality required to communicate on the fieldbus is
incorporated in the module itself, allowing the application to focus on
other tasks.
This patch adds devicetree binding documentation for the
Arcx anybus controller.
Signed-off-by: Sven Van Asbroeck
---
.../fieldbus/arcx,anybus-controller.txt | 71 +++
1 file changed, 71 insertions(+)
create mode 100644
Documentation/devicetree/bindings/fieldbus/arcx,anyb
Provide an explanation of what is expected with respect to sending new
versions of specific patches within a patch series, as well as what
happens if an earlier patch series accidentally gets merged).
Signed-off-by: Florian Fainelli
---
Documentation/networking/netdev-FAQ.rst | 13 +
> I'm using a Marvell 88E6161 with 5.0.1 and I get the following output
> which I think indicates that the 6161 does not use the 1540 PHY:
Correct. Maybe it is the 6172? I know it is one of the devices i have.
Yes, i mv88e6172 uses 88E1540.
Andrew
Naresh reported that test_align fails because of the mismatch at the
verbose printout of the register states. The reason is due to the newly
added ref_obj_id.
ref_obj_id is only useful for refcounted reg. Thus, this patch fixes it
by only printing ref_obj_id for refcounted reg. While at it, it
On Mon, Mar 18, 2019 at 06:31:53PM +0530, Naresh Kamboju wrote:
> selftests: bpf: test_align
> Test 0: mov ... Failed to find match 1: R1=ctx(id=0,off=0,imm=0)
Thanks for the report. I will post a fix.
The ip -j option to print output as JSON is ignored when using 'route get':
$ ip -j route get 127.0.0.1
local 127.0.0.1 dev lo src 127.0.0.1 uid 1000
cache
Enable JSON output in iproute_get(), and don't let print_cache_flags() close
the JSON output, as it's not always the last ca
=== Overview
arm64 has a feature called Top Byte Ignore, which allows to embed pointer
tags into the top byte of each pointer. Userspace programs (such as
HWASan, a memory debugging tool [1]) might use this feature and pass
tagged user pointers to the kernel through syscalls or other interfaces.
To allow arm64 syscalls to accept tagged pointers from userspace, we must
untag them when they are passed to the kernel. Since untagging is done in
generic parts of the kernel, the untagged_addr macro needs to be defined
for all architectures.
Define it as a noop for architectures other than arm64
This patch is a part of a series that extends arm64 kernel ABI to allow to
pass tagged user pointers (with the top byte set to something else other
than 0x00) as syscall arguments.
This patch allows tagged pointers to be passed to the following memory
syscalls: madvise, mbind, get_mempolicy, minco
This patch is a part of a series that extends arm64 kernel ABI to allow to
pass tagged user pointers (with the top byte set to something else other
than 0x00) as syscall arguments.
userfaultfd_register() and userfaultfd_unregister() use provided user
pointers for vma lookups, which can only by don
This patch is a part of a series that extends arm64 kernel ABI to allow to
pass tagged user pointers (with the top byte set to something else other
than 0x00) as syscall arguments.
In copy_mount_options a user address is being subtracted from TASK_SIZE.
If the address is lower than TASK_SIZE, the
ip route generates an invalid JSON if the route type has to be printed,
eg. when detailed mode is active, or the type is different that unicast:
$ ip -d -j -p route show
[ {"unicast",
"dst": "192.168.122.0/24",
"dev": "virbr0",
"protocol": "kernel",
This patch is a part of a series that extends arm64 kernel ABI to allow to
pass tagged user pointers (with the top byte set to something else other
than 0x00) as syscall arguments.
mm/gup.c provides a kernel interface that accepts user addresses and
manipulates user pages directly (for example get
This patch is a part of a series that extends arm64 kernel ABI to allow to
pass tagged user pointers (with the top byte set to something else other
than 0x00) as syscall arguments.
strncpy_from_user and strnlen_user accept user addresses as arguments, and
do not go through the same path as copy_fr
This patch is a part of a series that extends arm64 kernel ABI to allow to
pass tagged user pointers (with the top byte set to something else other
than 0x00) as syscall arguments.
prctl_set_mm() and prctl_set_mm_map() use provided user pointers for vma
lookups and do some pointer comparisons to p
> Some of the older Marvell switches use the 1540 for its internal
> PHYs. Same OUI as the external PHY. I don't remember which
> switches. Maybe the mv88e6161 in the RDU1?
>
I'm using a Marvell 88E6161 with 5.0.1 and I get the following output
which I think indicates that the 6161 does not use th
ip route can produce invalid JSON under certain circumstances,
here there are two fixes for this.
Matteo Croce (2):
ip route: print route type in JSON output
ip route: get: print JSON output when -j is given
ip/iproute.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
--
2
> Thanks, you mentioned a mv88e6085 but that chip is a 10/100 switch, did
> you mean that the mv88e6085 compatible string is used in Device Tree to
> designate that chip? While the 88E1540 driver is picked up, that driver
> is originally for external PHY packages (AFAICT), so there could be some
>
On 3/17/19 7:11 PM, Phil Reid wrote:
> On 16/03/2019 5:58 am, Florian Fainelli wrote:
>> On 3/15/19 1:52 AM, Phil Reid wrote:
>>> G'day All,
>>>
>>> I've just update from kernel 4.19 to 5.0 on a custom board that has a
>>> marvell
>>> dsa mv88e6085 and the phy on the mv88e6085 will only connect at
Bug fixes should target 'net', not 'net-next'.
On Mon, Mar 18, 2019 at 6:03 AM Naresh Kamboju
wrote:
>
> selftests: bpf: test_align failed on all devices ( arm64, armv7,
> x86_64 and i386) running Linux -next kernel 5.1.0-rc1 tag:
> next-20190318.
>
> Here is the log from arm64,
>
> selftests: bpf: test_align
>
> -Original Message-
> From: netdev-ow...@vger.kernel.org On
> Behalf Of Parav Pandit
> Sent: Monday, March 18, 2019 10:57 AM
> To: Jiri Pirko
> Cc: Samudrala, Sridhar ; Jakub Kicinski
> ; da...@davemloft.net;
> netdev@vger.kernel.org; oss-driv...@netronome.com
> Subject: RE: [PATCH ne
Just a quick check-in... I was able to do a decent amount of testing
yesterday after applying Heiner's patches that "removes an extra PCI
register read in the
interrupt handler" and adds some debug logging. So far I haven't seen
any crashes, everything has been smooth. It may be worth noting that
Replace open coded netdev_() macros.
Signed-off-by: Andy Shevchenko
---
drivers/net/ethernet/microchip/enc28j60.c | 42 ++-
1 file changed, 18 insertions(+), 24 deletions(-)
diff --git a/drivers/net/ethernet/microchip/enc28j60.c
b/drivers/net/ethernet/microchip/enc28j60.c
i
Instead of using open coded printk(KERN_) switch the driver to use
dev_ macros.
Note, the device name will be printed in full, which is beneficial when
more than one card installed on the system.
Signed-off-by: Andy Shevchenko
---
drivers/net/ethernet/microchip/enc28j60.c | 29 +
Eliminate some boilerplate code by using module_spi_driver() instead of
->init() / ->exit(), moving the salient bits from ->init() into ->probe().
Signed-off-by: Andy Shevchenko
---
drivers/net/ethernet/microchip/enc28j60.c | 21 ++---
1 file changed, 2 insertions(+), 19 deletion
The debug prints of network operations will look better if network
device name is printed. The benefit of that is a possibility to distinguish
the actual hardware when more than one is installed on the system.
Convert appropriate printk(KERN_DEBUG) to netdev_print(KERN_DEBUG, ndev).
Signed-off-by
Reduce size of duplicated comments by switching to use SPDX identifier.
No functional change.
Signed-off-by: Andy Shevchenko
---
drivers/net/ethernet/microchip/enc28j60.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/microchip/enc28j60.c
b/driver
Amend comments in the code:
- adding periods to the multi-line comments
- fixing typos
- capitalize first word in the sentences
- etc
Signed-off-by: Andy Shevchenko
---
drivers/net/ethernet/microchip/enc28j60.c | 31 ---
1 file changed, 16 insertions(+), 15 deletions(-)
Fix few indentation splats. No functional change intended.
Signed-off-by: Andy Shevchenko
---
drivers/net/ethernet/microchip/enc28j60.c | 58 ---
1 file changed, 21 insertions(+), 37 deletions(-)
diff --git a/drivers/net/ethernet/microchip/enc28j60.c
b/drivers/net/ethernet/
The debug prints of hardware status and operations will look better
if SPI device name is printed. The benefit of that is a possibility
to distinguish the actual hardware when more than one is installed
on the system.
Convert appropriate printk(KERN_DEBUG) to dev_print(KERN_DEBUG, &spi->dev).
Sig
Use ether_addr_copy() instead of memcpy() to copy the mac address.
Signed-off-by: Andy Shevchenko
---
drivers/net/ethernet/microchip/enc28j60.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/microchip/enc28j60.c
b/drivers/net/ethernet/microchip/enc28j60
The ->probe() and ->remove() stages can be easily debugged with
initcall_debug or function tracer. There is no need to repeat the same
explicitly in the driver.
Signed-off-by: Andy Shevchenko
---
drivers/net/ethernet/microchip/enc28j60.c | 20
1 file changed, 20 deletions(-)
There is no need to include linux/init.h when at the same time
we include linux/module.h.
Remove redundant inclusion.
Signed-off-by: Andy Shevchenko
---
drivers/net/ethernet/microchip/enc28j60.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/microchip/enc28j60.c
b/driv
Replace the DT-specific of_get_mac_address() function with
device_get_mac_address, which works on both DT and ACPI platforms.
This change makes it easier to add ACPI support.
Signed-off-by: Andy Shevchenko
---
drivers/net/ethernet/microchip/enc28j60.c | 7 +++
1 file changed, 3 insertions(+)
When dev_() macros are used against SPI device, the driver's name
is printed as well. No need to duplicate this explicitly.
Signed-off-by: Andy Shevchenko
---
drivers/net/ethernet/microchip/enc28j60.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/net/e
> -Original Message-
> From: Jiri Pirko
> Sent: Monday, March 18, 2019 7:21 AM
> To: Parav Pandit
> Cc: Samudrala, Sridhar ; Jakub Kicinski
> ; da...@davemloft.net;
> netdev@vger.kernel.org; oss-driv...@netronome.com
> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on dev
On 03/18/2019 04:39 PM, Michal Hocko wrote:
> On Mon 18-03-19 16:10:26, Martynas Pumputis wrote:
>> It has been observed that sometimes a higher order memory allocation
>> for BPF maps fails when there is no obvious memory pressure in a system.
>>
>> E.g. the map (BPF_MAP_TYPE_LRU_HASH, key=38, val
On Mon, 18 Mar 2019 15:02:53 +0100
Andrew Lunn wrote:
> On Mon, Mar 18, 2019 at 01:15:41PM +, Petr Machata wrote:
> >
> > Andrew Lunn writes:
> >
> > >> +enum rtnl_link_down_reason_major {
> > >> +RTNL_LDR_OTHER,
> > >
> > > Does 'other' make any sense? Seem better to just not
> -Original Message-
> From: Jakub Kicinski
> Sent: Friday, March 15, 2019 8:16 PM
> To: Parav Pandit
> Cc: Jiri Pirko ; Samudrala, Sridhar
> ; da...@davemloft.net;
> netdev@vger.kernel.org; oss-driv...@netronome.com
> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on dev
The HW trap and VNICC configuration is exposed via sysfs, and may have
already been modified when qeth_l?_probe_device() attempts to initialize
them. So (1) initialize the VNICC values a little earlier, and (2) don't
bother about the HW trap mode, it was already initialized before.
Signed-off-by:
Hi Dave,
please apply the following three patches to -net. The first two are fixes
for minor race conditions in the probe code, while the third one gets
dropwatch working (again).
Thanks,
Julian
Julian Wiedmann (3):
s390/qeth: don't erase configuration while probing
s390/qeth: fix race when
The ucast IP table is utilized by some of the L3-specific sysfs attributes
that qeth_l3_create_device_attributes() provides. So initialize the table
_before_ registering the attributes.
Fixes: ebccc7397e4a ("s390/qeth: add missing hash table initializations")
Signed-off-by: Julian Wiedmann
---
d
As part of the TX completion path, qeth_release_skbs() frees the completed
skbs with __skb_queue_purge(). This ends in kfree_skb(), reporting every
completed skb as dropped.
On the other hand when dropping an skb in .ndo_start_xmit, we end up
calling consume_skb()... where we should be using kfree_
On Mon 18-03-19 16:10:26, Martynas Pumputis wrote:
> It has been observed that sometimes a higher order memory allocation
> for BPF maps fails when there is no obvious memory pressure in a system.
>
> E.g. the map (BPF_MAP_TYPE_LRU_HASH, key=38, value=56, max_elems=524288)
> could not be created d
It has been observed that sometimes a higher order memory allocation
for BPF maps fails when there is no obvious memory pressure in a system.
E.g. the map (BPF_MAP_TYPE_LRU_HASH, key=38, value=56, max_elems=524288)
could not be created due to vmalloc unable to allocate 75497472B,
when the system's
On Mon, Mar 18, 2019 at 1:41 AM Yoshiki Komachi
wrote:
>
> I am using "protocol ip" filters in TC to manipulate TC flower
> classifiers, which are only available with "protocol ip". However,
> I faced an issue that packets sent via raw sockets with ETH_P_ALL
> did not match the ip filters even if
On Mon, Mar 18, 2019 at 01:15:41PM +, Petr Machata wrote:
>
> Andrew Lunn writes:
>
> >> +enum rtnl_link_down_reason_major {
> >> + RTNL_LDR_OTHER,
> >
> > Does 'other' make any sense? Seem better to just not report anything
> > at all, or add a comment that more reasons should be added at
Andrew Lunn writes:
> On Mon, Mar 18, 2019 at 01:15:41PM +, Petr Machata wrote:
>>
>> Andrew Lunn writes:
>>
>> >> +enum rtnl_link_down_reason_major {
>> >> + RTNL_LDR_OTHER,
>> >
>> > Does 'other' make any sense? Seem better to just not report anything
>> > at all, or add a comment that
On Mon, Mar 18, 2019 at 01:15:41PM +, Petr Machata wrote:
>
> Andrew Lunn writes:
>
> >> +enum rtnl_link_down_reason_major {
> >> + RTNL_LDR_OTHER,
> >
> > Does 'other' make any sense? Seem better to just not report anything
> > at all, or add a comment that more reasons should be added at
Andrew Lunn writes:
>> +enum rtnl_link_down_reason_major {
>> +RTNL_LDR_OTHER,
>
> Does 'other' make any sense? Seem better to just not report anything
> at all, or add a comment that more reasons should be added at the end
> to reflect whatever the hardware or software can determine.
You
> This copies how other fill APIs are done, in that the responsibility for
> filling up the message is deferred to the driver. I think it makes the
> API easier to extend: if there ever is richer information available, the
> drivers that want to support it just opt in and provide those attributes.
selftests: bpf: test_align failed on all devices ( arm64, armv7,
x86_64 and i386) running Linux -next kernel 5.1.0-rc1 tag:
next-20190318.
Here is the log from arm64,
selftests: bpf: test_align
Test 0: mov ... Failed to find match 1: R1=ctx(id=0,off=0,imm=0)
func#0 @0
0: R1=ctx(id=0 ref_obj_id
On Mon, Mar 18, 2019 at 12:34:55PM +, Petr Machata wrote:
> Jakub Kicinski writes:
> > Also perhaps this would be a ethtool-nl candidate (which would
> > hopefully land soon after the merge window)?
>
> Is this the repository with the patches? I'll take a look.
>
> https://github.com/mku
Jakub Kicinski writes:
> On Fri, 15 Mar 2019 17:56:07 +, Petr Machata wrote:
>> diff --git a/include/net/rtnetlink.h b/include/net/rtnetlink.h
>> index e2091bb2b3a8..cfd9e86ff0ca 100644
>> --- a/include/net/rtnetlink.h
>> +++ b/include/net/rtnetlink.h
>> @@ -110,6 +110,9 @@ struct rtnl_link
Fri, Mar 15, 2019 at 10:59:33PM CET, pa...@mellanox.com wrote:
>
>
>> -Original Message-
>> From: Jiri Pirko
>> Sent: Friday, March 15, 2019 3:08 PM
>> To: Parav Pandit
>> Cc: Samudrala, Sridhar ; Jakub Kicinski
>> ; da...@davemloft.net;
>> netdev@vger.kernel.org; oss-driv...@netronome.co
1 - 100 of 122 matches
Mail list logo
