Re: r8169 driver from kernel 5.0 crashing

2019-03-13 Thread Heiner Kallweit
On 14.03.2019 04:04, VDR User wrote: > Hi Heiner, > > Thanks for your response. Request info follows.. > >>> Hi, after updating to kernel 5.0, the nic driver (r8169) has been >>> crashing whenever I start using heavy traffic on it (for example, >>> xferring large files to the box across my lan).

Re: [PATCH v4 bpf 0/5] Fix bpf_tcp_sock and bpf_sk_fullsock issue related to bpf_sk_release

2019-03-13 Thread Martin Lau
On Wed, Mar 13, 2019 at 12:20:27PM -0700, Alexei Starovoitov wrote: > On Tue, Mar 12, 2019 at 10:23:01AM -0700, Martin KaFai Lau wrote: > > This set addresses issue about accessing invalid > > ptr returned from bpf_tcp_sock() and bpf_sk_fullsock() > > after bpf_sk_release(). > > > > v4: > > - Trie

Re: r8169 driver from kernel 5.0 crashing

2019-03-13 Thread VDR User
Hi Heiner, Thanks for your response. Request info follows.. > > Hi, after updating to kernel 5.0, the nic driver (r8169) has been > > crashing whenever I start using heavy traffic on it (for example, > > xferring large files to the box across my lan). The destination > > harddrive may be sleeping

UN

2019-03-13 Thread United Nation Compensation Fund
-- Emails has been sent to all deceived people around the world, the United Nations Organization has agreed to use it to compensate them. A total ($500,000), Five hundred thousand dollar will be programmed into an ATM card, This includes every foreign contractor that may not be available

Re: [PATCH net v1] net/mlx5e: Correctly use the namespace type when allocating pedit action

2019-03-13 Thread Tonghao Zhang
On Sat, Mar 2, 2019 at 3:43 AM Saeed Mahameed wrote: > > On Wed, 2019-02-27 at 21:02 +0100, Pablo Neira Ayuso wrote: > > On Wed, Feb 27, 2019 at 02:05:02PM +, Roi Dayan wrote: > > > > > > On 26/02/2019 14:28, xiangxia.m@gmail.com wrote: > > > > From: Tonghao Zhang > > > > > > > > The capa

Re: [PATCH RFC v4 0/5] SCTP: Event skb list overhaul.

2019-03-13 Thread Marcelo Ricardo Leitner
On Wed, Mar 13, 2019 at 01:06:21PM -0300, Marcelo Ricardo Leitner wrote: > On Mon, Mar 11, 2019 at 08:09:19PM -0700, David Miller wrote: > > > > This patch series eliminates the explicit reference to the skb list > > implementation via skb->prev dereferences. > > > > The approach used is to pass

[PATCH] net: add documentation to socket.c

2019-03-13 Thread Pedro Tammela
Adds missing sphinx documentation to the socket.c's functions. Also fixes some whitespaces. I also changed the style of older documentation as an effort to have an uniform documentation style. --- include/linux/net.h| 6 + include/linux/socket.h | 12 +- net/socket.c | 277 ++

[PATCH net 0/2] net/sched: taprio: cbs: Fix using invalid link speed

2019-03-13 Thread Leandro Dorileo
This set fixes miscalculations based on invalid link speed values. Leandro Dorileo (2): net/sched: taprio: fix picos_per_byte miscalculation net/sched: cbs: fix port_rate miscalculation net/sched/sch_cbs.c| 91 +++--- net/sched/sch_taprio.c | 90 ++

[PATCH net 2/2] net/sched: cbs: fix port_rate miscalculation

2019-03-13 Thread Leandro Dorileo
The Credit Based Shaper heavily depends on link speed to calculate the scheduling credits, we can't properly calculate the credits if the device has failed to report the link speed. In that case we can't dequeue packets assuming a wrong port rate that will result into an inconsistent credit distri

[PATCH net 1/2] net/sched: taprio: fix picos_per_byte miscalculation

2019-03-13 Thread Leandro Dorileo
The Time Aware Priority Scheduler is heavily dependent to link speed, it relies on it to calculate transmission bytes per cycle, we can't properly calculate the so called budget if the device has failed to report the link speed. In that case we can't dequeue packets assuming a wrong budget. This p

Re: [PATCH net] MAINTAINERS: GENET & SYSTEMPORT: Add internal Broadcom list

2019-03-13 Thread David Miller
From: Florian Fainelli Date: Tue, 12 Mar 2019 10:50:59 -0700 > There is a patchwork instance behind bcm-kernel-feedback-list that is > helpful to track submissions, add this list for the Broadcom GENET and > SYSTEMPORT drivers. > > Signed-off-by: Florian Fainelli Applied.

Re: [PATCHv2 net] pptp: dst_release sk_dst_cache in pptp_sock_destruct

2019-03-13 Thread David Miller
From: Xin Long Date: Wed, 13 Mar 2019 17:00:48 +0800 > sk_setup_caps() is called to set sk->sk_dst_cache in pptp_connect, > so we have to dst_release(sk->sk_dst_cache) in pptp_sock_destruct, > otherwise, the dst refcnt will leak. > > It can be reproduced by this syz log: > > r1 = socket$pptp(

Re: [PATCH net] l2tp: fix infoleak in l2tp_ip6_recvmsg()

2019-03-13 Thread David Miller
From: Eric Dumazet Date: Tue, 12 Mar 2019 06:50:11 -0700 > Back in 2013 Hannes took care of most of such leaks in commit > bceaa90240b6 ("inet: prevent leakage of uninitialized memory to user in recv > syscalls") > > But the bug in l2tp_ip6_recvmsg() has not been fixed. > > syzbot report : ..

Re: [PATCH net v2] net/tls: Inform user space about send buffer availability

2019-03-13 Thread David Miller
From: Vakul Garg Date: Tue, 12 Mar 2019 08:22:57 + > A previous fix ("tls: Fix write space handling") assumed that > user space application gets informed about the socket send buffer > availability when tls_push_sg() gets called. Inside tls_push_sg(), in > case do_tcp_sendpages() returns 0, t

Re: [PATCH] net_sched: return correct value for *notify* functions

2019-03-13 Thread David Miller
From: Zhike Wang Date: Mon, 11 Mar 2019 03:15:54 -0700 > It is confusing to directly use return value of netlink_send()/ > netlink_unicast() as the return value of *notify*, as it may be not > error at all. > > Example: in tc_del_tfilter(), after calling tfilter_del_notify(), it will > goto erro

Re: [PATCH v1 net] lan743x: Fix TX Stall Issue

2019-03-13 Thread David Miller
From: Bryan Whitehead Date: Wed, 13 Mar 2019 15:55:48 -0400 > It has been observed that tx queue may stall while downloading > from certain web sites (example www.speedtest.net) > > The cause has been tracked down to a corner case where > the tx interrupt vector was disabled automatically, but >

[PATCH v1 net] lan743x: Fix TX Stall Issue

2019-03-13 Thread Bryan Whitehead
It has been observed that tx queue may stall while downloading from certain web sites (example www.speedtest.net) The cause has been tracked down to a corner case where the tx interrupt vector was disabled automatically, but was not re enabled later. The lan743x has two mechanisms to enable/disab

[PATCH AUTOSEL 4.4 14/15] mdio_bus: Fix use-after-free on device_register fails

2019-03-13 Thread Sasha Levin
From: YueHaibing [ Upstream commit 6ff7b060535e87c2ae14dd8548512abfdda528fb ] KASAN has found use-after-free in fixed_mdio_bus_init, commit 0c692d07842a ("drivers/net/phy/mdio_bus.c: call put_device on device_register() failure") call put_device() while device_register() fails,give up the last r

Re: [PATCH v4 bpf 0/5] Fix bpf_tcp_sock and bpf_sk_fullsock issue related to bpf_sk_release

2019-03-13 Thread Alexei Starovoitov
On Tue, Mar 12, 2019 at 10:23:01AM -0700, Martin KaFai Lau wrote: > This set addresses issue about accessing invalid > ptr returned from bpf_tcp_sock() and bpf_sk_fullsock() > after bpf_sk_release(). > > v4: > - Tried the one "id" approach. It does not work well and the reason is in > the Patch

ethtool 5.0 released

2019-03-13 Thread John W. Linville
ethtool version 5.0 has been released. Home page: https://www.kernel.org/pub/software/network/ethtool/ Download link: https://www.kernel.org/pub/software/network/ethtool/ethtool-5.0.tar.xz Release notes: * Feature: don't report UFO on kernels v4.14 and above * Fix: zero initializ

Re: [PATCH net-next] net: use rcu_dereference_protected to fetch sk_dst_cache in sk_destruct

2019-03-13 Thread David Miller
net-next is closed

Re: [PATCH V1 net 0/2] net: ena: race condition bug fix and version update

2019-03-13 Thread David Miller
From: "Bshara, Saeed" Date: Wed, 13 Mar 2019 12:59:34 + > sorry for the late response. I agree that with stable versions the > driver version is not good indication for which exact code is > running. however, we have many users that port the latest ena > driver as-is from kernel sources into

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-13 Thread Jakub Kicinski
On Wed, 13 Mar 2019 17:22:43 +0100, Jiri Pirko wrote: > Wed, Mar 13, 2019 at 05:17:31PM CET, jakub.kicin...@netronome.com wrote: > >On Wed, 13 Mar 2019 07:07:01 +0100, Jiri Pirko wrote: > >> Tue, Mar 12, 2019 at 09:56:28PM CET, jakub.kicin...@netronome.com wrote: > >> >On Tue, 12 Mar 2019 15:02

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-13 Thread Jiri Pirko
Wed, Mar 13, 2019 at 05:03:17PM CET, sridhar.samudr...@intel.com wrote: >On 3/13/2019 12:37 AM, Jiri Pirko wrote: >> Wed, Mar 13, 2019 at 07:17:04AM CET, sridhar.samudr...@intel.com wrote: >> > >> > On 3/12/2019 7:02 AM, Jiri Pirko wrote: >> > >> > > >> > > > >> > > > > I originally planned to

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-13 Thread Jiri Pirko
Wed, Mar 13, 2019 at 05:17:31PM CET, jakub.kicin...@netronome.com wrote: >On Wed, 13 Mar 2019 07:07:01 +0100, Jiri Pirko wrote: >> Tue, Mar 12, 2019 at 09:56:28PM CET, jakub.kicin...@netronome.com wrote: >> >On Tue, 12 Mar 2019 15:02:39 +0100, Jiri Pirko wrote: >> >> Tue, Mar 12, 2019 at 03:10:54

Re: [PATCH 0/2] bpf: context casting for tail call and gtrace prog type

2019-03-13 Thread Brendan Gregg
On Tue, Mar 12, 2019 at 9:54 AM Kris Van Hees wrote: > > On Mon, Mar 11, 2019 at 11:03:10PM -0700, Brendan Gregg wrote: > > On Mon, Mar 11, 2019 at 8:24 PM Kris Van Hees > > wrote: > > > > > > On Mon, Mar 11, 2019 at 06:29:55PM -0700, Brendan Gregg wrote: > > > > On Mon, Mar 11, 2019 at 7:21 AM

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-13 Thread Jakub Kicinski
On Wed, 13 Mar 2019 07:07:01 +0100, Jiri Pirko wrote: > Tue, Mar 12, 2019 at 09:56:28PM CET, jakub.kicin...@netronome.com wrote: > >On Tue, 12 Mar 2019 15:02:39 +0100, Jiri Pirko wrote: > >> Tue, Mar 12, 2019 at 03:10:54AM CET, wrote: > >> >On Mon, 11 Mar 2019 09:52:04 +0100, Jiri Pirko wrote:

Re: [PATCH RFC v4 0/5] SCTP: Event skb list overhaul.

2019-03-13 Thread Marcelo Ricardo Leitner
On Mon, Mar 11, 2019 at 08:09:19PM -0700, David Miller wrote: > > This patch series eliminates the explicit reference to the skb list > implementation via skb->prev dereferences. > > The approach used is to pass a non-empty skb list around instead of an > event skb object which may or may not be

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-13 Thread Samudrala, Sridhar
On 3/13/2019 12:37 AM, Jiri Pirko wrote: Wed, Mar 13, 2019 at 07:17:04AM CET, sridhar.samudr...@intel.com wrote: On 3/12/2019 7:02 AM, Jiri Pirko wrote: I originally planned to implement sriov orchestration api in devlink too. Interesting, would you mind elaborating? I have to think a

RE: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver

2019-03-13 Thread Keller, Jacob E
> -Original Message- > From: Harini Katakam [mailto:hari...@xilinx.com] > Sent: Tuesday, March 12, 2019 11:00 PM > To: Keller, Jacob E > Cc: Paul Thomas ; netdev@vger.kernel.org > Subject: Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver > > Hi Paul, Jake, > On Wed, Mar 13, 2019 at 3:

RE: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver

2019-03-13 Thread Keller, Jacob E
> -Original Message- > From: Harini Katakam [mailto:hari...@xilinx.com] > Sent: Tuesday, March 12, 2019 10:40 PM > To: Paul Thomas > Cc: Keller, Jacob E ; netdev@vger.kernel.org > Subject: Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver > > Hi Paul, Jake, > On Wed, Mar 13, 2019 at 5:

[PATCH bpf] xsk: fix umem memory leak on cleanup

2019-03-13 Thread Björn Töpel
From: Björn Töpel When the umem is cleaned up, the task that created it might already be gone. If the task was gone, the xdp_umem_release function did not free the pages member of struct xdp_umem. It turned out that the task lookup was not needed at all; The code was a left-over when we moved fr

[PATCH net-next] net: use rcu_dereference_protected to fetch sk_dst_cache in sk_destruct

2019-03-13 Thread Xin Long
As Eric noticed, in .sk_destruct, sk->sk_dst_cache update is prevented, and no barrier is needed for this. So change to use rcu_dereference_protected() instead of rcu_dereference_check() to fetch sk_dst_cache in there. Reported-by: Eric Dumazet Signed-off-by: Xin Long --- net/decnet/af_decnet.c

Re: [RFC v1 01/19] net/i40e: Add peer register/unregister to struct i40e_netdev_priv

2019-03-13 Thread Jason Gunthorpe
On Tue, Mar 12, 2019 at 07:11:08PM -0700, Jeff Kirsher wrote: > > > I am assuming that the term PCI driver is being used to mean the PCI > > > subsystem in the kernel. If this assumption is wrong, please disregard > > > the next > > > paragraph, but the following points will still apply. > > > >

Re: [PATCH V1 net 0/2] net: ena: race condition bug fix and version update

2019-03-13 Thread Bshara, Saeed
David, sorry for the late response. I agree that with stable versions the driver version is not good indication for which exact code is running. however, we have many users that port the latest ena driver as-is from kernel sources into their older kernels, mainly to pull new ENA features (e.g.

[no subject]

2019-03-13 Thread Jessica
+Hey,i am Jessica ,How's everything with you,I have interest on you after going through your profile I really want to have a good friendship with you.Beside i have something very vital to tell you

Re: [bpf-next,02/11] xsk: introduce xdp_umem_page

2019-03-13 Thread Björn Töpel
On 2019-03-13 10:39, Jiri Slaby wrote: On 04. 06. 18, 14:05, Björn Töpel wrote: From: Björn Töpel The xdp_umem_page holds the address for a page. Trade memory for faster lookup. Later, we'll add DMA address here as well. ... --- a/include/net/xdp_sock.h +++ b/include/net/xdp_sock.h ... --

Re: [PATCH RFC v4 0/5] SCTP: Event skb list overhaul.

2019-03-13 Thread Neil Horman
On Mon, Mar 11, 2019 at 08:09:19PM -0700, David Miller wrote: > > This patch series eliminates the explicit reference to the skb list > implementation via skb->prev dereferences. > > The approach used is to pass a non-empty skb list around instead of an > event skb object which may or may not be

Re: [PATCH] 9p/net: fix memory leak in p9_client_create

2019-03-13 Thread Dominique Martinet
zhengbin wrote on Wed, Mar 13, 2019: > If msize is less than 4096, we should close and put trans, destroy > tagpool, not just free client. This patch fixes that. > > Fixes: 574d356b7a02 ("9p/net: put a lower bound on msize") > Reported-by: Hulk Robot > Signed-off-by: zhengbin Ack, definitely. T

为上帝的慈善工作捐款

2019-03-13 Thread roseemman9
为上帝的慈善工作捐款 我向你和你的家人致以亲切的问候。我是已故的Paul Emmanuel博士的遗体Rose Emmanuel女士最近,我的医生告诉我,由于手术已经进行了几个月的生活,尽管由于我的脊髓受损导致我目前的困境是多么令人不安。意外。了解了我的情况后,我决定将(2,500,000.00美元)的金额捐给慈善机构和个人以获得上帝的好工作,并帮助无母亲,少有特权以及寡妇的帮助,因为我是因为我的两个女儿已经死了,只有幸存的人才能继承这笔钱。我要求你做的就是协助保管这笔存放在保安公司保管的基金,然后再予以没收或宣布不能使用。我还决定,在该基金成功发行后,您应从基金中获得30%的资金。我收到

Re: [bpf-next,02/11] xsk: introduce xdp_umem_page

2019-03-13 Thread Jiri Slaby
On 04. 06. 18, 14:05, Björn Töpel wrote: > From: Björn Töpel > > The xdp_umem_page holds the address for a page. Trade memory for > faster lookup. Later, we'll add DMA address here as well. ... > --- a/include/net/xdp_sock.h > +++ b/include/net/xdp_sock.h ... > --- a/net/xdp/xdp_umem.c > +++ b/ne

[PATCHv2 net] pptp: dst_release sk_dst_cache in pptp_sock_destruct

2019-03-13 Thread Xin Long
sk_setup_caps() is called to set sk->sk_dst_cache in pptp_connect, so we have to dst_release(sk->sk_dst_cache) in pptp_sock_destruct, otherwise, the dst refcnt will leak. It can be reproduced by this syz log: r1 = socket$pptp(0x18, 0x1, 0x2) bind$pptp(r1, &(0x7f000100)={0x18, 0x2, {0x0, @

[PATCH] 9p/net: fix memory leak in p9_client_create

2019-03-13 Thread zhengbin
If msize is less than 4096, we should close and put trans, destroy tagpool, not just free client. This patch fixes that. Fixes: 574d356b7a02 ("9p/net: put a lower bound on msize") Reported-by: Hulk Robot Signed-off-by: zhengbin --- net/9p/client.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

2019-03-13 Thread Jiri Pirko
Wed, Mar 13, 2019 at 07:17:04AM CET, sridhar.samudr...@intel.com wrote: > >On 3/12/2019 7:02 AM, Jiri Pirko wrote: > >> >> > >> > > I originally planned to implement sriov orchestration api in devlink too. >> > >> > Interesting, would you mind elaborating? >> >> I have to think about it. But so