From: Vakul Garg <vakul.g...@nxp.com>
Date: Tue, 12 Mar 2019 08:22:57 +0000

> A previous fix ("tls: Fix write space handling") assumed that
> user space application gets informed about the socket send buffer
> availability when tls_push_sg() gets called. Inside tls_push_sg(), in
> case do_tcp_sendpages() returns 0, the function returns without calling
> ctx->sk_write_space. Further, the new function tls_sw_write_space()
> did not invoke ctx->sk_write_space. This leads to situation that user
> space application encounters a lockup always waiting for socket send
> buffer to become available.
> 
> Rather than call ctx->sk_write_space from tls_push_sg(), it should be
> called from tls_write_space. So whenever tcp stack invokes
> sk->sk_write_space after freeing socket send buffer, we always declare
> the same to user space by the way of invoking ctx->sk_write_space.
> 
> Fixes: 7463d3a2db0ef ("tls: Fix write space handling")
> Signed-off-by: Vakul Garg <vakul.g...@nxp.com>
> Reviewed-by: Boris Pismenny <bor...@mellanox.com>

Applied, thanks Vakul.

Reply via email to