Resource management for ndo_xdp_xmit (Was: [PATCH net] virtio_net: Account for tx bytes and packets on sending xdp_frames)

2019-02-06 Thread Jesper Dangaard Brouer
On Wed, 6 Feb 2019 00:06:33 + Saeed Mahameed wrote: > On Mon, 2019-02-04 at 19:13 -0800, David Ahern wrote: [...] > > > > mlx5 needs some work. As I recall it still has the bug/panic > > removing xdp programs - at least I don't recall seeing a patch for > > it. > > Only when xdp_redirec

[PATCH net-next 0/2] Change tc action identifiers to be more consistent

2019-02-06 Thread Eli Cohen
This two patch series modifies TC actions identifiers to be more consistent and also puts them in one place so new identifiers numbers can be chosen more easily. Eli Cohen (2): net: Move all TC actions identifiers to one place net: Change TCA_ACT_* to TCA_ID_* to match that of TCA_ID_POLICE

[PATCH net-next 1/2] net: Move all TC actions identifiers to one place

2019-02-06 Thread Eli Cohen
Move all the TC identifiers to one place, to the same enum that defines the identifier of police action. This makes it easier choose numbers for new actions since they are now defined in one place. We preserve the original values for binary compatibility. New IDs should be added inside the enum. S

Re: [PATCH bpf-next v2] tools/bpf: add log_level to bpf_load_program_attr

2019-02-06 Thread Yonghong Song
On 2/6/19 10:53 PM, Alexei Starovoitov wrote: > On Wed, Feb 06, 2019 at 10:15:50PM -0800, Yonghong Song wrote: >> The kernel verifier has three levels of logs: >> 0: no logs >> 1: logs mostly useful >>> 1: verbose >> >> Current libbpf API functions bpf_load_program_xattr() and >> bp

[PATCH net-next 2/2] net: Change TCA_ACT_* to TCA_ID_* to match that of TCA_ID_POLICE

2019-02-06 Thread Eli Cohen
Modify the kernel users of the TCA_ACT_* macros to use TCA_ID_*. For example, use TCA_ID_GACT instead of TCA_ACT_GACT. This will align with TCA_ID_POLICE and also differentiates these identifier, used in struct tc_action_ops type field, from other macros starting with TCA_ACT_. To make things clea

Re: [PATCH 1/2] xsk: do not use mmap_sem

2019-02-06 Thread Björn Töpel
Den tors 7 feb. 2019 kl 06:38 skrev Davidlohr Bueso : > > Holding mmap_sem exclusively for a gup() is an overkill. > Lets replace the call for gup_fast() and let the mm take > it if necessary. > > Cc: David S. Miller > Cc: Bjorn Topel > Cc: Magnus Karlsson > CC: netdev@vger.kernel.org > Signed-o

Re: [PATCH bpf-next 1/6] bpf: Add a bpf_sock pointer to __sk_buff and a bpf_sk_fullsock helper

2019-02-06 Thread Martin Lau
On Mon, Feb 04, 2019 at 04:50:32PM -0800, Martin Lau wrote: > On Mon, Feb 04, 2019 at 11:33:28PM +0100, Daniel Borkmann wrote: > > Hi Martin, > > > > On 02/01/2019 08:03 AM, Martin KaFai Lau wrote: > > > In kernel, it is common to check "!skb->sk && sk_fullsock(skb->sk)" > > > before accessing the

Re: [PATCH bpf-next v2] tools/bpf: add log_level to bpf_load_program_attr

2019-02-06 Thread Alexei Starovoitov
On Wed, Feb 06, 2019 at 10:15:50PM -0800, Yonghong Song wrote: > The kernel verifier has three levels of logs: > 0: no logs > 1: logs mostly useful > > 1: verbose > > Current libbpf API functions bpf_load_program_xattr() and > bpf_load_program() cannot specify log_level. > The bcc, howev

Re: [PATCH] ipmr: ip6mr: Create new sockopt to clear mfc cache only

2019-02-06 Thread Nikolay Aleksandrov
On 07/02/2019 04:08, Callum Sinclair wrote: > Currently the only way to clear the mfc cache was to delete the entries > one by one using the MRT_DEL_MFC socket option or to destroy and > recreate the socket. > > Create a new socket option which will clear the multicast forwarding > cache on the so

[PATCH bpf-next v2] tools/bpf: add log_level to bpf_load_program_attr

2019-02-06 Thread Yonghong Song
The kernel verifier has three levels of logs: 0: no logs 1: logs mostly useful > 1: verbose Current libbpf API functions bpf_load_program_xattr() and bpf_load_program() cannot specify log_level. The bcc, however, provides an interface for user to specify log_level 2 for verbose output.

Re: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized

2019-02-06 Thread Yizhuo Zhai
Thanks, but why initialization matters here? Is performance the main concern? On Wed, Feb 6, 2019 at 9:52 PM Yizhuo Zhai wrote: > > Thanks, but why initialization matters here? Is performance the main concern? > > On Wed, Feb 6, 2019 at 8:17 PM David Miller wrote: >> >> From: Yizhuo >> Date: T

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-06 Thread Eli Britstein
On 2/5/2019 10:23 PM, Ben Pfaff wrote: > On Tue, Feb 05, 2019 at 10:22:09AM -0800, Gregory Rose wrote: >> On 2/5/2019 4:02 AM, Eli Britstein wrote: >>> On 2/4/2019 10:07 PM, David Miller wrote: From: Yi-Hung Wei Date: Mon, 4 Feb 2019 10:47:18 -0800 > For example, to see how 'st

[PATCH v2 net-next] net: phy: fixed_phy: Fix fixed_phy not checking GPIO

2019-02-06 Thread Moritz Fischer
Fix fixed_phy not checking GPIO if no link_update callback is registered. In the original version all users registered a link_update callback so the issue was masked. Fixes: a5597008dbc2 ("phy: fixed_phy: Add gpio to determine link up/down.") Reviewed-by: Andrew Lunn Signed-off-by: Moritz Fische

[PATCH 1/2] xsk: do not use mmap_sem

2019-02-06 Thread Davidlohr Bueso
Holding mmap_sem exclusively for a gup() is an overkill. Lets replace the call for gup_fast() and let the mm take it if necessary. Cc: David S. Miller Cc: Bjorn Topel Cc: Magnus Karlsson CC: netdev@vger.kernel.org Signed-off-by: Davidlohr Bueso --- net/xdp/xdp_umem.c | 6 ++ 1 file change

Re: Stack sends oversize UDP packet to the driver

2019-02-06 Thread महेश बंडेवार
On Tue, Feb 5, 2019 at 11:36 AM Michael Chan wrote: > > On Wed, Jan 30, 2019 at 5:00 PM Mahesh Bandewar (महेश बंडेवार) > wrote: > > > > On Wed, Jan 30, 2019 at 1:07 AM Michael Chan > > wrote: > > > > > > On Tue, Jan 22, 2019 at 10:29 AM Mahesh Bandewar (महेश बंडेवार) > > > wrote: > > > > > > >

RE: [PATCH v2] arm64: dts: lx2160aqds: Add mdio mux nodes

2019-02-06 Thread Pankaj Bansal
> -Original Message- > From: Li Yang [mailto:leoyang...@nxp.com] > Sent: Thursday, 7 February, 2019 05:09 AM > To: Andrew Lunn > Cc: Pankaj Bansal ; Shawn Guo > ; Florian Fainelli ; > netdev@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Rob Herring > > Subject: Re: [PATCH v2] a

Re: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized

2019-02-06 Thread David Miller
From: Yizhuo Date: Tue, 5 Feb 2019 14:15:59 -0800 > @@ -639,9 +639,14 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv > *priv) > struct sunxi_priv_data *gmac = priv->plat->bsp_priv; > struct device_node *node = priv->device->of_node; > int ret; > - u32 reg, val; >

Re: [PATCH v3] net: emac: remove IBM_EMAC_RX_SKB_HEADROOM

2019-02-06 Thread David Miller
From: Christian Lamparter Date: Tue, 5 Feb 2019 22:20:09 +0100 > The EMAC driver had a custom IBM_EMAC_RX_SKB_HEADROOM > Kconfig option that reserved additional skb headroom for RX. > This patch removes the option and migrates the code > to use napi_alloc_skb() and netdev_alloc_skb_ip_align() >

Re: [PATCH] net: Don't default Cavium PTP driver to 'y'

2019-02-06 Thread David Miller
From: Bjorn Helgaas Date: Tue, 05 Feb 2019 14:47:21 -0600 > From: Bjorn Helgaas > > 8c56df372bc1 ("net: add support for Cavium PTP coprocessor") added the > Cavium PTP coprocessor driver and enabled it by default. Remove the > "default y" because the driver only applies to Cavium ThunderX proc

Re: [PATCH v2 net-next] net: phy: improve genphy_c45_read_link

2019-02-06 Thread David Miller
From: Heiner Kallweit Date: Tue, 5 Feb 2019 20:41:37 +0100 > Let's make genphy_c45_read_link behave the same as genphy_update_link > and set phydev->link in the function directly. This allows to simplify > the callers. In addition don't check further devices once we detect > that at least one dev

Re: general protection fault in __bfs (2)

2019-02-06 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:8834f5600cf3 Linux 5.0-rc5 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=143fd61f40 kernel config: https://syzkaller.appspot.com/x/.config?x=8f00801d7b7c4fe6 dashboard link: https:/

Re: [PATCH net-next] net: phy: fixed_phy: Fix fixed_phy not checking GPIO

2019-02-06 Thread Andrew Lunn
On Wed, Feb 06, 2019 at 10:10:40AM -0800, Moritz Fischer wrote: > Fix fixed_phy not checking GPIO if no link_update callback > is registered. > > Signed-off-by: Moritz Fischer Fixes: a5597008dbc2 ("phy: fixed_phy: Add gpio to determine link up/down.") Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next] net: phy: fixed_phy: Fix fixed_phy not checking GPIO

2019-02-06 Thread Andrew Lunn
On Wed, Feb 06, 2019 at 10:10:40AM -0800, Moritz Fischer wrote: > Fix fixed_phy not checking GPIO if no link_update callback > is registered. > > Signed-off-by: Moritz Fischer > --- > > Hi all, > > I've been trying to figure out where exactly this broke, > it must've been somewhere when the fil

ipmr: ip6mr: Create new sockopt to clear mfc cache only

2019-02-06 Thread Callum Sinclair
Created a way to clear the multicast forwarding cache on a socket without having to either remove the entries manually using the delete entry socket option or destroy and recreate the multicast socket. Using the flags MRT_FLUSH_ENTRIES and MRT_FLUSH_VIFS, all multicast entries can be cleared, all

[PATCH] ipmr: ip6mr: Create new sockopt to clear mfc cache only

2019-02-06 Thread Callum Sinclair
Currently the only way to clear the mfc cache was to delete the entries one by one using the MRT_DEL_MFC socket option or to destroy and recreate the socket. Create a new socket option which will clear the multicast forwarding cache on the socket without destroying the socket. Signed-off-by: Call

Re: Waiting for vrf to become free on rmmod of bridge...

2019-02-06 Thread David Ahern
On 2/6/19 3:20 PM, Ben Greear wrote: > Hello, > > I just saw this warning on a system running a hacked 4.20.2+ kernel.  > Any known bugs > of this nature in this (upstream) kernel?  The command that is blocked is: > 'rmmod bridge llc' > > [17069.299135] unregister_netdevice: waiting for _vrf13 to

Re: [PATCH net] net: sun: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-02-06 Thread Yanjun Zhu
On 2019/2/6 0:19, Yang Wei wrote: From: Yang Wei dev_consume_skb_irq() should be called when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Thanks a lot. I am OK. Zhu Yanjun Signed-off-by: Yang Wei --- drivers/net/ethernet/sun/cassini.c | 2 +- drivers/net/eth

Re: [PATCH net] net: tulip: de2104x: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-02-06 Thread David Miller
From: Yang Wei Date: Wed, 6 Feb 2019 00:03:51 +0800 > From: Yang Wei > > dev_consume_skb_irq() should be called in de_tx() when skb xmit > done. It makes drop profiles(dropwatch, perf) more friendly. > > Signed-off-by: Yang Wei Applied.

Re: [PATCH net] net: broadcom: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-02-06 Thread David Miller
From: Yang Wei Date: Wed, 6 Feb 2019 00:25:54 +0800 > From: Yang Wei > > dev_consume_skb_irq() should be called in sbdma_tx_process() when > skb xmit done. It makes drop profiles(dropwatch, perf) more > friendly. > > Signed-off-by: Yang Wei Applied.

Re: [PATCH net] net: fsl_ucc_hdlc: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-02-06 Thread David Miller
From: Yang Wei Date: Wed, 6 Feb 2019 00:14:51 +0800 > From: Yang Wei > > dev_consume_skb_irq() should be called in hdlc_tx_done() when skb > xmit done. It makes drop profiles(dropwatch, perf) more friendly. > > Signed-off-by: Yang Wei Applied.

Re: [PATCH net] net: sun: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-02-06 Thread David Miller
From: Yang Wei Date: Wed, 6 Feb 2019 00:19:44 +0800 > From: Yang Wei > > dev_consume_skb_irq() should be called when skb xmit done. It makes > drop profiles(dropwatch, perf) more friendly. > > Signed-off-by: Yang Wei Applied.

Re: [PATCH net] net: via-velocity: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-02-06 Thread David Miller
From: Yang Wei Date: Wed, 6 Feb 2019 00:22:54 +0800 > From: Yang Wei > > dev_consume_skb_irq() should be called in velocity_free_tx_buf() > when skb xmit done. It makes drop profiles(dropwatch, perf) more > friendly. > > Signed-off-by: Yang Wei Applied.

Re: [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-02-06 Thread David Miller
From: Yang Wei Date: Wed, 6 Feb 2019 00:01:04 +0800 > From: Yang Wei > > dev_consume_skb_irq() should be called in dfx_xmt_done() when skb > xmit done. It makes drop profiles(dropwatch, perf) more friendly. > > Signed-off-by: Yang Wei Applied.

Re: [PATCH net] net: tehuti: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-02-06 Thread David Miller
From: Yang Wei Date: Wed, 6 Feb 2019 00:21:31 +0800 > From: Yang Wei > > dev_consume_skb_irq() should be called in bdx_tx_cleanup() when skb > xmit done. It makes drop profiles(dropwatch, perf) more friendly. > > Signed-off-by: Yang Wei Applied.

Re: [PATCH net] net: fec_mpc52xx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-02-06 Thread David Miller
From: Yang Wei Date: Wed, 6 Feb 2019 00:12:04 +0800 > From: Yang Wei > > dev_consume_skb_irq() should be called in mpc52xx_fec_tx_interrupt() > when skb xmit done. It makes drop profiles(dropwatch, perf) more > friendly. > > Signed-off-by: Yang Wei Applied.

Re: [PATCH net] net: smsc: epic100: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-02-06 Thread David Miller
From: Yang Wei Date: Wed, 6 Feb 2019 00:09:41 +0800 > From: Yang Wei > > dev_consume_skb_irq() should be called in epic_tx() when skb xmit > done. It makes drop profiles(dropwatch, perf) more friendly. > > Signed-off-by: Yang Wei Applied.

Re: [PATCH net] net: dscc4: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-02-06 Thread David Miller
From: Yang Wei Date: Wed, 6 Feb 2019 00:07:03 +0800 > From: Yang Wei > > dev_consume_skb_irq() should be called in dscc4_tx_irq() when skb > xmit done. It makes drop profiles(dropwatch, perf) more friendly. > > Signed-off-by: Yang Wei Applied.

Re: [PATCH 1/2] net: phylink: update mac_config() documentation

2019-02-06 Thread David Miller
These two patches do not apply cleanly to net nor net-next. Please send me something that does apply, and please always clearly indicate which tree your changes are targetting.

Re: [net-next, PATCH] net: stmmac: fix ptp timestamping on Rx on gmac4

2019-02-06 Thread David Miller
From: Ilias Apalodimas Date: Tue, 5 Feb 2019 14:15:20 +0200 > The current driver only enables Pdelay_Req and Pdelay_Resp when > HWTSTAMP_FILTER_PTP_V2_EVENT, HWTSTAMP_FILTER_PTP_V1_L4_EVENT or > HWTSTAMP_FILTER_PTP_V2_L4_EVENT is requested. This results in ptp sync on > slave mode to report 'rec

Re: [PATCH v3 net-next 00/11] Devlink health reporting and recovery system

2019-02-06 Thread David Miller
This no longer applies cleanly to net-next, please respin. Thank you.

Re: [PATCH net-next v3] net: dsa: mv88e6xxx: Prevent suspend to RAM

2019-02-06 Thread David Miller
From: Miquel Raynal Date: Tue, 5 Feb 2019 12:07:28 +0100 > On one hand, the mv88e6xxx driver has a work queue called in loop > which will attempt register accesses after MDIO bus suspension, that > entirely freezes the platform during suspend. > > On the other hand, the DSA core is not ready ye

Re: [PATCH net v5 1/2] net/mlx5e: Update hw flows when encap source mac changed

2019-02-06 Thread David Miller
From: Or Gerlitz Date: Tue, 5 Feb 2019 11:03:01 +0200 > Dave, I see a copy of the patch on patchworks [1] with status being > not applicable, what is missing here? the patch should apply AFAIK. > There was also another patch reviewed here by me and Saeed [2], not > sure where it stands from your

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Saeed Mahameed
On Wed, Feb 6, 2019 at 3:00 PM Ian Kumlien wrote: > > On Wed, Feb 6, 2019 at 11:49 PM Cong Wang wrote: > > > > On Wed, Feb 6, 2019 at 2:41 PM Ian Kumlien wrote: > > > > > > On Wed, Feb 6, 2019 at 11:38 PM Cong Wang > > > wrote: > > > > On Wed, Feb 6, 2019 at 2:15 PM Ian Kumlien > > > > wrote

Re: [net-next][PATCH 0/5] rds: add tos support

2019-02-06 Thread David Miller
From: Santosh Shilimkar Date: Mon, 4 Feb 2019 16:04:44 -0800 > RDS applications make use of tos to classify database traffic. > This feature has been used in shipping products from 2.6.32 based > kernels. Its tied with RDS v4.1 protocol version and the compatibility > gets negotiated as part of

Re: [Patch net-next v2] mlx5: use RCU lock in mlx5_eq_cq_get()

2019-02-06 Thread Saeed Mahameed
On Wed, Feb 6, 2019 at 4:53 PM Cong Wang wrote: > > On Wed, Feb 6, 2019 at 4:28 PM Eric Dumazet wrote: > > > > > > > > On 02/06/2019 04:04 PM, Cong Wang wrote: > > > > > synchronize_irq() is called before mlx5_cq_put(), so I don't > > > see why readers could get 0 refcnt. > > > > Then the more re

Re: pull-request: bpf-next 2019-02-07

2019-02-06 Thread David Miller
From: Daniel Borkmann Date: Thu, 7 Feb 2019 01:42:30 +0100 > The following pull-request contains BPF updates for your *net-next* tree. > > The main changes are: > > 1) Add a riscv64 JIT for BPF, from Björn. Awesome. > 2) Implement BTF deduplication algorithm for libbpf which takes BTF type >

Re: [PATCH net 1/2] geneve: should not call rt6_lookup() when ipv6 was disabled

2019-02-06 Thread kbuild test robot
Hi Hangbin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Hangbin-Liu/fix-two-kernel-panics-when-disabled-IPv6-on-boot-up/20190207-071954 config: m68k-sun3_defconfig (attached as .config) compiler:

linux-next: manual merge of the net-next tree with the net tree

2019-02-06 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/mellanox/mlx5/core/en_tc.c between commit: 1651925d403e ("net/mlx5e: Use the inner headers to determine tc/pedit offload limitation on decap flows") from the net tree and commit: 738678817573

Re: [PATCH net 0/6] qed*: Bug fixes.

2019-02-06 Thread David Miller
From: Manish Chopra Date: Wed, 6 Feb 2019 14:43:41 -0800 > This series contains general qed/qede fixes. > Please consider applying this to "net" Series applied, thanks Manish.

Re: [Patch net-next v2] mlx5: use RCU lock in mlx5_eq_cq_get()

2019-02-06 Thread Cong Wang
On Wed, Feb 6, 2019 at 4:28 PM Eric Dumazet wrote: > > > > On 02/06/2019 04:04 PM, Cong Wang wrote: > > > synchronize_irq() is called before mlx5_cq_put(), so I don't > > see why readers could get 0 refcnt. > > Then the more reasons to get rid of the refcount increment/decrement > completely ...

Re: [Patch net-next v2] mlx5: use RCU lock in mlx5_eq_cq_get()

2019-02-06 Thread Saeed Mahameed
On Wed, Feb 6, 2019 at 4:28 PM Eric Dumazet wrote: > > > > On 02/06/2019 04:04 PM, Cong Wang wrote: > > > synchronize_irq() is called before mlx5_cq_put(), so I don't > > see why readers could get 0 refcnt. > > Then the more reasons to get rid of the refcount increment/decrement > completely ...

Re: [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation

2019-02-06 Thread Christian Lamparter
On Wednesday, February 6, 2019 11:29:18 PM CET Florian Fainelli wrote: > On 2/6/19 1:57 PM, Christian Lamparter wrote: > > On Tuesday, February 5, 2019 11:29:36 PM CET Florian Fainelli wrote: > >> On 2/5/19 2:12 PM, Christian Lamparter wrote: > >>> On Tuesday, February 5, 2019 10:29:34 PM CET Andre

pull-request: bpf-next 2019-02-07

2019-02-06 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Add a riscv64 JIT for BPF, from Björn. 2) Implement BTF deduplication algorithm for libbpf which takes BTF type information containing duplicate per-compilation unit information and

[PATCH bpf-next v7 3/6] bpf: handle GSO in bpf_lwt_push_encap

2019-02-06 Thread Peter Oskolkov
This patch adds handling of GSO packets in bpf_lwt_push_ip_encap() (called from bpf_lwt_push_encap): * IPIP, GRE, and UDP encapsulation types are deduced by looking into iphdr->protocol or ipv6hdr->next_header; * an error is returned if the same GSO encap type is set on the skb; * SCTP GSO packe

[PATCH bpf-next v7 2/6] bpf: implement BPF_LWT_ENCAP_IP mode in bpf_lwt_push_encap

2019-02-06 Thread Peter Oskolkov
This patch implements BPF_LWT_ENCAP_IP mode in bpf_lwt_push_encap BPF helper. It enables BPF programs (specifically, BPF_PROG_TYPE_LWT_IN and BPF_PROG_TYPE_LWT_XMIT prog types) to add IP encapsulation headers to packets (e.g. IP/GRE, GUE, IPIP). This is useful when thousands of different short-liv

[PATCH bpf-next v7 4/6] bpf: add handling of BPF_LWT_REROUTE to lwt_bpf.c

2019-02-06 Thread Peter Oskolkov
This patch builds on top of the previous patch in the patchset, which added BPF_LWT_ENCAP_IP mode to bpf_lwt_push_encap. As the encapping can result in the skb needing to go via a different interface/route/dst, bpf programs can indicate this by returning BPF_LWT_REROUTE, which triggers a new route

[PATCH bpf-next v7 6/6] selftests: bpf: add test_lwt_ip_encap selftest

2019-02-06 Thread Peter Oskolkov
This patch adds a bpf self-test to cover BPF_LWT_ENCAP_IP mode in bpf_lwt_push_encap. Covered: - encapping in LWT_IN and LWT_XMIT - IPv4 and IPv6 A follow-up patch will add VRF-enabled tests. Signed-off-by: Peter Oskolkov --- tools/testing/selftests/bpf/Makefile | 6 +- .../testing/

[PATCH bpf-next v7 5/6] bpf: sync /include/.../bpf.h with tools/include/.../bpf.h

2019-02-06 Thread Peter Oskolkov
This patch copies changes in bpf.h done by a previous patch in this patchset from the kernel uapi include dir into tools uapi include dir. Signed-off-by: Peter Oskolkov --- tools/include/uapi/linux/bpf.h | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --gi

[PATCH bpf-next v7 1/6] bpf: add plumbing for BPF_LWT_ENCAP_IP in bpf_lwt_push_encap

2019-02-06 Thread Peter Oskolkov
This patch adds all needed plumbing in preparation to allowing bpf programs to do IP encapping via bpf_lwt_push_encap. Actual implementation is added in the next patch in the patchset. Of note: - bpf_lwt_push_encap can now be called from BPF_PROG_TYPE_LWT_XMIT prog types in addition to BPF_PROG_

[PATCH bpf-next v7 0/6] bpf: add BPF_LWT_ENCAP_IP option to bpf_lwt_push_encap

2019-02-06 Thread Peter Oskolkov
This patchset implements BPF_LWT_ENCAP_IP mode in bpf_lwt_push_encap BPF helper. It enables BPF programs (specifically, BPF_PROG_TYPE_LWT_IN and BPF_PROG_TYPE_LWT_XMIT prog types) to add IP encapsulation headers to packets (e.g. IP/GRE, GUE, IPIP). This is useful when thousands of different short-

Re: [Patch net-next v2] mlx5: use RCU lock in mlx5_eq_cq_get()

2019-02-06 Thread Eric Dumazet
On 02/06/2019 04:04 PM, Cong Wang wrote: > synchronize_irq() is called before mlx5_cq_put(), so I don't > see why readers could get 0 refcnt. Then the more reasons to get rid of the refcount increment/decrement completely ... Technically, even the rcu_read_lock() and rcu_read_unlock() are no

Re: [Patch net-next v2] mlx5: use RCU lock in mlx5_eq_cq_get()

2019-02-06 Thread Cong Wang
On Wed, Feb 6, 2019 at 3:36 PM Eric Dumazet wrote: > > > > On 02/06/2019 03:00 PM, Cong Wang wrote: > > mlx5_eq_cq_get() is called in IRQ handler, the spinlock inside > > gets a lot of contentions when we test some heavy workload > > with 60 RX queues and 80 CPU's, and it is clearly shown in the >

[PATCH mac80211-next] virt_wifi: Remove REGULATORY_WIPHY_SELF_MANAGED

2019-02-06 Thread Cody Schuffelen
REGULATORY_WIPHY_SELF_MANAGED as set here breaks NL80211_CMD_GET_REG, because it expects the wiphy to do regulatory management. Since virt_wifi does not do regulatory management, this triggers a WARN_ON in NL80211_CMD_GET_REG and fails the netlink command. Removing REGULATORY_WIPHY_SELF_MANAGED fi

Re: [Patch net-next v2] mlx5: use RCU lock in mlx5_eq_cq_get()

2019-02-06 Thread Eric Dumazet
On 02/06/2019 03:36 PM, Eric Dumazet wrote: > > I suspect that you need a variant that makes sure refcount is not zero. > > ( Typical RCU rules apply ) > > if (cq && !refcount_inc_not_zero(&cq->refcount)) > cq = NULL; > > > See commit 6fa19f5637a6c22bc0999596bcc83bdcac8a4fa6 rds: fix

Re: [PATCH v2] arm64: dts: lx2160aqds: Add mdio mux nodes

2019-02-06 Thread Li Yang
On Wed, Feb 6, 2019 at 3:46 PM Andrew Lunn wrote: > > > > > > &i2c0 { > > > > > status = "okay"; > > > > > > > > > > + fpga@66 { > > > > > + compatible = "fsl,lx2160aqds-fpga", > > > > > "fsl,fpga-qixis-i2c"; > > > > > + reg = <0x66>; > > > > > +

Re: [Patch net-next v2] mlx5: use RCU lock in mlx5_eq_cq_get()

2019-02-06 Thread Eric Dumazet
On 02/06/2019 03:00 PM, Cong Wang wrote: > mlx5_eq_cq_get() is called in IRQ handler, the spinlock inside > gets a lot of contentions when we test some heavy workload > with 60 RX queues and 80 CPU's, and it is clearly shown in the > flame graph. > > In fact, radix_tree_lookup() is perfectly fi

Waiting for vrf to become free on rmmod of bridge...

2019-02-06 Thread Ben Greear
Hello, I just saw this warning on a system running a hacked 4.20.2+ kernel. Any known bugs of this nature in this (upstream) kernel? The command that is blocked is: 'rmmod bridge llc' [17069.299135] unregister_netdevice: waiting for _vrf13 to become free. Usage count = 1 [17079.306438] unreg

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Ian Kumlien
On Wed, Feb 6, 2019 at 11:49 PM Cong Wang wrote: > > On Wed, Feb 6, 2019 at 2:41 PM Ian Kumlien wrote: > > > > On Wed, Feb 6, 2019 at 11:38 PM Cong Wang wrote: > > > On Wed, Feb 6, 2019 at 2:15 PM Ian Kumlien wrote: > > > > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking

[Patch net-next v2] mlx5: use RCU lock in mlx5_eq_cq_get()

2019-02-06 Thread Cong Wang
mlx5_eq_cq_get() is called in IRQ handler, the spinlock inside gets a lot of contentions when we test some heavy workload with 60 RX queues and 80 CPU's, and it is clearly shown in the flame graph. In fact, radix_tree_lookup() is perfectly fine with RCU read lock, we don't have to take a spinlock

Re: [Patch net-next] mlx5: use RCU lock in mlx5_eq_cq_get()

2019-02-06 Thread Cong Wang
On Wed, Feb 6, 2019 at 9:40 AM Saeed Mahameed wrote: > > On Wed, 2019-02-06 at 09:35 -0800, Saeed Mahameed wrote: > > On Tue, 2019-02-05 at 16:35 -0800, Cong Wang wrote: > > > mlx5_eq_cq_get() is called in IRQ handler, the spinlock inside > > > gets a lot of contentions when we test some heavy wor

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Cong Wang
On Wed, Feb 6, 2019 at 2:41 PM Ian Kumlien wrote: > > On Wed, Feb 6, 2019 at 11:38 PM Cong Wang wrote: > > On Wed, Feb 6, 2019 at 2:15 PM Ian Kumlien wrote: > > > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking > > > things > > > > It doesn't break anything, packets are _n

[PATCH net 4/6] qede: Fix system crash on configuring channels.

2019-02-06 Thread Manish Chopra
From: Sudarsana Reddy Kalluru Under heavy traffic load, when changing number of channels via ethtool (ethtool -L) which will cause interface to be reloaded, it was observed that some packets gets transmitted on old TX channel/queue id which doesn't really exist after the channel configuration lea

[PATCH net 2/6] qed: Assign UFP TC value to vlan priority in UFP mode.

2019-02-06 Thread Manish Chopra
From: Sudarsana Reddy Kalluru In the case of Unified Fabric Port (UFP) mode, switch provides the traffic class (TC) value to be used for the traffic. Configure hardware to use this TC value for vlan priority. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/et

[PATCH net 5/6] qed: Change verbosity for coalescing message.

2019-02-06 Thread Manish Chopra
From: Rahul Verma Fix unnecessary logging of message in an expected default case where coalescing value read (via ethtool -c) migh not be valid unless they are configured explicitly in the hardware using ethtool -C. Signed-off-by: Rahul Verma Signed-off-by: Manish Chopra Signed-off-by: Ariel E

[PATCH net 3/6] qed: Consider TX tcs while deriving the max num_queues for PF.

2019-02-06 Thread Manish Chopra
From: Sudarsana Reddy Kalluru Max supported queues is derived incorrectly in the case of multi-CoS. Need to consider TCs while calculating num_queues for PF. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 5 +++-- 1 file change

[PATCH net 6/6] qed*: Advance drivers version to 8.37.0.20

2019-02-06 Thread Manish Chopra
Version update for qed/qede modules. Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed.h | 2 +- drivers/net/ethernet/qlogic/qede/qede.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed.h

[PATCH net 1/6] qed: Fix EQ full firmware assert.

2019-02-06 Thread Manish Chopra
When slowpath messages are sent with high rate, the resulting events can lead to a FW assert in case they are not handled fast enough (Event Queue Full assert). Attempt to send queued slowpath messages only after the newly evacuated entries in the EQ ring are indicated to FW. Signed-off-by: Manish

[PATCH net 0/6] qed*: Bug fixes.

2019-02-06 Thread Manish Chopra
Hi David, This series contains general qed/qede fixes. Please consider applying this to "net" Thanks, Manish Manish Chopra (2): qed: Fix EQ full firmware assert. qed*: Advance drivers version to 8.37.0.20 Rahul Verma (1): qed: Change verbosity for coalescing message. Sudarsana Reddy Kall

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Ian Kumlien
On Wed, Feb 6, 2019 at 11:38 PM Cong Wang wrote: > On Wed, Feb 6, 2019 at 2:15 PM Ian Kumlien wrote: > > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking things > > It doesn't break anything, packets are _not_ dropped, only that the > warning itself is noisy. Not my experien

Re: [RFC net-next] net: fixed_phy: Move the DT based link GPIO parsing to of_mdio.c

2019-02-06 Thread Florian Fainelli
On 2/6/19 2:38 PM, Moritz Fischer wrote: > Hi Andrew, > > thanks for your feedback. > > On Wed, Feb 06, 2019 at 10:53:22PM +0100, Andrew Lunn wrote: >> On Wed, Feb 06, 2019 at 12:51:06PM -0800, Moritz Fischer wrote: >>> Move the DT based link GPIO parsing to of_mdio and let the places >>> that re

Re: [RFC net-next] net: fixed_phy: Move the DT based link GPIO parsing to of_mdio.c

2019-02-06 Thread Moritz Fischer
Hi Andrew, thanks for your feedback. On Wed, Feb 06, 2019 at 10:53:22PM +0100, Andrew Lunn wrote: > On Wed, Feb 06, 2019 at 12:51:06PM -0800, Moritz Fischer wrote: > > Move the DT based link GPIO parsing to of_mdio and let the places > > that register a fixed_phy pass in a GPIO descriptor or NULL

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Cong Wang
On Wed, Feb 6, 2019 at 2:15 PM Ian Kumlien wrote: > > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking things It doesn't break anything, packets are _not_ dropped, only that the warning itself is noisy.

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Ian Kumlien
On Wed, Feb 6, 2019 at 11:22 PM David Miller wrote: > > From: Ian Kumlien > Date: Wed, 6 Feb 2019 23:12:53 +0100 > > > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking things > > Its... there: > > https://patchwork.ozlabs.org/bundle/davem/stable/?series=&submitter=&state=*&q=

Re: [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation

2019-02-06 Thread Florian Fainelli
On 2/6/19 2:29 PM, Florian Fainelli wrote: > On 2/6/19 1:57 PM, Christian Lamparter wrote: >> On Tuesday, February 5, 2019 11:29:36 PM CET Florian Fainelli wrote: >>> On 2/5/19 2:12 PM, Christian Lamparter wrote: On Tuesday, February 5, 2019 10:29:34 PM CET Andrew Lunn wrote: >> For now, I

Re: [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation

2019-02-06 Thread Florian Fainelli
On 2/6/19 1:57 PM, Christian Lamparter wrote: > On Tuesday, February 5, 2019 11:29:36 PM CET Florian Fainelli wrote: >> On 2/5/19 2:12 PM, Christian Lamparter wrote: >>> On Tuesday, February 5, 2019 10:29:34 PM CET Andrew Lunn wrote: > For now, I added the DT binding update to the patch as well

Re: [PATCH net-next] net: phy: fixed_phy: Fix fixed_phy not checking GPIO

2019-02-06 Thread Moritz Fischer
Hi Andrew, On Wed, Feb 06, 2019 at 10:59:05PM +0100, Andrew Lunn wrote: > On Wed, Feb 06, 2019 at 10:10:40AM -0800, Moritz Fischer wrote: > > Fix fixed_phy not checking GPIO if no link_update callback > > is registered. > > > > Signed-off-by: Moritz Fischer > > --- > > > > Hi all, > > > > I've

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread David Miller
From: Ian Kumlien Date: Wed, 6 Feb 2019 23:12:53 +0100 > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking things Its... there: https://patchwork.ozlabs.org/bundle/davem/stable/?series=&submitter=&state=*&q=&archive=

Re: [PATCH net-next v4 00/12] net: Introduce ndo_get_port_parent_id()

2019-02-06 Thread David Miller
From: David Miller Date: Wed, 06 Feb 2019 13:50:50 -0800 (PST) > From: Florian Fainelli > Date: Wed, 6 Feb 2019 09:45:34 -0800 > >> Based on discussion with Ido and feedback from Jakub there are clearly >> two classes of users that implement SWITCHDEV_ATTR_ID_PORT_PARENT_ID: >> >> - PF/VF dri

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread Ian Kumlien
On Wed, Feb 6, 2019 at 11:03 PM David Miller wrote: > From: Saeed Mahameed > Date: Wed, 6 Feb 2019 17:18:55 + > > On Wed, 2019-02-06 at 17:16 +0100, Ian Kumlien wrote: > >> Hi, > >> > >> I'm hitting an issue that i think is fixed by the following patch, > >> i haven't verified it yet - but i

Re: [PATCH net] net: dsa: Fix NULL checking in dsa_slave_set_eee()

2019-02-06 Thread David Miller
From: Dan Carpenter Date: Wed, 6 Feb 2019 18:35:15 +0300 > This function can't succeed if dp->pl is NULL. It will Oops inside the > call to return phylink_ethtool_get_eee(dp->pl, e); > > Fixes: 1be52e97ed3e ("dsa: slave: eee: Allow ports to use phylink") > Signed-off-by: Dan Carpenter Applied

Re: [ISSUE][4.20.6] mlx5 and checksum failures

2019-02-06 Thread David Miller
From: Saeed Mahameed Date: Wed, 6 Feb 2019 17:18:55 + > On Wed, 2019-02-06 at 17:16 +0100, Ian Kumlien wrote: >> Hi, >> >> I'm hitting an issue that i think is fixed by the following patch, >> i haven't verified it yet - but it looks like it should go on the >> stable queue(?) >> >> (And ye

Re: [PATCH net-next] net: phy: fixed_phy: Fix fixed_phy not checking GPIO

2019-02-06 Thread Andrew Lunn
On Wed, Feb 06, 2019 at 10:10:40AM -0800, Moritz Fischer wrote: > Fix fixed_phy not checking GPIO if no link_update callback > is registered. > > Signed-off-by: Moritz Fischer > --- > > Hi all, > > I've been trying to figure out where exactly this broke, > it must've been somewhere when the fil

Re: [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation

2019-02-06 Thread Christian Lamparter
On Tuesday, February 5, 2019 11:29:36 PM CET Florian Fainelli wrote: > On 2/5/19 2:12 PM, Christian Lamparter wrote: > > On Tuesday, February 5, 2019 10:29:34 PM CET Andrew Lunn wrote: > >>> For now, I added the DT binding update to the patch as well. > >>> But if this is indeed the way to go, it'l

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Julien Gomes
On 2/6/19 1:48 PM, Julien Gomes wrote: > > > On 2/6/19 1:39 PM, Neil Horman wrote: >> On Wed, Feb 06, 2019 at 01:26:55PM -0800, Julien Gomes wrote: >>> >>> >>> On 2/6/19 1:07 PM, Marcelo Ricardo Leitner wrote: On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > > >

Re: [RFC net-next] net: fixed_phy: Move the DT based link GPIO parsing to of_mdio.c

2019-02-06 Thread Andrew Lunn
On Wed, Feb 06, 2019 at 12:51:06PM -0800, Moritz Fischer wrote: > Move the DT based link GPIO parsing to of_mdio and let the places > that register a fixed_phy pass in a GPIO descriptor or NULL. > > This allows fixed_phy on non-DT platforms to have link GPIOs, too. > > Signed-off-by: Moritz Fisch

Re: [PATCH net-next v4 00/12] net: Introduce ndo_get_port_parent_id()

2019-02-06 Thread David Miller
From: Florian Fainelli Date: Wed, 6 Feb 2019 09:45:34 -0800 > Based on discussion with Ido and feedback from Jakub there are clearly > two classes of users that implement SWITCHDEV_ATTR_ID_PORT_PARENT_ID: > > - PF/VF drivers which typically only implement return the port's parent > ID, yet ha

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Julien Gomes
On 2/6/19 1:23 PM, Neil Horman wrote: > On Wed, Feb 06, 2019 at 07:07:23PM -0200, Marcelo Ricardo Leitner wrote: >> On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: >>> >>> >>> On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien G

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Julien Gomes
On 2/6/19 1:39 PM, Neil Horman wrote: > On Wed, Feb 06, 2019 at 01:26:55PM -0800, Julien Gomes wrote: >> >> >> On 2/6/19 1:07 PM, Marcelo Ricardo Leitner wrote: >>> On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: >>>

Re: [PATCH v2] arm64: dts: lx2160aqds: Add mdio mux nodes

2019-02-06 Thread Andrew Lunn
> > > > &i2c0 { > > > > status = "okay"; > > > > > > > > + fpga@66 { > > > > + compatible = "fsl,lx2160aqds-fpga", > > > > "fsl,fpga-qixis-i2c"; > > > > + reg = <0x66>; > > > > + #address-cells = <1>; > > > > + #size-cells = <0

Re: [PATCH net-next] cxgb4: Update 1.22.9.0 as the latest firmware supported.

2019-02-06 Thread David Miller
From: Vishal Kulkarni Date: Wed, 6 Feb 2019 18:31:36 +0530 > Change t4fw_version.h to update latest firmware version > number to 1.22.9.0. > > Signed-off-by: Vishal Kulkarni Applied.

  1   2   3   4   >