Hi Dan, Wolfgang,
On 1/10/2019 1:14 PM, Wolfgang Grandegger wrote:
Hello Dan,
sorry for my late response on that topic...
Am 09.01.19 um 21:58 schrieb Dan Murphy:
Wolfgang
On 11/3/18 5:45 AM, Wolfgang Grandegger wrote:
Hello Dan,
Am 31.10.2018 um 21:15 schrieb Dan Murphy:
Wolfgang
Thanks
Hello Dan,
sorry for my late response on that topic...
Am 09.01.19 um 21:58 schrieb Dan Murphy:
> Wolfgang
>
> On 11/3/18 5:45 AM, Wolfgang Grandegger wrote:
>> Hello Dan,
>>
>> Am 31.10.2018 um 21:15 schrieb Dan Murphy:
>>> Wolfgang
>>>
>>> Thanks for the review
>>>
>>> On 10/27/2018 09:19 AM,
Hi,
I have a setup in which VMs are connected with macvtap to the network. The
macvtap interfaces are attached to a physical NIC.
There is a question if it is possible to hot-unplug - hot-plug the physical
NIC and retain the VMs connectivity to the network (of course with some
hiccup for the unpl
From: wenxu
In the forward chain the iif is changed from slave device to master vrf
device. It will lead the offload not match on lower slave device.
This patch the flow table iif and oif based on route cache dst->dev, not
the skb->iif
This patch make the flollowing example can work correct
i
On Thu, Jan 10, 2019 at 07:29:17AM +0100, Greg Kroah-Hartman wrote:
> The L2CAP_CONF_EFS and L2CAP_CONF_RFC messages can be sent from
> userspace so their structure sizes need to be checked before parsing
> them.
>
> Based on a patch from Ran Menscher.
Ran, can you verify if these two patches sol
The L2CAP_CONF_EFS and L2CAP_CONF_RFC messages can be sent from
userspace so their structure sizes need to be checked before parsing
them.
Based on a patch from Ran Menscher.
Reported-by: Ran Menscher
Signed-off-by: Greg Kroah-Hartman
---
net/bluetooth/l2cap_core.c | 12
1 file ch
l2cap_get_conf_opt can handle a "default" message type, but it needs to
be verified that it really is the correct type (CONF_EFS or CONF_RFC)
before passing it back to the caller. To do this we need to check the
return value of this call now and handle the error correctly up the
stack.
Based on a
On Wed, Jan 9, 2019 at 4:48 PM Ian Kumlien wrote:
>
> Hi,
>
> Just been trough ~5+ hours of bisecting and eventually actually found
> the culprit =)
>
> commit fb420d5d91c1274d5966917725e71f27ed092a85 (refs/bisect/bad)
> Author: Eric Dumazet
> Date: Fri Sep 28 10:28:44 2018 -0700
>
> tcp/fq
On Thursday 10 January 2019 10:36 AM, Keerthy wrote:
>
>
> On Thursday 10 January 2019 03:06 AM, Tony Lindgren wrote:
>> Hi,
>>
>> * Heiner Kallweit [190109 19:28]:
>>> On 09.01.2019 20:06, Tony Lindgren wrote:
Commit 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") caused
A recent commit in Clang expanded the -Wstring-plus-int warning, showing
some odd behavior in this file.
drivers/isdn/hardware/avm/b1.c:426:30: warning: adding 'int' to a string does
not append to the string [-Wstring-plus-int]
cinfo->version[j] = "\0\0" + 1;
On 04-01-2019 14:04, Steffen Klassert wrote:
> On Thu, Jan 03, 2019 at 04:16:56PM +0530, Harsh Jain wrote:
>> On 02-01-2019 18:21, Herbert Xu wrote:
>>> Does this occur if you use software crypto on the receiving end
>>> while keeping the sending end unchanged?
>> I tried with "authencesn(hmac(sh
From: wenxu
This patch allows us to match on the tunnel metadata that is available
of the packet. We can use this to validate if the packet comes from/goes
to tunnel and the corresponding tunnel ID in the iptables.
Signed-off-by: wenxu
---
include/uapi/linux/netfilter/xt_tunnel.h | 12 +++
On 1/10/2019 12:05 PM, wenxu wrote:
> On 1/10/2019 12:41 AM, Pablo Neira Ayuso wrote:
>> On Fri, Dec 21, 2018 at 06:12:24PM +0800, we...@ucloud.cn wrote:
>> [...]
>>> +static struct xt_match tunnel_mt_reg __read_mostly = {
>>> + .name = "tunnel",
>>> + .revision = 0,
>>> + .
Clang warns:
In file included from drivers/net/ethernet/intel/iavf/iavf_main.c:4:
In file included from drivers/net/ethernet/intel/iavf/iavf.h:37:
In file included from drivers/net/ethernet/intel/iavf/iavf_type.h:8:
drivers/net/ethernet/intel/iavf/iavf_osdep.h:49:18: warning: 'format' attribute
a
On 1/10/2019 12:41 AM, Pablo Neira Ayuso wrote:
> On Fri, Dec 21, 2018 at 06:12:24PM +0800, we...@ucloud.cn wrote:
> [...]
>> +static struct xt_match tunnel_mt_reg __read_mostly = {
>> +.name = "tunnel",
>> +.revision = 0,
>> +.family = NFPROTO_UNSPEC,
>> +
We forgot to update ip6erspan version related info when changing link,
which will cause setting new hwid failed.
Reported-by: Jianlin Shi
Fixes: 94d7d8f292870 ("ip6_gre: add erspan v2 support")
Signed-off-by: Hangbin Liu
---
net/ipv6/ip6_gre.c | 4
1 file changed, 4 insertions(+)
diff --g
On 1/9/19 11:21 AM, Song Liu wrote:
> For better performance analysis of BPF programs, this patch introduces
> PERF_RECORD_BPF_EVENT, a new perf_event_type that exposes BPF program
> load/unload information to user space.
>
> Each BPF program may contain up to BPF_MAX_SUBPROGS (256) sub programs.
On Wed, Jan 09, 2019 at 11:35:52AM +0100, Miguel Ojeda wrote:
> On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers
> wrote:
> >
> > Also for more context, see:
> > commit 7829fb09a2b4 ("lib: make memzero_explicit more robust against
> > dead store elimination")
>
> By the way, shouldn't that barrie
> > I just looked at your regmap code and you use 3 regmap pointers for
> specific 8-bit, 16-bit, and 32-bit accesses. The switch access is always
> 8-bit. It
> has automatic register increment so that you can access arbitrary length of
> registers. The use of 16-bit and 32-bit accesses makes a
On Wed, Jan 9, 2019 at 10:39 AM Emmanuel Grumbach wrote:
>
> Hello,
>
> > > > >
> > > > > our hardware teams from the Bluetooth and WiFi side really need to
> > > > > look at this.
> > >
> > > Were you able to get attention from the hardware teams with the logs
> > > I've provided? Are there any
On 1/9/19 8:58 PM, tristram...@microchip.com wrote:
>> This is the regmap_config I used in Linux 4.9:
>>
>> .reg_bits = SPI_REGMAP_REG,
>> .val_bits = SPI_REGMAP_VAL,
>> .pad_bits = SPI_REGMAP_PAD,
>> .read_flag_mask = KS_SPIOP_RD << SPI
On 1/9/19 8:08 PM, tristram...@microchip.com wrote:
> + { \
> + .val_bits = (width),\
> + .reg_stride = (width) / 8, \
> + .reg_bits
Hi,
Just been trough ~5+ hours of bisecting and eventually actually found
the culprit =)
commit fb420d5d91c1274d5966917725e71f27ed092a85 (refs/bisect/bad)
Author: Eric Dumazet
Date: Fri Sep 28 10:28:44 2018 -0700
tcp/fq: move back to CLOCK_MONOTONIC
[--8<--]
So this might be because my
On Sat, Dec 29, 2018 at 06:10:25PM +0800, we...@ucloud.cn wrote:
> From: wenxu
>
> In the forward chain the iif is changed from slave device to master vrf
> device. It will lead the offload not match on lower slave device.
>
> This patch make the flollowing example can work correct
>
> ip addr
Confirmed, sending a new mail with summary etc
On Thu, Jan 10, 2019 at 1:16 AM Ian Kumlien wrote:
>
> On Wed, Jan 9, 2019 at 12:17 AM Ian Kumlien wrote:
> > On Wed, Jan 9, 2019, 00:09 Florian Fainelli
> [--8<---]
>
> >> > when looking at "git log v4.19...v4.20
> >> > drivers/net/ethernet/intel
On Wed, Jan 9, 2019 at 12:17 AM Ian Kumlien wrote:
> On Wed, Jan 9, 2019, 00:09 Florian Fainelli > > when looking at "git log v4.19...v4.20
>> > drivers/net/ethernet/intel/ixgbe/" nothing else really stands out...
>> > The machine is also running NAT for my home network and all of that
>> > works
Found by scripts/checkpatch.pl
---
net/vmw_vsock/af_vsock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index 43a1dec08825..a60df252d3cc 100644
--- a/net/vmw_vsock/af_vsock.c
+++ b/net/vmw_vsock/af_vsock.c
@@ -505,7 +505,7
On Wed, Jan 9, 2019 at 5:07 PM Ioana Ciornei wrote:
>
> Use optind as index for argv instead of a hardcoded value.
> When the program has options this leads to improper parameter handling.
>
> Fixes: dc378a1ab5b6 ("samples: bpf: get ifindex from ifname")
>
> Signed-off-by: Ioana Ciornei
> ---
>
On Tue, Jan 08, 2019 at 06:12:24PM -0800, Yuchung Cheng wrote:
> The existing BPF TCP initial congestion window (TCP_BPF_IW) does not
> to work on (active) Fast Open sender. This is because it changes the
> (initial) window only if data_segs_out is zero -- but data_segs_out
> is also incremented on
On 1/8/19, 6:13 PM, "netdev-ow...@vger.kernel.org on behalf of Yuchung Cheng"
wrote:
The existing BPF TCP initial congestion window (TCP_BPF_IW) does not
to work on (active) Fast Open sender. This is because it changes the
(initial) window only if data_segs_out is zero -- but data_se
On Wed, Jan 9, 2019 at 10:31 AM Heiner Kallweit wrote:
>
> On 09.01.2019 08:20, Frank Wunderlich wrote:
> > From: Heiner Kallweit
> >
> > linux 5.0-rc1 shows following warning on bpi-r2/mt7623 bootup:
> >
> > [ 5.170597] WARNING: CPU: 3 PID: 1 at drivers/net/phy/phy.c:548
> > phy_start_aneg+0x11
On Wed, Dec 26, 2018 at 12:16:25PM +0300, Kirill Tkhai wrote:
> On 26.12.2018 06:50, Kangjie Lu wrote:
> > When nla_parse fails, we should not use the results (the first
> > argument). The fix checks if it fails, and if so, returns its error code
> > upstream.
> >
> > Signed-off-by: Kangjie Lu
>
On 09.01.2019 22:36, Tony Lindgren wrote:
> Hi,
>
> * Heiner Kallweit [190109 19:28]:
>> On 09.01.2019 20:06, Tony Lindgren wrote:
>>> Commit 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") caused
>>> a regression where suspend resume cycle fails to bring up Ethernet on at
>>> least cps
On 8/31/2018 10:49 AM, Brian Rak wrote:
We've upgraded a few machines to a 4.18.3 kernel and we're running
into weird IPv6 neighbor discovery issues. Basically, the machines
stop responding to inbound IPv6 neighbor solicitation requests, which
very quickly breaks all IPv6 connectivity.
It
Hi,
* Heiner Kallweit [190109 19:28]:
> On 09.01.2019 20:06, Tony Lindgren wrote:
> > Commit 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") caused
> > a regression where suspend resume cycle fails to bring up Ethernet on at
> > least cpsw on am437x-sk-evm.
> >
> What kind of PHY and w
Quoting Heiner Kallweit (2019-01-09 19:34:56)
> When adding checks to detect wrong usage of the phylib API we added
> a check to phy_start_aneg() which is too strict. If the phylib
> state machine is in state PHY_HALTED we should allow reconfiguring
> and restarting aneg, and just don't touch the s
Wolfgang
On 11/3/18 5:45 AM, Wolfgang Grandegger wrote:
> Hello Dan,
>
> Am 31.10.2018 um 21:15 schrieb Dan Murphy:
>> Wolfgang
>>
>> Thanks for the review
>>
>> On 10/27/2018 09:19 AM, Wolfgang Grandegger wrote:
>>> Hello Dan,
>>>
>>> for the RFC, could you please just do the necessary changes t
> This is the regmap_config I used in Linux 4.9:
>
> .reg_bits = SPI_REGMAP_REG,
> .val_bits = SPI_REGMAP_VAL,
> .pad_bits = SPI_REGMAP_PAD,
> .read_flag_mask = KS_SPIOP_RD << SPI_REGMAP_MASK_S,
> .write_flag_mask= KS_
Add reference to scaling document into main table of contents in network
documentation.
Signed-off-by: Otto Sabart
---
Documentation/networking/index.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/networking/index.rst
b/Documentation/networking/index.rst
index 6a47629ef8e
Just rename the scaling file to be found by Sphinx.
There are no references to "scaling.txt" file. Whole kernel tree was
checked using:
$ grep -r "scaling\.txt"
Signed-off-by: Otto Sabart
---
Documentation/networking/{scaling.txt => scaling.rst} | 0
1 file changed, 0 insertions(+), 0 deletions
Add markups which are necessary for successful conversion into
reStructuredText.
There are no semantic changes.
Signed-off-by: Otto Sabart
---
Documentation/networking/scaling.txt | 131 +--
1 file changed, 85 insertions(+), 46 deletions(-)
diff --git a/Documentation/ne
These patches integrate scaling document into documentation tree.
There are no semantic changes.
Otto Sabart (3):
doc: networking: prepare scaling document for conversion into RST
doc: networking: convert scaling doc into RST
doc: networking: add scaling doc into index file
Documentation/
On 1/9/19 2:57 AM, Ido Schimmel wrote:
> IPv4 routing tables are flushed in two cases:
>
> 1. In response to events in the netdev and inetaddr notification chains
> 2. When a network namespace is being dismantled
>
> In both cases only routes associated with a dead nexthop group are
> flushed. Ho
On 09.01.2019 14:11, Chris Wilson wrote:
> Hi, we've hit a snag with
>
> commit 2b3e88ea65287ba738a798622405b15344871085
> Author: Heiner Kallweit
> Date: Sun Dec 16 18:30:14 2018 +0100
>
> net: phy: improve phy state checking
>
> as it is detecting that the call from tg3 during suspend i
When adding checks to detect wrong usage of the phylib API we added
a check to phy_start_aneg() which is too strict. If the phylib
state machine is in state PHY_HALTED we should allow reconfiguring
and restarting aneg, and just don't touch the state.
Fixes: 2b3e88ea6528 ("net: phy: improve phy sta
On 09.01.2019 20:06, Tony Lindgren wrote:
> Hi all,
>
> Commit 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") caused
> a regression where suspend resume cycle fails to bring up Ethernet on at
> least cpsw on am437x-sk-evm.
>
What kind of PHY and which PHY driver is used with this board
Hi Florian,
Just a few more comments...
On 1/8/19 8:39 PM, Florian Fainelli wrote:
> This patch provides details on the expected behavior of switchdev
> enabled network devices when operating in a "stand alone" mode, as well
> as when being bridge members. This clarifies a number of things that
This patch synthesize PERF_RECORD_KSYMBOL and PERF_RECORD_BPF_EVENT for
BPF programs loaded before perf-record. This is achieved by gathering
information about all BPF programs via sys_bpf.
Signed-off-by: Song Liu
---
tools/perf/builtin-record.c | 6 ++
tools/perf/util/bpf-event.c | 205 ++
sync changes for PERF_RECORD_KSYMBOL
Signed-off-by: Song Liu
---
tools/include/uapi/linux/perf_event.h | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/tools/include/uapi/linux/perf_event.h
b/tools/include/uapi/linux/perf_event.h
index 9de8780ac8d9.
For better performance analysis of dynamically JITed and loaded kernel
functions, such as BPF programs, this patch introduces
PERF_RECORD_KSYMBOL, a new perf_event_type that exposes kernel symbol
register/unregister information to user space.
The following data structure is used for PERF_RECORD_KS
This patch handles PERF_RECORD_KSYMBOL in perf record/report.
Specifically, map and symbol are created for ksymbol register, and
removed for ksymbol unregister.
This patch also set perf_event_attr.ksymbol properly. The flag is
ON by default.
Signed-off-by: Song Liu
---
tools/perf/util/event.c
sync for PERF_RECORD_BPF_EVENT
Signed-off-by: Song Liu
---
tools/include/uapi/linux/perf_event.h | 29 ++-
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/tools/include/uapi/linux/perf_event.h
b/tools/include/uapi/linux/perf_event.h
index 68c4da0227c5..8bd7
This set catches symbol for all bpf programs loaded/unloaded
before/during/after perf-record run PERF_RECORD_KSYMBOL and
PERF_RECORD_BPF_EVENT.
PERF_RECORD_KSYMBOL and PERF_RECORD_BPF_EVENT includes key information
of a bpf program load and unload. They are sent through perf ringbuffer,
and stored
This patch adds basic handling of PERF_RECORD_BPF_EVENT.
Tracking of PERF_RECORD_BPF_EVENT is OFF by default. Option --bpf-event
is added to turn it on.
Signed-off-by: Song Liu
---
tools/perf/builtin-record.c | 1 +
tools/perf/perf.h | 1 +
tools/perf/util/Build | 2 ++
tools/
For better performance analysis of BPF programs, this patch introduces
PERF_RECORD_BPF_EVENT, a new perf_event_type that exposes BPF program
load/unload information to user space.
Each BPF program may contain up to BPF_MAX_SUBPROGS (256) sub programs.
The following example shows kernel symbols for
> >>> + { \
> >>> + .val_bits = (width),\
> >>> + .reg_stride = (width) / 8, \
> >>> + .reg_bits = (regbits) + (regalign), \
> >
Hi all,
Commit 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") caused
a regression where suspend resume cycle fails to bring up Ethernet on at
least cpsw on am437x-sk-evm.
Keerthy noticed this may not happen on the first resume, but usually
happens after few suspend resume cycles. The m
On Wed, Jan 09, 2019 at 08:03:58PM +0100, Pablo Neira Ayuso wrote:
> On Wed, Jan 09, 2019 at 10:40:11AM +0800, we...@ucloud.cn wrote:
> > From: wenxu
> >
> > For nat example:
> > client 1.1.1.7 ---> 2.2.2.7 which dnat to 10.0.0.7 server
> >
> > When syn_rcv pkt from server it get the peer(client
On Wed, Jan 09, 2019 at 10:40:11AM +0800, we...@ucloud.cn wrote:
> From: wenxu
>
> For nat example:
> client 1.1.1.7 ---> 2.2.2.7 which dnat to 10.0.0.7 server
>
> When syn_rcv pkt from server it get the peer(client->server) route
> through daddr = ct->tuplehash[!dir].tuple.dst.u3.ip, the value
On Wed, Jan 09, 2019 at 09:43:52PM +0300, Maxim Uvarov wrote:
> Is this errata documented somewhere? What happends without that magic
> wirtes? Software reset doen't clear registers into initial state?
Hi Max
Marvell have documentation for it. From what i understand, if the PHY
establishes link w
Is this errata documented somewhere? What happends without that magic
wirtes? Software reset doen't clear registers into initial state?
Max.
ср, 9 янв. 2019 г. в 02:40, Andrew Lunn :
>
> The 6390 copper ports have an errata which require poking magic values
> into undocumented magic registers and
Hello,
> > > >
> > > > our hardware teams from the Bluetooth and WiFi side really need to look
> > > > at this.
> >
> > Were you able to get attention from the hardware teams with the logs
> > I've provided? Are there any news or an idea of when / if we can
> > expect this to be fixed in firmware
On 09.01.2019 08:20, Frank Wunderlich wrote:
> From: Heiner Kallweit
>
> linux 5.0-rc1 shows following warning on bpi-r2/mt7623 bootup:
>
> [ 5.170597] WARNING: CPU: 3 PID: 1 at drivers/net/phy/phy.c:548
> phy_start_aneg+0x110/0x144
> [ 5.178826] called from state READY
>
> [ 5.264111] []
This reverts commit 59361316afcb08569af21e1af83e89c7051c055a.
Due to problems found in additional testing, this causes an illegal
context switch in the RCU read-side critical section.
CC: Dave Jones
CC: Cong Wang
CC: Jan Jablonsky
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/ig
Use optind as index for argv instead of a hardcoded value.
When the program has options this leads to improper parameter handling.
Fixes: dc378a1ab5b6 ("samples: bpf: get ifindex from ifname")
Signed-off-by: Ioana Ciornei
---
samples/bpf/xdp1_user.c | 2 +-
1 file changed, 1 insertion(+), 1 del
On Mon, 2019-01-07 at 18:34 -0800, Cong Wang wrote:
> On Mon, Jan 7, 2019 at 11:19 AM Dave Jones
> wrote:
> > [ 32.845071] =
> > [ 32.845084] WARNING: suspicious RCU usage
> > [ 32.845098] 5.0.0-rc1-backup+ #1 Not tainted
> > [ 32.845111] ---
On Fri, Dec 21, 2018 at 06:12:24PM +0800, we...@ucloud.cn wrote:
[...]
> +static struct xt_match tunnel_mt_reg __read_mostly = {
> + .name = "tunnel",
> + .revision = 0,
> + .family = NFPROTO_UNSPEC,
> + .match = tunnel_mt,
> + .matchsize =
On 1/9/19 5:05 PM, Pavel Machek wrote:
> On Wed 2018-12-19 22:50:16, tristram...@microchip.com wrote:
>>> This header file makes no sense. Please move the functions into .c
>>
>> No, that would make code bigger & slower.
>>
>> It makes sense to me. But I'd add "inline" keyword t
There are now several places where qdisc_tree_reduce_backlog() is called
with a negative number of packets (to signal an increase in number of
packets in the queue). Rather than rely on overflow behaviour, change the
function signature to use signed integers to communicate this usage to
people read
To ensure parent qdiscs have the same notion of the number of enqueued
packets even after splitting a GSO packet, update the qdisc tree with the
number of packets that was added due to the split.
Reported-by: Pete Heist
Tested-by: Pete Heist
Signed-off-by: Toke Høiland-Jørgensen
---
net/sched/
Several qdiscs check on enqueue whether the packet was enqueued to a class
with an empty queue, in which case the class is activated. This is done by
checking if the qlen is exactly 1 after enqueue. However, if GSO splitting
is enabled in the child qdisc, a single packet can result in a qlen longer
Parent qdiscs may dereference the pointer to the enqueued skb after
enqueue. However, both CAKE and TBF call consume_skb() on the original skb
when splitting GSO packets, leading to a potential use-after-free in the
parent. Fix this by avoiding dereferencing the skb pointer after enqueueing
to the
This series fixes a couple of issues exposed by running sch_cake as a
leaf qdisc in an HFSC tree, which were discovered and reported by Pete
Heist. The interaction between CAKE's GSO splitting and the parent
qdisc's notion of its own queue length could cause queue stalls. While
investigating the re
On Wed 2018-12-19 22:50:16, tristram...@microchip.com wrote:
> > This header file makes no sense. Please move the functions into .c
> > >>>
> > >>> No, that would make code bigger & slower.
> > >>>
> > >>> It makes sense to me. But I'd add "inline" keyword to make the goal
> > >>> explicit.
>
> On Jan 9, 2019, at 4:59 AM, Peter Zijlstra wrote:
>
> On Wed, Jan 09, 2019 at 11:32:50AM +, Song Liu wrote:
>> I was thinking about modifying the text in-place scenario. In this case,
>> we can use something like
>>
>> struct perf_record_text_modify {
>>u64 addr;
>>u_big_enough
> On Jan 9, 2019, at 4:41 AM, Peter Zijlstra wrote:
>
> On Tue, Jan 08, 2019 at 08:45:19PM +, Alexei Starovoitov wrote:
>> On 1/8/19 12:29 PM, Peter Zijlstra wrote:
>>> On Thu, Dec 20, 2018 at 10:29:00AM -0800, Song Liu wrote:
The following example shows kernel symbols for a BPF progr
On Wed, Jan 09, 2019 at 04:09:02PM +1100, Benjamin Herrenschmidt wrote:
> > POWER 8 firmware is good? If the link does eventually come back, is
> > the POWER8's D3 resumption timeout long enough?
> >
> > If this doesn't lead to an obvious conclusion you'll probably need to
> > connect to IBM's Me
The check assumes that in transport mode, the first templates family
must match the address family of the policy selector.
Syzkaller managed to build a template using MODE_ROUTEOPTIMIZATION,
with ipv4-in-ipv6 chain, leading to following splat:
BUG: KASAN: stack-out-of-bounds in xfrm_state_find+0x
On Wed, Jan 09, 2019 at 11:35:52AM +0100, Miguel Ojeda wrote:
> On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers
> wrote:
> >
> > Also for more context, see:
> > commit 7829fb09a2b4 ("lib: make memzero_explicit more robust against
> > dead store elimination")
>
> By the way, shouldn't that barrie
On Wed, Jan 09, 2019 at 08:55:14AM -0500, Willem de Bruijn wrote:
> > In other words: because the socket needs to be ESTABLISHED for
> > MSG_ZEROCOPY to work, and because remote party can send FIN and move
> > the socket to CLOSE_WAIT, a sending party must implement a fallback
> > from EINVAL retur
On Wed, Jan 09, 2019 at 04:05:28PM +0800, Jason Wang wrote:
> Signed-off-by: Jason Wang
> ---
> include/uapi/linux/virtio_config.h | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/uapi/linux/virtio_config.h
> b/include/uapi/linux/virtio_config.h
> index 1196e1c1d4f6..2698e
On Wed, Jan 09, 2019 at 03:29:47PM +0800, Jason Wang wrote:
> Vhost dirty page logging API is designed to sync through GPA. But we
> try to log GIOVA when device IOTLB is enabled. This is wrong and may
> lead to missing data after migration.
>
> To solve this issue, when logging with device IOTLB
Hi Madalin,
> > > Thanks a lot for the info, will look into this. Do you have any
> > > pointers as to why the full page restriction exists in the first
> > > place? Sorry if it's a dumb question, but I haven't found details on
> > > this and I'd really like to understand it.
> >
> > Hi Ioana,
>
> -Original Message-
> From: netdev-ow...@vger.kernel.org On
> Behalf Of Jesper Dangaard Brouer
> Sent: Friday, December 21, 2018 5:31 PM
> To: Ioana Ciocoi Radulescu
> Cc: Ilias Apalodimas ;
> netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei
> ; dsah...@gmail.com; Camelia Alexa
On Wed, Jan 9, 2019 at 7:50 AM Marek Majkowski wrote:
>
> I got it slightly wrong, and it's even worse than this. As far as I
> understand it, the current semantics of MSG_ZEROCOPY on TCP make it
> close to unusable. The problem is that the remote party can move your
> MSG_ZEROCOPY socket from EST
On Wed, Jan 9, 2019 at 5:52 AM Dan Carpenter wrote:
>
> This should be == instead of =.
>
> Fixes: b52354aa068e ("selftests: expand txtimestamp with ipv6 dgram + raw and
> pf_packet")
> Signed-off-by: Dan Carpenter
Acked-by: Willem de Bruijn
Thanks for the fix, Dan.
On Tue, Jan 8, 2019 at 11:00 PM David Miller wrote:
>
>
> Willem, this was an empty reply to your own patch.
>
> Were you trying to say something that I should know?
I corrected a typo in Eric's email address. Sorry for the confusing
email, David. Should have added a short comment (and Eric proba
Hi, we've hit a snag with
commit 2b3e88ea65287ba738a798622405b15344871085
Author: Heiner Kallweit
Date: Sun Dec 16 18:30:14 2018 +0100
net: phy: improve phy state checking
as it is detecting that the call from tg3 during suspend is from the
HALTED state.
<4> [74.170194] [ cut
On Sat, Jan 05, 2019 at 10:59:08AM +0100, Florian Westphal wrote:
> Cong Wang wrote:
> > > - hlist_for_each_entry(tmp, &node->hhead, bydst)
> > > - tmp->bydst_reinsert = true;
> > > - hlist_for_each_entry(tmp, &n->hhead, byd
On Wed, Jan 09, 2019 at 11:32:50AM +, Song Liu wrote:
> I was thinking about modifying the text in-place scenario. In this case,
> we can use something like
>
> struct perf_record_text_modify {
> u64 addr;
> u_big_enough old_instr;
> u_big_enough new_instr;
char[15] for x86 ;-)
I got it slightly wrong, and it's even worse than this. As far as I
understand it, the current semantics of MSG_ZEROCOPY on TCP make it
close to unusable. The problem is that the remote party can move your
MSG_ZEROCOPY socket from ESTABLISHED to CLOSE_WAIT without your
involvement. This will mean t
On Tue, Jan 08, 2019 at 08:45:19PM +, Alexei Starovoitov wrote:
> On 1/8/19 12:29 PM, Peter Zijlstra wrote:
> > On Thu, Dec 20, 2018 at 10:29:00AM -0800, Song Liu wrote:
> >> The following example shows kernel symbols for a BPF program with 7
> >> sub programs:
> >>
> >> a0257cf9 t
On 2019/1/9 下午4:05, Jason Wang wrote:
Hi:
This series implement basic in order feature support for
vhost_net. This feature requires both driver and device to use
descriptors in order which can simplify the implementation and
optimizaton for both side. The series also implement a simple
optimiz
Hi,
Current implementation of MSG_ZEROCOPY for TCP requires the socket to
be ESTABLISHED:
https://elixir.bootlin.com/linux/v5.0-rc1/source/net/ipv4/tcp.c#L1188
if (sk->sk_state != TCP_ESTABLISHED) {
err = -EINVAL;
goto out_err;
}
In TCP it's totally fine to have half-open sockets, for ex
> On Jan 9, 2019, at 2:18 AM, Peter Zijlstra wrote:
>
> On Tue, Jan 08, 2019 at 11:54:04PM +, Song Liu wrote:
>
>> I think Intel PT case is at instruction granularity (instead of ksymbol
>> granularity)?
>
> Yes.
>
>> If this is true, modules, BPF, and PT could still share
>> the ksymb
Arend Van Spriel writes:
> On 1/8/2019 5:43 PM, Kalle Valo wrote:
>> Kangjie Lu writes:
>>
>>> usb_register() may fail, so let's check its status and issue an error
>>> message if it fails.
>>>
>>> Signed-off-by: Kangjie Lu
>>> ---
>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c |
This should be == instead of =.
Fixes: b52354aa068e ("selftests: expand txtimestamp with ipv6 dgram + raw and
pf_packet")
Signed-off-by: Dan Carpenter
---
tools/testing/selftests/networking/timestamping/txtimestamp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/test
On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers wrote:
>
> Also for more context, see:
> commit 7829fb09a2b4 ("lib: make memzero_explicit more robust against
> dead store elimination")
By the way, shouldn't that barrier_data() be directly in compiler.h
too, since it is for both gcc & clang?
> Re
On Tue, Jan 08, 2019 at 11:54:04PM +, Song Liu wrote:
> I think Intel PT case is at instruction granularity (instead of ksymbol
> granularity)?
Yes.
> If this is true, modules, BPF, and PT could still share
> the ksymbol record for basic profiling. And advanced use cases like
> annotation
In changelink ops, the ip6gre_net pointer is retrieved from
dev_net(dev), which is wrong in case of x-netns. Thus, the tunnel is not
unlinked from its current list and is relinked into another net
namespace. This corrupts the tunnel lists and can later trigger a kernel
oops.
Fix this by retrieving
1 - 100 of 118 matches
Mail list logo
